build: enable C++20

Elsewhere, all of our C++ repositories have updated to C++20. Enable
it here as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39ef53e7b41acd2f6b16070e35

build: enable C++20

Elsewhere, all of our C++ repositories have updated to C++20. Enable
it here as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39ef53e7b41acd2f6b16070e3533006d6b4dadeb

show more ...

configure: Default-enable virtual pnor

I'm tired of the lack of CI coverage, and I have to care about it.

Rework the README to reflect the change in default behaviour.

Chan

configure: Default-enable virtual pnor

I'm tired of the lack of CI coverage, and I have to care about it.

Rework the README to reflect the change in default behaviour.

Change-Id: I883be8bc4e89b755185f9f84f0ebd46a05fee71f
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

autotools: Fix autoconf-archive compatibility issues

autoconf-archive 2019-01-06 changed the setup of code coverage support.
Deal with both old and new. Based on Patrick Venture's simila

autotools: Fix autoconf-archive compatibility issues

autoconf-archive 2019-01-06 changed the setup of code coverage support.
Deal with both old and new. Based on Patrick Venture's similar patch in
other repositories[1].

[1] https://github.com/openbmc/phosphor-pid-control/commit/90e9dbcae6c1df3127dd3de41f9d1e1b5a438828

Change-Id: I29dae544d8feb462e848ab00c25da188f74686a7
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

build: use pkg_check_modules instead of ax_pkg_check_modules

ax_pkg_check_modules provides a wrapper to pkg_check_modules, such that
one can specify private and public dependencies. Thi

build: use pkg_check_modules instead of ax_pkg_check_modules

ax_pkg_check_modules provides a wrapper to pkg_check_modules, such that
one can specify private and public dependencies. This is not used,
therefore use the underlying macro.

Change-Id: I556f9e29da236e069b7a9b69448fb4cbcba7bbe1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ide33a6c67

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ide33a6c676d6b4db07a10aeb35e5076f9b3aeb91
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

configure: put c++ cruft behind virtual pnor check

When building outside of OpenBMC, none of the C++ libraries are
required.

Change-Id: I0677b13c373492977301cd6f1db9753a3a0fcb54

configure: put c++ cruft behind virtual pnor check

When building outside of OpenBMC, none of the C++ libraries are
required.

Change-Id: I0677b13c373492977301cd6f1db9753a3a0fcb54
Signed-off-by: Joel Stanley <joel@jms.id.au>

show more ...

configure: Update from c++14 to c++17

This uses the AX_CXX_COMPILE_STDCXX() instead of
AX_CXX_COMPILE_STDCXX_1{4,7}() so that the error messages we generate
make slightly more sense.

configure: Update from c++14 to c++17

This uses the AX_CXX_COMPILE_STDCXX() instead of
AX_CXX_COMPILE_STDCXX_1{4,7}() so that the error messages we generate
make slightly more sense.

We get errors like:
configure.ac:24: error: invalid first argument `20' to AX_CXX_COMPILE_STDCXX

Instead of:
./configure: line 5132: syntax error near unexpected token `noext'
./configure: line 5132: `AX_CXX_COMPILE_STDCXX_20(noext)'

Tested:
Builds and passes unit tests.

Change-Id: I22f71b4f83fec0507de1175ac656ce63e9acecea
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Unfork phosphor-mboxd from mboxbridge

Change-Id: I1b3b9d7fd47719594c1de027389959a5a9a3ea7a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

configure: Don't enable the virtual PNOR by default

To date, most systems are not configured with the virtual PNOR feature.
Turn it off by default, so only systems that want it enable it

configure: Don't enable the virtual PNOR by default

To date, most systems are not configured with the virtual PNOR feature.
Turn it off by default, so only systems that want it enable it.

See vpnor/README.md to understand whether this is a feature you want for
your system design.

Change-Id: I33f57946444db92a72851c9ce24df6121860b742
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

version: Update version to v2.1.1

The previous patch introduces a backwards compatible bug fix.

Bump the version to reflect this.

Signed-off-by: Suraj Jitindar Singh <sjiti

version: Update version to v2.1.1

The previous patch introduces a backwards compatible bug fix.

Bump the version to reflect this.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: If864822bbe0ef923cae43fda3313f4a43254bf60

show more ...

vpnor: Add patch location

Look for the requested partition in the designated patch location
(/usr/local/share/pnor/). If the partition is not found there,
continue with the existing

vpnor: Add patch location

Look for the requested partition in the designated patch location
(/usr/local/share/pnor/). If the partition is not found there,
continue with the existing logic of looking in the other partition
directories.
This allows users to use patches in the virtual pnor implementation.

Resolves openbmc/openbmc#1551

Change-Id: I7f27dfc9cd69a3f8ab88cb6fa77b2c1096e32841
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Read/write window property defines FFS partition file location.

The BMC loads the PNOR partitions in a read-only volume.

So after that there are following two cases:

Read:

Read/write window property defines FFS partition file location.

The BMC loads the PNOR partitions in a read-only volume.

So after that there are following two cases:

Read: Tries to open the file in read only mode from
the partition(READONLY/READWRITE/PRESERVED), Partition
Table tells the partition type depends on the offset.
if file is not there in the mapped partition
then tries to open the file from the read only partition.

Write: Tries to open the file in write mode from the
partition(READWRITE/PRESERVED), if file is not there
in the mapped partition then mailbox daemon will copy
the requested partition to the read-write volume to
make changes to it.

Change-Id: Ic0ef882380b56536ac55feae3ec563de95fdd4a6
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Add dependency on phosphor logging and sdbusplus

Change-Id: Ie7f6f1806c203ddf46fb8d5a651ebd908ea921cb
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

pnor : generate partition table

Implement a class that, upon construction, generates the virtual PNOR
partition table. The virtual PNOR is typically a subset of the full PNOR
image,

pnor : generate partition table

Implement a class that, upon construction, generates the virtual PNOR
partition table. The virtual PNOR is typically a subset of the full PNOR
image, by choosing partitions of interest.

The generation is based on upon information read from the
PNOR partition files and table of contents (toc) file.

Provide an interface to the virtual PNOR partition table.

Change-Id: I7a68e3833b8cf66e92eb6ca274f6a3c376ce0add
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

autotools: check for C++ compiler

In view of some of the upcoming C++ code, check for the C++ compiler.

Also enable compiling C++14 code.

Change-Id: I7ac587e3b40385845b39f7

autotools: check for C++ compiler

In view of some of the upcoming C++ code, check for the C++ compiler.

Also enable compiling C++14 code.

Change-Id: I7ac587e3b40385845b39f7ae0655227c45ed055b
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Enable conditional compilation flag for virtual pnor

Change-Id: I70e1b1f8d709ce79e0664d5f916115e77427b1e8
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

version: Update to version 2.1.0

Update to package version V2.1.0 to reflect that a backwards compatible
API change was made. This API change was the introduction of the timeout
to t

version: Update to version 2.1.0

Update to package version V2.1.0 to reflect that a backwards compatible
API change was made. This API change was the introduction of the timeout
to the GET_MBOX_INFO command.

This version update also encompasses previous bug fixes.

The versioning scheme is now aligned to semver.

Use the version from config.h for both mboxd and mboxctl instead of an
independant value for the daemon and control programs.

Change-Id: I12d7fe8e40697801594b1727054342613923a784
Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

show more ...

configure: Download aspeed-lpc-ctrl.h if not present

However, don't download it if the file is already present in the local
directory. The AC_CHECK_HEADER macro can't test this case, so

configure: Download aspeed-lpc-ctrl.h if not present

However, don't download it if the file is already present in the local
directory. The AC_CHECK_HEADER macro can't test this case, so the
condition will always trigger if the header isn't installed on the
system.

Change-Id: I7de8ff24823fe2ce54add9a33125cee5ad0b53f0
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

autotools: Add code coverage support

Change-Id: I7d11c64ffa3e68973081cfb1f3fdc1817a64e8cd
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

configure.ac: Update repository URL

Point it to the OpenBMC repository rather than Cyril's personal copy.

Change-Id: I70ead8e871e9f75d0a0f11c3cb4c4ee10b1e79fb
Signed-off-by: And

configure.ac: Update repository URL

Point it to the OpenBMC repository rather than Cyril's personal copy.

Change-Id: I70ead8e871e9f75d0a0f11c3cb4c4ee10b1e79fb
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Update mboxd to implement protocol V2 and add dbus support

Version 2 of the mbox protocol contains a few changes such as:
- All sizes are in block size
- Adds an erase comma

mboxd: Update mboxd to implement protocol V2 and add dbus support

Version 2 of the mbox protocol contains a few changes such as:
- All sizes are in block size
- Adds an erase command
- Adds new response codes
- Adds new BMC events
- Open windows commands now take a size directive

Update the mailbox daemon to support version 2 of the protocol which
includes implementing all of the V2 functionality. Also entirely refactor
the mboxd.c code to make it more modular improving readability and
maintainability.

At the same time improve the functionality by adding:
- Multiple windows in the daemon (still only one active window) to cache
flash contents
- Implement a dbus interface to allow interaction with the daemon
- Handle sigterm and sigint and terminate cleanly

The previous implementation utilised the entire reserved memory region.
Update the daemon so that on the command line the number of windows and
the size of each which the reserved memory region will be split into can
be specified. The reserved memory region is then divided between the
windows, however there can still only be one "active" window at a time.
The daemon uses these windows to cache the flash contents meaning the
flash doesn't have to be copied when the host requests access assuming
the daemon already has a copy.

A dbus interface is added so that commands can be sent to the daemon to
control it's operation from the bmc. These include suspending and resuming
the daemon to synchronise flash access, telling the daemon to point the lpc
mapping back to flash and telling the daemon when the flash has been
modified out from under it.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Change-Id: I10be01a395c2bec437cf2c825fdd144580b60dbc

show more ...

autoconf: Don't depend on systemd

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Convert to autotools

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>