prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ib442712e2562fac166148ce795f0a83511ad84cd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I6a61656dd

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I6a61656dd6033329cba124ac0754152cbd1e9de3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-ignore: rename

Currently openbmc-build-scripts will accept either .clang-ignore
or .clang-format-ignore. Meson by default looks at the
.clang-format-ignore name. Switch to using that one for

clang-ignore: rename

Currently openbmc-build-scripts will accept either .clang-ignore
or .clang-format-ignore. Meson by default looks at the
.clang-format-ignore name. Switch to using that one for broader
compatibility.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic215763d4197dc6d5f598737dbae902d4d23f44d

show more ...

eslintignore: drop

With I70ac6de1f9925ccd35396c894b45f16e33884551 in openbmc-build-scripts,
eslint is only called on files of the appropriate types as a direct
argument. Remove this workaround that

eslintignore: drop

With I70ac6de1f9925ccd35396c894b45f16e33884551 in openbmc-build-scripts,
eslint is only called on files of the appropriate types as a direct
argument. Remove this workaround that prevented eslint from doing
too deep of symlink recursion.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8584292ad2deaa75b9f9bf30c5a22ffe7a7a418a

show more ...

shellcheck: add ignore for files currently failing

An upcoming change in openbmc-build-scripts will enable shellcheck
everywhere. Add currently failing files to the .shellcheck-ignore.
The expectat

shellcheck: add ignore for files currently failing

An upcoming change in openbmc-build-scripts will enable shellcheck
everywhere. Add currently failing files to the .shellcheck-ignore.
The expectation is that the maintainers will resolve the shellcheck
issues as time is available.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I88fb6c71801141c08255e8f8deb6cf495b3624d9

show more ...

ncsid: add shebang on shell libraries

In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and d

ncsid: add shebang on shell libraries

In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and do not pass them to shellcheck.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia214e5418e24b53af29cbdec151f2838d08ae506

show more ...

nemora-postd: update add_option function

- cli11 update from 1.9.1 to 2.2.2 in PR-57585(ref1)
According cli11's commit(ref2), the add_option function needs update

ref:
1. https://gerrit.openbmc.o

nemora-postd: update add_option function

- cli11 update from 1.9.1 to 2.2.2 in PR-57585(ref1)
According cli11's commit(ref2), the add_option function needs update

ref:
1. https://gerrit.openbmc.org/c/openbmc/openbmc/+/57585
2. https://github.com/CLIUtils/CLI11/commit/e2e3cb2fed20b0c25eaf6d2689784b9c0e3730f1

Signed-off-by: Harvey.Wu <Harvey.Wu@quantatw.com>
Change-Id: I165f35dc02d27afb56ca4e88a9e08f0564033acd

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I524eafe25c461b0dd987e7c31f142264866c6fa3

OWNERS: fix syntax

Two subdirectory OWNERS files had invalid syntax which caused the
tools to crash.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia7cef2eae99eaf6fbdddc099b2261e35

OWNERS: fix syntax

Two subdirectory OWNERS files had invalid syntax which caused the
tools to crash.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia7cef2eae99eaf6fbdddc099b2261e35862cb18e

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5055fac459cb021ea94686e058e233bcc476a32d

show more ...

ncsid: Fix interruptible RA

Capturing directly from a subshell into a variable blocks the bash
process from waiting on a signal. Instead, use `coproc` and `read` to
achieve the same result.

Change-

ncsid: Fix interruptible RA

Capturing directly from a subshell into a variable blocks the bash
process from waiting on a signal. Instead, use `coproc` and `read` to
achieve the same result.

Change-Id: I7ad8b01e2508c5a0c871d77d3a629ac5812656c5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Guarantee MAC override

This allows us to runtime configure the mac address of the link while
still being able to have ncsid write an updated one.

Tested: On hardware and verified that the fi

ncsid: Guarantee MAC override

This allows us to runtime configure the mac address of the link while
still being able to have ncsid write an updated one.

Tested: On hardware and verified that the file gets written with the
MAC updated.

Change-Id: I1081ace0829f686e2e5bb34321433c5eb5b531dd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: update-ra-gw: Always keep RA updated

Even if we aren't using ncsid itself we should still try and update the
default router.

Change-Id: Idd8599dcb7003eafa50c03bde58ef5c3cb931e9f
Signed-off-b

ncsid: update-ra-gw: Always keep RA updated

Even if we aren't using ncsid itself we should still try and update the
default router.

Change-Id: Idd8599dcb7003eafa50c03bde58ef5c3cb931e9f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

metrics-ipmi-blobs: Fix memory leak with readMem

Add `munmap` after `mmap` succeeded.
Otherwise it might cause memory after 65500+ times.

Tested:
(Provided by @suichen)
```
Without munmap:

/tmp# .

metrics-ipmi-blobs: Fix memory leak with readMem

Add `munmap` after `mmap` succeeded.
Otherwise it might cause memory after 65500+ times.

Tested:
(Provided by @suichen)
```
Without munmap:

/tmp# ./mmap_test
...
65100 mmaps
65200 mmaps
65300 mmaps
65400 mmaps
65500 mmaps
ERR: 12
ERROR with 65503 mmaps
ERR: 12

-----------------------------------------------------------------
With unmap:

/tmp# WITH_UNMAP=1 ./mmap_test
...
161700 mmaps
161800 mmaps
161900 mmaps
162000 mmaps
162100 mmaps
162200 mmaps
...
```

Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: Ie68d4f42337ca3459ae60dc1f649ed1b25631b17

show more ...

ncsid: Fix IP / Gateway updating

Sometimes phosphor-networkd incorrectly determines that DHCP should be
enabled. This prevents us from assigning IPs and gateways to the BMC.
Disable DHCP to fix assi

ncsid: Fix IP / Gateway updating

Sometimes phosphor-networkd incorrectly determines that DHCP should be
enabled. This prevents us from assigning IPs and gateways to the BMC.
Disable DHCP to fix assignment.

Change-Id: I91c8da79afb2ff1f1dba924f8c229ee8862bdeab
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Use per-interface gateway

Change-Id: I97185fc181918ad4668cb4e758eec25c51090b04
Signed-off-by: William A. Kennington III <wak@google.com>

dhcp-done: Add daemon

Used to communicate with cloud utilities monitoring the netboot status
of the machine. Started once the netboot has completed in order to
provide status.

Change-Id: I6eb8b5a00

dhcp-done: Add daemon

Used to communicate with cloud utilities monitoring the netboot status
of the machine. Started once the netboot has completed in order to
provide status.

Change-Id: I6eb8b5a0048e3a9d5d4f56adae42ef5aff2c2bab
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Fix update_ra_gw for multi-RA

Change-Id: I2a3e796b39fe3dd4a3de0b347277d846896c010a
Signed-off-by: William A. Kennington III <wak@google.com>

libcr51sign: Temporarily ignore deprecate functions

The code is in the process of being updated internally, but this is
blocking commits to the repo.

Change-Id: I77cb1d4f5fb8eec02c224d71d4a2e76ad89

libcr51sign: Temporarily ignore deprecate functions

The code is in the process of being updated internally, but this is
blocking commits to the repo.

Change-Id: I77cb1d4f5fb8eec02c224d71d4a2e76ad893d9aa
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

libcr51sign: Sync with latest code

Change-Id: Id3de25f3b112aa84d4b2342f606a60bb049487c8
Signed-off-by: William A. Kennington III <wak@google.com>

ncsid: update_ra_gw: Fix SIGTERM handling

We need to make sure we handle TERMS correctly so the service can
shutdown in a reasonable amount of time.

Change-Id: I955f0871d7f9764de7565390913a7db2942e

ncsid: update_ra_gw: Fix SIGTERM handling

We need to make sure we handle TERMS correctly so the service can
shutdown in a reasonable amount of time.

Change-Id: I955f0871d7f9764de7565390913a7db2942e418e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Only log errors a single time

This reduces the amount of contents in the journal when an NCSI cable
is missing or the interface is broken.

It still periodically logs repeat messages, but onl

ncsid: Only log errors a single time

This reduces the amount of contents in the journal when an NCSI cable
is missing or the interface is broken.

It still periodically logs repeat messages, but only once per hour
instead of potentially many times a second.

Change-Id: Ic2efad4d3dea170863a5d4cbe48668a13007045c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

MAINTAINERS: fix syntax

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie1e068c27b22f3c44448970c1d8b7bc41ae0e5e5

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus and switch all redundant types to their `type_t`
counterpart.

Sign

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus and switch all redundant types to their `type_t`
counterpart.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9a8066ca6b01253d7bd062c3c416384db2ad65fc

show more ...

nemora-postd: fix compile fail

host_manager.hpp is missing header for `std::thread`.

```
In file included from ../subprojects/nemora-postd/src/nemora.hpp:17,
from ../subprojects/ne

nemora-postd: fix compile fail

host_manager.hpp is missing header for `std::thread`.

```
In file included from ../subprojects/nemora-postd/src/nemora.hpp:17,
from ../subprojects/nemora-postd/src/nemora.cpp:15:
../subprojects/nemora-postd/src/host_manager.hpp:76:26: error: ‘thread’ is not a member of ‘std’
76 | std::unique_ptr<std::thread> post_poller_;
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icda54302f7770e5760dfa3c509c7086e47af75f9

show more ...