use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6cfa8f7341cc0df7d48b90c83b9f25985d668cab

show more ...

[dhcp-status] add bmc warm reboot support

Change-Id: I805e2a245b2a4cbbda025c331683a3c945091d94
Signed-off-by: Yuxiao Zhang <yuxiaozhang@google.com>

espi-control: Fix std::format error

Change-Id: I885a7a79793ebbbd4c7b11fad2a6248d7ad0ff92
Signed-off-by: Yuxiao Zhang <yuxiaozhang@google.com>

libcr51sign: clean up silent const cast

Remove all `(void*)ctx` silent const remove cast

Change-Id: I89bb6d1ece4e47ba9344f58f66a0736416f6c9c1
Signed-off-by: Dan Zhang <zhdaniel@google.com>

markdownlint: minor fixes

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic88a1e968f08966946a57e422ea998960e9cb4af

libcr51sign: enhance to support key rotation

Support validate cr51 descriptor with trusted hash and key within the
signature structure.

Accept the descriptor if its hash is trusted.
Validate the de

libcr51sign: enhance to support key rotation

Support validate cr51 descriptor with trusted hash and key within the
signature structure.

Accept the descriptor if its hash is trusted.
Validate the descriptor signature with verification key provided along
with the signature if the key is trusted.

To support the above enhancement for key rotation, three new functions
are defined in interface:

* trust_descriptor_hash
* trust_key_in_signature_structure
* verify_rsa_signature_with_modulus_and_exponent

Applications (i.e. flashupdate or bios-validator) will provide these
functions.

And to facilitate verify rsa signature using key in signature structure,
an implementation of verify_rsa_signature_with_modulus_and_exponent
using the openssl has been provided also.

Change-Id: I787f8c661433052f8c8a1d23e9e6140befce2265
Signed-off-by: Dan Zhang <zhdaniel@google.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I8f8f59df50fb1b0bac487509c0933f133b45e9c2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

bare-metal-host-monitor: Use service type notify

We want to be able to start other services after this daemon has
finished its startup code. So, this commit updates the host-gpio-monitor
code to not

bare-metal-host-monitor: Use service type notify

We want to be able to start other services after this daemon has
finished its startup code. So, this commit updates the host-gpio-monitor
code to notify systemd when the initialization is done.

Tested:
Set the bare metal flag /var/google/config-package/enable-bm.flag
Did a power cycle, and confirmed the services started in the expected
order.

Change-Id: I51d1aed7509795852f5873f71ae6ba57401ae6b9
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

bare-metal-host-monitor: Start after x86-power-control

We need to ensure that the host-gpio-monitor starts after
xyz.openbmc_project.Chassis.Control.Power@.service, so the dbus objects
are ready.

T

bare-metal-host-monitor: Start after x86-power-control

We need to ensure that the host-gpio-monitor starts after
xyz.openbmc_project.Chassis.Control.Power@.service, so the dbus objects
are ready.

Tested:
Set the bare metal flag /var/google/config-package/enable-bm.flag
Power cycled the machine.
Ensured the host-gpio-monitor could query the dbus property at startup.
Also confirmed the expected systemd service ordering at startup:
xyz.openbmc_project.Chassis.Control.Power@.service, followed by
host-gpio-monitor@.service.

Change-Id: Ibfbac32586981a14ca276f40080a6e698f342aac
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

bare-metal-host-monitor: Reduce the filter timeout

There's a timer that filters out bursts of dbus signals, so that we
handle them all at once. But we need to reduce the timeout, so we don't
miss im

bare-metal-host-monitor: Reduce the filter timeout

There's a timer that filters out bursts of dbus signals, so that we
handle them all at once. But we need to reduce the timeout, so we don't
miss important dbus property state changes.

Tested:
Set the bare metal flag /var/google/config-package/enable-bm.flag
Power cycled the machine and confirmed that host-gpio-monitor@1.service
and host-gpio-monitor@2.service started.
Rebooted host 2, and confirmed this message showed up:
<6> Post Complete state is InReset

Change-Id: I1d08183edc1ff48d2031f62a0fd9ece118fd55aa
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

bare-metal-host-monitor: Add dbus configurations

Currently, the dbus service name, object, and property are all
hard-coded, but we need to be able to configure these dbus details for
different platf

bare-metal-host-monitor: Add dbus configurations

Currently, the dbus service name, object, and property are all
hard-coded, but we need to be able to configure these dbus details for
different platforms. This commit introduces some meson build options for
this purpose. The default values can be overridden in a bbappend file.

Tested:
Set the bare metal flag /var/google/config-package/enable-bm.flag
Power cycled the machine, and confirmed that host-gpio-monitor@1.service
and host-gpio-monitor@2.service started.
Rebooted host 2, and confirmed this message showed up:
<6> Post Complete state is InReset

Change-Id: I100ed2e450dbedf52565e0f35f50edba229ef800
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

ncsid: Use PACKET_MR_PROMISC

Using IFF_PROMISC is dangerous because it requires us to set the IF
flag. The if flags cannot be set atomically, and they are expected to be
owned and managed by systemd

ncsid: Use PACKET_MR_PROMISC

Using IFF_PROMISC is dangerous because it requires us to set the IF
flag. The if flags cannot be set atomically, and they are expected to be
owned and managed by systemd-networkd. NCSId will sometimes race with
systemd-networkd and discard the IFF_UP flag and prevent the interface
from coming up during boot.

PACKET_MR_PROMISC does not depend on the flags and will not conflict
with other processes using the interface.

Change-Id: I4c193e73bff789e079e859d2b98c2477b2956d54
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

dhcp-done: Write status at startup

We want the initial status file to be available as soon as the service
starts, so we never produce an error about reading the file contents.

This has a side benef

dhcp-done: Write status at startup

We want the initial status file to be available as soon as the service
starts, so we never produce an error about reading the file contents.

This has a side benefit that the DHCP processes don't need to write out
a status file until they have acquired lease information from the
server.

Change-Id: Ieedb14f1ab3927bcd5f13ad684309c163c920fef
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I47f5f8415b1afbc82d9186ffd2b5260a84907ef6
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I47f5f8415b1afbc82d9186ffd2b5260a84907ef6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Id3da51b0ab2cd90f7bb79bd7b613b2226672a802
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: Iea489ded084f43d245e7b17f210e83bc2398dd6d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ncsid: Take off phophor-networkd Dependency

We are in the process of eliminating phosphor-network daemon to
increase gBMC Networking stability by eliminating racing
conditions that exist when multip

ncsid: Take off phophor-networkd Dependency

We are in the process of eliminating phosphor-network daemon to
increase gBMC Networking stability by eliminating racing
conditions that exist when multiple daemons are configuring
the network concurrently. These two services do not need
dependency on phosphor networkd currently.

Change-Id: I1614f2c2c764acc6f88473d3a24d9f710305e66d
Signed-off-by: Mo Elbadry <elbadrym@google.com>

show more ...

ncsid: Remove defunct RA script

We no longer need this logic as we have a combined RA handling script in
our meta layers.

Change-Id: I1ca88a25e5b3e5afa46e2f6ff2789885d7046660
Signed-off-by: William

ncsid: Remove defunct RA script

We no longer need this logic as we have a combined RA handling script in
our meta layers.

Change-Id: I1ca88a25e5b3e5afa46e2f6ff2789885d7046660
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: Iae27e5bd313778cb732d5e87598cd94cc6b13cb4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ncsid: skip setting mac address if it matches

There are cases where NIC keeps trying to set MAC
address of already set interface, which can lead
to ncsid turning interface down/up non-stop. A
worka

ncsid: skip setting mac address if it matches

There are cases where NIC keeps trying to set MAC
address of already set interface, which can lead
to ncsid turning interface down/up non-stop. A
workaround is to check if mac matches before setting.

Change-Id: I376cfdde62d5e6a1021fd3410d48027644c7ddde
Signed-off-by: Mo Elbadry <elbadrym@google.com>

show more ...

host-gpio-monitor: Use systemd template

The systemd target gbmc-bare-metal-active.target is being changed to a
template, in order to support multi-host systems. The commit updates the
host-gpio-moni

host-gpio-monitor: Use systemd template

The systemd target gbmc-bare-metal-active.target is being changed to a
template, in order to support multi-host systems. The commit updates the
host-gpio-monitor functionality accordingly. The host number now gets
passed in as an argument.

Tested:
Set the bare metal flag /var/google/config-package/enable-bm.flag on the
BMC. Started host-gpio-monitor@0.service, which then started
gbmc-bare-metal-active@0.target. Then rebooted the host, at which point,
the host-gpio-monitor@0.service disabled
gbmc-bare-metal-active@0.target.

Change-Id: I02a0b11996aa2ee168e682fbf61f3f1a8cf01771
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

ncsid: Set MAC address using ioctl calls

Set the MAC address directly via ioctl calls, removing the
dependency on phosphor-networkd. This simplifies the process
and reduces overhead as phosphor-netw

ncsid: Set MAC address using ioctl calls

Set the MAC address directly via ioctl calls, removing the
dependency on phosphor-networkd. This simplifies the process
and reduces overhead as phosphor-networkd is not extensively
utilized in this context.

Change-Id: If3465f52834ba38c551d5152ef354cbf455f6a90
Signed-off-by: Mo Elbadry <elbadrym@google.com>

show more ...

metric-ipmi-blobs: adding tmpfs

Adding tmpfs metric coverage to pre-ttf machines

Tested:
```
df -h
Filesystem Size Used Available Use% Mounted on
dev 468.9M

metric-ipmi-blobs: adding tmpfs

Adding tmpfs metric coverage to pre-ttf machines

Tested:
```
df -h
Filesystem Size Used Available Use% Mounted on
dev 468.9M 0 468.9M 0% /dev
tmpfs 469.9M 12.6M 457.3M 3% /run
/dev/mtdblock4 20.6M 20.6M 0 100% /run/initramfs/ro
/dev/mtdblock6 3.0M 436.0K 2.6M 14% /run/initramfs/rw
cow 3.0M 436.0K 2.6M 14% /
tmpfs 469.9M 8.0K 469.9M 0% /dev/shm
tmpfs 469.9M 0 469.9M 0% /tmp
tmpfs 469.9M 40.0K 469.8M 0% /var/volatile
tmpfs 469.9M 12.6M 457.3M 3% /var/lib/systemd/coredump
```

Change-Id: I50c763707268252ed51a903d8b7e02543dab6166
Signed-off-by: Abby <buchmana@google.com>

show more ...

bare-metal-gpio-monitor: don't start on non-bm mode

This adds a condition check for the bm flag. So that the service will
not take effect on non-bm mode.

Change-Id: I0d15247a6e05aa5edf93468793cd74b

bare-metal-gpio-monitor: don't start on non-bm mode

This adds a condition check for the bm flag. So that the service will
not take effect on non-bm mode.

Change-Id: I0d15247a6e05aa5edf93468793cd74bd7d9ea158
Signed-off-by: Yuxiao Zhang <yuxiaozhang@google.com>

show more ...

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths and `libsystemd` should be used for `sd_*` functions.

Update the dependency accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9241adf8ce73df70fb7e50cc50f16015322bea5b

show more ...