ncsid: Use PACKET_MR_PROMISC

Using IFF_PROMISC is dangerous because it requires us to set the IF
flag. The if flags cannot be set atomically, and they are expected to be
owned and managed by systemd

ncsid: Use PACKET_MR_PROMISC

Using IFF_PROMISC is dangerous because it requires us to set the IF
flag. The if flags cannot be set atomically, and they are expected to be
owned and managed by systemd-networkd. NCSId will sometimes race with
systemd-networkd and discard the IFF_UP flag and prevent the interface
from coming up during boot.

PACKET_MR_PROMISC does not depend on the flags and will not conflict
with other processes using the interface.

Change-Id: I4c193e73bff789e079e859d2b98c2477b2956d54
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Id3da51b0ab2cd90f7bb79bd7b613b2226672a802
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I362352dcb341658501899267c2ff3ad044ed5912
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I91fe34f9d6743a3afeef73c3e55847542cea143c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ncsid: Fix if_packet warnings

The new Docker CI now hits the following error.
```
/usr/include/linux/if_packet.h:24:17: error: flexible array member 'sockaddr_ll::<unnamed union>::<unnamed struct>::

ncsid: Fix if_packet warnings

The new Docker CI now hits the following error.
```
/usr/include/linux/if_packet.h:24:17: error: flexible array member 'sockaddr_ll::<unnamed union>::<unnamed struct>::sll_addr_flex' not at end of 'class ncsi::SockIO'
24 | __DECLARE_FLEX_ARRAY(unsigned char, sll_addr_flex);
| ^~~~~~~~~~~~~~~~~~~~
../subprojects/ncsid/src/ncsi_sockio.h:55:15: note: next member 'const int ncsi::SockIO::kpoll_timeout_' declared here
55 | const int kpoll_timeout_ = 10;
| ^~~~~~~~~~~~~~
../subprojects/ncsid/src/ncsi_sockio.h:29:7: note: in the definition of 'class ncsi::SockIO'
29 | class SockIO : public net::SockIO
```

Removed the sockaddr_ll variable.

Change-Id: I67e700f6cd728bfbc822c1b8661915f8306711a1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

iwyu: Cleanup include headers

Triggered iwyu and add/remove used headers.

Change-Id: Iadbdb459563b3c89baf2d56f90a540342d020cd5
Signed-off-by: Willy Tu <wltu@google.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia240047e2472bccb2bb039ff71bea20a7a602ec4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I6a61656dd

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I6a61656dd6033329cba124ac0754152cbd1e9de3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ncsid: add shebang on shell libraries

In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and d

ncsid: add shebang on shell libraries

In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and do not pass them to shellcheck.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia214e5418e24b53af29cbdec151f2838d08ae506

show more ...

meson: Fix build with 0.57.1

Meson doesn't like that we are symlinking subprojects outside the
subproject directory. If we invert the links we are able to build again.

We also need to fix any proje

meson: Fix build with 0.57.1

Meson doesn't like that we are symlinking subprojects outside the
subproject directory. If we invert the links we are able to build again.

We also need to fix any projects passing arguments which they don't
actually accept.

Change-Id: Ie7adf82afabc1becc85c36b3cc632e8ebd4cae5b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...