Change primary postcode interface to byte array

Change primary code to std::vector<uint8_t> to meet the changes in
phosphor-dbus-interface.

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-in

Change primary postcode interface to byte array

Change primary code to std::vector<uint8_t> to meet the changes in
phosphor-dbus-interface.

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/74633

Change-Id: Ie1207d703f8bc1ad42fedc5bcbcbd0e4c23dacde
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

log handle: add thread to handle event log

The BIOS has a unified SEL timeout of 1 second.
If log writing takes longer than 1 second, it will trigger a retry,
causing duplicate log entries to be rec

log handle: add thread to handle event log

The BIOS has a unified SEL timeout of 1 second.
If log writing takes longer than 1 second, it will trigger a retry,
causing duplicate log entries to be recorded.

Add threads to handle event logs to avoid recording duplicate logs.

Change-Id: I743c501f0fa114251af45a5aa5b3c87bd5998ec9
Signed-off-by: Peter Yin <peter.yin@quantatw.com>

show more ...

oemcommands: add JSON parsing handling

The IPMI host service fails to activate
if the oemData.json or fbSelRaw.json file is corrupted.

To address this, add JSON parsing error handling
to prevent ab

oemcommands: add JSON parsing handling

The IPMI host service fails to activate
if the oemData.json or fbSelRaw.json file is corrupted.

To address this, add JSON parsing error handling
to prevent abnormal termination during file writing in an AC cycle.

Change-Id: I19a1274ac029413c8b1f2efb25bb1488076dab2d
Signed-off-by: Peter Yin <peter.yin@quantatw.com>

show more ...

machine check error: update machine check error decoding

Now machine check error would display severity detail

Logs example:
Sensor: MACHINE_CHK_ERR (0x40),
Event Data: (AC3900) Deferred Error,

machine check error: update machine check error decoding

Now machine check error would display severity detail

Logs example:
Sensor: MACHINE_CHK_ERR (0x40),
Event Data: (AC3900) Deferred Error,
Machine Check bank Number 57, CPU 0, Core 0 Assertion",

Sensor: MACHINE_CHK_ERR (0x40),
Event Data: (AC1900) Correctable Error,
Machine Check bank Number 25, CPU 0, Core 0 Assertion",

Sensor: MACHINE_CHK_ERR (0x40),
Event Data: (AB1900) Uncorrected Recoverable Error,
Machine Check bank Number 25, CPU 0, Core 0 Assertion",

Sensor: MACHINE_CHK_ERR (0x40),
Event Data: (AB3900) Uncorrected Thread Fatal Error,
Machine Check bank Number 57, CPU 0, Core 0 Assertion",

Sensor: MACHINE_CHK_ERR (0x40),
Event Data: (AB5900) Uncorrected System Fatal Error,
Machine Check bank Number 89, CPU 0, Core 0 Assertion"

Change-Id: I823d9ddcff943c4c4ddb64bdea302b2ae9554a69
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

sel: remove unified sel timestamp message

The issue stems from the BMC parsing a timestamp in the unified SEL,
but the BIOS always sends 0 in the timestamp byte.
The new log format already includes

sel: remove unified sel timestamp message

The issue stems from the BMC parsing a timestamp in the unified SEL,
but the BIOS always sends 0 in the timestamp byte.
The new log format already includes a dedicated timestamp item,
so the plan is to remove the "Time: Wed Dec 31 16:00:00 1969"
from the log message.

TestPlan

ipmitool raw 0x0A 0x44 0xC0 0xAB 0xC2 0 0 0 0 0x4C 0x1C 0 0 0xFE 0 0 0 0
19 00
ipmitool raw 0x0A 0x44 0xC0 0xAB 0xC0 0 0 0 0 0x4C 0x1C 0 0 0xFE 0 0 0 0
1a 00

"2": {
"additional_data": [
"IPMI_RAW=C0ABC2000000004C1C0000FE00000000"
],
"event_id": "",
"message": "SEL Entry: FRU: 1, Record: OEM timestamped (0xC2),
MFG ID: 4C1C00, OEM Data: (00FE00000000) Extra info:0xFE
MSCOD:0x0000 MCACOD:0x0000",
"resolution": "",
"resolved": false,
"severity": "xyz.openbmc_project.Logging.Entry.Level.Critical",
"timestamp": "2024-10-11T15:38:00.679000000Z",
"updated_timestamp": "2024-10-11T15:38:00.679000000Z"
},
"3": {
"additional_data": [
"IPMI_RAW=C0ABC0000000004C1C0000FE00000000"
],
"event_id": "",
"message": "SEL Entry: FRU: 1, Record: OEM timestamped (0xC0),
MFG ID: 4C1C00, OEM Data: (00FE00000000) VID:0xFE00 DID:0x0000
Slot:0x00 Error ID:0x00",
"resolution": "",
"resolved": false,
"severity": "xyz.openbmc_project.Logging.Entry.Level.Critical",
"timestamp": "2024-10-11T15:38:05.221000000Z",
"updated_timestamp": "2024-10-11T15:38:05.221000000Z"
}

Change-Id: Id35a71ad52d3385118b7d701c16c7556e25bda34
Signed-off-by: Peter Yin <peter.yin@quantatw.com>

show more ...

oemcommands: Update USB debug command to get FRU data

Use dbus call to get FRU path instead of just "baseboard".

Change-Id: Icf940ea9221da46a4424a2b439ce021dd48daf3e
Signed-off-by: Daniel Hsu <Dani

oemcommands: Update USB debug command to get FRU data

Use dbus call to get FRU path instead of just "baseboard".

Change-Id: Icf940ea9221da46a4424a2b439ce021dd48daf3e
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

usb-dbg: fix postcode frame buffer overflow

Correctly limit to 10 pages, and display the latest codes.
Shorten the title to display the page number, also align with
fb-openbmc.

Change-Id: I8f6b0a20

usb-dbg: fix postcode frame buffer overflow

Correctly limit to 10 pages, and display the latest codes.
Shorten the title to display the page number, also align with
fb-openbmc.

Change-Id: I8f6b0a2025310b037cf3b4e40078ceb6e47383f3
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...

usb-dbg: include extra code as part of postcode

Catalina system stores the first 8 bytes postcode in to primary code and
store last one byte into extra code array.

Include extra code as part of pos

usb-dbg: include extra code as part of postcode

Catalina system stores the first 8 bytes postcode in to primary code and
store last one byte into extra code array.

Include extra code as part of postcode to display full postcode on debug
card screen.

Change-Id: I4e4b40a254e90e0b4ae6d4ace16a93526f3f4c6c
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

usb-dbg: fix frame parse

Fixed that indent being incorrectly appended.

Change-Id: I427bbbc961e4d2e3c393947ff4b53d6b866fa1f0
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

groupextcommands: revise 9 bytes postcode object

Store first 8 bytes in primary code, and store the last byte in
secondary code array.

Test results:
```
root@bmc:~# busctl call xyz.openbmc_project.

groupextcommands: revise 9 bytes postcode object

Store first 8 bytes in primary code, and store the last byte in
secondary code array.

Test results:
```
root@bmc:~# busctl call xyz.openbmc_project.State.Boot.PostCode0 /xyz/openbmc_project/State/Boot/PostCode0 xyz.openbmc_project.State.Boot.PostCode GetPostCodes q 1 -j
{
"type" : "a(tay)",
"data" : [
[
[
72623859790382856,
[
9
]
],
[
1230066625199609624,
[
25
]
],
[
2387509390608836392,
[
41
]
],
[
2387509390608836392,
[
48
]
]
]
]
}
```

Change-Id: Id58c457f2107b447daed90bd3cd3b2a268e1b28f
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

usb-dbg: C++ise frames

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I25e4bcb74c8a5294b09531d95d66b22432ed070e

usb-dbg: C++ise panel

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib4671a3598d61f903f868846196cd8e645b11fb7

fix formatting

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f797b7cd5c76f2c743344b2beb0bdd5cccd1339

groupextcommands: Add SBMR send boot progress command

Add send boot progress command for postcode recording.
NetFn: 0x2C, Cmd: 0x02, Group: 0xAE (SBMR)

Tested Result:
```
root@bmc:~# ipmitool raw 0

groupextcommands: Add SBMR send boot progress command

Add send boot progress command for postcode recording.
NetFn: 0x2C, Cmd: 0x02, Group: 0xAE (SBMR)

Tested Result:
```
root@bmc:~# ipmitool raw 0x2C 0x02 0xAE 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09
ae
root@bmc:~# ipmitool raw 0x2C 0x02 0xAE 0x11 0x12 0x13 0x14 0x15 0x16 0x17 0x18 0x19
ae
root@bmc:~# ipmitool raw 0x2C 0x02 0xAE 0x21 0x22 0x23 0x24 0x25 0x26 0x27 0x28 0x29
ae
root@bmc:~# busctl call xyz.openbmc_project.State.Boot.PostCode0 /xyz/openbmc_project/State/Boot/PostCode0 xyz.openbmc_project.State.Boot.PostCode GetPostCodes q 1 -j
{
"type" : "a(tay)",
"data" : [
[
[
72623859790382856,
[
1,
2,
3,
4,
5,
6,
7,
8,
9
]
],
[
1230066625199609624,
[
17,
18,
19,
20,
21,
22,
23,
24,
25
]
],
[
2387509390608836392,
[
33,
34,
35,
36,
37,
38,
39,
40,
41
]
]
]
]
}
```

Change-Id: If064fe1300c63e334022a54054958a000200d9d8
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ide19264aa5b2b01a5102b4b2a9cf226ba8dec699
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

oemcommands: add https boot commands

1. netfn 0x30, cmd 0x57: GET_HTTPS_BOOT_DATA:
for BIOS to read cert data during POST

2. netfn 0x30, cmd 0x58: GET_HTTPS_BOOT_ATTR:
for BIOS to read cert info du

oemcommands: add https boot commands

1. netfn 0x30, cmd 0x57: GET_HTTPS_BOOT_DATA:
for BIOS to read cert data during POST

2. netfn 0x30, cmd 0x58: GET_HTTPS_BOOT_ATTR:
for BIOS to read cert info during POST
param 0: cert size
param 1: CRC32 of the cert

Change-Id: I258072916061f7859d101f2b4f8cdda018314b0c
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...

Add extra postcode and remove critical sensor/SEL

1.Add 4-byte postcode support for AMD platform.
2.Remove critical sensor and SEL support.

Change-Id: Icb14afb4424ad03410a3a1b749036f1e6b3f3842
Sign

Add extra postcode and remove critical sensor/SEL

1.Add 4-byte postcode support for AMD platform.
2.Remove critical sensor and SEL support.

Change-Id: Icb14afb4424ad03410a3a1b749036f1e6b3f3842
Signed-off-by: Peter Yin <peter.yin@quantatw.com>

show more ...

support OEM Crashdump

Supports OEM Crashdump command, BIOS sends crashdump data during POST.

Change-Id: Ie3eaee7c14ae52623b8e150e7ef9aa453fe26820
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

usb-dbg: fix type mismatch

There are two declarations of the plat_dbg_control_panel
function which disagree in return type. This results in the
following error under GCC-14:

```
| /usr/src/debug/f

usb-dbg: fix type mismatch

There are two declarations of the plat_dbg_control_panel
function which disagree in return type. This results in the
following error under GCC-14:

```
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/oemcommands.cpp:64:12: error: type of 'plat_udbg_control_panel' does not match original declaration [-Werror=lto-type-mismatch]
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/usb-dbg.cpp:1212:5: note: return value type mismatch
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/usb-dbg.cpp:1212:5: note: type 'int' should match type 'ipmi_ret_t'
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/usb-dbg.cpp:1212:5: note: 'plat_udbg_control_panel' was previously declared here
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/oemcommands.cpp:62:12: error: type of 'plat_udbg_get_frame_data' does not match original declaration [-Werror=lto-type-mismatch]
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/usb-dbg.cpp:1072:5: note: return value type mismatch
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/usb-dbg.cpp:1072:5: note: type 'int' should match type 'ipmi_ret_t'
| /usr/src/debug/fb-ipmi-oem/0.1+git/src/usb-dbg.cpp:1072:5: note: 'plat_udbg_get_frame_data' was previously declared here
```

Fix the return type to use the `ipmi_ret_t` as appropriate.

Make a similar change for plat_udbg_get_frame_data, but switch the
`oemcommands.cpp` definition to `int`, since the function appears to
use many calls that return int (and this is the simple change right
now).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0c1c4ca1230abc0374e311a38713062227a42510

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I1e57d16dd4e8655d698e272e6ee347d80e2056ba
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

parse Unified SEL

Parsing Facebook Unified SEL

Change-Id: I7c6afe1d0ee559e34f8f0d9fa6db3c0e33af25d3
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-Id: Ied1acfff806faeb131c1f55b3cc518f117c487a9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

storagecommands: fix sensorTree never updated

Swap the sequence of sensorTree.empty() and getSensorSubtree() in if
statement.
This will fix the issue of sensorTree never get updated.

Change-Id: I22

storagecommands: fix sensorTree never updated

Swap the sequence of sensorTree.empty() and getSensorSubtree() in if
statement.
This will fix the issue of sensorTree never get updated.

Change-Id: I225c3641145643ef481aec977ebd4b8b277b2dc8
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

fix the last "next record ID" missing in the Get SDR response

In current implementation, the last SDRs are for FRUIDs (Type 10h).
After fixing this issue, we can list all FRUIDs by the command,
"ipm

fix the last "next record ID" missing in the Get SDR response

In current implementation, the last SDRs are for FRUIDs (Type 10h).
After fixing this issue, we can list all FRUIDs by the command,
"ipmitool fru print".

Change-Id: I8ca22bea9a20128f268cf23bf6c92b352e901d67
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...

me: remove support

The ME support was only used for adding additional data onto the OCP
debug card. No new systems use the ME and none of the machines that had
an ME are using this code in producti

me: remove support

The ME support was only used for adding additional data onto the OCP
debug card. No new systems use the ME and none of the machines that had
an ME are using this code in production. Remove it to reduce the
clutter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I124f1b95c99a0695b5488695b81e274936461844

show more ...