#
15b63e12 |
| 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I07372e75f12f406bd0555dd27e249bc7dd0958d4 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
d4554f2a |
| 17-Jun-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://githu
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://github.com/codespell-project/codespell
Change-Id: I153217f4ae8454e3546a59da9fcfe3f83fd04b39 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
#
ff1b64f0 |
| 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: Idc09d9211b70f7afc008f32e8cb66485ebe0510c Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
04c28fad |
| 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: Ia968a74764d3bda33160a8a9890629ed3cc94d0e Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
be47c8fe |
| 30-Sep-2022 |
John Wedig <johnwedig@google.com> |
Fix zero_test and pattern_test
The zero_test and pattern_test are failing to compile because some mocks are returning vectors instead of spans.
Signed-off-by: John Wedig <johnwedig@google.com> Chan
Fix zero_test and pattern_test
The zero_test and pattern_test are failing to compile because some mocks are returning vectors instead of spans.
Signed-off-by: John Wedig <johnwedig@google.com> Change-Id: Iaf8166f265ef6a67d96e1507abeaca47459e24d3
show more ...
|
#
4906f4ef |
| 28-Apr-2022 |
John Edward Broadbent <jebr@google.com> |
span: switch to std
Reduce the dependency on stdplus' version of span now that we are using C++20 and use the one out of the STL instead.
See:https://gerrit.openbmc-project.xyz/c/openbmc/stdplus/+/
span: switch to std
Reduce the dependency on stdplus' version of span now that we are using C++20 and use the one out of the STL instead.
See:https://gerrit.openbmc-project.xyz/c/openbmc/stdplus/+/53308
Change-Id: I2a35670ab50c40fed093474c4986dd6d2cb79011 Signed-off-by: John Edward Broadbent <jebr@google.com>
show more ...
|
#
34a75f05 |
| 14-Apr-2022 |
John Edward Broadbent <jebr@google.com> |
Fix shadowed variable improperly scoped
These variables were outside of the function that used them. Every other function that set the "size" variable was shadowing the improperly scoped variables.
Fix shadowed variable improperly scoped
These variables were outside of the function that used them. Every other function that set the "size" variable was shadowing the improperly scoped variables.
Change-Id: I45b20606492987c7a09105c33847bc5b35b9e0ec Signed-off-by: John Edward Broadbent <jebr@google.com>
show more ...
|
#
d6071fc2 |
| 31-Mar-2022 |
John Edward Broadbent <jebr@google.com> |
Fix Short read/write issue
It was possible for "short" reads and writes to cause the pattern and zero steps to not work correctly. This change adds logic to deal with the short reads.
Tested: unit
Fix Short read/write issue
It was possible for "short" reads and writes to cause the pattern and zero steps to not work correctly. This change adds logic to deal with the short reads.
Tested: unit test and machine test root@bmc# time busctl call xyz.openbmc_project.eStoraged.mmcblk0 \ > /xyz/openbmc_project/inventory/storage/mmcblk0 \ > xyz.openbmc_project.Inventory.Item.Volume Erase s \ > xyz.openbmc_project.Inventory.Item.Volume.EraseMethod.ZeroOverWrite \ > --timeout=1200 real 6m0.815s user 0m0.010s sys 0m0.010s
Change-Id: If8df9bdba159a3bcfa77104a4c17b8d352794db2 Signed-off-by: John Edward Broadbent <jebr@google.com>
show more ...
|
#
82897c35 |
| 21-Feb-2022 |
Ed Tanous <edtanous@google.com> |
Check in a clang-tidy
This should've been done when we first created the repo, but better late than never.
Signed-off-by: Ed Tanous <edtanous@google.com> Signed-off-by: John Edward Broadbent <jebr@
Check in a clang-tidy
This should've been done when we first created the repo, but better late than never.
Signed-off-by: Ed Tanous <edtanous@google.com> Signed-off-by: John Edward Broadbent <jebr@google.com> Change-Id: I68da1d13167ec94f9d008dea307c9f23a991d42c
show more ...
|
#
d3bfa7bb |
| 13-Jan-2022 |
John Edward Broadbent <jebr@google.com> |
Add namespaces to erase methods
Some erase objects did not have the required namespace. This change adds the estoraged and estoraged_testing namespace where it is needed.
Testing: Not tested Change
Add namespaces to erase methods
Some erase objects did not have the required namespace. This change adds the estoraged and estoraged_testing namespace where it is needed.
Testing: Not tested Change-Id: I63757ea4d3672659f21108e5e65fd09aa1c03406 Signed-off-by: John Edward Broadbent <jebr@google.com>
show more ...
|
#
69786761 |
| 21-Jan-2022 |
John Edward Broadbent <jebr@google.com> |
Not passing fd in the zero and pattern erase
The original erase zero, and erase pattern methods took fd that were opened by the client code. This changes make zero and pattern open the files interna
Not passing fd in the zero and pattern erase
The original erase zero, and erase pattern methods took fd that were opened by the client code. This changes make zero and pattern open the files internally, which is safe and a more standard practice.
Tested: This change has not been tested
Change-Id: Iae848429b304aa39d510d1f090ace416db88ac7e Signed-off-by: John Edward Broadbent <jebr@google.com>
show more ...
|
#
7f2ab643 |
| 11-Nov-2021 |
John Edward Broadbent <jebr@google.com> |
Add pattern write and verify to erase
The goals are to write a non-compressible and verifiable pattern to the drive as a means to validate that the drive is working, and ensure all blocks have been
Add pattern write and verify to erase
The goals are to write a non-compressible and verifiable pattern to the drive as a means to validate that the drive is working, and ensure all blocks have been overwritten.
Tested: $ systemctl stop emmc.service $ ./eStoraged -b /dev/mmcblk0& $busctl call xyz.openbmc_project.eStoraged.mmcblk0 /xyz/openbmc_project/storage/mmcblk0 xyz.openbmc_project.Inventory.Item.Volume Erase s xyz.openbmc_project.Inventory.Item.Volume.EraseMethod.LogicalOverWrite --timeout=1200
$busctl call xyz.openbmc_project.eStoraged.mmcblk0 /xyz/openbmc_project/storage/mmcblk0 xyz.openbmc_project.Inventory.Item.Volume Erase s xyz.openbmc_project.Inventory.Item.Volume.EraseMethod.LogicalVerify --timeout=1200
$echo "jebr" > /dev/mmcblk0
$busctl call xyz.openbmc_project.eStoraged.mmcblk0 /xyz/openbmc_project/storage/mmcblk0 xyz.openbmc_project.Inventory.Item.Volume Erase s xyz.openbmc_project.Inventory.Item.Volume.EraseMethod.LogicalVerify --timeout=1200 Call failed: The operation failed internally.
Change-Id: Ibc1254279b1f46246eb37056ea6e4e1a57159bb9 Signed-off-by: John Edward Broadbent <jebr@google.com>
show more ...
|