#
f375fecc |
| 21-Mar-2024 |
Potin Lai <potin.lai@quantatw.com> |
meson: change install_dir to /usr/libexec/entity-manager
We notice a issue that if user accidentally execute fru-device and terminate it after few second, the xyz.openbmc_project.FruDevice busname w
meson: change install_dir to /usr/libexec/entity-manager
We notice a issue that if user accidentally execute fru-device and terminate it after few second, the xyz.openbmc_project.FruDevice busname will not exist on dbus, but the status of FruDevice.service is still active running.
It because sdbusplus changes the behavior of request_name() and it allows the busname can be replaced by new service. [1]
In order to avoid unexpected behavior by running service binary accidentally, move the install_dir to /usr/libexec/entity-manager.
Tested result: - EntityManager is still running normally after the change ``` root@bmc:~# systemctl status xyz.openbmc_project.EntityManager.service ● xyz.openbmc_project.EntityManager.service - Entity Manager Loaded: loaded (/usr/lib/systemd/system/xyz.openbmc_project.EntityManager.service; enabled; preset: enabled) Active: active (running) since Wed 2024-03-20 23:25:44 PDT; 27min ago Process: 596 ExecStartPre=/bin/mkdir -p /var/configuration (code=exited, status=0/SUCCESS) Process: 679 ExecStartPre=/bin/mkdir -p /tmp/overlays (code=exited, status=0/SUCCESS) Main PID: 687 (entity-manager) CPU: 7.203s CGroup: /system.slice/xyz.openbmc_project.EntityManager.service └─687 /usr/libexec/entity-manager/entity-manager ``` - FruDevice is still running normally after the change ``` root@bmc:~# systemctl status xyz.openbmc_project.FruDevice.service ● xyz.openbmc_project.FruDevice.service - Fru Device Loaded: loaded (/usr/lib/systemd/system/xyz.openbmc_project.FruDevice.service; enabled; preset: enabled) Active: active (running) since Wed 2024-03-20 23:25:40 PDT; 28min ago Main PID: 598 (fru-device) CPU: 729ms CGroup: /system.slice/xyz.openbmc_project.FruDevice.service └─598 /usr/libexec/entity-manager/fru-device ```
[1] https://github.com/openbmc/sdbusplus/commit/946c940434a7d5403f469ce2ab56f9136293ff38
Signed-off-by: Potin Lai <potin.lai@quantatw.com> Change-Id: I01c1f0fe7a1bdbaf74ec4d080b62450f4a90a057
show more ...
|
#
dafc6884 |
| 27-Jun-2023 |
Zhikui Ren <zhikui.ren@intel.com> |
FruDevice: update service to always restart
Entity Manager depends on FruDevice service to scan and then load configurations. Update FruDevice service to always restart on failure. Set restartsec to
FruDevice: update service to always restart
Entity Manager depends on FruDevice service to scan and then load configurations. Update FruDevice service to always restart on failure. Set restartsec to 5 seconds.
Tested: Service auto restart when the process is killed.
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com> Change-Id: I9c408c8d89a27bac0d7ae2ea6c419e1f544a222f
show more ...
|
#
3c61d7f4 |
| 15-Jul-2022 |
Zev Weiss <zev@bewilderbeest.net> |
Remove mux-closing detritus
It's been a while since we had python in the build; this script is obsolete, as is the reference to it in the FruDevice service file.
Signed-off-by: Zev Weiss <zev@bewil
Remove mux-closing detritus
It's been a while since we had python in the build; this script is obsolete, as is the reference to it in the FruDevice service file.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: If0bb9a4ff7c30d2e5b9ca370e11918ab36c820f8
show more ...
|
#
5113b931 |
| 09-Sep-2021 |
Charles Boyer <Charles.Boyer@fii-usa.com> |
service_files: remove StopWhenUnneeded flag in FruDevice service There have been instances where the FruDevice service would stop when the host is turned off. The solution was to remove
service_files: remove StopWhenUnneeded flag in FruDevice service There have been instances where the FruDevice service would stop when the host is turned off. The solution was to remove the StopWhenUnneeded flag. This flag is not necessary for FruDevice to detect devices. Tested: - ReScan and ReScanBus function with the flag removed - Re-init of the system successfully detects devices Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com> Change-Id: I47787fe72e004ff43911018b8b7251eb2775d692
show more ...
|
#
3649678c |
| 04-Nov-2020 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
systemd: install in multi-user.target Installing in basic.target adds an ordering dependency on every single unit to entity-manager and fru device. Avoid all these unnecessary impli
systemd: install in multi-user.target Installing in basic.target adds an ordering dependency on every single unit to entity-manager and fru device. Avoid all these unnecessary implicit dependencies by installing in multi-user instead. Testing consisted of booting a rainier bmc to multi-user with any issues. It should be noted that the rainier target has very few applications with dependencies on entity-manager and does not presently use fru-device at all. Change-Id: Ieb4e638b16839705555cfd699cf735a84478e4b2 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
#
dd9c79be |
| 28-Mar-2019 |
Patrick Venture <venture@google.com> |
build: install into bin instead of sbin Installs into bin instead of sbin per guidelines. Signed-off-by: Patrick Venture <venture@google.com> Change-Id: I049a33c7102d97110cf5ccf
build: install into bin instead of sbin Installs into bin instead of sbin per guidelines. Signed-off-by: Patrick Venture <venture@google.com> Change-Id: I049a33c7102d97110cf5ccf13fec1ad694e33246
show more ...
|
#
9b8ece15 |
| 03-Jan-2019 |
James Feist <james.feist@linux.intel.com> |
Remove condition from service files These don't provide anything useful and aren't working currently. Remove them to remove the error. Change-Id: I24b6a14ff9d585730095ed7fe5ebcd
Remove condition from service files These don't provide anything useful and aren't working currently. Remove them to remove the error. Change-Id: I24b6a14ff9d585730095ed7fe5ebcd02a187f64a Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
#
d534f743 |
| 08-Nov-2018 |
Yong Li <yong.b.li@linux.intel.com> |
Change the service type from oneshot to simple With oneshot type will block until the running process exists, however the fru-device does not exit, this causes the service status is
Change the service type from oneshot to simple With oneshot type will block until the running process exists, however the fru-device does not exit, this causes the service status is always in running Change-Id: Ibb246de21a6a2433549f09241d540348eb93870b Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
show more ...
|
#
ce4367c6 |
| 16-Oct-2018 |
James Feist <james.feist@linux.intel.com> |
Move service files into repo and clean up OVERLAYS Upstream request is to have service files in repo now. Also limit scope of OVERLAYS flag to allow exports to still work. C
Move service files into repo and clean up OVERLAYS Upstream request is to have service files in repo now. Also limit scope of OVERLAYS flag to allow exports to still work. Change-Id: I61c8621a648556d277d4faf3dfe38a61343053ce Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|