16b98a23 | 17-Dec-2023 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
subproject-maintainership: Add ToC
Change-Id: Iae9dc415fe05b55fc41528705ddf403ce7871e9a Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au> |
d72704a5 | 02-Aug-2023 |
Lei YU <yulei.sh@bytedance.com> |
design: Add SOL SysRq design doc
Add initial version of SOL SysRq design doc.
Signed-off-by: Lei YU <yulei.sh@bytedance.com> Change-Id: I7c14de106a71585b11eed4a9a27e0fb677a3a954 |
d00ea442 | 26-Nov-2023 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
Add Discord rules
These rules are currently implemented using the rules screening feature of Discord. However, I haven't found an obvious way to view them for people who have already joined the serv
Add Discord rules
These rules are currently implemented using the rules screening feature of Discord. However, I haven't found an obvious way to view them for people who have already joined the server.
https://support.discord.com/hc/en-us/articles/1500000466882-Rules-Screening-FAQ
Change-Id: Ifb230303dc1f27aff0c164fd89d1fab27e46dae2 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
5ae48158 | 28-Sep-2023 |
Alexander Hansen <alexander.hansen@9elements.com> |
clang-tidy: propose a base .clang-tidy
When there is a specific recommendation, it is taken from Cpp Core guidelines [1] or clang-tidy defaults.
- readability-function-size.LineThreshold was chos
clang-tidy: propose a base .clang-tidy
When there is a specific recommendation, it is taken from Cpp Core guidelines [1] or clang-tidy defaults.
- readability-function-size.LineThreshold was chosen to support [ F.3 Keep functions short and simple ]
They recommend 60 lines to flag functions which would not fit on a screen.
- readability-function-size.ParameterThreshold was chosen to support [ F.2: A function should perform a single logical operation ]
They recommend to be suspicious of functions with 7 or more parameters.
- readability-function-cognitive-complexity.Threshold was chosen to support [ F.3: Keep functions short and simple ]
They recommend a cyclomatic complexity of 10 or less. However, cyclomatic complexity is not implemented in clang-tidy, therefore going with the clang-tidy default.
What is the goal of this change?
- making it easier for people to read the code.
- making it easier to perform refactorings without breaking stuff
- making it easier to review changes
Who will be responsible for making the required changes?
- Everyone who is interested. The plan is to atleast get some of the most important pieces into a more readable state. Examples are dbus-sensors, entity-manager, x86-power-control.
- The plan is to enable some of these checks as errors once a repo comes into compliance. After that, contributors will be responsible to ensure their changes meet these checks.
Tradeoffs:
- There might be more code overall, as functions will be smaller. - People might be required to do another (refactoring) iteration on their changes if some of these checks become hard errors. - Refactoring code to meet these checks might introduce bugs.
[1] https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines
Change-Id: Icbdd55d2f672037a57d8ed08d52b20427e9e1e4f Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
show more ...
|
60fea57c | 17-Oct-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
docs: phosphor-health-monitor: add timestamps
Add support for adding timestamps to indicate when specific metric was collected. Existing EpochTime interface will be used for this purpose.
Change-Id
docs: phosphor-health-monitor: add timestamps
Add support for adding timestamps to indicate when specific metric was collected. Existing EpochTime interface will be used for this purpose.
Change-Id: I9d58baa50ad6da5b1137490398092bf5344ea729 Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
show more ...
|
6b367a2f | 16-Oct-2023 |
Lei YU <yulei.sh@bytedance.com> |
owners: Add Lei Yu to reviewers
Lei maintains several repos in OpenBMC and would like to become reviewer for general changes to OpenBMC.
Signed-off-by: Lei YU <yulei.sh@bytedance.com> Change-Id: I9
owners: Add Lei Yu to reviewers
Lei maintains several repos in OpenBMC and would like to become reviewer for general changes to OpenBMC.
Signed-off-by: Lei YU <yulei.sh@bytedance.com> Change-Id: I970d1ef6b4a2b80ca49cd8c7aa42839807fba181
show more ...
|
e1a27147 | 19-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: refresh settings from clang-17 docs
With later versions of clang, a number of settings we had previously are either deprecated or replaced from a simple boolean to an enumeration value
clang-format: refresh settings from clang-17 docs
With later versions of clang, a number of settings we had previously are either deprecated or replaced from a simple boolean to an enumeration value. Update them to reflect the intent.
Update a few settings based on new options available in clang-17 to minimize formatting churn.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ia0d5d3f9a48c60ab0f233166cfa481758d10491f
show more ...
|
19371049 | 12-Jul-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
docs: phosphor-health-monitor: design updates
This intent of this commit is to propose bunch of design updates for phosphor-health-monitor. More specifically, a new D-Bus interface.
Change-Id: I298
docs: phosphor-health-monitor: design updates
This intent of this commit is to propose bunch of design updates for phosphor-health-monitor. More specifically, a new D-Bus interface.
Change-Id: I298216136b8613accbcd3649f82cc8b657e00c50 Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
show more ...
|
7b4a8a79 | 13-Oct-2023 |
Gunnar Mills <gmills@us.ibm.com> |
TOF: Drop Brad
Brad's term has ended. Thank you for all our work!
Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Change-Id: I173668c4ef0fcf7e5a549d076f4b7db358501124 |
717d273c | 18-Sep-2023 |
Patrick Williams <patrick@stwcx.xyz> |
tof: membership: update for new terms
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I0aa63a8dd6811ca614d0e099115a12a9cc76ec2b |
afb213e0 | 25-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
tof: membership: adjust highly-productive to 80
For 2023H2, this puts the percent of highly-productive at ~14% with a reasonable gap between above and below.
Signed-off-by: Patrick Williams <patric
tof: membership: adjust highly-productive to 80
For 2023H2, this puts the percent of highly-productive at ~14% with a reasonable gap between above and below.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If3e9cac17c67215906c3f521599195bf7ed39af5
show more ...
|
0666ef8a | 12-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
c++: change desired language to C++23
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I7c69cbf4da5409c7fd105b946d10536e69c6c618 |
d8e8237d | 29-Jun-2023 |
Gunnar Mills <gmills@us.ibm.com> |
expired pw design: Switch to webui-vue
phosphor-webui has been replaced by webui-vue. Do so in this expired password design as well.
Change-Id: I8f09b8e346259ae647ad69dfd904903770cba4fa Signed-off-
expired pw design: Switch to webui-vue
phosphor-webui has been replaced by webui-vue. Do so in this expired password design as well.
Change-Id: I8f09b8e346259ae647ad69dfd904903770cba4fa Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
ddda2ff8 | 13-Jun-2023 |
Andrew Geissler <geissonator@yahoo.com> |
dev-environ: utilize devtool for code modifications
This moves from utilizing the SDK to using devtool in order to make a "hello world" test. As noted in the prior commit, this is done due to the co
dev-environ: utilize devtool for code modifications
This moves from utilizing the SDK to using devtool in order to make a "hello world" test. As noted in the prior commit, this is done due to the complexity of the SDK environment vs. the more consistent (but slower) devtool development process.
Change-Id: Iab7b6bbf82a5e36b121c1fedf916f956a35ca8e9 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|
f31c96df | 13-Jun-2023 |
Andrew Geissler <geissonator@yahoo.com> |
dev-environ: remove SDK and move to devtool
This is a series of patches to clean up our development tutorials. There's some miscellaneous cleanup combined with moving these from the use of the SDK t
dev-environ: remove SDK and move to devtool
This is a series of patches to clean up our development tutorials. There's some miscellaneous cleanup combined with moving these from the use of the SDK to devtool.
SDK usage, especially by new users of OpenBMC, can be confusing. You need to ensure you have the exact same level matching your version of openbmc/openbmc. There are consistently questions and confusion around the use of the SDK in discord and the mailing list. Although it can offer some extra speed with development, it's not a good area to have new users start with. Also, it does not seem many of our active OpenBMC developers use it, as it seems to consistently be missing packages required to build all of the OpenBMC repos.
Given the above, lets refocus these intro-to-openbmc tutorials on just using bitbake and devtool. It takes a bit longer but you're guaranteed to have the correct levels and all needed packages when doing this.
Change-Id: I7d50ea85a3489f702e98d7e8dca02e44886c2a5c Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|
1f98100d | 13-Jun-2023 |
Ed Tanous <edtanous@google.com> |
Change to designated reviewer
This is to disambiguate this class from any reviewer that might be in the Members class.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: I463211f803d4317f6cb
Change to designated reviewer
This is to disambiguate this class from any reviewer that might be in the Members class.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: I463211f803d4317f6cbbf38f3849729867150a61
show more ...
|
f44abd66 | 26-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Add design doc about optionality
Many patches these days ignore the concept of features being optional, and measuring impact to the project. This documentation attempts to close that gap, by having
Add design doc about optionality
Many patches these days ignore the concept of features being optional, and measuring impact to the project. This documentation attempts to close that gap, by having some explicitly defined language in the architecture that developers can reference in their commit messages, and maintainers can point to for general guidance on option flags.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: Id1ab8f1765110f58f22670db18db7ed226da6b57
show more ...
|
d62d386d | 17-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
release: delete outdated release process documents
To avoid confusion with processes that are no longer followed, delete these documents.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-
release: delete outdated release process documents
To avoid confusion with processes that are no longer followed, delete these documents.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ied444a1a00079ba52e447f1311553bf8089edcda
show more ...
|
3f90f507 | 17-May-2023 |
Ed Tanous <edtanous@google.com> |
Add a section about resigning
In the previous review, it was brought up that we should have a responsibility for resigning should the event occur. This commit codifies that.
Signed-off-by: Ed Tano
Add a section about resigning
In the previous review, it was brought up that we should have a responsibility for resigning should the event occur. This commit codifies that.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: I491dda468a4f4368d7443ad84e9fffa9d9105f8d
show more ...
|
25f45fc0 | 04-Jan-2023 |
Ed Tanous <edtanous@google.com> |
Add community membership document
This is largely based on the k8s document, with modifications to add "platform maintainer" as a title.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: If
Add community membership document
This is largely based on the k8s document, with modifications to add "platform maintainer" as a title.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: If33dc13d1810822f319bbc5c8140635ab3d181d9
show more ...
|
dc24b2ec | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: add IndentExternBlock setting
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I7cb11f19333775f3912f98a3a8bfd6559601fabc |
d1d05ee6 | 12-May-2023 |
Andrew Jeffery <andrew@aj.id.au> |
style: Add clang-format file for C code
This is based on libmctp and obmc-console's .clang-format with updates for clang-16.
Change-Id: I56535f1289fec55c3ce2b8c98ccc7e4904a62b75 Signed-off-by: Andr
style: Add clang-format file for C code
This is based on libmctp and obmc-console's .clang-format with updates for clang-16.
Change-Id: I56535f1289fec55c3ce2b8c98ccc7e4904a62b75 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
231ad0cd | 13-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: add clang-format-16 options
Some options are added and/or changed in clang-format-16. Attempt to define ones that cause the most churn in the codebase if left unset.
Signed-off-by: P
clang-format: add clang-format-16 options
Some options are added and/or changed in clang-format-16. Attempt to define ones that cause the most churn in the codebase if left unset.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I80217b5f8efeb4d5eeae3071149e6cfbe72f8046
show more ...
|
33d73e38 | 19-Dec-2022 |
Soroush Sherafat <71870584+sorousherafat@users.noreply.github.com> |
openbmc-systemd: fixed broken link.
Corrected markdown syntax mismatch and fixed broken URL.
Closes openbmc/docs#81.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I13df137c9241a56
openbmc-systemd: fixed broken link.
Corrected markdown syntax mismatch and fixed broken URL.
Closes openbmc/docs#81.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I13df137c9241a566a69500fb8608806b30ce2209
show more ...
|
1e09b3cb | 03-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
tof: membership: update for new terms
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If67454a436581c2077ff90cfa15e5b4174a5053e |