Add alternative way to add SSH key to gerrit

Added an explanation of how to manually add the github public SSH
key in case the plugin is not working correctly.

Change-Id: I7799fd48827e22e71ba82fddf

Add alternative way to add SSH key to gerrit

Added an explanation of how to manually add the github public SSH
key in case the plugin is not working correctly.

Change-Id: I7799fd48827e22e71ba82fddf12e2e688a848705
Signed-off-by: Roger G. Coscojuela <roger.gili-coscojuela@sipearl.com>

show more ...

clang-tidy: add default settings for headers

Add two settings to the default clang-tidy:

1. Set WarningsAsErrors - for strictness.
2. Set HeaderFilterRegex - to assist with meson subproject builds.

clang-tidy: add default settings for headers

Add two settings to the default clang-tidy:

1. Set WarningsAsErrors - for strictness.
2. Set HeaderFilterRegex - to assist with meson subproject builds.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I69cd2d5e7c816bc9fb433a810bc9f997e7721834

show more ...

clang-tidy: Add bugprone-unchecked-optional-access

Starting from meson 1.4.0[1], `-D_GLIBCXX_ASSERTIONS=1` is set if
`ndebug` is disabled.

This unveals a bug in the OpenBMC code, that it uses the s

clang-tidy: Add bugprone-unchecked-optional-access

Starting from meson 1.4.0[1], `-D_GLIBCXX_ASSERTIONS=1` is set if
`ndebug` is disabled.

This unveals a bug in the OpenBMC code, that it uses the std::optional
value without checking if it's empty.
It is undefined behavior, and without `-D_GLIBCXX_ASSERTIONS=1`, the
code runs OK to access the "default" value; And it gets assertion and
crash if `-D_GLIBCXX_ASSERTIONS=1` is set.

It is possible to use clang-tidy's `bugprone-unchecked-optional-access`
option to detect such issue in the build time.

[1]: https://mesonbuild.com/Release-notes-for-1-4-0.html#ndebug-setting-now-controls-c-stdlib-assertions

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I32f64b02b9593a6af6c26af66c386689717336dd

show more ...

clang-format: adjust PenaltyReturnTypeOnItOwnLine

Tweaking this format penalty was suggested during a review of the
latest clang-format results against dbus-sensors. The primary result
of this chan

clang-format: adjust PenaltyReturnTypeOnItOwnLine

Tweaking this format penalty was suggested during a review of the
latest clang-format results against dbus-sensors. The primary result
of this change is that long function names and arguments tend to not
be separated from their return type.

Before:
```
void
someReallyLongFunctionName(int andAnArg);
```

After:
```
void someReallyLongFunctionName(
int andAnArg);
```

My primary concern with this change is the readability of code
using post-function return types, but I don't see any evidence
of this affecting them when I apply this to a few repositories.

Example:
```
auto
someReallyLongFunctionName(int andAnArg) -> int;

// vs

auto someReallyLongFunctionName(
int andAnArg)
-> int;
```

An experimental version of this change is available[1].

[1]: https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/76859

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If7dac1a3c796a8145f0ca09b78941a23cabcdd7d

show more ...

Code update: Add PLDM package and EM configuration

PLDM image packaging can be used as one of the standardized option for
firmware image packages. Provide details on appropriate image
descriptors th

Code update: Add PLDM package and EM configuration

PLDM image packaging can be used as one of the standardized option for
firmware image packages. Provide details on appropriate image
descriptors that can be used by non-PLDM code updaters for image
validation and how to model this information in entity manager
configuration for firmware image validation and device access.

Related PR:
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/75947

Change-Id: I103969f70cbdf0aadf0518c273c3e8925ce24b90
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

design: gpio based hardware inventory

Design to support the gpio based detection of hardware.

Change-Id: Idbf2dc2cc77a637c58ad32af54c7c094a53a2a50
Signed-off-by: Alexander Hansen <alexander.hansen@

design: gpio based hardware inventory

Design to support the gpio based detection of hardware.

Change-Id: Idbf2dc2cc77a637c58ad32af54c7c094a53a2a50
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

pldm-stack: Update PLDM Fru inventory

As the discussion in [1], `pldmd` will directly host the FRU inventory
interfaces. Update the design spec.

[1] https://discord.com/channels/775381525260664832/

pldm-stack: Update PLDM Fru inventory

As the discussion in [1], `pldmd` will directly host the FRU inventory
interfaces. Update the design spec.

[1] https://discord.com/channels/775381525260664832/778790638563885086/1316606810031128647

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: Ie666023767dc785071ab9824b33733120f3c5c3d

show more ...

object-mapper: Clarify GetSubTree interfaces param

The existing documentation on the optional <interfaces> parameter to the
GetSubTree handler and other related handlers is not clear. The wording
im

object-mapper: Clarify GetSubTree interfaces param

The existing documentation on the optional <interfaces> parameter to the
GetSubTree handler and other related handlers is not clear. The wording
implies that the only interfaces returned in the dictionary will be the
ones specified by the <interfaces> parameter.

The examples show that is not the behavior.
The implementation of getSubTree() confirms this behavior. [1]

I've reworded like GetObject handler to clarify.

[1] https://github.com/openbmc/phosphor-objmgr/blob/d01fca35bf709c179ba5ade01b127b2a31ebfbce/src/handler.cpp#L139

Change-Id: Icdf407d677e8ba4c235bb10aad67d90e096ac88e
Signed-off-by: Janet Adkins <janeta@us.ibm.com>

show more ...

style: cpp: update for clang-format-19

There are a few options in our .clang-format file that are
deprecated in clang 19 and have alternative configurations
that match the same intention. Update ou

style: cpp: update for clang-format-19

There are a few options in our .clang-format file that are
deprecated in clang 19 and have alternative configurations
that match the same intention. Update our .clang-format to
be compliant.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie2f6eb3b043f2d655c9df806815afd7971fd0947

show more ...

ci: Apply prettier lint suggestions

This is blocking [new proposals][1] from passing CI.

[1]: https://gerrit.openbmc.org/c/openbmc/docs/+/76147

Change-Id: I3df57bd4e1abec93cb1775aa291295de9fa083f2

ci: Apply prettier lint suggestions

This is blocking [new proposals][1] from passing CI.

[1]: https://gerrit.openbmc.org/c/openbmc/docs/+/76147

Change-Id: I3df57bd4e1abec93cb1775aa291295de9fa083f2
Signed-off-by: Peter Delevoryas <peter@pjd.dev>

show more ...

design-template: Fix typo

Change-Id: Ie8fa5e930f7107f473cb27915ba0f2cf2e66ff82
Signed-off-by: Peter Delevoryas <peter@pjd.dev>

Replace scp with curl to download git hooks

The scp command as-is has stopped working on newer
Linux distributions and its much easier for users
to just download it via curl.

Change-Id: Ia77f01cf10

Replace scp with curl to download git hooks

The scp command as-is has stopped working on newer
Linux distributions and its much easier for users
to just download it via curl.

Change-Id: Ia77f01cf108318305886854e3b78c4d47c288dd5
Signed-off-by: Amithash Prasasd <amithash@meta.com>

show more ...

object-mapper: Add doc on AssociatedById handlers

This updates the documentation on the following new methods.
- GetAssociatedSubTreeById
- GetAssociatedSubTreePathsById

The handler is being implem

object-mapper: Add doc on AssociatedById handlers

This updates the documentation on the following new methods.
- GetAssociatedSubTreeById
- GetAssociatedSubTreePathsById

The handler is being implemented in
https://gerrit.openbmc.org/c/openbmc/phosphor-objmgr/+/70699

Change-Id: Iee98fb0da2a8bf1bde663ffc2502aa106e0ecf2f
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

devicetree vpd design now reflects tof discussion

Design doc for device-tree vpd parser now reflects TOF consensus that
no new repo is needed. 'Alternatives Considered' section has also been
updated

devicetree vpd design now reflects tof discussion

Design doc for device-tree vpd parser now reflects TOF consensus that
no new repo is needed. 'Alternatives Considered' section has also been
updated to reflect that the daemon will be hosted in Entity-Manager.

Change-Id: I3f669aa02ed50042247082720e6d533ccbaf16aa
Signed-off-by: Chris Sides <Christopher.Sides@hpe.com>

show more ...

entity-manager hw id: vpd discover via device-tree

Describes a way to make hardware identification data from device-tree
available to Entity-Manager for probe evaluations. Especially needed for
HPE

entity-manager hw id: vpd discover via device-tree

Describes a way to make hardware identification data from device-tree
available to Entity-Manager for probe evaluations. Especially needed for
HPE GXP systems that use non-standard formats and channels to present HW
ID Data (Vital Product Data)

Change-Id: I3055a77a6302165a1ca72b4213633ebe5d4a9313
Signed-off-by: Chris Sides <christopher.sides@hpe.com>

show more ...

tof: membership: update for new terms

[1]: https://lore.kernel.org/openbmc/ZvvKxr6Fb54In-4E@heinlein.vulture-banana.ts.net/

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5b4aaabdd

tof: membership: update for new terms

[1]: https://lore.kernel.org/openbmc/ZvvKxr6Fb54In-4E@heinlein.vulture-banana.ts.net/

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5b4aaabddd9f62213eb004fff3e9c8417d5a03cd

show more ...

design: BMC reboot cause event log

Design proposal for extending the BMC reboot cause event log mechanism

Change-Id: I9e50f5006fa3003db05b385db541566c4b73ed3c
Signed-off-by: Patrick NC Lin <patrick

design: BMC reboot cause event log

Design proposal for extending the BMC reboot cause event log mechanism

Change-Id: I9e50f5006fa3003db05b385db541566c4b73ed3c
Signed-off-by: Patrick NC Lin <patrick.nc.lin.wiwynn@gmail.com>

show more ...

PLDM-stack: Adding sensor monitoring section

The new added sections are for the design of enabling pldmd to monitor
sensor in PLDM terminus and expose to D-Bus interface. The proposal
currently cove

PLDM-stack: Adding sensor monitoring section

The new added sections are for the design of enabling pldmd to monitor
sensor in PLDM terminus and expose to D-Bus interface. The proposal
currently covers how to monitor numeric sensor and how to renew the
sensor status by polling or async method.

Signed-off-by: Gilbert Chen <gilbert.chen@arm.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: Icc851d1fcb7399c763a9000770cbd195d9f572de

show more ...

code-update: add missing actions after reset

Update the flow to add the creation of UpdateInterface and deletion of
interfaces on previous objectPath after the device has been reset.

Change-Id: I24

code-update: add missing actions after reset

Update the flow to add the creation of UpdateInterface and deletion of
interfaces on previous objectPath after the device has been reset.

Change-Id: I249c8910a3921dd137f06493f3138db34e693447
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

REDFISH-cheatsheet: add multipart form data update

Add the command for firmware update using multipart form data.

Change-Id: I7bbace99987b39edfcc14ec5fe10e9f7cbf44d36
Signed-off-by: Jagpal Singh Gi

REDFISH-cheatsheet: add multipart form data update

Add the command for firmware update using multipart form data.

Change-Id: I7bbace99987b39edfcc14ec5fe10e9f7cbf44d36
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

event-logging: reference the sdbusplus schema

Rather than a second (likely out of date) definition of the event
schema, point to the one in the sdbusplus repository.

Signed-off-by: Patrick Williams

event-logging: reference the sdbusplus schema

Rather than a second (likely out of date) definition of the event
schema, point to the one in the sdbusplus repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ae0c6034c92efe42196b96c0d02fbab2f29a4bf

show more ...

tof: membership: adjust highly-productive to 100

For 2024H1, if we leave the points at 80, we have over 30%
of the qualified members as "highly-productive" which is well
outside the expected range.

tof: membership: adjust highly-productive to 100

For 2024H1, if we leave the points at 80, we have over 30%
of the qualified members as "highly-productive" which is well
outside the expected range. There are large gaps between about
80-110 and 110-150 points. If we set the points at 150, we have
too few. If we set the points at 100 we have slightly too many,
but there are 3 developers close together between 100 and 105.
Picking 100 as a fair value that gets us close to the expected
percentage of active members.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic24bc622384241f8fa5c9d294e799040f1cac887

show more ...

ncsi-coredump: fix typo

Change-Id: I828eb8ffd93eccdad7529ea2919228ac4ff76c29
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

style: cpp: update for clang-format-18

clang-format-18 changed the behavior for lambda formatting,
and by adjusting the penalties we think we can get a more
consistent formatting with a more natural

style: cpp: update for clang-format-18

clang-format-18 changed the behavior for lambda formatting,
and by adjusting the penalties we think we can get a more
consistent formatting with a more natural indentation of lambdas.
Making these adjustments and will be reformatting all repositories
accordingly with clang-18.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5e08687e696dd240402a2780158664b7113def0e

show more ...

design: error and event logging

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I028d7ada80c1ba05ec6f9d12f8f6506202c926f6