Add new system: Fix doc

GitHub is rendering this as terrible looking red highlighted text. Fix
by making this correct JSON. It appears to be caused by some JSON
validation.

[1]: https://github.com/

Add new system: Fix doc

GitHub is rendering this as terrible looking red highlighted text. Fix
by making this correct JSON. It appears to be caused by some JSON
validation.

[1]: https://github.com/openbmc/docs/blob/44f3de929bbee0dbacd024b9724fe72817fd1f48/development/add-new-system.md?plain=1#L371

This was introduced years ago by
[2]: https://github.com/openbmc/docs/commit/ace9cd140d93e92c82b9bd705efea599cc5118e6

The GitHub rendering engine could have changed in that time.

Now that this was correct syntax, prettier had an opinion.

Tested: Pushed to my fork and looks good.

Change-Id: Idddfb94269665640cd94c9d920a02c91953898e0
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove Redfish Health Rollup

Health Rollup is unmaintained after the original author, James Feist,
left several years ago. Calls for an owner have gone unanswered. Its
implementation and design was

Remove Redfish Health Rollup

Health Rollup is unmaintained after the original author, James Feist,
left several years ago. Calls for an owner have gone unanswered. Its
implementation and design was only half done.

bmcweb is removing the redfish-health-populate option and its limited
support at https://gerrit.openbmc.org/c/openbmc/bmcweb/+/70450.

The option has been defaulted off for 10 months with no upstream layers
enabling it, and no discussions have been raised about keeping it.

It was always limited to a few resources.
A future "HealthRollup" can be proposed. Caution here that health rollup
is nontrivial to get correct, performance problems are a concern, and
hesitancy from the bmcweb maintainers due to multiple calls to get
people to own health rollup as a whole went completely unanswered.
Redfish probably needs better guidance on how health rollup needs to
work functionally.

Change-Id: Ib2d57ad05696ae81e41dcba31584b8786ba91714
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

tof: membership: update for new terms

[1]: https://lore.kernel.org/openbmc/Zf3otl5dVPv8wCcE@heinlein.vulture-banana.ts.net/

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If52c79319

tof: membership: update for new terms

[1]: https://lore.kernel.org/openbmc/Zf3otl5dVPv8wCcE@heinlein.vulture-banana.ts.net/

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If52c7931909a14ffe1d377b4dad2b65dd59ca35c

show more ...

Redfish cheatsheet: Correct Actions/Manager.ResetToDefaults command

According to the Redfish Data Model specification the correct parameter
name for the '/Actions/Manager.ResetToDefaults' action is

Redfish cheatsheet: Correct Actions/Manager.ResetToDefaults command

According to the Redfish Data Model specification the correct parameter
name for the '/Actions/Manager.ResetToDefaults' action is not
'ResetToDefaults' but 'ResetType'.
Change parameter name to match with the specification.

Change-Id: I92cda8479dff19e9cd0517d85973d05be8c73d9c
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS file, do that.

More discussion in Discord at
[1] https://discord.com/channels/775381525260664832/817151035197358081/1209585278025601094

Tested: With https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69549 my +2
means something again.

Change-Id: I091a5cc00acff4c268a86c6c9c79f705992738af
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

psu-firmware-update: add optional override param

The previous design only updated the PSU if the image in the BMC
filesystem was newer than the version on the PSU. These changes
allowed for an optio

psu-firmware-update: add optional override param

The previous design only updated the PSU if the image in the BMC
filesystem was newer than the version on the PSU. These changes
allowed for an optional override parameter to be used by the
vendor-specific tools to download the version from the BMC filesystem
to the PSU regardless of level of the firmware.

This is useful if the PSU needs to be back-leveled due to problems
later found in the new version of PSU firmware.

Change-Id: If8100b061a266a5aa0068880c8524cb359b41ced
Signed-off-by: Derek Howard <derekh@us.ibm.com>

show more ...

add designs/redfish-spdm-attestation.md

Propose a design for add Redfish SPDM support in BMCWeb,
with changes in phosphor-dbus-interfaces documented.

Redfish add schema for ComponentIntegrity
which

add designs/redfish-spdm-attestation.md

Propose a design for add Redfish SPDM support in BMCWeb,
with changes in phosphor-dbus-interfaces documented.

Redfish add schema for ComponentIntegrity
which allows user to use SPDM or TPM to authenticate device
identity and firmware integrity. It would be useful to add
SPDM attestation support in BMCWeb, which provides unified
interface for device security attestation in data center.

This design doc will focus on SPDM.

Change-Id: Id9674ce55230368a52652530cd93135678ef7a44
Signed-off-by: Zhichuang Sun <zhichuang@google.com>

show more ...

code-update: add design doc for revision to code update

This design doc is a revision to existing code update flow.

Change-Id: I84a5ae4b6501126a8318541156aeebe8b110416c
Signed-off-by: Jagpal Singh

code-update: add design doc for revision to code update

This design doc is a revision to existing code update flow.

Change-Id: I84a5ae4b6501126a8318541156aeebe8b110416c
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

CONTRIBUTING: Switch from scp to curl to fetch `commit_msg` hook

The existing scp command no longer works on modern distributions which
default to SFTP and not supported by Gerrit servers.
This chan

CONTRIBUTING: Switch from scp to curl to fetch `commit_msg` hook

The existing scp command no longer works on modern distributions which
default to SFTP and not supported by Gerrit servers.
This change switches to using curl which would minimize dependencies

Change-Id: I53273f37c3cff7031518eb93562244358aadea3e
Signed-off-by: Amithash Prasasd <amithash@meta.com>

show more ...

anti-patterns: Ill-defined data structuring in `lg2` message strings

Change-Id: Ib4cddad2425b5ab83f3bb248995c5a52806714dd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

OWNERS: Remove Andrew Jeffery from IBM OEM designs

Earlier this year I left IBM - I'll leave reviewing IBM's OEM designs
to Andrew G and Gunnar.

Change-Id: I7eab1cd4377489a2833fff94065d9b9310bd476c

OWNERS: Remove Andrew Jeffery from IBM OEM designs

Earlier this year I left IBM - I'll leave reviewing IBM's OEM designs
to Andrew G and Gunnar.

Change-Id: I7eab1cd4377489a2833fff94065d9b9310bd476c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

OWNERS: Update Andrew's preferred email

I'm reorganising things so work-related stuff goes to my work account,
so I'd prefer to have my work account as my email address in Gerrit. We
seem to have ru

OWNERS: Update Andrew's preferred email

I'm reorganising things so work-related stuff goes to my work account,
so I'd prefer to have my work account as my email address in Gerrit. We
seem to have run into some grief with non-preferred emails:

https://issues.gerritcodereview.com/issues/317345953

Change-Id: I4828d8f8b92470d73c030bd0e8415bacbf9745cb
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

bmc-health-monitor: unpluralize metrics in dbus interfaces

Align with typical dbus path and interface design and the latest
version of the dbus interfaces for Metric.Value.

Signed-off-by: Patrick W

bmc-health-monitor: unpluralize metrics in dbus interfaces

Align with typical dbus path and interface design and the latest
version of the dbus interfaces for Metric.Value.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1b82d9019262feb8e3c9795aeae5760811e77be7

show more ...

subproject-maintainership: Clarify the referenced preconditions

The text left the reader to their own devices to determine what was
meant. Avoid that by adding a link. Avoid further confusion by
cor

subproject-maintainership: Clarify the referenced preconditions

The text left the reader to their own devices to determine what was
meant. Avoid that by adding a link. Avoid further confusion by
correcting "above" to "below", which was a defect in the original
submission.

Change-Id: Idd40322f228696a57f63be6b5f2999d419038ed0
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

subproject-maintainership: Add ToC

Change-Id: Iae9dc415fe05b55fc41528705ddf403ce7871e9a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

design: Add SOL SysRq design doc

Add initial version of SOL SysRq design doc.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I7c14de106a71585b11eed4a9a27e0fb677a3a954

Add Discord rules

These rules are currently implemented using the rules screening feature
of Discord. However, I haven't found an obvious way to view them for
people who have already joined the serv

Add Discord rules

These rules are currently implemented using the rules screening feature
of Discord. However, I haven't found an obvious way to view them for
people who have already joined the server.

https://support.discord.com/hc/en-us/articles/1500000466882-Rules-Screening-FAQ

Change-Id: Ifb230303dc1f27aff0c164fd89d1fab27e46dae2
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-tidy: propose a base .clang-tidy

When there is a specific recommendation, it is taken from Cpp Core
guidelines [1] or clang-tidy defaults.

- readability-function-size.LineThreshold
was chos

clang-tidy: propose a base .clang-tidy

When there is a specific recommendation, it is taken from Cpp Core
guidelines [1] or clang-tidy defaults.

- readability-function-size.LineThreshold
was chosen to support
[ F.3 Keep functions short and simple ]

They recommend 60 lines to flag functions which would not fit on a
screen.

- readability-function-size.ParameterThreshold
was chosen to support
[ F.2: A function should perform a single logical operation ]

They recommend to be suspicious of functions with 7 or more
parameters.

- readability-function-cognitive-complexity.Threshold
was chosen to support
[ F.3: Keep functions short and simple ]

They recommend a cyclomatic complexity of 10 or less.
However, cyclomatic complexity is not implemented in clang-tidy,
therefore going with the clang-tidy default.

What is the goal of this change?

- making it easier for people to read the code.

- making it easier to perform refactorings without breaking stuff

- making it easier to review changes

Who will be responsible for making the required changes?

- Everyone who is interested. The plan is to atleast get some of the
most important pieces into a more readable state. Examples are
dbus-sensors, entity-manager, x86-power-control.

- The plan is to enable some of these checks as errors once a repo
comes into compliance. After that, contributors will be responsible
to ensure their changes meet these checks.

Tradeoffs:

- There might be more code overall, as functions will be smaller.
- People might be required to do another (refactoring) iteration on
their changes if some of these checks become hard errors.
- Refactoring code to meet these checks might introduce bugs.

[1] https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines

Change-Id: Icbdd55d2f672037a57d8ed08d52b20427e9e1e4f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

docs: phosphor-health-monitor: add timestamps

Add support for adding timestamps to indicate when specific metric was
collected. Existing EpochTime interface will be used for this purpose.

Change-Id

docs: phosphor-health-monitor: add timestamps

Add support for adding timestamps to indicate when specific metric was
collected. Existing EpochTime interface will be used for this purpose.

Change-Id: I9d58baa50ad6da5b1137490398092bf5344ea729
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

owners: Add Lei Yu to reviewers

Lei maintains several repos in OpenBMC and would like to become reviewer
for general changes to OpenBMC.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I9

owners: Add Lei Yu to reviewers

Lei maintains several repos in OpenBMC and would like to become reviewer
for general changes to OpenBMC.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I970d1ef6b4a2b80ca49cd8c7aa42839807fba181

show more ...

clang-format: refresh settings from clang-17 docs

With later versions of clang, a number of settings we had previously
are either deprecated or replaced from a simple boolean to an
enumeration value

clang-format: refresh settings from clang-17 docs

With later versions of clang, a number of settings we had previously
are either deprecated or replaced from a simple boolean to an
enumeration value. Update them to reflect the intent.

Update a few settings based on new options available in clang-17
to minimize formatting churn.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia0d5d3f9a48c60ab0f233166cfa481758d10491f

show more ...

docs: phosphor-health-monitor: design updates

This intent of this commit is to propose bunch of design updates for
phosphor-health-monitor. More specifically, a new D-Bus interface.

Change-Id: I298

docs: phosphor-health-monitor: design updates

This intent of this commit is to propose bunch of design updates for
phosphor-health-monitor. More specifically, a new D-Bus interface.

Change-Id: I298216136b8613accbcd3649f82cc8b657e00c50
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

TOF: Drop Brad

Brad's term has ended. Thank you for all our work!

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I173668c4ef0fcf7e5a549d076f4b7db358501124

tof: membership: update for new terms

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0aa63a8dd6811ca614d0e099115a12a9cc76ec2b

tof: membership: adjust highly-productive to 80

For 2023H2, this puts the percent of highly-productive at ~14%
with a reasonable gap between above and below.

Signed-off-by: Patrick Williams <patric

tof: membership: adjust highly-productive to 80

For 2023H2, this puts the percent of highly-productive at ~14%
with a reasonable gap between above and below.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If3e9cac17c67215906c3f521599195bf7ed39af5

show more ...