9c70ea06 | 06-Oct-2022 |
Glukhov Mikhail <mikl@greenfil.ru> |
ipmitool: fixing command parameters
Fixed commands that cause an error on run
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru> Change-Id: I9a1208e1f59f7b7039ed27aa5d48361510ea213a |
b90f17ff | 06-Oct-2022 |
Glukhov Mikhail <mikl@greenfil.ru> |
ipmitool: fixing line break
When using copy/paste commands, they should run
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru> Change-Id: I1783b805cad46b0f6529c69b2f8c9d422bd0d6ed |
9a8c365c | 05-Oct-2022 |
Gunnar Mills <gmills@us.ibm.com> |
Redfish-cheatsheet: Add Content-Type
From https://www.w3.org/Protocols/rfc2616/rfc2616-sec7.html#sec7.2.1: Any HTTP/1.1 message containing an entity-body SHOULD include a Content-Type header field d
Redfish-cheatsheet: Add Content-Type
From https://www.w3.org/Protocols/rfc2616/rfc2616-sec7.html#sec7.2.1: Any HTTP/1.1 message containing an entity-body SHOULD include a Content-Type header field defining the media type of that body.
Redfish also mentions this "In HTTP messages, the media type is specified in the Content-Type header."
Tested: Did a few of these POSTs and PATCHes. Work as expected.
Change-Id: Ie20ddf6679b09646d348b6996190dca6529e2316 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
06136285 | 29-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: use options for C++20 requires
clang-15 adds options to format C++20 Concepts `requires` statements. Set them now so we have consistency in any code which starts to use C++20 Concepts
clang-format: use options for C++20 requires
clang-15 adds options to format C++20 Concepts `requires` statements. Set them now so we have consistency in any code which starts to use C++20 Concepts.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If75f8ebdf46855423a4ffb1dba598e9c61d9a462
show more ...
|
c742fe86 | 29-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: tweak alignment settings
We already use 'PointerAlignment: Left'. clang-13 and clang-14 added 'QualifierAlignment' and 'ReferenceAlignment' options. Set those to left similarly.
Qua
clang-format: tweak alignment settings
We already use 'PointerAlignment: Left'. clang-13 and clang-14 added 'QualifierAlignment' and 'ReferenceAlignment' options. Set those to left similarly.
QualifierAlignment sets: * `const int` - right * `int const` - wrong
ReferenceAlignment sets: * `int& foo` - right * `int &foo` - wrong
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I17f2457b10682513ed5d824ce8c506dee833a744
show more ...
|
ba68be6a | 29-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: tweak penalty values
clang-format-15 seems to end up with a slightly different whitespace break than clang-format-14 did. Tweak the PenaltyBreakAssignment to favor not breaking as oft
clang-format: tweak penalty values
clang-format-15 seems to end up with a slightly different whitespace break than clang-format-14 did. Tweak the PenaltyBreakAssignment to favor not breaking as often, which allows the two to be more consistent.
This is already applied to sdbusplus as I49826e2011bce317b6b82dc985ddd35fa6eef2cb.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I455cc4bf29097e3d0462a7c1b667d21e382af104
show more ...
|
e12059ab | 01-Jun-2022 |
Benjamin Fair <benjaminfair@google.com> |
Physical topology design
This design describes a way to encode information about the physical topology of a system such as one chassis containing another or being powered by a power supply. It also
Physical topology design
This design describes a way to encode information about the physical topology of a system such as one chassis containing another or being powered by a power supply. It also explains how this information will be consumed by daemons such as bmcweb to represent it in Redfish.
Signed-off-by: Benjamin Fair <benjaminfair@google.com> Change-Id: If0c0193b6bc2eae79d82756462d23ef7084f9fc1
show more ...
|
40d4c066 | 14-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
tof: membership: update for new terms
The 2022H2 elections only had 3 nominations. Automatically add them all to the next terms.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I5e7
tof: membership: update for new terms
The 2022H2 elections only had 3 nominations. Automatically add them all to the next terms.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I5e75e48431f9e57ebe0095edc7aae4ae9e214488
show more ...
|
503fbd34 | 09-Sep-2022 |
Brandon Kim <brandonkim@google.com> |
designs: bios-bmc-smm-error-logging: Change header
During this review: https://gerrit.openbmc.org/c/openbmc/docs/+/52109
We noted that we should increase the queueSize header to increase the bigger
designs: bios-bmc-smm-error-logging: Change header
During this review: https://gerrit.openbmc.org/c/openbmc/docs/+/52109
We noted that we should increase the queueSize header to increase the bigger supported queue size. The BIOS team and the BMC team implementing this decided that 3 byte size gave enough size increase to the queue size (up to 16MB) and gave us more padding / reserved bytes in the header for future flexibility instead of increasing to 4 bytes.
As we are lacking README.md for the repo, update the design doc so that this header is matching the code.
Signed-off-by: Brandon Kim <brandonkim@google.com> Change-Id: Ifecfc64148e63f8f727e8f3c732bca7e17d31b87
show more ...
|
c1768568 | 09-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
workflow: switch openbmc-env for setup
There are upstream changes in poky that are forcing TEMPLATECONF to be used differently. Rather than try to track those changes, I am switching the documentat
workflow: switch openbmc-env for setup
There are upstream changes in poky that are forcing TEMPLATECONF to be used differently. Rather than try to track those changes, I am switching the documentation to use `setup`, which has existed for a number of years and is a simpler way to get started.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I258a38b455a14ebad7952e7480ece965e2b1edfd
show more ...
|
70bbfb44 | 06-Sep-2022 |
Jae Hyun Yoo <quic_jaehyoo@quicinc.com> |
Redfish cheatsheet: fix the 'ApplyTime' descriptions
Fix descriptions of the 'ApplyTime' setting to make it work on the latest code tree.
Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> Chan
Redfish cheatsheet: fix the 'ApplyTime' descriptions
Fix descriptions of the 'ApplyTime' setting to make it work on the latest code tree.
Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> Change-Id: I923ea70bc2c59dc55f0e10e0c1a44ea917e35422
show more ...
|
33bd07ba | 08-Sep-2022 |
Patrick Williams <patrick@stwcx.xyz> |
oem: move ibm subdirectory into oem tree
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I983773d91af2807faa60a47a3ebc61b34dcb1f73 |
33940c03 | 02-Sep-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
mctp-userspace: wrap at 79
This is aligned with the design template. Done by vim gq.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: I1b4f7408f24776e88f6b5e6b1d1b525e9a32f249 |
5d52507e | 02-Sep-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
mctp: fix a hyperlink
The original syntax is wrong. It should be [DisplayText](link).
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: Ice0304b29785de3efa09497a63de0d3cb91ec3da |
3547af1f | 26-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: allow some empty blocks on single line
Enable AllowShortBLocksOnASingleLine and AllowShortFunctionsOnASingleLine as 'Empty' instead of 'false'. This allows the code to be slightly mor
clang-format: allow some empty blocks on single line
Enable AllowShortBLocksOnASingleLine and AllowShortFunctionsOnASingleLine as 'Empty' instead of 'false'. This allows the code to be slightly more compact in the already readable case of an empty block. In sdbusplus this yields some minor simplifications such as:
``` - compose(bus_t&, const char*) - {} + compose(bus_t&, const char*) {} ```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I39423dc80c057674e16d23389f4e4d88aae80e6f
show more ...
|
106b09c1 | 27-Jul-2022 |
Joseph Reynolds <joseph-reynolds@charter.net> |
Use github security advisories
This updates the OpenBMC security vulnerability reporting process to use GitHub advisories. Each repository owner/maintainer is responsible for their security problem
Use github security advisories
This updates the OpenBMC security vulnerability reporting process to use GitHub advisories. Each repository owner/maintainer is responsible for their security problems, and the security response team advises and creates CVEs.
Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net> Change-Id: Ic9e169b4c94b625c9af838ef0c03c78fa0300031
show more ...
|
0b7780b5 | 17-Mar-2022 |
Brandon Kim <brandonkim@google.com> |
design: Add bios-bmc-smm-error-logging.md
This design doc is for providing a shared buffer between the BMC and the BIOS that allows the BIOS to send a very fast message without requiring an ack from
design: Add bios-bmc-smm-error-logging.md
This design doc is for providing a shared buffer between the BMC and the BIOS that allows the BIOS to send a very fast message without requiring an ack from the BMC within SMM.
Signed-off-by: Brandon Kim <brandonkim@google.com> Change-Id: Id76029a9f5c869a5e2a77fd53843c926b438b67d
show more ...
|
610a7b8f | 06-Aug-2022 |
Ruud A. Haring <ruud@us.ibm.com> |
interface-overview.md : fix broken links for BMCWeb configuration
Signed-off-by: Ruud A. Haring <ruud@us.ibm.com> Change-Id: Ibaf98149843aa3bc55d189de02b1dda9abd74bb2 |
fa1cca72 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
MAINTAINERS: remove file
The MAINTAINERS file is deprecated in favor of OWNERS.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I49ca719e728846cd165f38ace6b418cf4df57f51
|
91f51777 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
OWNERS: switch references from MAINTAINERS
MAINTAINERS files are now deprecated and/or removed and replaced by OWNERS. Update the documentation accordingly.
Signed-off-by: Patrick Williams <patric
OWNERS: switch references from MAINTAINERS
MAINTAINERS files are now deprecated and/or removed and replaced by OWNERS. Update the documentation accordingly.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I9c7e6ca3aeb41ea8f92ddc42072252d4f65de0aa
show more ...
|
7d092034 | 04-Aug-2022 |
Glukhov Mikhail <mikl@greenfil.ru> |
gerrit-setup: Update rsa to ed25519
Since openssh 8.8 rsa signatures are disabled https://www.openssh.com/txt/release-8.8 Test: Ubuntu 22.04 rsa key does not give access to gerrit, Ed25519 - no acce
gerrit-setup: Update rsa to ed25519
Since openssh 8.8 rsa signatures are disabled https://www.openssh.com/txt/release-8.8 Test: Ubuntu 22.04 rsa key does not give access to gerrit, Ed25519 - no access problems
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru> Change-Id: I7fdb9cf003f90ebbc3adabf01324db9c6d891654
show more ...
|
9db762d8 | 24-Jul-2022 |
Andrew Jeffery <andrew@aj.id.au> |
design-template: Design proposals are argumentative essays.
State this explicitly in the guidelines. The Grammarly blog post is excellent and well worth the read.
Change-Id: I06ef86fab5601e3ad0e8b5
design-template: Design proposals are argumentative essays.
State this explicitly in the guidelines. The Grammarly blog post is excellent and well worth the read.
Change-Id: I06ef86fab5601e3ad0e8b5b2fefd85aec25a6015 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
33b25295 | 24-Jul-2022 |
Andrew Jeffery <andrew@aj.id.au> |
design-template: Organise guidelines
Add some sub-headers and rename the section to "Document Guidelines". Do the rename because the section is guiding you on when/how to write the document, not how
design-template: Organise guidelines
Add some sub-headers and rename the section to "Document Guidelines". Do the rename because the section is guiding you on when/how to write the document, not how to design your thingo.
Change-Id: Iddf5540e80d5af00c9ef49bd1f7077cd4dfdddaa Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
e2430b15 | 23-Jul-2022 |
Ed Tanous <edtanous@google.com> |
Update organizational section with maintainer cc
Lots of designs get submitted that seem to omit the maintainers from the CC list, as well as designs that focus on only one part of the design (somet
Update organizational section with maintainer cc
Lots of designs get submitted that seem to omit the maintainers from the CC list, as well as designs that focus on only one part of the design (sometimes dbus, sometimes redfish, sometimes IPMI) without considering the whole system.
This commit adds a section to the design template for "repos that are expected to be modified", so that we can make sure the required reviewers are present on the design. This also helps as a hint to reviewers that they need to account for their whole design (hw->dbus->user interface), not just a single piece, like dbus->user interface or hw->dbus.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: I74d34dafe7da0c83484df7afa96d3aef12efcc27
show more ...
|
a3d471d4 | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have the correct field.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ic3dc0413f4eb84407ce0a3d883a2b39710442ec3
show more ...
|