Remove size checks from .clang-tidy

These two checks around cognative complexity and function size were put
in this file aspirationally. To date no repositories have been able to
successfully enabl

Remove size checks from .clang-tidy

These two checks around cognative complexity and function size were put
in this file aspirationally. To date no repositories have been able to
successfully enable these two checks. This maintainer has personally
tried and we'd either have to bypass so many functions that the check
became more cumbersome to maintain, or we'd have to raise the limits to
where they were not useful. While I'm hopeful that these checks could
be enabled in the future, they don't match the reality of where tidy is
at.

As a side note, one thing asio-based repos suffer from is overly large
inline lambdas. cognative complexity and length checks do not take
those into account when measuring line count, and in some cases seem to
actively disable the checks, so even if we were able to enable these
checks, as implemented in clang they're not useful in a lot of scenarios
today.

To ensure that the content is not lost, these two checks are moved into
documentation (tidy-desired.md) that can track the desire to enable
these checks, even if we're not able to do so today.

Change-Id: Ic86066f21f0c01a4d7b27a02829564f693f8b00b
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...