ExternalSensor: New service for external sensors

This code was mostly copied from HwmonTempSensor, and inspired by the
initial proof of concept from https://gerrit.openbmc-project.xyz/35476

Externa

ExternalSensor: New service for external sensors

This code was mostly copied from HwmonTempSensor, and inspired by the
initial proof of concept from https://gerrit.openbmc-project.xyz/35476

External sensors are designed to be placeholders, with no hwmon or
other hardware support locally. Thus, there is no detection or kernel
driver load, so no change is necessary to entity-manager.

The expectation is that these sensors will be updated by something
external to the BMC, such as the host, which can be useful for
including host-based sensors into phosphor-pid-control thermal zones.

* Added systemd service file, similar to the others.
* Added CMakeLists blocks, similar to the others.
* Also cleaned up some nearby formatting in CMakeLists.

Tested: With the addition of the Mutable feature from 36275, and the
installation of the systemd file from 36272, and a change to our IPMI
daemon (still in the process of being upstreamed), the host can write
to a sensor over IPMI. It correctly shows up in the IPMI SDR, and the
written value correctly shows up on the D-Bus ExternalSensor here.

Here is example JSON for use with entity-manager:
{
"Name": "HostOnlyDevTemp",
"Measure": "temperature",
"MinValue": -10.0,
"MaxValue": 117.5,
"Type": "ExternalSensor"
},

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Id499e1cd6c7918179bb1729e5ce8546cf4121dfa
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

Fan: Eliminate one unnecessary loop by using known fanType

Given we have known the fanType, we don't need to loop through all fan
types. In order to use fanType as the index for the sensorTypes arra

Fan: Eliminate one unnecessary loop by using known fanType

Given we have known the fanType, we don't need to loop through all fan
types. In order to use fanType as the index for the sensorTypes array,
we need to change "enum class FanTypes" to "enum FanTypes". Otherwise,
we will get a compiling error.

This also fixes an issue that an I2C fan could be incorrectly processed
as a Nuvoton or Aspee fan when they are used together.

Tested: the fan sensors are seen in the ipmitool sensor list.

Signed-off-by: Yong Zhao <yozhao@google.com>
Change-Id: I474a149e01b06a5a2e883aaa840486ef97965775

show more ...

dbus-sensors: PwmSensor math types cleanup

Cleaned up types during math to avoid precision loss.
Integer pwmMax and associated constants now double.
Avoid floating-point comparison, convert to int f

dbus-sensors: PwmSensor math types cleanup

Cleaned up types during math to avoid precision loss.
Integer pwmMax and associated constants now double.
Avoid floating-point comparison, convert to int first.
Corrected rounding from float to int.
Property setter now ignores floating-point NaN.

Rounding done more consistently and correctly now. In some edge
cases, the fan PWM setting will be different from what it was
before, because rounding is now proper instead of truncating.

Tested: Swept fans from 0.0 to 100.0 percent, stepping by 0.1 each
time, to exercise all values between 0 and 255. Behavior now seems
more correct to me. Also set NaN, and it was properly ignored.
Also tested on the uint64_t interface, swept from 0 to 255,
each value mapped cleanly to equivalent floating-point value.

Not tested on "PSU" fans. These are a special case, as the integers
in the underlying file range from 0 to 100, not 0 to 255. The
original logic to handle these remains unchanged, however.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Ibc9ad978c1567bb2e7116e00d84e43b4ae22e664

show more ...

cpusensor: change Min/Max values for power

minValue and maxValue are currently hardcoded for all cpusensors to
-128 and 127 respectively. There is no sense to have negative values for
power sensors

cpusensor: change Min/Max values for power

minValue and maxValue are currently hardcoded for all cpusensors to
-128 and 127 respectively. There is no sense to have negative values for
power sensors but CPU power consumption can be higher than 127W.
Change Min/Max to 0...511 for power sensors.

Tested: busctl introspect xyz.openbmc_project.CPUSensor /xyz/openbmc_project/sensors/power/Average_Power_CPU0
xyz.openbmc_project.Sensor.Value interface -- -
.MaxValue property d 511 emits-change
.MinValue property d 0 emits-change
.Unit property s "xyz.openbmc_project.Sensor.Value.Unit.… emits-change
.Value property d 64.393 emits-change writable

Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: I0dafdd657194b1b4d709ce093b658a89120f81f9

show more ...

Correct ADC sensors max reading

Set ADC max reading to be reference voltage 1.8Volt.
Calculate maxReading from it. This fixes threshold hysteresis.

Tested:
Use sensor override to trigger alarm and

Correct ADC sensors max reading

Set ADC max reading to be reference voltage 1.8Volt.
Calculate maxReading from it. This fixes threshold hysteresis.

Tested:
Use sensor override to trigger alarm and verify that
de-assert happens when sensor reading back to normal.
Without the change, the de-assert never happens.
Example:
busctl set-property xyz.openbmc_project.ADCSensor /xyz/openbmc_project/sensors/voltage/ABC_CPU1 xyz.openbmc_project.Sensor.Value Value d 1.348
intel-obmc adcsensor[412]: Sensor ABC_CPU1 high threshold 1.301 assert: value 1.348 raw data 1244
intel-obmc adcsensor[412]: Sensor ABC_CPU1 high threshold 1.263 assert: value 1.348 raw data 1244
intel-obmc ipmid[242]: thresholdChanged: Assert
intel-obmc ipmid[242]: thresholdChanged: Assert
intel-obmc sel-logger[288]: ABC_CPU1 sensor crossed a critical high threshold going high. Reading=1.348000 Threshold=1.301000.
intel-obmc sel-logger[288]: ABC_CPU1 sensor crossed a warning high threshold going high. Reading=1.348000 Threshold=1.263000.
intel-obmc ipmid[242]: thresholdChanged: deassert
intel-obmc ipmid[242]: thresholdChanged: deassert
intel-obmc sel-logger[288]: ABC_CPU1 sensor crossed a critical high threshold going low. Reading=1.244000 Threshold=1.301000.
intel-obmc sel-logger[288]: ABC_CPU1 sensor crossed a warning high threshold going low. Reading=1.244000 Threshold=1.263000.

Also ran "ipmitool sensor list" and varified ADCSensor values are correct
A P12V PSU SCALE | 12.096 | Volts | ok | na | 10.647 | 10.962 | 13.104 | 13.482 | na
P1V8 PCH | 1.805 | Volts | ok | na | 1.645 | 1.701 | 1.908 | 1.965 | na
P3V3 | 3.320 | Volts | ok | na | 2.976 | 3.062 | 3.543 | 3.646 | na
P3VBAT | 3.074 | Volts | ok | na | 2.141 | 2.459 | 3.265 | 3.286 | na
P12V AUX | 12.096 | Volts | ok | na | 10.647 | 10.962 | 13.104 | 13.482 | na
P105 PCH AUX | 1.058 | Volts | ok | na | 0.966 | 0.994 | 1.108 | 1.136 | na
PVCCIN CPU1 | 1.824 | Volts | ok | na | 1.372 | 1.419 | 2.087 | 2.153 | na
PVCCIO CPU1 | 1.030 | Volts | ok | na | 0.731 | 0.753 | 1.157 | 1.193 | na
PVDQ ABC CPU1 | 1.243 | Volts | ok | na | 1.101 | 1.136 | 1.264 | 1.299 | na
PVDQ DEF CPU1 | 1.243 | Volts | ok | na | 1.101 | 1.136 | 1.264 | 1.299 | na
PVNN PCH AUX | 0.902 | Volts | ok | na | 0.781 | 0.809 | 1.051 | 1.079 | na

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: If0dd132f963253172862d1b5e2b96c3bbedcdfd4

show more ...

PSUSensors: Move to GetSensorConfiguration

GetSensorConfiguration has improved to have retries
and avoid more expensive GetManagedOjects calls. Use
it.

Tested
PSU sensors are created consistently a

PSUSensors: Move to GetSensorConfiguration

GetSensorConfiguration has improved to have retries
and avoid more expensive GetManagedOjects calls. Use
it.

Tested
PSU sensors are created consistently ac_cycle test

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Id6b374ff415cc7c6c0d83b55f12551556838f2b7

show more ...

IpmbSensor:Fix SMBus configuration for VR Temp.

The SMBus index configuration for VR Temp sensor is different
for some platforms.
Hence, SMBus index in which these sensors are connected
is made as D

IpmbSensor:Fix SMBus configuration for VR Temp.

The SMBus index configuration for VR Temp sensor is different
for some platforms.
Hence, SMBus index in which these sensors are connected
is made as D-Bus property, read from xx_baseboard.json file.
Also, sensor read request commands modified to use this value.

Tested :
1.Dediprog and redfish flash the different platforms,
with[SMBus index read from json file] and
without[default SMBus index =3] this configuration change.
- System up and running.
- VR Temp sensor and other sensor readings shows
correctly in 'ipmitool sensor list' output.

Signed-off-by: Anoop S <anoopx.s@intel.com>
Change-Id: Ia106f1c699f5f1515c90585309a65ede37906f18

show more ...

NVMeSensor: use available interface for error handling

Sensor available and functional interfaces are used to
handle sensor not readable and read errors.
Update NVMeSensor to use them.

Tested
No re

NVMeSensor: use available interface for error handling

Sensor available and functional interfaces are used to
handle sensor not readable and read errors.
Update NVMeSensor to use them.

Tested
No regression detected in NVMeSensor read value

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Iabaf2508d14b3562cfe04992c9558a0114a9665e

show more ...

hwmontemp: Add emc1412 and emc1414 support

Adds EMC1412 and EMC1414 in sensorTypes array

Tested:
Tested on a system that uses emc1412 and emc1414 for temperature monitoring.

Signed-off-by: Gilbert

hwmontemp: Add emc1412 and emc1414 support

Adds EMC1412 and EMC1414 in sensorTypes array

Tested:
Tested on a system that uses emc1412 and emc1414 for temperature monitoring.

Signed-off-by: Gilbert Chen <gilbert.chen@hpe.com>
Change-Id: Ie4c53b2aa47a2d64d2e42c388ddf2391ebb35745

show more ...

Fix index checking to support double digit index.

If hwmon sysfs has double digit pwm index, fansensor service
incorrectly creates PWM sensors so some pwm sensors are missing.
For an example, pwm1 a

Fix index checking to support double digit index.

If hwmon sysfs has double digit pwm index, fansensor service
incorrectly creates PWM sensors so some pwm sensors are missing.
For an example, pwm1 and pwm11 are checked as Pwm_1 like below.
/sys/class/hwmon/hwmon0/pwm1 -> Pwm_1
/sys/class/hwmon/hwmon0/pwm11 -> Pwm_1

To fix the issue, this commit changes the index checking logic to
support double digits as well.

Tested: pwm11 was created as Pwm_11 and pwm1 was created as Pwm1.

Change-Id: Icfdec1ce186b22ce95e3582ac6a93285a818f596
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

ExitAir: Move to GetSensorConfiguration

GetSensorConfiguration has improved to have retries
and avoid more expensive GetManagedOjects calls. Use
it.

Tested: System Airflow still worked

Change-Id:

ExitAir: Move to GetSensorConfiguration

GetSensorConfiguration has improved to have retries
and avoid more expensive GetManagedOjects calls. Use
it.

Tested: System Airflow still worked

Change-Id: Icbbabb6ebda771b9cde563559a83f633ffc3769f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

hwmontemp: add labels attribute support

Adds Labels support to Hwmontemp. The behavior is meant to be identical
to the behavior of Labels from PSUSensors.

Labels has the following behavior:
When d

hwmontemp: add labels attribute support

Adds Labels support to Hwmontemp. The behavior is meant to be identical
to the behavior of Labels from PSUSensors.

Labels has the following behavior:
When discovering Name, Name1...NameX attributes from the configuration
and an associated temp is found
If tempX_label exists and its contents is in the Labels attribute then
create the sensor
If tempX_label does not exist but tempX is in the Labels attribute then
create the sensor
If Labels attribute is not present or is an empty list then create the
sensor

Tested:
Had a simple , publically available MAX6581 sensor that has
temp1, temp2, temp3, temp4, temp5
and tested with
Labels = ["temp1", "temp2", "temp3", "temp4", "temp5"]
├─/xyz/openbmc_project/sensors/temperature/max6581_1
├─/xyz/openbmc_project/sensors/temperature/max6581_2
├─/xyz/openbmc_project/sensors/temperature/max6581_3
├─/xyz/openbmc_project/sensors/temperature/max6581_4
├─/xyz/openbmc_project/sensors/temperature/max6581_5
Labels omitted
├─/xyz/openbmc_project/sensors/temperature/max6581_1
├─/xyz/openbmc_project/sensors/temperature/max6581_2
├─/xyz/openbmc_project/sensors/temperature/max6581_3
├─/xyz/openbmc_project/sensors/temperature/max6581_4
├─/xyz/openbmc_project/sensors/temperature/max6581_5

Labels containing temp2,temp5
Results:
├─/xyz/openbmc_project/sensors/temperature/max6581_2
├─/xyz/openbmc_project/sensors/temperature/max6581_5

And a similar test with a device that has temperature labels
"Labels": [
"device_label_A",
"device_label_B",
"device_label_C"
],

├─/xyz/openbmc_project/sensors/temperature/device1_label_A
├─/xyz/openbmc_project/sensors/temperature/device1_label_B
├─/xyz/openbmc_project/sensors/temperature/device1_label_C

Signed-off-by: Jason Ling <jasonling@google.com>
Change-Id: I6cb9edb0c7ae68fe01663d4ee1be0070715e9f82

show more ...

PSUSensors: add support for vout17

Add support for vouts up to vout32.

Tested:
Tested on a system where the hwmon(pmbus) driver had a in17_label that
read vout17. Unable to test past vout17.
Voltag

PSUSensors: add support for vout17

Add support for vouts up to vout32.

Tested:
Tested on a system where the hwmon(pmbus) driver had a in17_label that
read vout17. Unable to test past vout17.
Voltage reading using ipmi tool sensor list looked reasonable

Signed-off-by: Jason Ling <jasonling@google.com>
Change-Id: Id280898cf1fc9bdaa56b87f381c5d55b961e72d7

show more ...

Using reference to avoid copy

With this commit a reference will be used during some structure
binding to avoid copies.

Tested:
CPUSensors and PSUSensors launched on physical machine, no
regre

Using reference to avoid copy

With this commit a reference will be used during some structure
binding to avoid copies.

Tested:
CPUSensors and PSUSensors launched on physical machine, no
regression detected.

Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I7aa270e440e9aadeca151acc6d9b73d7c4c4f40c

show more ...

Add LED Support to Fan Sensor

This allows the fan sensor to trip an LED when a critical
threshold is crossed.

Tested: Saw LED d-bus object in Group manager get set
using sensor override

Change-Id:

Add LED Support to Fan Sensor

This allows the fan sensor to trip an LED when a critical
threshold is crossed.

Tested: Saw LED d-bus object in Group manager get set
using sensor override

Change-Id: Iab5a69ded20de6e3ac99e9ac687c60605d5763d1
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix PSU PWM fan control

105a19754f003956def5934612b1de86225a4bc1 broke the control
interface range as the interface is supposed to accept 0-255
fix it.

Tested:
PSU PID control worked again

Change-

Fix PSU PWM fan control

105a19754f003956def5934612b1de86225a4bc1 broke the control
interface range as the interface is supposed to accept 0-255
fix it.

Tested:
PSU PID control worked again

Change-Id: I89c03c3382b221256353cc28b1f182c80a063249
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Reading min and max values from the rated files exposed by hwmon

With kernel 5.10 hwmon will expose PSU capabilities files. They will
have endings `_rated_min` and `_rated_max`. This commit allows
P

Reading min and max values from the rated files exposed by hwmon

With kernel 5.10 hwmon will expose PSU capabilities files. They will
have endings `_rated_min` and `_rated_max`. This commit allows
PSUSensor to utilize these files. If `rated` files are available
for given sensor then values read from these files will be used to
overwrite the MaxValue and MinValue default values.
The min/max update will be done with frequency 8x times lower than
the sensor value is updated, because in most cases they will not
change too often and for now there is no need to read them more
often.

Tested:
Test were done manually, no regression detected.
CPU usage stays at the same level.
Min and max values are updated properly.

Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: Icbefcbeb605d0ebd3e127613181fbc5023f118e8

show more ...

Move dbus connection into base sensor object

This seems common through most sensors, might as
well move it for consistency.

Tested: sensors operational as normal

Change-Id: I4e6c55cbb7171ee5170001

Move dbus connection into base sensor object

This seems common through most sensors, might as
well move it for consistency.

Tested: sensors operational as normal

Change-Id: I4e6c55cbb7171ee51700015f8c2ef8c05c90fb4e
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

revert "revert log debug information for sensor threshold assert events"

Add back the orignial submit 9bf6804c2d76b92005ad9851cb052d407ea3117f
and includes the fix the bug that crashed ipmbsensor.

revert "revert log debug information for sensor threshold assert events"

Add back the orignial submit 9bf6804c2d76b92005ad9851cb052d407ea3117f
and includes the fix the bug that crashed ipmbsensor.

log debug information for sensor threshold assert events

There are sightings that TCPUx_P12_PVCCIO_VS_Temp Sensor
reports reading of zero and trips the low critical threshold.
Add debug prints to gather data.

Also add logs for raw value in sensor base class to help
debug threshold assert events for other sensor type.

Tested:
Verified that log messages show up as expected for threshold
assert events. There is no unwanted log messages on systems that
do not have bad sensor readings.
Verified system stayed up for 30 minutes without crashing.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I73e00e24bbae463dbe0f34e2308ee934588028d1

show more ...

Reading min, max values for ‘cap’ every 8 times.

There is no need to read min and max values of CPU
capabilities with every second. The CPU capabilities
doesn’t change to often if ever. The hwmon up

Reading min, max values for ‘cap’ every 8 times.

There is no need to read min and max values of CPU
capabilities with every second. The CPU capabilities
doesn’t change to often if ever. The hwmon updated the
cap files with cycle of 10sec.
Reading min and max value every 8 times should be enough
in this case.

Tested:
Working as expected, no regression detected.

Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I86c6b5542d3e2f3475aef3c5b05b305f87c6ef39

show more ...

Add retries into power control status commands

On first boot we're seeing an occasional miss of the
power status, but the match never being fired. This seems
to be caused by the sensors overwelming

Add retries into power control status commands

On first boot we're seeing an occasional miss of the
power status, but the match never being fired. This seems
to be caused by the sensors overwelming power control
by requesting too often. Add in a couple retries to
make sure we get the status.

Tested: On system with 100% production rate, cpu sensor
readings were valid

Change-Id: I19d3a342558db95c3a55ed8cb287df6629818c6a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Revert "log debug information for sensor threshold assert events"

This reverts commit 9bf6804c2d76b92005ad9851cb052d407ea3117f.
This causes ipmbsensor crash

Change-Id: I8517d801ea1598b190c140f317ef

Revert "log debug information for sensor threshold assert events"

This reverts commit 9bf6804c2d76b92005ad9851cb052d407ea3117f.
This causes ipmbsensor crash

Change-Id: I8517d801ea1598b190c140f317ef29d1bc172ee0
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>

show more ...

Fix fan redundancy set empty issue.

Have to make sure createSensors finished, and then to create
redundancy sensor.
Otherwise the input parameter array tachSensors is empty,
and cause Collection pro

Fix fan redundancy set empty issue.

Have to make sure createSensors finished, and then to create
redundancy sensor.
Otherwise the input parameter array tachSensors is empty,
and cause Collection property empty.

Tested:
Collection array includes correct items.

xyz.openbmc_project.Control.FanRedundancy interface - - -

.AllowedFailures property y 1 emits-change

.Collection property as 7 "/xyz/openbmc_project/sensors/fan_t…6" emits-change

.Status property s "Full" emits-change

Change-Id: I14013d454306dc39cab69194a2d4683bbefb168e
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

log debug information for sensor threshold assert events

There are sightings that TCPUx_P12_PVCCIO_VS_Temp Sensor
reports reading of zero and trips the low critical threshold.
Add debug prints to ga

log debug information for sensor threshold assert events

There are sightings that TCPUx_P12_PVCCIO_VS_Temp Sensor
reports reading of zero and trips the low critical threshold.
Add debug prints to gather data.

Also add logs for raw value in sensor base class to help
debug threshold assert events for other sensori type.

Tested:
Verified that log messages show up as expected for threshold
assert events. There is no unwanted log messages on systems that
do not have bad sensor readings.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Ib0557e804d275fbb3dce3347b4abec696925cc67

show more ...

TachSensor: Accept PowerState from configuration

Accept the PowerState configuration parameter,
similar to other sensors.
This allows it to optionally be set to "Always",
while still preserving the

TachSensor: Accept PowerState from configuration

Accept the PowerState configuration parameter,
similar to other sensors.
This allows it to optionally be set to "Always",
while still preserving the default of "On".

Some systems have their chassis fans not tied to host power,
so they can continue working, even when host powered off,
and "Always" allows the BMC to continue to monitor them.

Tested: Without this patch, or set to "On",
the tachometers show RPM of 0,
even though the fans are still running correctly,
when host is powered off (but BMC and chassis fans
still have power). After this patch, and setting "Always",
the tachometers once again indicate proper RPM.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I1774f0bec180f52e18d37500fcdd87d32620d519

show more ...