Fix for PSU input sensors

PSU1_input_power and PSU1_In_Voltage sensors are not populated in
busctl tree xyz.openbmc_project.PSUSensor.

Its happening as the sensor names searched with "sensorNameSub

Fix for PSU input sensors

PSU1_input_power and PSU1_In_Voltage sensors are not populated in
busctl tree xyz.openbmc_project.PSUSensor.

Its happening as the sensor names searched with "sensorNameSubStr" in
code and it was populating PSUProperty as "Output Power" for Power Input
sensors(pin) as well.

So update "sensorNameSubStr" with "labelHead" and add the strings to
labelMatch as per the PSU configuration file to populate pin sensors.

Tested:
Verified using ipmitool sensor list.
~#ipmitool sensor list | grep -i psu
PSU1_In_Current | 1.872 |Amps |ok|na | na|na|na|na| na
PSU1_Out_Current | 30.000 |Amps |ok|na |na|na| 164.000|180.000|na
Pwm_PSU1_Fan_1|39.984 |unspecified |ok|na|na|na|na|na| na
Pwm_PSU1_Fan_2|39.984 |unspecified |ok|na|na|na|na|na| na
PSU1_Fan_Speed_1 | 8142.000|RPM |ok|na|na|na|na|na| na
PSU1_Fan_Speed_2 | 6962.000|RPM |ok|na|na|na|na|na| na
PSU1_Input_Power | 401.200 |Watts|ok|na|na|na| 1947.000| 2147.600 | na
PSU1_Out_Power|354.000 |Watts |ok|na|na|na|na|na| na
PSU1_Temperature | 26.000 |degrees C |ok|na|na|na| 73.000 |78.000 |na
PSU1_In_Voltage | 207.680 |Volts |ok|na|na|na|na|na| na

Signed-off-by: Jitendra Tripathy <jitendra.kumarx.tripathy@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Idc7099e28632342c3c6591a63da6cd2129cd9f63

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I81aff1005be025ddb4405f384513c8e5e20bf6f4
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I81aff1005be025ddb4405f384513c8e5e20bf6f4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Ia881ec1745179e1ced79cc1d6cddbb2743f390f2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Apply misc-include-cleaner fixes

misc-include-cleaner seems to have found a lot more things all of a
sudden. Unclear why the result has changed, but we can just fix the
issues.

Tested: Clang-tidy

Apply misc-include-cleaner fixes

misc-include-cleaner seems to have found a lot more things all of a
sudden. Unclear why the result has changed, but we can just fix the
issues.

Tested: Clang-tidy now passes. Code compiles.

Change-Id: Iab045cc183f0daef663b4d5ac901200a42807987
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Deprecate std::filesystem namespace include

Clang-tidy is complaining about our using fs = ... directives. These
were originally added to handle boost::filesystem vs
std::experimental::filesystem v

Deprecate std::filesystem namespace include

Clang-tidy is complaining about our using fs = ... directives. These
were originally added to handle boost::filesystem vs
std::experimental::filesystem vs std::filesystem between the various
compilers. Now that we're all on std::filesystem, this redefinition can
be removed.

```
ChassisIntrusionSensor.hpp:11:11: error: namespace alias decl 'fs' is unused [misc-unused-alias-decls,-warnings-as-errors]
11 | namespace fs = std::filesystem;
```

Tested: code compiles

Change-Id: If4b968ff9cceb4038f526321d3c7c11563ffbce9
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

psusensor: add new CRPS185 power supply

The CRPS185 is a new power supply for certain IBM systems.
The device driver has been upstreamed in the Linux kernel.

Tested:
- Confirmed expected sensors ap

psusensor: add new CRPS185 power supply

The CRPS185 is a new power supply for certain IBM systems.
The device driver has been upstreamed in the Linux kernel.

Tested:
- Confirmed expected sensors appeared on dbus

Change-Id: I460fbf81f5f67f47f5dd56b9a1435f217b144f80
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Utils: Improve debug print

Currently the log contains lines like:
"psusensor[1464]: Error getting [...]: retries left4294967295"

Make debug print more readable:
- Add missing space between 'retries

Utils: Improve debug print

Currently the log contains lines like:
"psusensor[1464]: Error getting [...]: retries left4294967295"

Make debug print more readable:
- Add missing space between 'retries left' and number of
remaining retries
- Skip printing leftover retries when retries is zero as it
would underflow

Change-Id: I467053b43642fffb58771e525b773e2f1a0c24f3
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

adcsensor: prevent reading when power is not ready

Currently, the adcsensor is reading all of the sensors even their power
state is not ready. It made the system waste more resources to read
files.

adcsensor: prevent reading when power is not ready

Currently, the adcsensor is reading all of the sensors even their power
state is not ready. It made the system waste more resources to read
files.

This commit checks the power state before requesting to read I/O files.
It prevents reading sensors when the power state is not ready.

Tested:
1. Turn off the power.
$ipmitool power off
2. Check the adc sensors that have the "PowerState" property in
Entity-Manager is "On"/"ChassisOn" via dbus interfaces.
3. Those sensors have the "Available" property is "false" and the
"Value" is "nan".
4. The hwmon files that corresponding to those sensors are not read
5. Turn on the power.
$ipmitool power on
6. Check the adc sensors that have the "PowerState" property in
Entity-Manager is "On"/"ChassisOn" via dbus interfaces.
7. Those sensors have the "Available" property is "true" and the
"Value" is not "nan".

Change-Id: I52219f40fdd3b478425956c176ac40e3e16c10d1
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I1e9a5994d067f97a54388024184eb450938fe7b3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PSUSensor: add SY24655 device

Summary:
# Description:
Add SY24655 in dbus-sensors

# Motivation:
- Support SY24655.

Test Plan:
- Check the corresponding sensors

# Test Log:
root@bmc:~# busctl intr

PSUSensor: add SY24655 device

Summary:
# Description:
Add SY24655 in dbus-sensors

# Motivation:
- Support SY24655.

Test Plan:
- Check the corresponding sensors

# Test Log:
root@bmc:~# busctl introspect xyz.openbmc_project.EntityManager \
> .../Yosemite_4_Spider_Board/SPIDER_PMON_NIC0_12V
NAME RESULT/VALUE
org.freedesktop.DBus.Introspectable -
.Introspect s
org.freedesktop.DBus.Peer -
.GetMachineId s
.Ping -
org.freedesktop.DBus.Properties -
.Get v
.GetAll a{sv}
.Set -
.PropertiesChanged -
xyz.openbmc_project.Configuration.SY24655 -
.Address 65
.Bus 14
.Labels 3 "in0" "curr1" "power1"
.Name "SPIDER_PMON_NIC0_12V"
.Type "SY24655"
.curr1_Name "SPIDER_PMON_NIC0_12V_CURR_A"
.in0_Name "SPIDER_PMON_NIC0_12V_VOLT_V"
.power1_Name "SPIDER_PMON_NIC0_12V_PWR_W"

Change-Id: I79a2c004c2418f3e8582aef6aa59ae0193b05bac
Signed-off-by: Rush Chen <rush.chen.wiwynn@gmail.com>

show more ...

hwmontempsensor: check active state before activation

The activate() function can be called by the createSensors() when host
power state changes, when host goes off and on again, the sensor will be

hwmontempsensor: check active state before activation

The activate() function can be called by the createSensors() when host
power state changes, when host goes off and on again, the sensor will be
activated repeatedly and cause coredump.

This commit add the check activation state before activating the sensor,
which reference from PSUSensor[1].

[1] https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/74727

Tested on Catalina, no more hwmontempsensor service crash when host
power state from off to running.

Change-Id: I72af303fe808538e20b60a5619c036973b3eac91
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

MCTPReactor: Update MCTP D-Bus APIs

The MCTP D-Bus APIs are changed as
[1] https://codeconstruct.com.au/docs/mctp-utils-v2-0-release/
The `MCTPReactor` should be updated to use new APIs.

Signed-off

MCTPReactor: Update MCTP D-Bus APIs

The MCTP D-Bus APIs are changed as
[1] https://codeconstruct.com.au/docs/mctp-utils-v2-0-release/
The `MCTPReactor` should be updated to use new APIs.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: Ie2fdd9cadb61f4a2716080d8af1bdb21b9d9ad7c

show more ...

Enable GPIO polling for fans that dont support GPIO events

This commit will enable the use of GPIO polling for fans that do not
support GPIO events for presence detection.

The configuration should

Enable GPIO polling for fans that dont support GPIO events

This commit will enable the use of GPIO polling for fans that do not
support GPIO events for presence detection.

The configuration should specify the MonitoryType of Polling which will
trigger the polling based presence monitoring.

Preconditions:
Add the configuration of the dual rotor fan in xxx_BaseBoard.json,
for example:
```
{
"Address": "0x52",
"Bus": 6,
"Index": 0,
"MaxReading": 14500,
"Name": "Fan1a_in",
"PowerState": "Always",
"Presence": {
"PinName": "FAN0_PRESENCE_R_N",
"Polarity": "Low",
"MonitorType": "Polling"
},
"Type": "I2CFan"
},
{
"Address": "0x52",
"Bus": 6,
"Index": 1,
"MaxReading": 14500,
"Name": "Fan1b_in",
"PowerState": "Always",
"Presence": {
"PinName": "FAN0_PRESENCE_R_N",
"Polarity": "Low"
"MonitorType": "Polling"
},
"Type": "I2CFan"
},
```

Tested

```
a{sv} 2 "PrettyName" s "" "Present" b true
a{sv} 2 "PrettyName" s "" "Present" b true

(unplug dual rotor fan)

a{sv} 2 "PrettyName" s "" "Present" b false
a{sv} 2 "PrettyName" s "" "Present" b false

(journal)
Feb 27 17:26:17 system1 fansensor[350]: Fan Fan1a_in Removed
Feb 27 17:35:47 system1 fansensor[350]: Fan Fan1a_in Inserted

Signed-off-by: Xiaochao Ma <maxiaochao@ieisystem.com>
Change-Id: I15215e6e919fabc8b362016c9bb8a5bfaea842db
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Add mctpreactor for dynamic configuration of MCTP networks

While mctpd[1] may see heavy use in projects such as OpenBMC, it
implements generic functionality necessary to operate MCTP as a
protocol.

Add mctpreactor for dynamic configuration of MCTP networks

While mctpd[1] may see heavy use in projects such as OpenBMC, it
implements generic functionality necessary to operate MCTP as a
protocol. It therefore should be easy to use in other contexts, and so
it feels unwise to embed OpenBMC-specific details in its implementation.

Conversely, entity-manager's scope is to expose inventory and board
configuration. It externalises all other responsibilities for the sake
of stability and maintenance. While entity-manager is central to
OpenBMC's implementation and has little use in other contexts, embedding
details of how to configure mctpd in entity-manager exceeds its scope.

Thus we reach the design point of mctpreactor, an intermediary process
that encapsulates OpenBMC-specific and mctpd-specific behaviors to
constrain their dispersion in either direction. The design-point was
reached via discussion at [2].

mctpreactor tracks instances of transport-specific MCTP device
configurations[3] appearing as a result of inventory changes, and uses
them to assign endpoint IDs via mctpd.

The lifecycle of an MCTP device can be quite dynamic - mctpd provides
behaviors to recover[4] or remove endpoints from the network. Their
presence cannot be assumed. mctpreactor handles these events: If
a device is removed at the MCTP layer (as it may be unresponsive),
mctpreactor will periodically attempt to re-establish it as an endpoint
so long as the associated configuration on the entity-manager inventory
object remains exposed.

[1]: https://github.com/CodeConstruct/mctp/
[2]: https://github.com/CodeConstruct/mctp/pull/17
[3]: https://gerrit.openbmc.org/c/openbmc/entity-manager/+/70628
[4]: https://github.com/CodeConstruct/mctp/blob/7ec2f8daa3a8948066390aee621d6afa03f6ecd9/docs/endpoint-recovery.md

Change-Id: I5e362cf6e5ce80ce282bab48d912a1038003e236
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Define include_directories in dependencies for static libraries

This way the headers are found automatically via the dependency objects.

Change-Id: I740b331cd134497663dbd21565ea918c861f9901

meson: Define include_directories in dependencies for static libraries

This way the headers are found automatically via the dependency objects.

Change-Id: I740b331cd134497663dbd21565ea918c861f9901
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Add support for GPIO polling for presence detection

The current PresenceGpio implementation uses event driven detection by
using the gpioLine.event_read method to detect GPIO signal changes, and
the

Add support for GPIO polling for presence detection

The current PresenceGpio implementation uses event driven detection by
using the gpioLine.event_read method to detect GPIO signal changes, and
then to determine the presence status.

This commit will add support for a PollingPresenceGpio for GPIOs that
do not support events. It will use a pollTimer to periodically read the
GPIO status (every second).

The monitorPresence() function should be called to initiate the
monitoring of the GPIO.

TEST: Tested with multiple GPIOs including disabling to simulate
removing of device and enable to re-detect device. Unable to test Event
driven GPIO due to no hw available.

Change-Id: If46e884ad237dfe909a9373773c8302a0844ac90
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Move source files into application-specific sub-directories

Currently, dbus-sensors implement multiple applications:
- psusensor
- adcsensor
- intelcpusensor
- hwmontempsensor
- ipmbsensor
- n

Move source files into application-specific sub-directories

Currently, dbus-sensors implement multiple applications:
- psusensor
- adcsensor
- intelcpusensor
- hwmontempsensor
- ipmbsensor
- nvmesensor
- externalsensor
- mcutempsensor
- intrusionsensor
- fansensor
- exitairtempsensor

This commit is to create separate directories for each application so
that things can be separated more easily and the files are smaller,
instead of creating one huge file for the sensor implementation.

There was some discussion in discord on this. [1][2]

[1]: https://discord.com/channels/775381525260664832/1187158775438778408/1284106093756289067
[2]: https://discord.com/channels/775381525260664832/867820390406422538/1303217796821553214

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I258fc2ee7d8f939c7b83a07350395e78775b2b8d

show more ...

PSUSensor: add ISL28022 support

Add device ISL28022 reading support.

Tested:
Get ISL28022 reading from PSUSensor by dbus introspect.

Change-Id: I0260edd5bf967aee13f7d94297eff56ce285686f
Signed-off

PSUSensor: add ISL28022 support

Add device ISL28022 reading support.

Tested:
Get ISL28022 reading from PSUSensor by dbus introspect.

Change-Id: I0260edd5bf967aee13f7d94297eff56ce285686f
Signed-off-by: Yikai Tsai <yikai.tsai.wiwynn@gmail.com>

show more ...

sensorpaths: adjust case for 'utilization'

The path case 'Utilization' doesn't match the dbus specifications.
This issue was reported on Discord[1]. Change to lowercase to match
the rest of the pat

sensorpaths: adjust case for 'utilization'

The path case 'Utilization' doesn't match the dbus specifications.
This issue was reported on Discord[1]. Change to lowercase to match
the rest of the paths and the specifications.

[1]: https://discord.com/channels/775381525260664832/1187158775438778408/1298446074738118797

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16cf1f9dc327cce0ea14b252f41c55eff73ead9a

show more ...

Move GPIO presence object to its own files

This commit moves and renames the PresenceSensor to PresenceGpio
from TachSensors to its own file so that it can be used for more
than just fans.
It is cur

Move GPIO presence object to its own files

This commit moves and renames the PresenceSensor to PresenceGpio
from TachSensors to its own file so that it can be used for more
than just fans.
It is currently only used for GPIO presence monitoring for fans.

This commit maintains the same functionality as the original code.
Once the objects is created for a GPIO, it will be monitoring for
gpiod::line_request::EVENT_BOTH_EDGES changes. The user can call
isPresent() anytime to read the presence status.

Interface:
EventPresenceGpio(const std::string& iDeviceType,
const std::string& iDeviceName,
const std::string& gpioName, bool inverted,
boost::asio::io_context& io);
Sample usage:
presenceGpio = std::make_unique<EventPresenceGpio>(
"Fan", "Fan4b", "FAN4_PRESENCE_R_N", true, io);
if (presenceGpio->isPresent())
{
// Fan is present
}

Testing: Unable to test this update because no hardware supporting
event driven GPIO detection available.

Change-Id: I1f1a4cbab39d3e3ab38b30288f6aa199ee0cfe3c
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

psusensor: Check active state before activation

The activate() function of PSUSensor is not only called in the sensor's
constructor, but also directly from outside by the createSensors()
function in

psusensor: Check active state before activation

The activate() function of PSUSensor is not only called in the sensor's
constructor, but also directly from outside by the createSensors()
function in PSUSensorMain in case of a power state change. The power
state change matches include watches on both chassis state and host
state, which will be triggered more than one on a power change. This
works fine for PSU sensors which are present in the off state of host.
However, as the sensor type list expands to support more drivers that
function the same way, some types are not available during host-off.
Therefore, when host goes off and on again, those sensors will be
activated repeatedly following the power change signal and cause error
on inputDev, leading to coredump [1].

This commit checks activation state of a sensor before activating it.

Tested:

1. Configure one PSU sensor with "PowerState": "On" in EM
2. BMC boots with host On
3. Turn off host
4. Turn on host
=> No coredump, the sensor is successfully activated and runs again

[1] Journal log:
psusensor: terminate called after throwing an instance of
'boost::wrapexcept<boost::system::system_error>'

psusensor: what(): open: Already open [asio.misc:1 at
/usr/include/boost/asio/detail/impl/io_uring_file_service.ipp:53:5 in
function 'boost::system::error_code
boost::asio::detail::io_uring_file_service::open(implementation_type&,
const char*, boost::asio::file_base::flags,
boost::system::error_code&)']

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I0e02ea9973112ad56cf92a250aca7dc71d0893e2

show more ...

PSUSensor: Add smpro-hwmon sensor type

This commit adds smpro-hwmon driver as a new sensor type to the type
list of PSUSensor, as they have the same sysfs appearances and the same
way to read sensor

PSUSensor: Add smpro-hwmon sensor type

This commit adds smpro-hwmon driver as a new sensor type to the type
list of PSUSensor, as they have the same sysfs appearances and the same
way to read sensors.

But as there are 3 different drivers applied for the smpro MFD devices
of Ampere (smpro-hwmon is one). The hwmon path result from smpro-hwmon
will be different from other pmbus drivers that have device path points
directly to the i2c device path. The current implementation of PSUSensor
to get i2c bus, address only works for the later case, so this commit
uses regex to look for it instead and makes it work for wider cases.

Example:

`root@mtjade:/sys/class/hwmon# ls -la hwmon8 hwmon9
hwmon8 -> ../../devices/platform/xxx/1e78a0c0.i2c-bus/i2c-2/2-004e/\
smpro-hwmon.3.auto/hwmon/hwmon8

hwmon9 -> ../../devices/platform/xxx/1e78a1c0.i2c-bus/i2c-6/6-0058/\
hwmon/hwmon9

root@mtjade:/sys/class/hwmon# ls -la hwmon8/device hwmon9/device
hwmon8/device -> ../../2-004e/smpro-hwmon.3.auto
hwmon9/device -> ../../../6-0058

Tested on Ampere's Mt.Jade platform:
PSUSensor successfully maps Entity-Manager configurations with sysfs of
smpro-hwmon sensors, and reads values.

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I0ea0828e8726719969071a18bb27115c7cc71a9f

show more ...

PwmSensor: Fix function getValue returns wrong data type

Function "getValue" is defined as uint32_t but returns -1 in some cases.
Follow the function comment to change the return value from -1 to 0.

PwmSensor: Fix function getValue returns wrong data type

Function "getValue" is defined as uint32_t but returns -1 in some cases.
Follow the function comment to change the return value from -1 to 0.

Change-Id: Ifd228c94e4ebe14d9bdea953506d17371f9e5f79
Signed-off-by: Yang Chen <yang.chen@quantatw.com>

show more ...

psusensor: Check for present field before using

Using Present field in cpuPresenceHandler without checking for it's
availability may lead to undefined behavior. Check for "Present" field
presence in

psusensor: Check for present field before using

Using Present field in cpuPresenceHandler without checking for it's
availability may lead to undefined behavior. Check for "Present" field
presence in received signal message before using it.

Tested: psusensor rejected signals if "Present" field is absent.

Change-Id: I083f2c7cfb8b5208eebf85518f8859eee262cf58
Signed-off-by: Vikash Chandola <vikash.chandola@intel.com>

show more ...

HwmonTemp: add TMP468 support

Tested:
Verified that HwmonTempSensor generates the TMP468 dbus object.

Change-Id: Ida22cb6050a510563c490246277f277c989a46eb
Signed-off-by: Hieu Huynh <hieuh@os.ampere

HwmonTemp: add TMP468 support

Tested:
Verified that HwmonTempSensor generates the TMP468 dbus object.

Change-Id: Ida22cb6050a510563c490246277f277c989a46eb
Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>

show more ...