utils: fix interface usage for OperatingSystemState

OperatingSystemState property of
xyz.openbmc_project.State.OperatingSystem.Status should be PDI enum of
type OSStatus.
This commit fixes values to

utils: fix interface usage for OperatingSystemState

OperatingSystemState property of
xyz.openbmc_project.State.OperatingSystem.Status should be PDI enum of
type OSStatus.
This commit fixes values to be compatible with PDI.

Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: I2aae1e910decd79e6cf5eb03d96c7067e947f7de

show more ...

Refactoring threshold properties code.

Multiple threshold interfaces like Hardshutdown and Softshutdown
needs to be created for sensors. Therefore, array has been created
to store multiple propertie

Refactoring threshold properties code.

Multiple threshold interfaces like Hardshutdown and Softshutdown
needs to be created for sensors. Therefore, array has been created
to store multiple properties of thresholds.

Threshold level, direction and properties can be accessed based on
the array created. Moreover, lines of code has been reduced by
refactoring existing threshold code.

TESTED: Tested on Facebook YosemiteV2 hardware. Verified that the
Warning and Critical interfaces and properties are created and
displaying in dbus objects.

Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>
Change-Id: I98be6dd723a6f66336147ec572f161a6c5df3691

show more ...

cpusensor: Search in peci-0 directory

The code was searching /sys/bus/peci/devices for PECI sensors.
This results in below directories to be searched on typical 2 socket
x86 systems.
* peci-0
* 0-30

cpusensor: Search in peci-0 directory

The code was searching /sys/bus/peci/devices for PECI sensors.
This results in below directories to be searched on typical 2 socket
x86 systems.
* peci-0
* 0-30
* 0-31
Where 0-30 and 0-31 exist in peci-0 as well.
It is unnecessary, and the files in 0-30 and 0-31 will be searched twice
because they exist in peci-0.

Change the code to search in /sys/bus/peci/devices/peci-0 to make sure
it only search the files within the expected directory.
Note that the current peci driver only create peci-0, this code could be
easily extended to support peci-1/2/3 in the future.

Tested: The time for cpusensor to search the peci sensors reduces from
0.5s to about 0.3s.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I7b0f3ad7bea7a3dced13a985f0ad19ffda33f6d2

show more ...

NVMeSensorMain: Remove sensors when removing configs

Handle drive hot-unplug through the InterfacesRemoved signal from EM.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I685f0f2d3c8adc

NVMeSensorMain: Remove sensors when removing configs

Handle drive hot-unplug through the InterfacesRemoved signal from EM.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I685f0f2d3c8adc5b305c59546b306d5d8c8910c9

show more ...

NVMeSensor: Centralise configuration type

The objectType populated in the Sensor instance was different to the
configuration name used by NVMeSensorMain, which lead to sensors not
being removed with

NVMeSensor: Centralise configuration type

The objectType populated in the Sensor instance was different to the
configuration name used by NVMeSensorMain, which lead to sensors not
being removed with their EntityManager configuration went away.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ifa3c8f41fa8367d8fae62fe0d9b63a2b1675b53f

show more ...

utils: Refactor findFiles()

The findFiles() iterates the directory recursively. For CPU sensor it
was using depth 6 to iterate the PECI devices, and it results in
iterating all the devices in /sys/b

utils: Refactor findFiles()

The findFiles() iterates the directory recursively. For CPU sensor it
was using depth 6 to iterate the PECI devices, and it results in
iterating all the devices in /sys/bus/platform because it contains a
symlink of `subsystem` to `/sys/bus/platform`.

Refactor this function and make sure it skips iterating if a subdir does
not match the regex.

Tested: On g220a, the iterated files reduce from about 40000 to 400,
and the function execution time reduces from 30s+ to about 0.5s.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I7eada897a0f2c76c405a4efc0a081e00b48070e1

show more ...

Fixes Units for Temperature & Pressure for Hwmon

For pressure the units are Pascals and was missing in SensorPaths.cpp
Also changed to align with the rest of dbus-sensors and set units
as sensor_pat

Fixes Units for Temperature & Pressure for Hwmon

For pressure the units are Pascals and was missing in SensorPaths.cpp
Also changed to align with the rest of dbus-sensors and set units
as sensor_paths::unitDegreesC and sensor_paths::unitPascals instead
of literal string constants.

Tested: on Everest's Storm King Op Panels with busctl introspect \
--no-pager xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/\
sensors/temperature/Ambient_1_Temp and with
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/pressure/Station_Pressure
the .Unit fields are now align with the rest of dbus-sensors

Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: I46ce300d1f04e05c65196d69f6201db8ba266ad9

show more ...

Revert "Add beep support for PSU"

This reverts commit 3046a0242cfde0cbf871f632c2c143b48ac30c71.

Apparently nobody knows what this was meant for, and having useless code
around is confusing.

Citing

Revert "Add beep support for PSU"

This reverts commit 3046a0242cfde0cbf871f632c2c143b48ac30c71.

Apparently nobody knows what this was meant for, and having useless code
around is confusing.

Citing Ed Tanous: "This is likely leftover cruft from pulling
dbus-sensors into mainline."
(https://lists.ozlabs.org/pipermail/openbmc/2021-August/027166.html)

Change-Id: I92256d594ce7ca37b957fe86a2d99d9cc9c315af
Signed-off-by: Paul Fertser <fercerpav@gmail.com>

show more ...

DPS310 temperature pressure, SI7020 temperature

Infineon DPS310 pressure and temperature sensors for the Blyth
and Storm King Panel, as well as the Silicon Laboratories
SI7020 type sensors. This pr

DPS310 temperature pressure, SI7020 temperature

Infineon DPS310 pressure and temperature sensors for the Blyth
and Storm King Panel, as well as the Silicon Laboratories
SI7020 type sensors. This provide OpenBMC with the ability
to have the DPS310 pressure and temperature sensors also the
Silicon Laboratories SI7020 type sensors provide OpenBMC
with temperature sensor on dbus via dbus-sensors through
HwmonTempSensor. And adds "pressure" as a type of sensor.
Changed sensorScaleFactor to have offsetValue and scaleValue
for _raw IIO devices, scaleValue is a multiplier where
sensorScaleFactor was a divisor. Pulling this into HwmonTempSensor
came about from this Discord discussion:
https://discord.com/channels/775381525260664832/775381525260664836/869641817220595772

Tested: on Rainier's Blyth and Everest's Storm King Op Panels
busctl tree --no-pager xyz.openbmc_project.HwmonTempSensor
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/temperature/Ambient_0_Temp
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/temperature/Ambient_1_Temp
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/temperature/Ambient_2_Temp
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/temperature/PCIE_0_Temp
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/temperature/PCIE_1_Temp
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/pressure/Station_Pressure
Results consistent with location of the systems.

Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: I5c0d56b486a671ee507c7bfe18fea72e7eaf9ebe

show more ...

PSUSensor: Add MP5023 into whitelist

MPS MP5023 is a Hot-Swap controller which supports PMBus rev 1.3

Tested on Facebook Bletchley platform with 1 MP5023 device on i2c-2@40

Signed-off-by: Howard C

PSUSensor: Add MP5023 into whitelist

MPS MP5023 is a Hot-Swap controller which supports PMBus rev 1.3

Tested on Facebook Bletchley platform with 1 MP5023 device on i2c-2@40

Signed-off-by: Howard Chiu <howard.chiu@quantatw.com>
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Icc00d7ec4fe4918f958429fd3b3dfd628d1ee4a6

show more ...

Make list single line

Making this list a single, alphabetized list reduces the possibility we
get merge conflicts when people add things to this, and make it easier
to read.

Tested:
Code compiles.

Make list single line

Making this list a single, alphabetized list reduces the possibility we
get merge conflicts when people add things to this, and make it easier
to read.

Tested:
Code compiles. Whitespace changes.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ife51344f3c77d3af866f278de1724a62c565c17c

show more ...

NVMeSensorMain: Avoid context variable

It was only used once to add the sensor, so just use the rvalue
directly.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3a5a1bff93aa037bfaa53d2d

NVMeSensorMain: Avoid context variable

It was only used once to add the sensor, so just use the rvalue
directly.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3a5a1bff93aa037bfaa53d2d9b08c603f146c9b7

show more ...

NVMeSensorMain: Drop use of baseConfiguration pointer

Hopefully sensorBase can't be nullptr?

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I256e5c484a94ba42da4ff73e1621784fdbc14759

NVMeSensorMain: Collapse continue conditions

Reduce the verbosity of the loop implementation by testing everything at
once.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I1ffa99077e1ff

NVMeSensorMain: Collapse continue conditions

Reduce the verbosity of the loop implementation by testing everything at
once.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I1ffa99077e1ff51723c0b7f7c50ecad1b7a2c2b9

show more ...

NVMeSensorMain: Make early exits contiguous

This makes for a clear pattern of behaviour.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie9b74e384d7a6a5c0c4a7a9d2466e2b292a33497

NVMeSensorMain: Move context definition to where it's used

The definition of sensorPtr is pretty verbose.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia773d23ba03a2c86700b05009b0946d

NVMeSensorMain: Move context definition to where it's used

The definition of sensorPtr is pretty verbose.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia773d23ba03a2c86700b05009b0946d33d35dbad

show more ...

NVMeSensorMain: Define provideRootBusContext()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4919a13658d5e96b71ed

NVMeSensorMain: Define provideRootBusContext()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4919a13658d5e96b71ed45d38e8db74ad7da2c90

show more ...

NVMeSensorMain: Define deriveRootBus()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib125c05a8f8aa10e0a0c1da4036e

NVMeSensorMain: Define deriveRootBus()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib125c05a8f8aa10e0a0c1da4036ef134edaeb563

show more ...

NVMeSensorMain: Define deriveRootBusPath()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I28614a557bf61e1c32075477

NVMeSensorMain: Define deriveRootBusPath()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I28614a557bf61e1c32075477f8926f8d2c632bc3

show more ...

NVMeSensorMain: Define extractSensorName()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ief4e55d8a9b10f2d95c876d4

NVMeSensorMain: Define extractSensorName()

Continue lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ief4e55d8a9b10f2d95c876d4b1f6dd4bb667b87f

show more ...

NVMeSensorMain: Define extractBusNumber()

Start lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4663af6f00e9118938cb56dc9cb5

NVMeSensorMain: Define extractBusNumber()

Start lifting code from the lambda to simplify its implementation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4663af6f00e9118938cb56dc9cb514118ef62fb3

show more ...

NVMeSensorMain: Extract lambda body

Start unwrapping the onion to improve the ability to understand what's
going on.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I62fd5c9103006633e9ee

NVMeSensorMain: Extract lambda body

Start unwrapping the onion to improve the ability to understand what's
going on.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I62fd5c9103006633e9ee8f0358e688cf92bd8cc7

show more ...

cpuSensor:Check object validity in async callback

Sometimes the cpusensor crash was observed. The coredump was pointing
to segmentation fault while executing callback function inside
setupRead().
Si

cpuSensor:Check object validity in async callback

Sometimes the cpusensor crash was observed. The coredump was pointing
to segmentation fault while executing callback function inside
setupRead().
Similar issue was observed in adcsensor.
Reference to the fix: 1afda6bbb6db0e266795af3229b962c32775b928

The timer cancel() in destructor cannot cancel the expired callback
handlers. In such cases if the callback handler is executed, the
object is deleted already.

Use weak_ptr to check if the object is still valid before using these
member variables/functions.
The buffer used by async_read_util must guarantee that they remain
valid until the handler is called.

Tested: Stress tested by restarting the service. Service restart will
force re-creating the CPUSensor objects.
`count=0; \
while true; \
do systemctl restart xyz.openbmc_project.cpusensor.service; \
count=$((count + 1)); \
echo $count; \
sleep 40; \
done `

Signed-off-by: gokulsanker <gokul.sanker.v.g@intel.com>
Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>
Change-Id: I7410feb0e17c5f6d555cd042f5e5b327de1910c5

show more ...

Added JC42 JEDEC standard memory temp sensor support

Intended to export DIMM sensors on dbus-sensors interface. Similarly
Device support is added to entity-manager for JC42 devices to
work with dbus

Added JC42 JEDEC standard memory temp sensor support

Intended to export DIMM sensors on dbus-sensors interface. Similarly
Device support is added to entity-manager for JC42 devices to
work with dbus-sensors.

Tested: Tested on NVIDIA system, dbus-sensor HwmonTemp daemon is able
to pick up JC42 type sensor devices exported via entity-manager
configs and able to create sensors object and push temp readings to dbus.

Signed-off-by: Hardik Sangani <hsangani@nvidia.com>
Change-Id: Ice2f3c73b19736071193d1e4dd3676f7c4488862

show more ...

TachSensor: fix checkThresholds regression

Due to a merge mistake, the following commit
introduced an unintended change.

https://github.com/openbmc/dbus-sensors/commit/da98f095f25cc75af3c0268643bde

TachSensor: fix checkThresholds regression

Due to a merge mistake, the following commit
introduced an unintended change.

https://github.com/openbmc/dbus-sensors/commit/da98f095f25cc75af3c0268643bde2b21f5503e0#diff-33f4e0882e5eaea910f455ab4f5f22b2b9274ff46dd6120b6b23a092607174a0L187

Revert the code back.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I17198e9cfece47022a437cdba12eea8c3e4b32e2

show more ...