hwmontempsensor: update PercentRH unit string

change PercentRH unit string to follow the definition in
phosphor-dbus-interface.

Test Result:
```
root@bmc:~# busctl get-property xyz.openbmc_project.

hwmontempsensor: update PercentRH unit string

change PercentRH unit string to follow the definition in
phosphor-dbus-interface.

Test Result:
```
root@bmc:~# busctl get-property xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/humidity/FRONT_PANEL_HUMIDTY xyz.openbmc_project.Sensor.Value Unit -j
{
"type" : "s",
"data" : "xyz.openbmc_project.Sensor.Value.Unit.PercentRH"
}
```

Change-Id: I2967ee5d804eaa6f7ab28c9f39789bc58317e210
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Utils: change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-contro

Utils: change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/69589

Change-Id: If2180db4a26a548934ef62fb4a16a6f2ed6f41eb
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Enable misc-include-cleaner

Change-Id: I22099a0f95b2eb884dec7d95cee0bdd0c159fd1f
Signed-off-by: Ed Tanous <ed@tanous.net>

Enable cppcoreguidelines-rvalue-reference-param-not-moved

and fix the one failure.

Change-Id: I62ddb9e3520b4f16331f605441740da5831ade51
Signed-off-by: Ed Tanous <ed@tanous.net>

psusensor: Fix memory leak

Remove the psuProperties vector since older params are not being used.
Use a temp copy of the psuProperty for customization per label match.
This change fix the memory lea

psusensor: Fix memory leak

Remove the psuProperties vector since older params are not being used.
Use a temp copy of the psuProperty for customization per label match.
This change fix the memory leak when createSensors is called
repeatedly.

Tested:
Memory stay stable with overnight cold reset test.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: If4ec633fd533fdb90c7fc9f655e82bef2616e3f3

show more ...

Enable readability-container-data-pointer

Clang tidy check, and fix the one case.

Change-Id: I0935eb6403fd3b2e1a66d9e097febd292f61d70d
Signed-off-by: Ed Tanous <ed@tanous.net>

Add bugprone-optional-value-conversion

And fix the one case.

Change-Id: Iaaedf56b12cae38583ae82017ebea8bfe8987689
Signed-off-by: Ed Tanous <ed@tanous.net>

Fix readability-redundant-member-init

Clang-tidy-18 flags one new instance.

Change-Id: I43334b200b47dd1737ac9af9e56bd10be690cf36
Signed-off-by: Ed Tanous <ed@tanous.net>

Enable bugprone-unused-local-non-trivial-variable

And fix the two problems.

Change-Id: Ib91625d66e42fe8b14aaf1ef33761f9084564de9
Signed-off-by: Ed Tanous <ed@tanous.net>

Enable bugprone-assignment-in-if-condition

And fix the one violation.

Change-Id: I8b844d0e987827527c82e3351efd40c1bfd692db
Signed-off-by: Ed Tanous <ed@tanous.net>

Add modernize-redundant-void-arg

Enable this check and fix the failures.

Change-Id: I89b13daf1161be40564367562bb9c8c0c459e1d0
Signed-off-by: Ed Tanous <ed@tanous.net>

add hysteresis param to parseThresholdsFromAttr()

Parameter 'hysteresis' with a default = NaN, is added to the header for
parseThresholdsFromAttr(), and existing calls to it now explicitly
specify a

add hysteresis param to parseThresholdsFromAttr()

Parameter 'hysteresis' with a default = NaN, is added to the header for
parseThresholdsFromAttr(), and existing calls to it now explicitly
specify a hysteresis value.

This is an alternative to having calls to parseThresholdFromAttr() use
a hardcoded Intel-specific value of '0.'

The 'NaN' value was chosen as default because it reflects the value
that was being written before a device-specific value was hardcoded in
to solve a specific issue.

Change was created based on the discussion here:
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/61744/comments/38f6a
221_58a39817a

Tested: Confirmed the code builds and doesn't throw errors with OBMC
'local CI' testing. I believe heavier testing with actual Intel HW
isn't needed because this change simple moves where a value is specified
(from hardcode in function body to passed-in parameter) without
affecting any existing in-use functionality.

Change-Id: I1240b951d6e37adc1aad5ad3b19144f6baa64998
Signed-off-by: Chris Sides <christopher.sides@hpe.com>

show more ...

PSUSensor: add sbrmi support

Add device sbrmi for power reading support.

Test result:
- check sensor creation
```
root@bmc:~# busctl tree xyz.openbmc_project.PSUSensor |grep SBRMI
| `- /xyz/o

PSUSensor: add sbrmi support

Add device sbrmi for power reading support.

Test result:
- check sensor creation
```
root@bmc:~# busctl tree xyz.openbmc_project.PSUSensor |grep SBRMI
| `- /xyz/openbmc_project/State/Decorator/SBRMI_OperationalStatus
`- /xyz/openbmc_project/sensors/power/SBRMI_Output_Power
```

Change-Id: I4a86071e4bf01ccd473441d395221f565bb15519
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...

HwmonTempSensor: Add support for PT5161L

Add support for PT5161L temperature sensor.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=1b2ca93cd05

HwmonTempSensor: Add support for PT5161L

Add support for PT5161L temperature sensor.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=1b2ca93cd0592b1fcbc6f8b64e02552bc15f4bb4

Tested Result:
- MB_RETIMER0_TEMP_C sensor config from harma_mb.json
```
{
"Address": "0x24",
"Bus": 12,
"Name": "MB_RETIMER0_TEMP_C",
"PowerState": "On",
"Thresholds": [
{
"Direction": "greater than",
"Name": "upper critical",
"Severity": 1,
"Value": 107
},
{
"Direction": "greater than",
"Name": "upper non critical",
"Severity": 0,
"Value": 105
},
{
"Direction": "less than",
"Name": "lower non critical",
"Severity": 0,
"Value": 5
},
{
"Direction": "less than",
"Name": "lower critical",
"Severity": 1,
"Value": -7
}
],
"Type": "PT5161L"
}
```

- MB_RETIMER0_TEMP_C sensor reading
```
root@bmc:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/MB_RETIMER0_TEMP_C
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openbmc… emits-change
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b false emits-change
.CriticalAlarmLow property b false emits-change
.CriticalHigh property d 107 emits-change writable
.CriticalLow property d -7 emits-change writable
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b false emits-change
.WarningAlarmLow property b false emits-change
.WarningHigh property d 105 emits-change writable
.WarningLow property d 5 emits-change writable
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 127 emits-change
.MinValue property d -128 emits-change
.Unit property s "xyz.openbmc_project.Sensor.Value.Unit.… emits-change
.Value property d 55.6 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change
```

Change-Id: Ie0e7e9603c2e201a06a64de7c265500b73b5156d
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

PSUSensor: add ltc4286/ltc4287 support

Add device ltc4286/ltc4287 reading support.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/drivers/hwmon/pmbus/ltc4286.c?

PSUSensor: add ltc4286/ltc4287 support

Add device ltc4286/ltc4287 reading support.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/drivers/hwmon/pmbus/ltc4286.c?id=0c459759ca971ee49a313b19ba50fc499c6cf8ca

Test result:
- check sensors creation of CMM_HSC device config from minerva_cmm.json
```
root@bmc:~# busctl tree xyz.openbmc_project.PSUSensor | grep CMM_HSC
│ ├─ /xyz/openbmc_project/State/Decorator/CMM_HSC_OperationalStatus
│ ├─ /xyz/openbmc_project/sensors/current/CMM_HSC_CURR_A
│ ├─ /xyz/openbmc_project/sensors/power/CMM_HSC_PWR_W
├─ /xyz/openbmc_project/sensors/voltage/CMM_HSC_VIN_VOLT_V
├─ /xyz/openbmc_project/sensors/voltage/CMM_HSC_VOUT_VOLT_V
```

Change-Id: I945a26ea1ee98cb0ccd9978c2f43d729a9d4cdeb
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

State.Chassis: update service name

Both phosphor-state-manager and x86-power-control have code that exposes
both the Chassis and Chassis0 bus names as a backwards compatibility
when multi-chassis su

State.Chassis: update service name

Both phosphor-state-manager and x86-power-control have code that exposes
both the Chassis and Chassis0 bus names as a backwards compatibility
when multi-chassis support was added. Switch to the numbered bus name,
which is expected to be the non-deprecated one.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0aeefc5d00cfd1fbb1c53f35fc2d2f067d97f11b

show more ...

Utils: Remove unused getSensorConfiguration method

Since dbus sensor only uses the getSensorConfiguration method with the
`useCache` parameter, this patch removes the getSensorConfiguration
method t

Utils: Remove unused getSensorConfiguration method

Since dbus sensor only uses the getSensorConfiguration method with the
`useCache` parameter, this patch removes the getSensorConfiguration
method that does not use the `useCache` parameter.

Tested: built dbus-sensors successfully and it works fine with this
patch.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1730df517e115de0625cfcca561f08af1d053b46

show more ...

psusensor: Optimize the naming of some variables

Some variable declarations and parameter types use
`boost::container::flat_map`. The long type names make it difficult
for other developers to read.

psusensor: Optimize the naming of some variables

Some variable declarations and parameter types use
`boost::container::flat_map`. The long type names make it difficult
for other developers to read.

This commit makes some minor optimizations, using `using` to declare
an alias to increase the readability of the code.

Tested: built psusensor successfully and works fine.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9b632c27fc67694d2de384f6e7c88bf66b97f78e

show more ...

Set exitAirSensor to null before creating sensor

If the configuration for the current ExitAirTempSensor is changed the
service will crash because it will re-create its DBus interfaces. To
prevent th

Set exitAirSensor to null before creating sensor

If the configuration for the current ExitAirTempSensor is changed the
service will crash because it will re-create its DBus interfaces. To
prevent this set exitAirSensor to nullptr before creating a new sensor.

Tested:
Change a property of the ExitAirTempSensor to something new to
re-trigger createSensors(), e.g.
busctl set-property xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/chassis/R4000_Chassis/Exit_Air_Temp
xyz.openbmc_project.Configuration.ExitAirTempSensor.Thresholds0 Value d 93

Without the fix the service would crash:
with the error: "exitairtempsensor: what(): sd_bus_add_object_vtable:
org.freedesktop.DBus.Error.FileExists: File exists". With the fix the
service doesn't crash and the property change holds.

Change-Id: I288140a8bd7ebb7119726720e0c829f3677a8aca
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

tachsensor: Fix 'Associations' capitalization to register associations

Before patch:
```
# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.A

tachsensor: Fix 'Associations' capitalization to register associations

Before patch:
```
# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.Association.Definitions
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.associations property a(sss) 1 "sensors" "inventory" "/xyz/openbmc... emits-change

# busctl tree xyz.openbmc_project.ObjectMapper | grep Fan1_0
| | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0
| | | `- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/chassis
```

After patch:
```
# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.Association.Definitions
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Associations property a(sss) 1 "sensors" "inventory" "/xyz/openbmc... emits-change

# busctl tree xyz.openbmc_project.ObjectMapper | grep Fan1_0
| |- /xyz/openbmc_project/inventory/Fan1_0
| | `- /xyz/openbmc_project/inventory/Fan1_0/sensors
| | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0
| | | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/chassis
| | | `- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/inventory

```

Change-Id: Ie7fd69a4dc7216fb2dcfb1fdccc2b7885c7511ee
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>

show more ...

meson: Format build files according to meson style guide

muon[1], an meson-compatible build system, provides a `fmt` subcommand
to format meson build files in accordance with the meson style guide[2

meson: Format build files according to meson style guide

muon[1], an meson-compatible build system, provides a `fmt` subcommand
to format meson build files in accordance with the meson style guide[2].

[1]: https://muon.build/
[2]: https://mesonbuild.com/Style-guide.html

Apply `muon fmt` using the following to provide consistent formatting:

```
for f in $(git ls-files | grep meson.build)
do
muon fmt $f | sponge $f
done
```

Change-Id: I7ef7693ddf964e9540b2e3e256cdf584fb8ac9cd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

hwmontempsensor: Handle failure to canonicalize device path

std::filestream::canonical(const std::filesystem::path& p) can throw
exception if the path does not exist. hwmontempsensor would crash wit

hwmontempsensor: Handle failure to canonicalize device path

std::filestream::canonical(const std::filesystem::path& p) can throw
exception if the path does not exist. hwmontempsensor would crash with:
what(): filesystem error: cannot make canonical path:
No such file or directory [/sys/class/hwmon/hwmon38/device]

Replace with canonical(const std::filesystem::path& p,
std::error_code& ec) which captures error code without exception.

This call still may throw std::bad_alloc if memory allocation fails.
But there is no good way to resolve system OOM from this service,
leave it unhandled and let the service exit.

Tested:
Same hwmontemp sensors are created with the change.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I0cf98950faf44b35dc71387a653ba1feeb375cc1

show more ...

Add debounce timer to intrusion sensor rescan

GPIO based intrusion sensors were failing with rapid fire configuration
changes. Added a debounce timer to ensure multiple rescans can coalesce
into a s

Add debounce timer to intrusion sensor rescan

GPIO based intrusion sensors were failing with rapid fire configuration
changes. Added a debounce timer to ensure multiple rescans can coalesce
into a single call to createSensorsFromConfig.

Tested: Ran change on Akamai Crow server and observed the GPIO Intrusion
Sensor being created properly at boot.

Change-Id: I789838a31575b80d839bdb9812d23ad0d71505a9
Signed-off-by: Ian Woloschin <ian.woloschin@akamai.com>

show more ...

PSUSensor: add max11607 support

Add iio device max11607 reading support

Signed-off-by: Joseph Fu <joseph.fu@quantatw.com>
Change-Id: I38dec4c01e41657f5ccb9270d41530182c76b019

PSUSensor: add mp2856/mp2867 support

Add support for MPS Multi-phase mp2856/mp2857 controller.

The driver is applied in linux-staging.git.
Link: https://git.kernel.org/pub/scm/linux/kernel/git/groe

PSUSensor: add mp2856/mp2867 support

Add support for MPS Multi-phase mp2856/mp2857 controller.

The driver is applied in linux-staging.git.
Link: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=db79be9d970740b2310b1eece69c34bcea06c340

Change-Id: I0d8e6222c70e8f7de749bdccb74d3eab93b46871
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...