meson: Move unit-file-related definitions to service_files/meson.build

In the spirit of keeping-things-that-are-together-together, move the
dependency declaration to where it's used. We only declare

meson: Move unit-file-related definitions to service_files/meson.build

In the spirit of keeping-things-that-are-together-together, move the
dependency declaration to where it's used. We only declare the
dependency on systemd to grab the unit directory path.

Change-Id: I5bdda184ade023ee38b0d33dd1c5a9c118bf3b8a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Require meson 1.1

Fixes the following warnings:

```
WARNING: Project specifies a minimum meson_version '>=0.58.0' but uses features which were added in newer versions:
* 0.59.0: {'feature_o

meson: Require meson 1.1

Fixes the following warnings:

```
WARNING: Project specifies a minimum meson_version '>=0.58.0' but uses features which were added in newer versions:
* 0.59.0: {'feature_option.allowed()'}
* 1.1: {'meson.options file'}
```

Additionally, with the bump, fix the following warning:

```
WARNING: Deprecated features used:
* 0.64.0: {'copy arg in configure_file'}
```

Change-Id: I3b678769674f64e9050b4aa85fe6775c556ea8f6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I882edd53856df38c8292bc3313b9342b2b1ceddd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

cpusensor: Change cpusensor to intelcpusensor

cpusensor class is specifically used for Intel CPU. The name of this
class and the build option should be changed to reflect with their
role.
The patch

cpusensor: Change cpusensor to intelcpusensor

cpusensor class is specifically used for Intel CPU. The name of this
class and the build option should be changed to reflect with their
role.
The patch set https://gerrit.openbmc.org/c/openbmc/openbmc/+/56096 is
required to prevent the build error in openbmc source.

Tested:
1. No build error.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I1f941fffa10222cdac908fd763dccc866ba0e8a6

show more ...

intrusionsensor: systemd: Use qualified path

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Bra

intrusionsensor: systemd: Use qualified path

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Iee20d0516a4bd031b861f47c451a2bfccd986bde

show more ...

nvmesensor: Service requires EntityManager

This way it exits if EntityManager terminates, avoiding issues with
duplicate configuration when EntityManager restarts. This also makes its
service file c

nvmesensor: Service requires EntityManager

This way it exits if EntityManager terminates, avoiding issues with
duplicate configuration when EntityManager restarts. This also makes its
service file consistent with the other dbus-sensors services.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4a088b9d74cb7076d3816780852fbc8763c90cc2

show more ...

meson: add external sensor to meson build

Add external to unit_files to make the service can be installed.

Tested: Add configuration for exteranlSensor and verify pass.

Signed-off-by: Jeff Lin <Je

meson: add external sensor to meson build

Add external to unit_files to make the service can be installed.

Tested: Add configuration for exteranlSensor and verify pass.

Signed-off-by: Jeff Lin <JeffLin2@quantatw.com>
Change-Id: I1ca650cc15d8191fdbecc25d5b5ba099f3ee1920

show more ...

Fix mcu option

If the mcu temp sensor is not included in a build, it isn't showing up.
This is due to meson_options.txt having 2 different names for mcu; mcu,
and mcu-temp. The upstream recipe use

Fix mcu option

If the mcu temp sensor is not included in a build, it isn't showing up.
This is due to meson_options.txt having 2 different names for mcu; mcu,
and mcu-temp. The upstream recipe uses mcu to key, so lets just do
that.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ib84c96b97c534c81e9e4e83c838dffe4e26b6957

show more ...

meson: Fix psusensor

The psu sensor's process name was incorrectly set to psutempsensor and
is inconsistent with the service unit.
Fix this and use `psu` as the configure option instead of `psu-temp

meson: Fix psusensor

The psu sensor's process name was incorrectly set to psutempsensor and
is inconsistent with the service unit.
Fix this and use `psu` as the configure option instead of `psu-temp`,
because it is really psusensor including temperature/current/voltage/fan
sensors.

Tested: Verify the build binary is named as `psusensor`.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Iee6bcdbb948a58dd10cfe26ab268944f1f9a14e6

show more ...

Add support for building with meson

Follow the OpenBMC herd and support a modern, comprehensible build
framework.

To build with meson:
meson build
ninja -C build
OR
bitbake dbus-sensors

Add

Add support for building with meson

Follow the OpenBMC herd and support a modern, comprehensible build
framework.

To build with meson:
meson build
ninja -C build
OR
bitbake dbus-sensors

Add -Dtests to match de-facto OpenBMC meson usage conventions.

Maintain existing per-sensor config flags; however, do not define
targets when opting out of a sensor class.

One noteable omission is support for subprojects or vendoring.

The OpenBMC CI scripts look for meson.build before looking for
CMakelists so approval of this patch would change the build system
during CI to meson.

meta-phosphor change to update the recipe to meson is also coming
shortly.

Change-Id: I27d8c8f5761850d760428ed813eecd41e8f47c33
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

ExternalSensor: New service for external sensors

This code was mostly copied from HwmonTempSensor, and inspired by the
initial proof of concept from https://gerrit.openbmc-project.xyz/35476

Externa

ExternalSensor: New service for external sensors

This code was mostly copied from HwmonTempSensor, and inspired by the
initial proof of concept from https://gerrit.openbmc-project.xyz/35476

External sensors are designed to be placeholders, with no hwmon or
other hardware support locally. Thus, there is no detection or kernel
driver load, so no change is necessary to entity-manager.

The expectation is that these sensors will be updated by something
external to the BMC, such as the host, which can be useful for
including host-based sensors into phosphor-pid-control thermal zones.

* Added systemd service file, similar to the others.
* Added CMakeLists blocks, similar to the others.
* Also cleaned up some nearby formatting in CMakeLists.

Tested: With the addition of the Mutable feature from 36275, and the
installation of the systemd file from 36272, and a change to our IPMI
daemon (still in the process of being upstreamed), the host can write
to a sensor over IPMI. It correctly shows up in the IPMI SDR, and the
written value correctly shows up on the D-Bus ExternalSensor here.

Here is example JSON for use with entity-manager:
{
"Name": "HostOnlyDevTemp",
"Measure": "temperature",
"MinValue": -10.0,
"MaxValue": 117.5,
"Type": "ExternalSensor"
},

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Id499e1cd6c7918179bb1729e5ce8546cf4121dfa
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

Enabling NVMe sensor support

This commit introduces the support for NVMe drives for sensors.

All the NVMe drives which are detected by the FRU manager and are
present in the inventory are scanned a

Enabling NVMe sensor support

This commit introduces the support for NVMe drives for sensors.

All the NVMe drives which are detected by the FRU manager and are
present in the inventory are scanned at regular interval for reading
the temperature values of the NVMe devices.

Tested:

NAME TYPE SIGNATURE RESULT/VALUE
org.freedesktop.DBus.Introspectable interface - -
.Introspect method - s
org.freedesktop.DBus.Peer interface - -
.GetMachineId method - s
.Ping method - -
org.freedesktop.DBus.Properties interface - -
.Get method ss v
.GetAll method s a{sv}
.Set method ssv -
.PropertiesChanged signal sa{sv}as -
xyz.openbmc_project.Association.Definitions interface - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb...
xyz.openbmc_project.Sensor.Threshold.Critical interface - -
.CriticalAlarmHigh property b false
.CriticalAlarmLow property b false
.CriticalHigh property d 115
.CriticalLow property d 0
xyz.openbmc_project.Sensor.Threshold.Warning interface - -
.WarningAlarmHigh property b false
.WarningAlarmLow property b false
.WarningHigh property d 110
.WarningLow property d 5
xyz.openbmc_project.Sensor.Value interface - -
.MaxValue property d 127
.MinValue property d -60
.Value property d 22

Change-Id: Icb119b424234d548c8ff5cda9c7a9517ec9696bb
Signed-off-by: Nikhil Potade <nikhil.potade@linux.intel.com>
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Revert "Corrected the Settings service name"

This reverts commit d89bf5429f3687e483f230b8f5e1858abc37ad8c.

Reason for revert: Was right the in the first place
https://github.com/openbmc/meta-phosph

Revert "Corrected the Settings service name"

This reverts commit d89bf5429f3687e483f230b8f5e1858abc37ad8c.

Reason for revert: Was right the in the first place
https://github.com/openbmc/meta-phosphor/blob/master/recipes-phosphor/settings/phosphor-settings-manager/xyz.openbmc_project.Settings.service

Change-Id: I1d1c8c099c3f56976a7b3bb3d92f989c9915d595

show more ...

Corrected the Settings service name

Corrected service name from "xyz.openbmc_project.Settings"
to "xyz.openbmc_project.settings" in exitairsensor.service.

This causes EntityManager service restart

Corrected the Settings service name

Corrected service name from "xyz.openbmc_project.Settings"
to "xyz.openbmc_project.settings" in exitairsensor.service.

This causes EntityManager service restart fails via systemctl.

Tested:
Restarted the EntityManager using systemctl and works fine.

Change-Id: I99e9ba2f23e30e776d833845ea6acdc0b4cd2617
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Ensuring EntityManager starts before all Sensor services

This fix was needed by PSUSensor
However, all of these Sensor services are written in a similar way
All could probably benefit from this simi

Ensuring EntityManager starts before all Sensor services

This fix was needed by PSUSensor
However, all of these Sensor services are written in a similar way
All could probably benefit from this similar fix
Adds Requires and After for EntityManager
Also clean up dangling Requires that did not have After
Tested: On PSUSensor only

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Ib132b642b88dfb344b28d27d55dfd89b49e917f4

show more ...

Force PSUSensors to start after EntityManager

PSUSensors would start before EntityManager. This would cause an
issue where PSUSensors would not be able to find the EntityManager
service and as a res

Force PSUSensors to start after EntityManager

PSUSensors would start before EntityManager. This would cause an
issue where PSUSensors would not be able to find the EntityManager
service and as a result fail sensor creation.
Tested: Reboot BMC, observed that PSUSensors started up after
EntityManager instead of before

Change-Id: I17a646038e923c37639d171eecbf1bee2d9fdc77
Signed-off-by: Jason Ling <jasonling@google.com>

show more ...

Support temp sensor on MCU which is available from I2C

Chassis MCU exposes register to report temperature for the peripheral board.
The MCU access is configurable as below:
{
"Bu

Support temp sensor on MCU which is available from I2C

Chassis MCU exposes register to report temperature for the peripheral board.
The MCU access is configurable as below:
{
"Bus": $bus,
"Address": "0xAA",
"Reg": "0xBB",
"Class": "MCUTemp",
"Name": "MCU Temp",
"Thresholds": [
xxx
]
"Type": "MCUTempSensor"
}

Tested:
The below interface was found under temperature sensor namespace:
└─/xyz/openbmc_project/sensors/temperature/MCU_Temp

Run ipmitool sensor and check below from list:
MCU Temp | 30.175 | degrees C | cr | na | 0.000 | 5.000 | 110.000 | 115.000 | na

Change-Id: I8d54455ccc39ea4f60a5b4aee5c68be092d39a72
Signed-off-by: Yuan Li <yuan.li@linux.intel.com>

show more ...

adcsensor: Add CPU presence checking

This adds a match to catch cpu presence coming from
cpusensor.

Tested: ipmitool sensor list no longer showed ADCs that
monitored unavailable CPU

Change-Id: I3

adcsensor: Add CPU presence checking

This adds a match to catch cpu presence coming from
cpusensor.

Tested: ipmitool sensor list no longer showed ADCs that
monitored unavailable CPU

Change-Id: I39c067e5da3565c5b229cc19ed4ccf7767c1e85c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Enable PSUSensor support

Add psusensor service to enable PSUSensor.

Tested By:
After BMC started, run ipmitool sensor list, all PSU sensors can show
correct name and value.

Signed-off-by: Cheng C

Enable PSUSensor support

Add psusensor service to enable PSUSensor.

Tested By:
After BMC started, run ipmitool sensor list, all PSU sensors can show
correct name and value.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I55d52c3cc71243a1db10a47551872b458ad9d21b

show more ...

cfm: allow setting of max pwm

When a change from xyz.openbmc_project.Control.CFMLimit
interface is detected set the max pwm in pid control configs
to limit max fan speed.

This also puts the max CFM

cfm: allow setting of max pwm

When a change from xyz.openbmc_project.Control.CFMLimit
interface is detected set the max pwm in pid control configs
to limit max fan speed.

This also puts the max CFM on d-bus for other commands to
use.

Tested-by: Used settingsd to control fan speed

Change-Id: Ic4ca37747690f6476cfa12bf3c19a44d7ee086c8
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie5783c3a631c09497cf5e27e51a31035f25c6208

Add chassis intrusion sensor daemon

Chassis intrusion signal is read from PCH via I2C or from GPIO.
Create a new daemon to poll its status and expose to dbus.

Related patches to run test:
- meta-ph

Add chassis intrusion sensor daemon

Chassis intrusion signal is read from PCH via I2C or from GPIO.
Create a new daemon to poll its status and expose to dbus.

Related patches to run test:
- meta-phosphor: dbus-sensors: Enable new service of intrusion sensor
https://gerrit.openbmc-project.xyz/#/c/openbmc/meta-phosphor/+/17063/
- redfish: chassis: add property of physical security
https://gerrit.openbmc-project.xyz/#/c/openbmc/bmcweb/+/17691/

Tested-by: Check intrusion status value by redfish,
verified PCH solution on WFP and GPIO solution on STP.

Change-Id: Id5e67abbd80bbf2ef502db49fa183d92d0d31bda
Signed-off-by: Qiang XU <qiang.xu@linux.intel.com>

show more ...

Enable ipmb sensor

Tested-by: Saw sensor readings in ipmitool sensor list

Change-Id: I37dea869cbbae42779362e14bb2631eceeff02ea
Signed-off-by: James Feist <james.feist@linux.intel.com>

Fix Exit Air Temp Sensor

Add custom destructor for CFM sensor as it is configuration
driven and can be destroyed unlike exit air. Having this not
have a destructor caused the old sensor loop to keep

Fix Exit Air Temp Sensor

Add custom destructor for CFM sensor as it is configuration
driven and can be destroyed unlike exit air. Having this not
have a destructor caused the old sensor loop to keep running
and not be destroyed. Also attempt to pre-populate inlet temp
as it doesn't get updated as frequently as tach readings.

Tested-by: sensor list started to work again and readings
were appropriate.

Change-Id: Id5b42a73a22ff860149ced1ba073d81fe84a9375
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Disable exit air temp sensor

It's having some issues, disable it while it's getting
fixed.

Change-Id: I6bb9501191f281655234d0cd74f5651ebcf862ff
Signed-off-by: James Feist <james.feist@linux.intel.c

Disable exit air temp sensor

It's having some issues, disable it while it's getting
fixed.

Change-Id: I6bb9501191f281655234d0cd74f5651ebcf862ff
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...