| 11399367 | 20-Jan-2026 |
Ed Tanous <etanous@nvidia.com> |
Remove old login routines
At one point the bmcweb /login route has supported a bunch of
different login mechanisms:
1. Sending username and password via headers, mirroring a non-openbmc
implement
Remove old login routines
At one point the bmcweb /login route has supported a bunch of
different login mechanisms:
1. Sending username and password via headers, mirroring a non-openbmc
implementation that has never been used in openbmc, and predates this
repo being called bmcweb.
2. Sending username and password under a "data" object, mirroring
phosphor-rest json webserver.
3. Sending username and password as an http multipart as part of the
initial multipart parser patch.
4. Sending a json payload as {"username": <>, "password": <>}
This commit removes all but the final login mechanism. Redfish login
has been used exclusively for many many years, and only the webui used
4 above up until a few years ago in commit
1ff8e89fd2397c468ab0237158e5aeeff2692413
Keeping one viable login mechanism that's not Redfish is useful in the
future if there are those that want to disable Redfish. All others
could potentially be security issues, so keeping the code simple and
conscise here is ideal.
This commit does not attempt to make a backwards compatibility path,
under the assumption that other than 4, none of the other code was ever
used in any real capacity. If we find that to not be true, we can add
back the portions where we need compatibility, but this seems unlikely.
Tested: WIP
Change-Id: I04b4968836f0f824f46b3dff180ad92feb16967c
Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|