Move error_message JSON into own function

Right now all error messages requires a response object,
so they cannot be used directly in the json body. This
pulls the messages out into their own functi

Move error_message JSON into own function

Right now all error messages requires a response object,
so they cannot be used directly in the json body. This
pulls the messages out into their own function so that
they can be used at any place in the response body.

Tested: It compiles and runs, verified return codes look
ok

Change-Id: I500b2164b2366086d610f0fdc8fa22985183e438
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix response error code for error - Unauthorized

Tested by:
Request: Creating session with wrong credential.

curl --insecure -X POST -D headers.txt https://${BMC_IP}/redfish/v1/SessionService/Sessi

Fix response error code for error - Unauthorized

Tested by:
Request: Creating session with wrong credential.

curl --insecure -X POST -D headers.txt https://${BMC_IP}/redfish/v1/SessionService/Sessions
-d '{"UserName":"root", "Password":"penBmc"}'

Resonse Error code: HTTP/1.1 401 Unauthorized

Signed-off-by: Sunitha Harish <sunithaharish04@gmail.com>
Change-Id: I9c7b0af644f1e3d987b4f76e4206bbb276aba035

show more ...

Add "Retry-After" header for temporarily unavailable messages

Whenever the Redfish response is that a service is temporarily
unavailable, the "Retry-After" header is added with the same
value, so ju

Add "Retry-After" header for temporarily unavailable messages

Whenever the Redfish response is that a service is temporarily
unavailable, the "Retry-After" header is added with the same
value, so just set the header automatically with the response.

Tested:
Confirmed that the "Retry-After" header is set correctly with
the Redfish temporarily unavailable message.

Change-Id: I9c940be94d9d284b9633c5caa2ce71ade76d22d5
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Make references to crow less obvious

Recently, a number of people in the community have made the (admittedly
easy) mistake that we use a significant portion of crow.

Today, we use crow for the rout

Make references to crow less obvious

Recently, a number of people in the community have made the (admittedly
easy) mistake that we use a significant portion of crow.

Today, we use crow for the router, and the "app" structure, and even
those have been significantly modified to meet the bmc needs. All other
components have been replaced with Boost beast. This commit removes the
crow mentions from the Readme, and moves the crow folder to "http" to
camouflage it a little. No code content has changed.

Tested:
Code compiles. No functional change made to any executable code.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: Iceb57b26306cc8bdcfc77f3874246338864fd118

show more ...

Remove a lame clang-format off

Code was tabbed into the wrong spot as a result of shutting clang-format
off for a dubious reason. Turn it back on.

Tested: It builds. Only whitespace changes prese

Remove a lame clang-format off

Code was tabbed into the wrong spot as a result of shutting clang-format
off for a dubious reason. Turn it back on.

Tested: It builds. Only whitespace changes present

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I08b294ca5ea076f8cb5680b801b507127e091824

show more ...

Fix variable name case style for CI warning

CI gives a warning for invalid case style in variable names. This
fixes the warnings that show up so far.

Change-Id: I2a8706d3283bdc685dc026391de715accea

Fix variable name case style for CI warning

CI gives a warning for invalid case style in variable names. This
fixes the warnings that show up so far.

Change-Id: I2a8706d3283bdc685dc026391de715accea7b86e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Don't set result to success when calling success

res.success is the default, if one async call
sets failure, and another later sets success, we
don't want to overwrite the failure with sucess.

Test

Don't set result to success when calling success

res.success is the default, if one async call
sets failure, and another later sets success, we
don't want to overwrite the failure with sucess.

Tested-by: still got success on good patch

Change-Id: Iee76892f7517d508ed98929d9ecd127dd83b1329
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add MessageArgs for Redfish messages from the Base registry

Per the Redfish API Specification, the MessageArgs array of
strings is required when using a MessageId for a
parameterized message.

This

Add MessageArgs for Redfish messages from the Base registry

Per the Redfish API Specification, the MessageArgs array of
strings is required when using a MessageId for a
parameterized message.

This change adds the MessageArgs array for the Redfish messages
that we use from the Base message registry.

Tested: Manually set various error types and confirmed that the
MessageArg array was properly displayed.

Change-Id: I2248128f8290305ba3466ef2ce57447ce970a57d
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simpl

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simplifies the interface by using a
string so there doesn't have to be a '/'. This allowed the
same property argument passed for the message to be used
for the property field path.

Tested: Sent an error with a property and verified that it is
correctly displayed.

Change-Id: I0571e2eee627cedf29d751588a4f1bceee66f084
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Update Redfish to Base.1.4.0 message registry

Update the Redfish error_messages from Base.1.2.0 to Base.1.4.0
from the Redfish standard registries.

Change-Id: I771b119372fd995bd1dc4065830485b6a848f

Update Redfish to Base.1.4.0 message registry

Update the Redfish error_messages from Base.1.2.0 to Base.1.4.0
from the Redfish standard registries.

Change-Id: I771b119372fd995bd1dc4065830485b6a848f086
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Update formatting of error string literals and message descriptions

clang-format doesn't automatically merge multi-line string
literals, so this change updates the formatting to merge some
multi-lin

Update formatting of error string literals and message descriptions

clang-format doesn't automatically merge multi-line string
literals, so this change updates the formatting to merge some
multi-line strings into fewer lines.

This change also corrects the <argx> numbering in the error message
descriptions to match the function parameter numbers.

Change-Id: Ibedcaf5793a607acacdb3bc83081599ba508c989
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncRe

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: Icfdce2de763225f070e8dd61e591f296703f46bb
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Move to clang-format-6.0

This commit moves the codebase to the lastest clang-format file from
upstream, as well as clang-format-6.0.

Change-Id: Ice8313468097c0c42317fbb9e10ddf036e8cff4c
Signed-off-

Move to clang-format-6.0

This commit moves the codebase to the lastest clang-format file from
upstream, as well as clang-format-6.0.

Change-Id: Ice8313468097c0c42317fbb9e10ddf036e8cff4c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move over to upstream c++ style

This patchset moves bmcweb over to the upstream style naming
conventions for variables, classes, and functions, as well as imposes
the latest clang-format file.

This

Move over to upstream c++ style

This patchset moves bmcweb over to the upstream style naming
conventions for variables, classes, and functions, as well as imposes
the latest clang-format file.

This changeset was mostly built automatically by the included
.clang-tidy file, which has the ability to autoformat and auto rename
variables. At some point in the future I would like to see this in
greater use, but for now, we will impose it on bmcweb, and see how it
goes.

Tested: Code still compiles, and appears to run, although other issues
are possible and likely.

Change-Id: If422a2e36df924e897736b3feffa89f411d9dac1
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Pull in nlohmann json as a dependency rather than checking in.

This should allow keeping closer to the upstream yocto recipes, and
avoid excess code in the repo

Change-Id: Ib66f7cf69b68bb23f9789580

Pull in nlohmann json as a dependency rather than checking in.

This should allow keeping closer to the upstream yocto recipes, and
avoid excess code in the repo

Change-Id: Ib66f7cf69b68bb23f9789580beadf8344cb68cfa
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Introduce Redfish Error messages definitions

Added a python script that should be use to generate error_messages.cpp na .hpp
files. These files as are not subject to change in a dynamic manner, shou

Introduce Redfish Error messages definitions

Added a python script that should be use to generate error_messages.cpp na .hpp
files. These files as are not subject to change in a dynamic manner, should be
regenerated only when MessageRegistry changes.

Tested on x86 Ubuntu VM and Wolfpass platform:
a) No regression in BMCWeb interface
- Went through WebUI observed no changes in functionality
b) No regression in Redfish functionality
- Went through nodes and observed no changes in functionality
- Sessions now return error messages in addition to HTTP codes

Change-Id: I4aba9ee247b6cd2c46a9c158d14bdc7546e9b11b
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...