Systems: Add space in Debug traces

Before:
"Got 71led group objects"

Tested: Built bmcweb with DCMAKE_BUILD_TYPE=Debug.

Change-Id: I80f7613c338e9fd16b2335ca0adc935dfa142a51
Signed-off-by: Gunnar M

Systems: Add space in Debug traces

Before:
"Got 71led group objects"

Tested: Built bmcweb with DCMAKE_BUILD_TYPE=Debug.

Change-Id: I80f7613c338e9fd16b2335ca0adc935dfa142a51
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Revert "Add Storage Schema for NVMe on Redfish"

This reverts commit e56c7b7092298c609831a65bcc8c21e62d422ba7.

Reason for revert: /redfish/v1/Systems/1 returns no result. This should've been flagge

Revert "Add Storage Schema for NVMe on Redfish"

This reverts commit e56c7b7092298c609831a65bcc8c21e62d422ba7.

Reason for revert: /redfish/v1/Systems/1 returns no result. This should've been flagged in service validator, but the commit mentions that test was run, so it's not clear how this was missed.

Reverting for a moment until we can determine what happened.

Change-Id: I276d4cd239adb87b77264bc65ab4856705274ff0

show more ...

Add Storage Schema for NVMe on Redfish

This provides an implementation for the Get methods for the Storage
schemas using following classes :
- StorageCollection
- Storage

Tested:
- Ran Redfish Serv

Add Storage Schema for NVMe on Redfish

This provides an implementation for the Get methods for the Storage
schemas using following classes :
- StorageCollection
- Storage

Tested:
- Ran Redfish Service Validator to verify no issues are reported.
- Tested that the NVMe drives in the system show up and proper fields
are populated with appropriate data.
- Tested with no drives present. Made sure the Storage interface shows
no drives and Drive interface returns error message.

Signed-off-by: Nikhil Potade <nikhil.potade@linux.intel.com>
Change-Id: I9fa9f4cd69fe07cde15604c5405a6987774065fd

show more ...

Redfish: Permit Usb and CD boot overrides

Implemented corrections to allow booting from removeable media. USB
did not function, and CD was also failing.

Eliminated code that calculated the boot str

Redfish: Permit Usb and CD boot overrides

Implemented corrections to allow booting from removeable media. USB
did not function, and CD was also failing.

Eliminated code that calculated the boot string and boot mode
twice. Always assigned a boot type and boot mode, to simplify the
asynchronous function calls.

Changed the Redfish result to return "204 No Content" when the PATCH
operation is successful. Any async function call that fails overrides
this value.

Tested:
Performed a full set of BootSource/BootMode combinations. Confirmed
the values were set correctly by using "ipmitool raw 0 9 5 0 0" to
read the values that the BIOS will read after a reboot.

Also tested the full set of combinations by issuing hard resets. All
boot combinations worked on a S2600WF within the limits of the S2600WF
BIOS.

Change-Id: If5480e20040d96bc12961125fdbd4ebbb30b0ada
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Redfish: Prevent IndicatorLED PATCH from breaking Boot PATCH

Preloading an error into res.result causes the readJson function to
return with that same error. This blocks any PATCH actions on the Boo

Redfish: Prevent IndicatorLED PATCH from breaking Boot PATCH

Preloading an error into res.result causes the readJson function to
return with that same error. This blocks any PATCH actions on the Boot
array. The PATCH command now responds with an OK response instead of a
Missing Data response.

Tested:
Confirmed the Lit action illuminates the ID LED.
Confirmed the Blinking action causes the ID LED to blink.
Confirmed the Off action turns off the ID LED.
Confirmed Blinking overrides Lit.
Confirmed Lit overrides Blinking.
Confirmed Flashing is returns an error message.

Change-Id: I86104e2a1232f1905a7c54eb00e399b634fa69d3
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Fix "MemorySummary" status: Disabled on IBM systems

"MemorySummary" Status is always Disabled.Fixed it.

Doing GET on Interface xyz.openbmc_project.State.Decorator.OperationalStatus
instead of xyz.o

Fix "MemorySummary" status: Disabled on IBM systems

"MemorySummary" Status is always Disabled.Fixed it.

Doing GET on Interface xyz.openbmc_project.State.Decorator.OperationalStatus
instead of xyz.openbmc_project.Inventory.Item.Dimm to get the State of Dimm

Tested:
-- Ran GET request on the ComputerSystem node when Host is Up
curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system
"MemorySummary": {
"Status": {
"State": "Enabled"
},
"TotalSystemMemoryGiB": 0
},

Redfish schema validator.
ComputerSystem.v1_0_0.MemorySummary:Status
value: OrderedDict([('State', 'Enabled')]) <class 'collections.OrderedDict'>
has Type: Resource.Status complex
is Optional
***going into Complex
Resource.Status:State
value: Enabled <class 'str'>
has Type: Resource.State enum
is Optional
permission OData.Permission/Read
Success

MemorySummary.TotalSystemMemoryGiB PASS
MemorySummary.Status complex
MemorySummary.Status.State PASS

Change-Id: I272a2c6c53f39be3dafd62759be4cc65aa0dd74f
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...

Fix Regression in PATCH on system node

Commit d573bb2a regressed the PATCH operation
on the system redfish node. By initializing
result to no_content, the commit broke the subsequent
json_util::read

Fix Regression in PATCH on system node

Commit d573bb2a regressed the PATCH operation
on the system redfish node. By initializing
result to no_content, the commit broke the subsequent
json_util::readJson, which checks if the result is "ok"
at the end of the function.

This commit fixes it by making readJsonValues() and its
descendants return a bool status. readJson() no longer
relies on the response object result to indicate success/
failure.

Tested:
-- Verified that PATCH operations on the system node now work.
-- Verified PATCH operations work on manager, accountservice and
ethernetinterfaces nodes.
-- No new errors from the Redfish validator.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I54080392297a8f0276161da8b48d8f9518cbdcfe

show more ...

Fix Error on Missing interface

Missing interface != 500 error, just means less data
we can show.

Tested: No 500 error on systems with missing interface

Change-Id: Ifaecd67f8f4f6faed26c7a24ab79dfbd

Fix Error on Missing interface

Missing interface != 500 error, just means less data
we can show.

Tested: No 500 error on systems with missing interface

Change-Id: Ifaecd67f8f4f6faed26c7a24ab79dfbd82462291
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix ProcessorSummary Count and Status

ProcessorSummary State is always Disabled and Count shows 0.
Fixed it by using correct interface to get these values.

Doing GET on Interface xyz.openbmc_projec

Fix ProcessorSummary Count and Status

ProcessorSummary State is always Disabled and Count shows 0.
Fixed it by using correct interface to get these values.

Doing GET on Interface xyz.openbmc_project.State.Decorator.OperationalStatus
instead of xyz.openbmc_project.Inventory.Item.Cpu to get the State of CPU

Tested:
-- Ran GET request on the ComputerSystem node

--when 2 CPUs are present and functional

"ProcessorSummary": {
"Count": 2,
"Status": {
"State": "Enabled"
}
},

--when 2 CPUs are present but only 1 is functional
"ProcessorSummary": {
"Count": 2,
"Status": {
"State": "Enabled"
}
},

--when only 1 CPU present and functional
"ProcessorSummary": {
"Count": 1,
"Status": {
"State": "Enabled"
}
},

--when only 1 CPU present and Not Functional
"ProcessorSummary": {
"Count": 1,
"Status": {
"State": "Disabled"
}
},

--Ran Redfish-Service-Validator
ComputerSystem.v1_0_0.ProcessorSummary:Count
value: 2 <class 'int'>
has Type: Edm.Int64 Edm.Int64
is Optional
permission OData.Permission/Read
Success
ComputerSystem.v1_0_0.ProcessorSummary:Status
value: OrderedDict([('State', 'Enabled')]) <class 'collections.OrderedDict'>
has Type: Resource.Status complex
is Optional
***going into Complex
Resource.Status:State
value: Enabled <class 'str'>
has Type: Resource.State enum
is Optional
permission OData.Permission/Read
Success
ProcessorSummary.Count PASS
ProcessorSummary.Model Optional
ProcessorSummary.Status complex
ProcessorSummary.Status.State PASS

Change-Id: I953db79da965b4493d7bd0005820945383b1377c

Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>
Change-Id: I1d5f76adf2ed8a66d8b27aeca59e0d1a5730e6a8

show more ...

Add Redfish PCIe information

This adds the capability to get PCIe device information from
D-Bus and display it in the appropriate Redfish PCIeDevice
and PCIeFunction objects.

Tested: Passed the Red

Add Redfish PCIe information

This adds the capability to get PCIe device information from
D-Bus and display it in the appropriate Redfish PCIeDevice
and PCIeFunction objects.

Tested: Passed the Redfish validator for the new PCIeDevice
and PCIeFunction objects.

Change-Id: I06f3b0e7d283e48d2235b7d34f78f603b22de79f
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

bmcweb implementation of NMI (soft reset) control code

Tested : Verified following

1) Redfish validator result is Negative
2) verified following command triggered NMI on host
curl -k -H "X

bmcweb implementation of NMI (soft reset) control code

Tested : Verified following

1) Redfish validator result is Negative
2) verified following command triggered NMI on host
curl -k -H "X-Auth-Token: $bmc_token" -X POST
https://9.5.180.47/redfish/v1/Systems/system/Actions/ComputerSystem.Reset
-d '{"ResetType":"Nmi"}'
Response : OK
2) Host rebooted and crash dump is collected

Signed-off-by: Lakshminarayana R. Kammath <lkammath@in.ibm.com>
Change-Id: I09efa1e3d94437c89afbe1a1b9d148cc4f577ebe

show more ...

Health / Rollup Support

Look for associations for inventory and compare the
inventory warning / critical and global warning / critical
to get HealthRollup and Health respectively.

Tested:

Used sen

Health / Rollup Support

Look for associations for inventory and compare the
inventory warning / critical and global warning / critical
to get HealthRollup and Health respectively.

Tested:

Used sensor override to set BMC temp to Upper critical
and saw:

{
"@odata.context": "/redfish/v1/$metadata#Chassis.Chassis",
"@odata.id": "/redfish/v1/Chassis/WFP_Baseboard",
"@odata.type": "#Chassis.v1_4_0.Chassis",
"ChassisType": "RackMount",
"Id": "WFP_Baseboard",
"Links": {
"ComputerSystems": [
{
"@odata.id": "/redfish/v1/Systems/system"
}
],
"ManagedBy": [
{
"@odata.id": "/redfish/v1/Managers/bmc"
}
]
},
"Manufacturer": "Intel Corporation",
"Model": "S2600WFT",
"Name": "WFP_Baseboard",
"PartNumber": "123456789",
"Power": {
"@odata.id": "/redfish/v1/Chassis/WFP_Baseboard/Power"
},
"PowerState": "Off",
"SerialNumber": "123454321",
"Status": {
"Health": "Warning",
"HealthRollup": "Critical",
"State": "StandbyOffline"
},
"Thermal": {
"@odata.id": "/redfish/v1/Chassis/WFP_Baseboard/Thermal"
}
}

Change-Id: Idd9e832db18bb4769f1452fe243d68339a6f844d
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Systems: Add AssetTag Support

We can get this item from the AssetTag interface.

Tested:

{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1

Systems: Add AssetTag Support

We can get this item from the AssetTag interface.

Tested:

{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_6_0.ComputerSystem",
"Actions": {
"#ComputerSystem.Reset": {
"ResetType@Redfish.AllowableValues": [
"On",
"ForceOff",
"ForceOn",
"ForceRestart",
"GracefulRestart",
"GracefulShutdown",
"PowerCycle"
],
"target": "/redfish/v1/Systems/system/Actions/ComputerSystem.Reset"
}
},
"AssetTag": "abc",
"Description": "Computer System",
"Id": null,
....

Change-Id: I1c92b001cc08bd0661368d28d9fb8ae56c122d1e
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove pulling BiosID for the system schema

This is causing 500 errors on POWER platforms, given that (shocker) they
don't have a BIOS! In practice, this isn't even the right way to grab
the versio

Remove pulling BiosID for the system schema

This is causing 500 errors on POWER platforms, given that (shocker) they
don't have a BIOS! In practice, this isn't even the right way to grab
the version information, we should be grabbing it over the software
version interface https://github.com/openbmc/phosphor-dbus-interfaces
/blob/master/xyz/openbmc_project/Software/Version.interface.yaml

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I45704b879a57d152c898594770e8d3729ad9e72e

show more ...

Redfish: Added OCP mandatory properties

- Manager: Added SerialConsole, Links/ManagerForChassis and Links/ManagerForChassis@odata.count
- System: Added Links/Chassis, Links/ManagedBy, Status, BiosVe

Redfish: Added OCP mandatory properties

- Manager: Added SerialConsole, Links/ManagerForChassis and Links/ManagerForChassis@odata.count
- System: Added Links/Chassis, Links/ManagedBy, Status, BiosVersion
- Power: Added placeholder for PowerControl

Tested:
GET /redfish/v1/Systems/system HTTP/1.1
Response:
{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_6_0.ComputerSystem",
......
"BiosVersion": "SE5C620.86B.01.00.0361.120520162351",
......
"Description": "Computer System",
"Id": "system",
"IndicatorLED": "Off",
"Links": {
"Chassis": [
{
"@odata.id": "/redfish/v1/Chassis/R1000_Chassis"
}
],
"ManagedBy": [
{
"@odata.id": "/redfish/v1/Managers/bmc"
}
]
},
......

"Processors": {
"@odata.id": "/redfish/v1/Systems/system/Processors"
},
"Status": {
"Health": "OK",
"State": "Enabled"
},
"SystemType": "Physical",
"UUID": "13876882-7708-4200-bcf2-2c5681218bc8"
}

GET /redfish/v1/Managers/bmc HTTP/1.1
Response:
{
"@odata.context": "/redfish/v1/$metadata#Manager.Manager",
"@odata.id": "/redfish/v1/Managers/bmc",
"@odata.type": "#Manager.v1_3_0.Manager",
......
"Description": "Baseboard Management Controller",
"Linkn"fces": {
"@odata.id": "/redfish/v1/Managers/bmc/EthernetInterfaces"
},
"FirmwareVersion": "2.7.0-dev-266-g111d297-d14e857",
"Id": "bmc",
Links: {
"ManagerForChassis": [
{
"@odata.id": "/redfish/v1/Chassis/R1000_Chassis"
}
],
"ManagerForChassis@odata.count": 1,
"ManagerForServers": [
{
"@odata.id": "/redfish/v1/Systems/system"
}
],
"ManagerForServers@odata.count": 1
},
......

"SerialConsole": {
"ConnectTypesSupported": [
"IPMI",
"SSH"
],
"ServiceEnabled": true
},
"Status": {
"Health": "OK",
"State": "Enabled"
},
"UUID": "067b4e8d-6c29-475c-92a1-6590d4e5818c"
}

GET /redfish/v1/Chassis/R1000_Chassis/Power HTTP/1.1
Response:
{
"@odata.context": "/redfish/v1/$metadata#Power.Power",
"@odata.id": "/redfish/v1/Chassis/R1000_Chassis/Power",
"@odata.type": "#Power.v1_2_1.Power",
"Id": "Power",
"Name": "Power",
"PowerControl": []
}

Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>
Change-Id: I61d8ba493ad689d7062e1f8bfd26d9a0d80230da

show more ...

Update supported ResetTypes and actions

This updates the supported ResetType options and triggers the
corresponding state change request on DBus.

Tested:
Used Postman to send POST commands with var

Update supported ResetTypes and actions

This updates the supported ResetType options and triggers the
corresponding state change request on DBus.

Tested:
Used Postman to send POST commands with various ResetType values
and confirmed the appropriate response:
ForceOff: System forced off
ForceOn: System powered-on
ForceRestart: System reset forced
GracefulRestart: System gracefully shut down followed by
a power-on
GracefulShutdown: System gracefully shut down
Nmi: Not supported:
On: System powered-on
PowerCycle: System forced off followed by a power-on
PushPowerButton: Not supported

Change-Id: Id672b154968fa46c540272c1af6709b04770a849
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Fix DBUS Name For BootSource Cd

Commit 9f16b2c1b6b6884482bca304fcaa573caf91d0d6
changed the mapping for redfish boot source 'Cd' to
'xyz.openbmc_project.Control.Boot.Source.Sources.DVD'.
However, th

Fix DBUS Name For BootSource Cd

Commit 9f16b2c1b6b6884482bca304fcaa573caf91d0d6
changed the mapping for redfish boot source 'Cd' to
'xyz.openbmc_project.Control.Boot.Source.Sources.DVD'.
However, that mapping does not match what we have in
phosphor-dbus-interfaces:
'xyz.openbmc_project.Control.Boot.Source.Sources.ExternalMedia'

This commit reverts that mapping back to ExternalMedia.

Tested:
-- Ran redfish service validator - no errors seen.
-- Tested PATCH on BootSourceOverrideTarget with value "Cd"
curl -k -H "X-Auth-Token: $bmc_token" -X PATCH
https://${bmc}:${port}/redfish/v1/Systems/system -d '{"Boot":
{"BootSourceOverrideEnabled": "Continuous", "BootSourceOverrideTarget": "Cd"}}'
{
"@Message.ExtendedInfo": [
{
"@odata.type": "/redfish/v1/$metadata#Message.v1_0_0.Message",
"Message": "Successfully Completed Request",
"MessageArgs": [],
"MessageId": "Base.1.4.0.Success",
"Resolution": "None",
"Severity": "OK"
}
]

curl -k -H "X-Auth-Token: $bmc_token" -X GET
https://${bmc}:${port}/redfish/v1/Systems/system
{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1/Systems/system",
....
....
....
"Boot": {
"BootSourceOverrideEnabled": "Continuous",
"BootSourceOverrideMode": "Legacy",
"BootSourceOverrideTarget": "Cd",
"BootSourceOverrideTarget@Redfish.AllowableValues": [
"None",
"Pxe",
"Hdd",
"Cd",
"Diags",
"BiosSetup"
]
},

Change-Id: Ibd1fe3bc2c98dc97422b8dd71f9f95f6e9e25285
Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>

show more ...

[Redfish] Fixed PATCH behavior of IndicatorLED in ComputerSystem

Patching IndicatorLED to "Lit" was not working. Also modified the
response code to 204 no-content for successful PATCH request.

Test

[Redfish] Fixed PATCH behavior of IndicatorLED in ComputerSystem

Patching IndicatorLED to "Lit" was not working. Also modified the
response code to 204 no-content for successful PATCH request.

Tested:
PATCH /redfish/v1/Systems/system HTTP/1.1
{
"IndicatorLED": "Lit"
}
Response:
204 No Content

GET /redfish/v1/Systems/system HTTP/1.1
Response:
{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_6_0.ComputerSystem",
"Actions": {
"#ComputerSystem.Reset": {
"ResetType@Redfish.AllowableValues": [
"On",
"ForceOff",
"GracefulRestart",
"GracefulShutdown"
],
"target": "/redfish/v1/Systems/system/Actions/ComputerSystem.Reset"
}
},
"Boot": {
"BootSourceOverrideEnabled": "Disabled",
"BootSourceOverrideMode": "Legacy",
"BootSourceOverrideTarget": "None",
"BootSourceOverrideTarget@Redfish.AllowableValues": [
"None",
"Pxe",
"Hdd",
"Cd",
"Diags",
"BiosSetup"
]
},
"Description": "Computer System",
"Id": "system",
"IndicatorLED": "Lit",
"LogServices": {
"@odata.id": "/redfish/v1/Systems/system/LogServices"
},
"Memory": {
"@odata.id": "/redfish/v1/Systems/system/Memory"
},
"MemorySummary": {
"Status": {
"State": "Disabled"
},
"TotalSystemMemoryGiB": 0
},
"Name": "Computer System",
"PowerState": "On",
"ProcessorSummary": {
"Count": 4,
"Model": "Intel Xeon processor",
"Status": {
"State": "Enabled"
}
},
"Processors": {
"@odata.id": "/redfish/v1/Systems/system/Processors"
},
"Status": {
"State": "Enabled"
},
"SystemType": "Physical",
"UUID": "13876882-7708-4200-bcf2-2c5681218bc8"
}

Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>
Change-Id: I8ae152190ee9f122e8580903a9d5e687b2fd9e13

show more ...

[Redfish] Fix incorrect mapping of dbus and Redfish API strings for BootSource

- "Cd" should be mapped to "xyz.openbmc_project.Control.Boot.Source.Sources.DVD"
- Adding mapping "Usb" to "xyz.openbmc

[Redfish] Fix incorrect mapping of dbus and Redfish API strings for BootSource

- "Cd" should be mapped to "xyz.openbmc_project.Control.Boot.Source.Sources.DVD"
- Adding mapping "Usb" to "xyz.openbmc_project.Control.Boot.Source.Sources.Removable"

Tested:
PATCH /redfish/v1/Systems/system HTTP/1.1
{
"Boot": {
"BootSourceOverrideTarget": "Cd" (or "Usb")
}
}
Response:
{
"@Message.ExtendedInfo": [
{
"@odata.type": "/redfish/v1/$metadata#Message.v1_0_0.Message",
"Message": "Successfully Completed Request",
"MessageArgs": [],
"MessageId": "Base.1.4.0.Success",
"Resolution": "None",
"Severity": "OK"
}
]
}

GET /redfish/v1/Systems/system HTTP/1.1
Response:
...
Boot:
{
...
"BootSourceOverrideTarget": "Cd", (or "Usb")
...
}
...

Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>
Change-Id: Ib5f69fe93d45b4012c089bd48e484ef978a4e57a

show more ...

Redfish: Remove BMCWEB_ENABLE_REDFISH_ONE_CHASSIS

Removed the BMCWEB_ENABLE_REDFISH_ONE_CHASSIS #define. The new support
for finding chassis sensors via associations is now used on all systems.

Te

Redfish: Remove BMCWEB_ENABLE_REDFISH_ONE_CHASSIS

Removed the BMCWEB_ENABLE_REDFISH_ONE_CHASSIS #define. The new support
for finding chassis sensors via associations is now used on all systems.

Test Plan:
https://gist.github.com/smccarney/f5b4783d8cf41a486ceff9b941b1ba9a

Tested: Verified the Chassis, Power, and Thermal output was valid on a
Witherspoon system. Verified sensor associations on Witherspoon
work with bmcweb implementation. Ran Redfish Service Validator.

Change-Id: I975f79da2c9de63e4ddd155d39ea872ca9fbffa9
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

fw-inventory: Provide BiosVersion in system obj

Created a new fw_utils.hpp to reduce more indentation code in
systems.hpp and also as a base for some future refactoring for common
use cases to acces

fw-inventory: Provide BiosVersion in system obj

Created a new fw_utils.hpp to reduce more indentation code in
systems.hpp and also as a base for some future refactoring for common
use cases to access firmware information.

Tested:
- Verified RedfishServiceValidator.py shows no new errors
VERBO - ComputerSystem.v1_0_0.ComputerSystem:BiosVersion
VERBO - value: IBM-witherspoon-OP9-v2.0.10-2.22 <class 'str'>
VERBO - has Type: Edm.String Edm.String
VERBO - is Optional
VERBO - permission OData.Permission/Read
VERBO - Success

- BiosVersion now correctly returned in data
$ curl -k -H "X-Auth-Token: $TOKEN" -X GET https://${BMC_IP}/redfish/v1/Systems/system
{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_5_1.ComputerSystem",
"Actions": {
"#ComputerSystem.Reset": {
"ResetType@Redfish.AllowableValues": [
"On",
"ForceOff",
"GracefulRestart",
"GracefulShutdown"
],
"target": "/redfish/v1/Systems/system/Actions/ComputerSystem.Reset"
}
},
"BiosVersion": "IBM-witherspoon-OP9-v2.0.10-2.22",
...
}

Change-Id: I2d7792c724f88aa13bd7b40c0d7f70dd4aa1c807
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add BMCWEB_ENABLE_REDFISH_ONE_CHASSIS build option

Define a new build option named BMCWEB_ENABLE_REDFISH_ONE_CHASSIS that
is not set by default.

When this build option is set, bmcweb will always re

Add BMCWEB_ENABLE_REDFISH_ONE_CHASSIS build option

Define a new build option named BMCWEB_ENABLE_REDFISH_ONE_CHASSIS that
is not set by default.

When this build option is set, bmcweb will always return a single
chassis named "chassis".

Setting this option will also cause all sensors to be shown under this
chassis.

This is a short-term solution. Long term, inventory-manager needs to be
enhanced to allow sensors to be under a chassis, or the rest of the
project needs to move to EntityManager.

Currently IBM does not use EntityManager, but EntityManager is called
directly in sensors.hpp. This results in an HTTP 500 Internal Server
Error.

Tested: The URLs /redfish/v1/Chassis/ and /redfish/v1/Chassis/chassis
show correct data on a Witherspoon. /redfish/v1/Managers/bmc/
now has a link to the single chassis.
/redfish/v1/Chassis/chassis/Power and
/redfish/v1/Chassis/chassis/Thermal no longer result in an
HTTP 500 Internal Server Error. Ran Redfish Service Validator.
Change-Id: Iec8f4da333946f19330f37ab084cd9787c52c8ea
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

Fix IndicatorLED "Blinking" value

Blink is not a valid value for Redfish IndicatorLED.
Blinking is though. Changed. See:
https://redfish.dmtf.org/schemas/ComputerSystem.v1_6_0.json
http://redfish.dm

Fix IndicatorLED "Blinking" value

Blink is not a valid value for Redfish IndicatorLED.
Blinking is though. Changed. See:
https://redfish.dmtf.org/schemas/ComputerSystem.v1_6_0.json
http://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/IndicatorLED

LED D-Bus interface has the value "Blink". Updated.
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Led/Physical.interface.yaml#L40

Tested: Limited.
Change-Id: I183b72f06f2dddf6a37592893e841d810d06a0d6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Support for boot properties

This commit adds support for DBUS properties BootMode and BootSource
in the Redfish ComputerSystems schema. These properties reside on the
BMC in two DBUS objects:

/xyz/

Support for boot properties

This commit adds support for DBUS properties BootMode and BootSource
in the Redfish ComputerSystems schema. These properties reside on the
BMC in two DBUS objects:

/xyz/openbmc_project/control/host0/boot contains settings that apply
on each boot
/xyz/openbmc_project/control/host0/boot/one_time contains settings
that apply for one boot only

The interface definition can be looked up in
phosphor-dbus-interfaces/tree/master/xyz/openbmc_project/Control/Boot

BootMode and BootSource are together mapped into the Redfish property
BootSourceOverrideTarget. Specifically, we only support the following
BootSource's: None (default source), Pxe, Hdd, Cd, Diags and BiosSetup

Diags and BiosSetup get mapped to the BootMode property, whereas the
other values get mapped to the BootSource property.

In addition, we map the BootSourceOverrideEnabled redfish property
to the Enabled property in
/xyz/openbmc_project/control/host0/boot/one_time to indicate if the
override applies for just this boot or all future boots.

Tested:
-- Ran the Redfish schema validator - no errors.
-- Ran GET and PATCH requets on the ComputerSystem node to test
setting of each property individually as well as together.

Ex:
curl -k -H "X-Auth-Token: $bmc_token" -XGET
https://${bmc}:${port}/redfish/v1/Systems/system
....
....
"Boot": {
"BootSourceOverrideEnabled": "Disabled",
"BootSourceOverrideMode": "Legacy",
"BootSourceOverrideTarget": "None",
"BootSourceOverrideTarget@Redfish.AllowableValues": [
"None",
"Pxe",
"Hdd",
"Cd",
"Diags",
"BiosSetup"
]
}
....

curl -k -H "X-Auth-Token: $bmc_token" -X PATCH
https://${bmc}:${port}/redfish/v1/Systems/system -d '{"Boot":
{"BootSourceOverrideEnabled": "Once",
"BootSourceOverrideTarget": "Diags"}}'

curl -k -H "X-Auth-Token: $bmc_token" -XGET
https://${bmc}:${port}/redfish/v1/Systems/system
....
....
"Boot": {
"BootSourceOverrideEnabled": "Once",
"BootSourceOverrideMode": "Legacy",
"BootSourceOverrideTarget": "Diags",
"BootSourceOverrideTarget@Redfish.AllowableValues": [
"None",
"Pxe",
"Hdd",
"Cd",
"Diags",
"BiosSetup"
]
}
....

curl -k -H "X-Auth-Token: $bmc_token" -X PATCH
https://${bmc}:${port}/redfish/v1/Systems/system -d '{"Boot":
{"BootSourceOverrideEnabled": "Disabled"}}'

curl -k -H "X-Auth-Token: $bmc_token" -XGET
https://${bmc}:${port}/redfish/v1/Systems/system'
....
....
"Boot": {
"BootSourceOverrideEnabled": "Disabled",
"BootSourceOverrideMode": "Legacy",
"BootSourceOverrideTarget": "None",
"BootSourceOverrideTarget@Redfish.AllowableValues": [
"None",
"Pxe",
"Hdd",
"Cd",
"Diags",
"BiosSetup"
]
}
....

Change-Id: If8850428422de822cd0e220ceaff4168f4b50391
Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>

show more ...

Redfish remove buildDate property from system

BuildDate does not exist in the Redfish ComputerSystem schema. Checks for
the appropriate properties for system and adds them, rather than adding
all pr

Redfish remove buildDate property from system

BuildDate does not exist in the Redfish ComputerSystem schema. Checks for
the appropriate properties for system and adds them, rather than adding
all properties returned.

Tested: Verified /redfish/v1/Systems/system/ returns the correct
properties on a Witherspoon system, and buildDate is no
longer returned.

Change-Id: I83e8f637b17868eda810cbe342d1569d534a6d1b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...