sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia5d0845741f1d8d4bc6fd227c6d2e6f3a8d42b2e

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86e11299512704fa1df1e5f6517ea25cc6eced8f

Add support for Quiesced state

OpenBMC has a Quiesced state, Redfish does as well.
Set Redfish "Status""Sate" to Quiesced and "PowerState" to On,
if the D-Bus HoseState is Quiesced.

Tested: Validat

Add support for Quiesced state

OpenBMC has a Quiesced state, Redfish does as well.
Set Redfish "Status""Sate" to Quiesced and "PowerState" to On,
if the D-Bus HoseState is Quiesced.

Tested: Validator passed on a Witherspoon system in this Quiesced
state.

"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Quiesced"
},

Change-Id: I53299d51aa0ee065bb5794bab32f69b2a0f8acb2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Map policy restore D-Bus interface to Redfish

Tested:
curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system
{
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#C

Map policy restore D-Bus interface to Redfish

Tested:
curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system
{
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_6_0.ComputerSystem",
... ...
"PowerRestorePolicy": "AlwaysOff",
... ...
}

curl -k -H "X-Auth-Token: $token" -X PATCH -d '{"PowerRestorePolicy":"AlwaysOn"}' https://${bmc}/redfish/v1/Systems/system

curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system
{
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_6_0.ComputerSystem",
... ...
"PowerRestorePolicy": "AlwaysOn",
... ...
}

curl -k -H "X-Auth-Token: $token" -X PATCH -d '{"PowerRestorePolicy":"TestPolicy"}' https://${bmc}/redfish/v1/Systems/system
{
"error": {
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_0_0.Message",
"Message": "The request failed due to an internal service error. The service is still operational.",
"MessageArgs": [],
"MessageId": "Base.1.4.0.InternalError",
"Resolution": "Resubmit the request. If the problem persists, consider resetting the service.",
"Severity": "Critical"
}
],
"code": "Base.1.4.0.InternalError",
"message": "The request failed due to an internal service error. The service is still operational."
}
}

Passed the validator:
VERBO - ServiceRoot -> Systems.Systems -> Members.ComputerSystem#0, ComputerSystem.v1_10_0, ComputerSystem
VERBO - @odata.id PASS
VERBO - @odata.type PASS
VERBO - Actions complex
VERBO - Bios PASS
VERBO - Boot complex
VERBO - Description PASS
VERBO - Id PASS
VERBO - Links complex
VERBO - LogServices PASS
VERBO - Memory PASS
VERBO - MemorySummary complex
VERBO - Name PASS
VERBO - PowerRestorePolicy PASS
... ...

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I75155c5cb930d6c4d9d5aad39f3315506db28e38

show more ...

Adding Hypervisor system and Hypervisor Interface

This commit implements the GET commands for Power hypervisor
Virtual Management Interface's interface collection.

Tested by:
1. GET https://${bmc}/

Adding Hypervisor system and Hypervisor Interface

This commit implements the GET commands for Power hypervisor
Virtual Management Interface's interface collection.

Tested by:
1. GET https://${bmc}/redfish/v1/Systems
2. GET https://${bmc}/redfish/v1/Systems/hypervisor
3. GET https://${bmc}/redfish/v1/Systems/hypervisor/EthernetInterfaces
4. Successfully ran the Redfish Validator

*** /redfish/v1/Systems
Type (#ComputerSystemCollection.ComputerSystemCollection), GET SUCCESS (time: 0.335171)
PASS

*** /redfish/v1/Systems/hypervisor
Type (#ComputerSystem.v1_6_0.ComputerSystem), GET SUCCESS (time: 0.341849)
PASS

*** /redfish/v1/Systems/hypervisor/EthernetInterfaces
Type (#EthernetInterfaceCollection.EthernetInterfaceCollection), GET SUCCESS (time: 0.362111)
PASS
5. Verified the hypervisor in not listed on BMC which does not implement
the Hypervisor object

Signed-off-by: Sunitha Harish <sunithaharish04@gmail.com>
Change-Id: Ie1eb166808473137dd65df54fb4d748cfd1131d2

show more ...

System: Remove 2nd setting of "Id"

Id was already set to "system".

This changes the Id from the Serial number to "system".

Id now matches the last segment of the URL/@odata.id.
Could not find a ha

System: Remove 2nd setting of "Id"

Id was already set to "system".

This changes the Id from the Serial number to "system".

Id now matches the last segment of the URL/@odata.id.
Could not find a hard rule to require the Id to match the last segment
of the URL/@data.id but all Redfish mockups match this way, other bmcweb
resources do as well, and redfishtool is easier to use if this is true.

Tested: Validator passes.

curl -k https://${bmc}/redfish/v1/Systems/system/
...
"Description": "Computer System",
"Id": "system",
"IndicatorLED": "Off",
"Links": {
"Chassis": [
{
"@odata.id": "/redfish/v1/Chassis/chassis"
}
],

Change-Id: Ib2cc34f033accfe6ed6236d512801674153944fc
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

System: Remove 2nd setting of "Name"

Computer System Name was already set on line 1571.

Tested:
The top commit was built with this commit and validator passed.

Change-Id: I4669cb284880a597c068c6ed

System: Remove 2nd setting of "Name"

Computer System Name was already set on line 1571.

Tested:
The top commit was built with this commit and validator passed.

Change-Id: I4669cb284880a597c068c6edcbd1cedb0b77ace9
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

System: Remove odata.context

Redfish made odata.context optional (1.6.0 of DSP0266, Sept 2018).
Redfish has removed odata.context from example payloads in the
specification (1.7.0 of DSP0266), remov

System: Remove odata.context

Redfish made odata.context optional (1.6.0 of DSP0266, Sept 2018).
Redfish has removed odata.context from example payloads in the
specification (1.7.0 of DSP0266), removed it from the mockups,
and Redfish recommended not using.

The reason for making optional and removing from mockups/examples,
"no one could figure out how to use it and it did not add value".

Don't see value in it for our implementation.

Change-Id: Iee73d72d56237e8787e839ed06b979779c97d2f3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

diag-mode: return InTest if host is in diag mode

Per discussion with DMTF and clarification of InTest state within
http://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/Status
it was determi

diag-mode: return InTest if host is in diag mode

Per discussion with DMTF and clarification of InTest state within
http://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/Status
it was determined that this would represent the situation where the host
is collecting diagnostic data. This maps to the new DiagnosticMode
state added to the xyz.openbmc_project.State.Host.HostState namespace.

Tested:
Verified that Redfish API returned expected result when in
DiagnosticMode:
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "InTest"
},

Change-Id: I1c5deb5fdc251a5dcd4d1d01f4eedb6c507ded0a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Update to the new ResetType mapping

This updates Redfish ResetType with the new states added in the
document below:

ref: https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/28706

Tested:
Sent a PO

Update to the new ResetType mapping

This updates Redfish ResetType with the new states added in the
document below:

ref: https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/28706

Tested:
Sent a POST with the updated ResetType values and confirmed the correct
behavior:
ForceRestart: host restarted using Host.ForceWarmReboot
GracefulRestart: host restarted using Host.GracefulWarmReboot
PowerCycle: host restarted using Host.Reboot

Change-Id: I053919f2aaa709ba92685d67c1692bfc88b10d39
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add IndicatorLed to Chassis Schema

This adds the indicator property to Chassis Schema,
and moves the logic from systems.hpp to a common header
to share the code.

Tested: Passed the validator, was a

Add IndicatorLed to Chassis Schema

This adds the indicator property to Chassis Schema,
and moves the logic from systems.hpp to a common header
to share the code.

Tested: Passed the validator, was able to turn LED on

Change-Id: I79458a2a4656d7ddf2939bb9f56845eb6d9a27ca
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

ProcSummary: Use Nothrow

Exceptions are compiled out, and json.get throws, change
it to get_ptr.

Tested: no functional change

Change-Id: Ie2db7285b89b45b1fd61d8526561b772c85151b3
Signed-off-by: Ja

ProcSummary: Use Nothrow

Exceptions are compiled out, and json.get throws, change
it to get_ptr.

Tested: no functional change

Change-Id: Ie2db7285b89b45b1fd61d8526561b772c85151b3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Redfish: Implement ResetBios action

This action resets the BIOS attributes to default.

Tested:
GET test:
1. $ curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system
{
...
"B

Redfish: Implement ResetBios action

This action resets the BIOS attributes to default.

Tested:
GET test:
1. $ curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system
{
...
"Bios": {
"@odata.id": "/redfish/v1/Systems/system/Bios"
},
...
}
2. $ curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system/Bios
{
"@odata.id": "/redfish/v1/Systems/system/Bios",
"@odata.type": "#Bios.v1_1_0.Bios",
"Actions": {
"#Bios.ResetBios": {
"target": "/redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios"
}
},
"Description": "BIOS Configuration Service",
"Id": "BIOS",
"Name": "BIOS Configuration"
}

POST test:
1. Change gard list:
# ./gard list
No GARD entries to display
# ./gard create /Sys0/Node0/Proc1/EQ1/EX1/Core0
# ./gard list
ID | Error | Type | Path
-----------------------------------------------------------------------
00000001 | 00000000 | Manual | /Sys0/Node0/Proc1/EQ1/EX1/Core0
=======================================================================
2. Reset bios:
# curl -k -H "X-Auth-Token: $token" -X POST https://${bmc}/redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios
3. Check gard list again:
# ./gard list
No GARD entries to display

Validator tool test:
Counter({'pass': 3001, 'skipOptional': 2475, 'metadataNamespaces': 1605,
'passGet': 191, 'serviceNamespaces': 72, 'invalidPropertyValue': 10,
'passAction': 7, 'optionalAction': 6, 'warningPresent': 6, 'warnDeprecated':
2, 'unverifiedComplexAdditional': 1})
Validation has succeeded.

Signed-off-by: Carol Wang <wangkair@cn.ibm.com>
Change-Id: I0cba966bfde04566001b6df07ad15217f627c327

show more ...

Fix No Total Memory Size Issue

Total Memory in redfish is always 0, fix the problem.

Tested:
After DC cycle the system. TotalSystemMemoryGiB in Redfish system page should
not be zero.

"MemorySumma

Fix No Total Memory Size Issue

Total Memory in redfish is always 0, fix the problem.

Tested:
After DC cycle the system. TotalSystemMemoryGiB in Redfish system page should
not be zero.

"MemorySummary": {
"Status": {
"State": "Enabled"
},
"TotalSystemMemoryGiB": 16
},

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I89ad8ed1cf5f9ca9589db444740167645dab9a6e

show more ...

Storage: Add Storage Controller

This adds support for Storage Controllers.

Tested: Validator passed

{
"@odata.context": "/redfish/v1/$metadata#Storage.Storage",
"@odata.id": "/redfish/v1/S

Storage: Add Storage Controller

This adds support for Storage Controllers.

Tested: Validator passed

{
"@odata.context": "/redfish/v1/$metadata#Storage.Storage",
"@odata.id": "/redfish/v1/Systems/system/Storage/1",
"@odata.type": "#Storage.v1_7_1.Storage",
"Drives": [
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_1"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_2"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_3"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_4"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_5"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_6"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_7"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive_8"
}
],
"Drives@odata.count": 8,
"Id": "1",
"Name": "Storage Controller",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
},
"StorageControllers": [
{
"@odata.context": "/redfish/v1/$metadata#Storage.StorageController",
"@odata.id": "/redfish/v1/Systems/system/Storage/1#/StorageControllers/0",
"@odata.type": "#Storage.v1_7_0.StorageController",
"Manufacturer": "$BOARD_MANUFACTURER",
"MemberId": "HSBP_1",
"Model": "$BOARD_PRODUCT_NAME",
"Name": "HSBP_1",
"PartNumber": "$BOARD_PART_NUMBER",
"SerialNumber": "$BOARD_SERIAL_NUMBER",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
}
}
]
}

Change-Id: I9d956343daa74ddfa912e3cbe0d38b0e42a4859f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix for IndicatorLED if blinking object not found

Currently some systems doesn't have enclosure_identity_blink
object for supporting blinking feature which are leading
to systems/system uri failing

Fix for IndicatorLED if blinking object not found

Currently some systems doesn't have enclosure_identity_blink
object for supporting blinking feature which are leading
to systems/system uri failing with 500 error.
Corrected the code to make enclosure_identity_blink object
get/set as optional.

Tested:
Tested IndicatorLED for all 3 cases and it works fine.
Simulated case to not have enclosure_identity_blink object
and teste all 3 InidicatorLED value set and get.
Ran the redfish validator with success results.

Change-Id: I310fb71269aae6d36ea025556ad3b1d87b0acb39
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

IndicatorLED get and set support

Updated get and set of IndicatorLED state
to use the correct d-bus service. Added code to
support LED blinking state.

Tested:
- Using PATCH method on below URI, ch

IndicatorLED get and set support

Updated get and set of IndicatorLED state
to use the correct d-bus service. Added code to
support LED blinking state.

Tested:
- Using PATCH method on below URI, changed "IndicatorLed"
to multiple states like 'Lit', 'Off', 'Blinking' and
verified correct response using GET method.
URI: /redfish/v1/Systems/system
- Ran the Redfish validator and no new issues observed.

Change-Id: I40f103b1cb0190c48605f60bfca39ba1d20a28ec
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Add Storage Health & Update Systems Health

This adds health to storage based on drive inventory and
updates systems health to include drives.

This also fixes properties that are manditory in drives

Add Storage Health & Update Systems Health

This adds health to storage based on drive inventory and
updates systems health to include drives.

This also fixes properties that are manditory in drives to
make this patch pass the validator.

Tested:

Validator Passed.

Failed a drive and saw:

{
"@odata.context": "/redfish/v1/$metadata#Storage.Storage",
"@odata.id": "/redfish/v1/Systems/system/Storage/1",
"@odata.type": "#Storage.v1_7_1.Storage",
"Drives": [
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_1"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_2"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_3"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_4"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_5"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_6"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_7"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_8"
}
],
"Drives@odata.count": 8,
"Id": "1",
"Name": "Storage Controller",
"Status": {
"Health": "Warning",
"HealthRollup": "Warning",
"State": "Enabled"
}
}

And In systems:

"Status": {
"Health": "Warning",
"HealthRollup": "Warning",
"State": "Enabled"
},

Change-Id: I7abf042ac51b1fbe9e4ee0b72876e9be96e60b7c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Redfish: Fix System IndicatorLED

xyz.openbmc_project.LED.Controller.identify does not exist in all systems.
Checking LED group enclosure_identify is generic and is expected to
indicate the Indicator

Redfish: Fix System IndicatorLED

xyz.openbmc_project.LED.Controller.identify does not exist in all systems.
Checking LED group enclosure_identify is generic and is expected to
indicate the Indicator LED state.
Remove LED physical identify related code to make it generic for all systems.

Tested:
$curl -k -H "X-Auth-Token: $token" -d "{\"data\": true}" -X PUT https://${bmc}/xyz/openbmc_project/led/groups/enclosure_identify/attr/Asserted
{
"data": null,
"message": "200 OK",
"status": "ok"
}
$ curl -k -H "X-Auth-Token: $token" X GET https://${bmc}/redfish/v1/Systems/system
{
"@odata.context": "/redfish/v1/$metadata#ComputerSystem.ComputerSystem",
"@odata.id": "/redfish/v1/Systems/system",
"@odata.type": "#ComputerSystem.v1_6_0.ComputerSystem",
"Actions": {
"#ComputerSystem.Reset": {
"ResetType@Redfish.AllowableValues": [
"On",
"ForceOff",
"ForceOn",
"ForceRestart",
"GracefulRestart",
"GracefulShutdown",
"PowerCycle",
"Nmi"
],
"target": "/redfish/v1/Systems/system/Actions/ComputerSystem.Reset"
}
},
"AssetTag": "",
"BiosVersion": "open-power-witherspoon-v2.3-rc2-390-g8db7a9e",
"Boot": {
"BootSourceOverrideEnabled": "Disabled",
"BootSourceOverrideMode": "Legacy",
"BootSourceOverrideTarget": "None",
"BootSourceOverrideTarget@Redfish.AllowableValues": [
"None",
"Pxe",
"Hdd",
"Cd",
"Diags",
"BiosSetup",
"Usb"
]
},
"Description": "Computer System",
"Id": "1069A8T ",
"IndicatorLED": "On",
"Links": {
"Chassis": [
{
"@odata.id": "/redfish/v1/Chassis/chassis"
}
],
"ManagedBy": [
{
"@odata.id": "/redfish/v1/Managers/bmc"
}
]
},
"LogServices": {
"@odata.id": "/redfish/v1/Systems/system/LogServices"
},
"Manufacturer": "",
"Memory": {
"@odata.id": "/redfish/v1/Systems/system/Memory"
},
"MemorySummary": {
"Status": {
"State": "Enabled"
},
"TotalSystemMemoryGiB": 0
},
"Model": "8286-42B ",
"Name": "system",
"PartNumber": "",
"PowerState": "Off",
"ProcessorSummary": {
"Count": 2,
"Status": {
"State": "Enabled"
}
},
"Processors": {
"@odata.id": "/redfish/v1/Systems/system/Processors"
},
"SerialNumber": "1069A8T ",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Disabled"
},
"SystemType": "Physical"
}

The result of redfish Validator tool:
Counter Optional': 2480, 'metadataNamespaces': 1602, 'passGet': 191, 'serviceNamespaces': 69, 'invalidPropertyValue': 10, 'warningPresent': 6, 'passAction': 6, 'optionalAction': 5, 'warnDeprecated': 2, 'unverifiedComplexAdditional': 1})
Validation has succeeded.

Change-Id: Ie4b7931404fd072df4c6f215656436f07d3e4cde
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

Added OemComputerSystems and properties for provisioning

- Added OemComputerSystems Schema for provisioning properties
- Added "ProvisioningStatus" Oem property with EnumType
1) NotProvisioned

Added OemComputerSystems and properties for provisioning

- Added OemComputerSystems Schema for provisioning properties
- Added "ProvisioningStatus" Oem property with EnumType
1) NotProvisioned
2) ProvisionedButNotLocked
3) ProvisionedAndLocked

Intel secures platform firmware components using Intel PFR mechanism.
This may differ for other Oem's(non-intel platforms) but the properties
like Provisioned, Locked states should be of generic as per NIST SP
800-193. Added build time flag to enable/disable PFR supported platforms.

Tested:
- By default provisioning feature is OFF, using GET method on below URI
verified Oem Property and observed no such property. This is default
behaviour on upstream.

URI: /redfish/v1/Systems/system
Response: No "Oem" property.

- Enabled provisioning feature in Intel platforms and Verified using Systems
URI. Ran the redfish validator tool and no new issues found due to this
change.
URI: /redfish/v1/Systems/system
RESPONSE:
.....

"Oem": {
"OpenBmc": {
"FirmwareProvisioning": {
"ProvisioningStatus": "NotProvisioned"
}
}
}
.....

Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
Change-Id: I674e6075263f4fa2962637d3add47393a1ff0c0b

show more ...

Update to Chassis 1.10 and add PCIeDeviceCollection support

v1.10 of Chassis adds a PCIeDeviceCollection. This change adds
support for the PCIeDeviceCollection and references it from
Chassis.

Test

Update to Chassis 1.10 and add PCIeDeviceCollection support

v1.10 of Chassis adds a PCIeDeviceCollection. This change adds
support for the PCIeDeviceCollection and references it from
Chassis.

Tested:
Passed the Redfish Service Validator.

Change-Id: If3bb75f4fa90a9df4a2a94a7c7e0bcaf37673723
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Support PATCH for HostWatchDogTimer in redfish

This commit adds support for SET DBUS properties "Enabled"
and "ExpireAction" for WatchDogTimer in the Redfish ComputerSystems schema.

FunctionEnabled

Support PATCH for HostWatchDogTimer in redfish

This commit adds support for SET DBUS properties "Enabled"
and "ExpireAction" for WatchDogTimer in the Redfish ComputerSystems schema.

FunctionEnabled values can be false/true .
TimeoutAction values can be "None","PowerCycle","PowerDown","ResetSystem".

Tested:
Modify the watchdog properties:
curl --noproxy $BMCIP -k -H "Content-Type: application/json" -X PATCH \
https://root:0penBmc@$BMCIP/redfish/v1/Systems/system -d \
'{"WatchdogTimer":{"FunctionEnabled": false,"TimeoutAction": "PowerCycle"}}'

Check them:
curl --noproxy $BMCIP -k -H "Content-Type: application/json" -X GET \
https://root:0penBmc@$BMCIP/redfish/v1/Systems/system
ipmitool mc watchdog get

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ie41232a56b3d0a62be76ae27d6ded8920f7b9407

show more ...

Add HostWatchdogTimer attribute in redfish

Add HostWatchdogTimer attribute in redfish

Based on redfish spec, add HostWatchdogTimer property in
redfish/v1/Systems/system.

This object describes the

Add HostWatchdogTimer attribute in redfish

Add HostWatchdogTimer attribute in redfish

Based on redfish spec, add HostWatchdogTimer property in
redfish/v1/Systems/system.

This object describes the Host Watchdog Timer functionality,
including FunctionEnabled, Status and TimeoutActionproperties:
"HostWatchdogTimer": {
"FunctionEnabled": false,
"Status": {
"State": "Enabled"
},
"TimeoutAction": "None"
}

Tested:
Validator checking for HostWatchdogTimer in below test cases:
Set different timeout actions reset|poweroff|cycle|none:
ipmitool mc watchdog set action=reset timeout=1000 int=msg use=oem
Start watchdog: ipmitool mc watchdog reset

ComputerSystem.v1_5_0.ComputerSystem:HostWatchdogTimer
value: OrderedDict([('FunctionEnabled', False),
('Status', OrderedDict([('State', 'Enabled')])),
('TimeoutAction', 'None')]) <class 'collections.OrderedDict'>
has Type: ComputerSystem.v1_5_0.WatchdogTimer complex
is Optional
***going into Complex
ComputerSystem.v1_5_0.WatchdogTimer:FunctionEnabled
value: False <class 'bool'>
has Type: Edm.Boolean Edm.Boolean
Mandatory Test: OK
permission OData.Permission/ReadWrite
Success
ComputerSystem.v1_5_0.WatchdogTimer:WarningAction
value: n/a <class 'str'>
has Type: ComputerSystem.v1_5_0.WatchdogWarningActions enum
is Optional
prop Does not exist, skip...
ComputerSystem.v1_5_0.WatchdogTimer:TimeoutAction
value: None <class 'str'>
has Type: ComputerSystem.v1_5_0.WatchdogTimeoutActions enum
Mandatory Test: OK
permission OData.Permission/ReadWrite
Success
ComputerSystem.v1_5_0.WatchdogTimer:Status
value: OrderedDict([('State', 'Enabled')])
<class 'collections.OrderedDict'>
has Type: Resource.Status complex
is Optional
***going into Complex
Resource.Status:State
value: Enabled <class 'str'>
has Type: Resource.State enum
is Optional
permission OData.Permission/Read
Success

HostWatchdogTimer.FunctionEnabled PASS
HostWatchdogTimer.WarningAction Optional
HostWatchdogTimer.TimeoutAction PASS
HostWatchdogTimer.Status complex
HostWatchdogTimer.Status.State PASS

Watchdog service is stopped, no such property in redfish

Change-Id: I883e4b739a3fe525080ed486d2ca8e461fddf212
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

Add Health to Memory and Processor Summary

These fields were missing Health. Add health objects
to get the health associated with these items. Also update
the health object to be able to add more th

Add Health to Memory and Processor Summary

These fields were missing Health. Add health objects
to get the health associated with these items. Also update
the health object to be able to add more than the 'main'
health for a url, by allowing passing a json reference.
Also, add a 'children' vector of more shared_ptr<HealthPopulate>
so we don't double up on d-bus calls.

Tested:

"MemorySummary": {
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Disabled"
},
"TotalSystemMemoryGiB": 0
},
"Model": "S2600WFT",
"Name": "system",
"PartNumber": "..........",
"PowerState": "On",
"ProcessorSummary": {
"Count": 2,
"Model": "Intel Xeon processor",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
}
},

Change-Id: I06f802da93a44cfbac40b63d507e3b9faf0c999a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Storage Schema

This takes the original commit below and updates it so that it
passes the validatior, and provides the Status attribute in
redfish when appropriate.

Tested: Passed the validator

Add Storage Schema

This takes the original commit below and updates it so that it
passes the validatior, and provides the Status attribute in
redfish when appropriate.

Tested: Passed the validator

{
"@odata.context": "/redfish/v1/$metadata#Drive.Drive",
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drive/Drive_2",
"@odata.type": "#Drive.v1_2_0.Drive",
"Id": "Drive_2",
"Manufacturer": "INTEL",
"Model": "P4800X",
"Name": "Drive_2",
"PartNumber": "INTEL SSDPE21K375GA",
"SerialNumber": "PHKE722600NL375AGN",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
}
}

Original Commit Message:
-------------------------------------------------------------------

Add Storage Schema for NVMe on Redfish

This provides an implementation for the Get methods for the Storage
schemas using following classes :
- StorageCollection
- Storage

Tested:
- Ran Redfish Service Validator to verify no issues are reported.
- Tested that the NVMe drives in the system show up and proper fields
are populated with appropriate data.
- Tested with no drives present. Made sure the Storage interface shows
no drives and Drive interface returns error message.

Change-Id: Id0306ea413ac16a993110bb1a36cd95d939cff71
Signed-off-by: Nikhil Potade <nikhil.potade@linux.intel.com>
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...