#
717794d5
|
| 18-Oct-2019 |
AppaRao Puli <apparao.puli@linux.intel.com> |
Minor fix: Typo correction
Typo correction: 'refish' to "redfish"
Tested: Checked chassis URI and observed correct spelling.
Change-Id: Ic09ab11acd47fdf45fadc485df9c1fd03c0ee4fb Signed-off-by: App
Minor fix: Typo correction
Typo correction: 'refish' to "redfish"
Tested: Checked chassis URI and observed correct spelling.
Change-Id: Ic09ab11acd47fdf45fadc485df9c1fd03c0ee4fb Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
#
271584ab
|
| 09-Jul-2019 |
Ed Tanous <ed.tanous@intel.com> |
Fix a bunch of warnings
using the list of warnings from here: https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100
Seems lik
Fix a bunch of warnings
using the list of warnings from here: https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100
Seems like a good place to start, and would improve things a bit type-wise. This patchset attempts to correct all the issues in one shot.
Tested: It builds. Will test various subsystems that have been touched
Signed-off-by: Ed Tanous <ed.tanous@intel.com> Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e
show more ...
|
#
3929aca1
|
| 19-Jul-2019 |
Anthony Wilson <wilsonan@us.ibm.com> |
bmcweb: Add Threshold properties to Sensors
Added the Sensor Threshold properties: UpperCritical LowerCritical UpperCaution LowerCaution
Sample Output: curl -k -H "X-Auth-Token: $bm
bmcweb: Add Threshold properties to Sensors
Added the Sensor Threshold properties: UpperCritical LowerCritical UpperCaution LowerCaution
Sample Output: curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Chassis/chassis/Sensors/p1_vdd_current { "@odata.context": "/redfish/v1/$metadata#Sensor.Sensor", "@odata.id": "/redfish/v1/Chassis/chassis/Sensors/p1_vdd_current", "@odata.type": "#Sensor.v1_0_0.Sensor", "Id": "p1_vdd_current", "Name": "p1 vdd current", "Reading": 0.0, "ReadingRangeMax": 0.0, "ReadingRangeMin": 0.0, "ReadingUnits": "Amperes", "Status": { "Health": "Critical", "State": "Enabled" }, "Thresholds": { "LowerCaution": { "Reading": 0.0 }, "LowerCritical": { "Reading": 0.0 }, "UpperCaution": { "Reading": 320.0 }, "UpperCritical": { "Reading": 360.0 } } }
Change-Id: Ia76ff1308653ece90830a06333611960da43cb57 Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com> Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
#
95a3ecad
|
| 11-Jun-2019 |
Anthony Wilson <wilsonan@us.ibm.com> |
bmcweb: Implement SensorCollection
Add collection of all power and current sensors.
Testing: Verified SensorCollection and Sensor output on a Witherspoon system. Verified no error
bmcweb: Implement SensorCollection
Add collection of all power and current sensors.
Testing: Verified SensorCollection and Sensor output on a Witherspoon system. Verified no errors from RedfishServiceValidator.
Change-Id: Icfdc14d738bf037d5d599a3c6fc0be5ea0919929 Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>
show more ...
|
#
adc4f0db
|
| 24-Jul-2019 |
Shawn McCarney <shawnmm@us.ibm.com> |
Redfish: Move power supplies to Power schema
Made the following enhancements related to power supplies in Redfish: * Moved power supplies from Chassis schema to Power schema * Added support for mult
Redfish: Move power supplies to Power schema
Made the following enhancements related to power supplies in Redfish: * Moved power supplies from Chassis schema to Power schema * Added support for multiple power supplies within one chassis * Added support for multiple sensors associated with one power supply * Set power supply Name and MemberId to inventory item name (like powersupply0) rather than sensor name (like ps0_input_power). * Set power supply VPD fields like Manufacturer and SerialNumber
Also improved support for power sensors that are not related to power supplies, such as VRM sensors. These sensors are no longer treated as power supplies, and they will not be included in the Power schema output. They should instead be included in the SensorCollection output when that support is completed.
Uses an ObjectMapper association named "inventory" to find the power supply inventory item associated with a power sensor. For example:
/xyz/openbmc_project/sensors/power/ps0_input_power/inventory -> /xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0
See https://github.com/openbmc/docs/blob/master/sensor-architecture.md for more information on associations between sensors and low-level hardware items.
Test Plan: https://gist.github.com/smccarney/43b2fae304575302af61332a71280d74
Tested: Verified Power and Thermal output on a Witherspoon system. Tested with power sensors that were/were not associated with power supplies. Verified power supply properties in Power output. Verified that power supplies are no longer returned in Chassis collection output. Ran Redfish Service Validator.
Change-Id: I50db389b5df011bfb561d31aafb33cc4bf7fcde6 Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
show more ...
|
#
7ab06f49
|
| 02-Jul-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Move PowerLimit to correct location
See the following Redfish Validator errors and warning: /redfish/v1/Chassis/chassis/Power ERROR - PowerLimit not defined in schema Power.v1_5_2 (check version, sp
Move PowerLimit to correct location
See the following Redfish Validator errors and warning: /redfish/v1/Chassis/chassis/Power ERROR - PowerLimit not defined in schema Power.v1_5_2 (check version, spelling and casing)
/redfish/v1/Chassis/chassis/Power#/PowerControl/ ERROR - Decoded object no longer a dictionary /redfish/v1/Chassis/chassis/Power ERROR - @odata.id of ReferenceableMember does not properly resolve: /redfish/v1/Chassis/chassis/Power#/PowerControl/
WARNING - No @odata.type present, assuming highest type Power.v1_0_0.PowerControl Power.v1_4_0.PowerControl
If you look at the specification/mockups, PowerLimit is under PowerControl.
From the https://redfish.dmtf.org/redfish/mockups/v1/893 mockup: PowerControl": [ { "@odata.id": "/redfish/v1/Chassis/1U/Power#/PowerControl/0", "MemberId": "0", ... "PowerAvailableWatts": 0, "PowerCapacityWatts": 800, ... "PowerLimit": { "LimitInWatts": 500, "LimitException": "LogEventOnly", "CorrectionInMs": 50 } , ... } ],
Added an odata.type and fixed the odata.id for PowerControl.
Put all power control sensors under the same PowerControl like we do for PowerSupplies.
Tested: No longer see the errors.
If no total_power (happens when a Open Power system is off): curl -k https://${bmc}/redfish/v1/Chassis/chassis/Power ... "PowerControl": [ { "@odata.id": "/redfish/v1/Chassis/chassis/Power#/PowerControl/0", "@odata.type": "#Power.v1_0_0.PowerControl", "MemberId": "0", "Name": "Chassis Power Control", "PowerLimit": { "LimitInWatts": null } } ], "Redundancy": [], ...
curl -k https://${bmc}/redfish/v1/Chassis/chassis/Power/ { "PowerControl": [ { "@odata.id": "/redfish/v1/Chassis/chassis/Power#/PowerControl/0", "@odata.type": "#Power.v1_0_0.PowerControl", "MemberId": "0", "Name": "Chassis Power Control", "PowerConsumedWatts": 232.0, "PowerLimit": { "LimitInWatts": null }, "Status": { "Health": "OK", "State": "Enabled"
Change-Id: I8ca47bd6c7dedf5d0685886e2e45e6f964f69060 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
85e1424f
|
| 27-Jun-2019 |
Ed Tanous <ed.tanous@intel.com> |
Fix initialier_list issues
This is a warning that the clang analyser seems to pop up with. For whatever reason, GCC is just fine with it.
Tested: Not yet tested.
Change-Id: I5d665e23011806f51d1ef
Fix initialier_list issues
This is a warning that the clang analyser seems to pop up with. For whatever reason, GCC is just fine with it.
Tested: Not yet tested.
Change-Id: I5d665e23011806f51d1ef4c5b1e8b887bdb456eb Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
#
02e92e32
|
| 26-Jun-2019 |
James Feist <james.feist@linux.intel.com> |
Fix redudancy for association change
s/inventory/chassis according to https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976
Tested: Redundancy still worked with according change in sensor repo
Fix redudancy for association change
s/inventory/chassis according to https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976
Tested: Redundancy still worked with according change in sensor repo
Change-Id: Id0e517e09908a44fa983a6934b8c4c39d5db4dd6 Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
#
8fb49dd6
|
| 12-Jun-2019 |
Shawn McCarney <shawnmm@us.ibm.com> |
Redfish: Check inventory item for sensor status
Added support to find the inventory item (if any) associated with a sensor. Checks whether the inventory item is not present or not functional. If s
Redfish: Check inventory item for sensor status
Added support to find the inventory item (if any) associated with a sensor. Checks whether the inventory item is not present or not functional. If so, updates the sensor status.
Uses the standard D-Bus Inventory.Item and OperationalStatus interfaces to obtain the Present and Functional properties for the inventory item.
These checks are in addition to the sensor threshold checks. The two approaches are complementary. Some functional problems and missing hardware are not detectable via thresholds depending on how the system is implemented.
Uses an ObjectMapper association named "inventory" to find the inventory item associated with a sensor. For example:
/xyz/openbmc_project/sensors/power/ps0_input_power/inventory -> /xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply0
This support could be used in the future to obtain VPD data such as Model and PartNumber for PowerSupply sensors. VPD data is associated with the inventory item on D-Bus.
Also changed the association name used to find all sensors in a chassis from "sensors" to "all_sensors".
Test Plan: https://gist.github.com/smccarney/accc500b58fed80b711c65520cc7aafc
Tested: Verified Power and Thermal output on a Witherspoon system. Tested where inventory item associated with sensor was present/not present and function/not functional. Ran Redfish Service Validator.
Change-Id: Ibcdc515eb6b52ef43f05f98f36b8f0849fe1f25b Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
show more ...
|
#
34dd179e
|
| 17-May-2019 |
James Feist <james.feist@linux.intel.com> |
Add sensor health support
Read through the thresolds and determine if any are crossed. If so, change the status of the sensor.
Tested: Used sensor override to modify a sensor value, asserting the t
Add sensor health support
Read through the thresolds and determine if any are crossed. If so, change the status of the sensor.
Tested: Used sensor override to modify a sensor value, asserting the threshold.
Change-Id: Id56e036449ca019a5e9563df68af0f590c693045 Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
#
0a86febd
|
| 27-May-2019 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
bmcweb: Fix sensor name identification method
Sensor name was calculated based on 5th elemennt is not applicable any more. Get the last token in the path, which is the sensor name, which is used as
bmcweb: Fix sensor name identification method
Sensor name was calculated based on 5th elemennt is not applicable any more. Get the last token in the path, which is the sensor name, which is used as member_id.
Tested: 1. Verified the PATCH method for thermal & power overriding, temperatures, fans & voltages. Overriding works as expected.
Change-Id: I08291171496a979f120a57ac0802733007e11871 Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
show more ...
|
#
028f7ebc
|
| 17-May-2019 |
Eddie James <eajames@linux.ibm.com> |
Add basic PowerControl and PowerLimit properties
Add code in the power-specific response handler to fetch the Power Limit value for the chassis that implements the Chassis inventory item. Add a spec
Add basic PowerControl and PowerLimit properties
Add code in the power-specific response handler to fetch the Power Limit value for the chassis that implements the Chassis inventory item. Add a special case to the generic sensor handling code to place the total_power value into the PowerControl PowerConsumedWatts field.
curl -k https://${bmc}/redfish/v1/Chassis/chassis/Power { "@odata.context": "/redfish/v1/$metadata#Power.Power", "@odata.id": "/redfish/v1/Chassis/chassis/Power", "@odata.type": "#Power.v1_5_2.Power", "Id": "Power", "Name": "Power", "PowerControl": [ { "@odata.id": "/redfish/v1/Chassis/chassis/Power#/PowerControl/", "MemberId": "total_power", "Name": "total power", "PowerConsumedWatts": 269.0, "Status": { "Health": "OK", "State": "Enabled" } } ], "PowerLimit": [ { "LimitInWatts": null } ],
Signed-off-by: Eddie James <eajames@linux.ibm.com> Change-Id: I447de59fb44a4ecbe7b47610d915ac22aef90250
show more ...
|
#
4f9a2130
|
| 04-Mar-2019 |
Jennifer Lee <jennifer1.lee@intel.com> |
[Redfish] Add OCP required properties for Chassis
- Thermal - Redundancy - Fans
Tested: GET /redfish/v1/Chassis/<chassis id>/Thermal HTTP/1.1 Response: { "@odata.context": "/redfish/v1/$metad
[Redfish] Add OCP required properties for Chassis
- Thermal - Redundancy - Fans
Tested: GET /redfish/v1/Chassis/<chassis id>/Thermal HTTP/1.1 Response: { "@odata.context": "/redfish/v1/$metadata#Thermal.Thermal", "@odata.id": "/redfish/v1/Chassis/<chassis id>/Thermal", "@odata.type": "#Thermal.v1_4_0.Thermal", "Fans": [], "Id": "Thermal", "Name": "Thermal", "Redundancy": [], "Temperatures": [ { "@odata.id": "/redfish/v1/Chassis/<chassis id>/Thermal#/Temperatures/0", "@odata.type": "#Thermal.v1_3_0.Temperature", "LowerThresholdCritical": 0, "LowerThresholdNonCritical": 5, "MaxReadingRangeTemp": 127, "MemberId": "BMC_Temp", "MinReadingRangeTemp": -128, "Name": "BMC_Temp", "ReadingCelsius": 34.6870002746582, "Status": { "Health": "OK", "State": "Enabled" }, "UpperThresholdCritical": 115, "UpperThresholdNonCritical": 110 }, ... }
Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com> Change-Id: I8fe41e698ef55b02779b04468dee51ebe5561762
show more ...
|
#
e742b6cc
|
| 03-May-2019 |
Ed Tanous <ed.tanous@intel.com> |
Redfish: Make sensor names more friendly
The primary goal of this patchset is to make sensor names more approachable, in the same way that IPMI does. This replaces the underscores from the sensor p
Redfish: Make sensor names more friendly
The primary goal of this patchset is to make sensor names more approachable, in the same way that IPMI does. This replaces the underscores from the sensor path name with spaces.
Tested: GET /redfish/v1/Chassis/Solum_1300W_PSU_1/Power Observed sensor "Name" property changed from PSU1_Input_Power to PSU1 Input Power
Service validator shows no issues on Thermal or Power Nodes.
Signed-off-by: Ed Tanous <ed.tanous@intel.com> Change-Id: I0862f180700502d401cf5a0746a639db5133e631
show more ...
|
#
26f03899
|
| 03-May-2019 |
Shawn McCarney <shawnmm@us.ibm.com> |
Redfish: Remove BMCWEB_ENABLE_REDFISH_ONE_CHASSIS
Removed the BMCWEB_ENABLE_REDFISH_ONE_CHASSIS #define. The new support for finding chassis sensors via associations is now used on all systems.
Te
Redfish: Remove BMCWEB_ENABLE_REDFISH_ONE_CHASSIS
Removed the BMCWEB_ENABLE_REDFISH_ONE_CHASSIS #define. The new support for finding chassis sensors via associations is now used on all systems.
Test Plan: https://gist.github.com/smccarney/f5b4783d8cf41a486ceff9b941b1ba9a
Tested: Verified the Chassis, Power, and Thermal output was valid on a Witherspoon system. Verified sensor associations on Witherspoon work with bmcweb implementation. Ran Redfish Service Validator.
Change-Id: I975f79da2c9de63e4ddd155d39ea872ca9fbffa9 Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
show more ...
|
#
49c53ac9
|
| 02-May-2019 |
Johnathan Mantey <johnathanx.mantey@intel.com> |
Acquire chassis sensors using the sensor association DBus item
Each entry in the Chassis Collection has, or will have, a sensors DBus item that lists the sensors that Chassis node contains. This ch
Acquire chassis sensors using the sensor association DBus item
Each entry in the Chassis Collection has, or will have, a sensors DBus item that lists the sensors that Chassis node contains. This change queries that DBus entry, and uses the information to collect the Thermal or Power sensor information.
Tested: GET https://10.243.48.59/redfish/v1/Chassis/WP_Baseboard GET https://10.243.48.59/redfish/v1/Chassis/WP_Baseboard/Power GET https://10.243.48.59/redfish/v1/Chassis/WP_Baseboard/Thermal
On 2 representative systems, one with a chassis, and one without. Observed correct behavior for both.
Ran Redfish service validator. Observed no errors in Chassis, Thermal, Power, or ChassisCollection schemas.
Change-Id: I01fcb3707396e2e33345bf125d8ae95170088a2a Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com> Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
#
e278c18f
|
| 13-Mar-2019 |
Ed Tanous <ed.tanous@intel.com> |
update ASIO interfaces
This commit does 2 things.
1. Upgrades and prepares bmcweb for boost 1.70. 2. Allows us to compile with BOOST_AIO_NO_DEPRECATED
Tested: Compiled against 1.69 and 1.70. All
update ASIO interfaces
This commit does 2 things.
1. Upgrades and prepares bmcweb for boost 1.70. 2. Allows us to compile with BOOST_AIO_NO_DEPRECATED
Tested: Compiled against 1.69 and 1.70. All changes should be no-op.
Change-Id: I557ecd840fe2b88c0fa01978a1b666b40ccccca4 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
show more ...
|
#
b01bf299
|
| 25-Mar-2019 |
Ed Tanous <ed.tanous@intel.com> |
Revert "bmcweb: Fix a bunch of warnings"
This reverts commit 6ea007a2faec52ad62680015d2a3f00371a1e351.
Reason for revert: Reports of bmcweb seg faults.
Change-Id: I408f1bb29c2f8e427a6621cdaac8c31b
Revert "bmcweb: Fix a bunch of warnings"
This reverts commit 6ea007a2faec52ad62680015d2a3f00371a1e351.
Reason for revert: Reports of bmcweb seg faults.
Change-Id: I408f1bb29c2f8e427a6621cdaac8c31b847ebf06
show more ...
|
#
6ea007a2
|
| 14-Feb-2019 |
Ed Tanous <ed@tanous.net> |
bmcweb: Fix a bunch of warnings
bmcweb classically has not taken a strong opinion on warnings. With this commit, that policy is changing, and bmcweb will invoke the best warnings we are able to ena
bmcweb: Fix a bunch of warnings
bmcweb classically has not taken a strong opinion on warnings. With this commit, that policy is changing, and bmcweb will invoke the best warnings we are able to enable, and turn on -Werror for all builds.
This is intended to reduce the likelihood of hard-to-debug situations that the compiler coulve caught early on.
Change-Id: I57474410821e82666b3a108cfd0db7d070e8900a Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
#
8bd25ccd
|
| 15-Mar-2019 |
James Feist <james.feist@linux.intel.com> |
Add Redundancy to Thermal Schema
This looks for the FanRedundancy Interface https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/FanRedundancy.interface.yaml
Add Redundancy to Thermal Schema
This looks for the FanRedundancy Interface https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/FanRedundancy.interface.yaml
and an association to type inventory. Using these it adds Redundancy to the thermal schema.
Tested: Passes Redfish schema validator
Change-Id: Iffa32e445bd57234afeb5c682c9502c5daa227c1 Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
#
de629b6e
|
| 08-Mar-2019 |
Shawn McCarney <shawnmm@us.ibm.com> |
Redfish: Enhance and fix power/thermal sensors
Made the following enhancements for Redfish power/thermal sensors: * Now dynamically obtains the DBus object path to pass to GetManagedObjects() when
Redfish: Enhance and fix power/thermal sensors
Made the following enhancements for Redfish power/thermal sensors: * Now dynamically obtains the DBus object path to pass to GetManagedObjects() when getting sensor values. Was previously hard-coded to "/" which didn't work on some systems. * Added "fan_tach" to list of DBus sensor types returned when thermal sensors are requested. * Added support for one-chassis systems.
Made the following fixes: * Fixed @odata.id value when power sensors are requested. Previously returned "/redfish/v1/Chassis/chassis/Thermal". * Renamed "PowerSupply" to "PowerSupplies" to conform to schema. * Removed 6 properties that were being returned for PowerSupplies that were not in the schema. * Added check to make sure no sensors of the wrong type were being returned. Previously if the same connection (service) provided both power and thermal sensors, both types of sensors were always returned.
Test Plan: https://gist.github.com/smccarney/79186e8510ba5479e846f2592d44d059
Tested: Verified the URLs /redfish/v1/Chassis/<chassis>/Power and /redfish/v1/Chassis/<chassis>/Thermal return the correct sensor names and values on a Witherspoon system. Verified fixes listed above worked. Ran Redfish Service Validator.
Change-Id: I4bae615cb61fc436b3c0a9a5c4d6b4566a3ddaa6 Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
show more ...
|
#
f65af9e8
|
| 13-Feb-2019 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
Support for overriding multiple sensor
Support added for overriding multiple sensor, in single patch method. Can accept Thermal (Temperatures/Fans) and Power (Voltages) collections.
Unit-Test: 1. V
Support for overriding multiple sensor
Support added for overriding multiple sensor, in single patch method. Can accept Thermal (Temperatures/Fans) and Power (Voltages) collections.
Unit-Test: 1. Verified sensor values are getting updated by doing PATCH method to a known sensor. Verified the value got updated using ipmitool sensor list. 2. Verified negative cases of making PATCH call on invalid chasisId, Invalid MemberId etc.
Testedeby: Used Postman tool to issue the PATCH call to the 1. https://xx.xx.xx.xx/redfish/v1/Chassis/XXYYZZ/Thermal with content { "Temperatures": [ { "MemberId" : "SensorNameXX", "ReadingCelsius" : valueXX } ] "Fans": [ { "MemberId" : "SensorNameYY", "Reading" : valueYY } ] } 2. https://xx.xx.xx.xx/redfish/v1/Chassis/XXYYZZ/Power with content { "Voltages": [ { "MemberId" : "SensorNameXX", "ReadingVolts" : valueXX }, { "MemberId" : "SensorNameYY", "ReadingVolts" : valueYY } ] }
Change-Id: Ie30a7dff421f1a459dfe7bac262ae29e98754810 Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
show more ...
|
#
413961de
|
| 31-Jan-2019 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
Patch support for sensor overrride
Support added for overriding sensor, which can be used for validation / ad-hoc debugging. This provides option to make PATCH call to redfish/v1/<chassisId>/Thermal
Patch support for sensor overrride
Support added for overriding sensor, which can be used for validation / ad-hoc debugging. This provides option to make PATCH call to redfish/v1/<chassisId>/Thermal or power id. Based on schema, will accept Temperatures / Voltages collection with properties MemberId and ReadingCelsius / ReadingVolts.
TODO: 1. Need to make a dynamic way of enabling / disbaling this command.
Unit-Test: 1. Verified sensor values are getting updated by doing PATCH method to a known sensor. Verified the value got updated using ipmitool sensor list. 2. Verified negative cases of making PATCH call on invalid chasisId, Invalid MemberId etc.
Testedeby: Used Postman tool to issue the PATCH call to the 1. https://xx.xx.xx.xx/redfish/v1/Chassis/XXYYZZ/Thermal with content { "Temperatures": [ { "MemberId" : "SensorNameXX", "ReadingCelsius" : valueXX } ] } 2. https://xx.xx.xx.xx/redfish/v1/Chassis/XXYYZZ/Power with content { "Voltages": [ { "MemberId" : "SensorNameXX", "ReadingVolts" : valueXX } ] }
Change-Id: Idf2d891ac0d10b5d20f78c386232cae8a6896f1a Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
show more ...
|
#
43b761d0
|
| 13-Feb-2019 |
Ed Tanous <ed@tanous.net> |
bmcweb: fix compiler warnings
This patchset attempts to fix all compiler warnings in bmcweb owned files. There are 2 warnings left, both in sdbusplus, which will be resolved in a patchset there.
T
bmcweb: fix compiler warnings
This patchset attempts to fix all compiler warnings in bmcweb owned files. There are 2 warnings left, both in sdbusplus, which will be resolved in a patchset there.
Tested By: Recompiled, observed warning count went from 30, to zero.
Change-Id: Ife90207aa5773bc28faa8b04c732cafa5a56e4e4 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
#
abf2add6
|
| 22-Jan-2019 |
Ed Tanous <ed.tanous@intel.com> |
bmcweb: move variant usage to std namespace
Change-Id: I9d7069668f91f2ac72d2f4a440f63e0e85dd5269 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|