Refactor Processor object lookup

In order to reuse the D-Bus lookup logic for both GET and PATCH
requests, separate the GetSubTree call from the processing loop.
This way, we can have one common pla

Refactor Processor object lookup

In order to reuse the D-Bus lookup logic for both GET and PATCH
requests, separate the GetSubTree call from the processing loop.
This way, we can have one common place to determine if 404 Not Found
should be returned for any type of Processor request.

This also improves 404 handling by filtering out those objects which
don't implement Item.Cpu or Item.Accelerator. Previously it was possible
to request e.g. /redfish/v1/Systems/system/Processors/dimm0 and get back
some information about that DIMM. This change will ensure non-CPU items
return a 404.

Tested:
- All links in the ProcessorCollection return the same data that they
did before this change.
- Invalid Processor IDs (e.g. dimm0 from above) now return 404 error
message.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: I0f09ba1189b7a068c8c0ffe136d19e9587765d18

show more ...

Add additional Redfish Processor properties

This commit adds the following inventory properties for the
Processor resource in bmcweb:

a) LocationCode, a free form, implementation-defined string
to

Add additional Redfish Processor properties

This commit adds the following inventory properties for the
Processor resource in bmcweb:

a) LocationCode, a free form, implementation-defined string
to provide the location of the processor. This is needed so an
implementation can identify the processor via system diagrams.

b) SparePartNumber, also field-replaceable unit (FRU) Part
Number, is a part number that identifies the FRU for replacement
specifically ordering of a new part.

c) PartNumber, also called a Marketing Number, describes a
specific part within a specific system among a manufactures various
product lines. These numbers tell IT infrastructure technicians
exactly which parts are included in their servers, storage and
networking equipment.

These properties are essential to locate and replace the FRU.

Validator has been executed and no new error has been found.

Sample Output:
{
"@odata.id": "/redfish/v1/Systems/system/Processors/cpu0",
"@odata.type": "#Processor.v1_11_0.Processor",
"Id": "cpu0",
"Location": {
"PartLocation": {
"ServiceLabel": "Ufcs-P0-C15"
}
},
"Manufacturer": "",
"Model": "AB41",
"Name": "Processor",
"PartNumber": "2345678",
"ProcessorType": "CPU",
"SerialNumber": "YLAB41010000",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Absent"
}
}

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ifc0e13fd7eb94e86eade223608a1ecad2487ed37

show more ...

Add support for Redfish OperatingConfig resources

- Update Processor GET handler to look for a matching
CurrentOperatingConfig interface on D-Bus.
- Add OperatingConfig node and implement GET hand

Add support for Redfish OperatingConfig resources

- Update Processor GET handler to look for a matching
CurrentOperatingConfig interface on D-Bus.
- Add OperatingConfig node and implement GET handler to look for
matching OperatingConfig interface on D-Bus.
- Add OperatingConfigCollection node and implement GET handler to look
for all OperatingConfig interfaces on D-Bus under the given cpu.

Tested:
- Ran Redfish Service Validator and verified no errors or warnings on
Processor, OperatingConfig, and OperatingConfigCollection.
- Browsed OperatingConfig links and resources in browser, confirmed
nonexistent configs returned 404 and didn't crash bmcweb.
- Killed D-Bus provider service and verified bmcweb didn't crash and
still served Processor as before, and passed service validator.

Change-Id: Iab94b7fd49a9462cb0eca6f8ea0754f5fb241053
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

Refactor getProcessorData

- Move list of interfaces to search for next to the result callback, so
that it's easier to catch mismatches. And add 1 missing interface to
GetSubTree request.
- Use v

Refactor getProcessorData

- Move list of interfaces to search for next to the result callback, so
that it's easier to catch mismatches. And add 1 missing interface to
GetSubTree request.
- Use vector instead of map for GetSubTree response
- Use structured bindings to make the loop variables easier to
understand.
- Reorganize logic to save an indent.

Tested: As part of child change Iab94b7fd49a9462cb0eca6f8ea0754f5fb241053

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Iccf76ca0ddf944b053ebcf904f872e7960f2b508

show more ...

Restore missing/broken Processor fields

Couple of properties taken from xyz.openbmc_project.Inventory.Item.Cpu
got accidentally broken by refactoring in 5fb91ba400e04828.

Tested:
Browsed to https:/

Restore missing/broken Processor fields

Couple of properties taken from xyz.openbmc_project.Inventory.Item.Cpu
got accidentally broken by refactoring in 5fb91ba400e04828.

Tested:
Browsed to https://<bmc>/redfish/v1/Systems/system/Processors/cpu0 and
verified that exactly the two properties were now added.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: I5e5c96b80e952d6eb58ea00b3f2ecb3f59a792e9

show more ...

Processors: Remove / at end of odata.id

Matches mockups and other places in code.

Tested:
curl -k https://$bmc/redfish/v1/Systems/system/Processors
{
"@odata.id": "/redfish/v1/Systems/system/Pro

Processors: Remove / at end of odata.id

Matches mockups and other places in code.

Tested:
curl -k https://$bmc/redfish/v1/Systems/system/Processors
{
"@odata.id": "/redfish/v1/Systems/system/Processors",
"@odata.type": "#ProcessorCollection.ProcessorCollection",
"Members": [
{
"@odata.id": "/redfish/v1/Systems/system/Processors/cpu0"
},
...

Change-Id: I828e49013e09b9f40e189fd736103595ddb19a42
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix up Function to Populate collection Members

Added Doxygen comments, renamed the funciton, renamed several
variables, and made more generic.

Tested: Top commit passes validator and resources look

Fix up Function to Populate collection Members

Added Doxygen comments, renamed the funciton, renamed several
variables, and made more generic.

Tested: Top commit passes validator and resources look good.
Change-Id: I9a13176b7f4c8611ae38c6563b0e119e0f66edf2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

cpudimm.hpp: Separate Memory and Processor functionality

To match other files move Redfish Memory classes and functions
to a separate memory.hpp file. This naming "memory" (after the Redfish
schemas

cpudimm.hpp: Separate Memory and Processor functionality

To match other files move Redfish Memory classes and functions
to a separate memory.hpp file. This naming "memory" (after the Redfish
schemas) matches other filenames. Do the same with Processor
classes and functions, moving to a separate processor.hpp.

cpudimm.hpp had grown to 1300+ lines. Makes development and review
easier.

Tested: Validator passes. Resources look the same.
Change-Id: I7e23ecaf9b4b69cc72aad6d94ad3a555ee76b28a
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...