Redfish(Ethernet): Don't init the vlanID and vlanEnable

These variables are of type std::optional,The values should be
filled by the readJSON function,as further decision to handle the
patch for the

Redfish(Ethernet): Don't init the vlanID and vlanEnable

These variables are of type std::optional,The values should be
filled by the readJSON function,as further decision to handle the
patch for the vlan is dependent on whether the value for vlanID and vlanEnable
is not null.

Due to this issue, control goes to handle the vlan patch and the
readJSON inside the handleVlanPatch doesn't find the values for
vlanID and vlanEnable so set the resp result to forbidden.

After that if any other readJSON would be called it would return failure
and due to that no other PATCH operation on the ipv4Address can be
completed.

Change-Id: I3ebab18ae4adfa7c871ecab862a2865dc14f154d
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...

bmcweb: move ethernet VLAN to readJson

This commit moves the various vlan interfaces to use the existing
std::vector based implementations, and not the existing implementations.

Change-Id: Id2503d5

bmcweb: move ethernet VLAN to readJson

This commit moves the various vlan interfaces to use the existing
std::vector based implementations, and not the existing implementations.

Change-Id: Id2503d5e2f1503b61ec7dbdb25098611382b24c5
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

bmcweb: fix compiler warnings

This patchset attempts to fix all compiler warnings in bmcweb owned
files. There are 2 warnings left, both in sdbusplus, which will be
resolved in a patchset there.

T

bmcweb: fix compiler warnings

This patchset attempts to fix all compiler warnings in bmcweb owned
files. There are 2 warnings left, both in sdbusplus, which will be
resolved in a patchset there.

Tested By:
Recompiled, observed warning count went from 30, to zero.

Change-Id: Ife90207aa5773bc28faa8b04c732cafa5a56e4e4
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

bmcweb: Implement single Redfish "system" endpoint

This commit changes the redfish behavior to move to a single, known name
under the /redfish/v1/Systems/system path. This is advantageous for a
lot

bmcweb: Implement single Redfish "system" endpoint

This commit changes the redfish behavior to move to a single, known name
under the /redfish/v1/Systems/system path. This is advantageous for a
lot of reasons.
1. Lots fewer dbus calls to determine the system name for every path.
This could be optimized in other ways, like checking the system name on
startup, but because redfish paths are not intended to be informative,
this patchset takes the opinion that less code is better.
2. Lots of lowered complexity, given that each endpoint underneath
/system doesn't need an individual "does this system exist, and is the
name right" check.
3. This makes it possible to correctly implement the "Links" property in
Chassis, which is required for the OCP base server profile

Tested By:
Very minimal testing done, but it seems to pass the validator.

Change-Id: Iea3cb5081b92a3843b6877decd009936de00561c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

bmcweb: move variant usage to std namespace

Change-Id: I9d7069668f91f2ac72d2f4a440f63e0e85dd5269
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Use the unpacking mechanisms for hostname

The ethernet interface previous hardcoded error handling patterns for
the interfaces shown. This commit moves it to the generic ReadJson
mechanisms for err

Use the unpacking mechanisms for hostname

The ethernet interface previous hardcoded error handling patterns for
the interfaces shown. This commit moves it to the generic ReadJson
mechanisms for error handling

Change-Id: I710188c808ee62c5797059d7ee8f9876bf872a11
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

bmcweb: Enable redfish unpacking of complex types

In certain cases, redfish wants to unpack specialized types that might
be more complex than just simple structs. This commit adds the ability
to un

bmcweb: Enable redfish unpacking of complex types

In certain cases, redfish wants to unpack specialized types that might
be more complex than just simple structs. This commit adds the ability
to unpack a nlohman json object directly, and moves the ethernet schema
over to the new api

Change-Id: Ib3c25e6c4d8f0a163647092adfb454355d329170
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

bmcweb: Move boost::optional to std::optional

This change is largely a sed replace, and gets us closer to standards
compliance.

Change-Id: Ie60437eff43de830ef19389344a55430dabd9d16
Signed-off-by: E

bmcweb: Move boost::optional to std::optional

This change is largely a sed replace, and gets us closer to standards
compliance.

Change-Id: Ie60437eff43de830ef19389344a55430dabd9d16
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Remove custom version of getPtr

Now that sdbusplus variant supports std::get_if, we can remove our
custom, mapbox namespaced implementation that does the same thing.

Change-Id: I854c473003e28e41dd4

Remove custom version of getPtr

Now that sdbusplus variant supports std::get_if, we can remove our
custom, mapbox namespaced implementation that does the same thing.

Change-Id: I854c473003e28e41dd45dba08ca683433f1c1774
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

bmcweb: Redfish away from json cache

In the original incarnation of bmcweb, route registration was done
automatically. This has proved to be a terrible idea, wraught with
corner cases and issues.

bmcweb: Redfish away from json cache

In the original incarnation of bmcweb, route registration was done
automatically. This has proved to be a terrible idea, wraught with
corner cases and issues.

The route registration is currently the only user of the
redfish::Node::json element. Unfortunately, as written, this structure
consumes a lot of memory that's duplicated and not very useful. From a
performance perspective, there is almost no difference between
rebuilding the structure for each GET request, and having the "cache"
that needs to be copied into the response and modified before it can be
useful.

In the programming tradeoffs for bmc, lower memory usage is more important
than latency, especially at these levels.

Change-Id: I785e8352123e5e886acf05cd59cb23648f93839d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simpl

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simplifies the interface by using a
string so there doesn't have to be a '/'. This allowed the
same property argument passed for the message to be used
for the property field path.

Tested: Sent an error with a property and verified that it is
correctly displayed.

Change-Id: I0571e2eee627cedf29d751588a4f1bceee66f084
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncRe

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: Icfdce2de763225f070e8dd61e591f296703f46bb
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Cleanups to ethernet schemas

Several rounds of cleanup to the ethernet interfaces. Changes involved:
1. Move schemas to std::shared_ptr for handling responses
2. Remove the use of the "providers" i

Cleanups to ethernet schemas

Several rounds of cleanup to the ethernet interfaces. Changes involved:
1. Move schemas to std::shared_ptr for handling responses
2. Remove the use of the "providers" interface. As there is currently
only one usage, the providers interface doesn't give us any flexibility.
3 Move the ethernet interfaces to flat_set, to allow better sorting
and lookup times.
4. Fix a number of "use after free" bugs with lambda callbacks that
were passing by reference instead of by value.

Change-Id: I3f8ffb10702563b25fda88155f1929b8d8e38bf5
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Implement redfish LogService

This commit implements an optional LogService endpoint for debugging
CPUs over Redish. It exposes both the ability to create a new log with
the LogImmediate action, as

Implement redfish LogService

This commit implements an optional LogService endpoint for debugging
CPUs over Redish. It exposes both the ability to create a new log with
the LogImmediate action, as well as to pull a stored log using the
LogCollection schema. This feature is disabled by default, and should
be enabled in the meta-x86 layer.

Change-Id: Ied1d5e263a0857e09cd9a24fddec9c11a4066cd2
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move to clang-format-6.0

This commit moves the codebase to the lastest clang-format file from
upstream, as well as clang-format-6.0.

Change-Id: Ice8313468097c0c42317fbb9e10ddf036e8cff4c
Signed-off-

Move to clang-format-6.0

This commit moves the codebase to the lastest clang-format file from
upstream, as well as clang-format-6.0.

Change-Id: Ice8313468097c0c42317fbb9e10ddf036e8cff4c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Last round of variable renames

A few patches were in flight when we did the great variable renaming.
This catches all the patches that have been merged since

Change-Id: Ie9642a4812b2a679ffa01ce540f

Last round of variable renames

A few patches were in flight when we did the great variable renaming.
This catches all the patches that have been merged since

Change-Id: Ie9642a4812b2a679ffa01ce540f5c4515a4c710b
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Clang-format cleanup

It looks like some of the code reviews in progress contain clang-format
fixes as well.

This squashes all of the clang-format fixes into a single commit, that
hopefully can go t

Clang-format cleanup

It looks like some of the code reviews in progress contain clang-format
fixes as well.

This squashes all of the clang-format fixes into a single commit, that
hopefully can go through the process a little faster, as it should only
be whitespace changes.

In the past, clang-formatting the naughty strings file proved
to return inconsistent results, and even formatted files would still be
detected as unformatted. Aparently the solution was to run
clang-format-5.0 approximately 20 times in a loop, until it decided on
a code layout that it was ok with iteration to iteration.

This is a bit of a corner case, so I don't think we need to get CI
running multiple runs in the future, and can just handle this on a case
by case basis. I'd be surprised if anyone else had this issue.

Change-Id: I57e2a03676bce20dc376fd9cea724732b2dc7010
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Fix merge conflict

Got a couple patches that collided in air, and now builds are broken.
This resolves the collision by moving the new patches forward to the
latest #defines

Change-Id: I1fe35d17a68

Fix merge conflict

Got a couple patches that collided in air, and now builds are broken.
This resolves the collision by moving the new patches forward to the
latest #defines

Change-Id: I1fe35d17a68c61ad90752ae73000e2579131bf5d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move over to upstream c++ style

This patchset moves bmcweb over to the upstream style naming
conventions for variables, classes, and functions, as well as imposes
the latest clang-format file.

This

Move over to upstream c++ style

This patchset moves bmcweb over to the upstream style naming
conventions for variables, classes, and functions, as well as imposes
the latest clang-format file.

This changeset was mostly built automatically by the included
.clang-tidy file, which has the ability to autoformat and auto rename
variables. At some point in the future I would like to see this in
greater use, but for now, we will impose it on bmcweb, and see how it
goes.

Tested: Code still compiles, and appears to run, although other issues
are possible and likely.

Change-Id: If422a2e36df924e897736b3feffa89f411d9dac1
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Make Ethernet/VLAN Interfaces handle "404 Not Found" properly

Ethernet and VLAN Interfaces lacked detection whether interface
actually existed. So this detection had to be added. Additionally
there

Make Ethernet/VLAN Interfaces handle "404 Not Found" properly

Ethernet and VLAN Interfaces lacked detection whether interface
actually existed. So this detection had to be added. Additionally
there was slight inconsistency with error messages and statuses,
this is fixed now.

Tested on x86 development machine and dedicated platform. Does not
introduce any regression.

Change-Id: Ic9e2a98c748ac0dd1cf412b6a54a14f3f53eb9fa
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Make SessionStore a proper singleton

- SessionStore class now has a proper singleton structure
- session_storage_singleton.hpp is removed
- from_json(..) function for SessionStore is changed to a sp

Make SessionStore a proper singleton

- SessionStore class now has a proper singleton structure
- session_storage_singleton.hpp is removed
- from_json(..) function for SessionStore is changed to a specialized
template
- minor cosmetic fixes added
- Move the template class usages of Crow App over to a non-template
parameter


Change-Id: Ic9effd5b7bac089a84c80a0caa97bd46d4984416
Signed-off-by: Borawski.Lukasz <lukasz.borawski@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Implement VlanNetworkInterface and VlanNetworkInterfaceCollection Schema

Implemented GET for both schemas and POST in collection for VLAN creation.
PATCH and DELETE for interface schema will be intr

Implement VlanNetworkInterface and VlanNetworkInterfaceCollection Schema

Implemented GET for both schemas and POST in collection for VLAN creation.
PATCH and DELETE for interface schema will be introduced later.

Does not introduce regression. Tested on HW platform and x86 dev system.

Change-Id: If7b11c42a9382030ab1f0712422e310f192055ca
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>

show more ...

Fix for empty string in IPv4 PATCH.

Unfortunately current implementation handles empty string as 0, so format verification is OK,
but IPs like XXX...XXX should not be accepted.

Change-Id: Ibdc526a7

Fix for empty string in IPv4 PATCH.

Unfortunately current implementation handles empty string as 0, so format verification is OK,
but IPs like XXX...XXX should not be accepted.

Change-Id: Ibdc526a7118bffdc6a028343a32711d1ad6e2d62
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>

show more ...

Implement VlanNetworkInterface Schema DELETE and PATCH methods

Does not introduce regression. Tested on HW platform and x86 dev system.

Change-Id: I1e8894367e664de4900f7a528d1ce8ee4d66ac1c
Signed-o

Implement VlanNetworkInterface Schema DELETE and PATCH methods

Does not introduce regression. Tested on HW platform and x86 dev system.

Change-Id: I1e8894367e664de4900f7a528d1ce8ee4d66ac1c
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>

show more ...

Implemented PATCH for EthernetInterface IPv4Addresses array

Implemented PATCH request handling in EthernetInterface schema. Allows creation, modification
and deletion of IPv4Addresses according to D

Implemented PATCH for EthernetInterface IPv4Addresses array

Implemented PATCH request handling in EthernetInterface schema. Allows creation, modification
and deletion of IPv4Addresses according to DMTF's Redfish specification.

This code does not change existing functionality - only expands it.
Tested on real hardware and x86 VM. Works fine, passes RedfishSchemaValidator.

Change-Id: Iff485b969e87d51b65a63c84a9199d44189131d0
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>

show more ...