72bed802 | 24-Jan-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Update cereal dependency
It seems that, we cannot directly make the cereal packages as required, since the libcereal bitbake recipe does not seem to supply the necessary package config files which m
Update cereal dependency
It seems that, we cannot directly make the cereal packages as required, since the libcereal bitbake recipe does not seem to supply the necessary package config files which meson build system could find using the dependency() call.
The libcereal bitbake recipe does not seem to put the package config files but seem to install the necessary header files into the includes, so mark the cereal dependency as not required, but add the checks for finding the necessary cereal headers rather than the package config file.
Just copied the cereal dependency check code from other repositories like phosphor-state-manager & pldm.
Tested by : 1. Did a bitbake build with this change and made sure that the bios-config-mgr builds & figure outs the cereal dependency.
Change-Id: Ib1139bfc41024a9f29953ed0427fa9fc0bbf238c Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
d8f9f3fb | 16-Dec-2023 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Remove an unused variable
This commit removes biosPasswordFile variable which is not used anywhere in the code.
Tested by: 1. Removed the un-used variable and daemon still compiles and builds. So t
Remove an unused variable
This commit removes biosPasswordFile variable which is not used anywhere in the code.
Tested by: 1. Removed the un-used variable and daemon still compiles and builds. So this commit is removing an already dead code. Functionally this does not impact any features.
Change-Id: Ic3a1642bff20977d34270e9d9015feee320db374 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
e7f0b66c | 16-Dec-2023 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Add missing cereal dependency
The repository uses cereal as a serialization library to persist the dbus object changes.So we better add it to the dependency list so that , there will be an explicit
Add missing cereal dependency
The repository uses cereal as a serialization library to persist the dbus object changes.So we better add it to the dependency list so that , there will be an explicit checking in the configuration stage rather than bailing out with a compile failure.
Change-Id: Id674c3a1eb47d9df9a9aaeaba278509f467765b8 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
f5911653 | 16-Dec-2023 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Add missing nlohmann_json dependency
The bios-password part of code relies on seed file which is in JSON format and also uses the nlohmann parse functions to parse it, so add it to the dependency li
Add missing nlohmann_json dependency
The bios-password part of code relies on seed file which is in JSON format and also uses the nlohmann parse functions to parse it, so add it to the dependency list.
Change-Id: I7f4ab5a79f8909ee527861a9275ddc2282599a67 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
918d1a3e | 16-Dec-2023 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Add support for subprojects
In the current state, the repository does not build with out the necessary libraries installed on the host machine, intention behind this commit is to add the necessary s
Add support for subprojects
In the current state, the repository does not build with out the necessary libraries installed on the host machine, intention behind this commit is to add the necessary subprojects support so that, the repository can be build with automatic download of dependencies.
Change-Id: Iddd4e87651fb07a328747133a196f1fac30e60de Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
e62033ca | 16-Dec-2023 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Remove executable permissions for text files
In the current state of the repository, meson.build, README.md and LICENSE files are checked in with executable permissions. They dont need executable pe
Remove executable permissions for text files
In the current state of the repository, meson.build, README.md and LICENSE files are checked in with executable permissions. They dont need executable permissions as they are not executables themselves, so removing the permissions.
Change-Id: Id693bd165ab3a2cf1d3478cd78bd4171bf2a38db Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
20de6de8 | 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: Ia881313b07842cd9448f3d600760f9deef2f57c3 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
628e4aa4 | 16-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson: Replace configure_file with fs.copyfile
configure_file is deprecated since 0.64.0, and replace it with fs.copyfile.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I258e8dbdd8108a
meson: Replace configure_file with fs.copyfile
configure_file is deprecated since 0.64.0, and replace it with fs.copyfile.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I258e8dbdd8108af9f6024f8d70dea720e68c6b3e
show more ...
|
50302b8a | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using t
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using the .txt extension for a build file has a few advantages, chief among them many tools and text editors expect a file with the .txt extension to be plain text files, not build scripts.
[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I0c2107e2416850fb71ede666b733abb502ac698a
show more ...
|
ea08aa58 | 15-Aug-2023 |
Patrick Williams <patrick@stwcx.xyz> |
README: fix documentation URL
Change-Id: If34b22822bd2c3d086bba4c5ed8a1347bef7845b Signed-off-by: Patrick Williams <patrick@stwcx.xyz> |
9ace6ac5 | 12-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of the standard has been implemented. Upgrade the build to leverage it.
Change-Id: Ia1f83dde45a080bf854a3
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of the standard has been implemented. Upgrade the build to leverage it.
Change-Id: Ia1f83dde45a080bf854a3bccb23af462410aa158 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
f19e2713 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I8eaad22ef9603fcdddf3de9d297aafbaf7472816 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
b3f7a79e | 09-May-2023 |
Smriti-Ayushi <smriti.ayushi@linux.intel.com> |
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No oob-bios functionality impact.
Change-Id: I2a37eb12cbf33bcb560a819be37471adfde410b6 Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
1a448ad8 | 03-May-2023 |
Arun Lal K M <arun.lal@intel.com> |
Show option->text of BIOS knob in Redfish response.
GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/ shows list of Attributes under RegistryEntries. Each attribute correspo
Show option->text of BIOS knob in Redfish response.
GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/ shows list of Attributes under RegistryEntries. Each attribute corresponds to a knob in BIOS.
If knob in BIOS is of type Enumeration, it will have 'option' with 'text' and 'value'. This text should be mapped to attribute->Value->ValueDisplayName.
Code changes are made for the same.
Tested Sample knobs from BIOS.
<knob name="AdaptiveRefreshMgmtLevel" ... > <options> <option text="Default" value="0x0"/> <option text="Level A" value="0x1"/> <option text="Level B" value="0x2"/> <option text="Level C" value="0x3"/> </options> </knob> <knob name="ADDDCEn" ... > <options> <option text="Disable" value="0x0"/> <option text="Enable" value="0x1"/> </options> </knob>
Corresponding Redfish response in BiosAttributeRegistry
{ "AttributeName": "AdaptiveRefreshMgmtLevel", "CurrentValue": "0x00", "DefaultValue": "0x00", "DisplayName": "AdaptiveRefreshMgmtLevel", "HelpText": "ARFM Level when ... ", "MenuPath": "./", "ReadOnly": false, "Type": "Enumeration", "Value": [ { "ValueDisplayName": "Default", "ValueName": "0x0" }, { "ValueDisplayName": "Level A", "ValueName": "0x1" }, { "ValueDisplayName": "Level B", "ValueName": "0x2" }, { "ValueDisplayName": "Level C", "ValueName": "0x3" } ] }, { "AttributeName": "ADDDCEn", "CurrentValue": "0x00", "DefaultValue": "0x00", "DisplayName": "ADDDCEn", "HelpText": "Enable/Disable ADDDC Sparing", "MenuPath": "./", "ReadOnly": false, "Type": "Enumeration", "Value": [ { "ValueDisplayName": "Disable", "ValueName": "0x0" }, { "ValueDisplayName": "Enable", "ValueName": "0x1" } ] }
Change-Id: Ie0134c3d47a5eae85b6838e6fe44e3ba31090c8e Signed-off-by: Arun Lal K M <arun.lal@intel.com>
show more ...
|
c76391be | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In meson 0.58 the `get_variable` was enhanced to no longer require the `pkgconfig
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In meson 0.58 the `get_variable` was enhanced to no longer require the `pkgconfig` keyword argument. Ensure meson 0.58 is required and update the usage of all `get_pkgconfig_variable` and `get_variable` to be the modern variant.
Change-Id: I7df6262b311149cc179f43d7802dd2aacbc55317 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
8c22d07b | 22-Mar-2023 |
yes <smriti.ayushi@linux.intel.com> |
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No oob-bios functionality impact.
Change-Id: Id500b824f8d99b28c580ceb244f4a0114060e57e Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
8de46ffb | 22-Mar-2023 |
yes <smriti.ayushi@linux.intel.com> |
Clean up
Following commit just covers few spellings and grammatical corrections in src code files and README.
Verified: No impact on oob-bios functionality.
Change-Id: Iaaa1a89186928fbb750c5f38fc1
Clean up
Following commit just covers few spellings and grammatical corrections in src code files and README.
Verified: No impact on oob-bios functionality.
Change-Id: Iaaa1a89186928fbb750c5f38fc163a12597ced08 Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
f0452a0a | 01-Feb-2023 |
kuiying <wangkuiying.wky@alibaba-inc.com> |
Updagte Kuiying's email address
Kuiying's email address is changed to wangkuiying.wky@alibaba-inc.com
Change-Id: Ia4e6ee74d5b96c490e1cecac36c1329e179c9d33 Signed-off-by: kuiying <wangkuiying.wky@al
Updagte Kuiying's email address
Kuiying's email address is changed to wangkuiying.wky@alibaba-inc.com
Change-Id: Ia4e6ee74d5b96c490e1cecac36c1329e179c9d33 Signed-off-by: kuiying <wangkuiying.wky@alibaba-inc.com>
show more ...
|
1a1dfbd2 | 17-Jan-2023 |
Arun Lal K M <arun.lal@intel.com> |
Make BiosConfig run as one service.
As of now BiosConfig runs in two service as seen below. 1) xyz.openbmc_project.biosconfig_manager.service busctl tree xyz.openbmc_project.BIOSConfigManager `-/xyz
Make BiosConfig run as one service.
As of now BiosConfig runs in two service as seen below. 1) xyz.openbmc_project.biosconfig_manager.service busctl tree xyz.openbmc_project.BIOSConfigManager `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/bios_config `-/xyz/openbmc_project/bios_config/manager
2) xyz.openbmc_project.biosconfig_password.service busctl tree xyz.openbmc_project.BIOSConfigPassword `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/bios_config `-/xyz/openbmc_project/bios_config/password
The code changes are to move functionalities of xyz.openbmc_project.biosconfig_password.service to xyz.openbmc_project.biosconfig_manager.service as shown below
busctl tree xyz.openbmc_project.BIOSConfigManager `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/bios_config |-/xyz/openbmc_project/bios_config/manager `-/xyz/openbmc_project/bios_config/password
Tested: Made sure BiosConfig functionality is not affected. Note that calls from bmcweb will now require to use service as xyz.openbmc_project.biosconfig_manager.service
Change-Id: I8adeb57ed3758041b2b9b0d1ddc714e418c4484e Signed-off-by: Arun Lal K M <arun.lal@intel.com>
show more ...
|
d0f034a2 | 29-Dec-2022 |
yes <smriti.ayushi@intel.com> |
Clean up in Password code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: I616a2e90566fc687702f08511955ef9a6fed3c59 Signed-
Clean up in Password code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: I616a2e90566fc687702f08511955ef9a6fed3c59 Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
ad54c7cb | 29-Dec-2022 |
yes <smriti.ayushi@linux.intel.com> |
Clean up manager code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: Ic7487dc042e637b50c8b68e7a87c9d36465bac8b Signed-off-
Clean up manager code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: Ic7487dc042e637b50c8b68e7a87c9d36465bac8b Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
7520590a | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
Change-Id: Iebd96d897c7c1cb923861a09e44898d9a8588af1 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
36cd3238 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
MAINTAINERS: remove file
The MAINTAINERS file is deprecated in favor of OWNERS.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I8139f810c2a491bb921f8b1a289c59e58758a245
|
d7d15fcb | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have the correct field.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I4765da85294f95e382e388d6afe458d1af7b07b8
show more ...
|
616f9228 | 29-Dec-2021 |
George Liu <liuxiwei@inspur.com> |
Fix some warnings by cppcheck
Warning message: /src/manager.cpp:255:53: warning: Division by zero [core.DivideZero] if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/pass
Fix some warnings by cppcheck
Warning message: /src/manager.cpp:255:53: warning: Division by zero [core.DivideZero] if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/password.hpp:84:36: performance: Function parameter 'rawData' should be passed by const reference. [passedByValue] const std::string rawData, const std::string algo); ^ include/password.hpp:84:63: performance: Function parameter 'algo' should be passed by const reference. [passedByValue] const std::string rawData, const std::string algo);
Tested: Verify that there are no such warnings in local CI.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I12276f64b06e4eddfd8cd340ebc16d04e4e9ccd5
show more ...
|