fix secureboot namespace to bios_config

I am not sure how this was working to begin with. Using bios_config_sec
seems to cause a build error due to an undefined namespace. Switch to
the correct name

fix secureboot namespace to bios_config

I am not sure how this was working to begin with. Using bios_config_sec
seems to cause a build error due to an undefined namespace. Switch to
the correct namespace to fix the build failure.

Change-Id: Ib7d2aad14eb3b8f5927b156d269829d10d8b3554
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

meson: drop configuration.h generation and usage

The configuration header was generated but unused.
Remove configure_file() and the stale include from main.cpp.

Change-Id: Ibe614b9b8dd57d42825f0713

meson: drop configuration.h generation and usage

The configuration header was generated but unused.
Remove configure_file() and the stale include from main.cpp.

Change-Id: Ibe614b9b8dd57d42825f0713464d0220562f0c72
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-tidy: remove unused fields, keep ctor ABI

Clang-tidy flagged objServer/systemBus as unused private fields in
bios_config_pwd::Password. These members were originally added for
future D-Bus int

clang-tidy: remove unused fields, keep ctor ABI

Clang-tidy flagged objServer/systemBus as unused private fields in
bios_config_pwd::Password. These members were originally added for
future D-Bus integration but are not referenced today.

To keep the code clean and satisfy -Werror without hacks, remove the
unused members while preserving the constructor signature
(objectServer, systemBus, persistPath) for ABI compatibility with
upstream main.cpp and potential future use.

fixed below errors

'''
In file included from ../src/password.cpp:16:
../include/password.hpp:93:37: error: private field 'objServer' is not used [-Werror,-Wunused-private-field]
93 | sdbusplus::asio::object_server& objServer;
| ^
../include/password.hpp:94:51: error: private field 'systemBus' is not used [-Werror,-Wunused-private-field]
94 | std::shared_ptr<sdbusplus::asio::connection>& systemBus;
| ^
'''

Change-Id: Id5032b28ccc14ccea4b790dc38cc1e470a33b4e3
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

Correct misleading trace in deserialization path

The trace logged during deserialization failure is misleading.
This change updates the message to accurately reflect error.


Change-Id: I3e617fe658a

Correct misleading trace in deserialization path

The trace logged during deserialization failure is misleading.
This change updates the message to accurately reflect error.


Change-Id: I3e617fe658a38b0a5679222393c6049eb5bf495e
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

Revert "Add version to BaseBiosTable to prevent data loss"

This reverts commit 4e29f80bf85c3a8197bb6c3183f25face059f29c.

Version 0 was originally intended for the old BIOS table format,
while Versi

Revert "Add version to BaseBiosTable to prevent data loss"

This reverts commit 4e29f80bf85c3a8197bb6c3183f25face059f29c.

Version 0 was originally intended for the old BIOS table format,
while Version 1 was introduced for the updated BIOS table that
includes VDN. However, the Version 1 support and the BIOS data
type changes were not merged together, causing the modified BIOS
table to be incorrectly serialized using Version 0.
To ensure successful BIOS table deserialization, this commit
is being reverted.

Change-Id: I49619b216ed568c58c06b4b32f48b8730529fb3b
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

json: format output with 4-space indentation

Use `dump(4)` instead of `dump()` to generate JSON with
4-space indentation, improving readability of written files.

Change-Id: I7aad3bf50cdf482dde7c0bd

json: format output with 4-space indentation

Use `dump(4)` instead of `dump()` to generate JSON with
4-space indentation, improving readability of written files.

Change-Id: I7aad3bf50cdf482dde7c0bdd5aa76d030aa0ca60
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Remove error trace from BIOS attribute updates

Commit 4e29f80bf85c3a8197bb6c3183f25face059f29c introduced an error
trace in the serialization function for a condition that is not
actually erroneous.

Remove error trace from BIOS attribute updates

Commit 4e29f80bf85c3a8197bb6c3183f25face059f29c introduced an error
trace in the serialization function for a condition that is not
actually erroneous. This message is printed on every BIOS attribute
update, adding noise without providing meaningful information. The
trace is now removed to reduce unnecessary log clutter.

Change-Id: I632f8c98da5a4418c4715b6b88e95f1025183a54
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Support to remotely configure UEFI SecureBoot Settings

Redfish added schema for SecureBoot contains UEFI Secure Boot
information and represents properties for managing the UEFI Secure
Boot functiona

Support to remotely configure UEFI SecureBoot Settings

Redfish added schema for SecureBoot contains UEFI Secure Boot
information and represents properties for managing the UEFI Secure
Boot functionality of a system. This patch adds support to configure
the settings from BMC.

Introduced option 'ENABLE_BIOS_SECUREBOOT` to selectively create
SecureBoot object.

The PDI Changes for SecureBoot:
[1]: https://github.com/openbmc/phosphor-dbus-interfaces/commit/b235159e0acc9943bc5f4e428ba6536f2e3cb621#diff-dbd3a29b95a6a0d436ba19696c3db9852172311f363b6781cc48b49d62ee28fa

Redfish URI enabled with this change
`/redfish/v1/Systems/<system>/SecureBoot`

Tested:
1) Dbus tree view with the change
```
busctl tree xyz.openbmc_project.BIOSConfigManager
`- /xyz
`- /xyz/openbmc_project
`- /xyz/openbmc_project/bios_config
|- /xyz/openbmc_project/bios_config/manager
|- /xyz/openbmc_project/bios_config/password
`- /xyz/openbmc_project/bios_config/secure_boot
```
2) Runtime Check at Redfish Level:
On platforms where the ENABLE_BIOS_SECUREBOOT is disabled the
redfish URI at the redfish level is disabled as the dbus path
does not exists.
3) For persistence of BIOS secureboot values the data is written to
separate file `securebootData` under
`/var/lib/bios-settings-manager`. This will avoid any issues for
current platforms.

Change-Id: I51cb42671bb7c62ef51f8d77b17265ab24edbcff
Signed-off-by: Prithvi Pai <ppai@nvidia.com>

show more ...

Fix build issues with boost 1.87

Update deprecated terminology that was removed in boost 1.87.

Change-Id: I85e6103745f10bcaa0d383e339130fbaac08d8a7
Signed-off-by: Jason M. Bills <jason.m.bills@linu

Fix build issues with boost 1.87

Update deprecated terminology that was removed in boost 1.87.

Change-Id: I85e6103745f10bcaa0d383e339130fbaac08d8a7
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add version to BaseBiosTable to prevent data loss

The initial version of the Base BIOS table did not support Value Display
Names (VDN). Support for VDN was introduced in a commit [1]. A BMC image
cr

Add version to BaseBiosTable to prevent data loss

The initial version of the Base BIOS table did not support Value Display
Names (VDN). Support for VDN was introduced in a commit [1]. A BMC image
created without VDN support stores data in the old BaseBiosTable format.
If a new BMC image (with VDN support) is flashed over an older image
(without VDN support), the BIOS manager attempts to read the binary
archive generated by the older BIOS settings manager. Since it doesn't
recognize the newly added property, it assumes the persisted file is
corrupted and ignores all the saved settings.

To prevent the loss of persisted BIOS data, the versioning support
provided by the Cereal library is used. This version information is
utilized to convert the persisted data into the current supported
format.

[1]: https://github.com/openbmc/bios-settings-mgr/commit/1a448ad88fdaec7e082b4a1c437f7f3c990402cd

Change-Id: If68be37e32ae31d7338d8933df945453a30c113a
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

Fix log message for integer property validation

Update error log message to clarify that the expected variant type is
an integer for Integer properties.

Change-Id: Ie9c5aa53755d146d6c7543397e13396f

Fix log message for integer property validation

Update error log message to clarify that the expected variant type is
an integer for Integer properties.

Change-Id: Ie9c5aa53755d146d6c7543397e13396f745bc72e
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove duplicated block comments in copyrights

All the copyright headers from the repository seems to have duplicated
block comments. Removing them.

Change-Id: I13ab1a10e60de14f740bac52624e1c7ac672

Remove duplicated block comments in copyrights

All the copyright headers from the repository seems to have duplicated
block comments. Removing them.

Change-Id: I13ab1a10e60de14f740bac52624e1c7ac672eafc
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

deserialize: Handle wide range of exceptions

We seem to only catch std::length_error exception and cereal exception,
but all the other exceptions like std::bad_alloc are ignored. This
commit would e

deserialize: Handle wide range of exceptions

We seem to only catch std::length_error exception and cereal exception,
but all the other exceptions like std::bad_alloc are ignored. This
commit would ensure that we catch wide range of exceptions and makes
sure we delete the corrpted file in all error scenarios.

Change-Id: Ia607ec18fdce3385fb4857d9a0608f5d8d1e8704
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Add error handling in serialize() & deserialize()

Refined the serialize and deserialize functions to incorporate robust
error handling. These checks would safeguard the application against
potential

Add error handling in serialize() & deserialize()

Refined the serialize and deserialize functions to incorporate robust
error handling. These checks would safeguard the application against
potential runtime crashes.

Change-Id: I39923feeb489a5270b961278118abcc7f4c31dee
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

manager: allow running at non-standard path

Add an optional argument to the daemon to allow the persistent
location to be a non-standard path. This enables running the
application as a normal user

manager: allow running at non-standard path

Add an optional argument to the daemon to allow the persistent
location to be a non-standard path. This enables running the
application as a normal user on a developer system rather than
requiring it to be installed in a full BMC image.

Tested:

Ran with `biosconfig-manager /tmp/bios-config-manager`:

```
$ busctl --user tree xyz.openbmc_project.BIOSConfigManager
└─ /xyz
└─ /xyz/openbmc_project
└─ /xyz/openbmc_project/bios_config
├─ /xyz/openbmc_project/bios_config/manager
└─ /xyz/openbmc_project/bios_config/password
```

Change-Id: I42f688e233060c43983d2690facbb1026e678c77
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

remove meson.options

The only option in this repository is configuring the location
of the persistent file location. This is not ever leveraged
by anyone. Reduce the complexity of maintaining a me

remove meson.options

The only option in this repository is configuring the location
of the persistent file location. This is not ever leveraged
by anyone. Reduce the complexity of maintaining a meson.option
to hold a string and just move it to a constant in a header.

Change-Id: I066d88d2831d1d04fd53b47e26cd6fbcabf863d2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I16de1731b6a2549fb11ca4115a9e477001c1f403
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I8eaad22ef9603fcdddf3de9d297aafbaf7472816
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Clean up: Function abstraction in password file

Abstracted verifyPassword function in password source file
to make it more readable by creating a new function named
verifyIntegrityCheck.

Tested:
No

Clean up: Function abstraction in password file

Abstracted verifyPassword function in password source file
to make it more readable by creating a new function named
verifyIntegrityCheck.

Tested:
No oob-bios functionality impact.

Change-Id: I2a37eb12cbf33bcb560a819be37471adfde410b6
Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>

show more ...

Show option->text of BIOS knob in Redfish response.

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
correspo

Show option->text of BIOS knob in Redfish response.

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
corresponds to a knob in BIOS.

If knob in BIOS is of type Enumeration, it will have 'option' with
'text' and 'value'. This text should be mapped to
attribute->Value->ValueDisplayName.

Code changes are made for the same.

Tested
Sample knobs from BIOS.

<knob name="AdaptiveRefreshMgmtLevel" ... >
<options>
<option text="Default" value="0x0"/>
<option text="Level A" value="0x1"/>
<option text="Level B" value="0x2"/>
<option text="Level C" value="0x3"/>
</options>
</knob>
<knob name="ADDDCEn" ... >
<options>
<option text="Disable" value="0x0"/>
<option text="Enable" value="0x1"/>
</options>
</knob>

Corresponding Redfish response in BiosAttributeRegistry

{
"AttributeName": "AdaptiveRefreshMgmtLevel",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "AdaptiveRefreshMgmtLevel",
"HelpText": "ARFM Level when ... ",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Default",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Level A",
"ValueName": "0x1"
},
{
"ValueDisplayName": "Level B",
"ValueName": "0x2"
},
{
"ValueDisplayName": "Level C",
"ValueName": "0x3"
}
]
},
{
"AttributeName": "ADDDCEn",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "ADDDCEn",
"HelpText": "Enable/Disable ADDDC Sparing",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Disable",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Enable",
"ValueName": "0x1"
}
]
}

Change-Id: Ie0134c3d47a5eae85b6838e6fe44e3ba31090c8e
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

Clean up: Function abstraction in password file

Abstracted verifyPassword function in password source file
to make it more readable by creating a new function named
verifyIntegrityCheck.

Tested:
No

Clean up: Function abstraction in password file

Abstracted verifyPassword function in password source file
to make it more readable by creating a new function named
verifyIntegrityCheck.

Tested:
No oob-bios functionality impact.

Change-Id: Id500b824f8d99b28c580ceb244f4a0114060e57e
Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>

show more ...

Clean up

Following commit just covers few spellings and grammatical corrections
in src code files and README.

Verified:
No impact on oob-bios functionality.

Change-Id: Iaaa1a89186928fbb750c5f38fc1

Clean up

Following commit just covers few spellings and grammatical corrections
in src code files and README.

Verified:
No impact on oob-bios functionality.

Change-Id: Iaaa1a89186928fbb750c5f38fc163a12597ced08
Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>

show more ...

Make BiosConfig run as one service.

As of now BiosConfig runs in two service as seen below.
1) xyz.openbmc_project.biosconfig_manager.service
busctl tree xyz.openbmc_project.BIOSConfigManager
`-/xyz

Make BiosConfig run as one service.

As of now BiosConfig runs in two service as seen below.
1) xyz.openbmc_project.biosconfig_manager.service
busctl tree xyz.openbmc_project.BIOSConfigManager
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/bios_config
`-/xyz/openbmc_project/bios_config/manager

2) xyz.openbmc_project.biosconfig_password.service
busctl tree xyz.openbmc_project.BIOSConfigPassword
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/bios_config
`-/xyz/openbmc_project/bios_config/password

The code changes are to move functionalities of
xyz.openbmc_project.biosconfig_password.service to
xyz.openbmc_project.biosconfig_manager.service as
shown below

busctl tree xyz.openbmc_project.BIOSConfigManager
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/bios_config
|-/xyz/openbmc_project/bios_config/manager
`-/xyz/openbmc_project/bios_config/password

Tested:
Made sure BiosConfig functionality is not affected.
Note that calls from bmcweb will now require to use
service as xyz.openbmc_project.biosconfig_manager.service

Change-Id: I8adeb57ed3758041b2b9b0d1ddc714e418c4484e
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

Clean up in Password code file

Abstracted functions to make code more readable.

Tested:
Verified oob-bios functionality is not altered.

Change-Id: I616a2e90566fc687702f08511955ef9a6fed3c59
Signed-

Clean up in Password code file

Abstracted functions to make code more readable.

Tested:
Verified oob-bios functionality is not altered.

Change-Id: I616a2e90566fc687702f08511955ef9a6fed3c59
Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>

show more ...

Clean up manager code file

Abstracted functions to make code more readable.

Tested:
Verified oob-bios functionality is not altered.

Change-Id: Ic7487dc042e637b50c8b68e7a87c9d36465bac8b
Signed-off-

Clean up manager code file

Abstracted functions to make code more readable.

Tested:
Verified oob-bios functionality is not altered.

Change-Id: Ic7487dc042e637b50c8b68e7a87c9d36465bac8b
Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>

show more ...