4e29f80b | 20-Aug-2024 |
Archana Kakani <archana.kakani@ibm.com> |
Add version to BaseBiosTable to prevent data loss
The initial version of the Base BIOS table did not support Value Display Names (VDN). Support for VDN was introduced in a commit [1]. A BMC image cr
Add version to BaseBiosTable to prevent data loss
The initial version of the Base BIOS table did not support Value Display Names (VDN). Support for VDN was introduced in a commit [1]. A BMC image created without VDN support stores data in the old BaseBiosTable format. If a new BMC image (with VDN support) is flashed over an older image (without VDN support), the BIOS manager attempts to read the binary archive generated by the older BIOS settings manager. Since it doesn't recognize the newly added property, it assumes the persisted file is corrupted and ignores all the saved settings.
To prevent the loss of persisted BIOS data, the versioning support provided by the Cereal library is used. This version information is utilized to convert the persisted data into the current supported format.
[1]: https://github.com/openbmc/bios-settings-mgr/commit/1a448ad88fdaec7e082b4a1c437f7f3c990402cd
Change-Id: If68be37e32ae31d7338d8933df945453a30c113a Signed-off-by: Archana Kakani <archana.kakani@ibm.com>
show more ...
|
6741adba | 12-Nov-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix log message for integer property validation
Update error log message to clarify that the expected variant type is an integer for Integer properties.
Change-Id: Ie9c5aa53755d146d6c7543397e13396f
Fix log message for integer property validation
Update error log message to clarify that the expected variant type is an integer for Integer properties.
Change-Id: Ie9c5aa53755d146d6c7543397e13396f745bc72e Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
fae57325 | 12-Nov-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Remove duplicated block comments in copyrights
All the copyright headers from the repository seems to have duplicated block comments. Removing them.
Change-Id: I13ab1a10e60de14f740bac52624e1c7ac672
Remove duplicated block comments in copyrights
All the copyright headers from the repository seems to have duplicated block comments. Removing them.
Change-Id: I13ab1a10e60de14f740bac52624e1c7ac672eafc Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
4b1e496a | 15-Oct-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
deserialize: Handle wide range of exceptions
We seem to only catch std::length_error exception and cereal exception, but all the other exceptions like std::bad_alloc are ignored. This commit would e
deserialize: Handle wide range of exceptions
We seem to only catch std::length_error exception and cereal exception, but all the other exceptions like std::bad_alloc are ignored. This commit would ensure that we catch wide range of exceptions and makes sure we delete the corrpted file in all error scenarios.
Change-Id: Ia607ec18fdce3385fb4857d9a0608f5d8d1e8704 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
ae2ed8d0 | 15-Oct-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Add error handling in serialize() & deserialize()
Refined the serialize and deserialize functions to incorporate robust error handling. These checks would safeguard the application against potential
Add error handling in serialize() & deserialize()
Refined the serialize and deserialize functions to incorporate robust error handling. These checks would safeguard the application against potential runtime crashes.
Change-Id: I39923feeb489a5270b961278118abcc7f4c31dee Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
773c9222 | 18-Oct-2024 |
Patrick Williams <patrick@stwcx.xyz> |
manager: allow running at non-standard path
Add an optional argument to the daemon to allow the persistent location to be a non-standard path. This enables running the application as a normal user
manager: allow running at non-standard path
Add an optional argument to the daemon to allow the persistent location to be a non-standard path. This enables running the application as a normal user on a developer system rather than requiring it to be installed in a full BMC image.
Tested:
Ran with `biosconfig-manager /tmp/bios-config-manager`:
``` $ busctl --user tree xyz.openbmc_project.BIOSConfigManager └─ /xyz └─ /xyz/openbmc_project └─ /xyz/openbmc_project/bios_config ├─ /xyz/openbmc_project/bios_config/manager └─ /xyz/openbmc_project/bios_config/password ```
Change-Id: I42f688e233060c43983d2690facbb1026e678c77 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
5c7e80d5 | 18-Oct-2024 |
Patrick Williams <patrick@stwcx.xyz> |
remove meson.options
The only option in this repository is configuring the location of the persistent file location. This is not ever leveraged by anyone. Reduce the complexity of maintaining a me
remove meson.options
The only option in this repository is configuring the location of the persistent file location. This is not ever leveraged by anyone. Reduce the complexity of maintaining a meson.option to hold a string and just move it to a constant in a header.
Change-Id: I066d88d2831d1d04fd53b47e26cd6fbcabf863d2 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
ea6a65f0 | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I16de1731b6a2549fb11ca4115a9e477001c1f403 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
f19e2713 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I8eaad22ef9603fcdddf3de9d297aafbaf7472816 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
b3f7a79e | 09-May-2023 |
Smriti-Ayushi <smriti.ayushi@linux.intel.com> |
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No oob-bios functionality impact.
Change-Id: I2a37eb12cbf33bcb560a819be37471adfde410b6 Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
1a448ad8 | 03-May-2023 |
Arun Lal K M <arun.lal@intel.com> |
Show option->text of BIOS knob in Redfish response.
GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/ shows list of Attributes under RegistryEntries. Each attribute correspo
Show option->text of BIOS knob in Redfish response.
GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/ shows list of Attributes under RegistryEntries. Each attribute corresponds to a knob in BIOS.
If knob in BIOS is of type Enumeration, it will have 'option' with 'text' and 'value'. This text should be mapped to attribute->Value->ValueDisplayName.
Code changes are made for the same.
Tested Sample knobs from BIOS.
<knob name="AdaptiveRefreshMgmtLevel" ... > <options> <option text="Default" value="0x0"/> <option text="Level A" value="0x1"/> <option text="Level B" value="0x2"/> <option text="Level C" value="0x3"/> </options> </knob> <knob name="ADDDCEn" ... > <options> <option text="Disable" value="0x0"/> <option text="Enable" value="0x1"/> </options> </knob>
Corresponding Redfish response in BiosAttributeRegistry
{ "AttributeName": "AdaptiveRefreshMgmtLevel", "CurrentValue": "0x00", "DefaultValue": "0x00", "DisplayName": "AdaptiveRefreshMgmtLevel", "HelpText": "ARFM Level when ... ", "MenuPath": "./", "ReadOnly": false, "Type": "Enumeration", "Value": [ { "ValueDisplayName": "Default", "ValueName": "0x0" }, { "ValueDisplayName": "Level A", "ValueName": "0x1" }, { "ValueDisplayName": "Level B", "ValueName": "0x2" }, { "ValueDisplayName": "Level C", "ValueName": "0x3" } ] }, { "AttributeName": "ADDDCEn", "CurrentValue": "0x00", "DefaultValue": "0x00", "DisplayName": "ADDDCEn", "HelpText": "Enable/Disable ADDDC Sparing", "MenuPath": "./", "ReadOnly": false, "Type": "Enumeration", "Value": [ { "ValueDisplayName": "Disable", "ValueName": "0x0" }, { "ValueDisplayName": "Enable", "ValueName": "0x1" } ] }
Change-Id: Ie0134c3d47a5eae85b6838e6fe44e3ba31090c8e Signed-off-by: Arun Lal K M <arun.lal@intel.com>
show more ...
|
8c22d07b | 22-Mar-2023 |
yes <smriti.ayushi@linux.intel.com> |
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No
Clean up: Function abstraction in password file
Abstracted verifyPassword function in password source file to make it more readable by creating a new function named verifyIntegrityCheck.
Tested: No oob-bios functionality impact.
Change-Id: Id500b824f8d99b28c580ceb244f4a0114060e57e Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
8de46ffb | 22-Mar-2023 |
yes <smriti.ayushi@linux.intel.com> |
Clean up
Following commit just covers few spellings and grammatical corrections in src code files and README.
Verified: No impact on oob-bios functionality.
Change-Id: Iaaa1a89186928fbb750c5f38fc1
Clean up
Following commit just covers few spellings and grammatical corrections in src code files and README.
Verified: No impact on oob-bios functionality.
Change-Id: Iaaa1a89186928fbb750c5f38fc163a12597ced08 Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
1a1dfbd2 | 17-Jan-2023 |
Arun Lal K M <arun.lal@intel.com> |
Make BiosConfig run as one service.
As of now BiosConfig runs in two service as seen below. 1) xyz.openbmc_project.biosconfig_manager.service busctl tree xyz.openbmc_project.BIOSConfigManager `-/xyz
Make BiosConfig run as one service.
As of now BiosConfig runs in two service as seen below. 1) xyz.openbmc_project.biosconfig_manager.service busctl tree xyz.openbmc_project.BIOSConfigManager `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/bios_config `-/xyz/openbmc_project/bios_config/manager
2) xyz.openbmc_project.biosconfig_password.service busctl tree xyz.openbmc_project.BIOSConfigPassword `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/bios_config `-/xyz/openbmc_project/bios_config/password
The code changes are to move functionalities of xyz.openbmc_project.biosconfig_password.service to xyz.openbmc_project.biosconfig_manager.service as shown below
busctl tree xyz.openbmc_project.BIOSConfigManager `-/xyz `-/xyz/openbmc_project `-/xyz/openbmc_project/bios_config |-/xyz/openbmc_project/bios_config/manager `-/xyz/openbmc_project/bios_config/password
Tested: Made sure BiosConfig functionality is not affected. Note that calls from bmcweb will now require to use service as xyz.openbmc_project.biosconfig_manager.service
Change-Id: I8adeb57ed3758041b2b9b0d1ddc714e418c4484e Signed-off-by: Arun Lal K M <arun.lal@intel.com>
show more ...
|
d0f034a2 | 29-Dec-2022 |
yes <smriti.ayushi@intel.com> |
Clean up in Password code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: I616a2e90566fc687702f08511955ef9a6fed3c59 Signed-
Clean up in Password code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: I616a2e90566fc687702f08511955ef9a6fed3c59 Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
ad54c7cb | 29-Dec-2022 |
yes <smriti.ayushi@linux.intel.com> |
Clean up manager code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: Ic7487dc042e637b50c8b68e7a87c9d36465bac8b Signed-off-
Clean up manager code file
Abstracted functions to make code more readable.
Tested: Verified oob-bios functionality is not altered.
Change-Id: Ic7487dc042e637b50c8b68e7a87c9d36465bac8b Signed-off-by: Smriti-Ayushi <smriti.ayushi@linux.intel.com>
show more ...
|
616f9228 | 29-Dec-2021 |
George Liu <liuxiwei@inspur.com> |
Fix some warnings by cppcheck
Warning message: /src/manager.cpp:255:53: warning: Division by zero [core.DivideZero] if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/pass
Fix some warnings by cppcheck
Warning message: /src/manager.cpp:255:53: warning: Division by zero [core.DivideZero] if (((std::abs(attrValue - lowerBound)) % scalarIncrement) != 0)
include/password.hpp:84:36: performance: Function parameter 'rawData' should be passed by const reference. [passedByValue] const std::string rawData, const std::string algo); ^ include/password.hpp:84:63: performance: Function parameter 'algo' should be passed by const reference. [passedByValue] const std::string rawData, const std::string algo);
Tested: Verify that there are no such warnings in local CI.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I12276f64b06e4eddfd8cd340ebc16d04e4e9ccd5
show more ...
|
47453d77 | 29-Nov-2021 |
George Liu <liuxiwei@inspur.com> |
Fix the String type of pendingAttributes method
When the user calls the `pendingAttributes` method, if the `attributeType` is equal to the string type, there is a chance that the previous logic will
Fix the String type of pendingAttributes method
When the user calls the `pendingAttributes` method, if the `attributeType` is equal to the string type, there is a chance that the previous logic will fail because of the `std::get<1>` exception.
Since the string type has joined `MinStringLength` and `MaxStringLength`, it is necessary to verify the maximum length and minimum length of the string.
resolved: https://github.com/openbmc/bios-settings-mgr/issues/2
Tested: If the length of the hb_lid_ids attribute value we configure is 0 to 10, which is when we set a string with a length of more than 10 bytes, an exception will be thrown.
bios/string_attrs.json: { "attribute_name" : "hb_lid_ids", "string_type" : "ASCII", "minimum_string_length" : 0, "maximum_string_length" : 10, "default_string_length" : 0, "default_string" : "", "helpText" : "Provides the host a mapping of the lid IDs to human readable names.", "displayName" : "Hostboot Lid IDs" }
busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager org.freedesktop.DBus.Properties Set ssv xyz.openbmc_project.BIOSConfig.Manager PendingAttributes a{s\(sv\)} 1 "hb_lid_ids" "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String" s "123456789023" Call failed: Invalid argument was given.
journalctl -o json-pretty SYSLOG_IDENTIFIER=biosconfig-manager { "_SYSTEMD_INVOCATION_ID" : "0930e3a7967e4eb68429fd472afebcec", "_HOSTNAME" : "fp5280g2", "_PID" : "243", "ATTRVALUE" : "123456789023", "_EXE" : "/usr/bin/biosconfig-manager", "_CMDLINE" : "/usr/bin/biosconfig-manager", "_SYSTEMD_SLICE" : "system.slice", "SYSLOG_IDENTIFIER" : "biosconfig-manager", "__REALTIME_TIMESTAMP" : "305445800", "_GID" : "0", "MINLEN" : "0", "MAXLEN" : "10", "CODE_LINE" : "210", "MESSAGE" : "123456789023 Length is out of range, bound is invalid, maxStringLength = 10, minStringLength = 0", ... }
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Ic13a8acf8417beb92ea3ed1bec5a4bc58d3adda9
show more ...
|
567a3cf2 | 07-Dec-2021 |
George Liu <liuxiwei@inspur.com> |
logging: switch to lg2
After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking.
Tested: buil
logging: switch to lg2
After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking.
Tested: built biosConfigManager successfully. journalctl -o json-pretty SYSLOG_IDENTIFIER=biosconfig-manager { "_TRANSPORT" : "journal", "_PID" : "244", "__MONOTONIC_TIMESTAMP" : "513878067", "_SYSTEMD_SLICE" : "system.slice", "CODE_LINE" : "123", "_SOURCE_REALTIME_TIMESTAMP" : "513877941", "_HOSTNAME" : "fp5280g2", "_CAP_EFFECTIVE" : "1ffffffffff", "_BOOT_ID" : "40382c3612f54e1a96a6ecf41fe6b38e", "SYSLOG_IDENTIFIER" : "biosconfig-manager", "_CMDLINE" : "/usr/bin/biosconfig-manager", "_EXE" : "/usr/bin/biosconfig-manager", "LOG2_FMTMSG" : "BIOS attribute not found in the BaseBIOSTable", "_SYSTEMD_UNIT" : "xyz.openbmc_project.biosconfig_manager.service", "MESSAGE" : "BIOS attribute not found in the BaseBIOSTable", "PRIORITY" : "3", "CODE_FILE" : "../biosconfig-manager/src/manager.cpp", "CODE_FUNC" : "virtual bios_config::Manager::PendingAttributes bios_config::Manager::pendingAttributes (bios_config::Manager::PendingAttributes)" ... }
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I274d61827279b10ba3fe9d61404ce8b654ccdd9e
show more ...
|
2f7ba73a | 30-Sep-2021 |
Snehalatha Venkatesh <snehalathax.v@intel.com> |
Fix for changing BIOS AdminPassword through BMC
BIOS hash value doesn't match with BMC computed hash value for changing admin password
Changed the hash function as per BIOS usage to match with BMC
Fix for changing BIOS AdminPassword through BMC
BIOS hash value doesn't match with BMC computed hash value for changing admin password
Changed the hash function as per BIOS usage to match with BMC computed hash value and BIOS hash value
Tested: By giving POST to '/redfish/v1/Systems/system/Bios/Actions/Bios.ChangePassword' Body: { "NewPassword": "123456789", "OldPassword": "1234567890", "PasswordName": "AdminPassword" } Response: Success
Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com> Change-Id: Ibaf0079e471914b738f167652d6b985533f5d920
show more ...
|
b5984b87 | 16-Aug-2021 |
Arun Lal K M <arun.lal@intel.com> |
Add data validation for PATCH to /Bios/Settings.
New data was validated only using option length. Added code to check if new value is part of available options. Error is thrown if the new values is
Add data validation for PATCH to /Bios/Settings.
New data was validated only using option length. Added code to check if new value is part of available options. Error is thrown if the new values is not a valid option.
Tested: By giving PATCH Request to 'redfish/v1/systems/system/bios/settings'. Output sample showing success case: PATCH command raw data: { "data":[ { "AttributeName": "AmpPrefetchEnable", "AttributeType": "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String", "AttributeValue": "0x01" } ] }
Response: { "@odata.id": "/redfish/v1/Systems/system/Bios/Settings", "@odata.type": "#Bios.v1_1_0.Bios", "AttributeRegistry": "BiosAttributeRegistry", "Id": "BiosSettingsV1", "Message": "Successfully Completed Request", "Name": "Bios Settings Version 1" }
Output sample showing failure case: PATCH command raw data: { "data":[ { "AttributeName": "AmpPrefetchEnable", "AttributeType": "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String", "AttributeValue": "0x05" } ] }
Response: { "@odata.id": "/redfish/v1/Systems/system/Bios/Settings", "@odata.type": "#Bios.v1_1_0.Bios", "AttributeRegistry": "BiosAttributeRegistry", "Id": "BiosSettingsV1", "Name": "Bios Settings Version 1", "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The request failed due to an internal service error. The service is still operational.", "MessageArgs": [], "MessageId": "Base.1.8.1.InternalError", "MessageSeverity": "Critical", "Resolution": "Resubmit the request. If the problem persists, consider resetting the service." } ], "code": "Base.1.8.1.InternalError", "message": "The request failed due to an internal service error. The service is still operational." } }
Note: Valid options for knob AmpPrefetchEnable is 0x01 and 0x00 as shown below. { "AttributeName": "AmpPrefetchEnable", "CurrentValue": "0x00", "DefaultValue": "0x00", "DisplayName": "AmpPrefetchEnable", "HelpText": "Set to enable or disable MLC AMP prefetch (MSR 1A4h [4]).", "MenuPath": "./", "ReadOnly": false, "Type": "String", "Value": [ { "OneOf": "0x01" }, { "OneOf": "0x00" } ] }
Signed-off-by: Arun Lal K M <arun.lal@intel.com> Change-Id: Id66bacf2491d90aa189a8fb0f48d45243195e38c
show more ...
|
8f54ee18 | 05-Aug-2021 |
George Liu <liuxiwei@inspur.com> |
Remove readOnly attribute check
In IBM's p10 system, The BIOS attribute can be set by Host but not other OOB entities(Redfish doPatch).
All attributes can be changed when the readOnly attribute is
Remove readOnly attribute check
In IBM's p10 system, The BIOS attribute can be set by Host but not other OOB entities(Redfish doPatch).
All attributes can be changed when the readOnly attribute is true and make corresponding change in pldmtool & D-Bus also.
Tested: busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager org.freedesktop.DBus.Properties Set ssv xyz.openbmc_project.BIOSConfig.Manager PendingAttributes a{s\(sv\)} 1 "pvm_system_name" "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String" s "XXX"
busctl get-property xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager xyz.openbmc_project.BIOSConfig.Manager BaseBIOSTable --verbose ... DICT_ENTRY "s(sbsssvva(sv))" { STRING "pvm_system_name"; STRUCT "sbsssvva(sv)" { STRING "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String"; BOOLEAN false; STRING "pvm_system_name"; STRING "pvm_system_name"; STRING ""; VARIANT "s" { STRING "XXX"; }; VARIANT "s" { STRING ""; }; ARRAY "(sv)" { STRUCT "sv" { STRING "xyz.openbmc_project.BIOSConfig.Manager.BoundType.MinStringLength"; VARIANT "x" { INT64 0; }; }; STRUCT "sv" { STRING "xyz.openbmc_project.BIOSConfig.Manager.BoundType.MaxStringLength"; VARIANT "x" { INT64 100; }; }; }; }; }; ...
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I70ceeff2859d6c8b56690e04018bdf0b23427042
show more ...
|
5e2cb720 | 26-May-2021 |
Snehalatha Venkatesh <snehalathax.v@intel.com> |
Change Resetflag from default to Noaction
Change Resetflag from default to Noaction as BMC have to clear the default reset bios settings flag whenever new BaseTable is received from BIOS or else BIO
Change Resetflag from default to Noaction
Change Resetflag from default to Noaction as BMC have to clear the default reset bios settings flag whenever new BaseTable is received from BIOS or else BIOS will keep reset the system with default values.
Tested: Ran unit test cases and manually tested with commands. When new BaseTable is created, ResetBIOS setting will set the flag to NoAction.
Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com> Change-Id: Iea029b1a5a3d97c7f19bc21851972fdc5599cb8d
show more ...
|
96e72ec5 | 20-May-2021 |
Ayushi Smriti <smriti.ayushi@linux.intel.com> |
oob bios config ChangePassword Action support
Change Password ACTION was not working as expected. This implementation adds change password support in oob bios config to enable admin password change
oob bios config ChangePassword Action support
Change Password ACTION was not working as expected. This implementation adds change password support in oob bios config to enable admin password change via Redfish. Also, password storing file is removed and only hash is required to be stored in seedData File.
Tested: -Set the BIOS password via Set BIOS Pwd hash cmd via KCS interface -Change BIOS Admin password via Change Password ACTION in Redfish -Run the Get stored Pwd hash command via KCS interface -Could get the updated admin password hash and admin Password Flag gets set to true -Verified the updated changes in seedData file as well
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com> Change-Id: If23416d66f1a2daa4292113b899d180fc7bb2894
show more ...
|
8f706213 | 16-Dec-2020 |
Kuiying Wang <kuiying.wang@intel.com> |
oob bios config password and bios reset
Tested: 1. Bios reset flag can be modified throw redfish POST https://IP_ADDR/redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios { "ResetFlag": "Factor
oob bios config password and bios reset
Tested: 1. Bios reset flag can be modified throw redfish POST https://IP_ADDR/redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios { "ResetFlag": "Factory" } root@intel-obmc:~# busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager org.freedesktop.DBus.Properties Get ss xyz.openbmc_project.BIOSConfig.Manager ResetBIOSSettings v s "xyz.openbmc_project.BIOSConfig.Manager.ResetFlag.FactoryDefaults"
2. Bios change password: root@intel-obmc:~# cat /var/lib/bios-settings-manager/seedData { "UserPwdHash": "08D91157785366CDC3AA64D87E5E3C621EDAB13E26B6E484397EBA5E459E54C567BF5B1FFB36A43B6142B18F8D642E9D", "AdminPwdHash": "08D91157785366CDC3AA64D87E5E3C621EDAB13E26B6E484397EBA5E459E54C567BF5B1FFB36A43B6142B18F8D642E9D", "Seed": "123456", "HashAlgo": "SHA384" } POST https://IP_ADDR/redfish/v1/Systems/system/Bios/Actions/Bios.ChangePassword { "NewPassword": "12345678", "OldPassword": "1234567890", "PasswordName": "Administrator" } root@intel-obmc:~# cat /var/lib/bios-settings-manager/passwordData { "CurrentPassword": "1234567890", "IsAdminPwdChanged": 1, "IsUserPwdChanged": 0, "NewPassword": "2DD65D57EB60B1D92C5F3D2DC84724FCEE7BC02E57AA75E834712266ED94CAC704047B2FF7CEC1C36BED280B36BB5AC6", "UserName": "Administrator" }
Change-Id: Ib54b36819e49c891c6169c95d9cdaebd5bcb06f3 Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
show more ...
|