clang-tidy: Customize Configuration

The .clang-tidy file has been updated to align with the recommended
clang-tidy categories for C++ projects in OpenBMC. All recommended
categories are enabled, and

clang-tidy: Customize Configuration

The .clang-tidy file has been updated to align with the recommended
clang-tidy categories for C++ projects in OpenBMC. All recommended
categories are enabled, and failing checks are disabled by prefixing
them with a '-'.

This approach allows to improve coverage by enabling failing checks
and making necessary code changes to fix failures over time.

Tested: Build and unit tests verified.

Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
Change-Id: Ief641712880303f6763aeed21169ecbe80119f5a

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I8c80f196fb4c3ed7c49e0603581e763143cf2b0d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove all operational logs

Only error messages shall emit logs

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I54198f36531f3deb5f9ca57f8b7caece2fbcc065

external_storer: Add a log entry limit

This is to ensure that we don't get uncapped log entries. Default is set
to the first 20 logs being saved, and the next 980 being in a circualr
queue (1000 ent

external_storer: Add a log entry limit

This is to ensure that we don't get uncapped log entries. Default is set
to the first 20 logs being saved, and the next 980 being in a circualr
queue (1000 entries in total).

Tested:
Added unit test to ensure that the queue works as intended. Also
verified by injecting 1000 entries to ensure that the buffer indeed
saves the first 20, and caps it 1000.

```
//LogEntry1:
Created: ...Entries/66a97808-1e22-4c1e-b0f6-4b9eb7c714e7/index.json
...
//LogEntry20:
Created: ...Entries/9c07937a-9524-40f1-acef-19db73b46678/index.json
//LogEntry21:
Created: ...Entries/0bfb7ede-8020-4613-bfcf-5815ca176c79/index.json
...
//LogEntry1001:
Removed: ...Entries/0bfb7ede-8020-4613-bfcf-5815ca176c79
Created: ...Entries/31bdf3be-1e87-4e77-922d-9bbac09ac824/index.json
```

We can see that starting on the 1001st log, log entry 21 is deleted to
make room.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ic2badd7f01741d788cad829c9e203b7c4962fc8e

show more ...

notifier_dbus_handler: Remove the vector

This vector isn't needed, as we only use the D-Bus object to notify the
phosphor-dump-manager.

Tested:
Verified on a local machine that the dump manager sti

notifier_dbus_handler: Remove the vector

This vector isn't needed, as we only use the D-Bus object to notify the
phosphor-dump-manager.

Tested:
Verified on a local machine that the dump manager still detects the
new D-Bus path.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: If8fb12554f5015377c71c56e1f059c14c3865661

show more ...

Modify D-Bus to using asio server

DBus updates are now using the asio server way.

Tested:
Tested with unit tests and locally on a machine.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Cha

Modify D-Bus to using asio server

DBus updates are now using the asio server way.

Tested:
Tested with unit tests and locally on a machine.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I77553bcc3baae70e5d684a62f2c19592ff844665
Signed-off-by: Brandon Kim <brandonkim@google.com>

show more ...

clang-tidy: Remove redundant configuration

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I33d4c33690ead9af8ce1b116b142667ffc82c758

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I61c7e22e726dbab6c7f3da43270adbdb9b4927fb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prefer std::format over fmt

Use std::format or stdplus::print and eliminate the fmt dependency.

Change-Id: Ide14b682949914f09f749141196cdb210fe1239e
Signed-off-by: Patrick Williams <patrick@stwcx.x

prefer std::format over fmt

Use std::format or stdplus::print and eliminate the fmt dependency.

Change-Id: Ide14b682949914f09f749141196cdb210fe1239e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: add subproject wrap files

The repository isn't buildable in a meson wrapfile mode without two
missing dependencies: phosphor-dbus-interfaces and sdbusplus. Add wrap
files for both of them.

meson: add subproject wrap files

The repository isn't buildable in a meson wrapfile mode without two
missing dependencies: phosphor-dbus-interfaces and sdbusplus. Add wrap
files for both of them.

Change-Id: Idec177b8a7b08a665aa03d353122055b7edc157e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

external_storer_file: Add logging for created file

It's hard to debug exactly what error was passed in from the payload
size. Add file creation path to the debug message for better debugging

Tested

external_storer_file: Add logging for created file

It's hard to debug exactly what error was passed in from the payload
size. Add file creation path to the debug message for better debugging

Tested:
root@iacpr4-nfd01:~# journalctl -b |grep bios-bmc
bios-bmc-smm-error-logger[435]: Read an entry of '235' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '228' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '369' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '90' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '2454' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '307' bytes
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/LogServices/Log1/index.json
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/LogServices/Log1/Entries/index.json
bios-bmc-smm-error-logger[435]: Read an entry of '178' bytes
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/Memory/dimm6/MemoryMetrics/index.json
bios-bmc-smm-error-logger[435]: Read an entry of '1046' bytes
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/LogServices/Log1/Entries/
d311e785-8245-4cc5-8de1-cb103bd4c0a3/index.json

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I18e89eb1e46a507da425b83962f42f7e64a6adbb

show more ...

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json in the meson.build and align with the usage
in other repositories.

Change-Id: I8daf46711bdfcec30bb38a32324046f6b717aa33
Signed-off-

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json in the meson.build and align with the usage
in other repositories.

Change-Id: I8daf46711bdfcec30bb38a32324046f6b717aa33
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I36e9219ec764c9fddb762

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I36e9219ec764c9fddb762f323ee812223df36172
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ff0bc6d39e0c53b1fc37cf790fa88ebcfdea680
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1f25f2e08b77e896e8f06d59f3d5d4966f8bb4a

show more ...

buffer: Update to follow the design doc

queueSize and ueRegionSize should not change at runtime. Make it so that
it throws if these constants fail any time we try to use them as it
means that the bu

buffer: Update to follow the design doc

queueSize and ueRegionSize should not change at runtime. Make it so that
it throws if these constants fail any time we try to use them as it
means that the buffer was overwritten (possibly by a bad actor).

Update the default queueSize and ueRegionSize to match our test
variables.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I2c906d26016ce6eb19e953ae432abd5482b6ccf8

show more ...

Add nlohmann dependency

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8b0a1c01d05b053fc0669f626a975f406d88549a

Update gitignore dependency

Update the .gitignore to ignore the subproject source directories.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I195dc4536fd6c5d893e9367b2d1b64819e590897

build-tests: The allowed method is used by default

The allowed method returns true when the feature is set to `enabled`
or `auto`.
The allowed method returns false when the feature is set to
`disabl

build-tests: The allowed method is used by default

The allowed method returns true when the feature is set to `enabled`
or `auto`.
The allowed method returns false when the feature is set to
`disabled`.
So we prefer to use the `allowed` method instead of `enabled`.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ie729807e5e08b904f8c677aead222d5965e13a04

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I8f5382f5868ca19781c2327a3e69f02118975a25
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I16a6ed1a6d4dfdd367464a087fa0f3d23b0d588f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Restart daemon on failure

If the daemon crashes, then we lose the daemon's functionality.
Restarting on failure would allow the daemon to still continue working.

Tested: Locally on QEMU

Change-Id:

Restart daemon on failure

If the daemon crashes, then we lose the daemon's functionality.
Restarting on failure would allow the daemon to still continue working.

Tested: Locally on QEMU

Change-Id: I8fadc45941a11e294f3928549d82a19cd5869c91
Signed-off-by: Edward Lee <edwarddl@google.com>

show more ...

Remove unused variables

Jenkins presubmit fails for all commits right now due to certain unused
variables. This commit aims to pass presubmit without regressing
functionality.

Tested: Presubmit pas

Remove unused variables

Jenkins presubmit fails for all commits right now due to certain unused
variables. This commit aims to pass presubmit without regressing
functionality.

Tested: Presubmit passes

Change-Id: Ifdc7081b1154ce3ac2f3ab0828429660db35360a
Signed-off-by: Edward Lee <edwarddl@google.com>

show more ...

Add missing RDE definitions

In the previous commit, some RDE definitions were moved to this
repo from libbej repo but some definitions were missed.
This CL adds the missing definitions.

Signed-off-

Add missing RDE definitions

In the previous commit, some RDE definitions were moved to this
repo from libbej repo but some definitions were missed.
This CL adds the missing definitions.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I00c63a5ccb02dc3dfe3018d343a633458ef23c14

show more ...

Locally define used RDE headers

2 RDE headers used by bios-bmc-smm-error-logger are being removed from
libbej repo. Also bios-bmc-smm-error-logger doesn't use RDE protocol.
It simply uses 2 RDE head

Locally define used RDE headers

2 RDE headers used by bios-bmc-smm-error-logger are being removed from
libbej repo. Also bios-bmc-smm-error-logger doesn't use RDE protocol.
It simply uses 2 RDE headers to encapsulate data sent from BIOS.
Therefore this change defines the RDE headers (removed from libbej)
locally.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I9d0dfd669283bee6443e9d542b941bf73787fe95

show more ...