prefer std::format over fmt

Use std::format or stdplus::print and eliminate the fmt dependency.

Change-Id: Ide14b682949914f09f749141196cdb210fe1239e
Signed-off-by: Patrick Williams <patrick@stwcx.x

prefer std::format over fmt

Use std::format or stdplus::print and eliminate the fmt dependency.

Change-Id: Ide14b682949914f09f749141196cdb210fe1239e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: add subproject wrap files

The repository isn't buildable in a meson wrapfile mode without two
missing dependencies: phosphor-dbus-interfaces and sdbusplus. Add wrap
files for both of them.

meson: add subproject wrap files

The repository isn't buildable in a meson wrapfile mode without two
missing dependencies: phosphor-dbus-interfaces and sdbusplus. Add wrap
files for both of them.

Change-Id: Idec177b8a7b08a665aa03d353122055b7edc157e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

external_storer_file: Add logging for created file

It's hard to debug exactly what error was passed in from the payload
size. Add file creation path to the debug message for better debugging

Tested

external_storer_file: Add logging for created file

It's hard to debug exactly what error was passed in from the payload
size. Add file creation path to the debug message for better debugging

Tested:
root@iacpr4-nfd01:~# journalctl -b |grep bios-bmc
bios-bmc-smm-error-logger[435]: Read an entry of '235' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '228' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '369' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '90' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '2454' bytes
bios-bmc-smm-error-logger[435]: Read an entry of '307' bytes
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/LogServices/Log1/index.json
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/LogServices/Log1/Entries/index.json
bios-bmc-smm-error-logger[435]: Read an entry of '178' bytes
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/Memory/dimm6/MemoryMetrics/index.json
bios-bmc-smm-error-logger[435]: Read an entry of '1046' bytes
bios-bmc-smm-error-logger[435]: Created: /run/bmcweb/redfish/v1/
Systems/system/LogServices/Log1/Entries/
d311e785-8245-4cc5-8de1-cb103bd4c0a3/index.json

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I18e89eb1e46a507da425b83962f42f7e64a6adbb

show more ...

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json in the meson.build and align with the usage
in other repositories.

Change-Id: I8daf46711bdfcec30bb38a32324046f6b717aa33
Signed-off-

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json in the meson.build and align with the usage
in other repositories.

Change-Id: I8daf46711bdfcec30bb38a32324046f6b717aa33
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I36e9219ec764c9fddb762

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I36e9219ec764c9fddb762f323ee812223df36172
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ff0bc6d39e0c53b1fc37cf790fa88ebcfdea680
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1f25f2e08b77e896e8f06d59f3d5d4966f8bb4a

show more ...

buffer: Update to follow the design doc

queueSize and ueRegionSize should not change at runtime. Make it so that
it throws if these constants fail any time we try to use them as it
means that the bu

buffer: Update to follow the design doc

queueSize and ueRegionSize should not change at runtime. Make it so that
it throws if these constants fail any time we try to use them as it
means that the buffer was overwritten (possibly by a bad actor).

Update the default queueSize and ueRegionSize to match our test
variables.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I2c906d26016ce6eb19e953ae432abd5482b6ccf8

show more ...

Add nlohmann dependency

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8b0a1c01d05b053fc0669f626a975f406d88549a

Update gitignore dependency

Update the .gitignore to ignore the subproject source directories.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I195dc4536fd6c5d893e9367b2d1b64819e590897

build-tests: The allowed method is used by default

The allowed method returns true when the feature is set to `enabled`
or `auto`.
The allowed method returns false when the feature is set to
`disabl

build-tests: The allowed method is used by default

The allowed method returns true when the feature is set to `enabled`
or `auto`.
The allowed method returns false when the feature is set to
`disabled`.
So we prefer to use the `allowed` method instead of `enabled`.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ie729807e5e08b904f8c677aead222d5965e13a04

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I8f5382f5868ca19781c2327a3e69f02118975a25
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I16a6ed1a6d4dfdd367464a087fa0f3d23b0d588f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Restart daemon on failure

If the daemon crashes, then we lose the daemon's functionality.
Restarting on failure would allow the daemon to still continue working.

Tested: Locally on QEMU

Change-Id:

Restart daemon on failure

If the daemon crashes, then we lose the daemon's functionality.
Restarting on failure would allow the daemon to still continue working.

Tested: Locally on QEMU

Change-Id: I8fadc45941a11e294f3928549d82a19cd5869c91
Signed-off-by: Edward Lee <edwarddl@google.com>

show more ...

Remove unused variables

Jenkins presubmit fails for all commits right now due to certain unused
variables. This commit aims to pass presubmit without regressing
functionality.

Tested: Presubmit pas

Remove unused variables

Jenkins presubmit fails for all commits right now due to certain unused
variables. This commit aims to pass presubmit without regressing
functionality.

Tested: Presubmit passes

Change-Id: Ifdc7081b1154ce3ac2f3ab0828429660db35360a
Signed-off-by: Edward Lee <edwarddl@google.com>

show more ...

Add missing RDE definitions

In the previous commit, some RDE definitions were moved to this
repo from libbej repo but some definitions were missed.
This CL adds the missing definitions.

Signed-off-

Add missing RDE definitions

In the previous commit, some RDE definitions were moved to this
repo from libbej repo but some definitions were missed.
This CL adds the missing definitions.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I00c63a5ccb02dc3dfe3018d343a633458ef23c14

show more ...

Locally define used RDE headers

2 RDE headers used by bios-bmc-smm-error-logger are being removed from
libbej repo. Also bios-bmc-smm-error-logger doesn't use RDE protocol.
It simply uses 2 RDE head

Locally define used RDE headers

2 RDE headers used by bios-bmc-smm-error-logger are being removed from
libbej repo. Also bios-bmc-smm-error-logger doesn't use RDE protocol.
It simply uses 2 RDE headers to encapsulate data sent from BIOS.
Therefore this change defines the RDE headers (removed from libbej)
locally.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I9d0dfd669283bee6443e9d542b941bf73787fe95

show more ...

meson: fix typo

Tested: N/A
Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: I915f9be78628e815fef21c7e1235e9c7d7bc7992

buffer: Update the definition of QueueSize

There were confusion whether the QueueSize field represented just the
queue for the normal log or if it represented the whole circular buffer.
Settled on i

buffer: Update the definition of QueueSize

There were confusion whether the QueueSize field represented just the
queue for the normal log or if it represented the whole circular buffer.
Settled on it being the whole circular buffer.

Tested: Unit tested and verified this works on a downstream machine

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I867e997b72500c7bcd03047d8eb3e4db146a8add

show more ...

buffer: Fix a corner case with header wraparound

Update the unit test so that we cover this corner case + update the API
so that we no longer pass in the offset manually.

Tested: Unit test coverage

buffer: Fix a corner case with header wraparound

Update the unit test so that we cover this corner case + update the API
so that we no longer pass in the offset manually.

Tested: Unit test coverage + integration test with our downstream
platform that found this issue

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I6b0a7974f902e0248bfb4932237176df20fdaf61

show more ...

README: Update to point to the actual design doc

It was previously pointing to the gerrit review for the design doc.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Iddc7dc2983ce20c34

README: Update to point to the actual design doc

It was previously pointing to the gerrit review for the design doc.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Iddc7dc2983ce20c346d8e12a5716d5e28d09bacf

show more ...

buffer: Update queueSize and Read/Write Ptrs to 3B

This allows for bigger Queue size than 64KB.

Tested: Verified this with a new BIOS

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id:

buffer: Update queueSize and Read/Write Ptrs to 3B

This allows for bigger Queue size than 64KB.

Tested: Verified this with a new BIOS

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I558a24c3b2500754424bdad6459244279592238b

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2572a01b069437e917c6def45dcf5016dff04e2

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I17807e986cefa6a3d9e757c533ac373035438aed

show more ...

Create a DBus notification for each LogEntry

For each log entry, a new FilePath DBus object will be created where
the FilePath.path value is the location of the JSON LogEntry file.

Tested:
Tested w

Create a DBus notification for each LogEntry

For each log entry, a new FilePath DBus object will be created where
the FilePath.path value is the location of the JSON LogEntry file.

Tested:
Tested with unit tests and locally on a machine.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I5999826f7b4447bfca88b83c487d7c03a1c84a08

show more ...