xref: /openbmc/u-boot/tools/patman/test.py (revision 014a953c)
1# -*- coding: utf-8 -*-
2#
3# Copyright (c) 2011 The Chromium OS Authors.
4#
5# SPDX-License-Identifier:	GPL-2.0+
6#
7
8import os
9import tempfile
10import unittest
11
12import checkpatch
13import gitutil
14import patchstream
15import series
16
17
18class TestPatch(unittest.TestCase):
19    """Test this program
20
21    TODO: Write tests for the rest of the functionality
22    """
23
24    def testBasic(self):
25        """Test basic filter operation"""
26        data='''
27
28From 656c9a8c31fa65859d924cd21da920d6ba537fad Mon Sep 17 00:00:00 2001
29From: Simon Glass <sjg@chromium.org>
30Date: Thu, 28 Apr 2011 09:58:51 -0700
31Subject: [PATCH (resend) 3/7] Tegra2: Add more clock support
32
33This adds functions to enable/disable clocks and reset to on-chip peripherals.
34
35cmd/pci.c:152:11: warning: format ‘%llx’ expects argument of type
36   ‘long long unsigned int’, but argument 3 has type
37   ‘u64 {aka long unsigned int}’ [-Wformat=]
38
39BUG=chromium-os:13875
40TEST=build U-Boot for Seaboard, boot
41
42Change-Id: I80fe1d0c0b7dd10aa58ce5bb1d9290b6664d5413
43
44Review URL: http://codereview.chromium.org/6900006
45
46Signed-off-by: Simon Glass <sjg@chromium.org>
47---
48 arch/arm/cpu/armv7/tegra2/Makefile         |    2 +-
49 arch/arm/cpu/armv7/tegra2/ap20.c           |   57 ++----
50 arch/arm/cpu/armv7/tegra2/clock.c          |  163 +++++++++++++++++
51'''
52        expected='''
53
54From 656c9a8c31fa65859d924cd21da920d6ba537fad Mon Sep 17 00:00:00 2001
55From: Simon Glass <sjg@chromium.org>
56Date: Thu, 28 Apr 2011 09:58:51 -0700
57Subject: [PATCH (resend) 3/7] Tegra2: Add more clock support
58
59This adds functions to enable/disable clocks and reset to on-chip peripherals.
60
61cmd/pci.c:152:11: warning: format ‘%llx’ expects argument of type
62   ‘long long unsigned int’, but argument 3 has type
63   ‘u64 {aka long unsigned int}’ [-Wformat=]
64
65Signed-off-by: Simon Glass <sjg@chromium.org>
66---
67
68 arch/arm/cpu/armv7/tegra2/Makefile         |    2 +-
69 arch/arm/cpu/armv7/tegra2/ap20.c           |   57 ++----
70 arch/arm/cpu/armv7/tegra2/clock.c          |  163 +++++++++++++++++
71'''
72        out = ''
73        inhandle, inname = tempfile.mkstemp()
74        infd = os.fdopen(inhandle, 'w')
75        infd.write(data)
76        infd.close()
77
78        exphandle, expname = tempfile.mkstemp()
79        expfd = os.fdopen(exphandle, 'w')
80        expfd.write(expected)
81        expfd.close()
82
83        patchstream.FixPatch(None, inname, series.Series(), None)
84        rc = os.system('diff -u %s %s' % (inname, expname))
85        self.assertEqual(rc, 0)
86
87        os.remove(inname)
88        os.remove(expname)
89
90    def GetData(self, data_type):
91        data='''From 4924887af52713cabea78420eff03badea8f0035 Mon Sep 17 00:00:00 2001
92From: Simon Glass <sjg@chromium.org>
93Date: Thu, 7 Apr 2011 10:14:41 -0700
94Subject: [PATCH 1/4] Add microsecond boot time measurement
95
96This defines the basics of a new boot time measurement feature. This allows
97logging of very accurate time measurements as the boot proceeds, by using
98an available microsecond counter.
99
100%s
101---
102 README              |   11 ++++++++
103 MAINTAINERS         |    3 ++
104 common/bootstage.c  |   50 ++++++++++++++++++++++++++++++++++++
105 include/bootstage.h |   71 +++++++++++++++++++++++++++++++++++++++++++++++++++
106 include/common.h    |    8 ++++++
107 5 files changed, 141 insertions(+), 0 deletions(-)
108 create mode 100644 common/bootstage.c
109 create mode 100644 include/bootstage.h
110
111diff --git a/README b/README
112index 6f3748d..f9e4e65 100644
113--- a/README
114+++ b/README
115@@ -2026,6 +2026,17 @@ The following options need to be configured:
116 		example, some LED's) on your board. At the moment,
117 		the following checkpoints are implemented:
118
119+- Time boot progress
120+		CONFIG_BOOTSTAGE
121+
122+		Define this option to enable microsecond boot stage timing
123+		on supported platforms. For this to work your platform
124+		needs to define a function timer_get_us() which returns the
125+		number of microseconds since reset. This would normally
126+		be done in your SOC or board timer.c file.
127+
128+		You can add calls to bootstage_mark() to set time markers.
129+
130 - Standalone program support:
131 		CONFIG_STANDALONE_LOAD_ADDR
132
133diff --git a/MAINTAINERS b/MAINTAINERS
134index b167b028ec..beb7dc634f 100644
135--- a/MAINTAINERS
136+++ b/MAINTAINERS
137@@ -474,3 +474,8 @@ S:	Maintained
138 T:	git git://git.denx.de/u-boot.git
139 F:	*
140 F:	*/
141+
142+BOOTSTAGE
143+M:	Simon Glass <sjg@chromium.org>
144+L:	u-boot@lists.denx.de
145+F:	common/bootstage.c
146diff --git a/common/bootstage.c b/common/bootstage.c
147new file mode 100644
148index 0000000..2234c87
149--- /dev/null
150+++ b/common/bootstage.c
151@@ -0,0 +1,37 @@
152+/*
153+ * Copyright (c) 2011, Google Inc. All rights reserved.
154+ *
155+ * SPDX-License-Identifier:	GPL-2.0+
156+ */
157+
158+/*
159+ * This module records the progress of boot and arbitrary commands, and
160+ * permits accurate timestamping of each. The records can optionally be
161+ * passed to kernel in the ATAGs
162+ */
163+
164+#include <common.h>
165+
166+struct bootstage_record {
167+	u32 time_us;
168+	const char *name;
169+};
170+
171+static struct bootstage_record record[BOOTSTAGE_COUNT];
172+
173+u32 bootstage_mark(enum bootstage_id id, const char *name)
174+{
175+	struct bootstage_record *rec = &record[id];
176+
177+	/* Only record the first event for each */
178+%sif (!rec->name) {
179+		rec->time_us = (u32)timer_get_us();
180+		rec->name = name;
181+	}
182+	if (!rec->name &&
183+	%ssomething_else) {
184+		rec->time_us = (u32)timer_get_us();
185+		rec->name = name;
186+	}
187+%sreturn rec->time_us;
188+}
189--
1901.7.3.1
191'''
192        signoff = 'Signed-off-by: Simon Glass <sjg@chromium.org>\n'
193        tab = '	'
194        indent = '    '
195        if data_type == 'good':
196            pass
197        elif data_type == 'no-signoff':
198            signoff = ''
199        elif data_type == 'spaces':
200            tab = '   '
201        elif data_type == 'indent':
202            indent = tab
203        else:
204            print('not implemented')
205        return data % (signoff, tab, indent, tab)
206
207    def SetupData(self, data_type):
208        inhandle, inname = tempfile.mkstemp()
209        infd = os.fdopen(inhandle, 'w')
210        data = self.GetData(data_type)
211        infd.write(data)
212        infd.close()
213        return inname
214
215    def testGood(self):
216        """Test checkpatch operation"""
217        inf = self.SetupData('good')
218        result = checkpatch.CheckPatch(inf)
219        self.assertEqual(result.ok, True)
220        self.assertEqual(result.problems, [])
221        self.assertEqual(result.errors, 0)
222        self.assertEqual(result.warnings, 0)
223        self.assertEqual(result.checks, 0)
224        self.assertEqual(result.lines, 62)
225        os.remove(inf)
226
227    def testNoSignoff(self):
228        inf = self.SetupData('no-signoff')
229        result = checkpatch.CheckPatch(inf)
230        self.assertEqual(result.ok, False)
231        self.assertEqual(len(result.problems), 1)
232        self.assertEqual(result.errors, 1)
233        self.assertEqual(result.warnings, 0)
234        self.assertEqual(result.checks, 0)
235        self.assertEqual(result.lines, 62)
236        os.remove(inf)
237
238    def testSpaces(self):
239        inf = self.SetupData('spaces')
240        result = checkpatch.CheckPatch(inf)
241        self.assertEqual(result.ok, False)
242        self.assertEqual(len(result.problems), 3)
243        self.assertEqual(result.errors, 0)
244        self.assertEqual(result.warnings, 3)
245        self.assertEqual(result.checks, 0)
246        self.assertEqual(result.lines, 62)
247        os.remove(inf)
248
249    def testIndent(self):
250        inf = self.SetupData('indent')
251        result = checkpatch.CheckPatch(inf)
252        self.assertEqual(result.ok, False)
253        self.assertEqual(len(result.problems), 1)
254        self.assertEqual(result.errors, 0)
255        self.assertEqual(result.warnings, 0)
256        self.assertEqual(result.checks, 1)
257        self.assertEqual(result.lines, 62)
258        os.remove(inf)
259
260
261if __name__ == "__main__":
262    unittest.main()
263    gitutil.RunTests()
264