1*c9537f57SPatrick WilliamsFrom 1dc81f272855d94e6a78f7d10ea952745d991aa9 Mon Sep 17 00:00:00 2001
2*c9537f57SPatrick WilliamsFrom: Bin Lan <bin.lan.cn@windriver.com>
3*c9537f57SPatrick WilliamsDate: Tue, 11 Mar 2025 17:19:11 +0800
4*c9537f57SPatrick WilliamsSubject: [PATCH] Tests: fix test applications in cpp-common are needed to
5*c9537f57SPatrick Williams re-build
6*c9537f57SPatrick Williams
7*c9537f57SPatrick WilliamsTest applications in cpp-common directory are needed to re-build when
8*c9537f57SPatrick Williamscalling make check in embedded system. The following error is shown
9*c9537f57SPatrick Williamswhen running test applications:
10*c9537f57SPatrick Williamsmake[3]: *** No rule to make target 'cpp-common/test-c-string-view.cpp',
11*c9537f57SPatrick Williamsneeded by 'cpp-common/test-c-string-view.o'.
12*c9537f57SPatrick Williamsmake[3]: *** No rule to make target '../tests/utils/tap/libtap.la',
13*c9537f57SPatrick Williamsneeded by 'cpp-common/test-c-string-view'.
14*c9537f57SPatrick Williamsmake[3]: *** No rule to make target '../src/common/libcommon.la',
15*c9537f57SPatrick Williamsneeded by 'cpp-common/test-c-string-view'.
16*c9537f57SPatrick Williamsmake[3]: *** No rule to make target '../src/logging/liblogging.la',
17*c9537f57SPatrick Williamsneeded by 'cpp-common/test-c-string-view'.
18*c9537f57SPatrick Williams...
19*c9537f57SPatrick Williamsmake[2]: *** [Makefile:1274: check-TESTS] Error 2
20*c9537f57SPatrick Williamsmake[1]: *** [Makefile:1805: check-am] Error 2
21*c9537f57SPatrick Williamsmake: *** [Makefile:1033: check-recursive] Error 1
22*c9537f57SPatrick Williamsmake: Target 'check' not remade because of errors.
23*c9537f57SPatrick Williams
24*c9537f57SPatrick WilliamsCreate some new shell scripts which are used to call test applications
25*c9537f57SPatrick Williamsin cpp-common directory. Then these test applications can run without
26*c9537f57SPatrick Williamsactually examining the source code.
27*c9537f57SPatrick Williams
28*c9537f57SPatrick WilliamsUpstream-Status: Submitted [https://review.lttng.org/c/babeltrace/+/14213]
29*c9537f57SPatrick Williams
30*c9537f57SPatrick WilliamsSigned-off-by: Bin Lan <bin.lan.cn@windriver.com>
31*c9537f57SPatrick Williams---
32*c9537f57SPatrick Williams tests/Makefile.am                      |  6 +++---
33*c9537f57SPatrick Williams tests/cpp-common/test-c-string-view.sh | 17 +++++++++++++++++
34*c9537f57SPatrick Williams tests/cpp-common/test-unicode-conv.sh  | 17 +++++++++++++++++
35*c9537f57SPatrick Williams tests/cpp-common/test-uuid.sh          | 17 +++++++++++++++++
36*c9537f57SPatrick Williams 4 files changed, 54 insertions(+), 3 deletions(-)
37*c9537f57SPatrick Williams create mode 100755 tests/cpp-common/test-c-string-view.sh
38*c9537f57SPatrick Williams create mode 100755 tests/cpp-common/test-unicode-conv.sh
39*c9537f57SPatrick Williams create mode 100755 tests/cpp-common/test-uuid.sh
40*c9537f57SPatrick Williams
41*c9537f57SPatrick Williamsdiff --git a/tests/Makefile.am b/tests/Makefile.am
42*c9537f57SPatrick Williamsindex 2a4022bc4..c79b77b32 100644
43*c9537f57SPatrick Williams--- a/tests/Makefile.am
44*c9537f57SPatrick Williams+++ b/tests/Makefile.am
45*c9537f57SPatrick Williams@@ -129,9 +129,9 @@ cpp_common_test_unicode_conv_LDADD = \
46*c9537f57SPatrick Williams 	$(COMMON_TEST_LDADD)
47*c9537f57SPatrick Williams
48*c9537f57SPatrick Williams TESTS_CPP_COMMON = \
49*c9537f57SPatrick Williams-	cpp-common/test-c-string-view \
50*c9537f57SPatrick Williams-	cpp-common/test-uuid \
51*c9537f57SPatrick Williams-	cpp-common/test-unicode-conv
52*c9537f57SPatrick Williams+	cpp-common/test-c-string-view.sh \
53*c9537f57SPatrick Williams+	cpp-common/test-uuid.sh \
54*c9537f57SPatrick Williams+	cpp-common/test-unicode-conv.sh
55*c9537f57SPatrick Williams
56*c9537f57SPatrick Williams TESTS_LIB = \
57*c9537f57SPatrick Williams 	lib/test-bt-uuid \
58*c9537f57SPatrick Williamsdiff --git a/tests/cpp-common/test-c-string-view.sh b/tests/cpp-common/test-c-string-view.sh
59*c9537f57SPatrick Williamsnew file mode 100755
60*c9537f57SPatrick Williamsindex 000000000..9c2ca5818
61*c9537f57SPatrick Williams--- /dev/null
62*c9537f57SPatrick Williams+++ b/tests/cpp-common/test-c-string-view.sh
63*c9537f57SPatrick Williams@@ -0,0 +1,17 @@
64*c9537f57SPatrick Williams+#!/bin/bash
65*c9537f57SPatrick Williams+#
66*c9537f57SPatrick Williams+# SPDX-License-Identifier: GPL-2.0-only
67*c9537f57SPatrick Williams+#
68*c9537f57SPatrick Williams+# Copyright (C) 2025 Bin Lan <bin.lan.cn@windriver.com>
69*c9537f57SPatrick Williams+#
70*c9537f57SPatrick Williams+
71*c9537f57SPatrick Williams+if [ -n "${BT_TESTS_SRCDIR:-}" ]; then
72*c9537f57SPatrick Williams+	UTILSSH="$BT_TESTS_SRCDIR/utils/utils.sh"
73*c9537f57SPatrick Williams+else
74*c9537f57SPatrick Williams+	UTILSSH="$(dirname "$0")/../utils/utils.sh"
75*c9537f57SPatrick Williams+fi
76*c9537f57SPatrick Williams+
77*c9537f57SPatrick Williams+# shellcheck source=../utils/utils.sh
78*c9537f57SPatrick Williams+source "$UTILSSH"
79*c9537f57SPatrick Williams+
80*c9537f57SPatrick Williams+"${BT_TESTS_BUILDDIR}/cpp-common/test-c-string-view" "$BT_TESTS_BT2_BIN"
81*c9537f57SPatrick Williamsdiff --git a/tests/cpp-common/test-unicode-conv.sh b/tests/cpp-common/test-unicode-conv.sh
82*c9537f57SPatrick Williamsnew file mode 100755
83*c9537f57SPatrick Williamsindex 000000000..df490b2eb
84*c9537f57SPatrick Williams--- /dev/null
85*c9537f57SPatrick Williams+++ b/tests/cpp-common/test-unicode-conv.sh
86*c9537f57SPatrick Williams@@ -0,0 +1,17 @@
87*c9537f57SPatrick Williams+#!/bin/bash
88*c9537f57SPatrick Williams+#
89*c9537f57SPatrick Williams+# SPDX-License-Identifier: GPL-2.0-only
90*c9537f57SPatrick Williams+#
91*c9537f57SPatrick Williams+# Copyright (C) 2025 Bin Lan <bin.lan.cn@windriver.com>
92*c9537f57SPatrick Williams+#
93*c9537f57SPatrick Williams+
94*c9537f57SPatrick Williams+if [ -n "${BT_TESTS_SRCDIR:-}" ]; then
95*c9537f57SPatrick Williams+	UTILSSH="$BT_TESTS_SRCDIR/utils/utils.sh"
96*c9537f57SPatrick Williams+else
97*c9537f57SPatrick Williams+	UTILSSH="$(dirname "$0")/../utils/utils.sh"
98*c9537f57SPatrick Williams+fi
99*c9537f57SPatrick Williams+
100*c9537f57SPatrick Williams+# shellcheck source=../utils/utils.sh
101*c9537f57SPatrick Williams+source "$UTILSSH"
102*c9537f57SPatrick Williams+
103*c9537f57SPatrick Williams+"${BT_TESTS_BUILDDIR}/cpp-common/test-unicode-conv" "$BT_TESTS_BT2_BIN"
104*c9537f57SPatrick Williamsdiff --git a/tests/cpp-common/test-uuid.sh b/tests/cpp-common/test-uuid.sh
105*c9537f57SPatrick Williamsnew file mode 100755
106*c9537f57SPatrick Williamsindex 000000000..8c65daa94
107*c9537f57SPatrick Williams--- /dev/null
108*c9537f57SPatrick Williams+++ b/tests/cpp-common/test-uuid.sh
109*c9537f57SPatrick Williams@@ -0,0 +1,17 @@
110*c9537f57SPatrick Williams+#!/bin/bash
111*c9537f57SPatrick Williams+#
112*c9537f57SPatrick Williams+# SPDX-License-Identifier: GPL-2.0-only
113*c9537f57SPatrick Williams+#
114*c9537f57SPatrick Williams+# Copyright (C) 2025 Bin Lan <bin.lan.cn@windriver.com>
115*c9537f57SPatrick Williams+#
116*c9537f57SPatrick Williams+
117*c9537f57SPatrick Williams+if [ -n "${BT_TESTS_SRCDIR:-}" ]; then
118*c9537f57SPatrick Williams+	UTILSSH="$BT_TESTS_SRCDIR/utils/utils.sh"
119*c9537f57SPatrick Williams+else
120*c9537f57SPatrick Williams+	UTILSSH="$(dirname "$0")/../utils/utils.sh"
121*c9537f57SPatrick Williams+fi
122*c9537f57SPatrick Williams+
123*c9537f57SPatrick Williams+# shellcheck source=../utils/utils.sh
124*c9537f57SPatrick Williams+source "$UTILSSH"
125*c9537f57SPatrick Williams+
126*c9537f57SPatrick Williams+"${BT_TESTS_BUILDDIR}/cpp-common/test-uuid" "$BT_TESTS_BT2_BIN"
127*c9537f57SPatrick Williams--
128*c9537f57SPatrick Williams2.34.1
129*c9537f57SPatrick Williams
130