1975a06f9SPatrick WilliamsFrom 3b7091243ec03054ca8800b51b85a1c09e7e3075 Mon Sep 17 00:00:00 2001 2975a06f9SPatrick WilliamsFrom: Sui Chen <suichen6@gmail.com> 3975a06f9SPatrick WilliamsDate: Mon, 13 Jun 2022 17:46:49 +0000 4975a06f9SPatrick WilliamsSubject: [PATCH] Remove "check_build_deps" build steps 5975a06f9SPatrick Williams 6975a06f9SPatrick WilliamsWhen building with Bitbake, we want Bitbake to manage our dependencies, 7975a06f9SPatrick Williamsso we remove the "check_build_deps" steps from Perfetto. 8975a06f9SPatrick Williams 9975a06f9SPatrick WilliamsAlso setting "is_cross_compiling" to true, so that the host-side tools 10975a06f9SPatrick Williams(such as protoc) will always be generated using the native toolchain, 11975a06f9SPatrick Williamsrather than the Bitbake-generated one. 12975a06f9SPatrick Williams 13975a06f9SPatrick WilliamsSigned-off-by: Sui Chen <suichen6@gmail.com> 14975a06f9SPatrick Williams--- 15*520786ccSPatrick WilliamsUpstream-Status: Pending 16*520786ccSPatrick Williams 17975a06f9SPatrick Williams gn/BUILD.gn | 1 - 18975a06f9SPatrick Williams gn/standalone/BUILD.gn | 12 ++++++------ 19975a06f9SPatrick Williams gn/standalone/BUILDCONFIG.gn | 5 +++-- 20975a06f9SPatrick Williams 3 files changed, 9 insertions(+), 9 deletions(-) 21975a06f9SPatrick Williams 22975a06f9SPatrick Williamsdiff --git a/gn/BUILD.gn b/gn/BUILD.gn 23975a06f9SPatrick Williamsindex 8a7ca72a8..e4a2d39f0 100644 24975a06f9SPatrick Williams--- a/gn/BUILD.gn 25975a06f9SPatrick Williams+++ b/gn/BUILD.gn 26975a06f9SPatrick Williams@@ -111,7 +111,6 @@ group("default_deps") { 27975a06f9SPatrick Williams deps = [ ":gen_buildflags" ] 28975a06f9SPatrick Williams if (perfetto_build_standalone) { 29975a06f9SPatrick Williams public_deps = [ 30975a06f9SPatrick Williams- "//gn/standalone:check_build_deps", 31975a06f9SPatrick Williams "//gn/standalone/libc++:deps", 32975a06f9SPatrick Williams "//gn/standalone/sanitizers:deps", 33975a06f9SPatrick Williams ] 34975a06f9SPatrick Williamsdiff --git a/gn/standalone/BUILD.gn b/gn/standalone/BUILD.gn 35975a06f9SPatrick Williamsindex 582e9b867..9c77ac64c 100644 36975a06f9SPatrick Williams--- a/gn/standalone/BUILD.gn 37975a06f9SPatrick Williams+++ b/gn/standalone/BUILD.gn 38975a06f9SPatrick Williams@@ -441,10 +441,10 @@ config("android_liblog") { 39975a06f9SPatrick Williams } 40975a06f9SPatrick Williams 41975a06f9SPatrick Williams # Checks that tools/install-build-deps has been run since it last changed. 42975a06f9SPatrick Williams-perfetto_check_build_deps("check_build_deps") { 43975a06f9SPatrick Williams- args = [] 44975a06f9SPatrick Williams-} 45975a06f9SPatrick Williams+#perfetto_check_build_deps("check_build_deps") { 46975a06f9SPatrick Williams+# args = [] 47975a06f9SPatrick Williams+#} 48975a06f9SPatrick Williams 49975a06f9SPatrick Williams-perfetto_check_build_deps("check_build_deps_android") { 50975a06f9SPatrick Williams- args = [ "--android" ] 51975a06f9SPatrick Williams-} 52975a06f9SPatrick Williams+#perfetto_check_build_deps("check_build_deps_android") { 53975a06f9SPatrick Williams+# args = [ "--android" ] 54975a06f9SPatrick Williams+#} 55975a06f9SPatrick Williamsdiff --git a/gn/standalone/BUILDCONFIG.gn b/gn/standalone/BUILDCONFIG.gn 56975a06f9SPatrick Williamsindex 6f32686c1..c041989b0 100644 57975a06f9SPatrick Williams--- a/gn/standalone/BUILDCONFIG.gn 58975a06f9SPatrick Williams+++ b/gn/standalone/BUILDCONFIG.gn 59975a06f9SPatrick Williams@@ -59,8 +59,9 @@ declare_args() { 60975a06f9SPatrick Williams # the ossfuzz sanitizer overrides this to true. In that config the 61975a06f9SPatrick Williams # host/target cpu and arch are identical, but we want to build only the 62975a06f9SPatrick Williams # targets with the sanitizer/fuzzer flags 63975a06f9SPatrick Williams- is_cross_compiling = 64975a06f9SPatrick Williams- target_cpu != host_cpu || target_os != host_os || target_triplet != "" 65975a06f9SPatrick Williams+ 66975a06f9SPatrick Williams+ # for Bitbake build 67975a06f9SPatrick Williams+ is_cross_compiling = true 68975a06f9SPatrick Williams } 69975a06f9SPatrick Williams default_configs = [ 70975a06f9SPatrick Williams "//gn/standalone:debug_symbols", 71975a06f9SPatrick Williams-- 72975a06f9SPatrick Williams2.37.1 73975a06f9SPatrick Williams 74