1From 28fd86fb4e18af181174176530a80672de4449d2 Mon Sep 17 00:00:00 2001 2From: alperak <alperyasinak1@gmail.com> 3Date: Sat, 18 Nov 2023 12:27:17 +0300 4Subject: [PATCH] fix build with clang 5 6struct ibpi2value is a structure which contains 2 unsigned integers. In 7a number of cases the code was not initializing a value for the last value 8in the pair in struct ibpi2value ibpi_to_attention. This was raised when 9using clang compiler. 10 11vmdssd.c:49:27: error: missing field 'value' initializer 12[-Werror,-Wmissing-field-initializers] 13 {LED_IBPI_PATTERN_UNKNOWN} 14 15dellssd.c:74:27: error: missing field 'value' initializer 16[-Werror,-Wmissing-field-initializers] 17 {LED_IBPI_PATTERN_UNKNOWN} 18 19amd_ipmi.c:57:27: error: missing field 'value' 20initializer [-Werror,-Wmissing-field-initializers] 21 {LED_IBPI_PATTERN_UNKNOWN} 22 23npem.c:76:27: error: missing field 'value' 24initializer [-Werror,-Wmissing-field-initializers] 25 {LED_IBPI_PATTERN_UNKNOWN} 26 27Upstream-Status: Submitted [https://github.com/intel/ledmon/pull/179] 28Signed-off-by: alperak <alperyasinak1@gmail.com> 29--- 30 src/amd_ipmi.c | 2 +- 31 src/dellssd.c | 2 +- 32 src/npem.c | 2 +- 33 src/vmdssd.c | 2 +- 34 4 files changed, 4 insertions(+), 4 deletions(-) 35 36diff --git a/src/amd_ipmi.c b/src/amd_ipmi.c 37index 726f77d..ad36e9e 100644 38--- a/src/amd_ipmi.c 39+++ b/src/amd_ipmi.c 40@@ -53,7 +53,7 @@ const struct ibpi2value ibpi2amd_ipmi[] = { 41 {IBPI_PATTERN_FAILED_ARRAY, 0x45}, 42 {IBPI_PATTERN_REBUILD, 0x46}, 43 {IBPI_PATTERN_HOTSPARE, 0x47}, 44- {IBPI_PATTERN_UNKNOWN} 45+ {IBPI_PATTERN_UNKNOWN, 0} 46 }; 47 48 #define MG9098_CHIP_ID_REG 0x63 49diff --git a/src/dellssd.c b/src/dellssd.c 50index 3c10ec7..7f02ea1 100644 51--- a/src/dellssd.c 52+++ b/src/dellssd.c 53@@ -71,7 +71,7 @@ static const struct ibpi2value ibpi2ssd[] = { 54 {IBPI_PATTERN_FAILED_DRIVE, BP_FAULT | BP_ONLINE}, 55 {IBPI_PATTERN_LOCATE, BP_IDENTIFY | BP_ONLINE}, 56 {IBPI_PATTERN_LOCATE_OFF, BP_ONLINE}, 57- {IBPI_PATTERN_UNKNOWN} 58+ {IBPI_PATTERN_UNKNOWN, 0} 59 }; 60 61 #define DELL_OEM_NETFN 0x30 62diff --git a/src/npem.c b/src/npem.c 63index c21276d..3499169 100644 64--- a/src/npem.c 65+++ b/src/npem.c 66@@ -72,7 +72,7 @@ const struct ibpi2value ibpi_to_npem_capability[] = { 67 {IBPI_PATTERN_FAILED_DRIVE, PCI_NPEM_FAIL_CAP}, 68 {IBPI_PATTERN_LOCATE, PCI_NPEM_LOCATE_CAP}, 69 {IBPI_PATTERN_LOCATE_OFF, PCI_NPEM_OK_CAP}, 70- {IBPI_PATTERN_UNKNOWN} 71+ {IBPI_PATTERN_UNKNOWN, 0} 72 }; 73 74 static struct pci_access *get_pci_access() 75diff --git a/src/vmdssd.c b/src/vmdssd.c 76index 51af591..9c63d90 100644 77--- a/src/vmdssd.c 78+++ b/src/vmdssd.c 79@@ -45,7 +45,7 @@ struct ibpi2value ibpi_to_attention[] = { 80 {IBPI_PATTERN_REBUILD, ATTENTION_REBUILD}, 81 {IBPI_PATTERN_LOCATE_OFF, ATTENTION_OFF}, 82 {IBPI_PATTERN_ONESHOT_NORMAL, ATTENTION_OFF}, 83- {IBPI_PATTERN_UNKNOWN} 84+ {IBPI_PATTERN_UNKNOWN, 0} 85 }; 86 87 #define SYSFS_PCIEHP "/sys/module/pciehp" 88-- 892.25.1 90 91