1#!/bin/bash 2# SPDX-License-Identifier: GPL-2.0 3# 4# Test various interface configuration scenarios. Observe that configurations 5# deemed valid by mlxsw succeed, invalid configurations fail and that no traces 6# are produced. To prevent the test from passing in case traces are produced, 7# the user can set the 'kernel.panic_on_warn' and 'kernel.panic_on_oops' 8# sysctls in its environment. 9 10lib_dir=$(dirname $0)/../../../net/forwarding 11 12ALL_TESTS=" 13 rif_set_addr_test 14 rif_vrf_set_addr_test 15 rif_inherit_bridge_addr_test 16 rif_non_inherit_bridge_addr_test 17 vlan_interface_deletion_test 18 bridge_deletion_test 19 bridge_vlan_flags_test 20 vlan_1_test 21 lag_bridge_upper_test 22 duplicate_vlans_test 23 vlan_rif_refcount_test 24 subport_rif_refcount_test 25 vlan_dev_deletion_test 26 lag_unlink_slaves_test 27 lag_dev_deletion_test 28 vlan_interface_uppers_test 29 bridge_extern_learn_test 30 neigh_offload_test 31 devlink_reload_test 32" 33NUM_NETIFS=2 34source $lib_dir/lib.sh 35source $lib_dir/devlink_lib.sh 36 37setup_prepare() 38{ 39 swp1=${NETIFS[p1]} 40 swp2=${NETIFS[p2]} 41 42 ip link set dev $swp1 up 43 ip link set dev $swp2 up 44} 45 46cleanup() 47{ 48 pre_cleanup 49 50 ip link set dev $swp2 down 51 ip link set dev $swp1 down 52} 53 54rif_set_addr_test() 55{ 56 local swp1_mac=$(mac_get $swp1) 57 local swp2_mac=$(mac_get $swp2) 58 59 RET=0 60 61 # $swp1 and $swp2 likely got their IPv6 local addresses already, but 62 # here we need to test the transition to RIF. 63 ip addr flush dev $swp1 64 ip addr flush dev $swp2 65 sleep .1 66 67 ip addr add dev $swp1 192.0.2.1/28 68 check_err $? 69 70 ip link set dev $swp1 addr 00:11:22:33:44:55 71 check_err $? 72 73 # IP address enablement should be rejected if the MAC address prefix 74 # doesn't match other RIFs. 75 ip addr add dev $swp2 192.0.2.2/28 &>/dev/null 76 check_fail $? "IP address addition passed for a device with a wrong MAC" 77 ip addr add dev $swp2 192.0.2.2/28 2>&1 >/dev/null \ 78 | grep -q mlxsw_spectrum 79 check_err $? "no extack for IP address addition" 80 81 ip link set dev $swp2 addr 00:11:22:33:44:66 82 check_err $? 83 ip addr add dev $swp2 192.0.2.2/28 &>/dev/null 84 check_err $? 85 86 # Change of MAC address of a RIF should be forbidden if the new MAC 87 # doesn't share the prefix with other MAC addresses. 88 ip link set dev $swp2 addr 00:11:22:33:00:66 &>/dev/null 89 check_fail $? "change of MAC address passed for a wrong MAC" 90 ip link set dev $swp2 addr 00:11:22:33:00:66 2>&1 >/dev/null \ 91 | grep -q mlxsw_spectrum 92 check_err $? "no extack for MAC address change" 93 94 log_test "RIF - bad MAC change" 95 96 ip addr del dev $swp2 192.0.2.2/28 97 ip addr del dev $swp1 192.0.2.1/28 98 99 ip link set dev $swp2 addr $swp2_mac 100 ip link set dev $swp1 addr $swp1_mac 101} 102 103rif_vrf_set_addr_test() 104{ 105 # Test that it is possible to set an IP address on a VRF upper despite 106 # its random MAC address. 107 RET=0 108 109 ip link add name vrf-test type vrf table 10 110 ip link set dev $swp1 master vrf-test 111 112 ip -4 address add 192.0.2.1/24 dev vrf-test 113 check_err $? "failed to set IPv4 address on VRF" 114 ip -6 address add 2001:db8:1::1/64 dev vrf-test 115 check_err $? "failed to set IPv6 address on VRF" 116 117 log_test "RIF - setting IP address on VRF" 118 119 ip link del dev vrf-test 120} 121 122rif_inherit_bridge_addr_test() 123{ 124 RET=0 125 126 # Create first RIF 127 ip addr add dev $swp1 192.0.2.1/28 128 check_err $? 129 130 # Create a FID RIF 131 ip link add name br1 up type bridge vlan_filtering 0 132 ip link set dev $swp2 master br1 133 ip addr add dev br1 192.0.2.17/28 134 check_err $? 135 136 # Prepare a device with a low MAC address 137 ip link add name d up type dummy 138 ip link set dev d addr 00:11:22:33:44:55 139 140 # Attach the device to br1. That prompts bridge address change, which 141 # should be vetoed, thus preventing the attachment. 142 ip link set dev d master br1 &>/dev/null 143 check_fail $? "Device with low MAC was permitted to attach a bridge with RIF" 144 ip link set dev d master br1 2>&1 >/dev/null \ 145 | grep -q mlxsw_spectrum 146 check_err $? "no extack for bridge attach rejection" 147 148 ip link set dev $swp2 addr 00:11:22:33:44:55 &>/dev/null 149 check_fail $? "Changing swp2's MAC address permitted" 150 ip link set dev $swp2 addr 00:11:22:33:44:55 2>&1 >/dev/null \ 151 | grep -q mlxsw_spectrum 152 check_err $? "no extack for bridge port MAC address change rejection" 153 154 log_test "RIF - attach port with bad MAC to bridge" 155 156 ip link del dev d 157 ip link del dev br1 158 ip addr del dev $swp1 192.0.2.1/28 159} 160 161rif_non_inherit_bridge_addr_test() 162{ 163 local swp2_mac=$(mac_get $swp2) 164 165 RET=0 166 167 # Create first RIF 168 ip addr add dev $swp1 192.0.2.1/28 169 check_err $? 170 171 # Create a FID RIF 172 ip link add name br1 up type bridge vlan_filtering 0 173 ip link set dev br1 addr $swp2_mac 174 ip link set dev $swp2 master br1 175 ip addr add dev br1 192.0.2.17/28 176 check_err $? 177 178 # Prepare a device with a low MAC address 179 ip link add name d up type dummy 180 ip link set dev d addr 00:11:22:33:44:55 181 182 # Attach the device to br1. Since the bridge address was set, it should 183 # work. 184 ip link set dev d master br1 &>/dev/null 185 check_err $? "Could not attach a device with low MAC to a bridge with RIF" 186 187 # Port MAC address change should be allowed for a bridge with set MAC. 188 ip link set dev $swp2 addr 00:11:22:33:44:55 189 check_err $? "Changing swp2's MAC address not permitted" 190 191 log_test "RIF - attach port with bad MAC to bridge with set MAC" 192 193 ip link set dev $swp2 addr $swp2_mac 194 ip link del dev d 195 ip link del dev br1 196 ip addr del dev $swp1 192.0.2.1/28 197} 198 199vlan_interface_deletion_test() 200{ 201 # Test that when a VLAN interface is deleted, its associated router 202 # interface (RIF) is correctly deleted and not leaked. See commit 203 # c360867ec46a ("mlxsw: spectrum: Delete RIF when VLAN device is 204 # removed") for more details 205 RET=0 206 207 ip link add name br0 type bridge vlan_filtering 1 208 ip link set dev $swp1 master br0 209 210 ip link add link br0 name br0.10 type vlan id 10 211 ip -6 address add 2001:db8:1::1/64 dev br0.10 212 ip link del dev br0.10 213 214 # If we leaked the previous RIF, then this should produce a trace 215 ip link add link br0 name br0.20 type vlan id 20 216 ip -6 address add 2001:db8:1::1/64 dev br0.20 217 ip link del dev br0.20 218 219 log_test "vlan interface deletion" 220 221 ip link del dev br0 222} 223 224bridge_deletion_test() 225{ 226 # Test that when a bridge with VLAN interfaces is deleted, we correctly 227 # delete the associated RIFs. See commit 602b74eda813 ("mlxsw: 228 # spectrum_switchdev: Do not leak RIFs when removing bridge") for more 229 # details 230 RET=0 231 232 ip link add name br0 type bridge vlan_filtering 1 233 ip link set dev $swp1 master br0 234 ip -6 address add 2001:db8::1/64 dev br0 235 236 ip link add link br0 name br0.10 type vlan id 10 237 ip -6 address add 2001:db8:1::1/64 dev br0.10 238 239 ip link add link br0 name br0.20 type vlan id 20 240 ip -6 address add 2001:db8:2::1/64 dev br0.20 241 242 ip link del dev br0 243 244 # If we leaked previous RIFs, then this should produce a trace 245 ip -6 address add 2001:db8:1::1/64 dev $swp1 246 ip -6 address del 2001:db8:1::1/64 dev $swp1 247 248 log_test "bridge deletion" 249} 250 251bridge_vlan_flags_test() 252{ 253 # Test that when bridge VLAN flags are toggled, we do not take 254 # unnecessary references on related structs. See commit 9e25826ffc94 255 # ("mlxsw: spectrum_switchdev: Fix port_vlan refcounting") for more 256 # details 257 RET=0 258 259 ip link add name br0 type bridge vlan_filtering 1 260 ip link set dev $swp1 master br0 261 262 bridge vlan add vid 10 dev $swp1 pvid untagged 263 bridge vlan add vid 10 dev $swp1 untagged 264 bridge vlan add vid 10 dev $swp1 pvid 265 bridge vlan add vid 10 dev $swp1 266 ip link del dev br0 267 268 # If we did not handle references correctly, then this should produce a 269 # trace 270 devlink dev reload "$DEVLINK_DEV" 271 272 # Allow netdevices to be re-created following the reload 273 sleep 20 274 275 log_test "bridge vlan flags" 276} 277 278vlan_1_test() 279{ 280 # Test that VLAN 1 can be configured over mlxsw ports. In the past it 281 # was used internally for untagged traffic. See commit 47bf9df2e820 282 # ("mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG") for more 283 # details 284 RET=0 285 286 ip link add link $swp1 name $swp1.1 type vlan id 1 287 check_err $? "did not manage to create vlan 1 when should" 288 289 log_test "vlan 1" 290 291 ip link del dev $swp1.1 292} 293 294lag_bridge_upper_test() 295{ 296 # Test that ports cannot be enslaved to LAG devices that have uppers 297 # and that failure is handled gracefully. See commit b3529af6bb0d 298 # ("spectrum: Reference count VLAN entries") for more details 299 RET=0 300 301 ip link add name bond1 type bond mode 802.3ad 302 303 ip link add name br0 type bridge vlan_filtering 1 304 ip link set dev bond1 master br0 305 306 ip link set dev $swp1 down 307 ip link set dev $swp1 master bond1 &> /dev/null 308 check_fail $? "managed to enslave port to lag when should not" 309 310 # This might generate a trace, if we did not handle the failure 311 # correctly 312 ip -6 address add 2001:db8:1::1/64 dev $swp1 313 ip -6 address del 2001:db8:1::1/64 dev $swp1 314 315 log_test "lag with bridge upper" 316 317 ip link del dev br0 318 ip link del dev bond1 319} 320 321duplicate_vlans_test() 322{ 323 # Test that on a given port a VLAN is only used once. Either as VLAN 324 # in a VLAN-aware bridge or as a VLAN device 325 RET=0 326 327 ip link add name br0 type bridge vlan_filtering 1 328 ip link set dev $swp1 master br0 329 bridge vlan add vid 10 dev $swp1 330 331 ip link add link $swp1 name $swp1.10 type vlan id 10 &> /dev/null 332 check_fail $? "managed to create vlan device when should not" 333 334 bridge vlan del vid 10 dev $swp1 335 ip link add link $swp1 name $swp1.10 type vlan id 10 336 check_err $? "did not manage to create vlan device when should" 337 bridge vlan add vid 10 dev $swp1 &> /dev/null 338 check_fail $? "managed to add bridge vlan when should not" 339 340 log_test "duplicate vlans" 341 342 ip link del dev $swp1.10 343 ip link del dev br0 344} 345 346vlan_rif_refcount_test() 347{ 348 # Test that RIFs representing VLAN interfaces are not affected from 349 # ports member in the VLAN. We use the offload indication on routes 350 # configured on the RIF to understand if it was created / destroyed 351 RET=0 352 353 ip link add name br0 type bridge vlan_filtering 1 354 ip link set dev $swp1 master br0 355 356 ip link set dev $swp1 up 357 ip link set dev br0 up 358 359 ip link add link br0 name br0.10 up type vlan id 10 360 ip -6 address add 2001:db8:1::1/64 dev br0.10 361 362 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload 363 check_err $? "vlan rif was not created before adding port to vlan" 364 365 bridge vlan add vid 10 dev $swp1 366 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload 367 check_err $? "vlan rif was destroyed after adding port to vlan" 368 369 bridge vlan del vid 10 dev $swp1 370 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload 371 check_err $? "vlan rif was destroyed after removing port from vlan" 372 373 ip link set dev $swp1 nomaster 374 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload 375 check_fail $? "vlan rif was not destroyed after unlinking port from bridge" 376 377 log_test "vlan rif refcount" 378 379 ip link del dev br0.10 380 ip link set dev $swp1 down 381 ip link del dev br0 382} 383 384subport_rif_refcount_test() 385{ 386 # Test that RIFs representing upper devices of physical ports are 387 # reference counted correctly and destroyed when should. We use the 388 # offload indication on routes configured on the RIF to understand if 389 # it was created / destroyed 390 RET=0 391 392 ip link add name bond1 type bond mode 802.3ad 393 ip link set dev $swp1 down 394 ip link set dev $swp2 down 395 ip link set dev $swp1 master bond1 396 ip link set dev $swp2 master bond1 397 398 ip link set dev bond1 up 399 ip link add link bond1 name bond1.10 up type vlan id 10 400 ip -6 address add 2001:db8:1::1/64 dev bond1 401 ip -6 address add 2001:db8:2::1/64 dev bond1.10 402 403 ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload 404 check_err $? "subport rif was not created on lag device" 405 ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload 406 check_err $? "subport rif was not created on vlan device" 407 408 ip link set dev $swp1 nomaster 409 ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload 410 check_err $? "subport rif of lag device was destroyed when should not" 411 ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload 412 check_err $? "subport rif of vlan device was destroyed when should not" 413 414 ip link set dev $swp2 nomaster 415 ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload 416 check_fail $? "subport rif of lag device was not destroyed when should" 417 ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload 418 check_fail $? "subport rif of vlan device was not destroyed when should" 419 420 log_test "subport rif refcount" 421 422 ip link del dev bond1.10 423 ip link del dev bond1 424} 425 426vlan_dev_deletion_test() 427{ 428 # Test that VLAN devices are correctly deleted / unlinked when enslaved 429 # to bridge 430 RET=0 431 432 ip link add name br10 type bridge 433 ip link add name br20 type bridge 434 ip link add name br30 type bridge 435 ip link add link $swp1 name $swp1.10 type vlan id 10 436 ip link add link $swp1 name $swp1.20 type vlan id 20 437 ip link add link $swp1 name $swp1.30 type vlan id 30 438 ip link set dev $swp1.10 master br10 439 ip link set dev $swp1.20 master br20 440 ip link set dev $swp1.30 master br30 441 442 # If we did not handle the situation correctly, then these operations 443 # might produce a trace 444 ip link set dev $swp1.30 nomaster 445 ip link del dev $swp1.20 446 # Deletion via ioctl uses different code paths from netlink 447 vconfig rem $swp1.10 &> /dev/null 448 449 log_test "vlan device deletion" 450 451 ip link del dev $swp1.30 452 ip link del dev br30 453 ip link del dev br20 454 ip link del dev br10 455} 456 457lag_create() 458{ 459 ip link add name bond1 type bond mode 802.3ad 460 ip link set dev $swp1 down 461 ip link set dev $swp2 down 462 ip link set dev $swp1 master bond1 463 ip link set dev $swp2 master bond1 464 465 ip link add link bond1 name bond1.10 type vlan id 10 466 ip link add link bond1 name bond1.20 type vlan id 20 467 468 ip link add name br0 type bridge vlan_filtering 1 469 ip link set dev bond1 master br0 470 471 ip link add name br10 type bridge 472 ip link set dev bond1.10 master br10 473 474 ip link add name br20 type bridge 475 ip link set dev bond1.20 master br20 476} 477 478lag_unlink_slaves_test() 479{ 480 # Test that ports are correctly unlinked from their LAG master, when 481 # the LAG and its VLAN uppers are enslaved to bridges 482 RET=0 483 484 lag_create 485 486 ip link set dev $swp1 nomaster 487 check_err $? "lag slave $swp1 was not unlinked from master" 488 ip link set dev $swp2 nomaster 489 check_err $? "lag slave $swp2 was not unlinked from master" 490 491 # Try to configure corresponding VLANs as router interfaces 492 ip -6 address add 2001:db8:1::1/64 dev $swp1 493 check_err $? "failed to configure ip address on $swp1" 494 495 ip link add link $swp1 name $swp1.10 type vlan id 10 496 ip -6 address add 2001:db8:10::1/64 dev $swp1.10 497 check_err $? "failed to configure ip address on $swp1.10" 498 499 ip link add link $swp1 name $swp1.20 type vlan id 20 500 ip -6 address add 2001:db8:20::1/64 dev $swp1.20 501 check_err $? "failed to configure ip address on $swp1.20" 502 503 log_test "lag slaves unlinking" 504 505 ip link del dev $swp1.20 506 ip link del dev $swp1.10 507 ip address flush dev $swp1 508 509 ip link del dev br20 510 ip link del dev br10 511 ip link del dev br0 512 ip link del dev bond1 513} 514 515lag_dev_deletion_test() 516{ 517 # Test that LAG device is correctly deleted, when the LAG and its VLAN 518 # uppers are enslaved to bridges 519 RET=0 520 521 lag_create 522 523 ip link del dev bond1 524 525 log_test "lag device deletion" 526 527 ip link del dev br20 528 ip link del dev br10 529 ip link del dev br0 530} 531 532vlan_interface_uppers_test() 533{ 534 # Test that uppers of a VLAN interface are correctly sanitized 535 RET=0 536 537 ip link add name br0 type bridge vlan_filtering 1 538 ip link set dev $swp1 master br0 539 540 ip link add link br0 name br0.10 type vlan id 10 541 ip link add link br0.10 name macvlan0 \ 542 type macvlan mode private &> /dev/null 543 check_fail $? "managed to create a macvlan when should not" 544 545 ip -6 address add 2001:db8:1::1/64 dev br0.10 546 ip link add link br0.10 name macvlan0 type macvlan mode private 547 check_err $? "did not manage to create a macvlan when should" 548 549 ip link del dev macvlan0 550 551 ip link add name vrf-test type vrf table 10 552 ip link set dev br0.10 master vrf-test 553 check_err $? "did not manage to enslave vlan interface to vrf" 554 ip link del dev vrf-test 555 556 ip link add name br-test type bridge 557 ip link set dev br0.10 master br-test &> /dev/null 558 check_fail $? "managed to enslave vlan interface to bridge when should not" 559 ip link del dev br-test 560 561 log_test "vlan interface uppers" 562 563 ip link del dev br0 564} 565 566bridge_extern_learn_test() 567{ 568 # Test that externally learned entries added from user space are 569 # marked as offloaded 570 RET=0 571 572 ip link add name br0 type bridge 573 ip link set dev $swp1 master br0 574 575 bridge fdb add de:ad:be:ef:13:37 dev $swp1 master extern_learn 576 577 bridge fdb show brport $swp1 | grep de:ad:be:ef:13:37 | grep -q offload 578 check_err $? "fdb entry not marked as offloaded when should" 579 580 log_test "externally learned fdb entry" 581 582 ip link del dev br0 583} 584 585neigh_offload_test() 586{ 587 # Test that IPv4 and IPv6 neighbour entries are marked as offloaded 588 RET=0 589 590 ip -4 address add 192.0.2.1/24 dev $swp1 591 ip -6 address add 2001:db8:1::1/64 dev $swp1 592 593 ip -4 neigh add 192.0.2.2 lladdr de:ad:be:ef:13:37 nud perm dev $swp1 594 ip -6 neigh add 2001:db8:1::2 lladdr de:ad:be:ef:13:37 nud perm \ 595 dev $swp1 596 597 ip -4 neigh show dev $swp1 | grep 192.0.2.2 | grep -q offload 598 check_err $? "ipv4 neigh entry not marked as offloaded when should" 599 ip -6 neigh show dev $swp1 | grep 2001:db8:1::2 | grep -q offload 600 check_err $? "ipv6 neigh entry not marked as offloaded when should" 601 602 log_test "neighbour offload indication" 603 604 ip -6 neigh del 2001:db8:1::2 dev $swp1 605 ip -4 neigh del 192.0.2.2 dev $swp1 606 ip -6 address del 2001:db8:1::1/64 dev $swp1 607 ip -4 address del 192.0.2.1/24 dev $swp1 608} 609 610devlink_reload_test() 611{ 612 # Test that after executing all the above configuration tests, a 613 # devlink reload can be performed without errors 614 RET=0 615 616 devlink dev reload "$DEVLINK_DEV" 617 check_err $? "devlink reload failed" 618 619 log_test "devlink reload - last test" 620 621 sleep 20 622} 623 624trap cleanup EXIT 625 626setup_prepare 627setup_wait 628 629tests_run 630 631exit $EXIT_STATUS 632