xref: /openbmc/linux/sound/soc/sof/amd/acp.c (revision cc3519b8)
1 // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
2 //
3 // This file is provided under a dual BSD/GPLv2 license. When using or
4 // redistributing this file, you may do so under either license.
5 //
6 // Copyright(c) 2021, 2023 Advanced Micro Devices, Inc. All rights reserved.
7 //
8 // Authors: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
9 //	    Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
10 
11 /*
12  * Hardware interface for generic AMD ACP processor
13  */
14 
15 #include <linux/io.h>
16 #include <linux/module.h>
17 #include <linux/pci.h>
18 
19 #include "../ops.h"
20 #include "acp.h"
21 #include "acp-dsp-offset.h"
22 
23 #define SECURED_FIRMWARE 1
24 
25 static bool enable_fw_debug;
26 module_param(enable_fw_debug, bool, 0444);
27 MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
28 
29 const struct dmi_system_id acp_sof_quirk_table[] = {
30 	{
31 		/* Valve Jupiter device */
32 		.matches = {
33 			DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
34 			DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
35 			DMI_MATCH(DMI_PRODUCT_FAMILY, "Sephiroth"),
36 		},
37 		.driver_data = (void *)SECURED_FIRMWARE,
38 	},
39 	{}
40 };
41 EXPORT_SYMBOL_GPL(acp_sof_quirk_table);
42 
43 static int smn_write(struct pci_dev *dev, u32 smn_addr, u32 data)
44 {
45 	pci_write_config_dword(dev, 0x60, smn_addr);
46 	pci_write_config_dword(dev, 0x64, data);
47 
48 	return 0;
49 }
50 
51 static int smn_read(struct pci_dev *dev, u32 smn_addr)
52 {
53 	u32 data = 0;
54 
55 	pci_write_config_dword(dev, 0x60, smn_addr);
56 	pci_read_config_dword(dev, 0x64, &data);
57 
58 	return data;
59 }
60 
61 static void init_dma_descriptor(struct acp_dev_data *adata)
62 {
63 	struct snd_sof_dev *sdev = adata->dev;
64 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
65 	unsigned int addr;
66 
67 	addr = desc->sram_pte_offset + sdev->debug_box.offset +
68 	       offsetof(struct scratch_reg_conf, dma_desc);
69 
70 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_DESC_BASE_ADDR, addr);
71 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_DESC_MAX_NUM_DSCR, ACP_MAX_DESC_CNT);
72 }
73 
74 static void configure_dma_descriptor(struct acp_dev_data *adata, unsigned short idx,
75 				     struct dma_descriptor *dscr_info)
76 {
77 	struct snd_sof_dev *sdev = adata->dev;
78 	unsigned int offset;
79 
80 	offset = ACP_SCRATCH_REG_0 + sdev->debug_box.offset +
81 		offsetof(struct scratch_reg_conf, dma_desc) +
82 		idx * sizeof(struct dma_descriptor);
83 
84 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, offset, dscr_info->src_addr);
85 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, offset + 0x4, dscr_info->dest_addr);
86 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, offset + 0x8, dscr_info->tx_cnt.u32_all);
87 }
88 
89 static int config_dma_channel(struct acp_dev_data *adata, unsigned int ch,
90 			      unsigned int idx, unsigned int dscr_count)
91 {
92 	struct snd_sof_dev *sdev = adata->dev;
93 	unsigned int val, status;
94 	int ret;
95 
96 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_CNTL_0 + ch * sizeof(u32),
97 			  ACP_DMA_CH_RST | ACP_DMA_CH_GRACEFUL_RST_EN);
98 
99 	ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_DMA_CH_RST_STS, val,
100 					    val & (1 << ch), ACP_REG_POLL_INTERVAL,
101 					    ACP_REG_POLL_TIMEOUT_US);
102 	if (ret < 0) {
103 		status = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_ERROR_STATUS);
104 		val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_DMA_ERR_STS_0 + ch * sizeof(u32));
105 
106 		dev_err(sdev->dev, "ACP_DMA_ERR_STS :0x%x ACP_ERROR_STATUS :0x%x\n", val, status);
107 		return ret;
108 	}
109 
110 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, (ACP_DMA_CNTL_0 + ch * sizeof(u32)), 0);
111 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_DSCR_CNT_0 + ch * sizeof(u32), dscr_count);
112 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_DSCR_STRT_IDX_0 + ch * sizeof(u32), idx);
113 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_PRIO_0 + ch * sizeof(u32), 0);
114 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_DMA_CNTL_0 + ch * sizeof(u32), ACP_DMA_CH_RUN);
115 
116 	return ret;
117 }
118 
119 static int acpbus_dma_start(struct acp_dev_data *adata, unsigned int ch,
120 			    unsigned int dscr_count, struct dma_descriptor *dscr_info)
121 {
122 	struct snd_sof_dev *sdev = adata->dev;
123 	int ret;
124 	u16 dscr;
125 
126 	if (!dscr_info || !dscr_count)
127 		return -EINVAL;
128 
129 	for (dscr = 0; dscr < dscr_count; dscr++)
130 		configure_dma_descriptor(adata, dscr, dscr_info++);
131 
132 	ret = config_dma_channel(adata, ch, 0, dscr_count);
133 	if (ret < 0)
134 		dev_err(sdev->dev, "config dma ch failed:%d\n", ret);
135 
136 	return ret;
137 }
138 
139 int configure_and_run_dma(struct acp_dev_data *adata, unsigned int src_addr,
140 			  unsigned int dest_addr, int dsp_data_size)
141 {
142 	struct snd_sof_dev *sdev = adata->dev;
143 	unsigned int desc_count, index;
144 	int ret;
145 
146 	for (desc_count = 0; desc_count < ACP_MAX_DESC && dsp_data_size >= 0;
147 	     desc_count++, dsp_data_size -= ACP_PAGE_SIZE) {
148 		adata->dscr_info[desc_count].src_addr = src_addr + desc_count * ACP_PAGE_SIZE;
149 		adata->dscr_info[desc_count].dest_addr = dest_addr + desc_count * ACP_PAGE_SIZE;
150 		adata->dscr_info[desc_count].tx_cnt.bits.count = ACP_PAGE_SIZE;
151 		if (dsp_data_size < ACP_PAGE_SIZE)
152 			adata->dscr_info[desc_count].tx_cnt.bits.count = dsp_data_size;
153 	}
154 
155 	ret = acpbus_dma_start(adata, 0, desc_count, adata->dscr_info);
156 	if (ret)
157 		dev_err(sdev->dev, "acpbus_dma_start failed\n");
158 
159 	/* Clear descriptor array */
160 	for (index = 0; index < desc_count; index++)
161 		memset(&adata->dscr_info[index], 0x00, sizeof(struct dma_descriptor));
162 
163 	return ret;
164 }
165 
166 /*
167  * psp_mbox_ready- function to poll ready bit of psp mbox
168  * @adata: acp device data
169  * @ack: bool variable to check ready bit status or psp ack
170  */
171 
172 static int psp_mbox_ready(struct acp_dev_data *adata, bool ack)
173 {
174 	struct snd_sof_dev *sdev = adata->dev;
175 	int ret;
176 	u32 data;
177 
178 	ret = read_poll_timeout(smn_read, data, data & MBOX_READY_MASK, MBOX_DELAY_US,
179 				ACP_PSP_TIMEOUT_US, false, adata->smn_dev, MP0_C2PMSG_114_REG);
180 	if (!ret)
181 		return 0;
182 
183 	dev_err(sdev->dev, "PSP error status %x\n", data & MBOX_STATUS_MASK);
184 
185 	if (ack)
186 		return -ETIMEDOUT;
187 
188 	return -EBUSY;
189 }
190 
191 /*
192  * psp_send_cmd - function to send psp command over mbox
193  * @adata: acp device data
194  * @cmd: non zero integer value for command type
195  */
196 
197 static int psp_send_cmd(struct acp_dev_data *adata, int cmd)
198 {
199 	struct snd_sof_dev *sdev = adata->dev;
200 	int ret;
201 	u32 data;
202 
203 	if (!cmd)
204 		return -EINVAL;
205 
206 	/* Get a non-zero Doorbell value from PSP */
207 	ret = read_poll_timeout(smn_read, data, data, MBOX_DELAY_US, ACP_PSP_TIMEOUT_US, false,
208 				adata->smn_dev, MP0_C2PMSG_73_REG);
209 
210 	if (ret) {
211 		dev_err(sdev->dev, "Failed to get Doorbell from MBOX %x\n", MP0_C2PMSG_73_REG);
212 		return ret;
213 	}
214 
215 	/* Check if PSP is ready for new command */
216 	ret = psp_mbox_ready(adata, 0);
217 	if (ret)
218 		return ret;
219 
220 	smn_write(adata->smn_dev, MP0_C2PMSG_114_REG, cmd);
221 
222 	/* Ring the Doorbell for PSP */
223 	smn_write(adata->smn_dev, MP0_C2PMSG_73_REG, data);
224 
225 	/* Check MBOX ready as PSP ack */
226 	ret = psp_mbox_ready(adata, 1);
227 
228 	return ret;
229 }
230 
231 int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
232 			      unsigned int start_addr, unsigned int dest_addr,
233 			      unsigned int image_length)
234 {
235 	struct snd_sof_dev *sdev = adata->dev;
236 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
237 	unsigned int tx_count, fw_qualifier, val;
238 	int ret;
239 
240 	if (!image_addr) {
241 		dev_err(sdev->dev, "SHA DMA image address is NULL\n");
242 		return -EINVAL;
243 	}
244 
245 	val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD);
246 	if (val & ACP_SHA_RUN) {
247 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RESET);
248 		ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD_STS,
249 						    val, val & ACP_SHA_RESET,
250 						    ACP_REG_POLL_INTERVAL,
251 						    ACP_REG_POLL_TIMEOUT_US);
252 		if (ret < 0) {
253 			dev_err(sdev->dev, "SHA DMA Failed to Reset\n");
254 			return ret;
255 		}
256 	}
257 
258 	if (adata->signed_fw_image)
259 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
260 
261 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
262 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_DESTINATION_ADDR, dest_addr);
263 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_MSG_LENGTH, image_length);
264 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RUN);
265 
266 	ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_TRANSFER_BYTE_CNT,
267 					    tx_count, tx_count == image_length,
268 					    ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US);
269 	if (ret < 0) {
270 		dev_err(sdev->dev, "SHA DMA Failed to Transfer Length %x\n", tx_count);
271 		return ret;
272 	}
273 
274 	/* psp_send_cmd only required for renoir platform (rev - 3) */
275 	if (desc->rev == 3) {
276 		ret = psp_send_cmd(adata, MBOX_ACP_SHA_DMA_COMMAND);
277 		if (ret)
278 			return ret;
279 	}
280 
281 	ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DSP_FW_QUALIFIER,
282 					    fw_qualifier, fw_qualifier & DSP_FW_RUN_ENABLE,
283 					    ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US);
284 	if (ret < 0) {
285 		dev_err(sdev->dev, "PSP validation failed\n");
286 		return ret;
287 	}
288 
289 	return 0;
290 }
291 
292 int acp_dma_status(struct acp_dev_data *adata, unsigned char ch)
293 {
294 	struct snd_sof_dev *sdev = adata->dev;
295 	unsigned int val;
296 	int ret = 0;
297 
298 	val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_DMA_CNTL_0 + ch * sizeof(u32));
299 	if (val & ACP_DMA_CH_RUN) {
300 		ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_DMA_CH_STS, val, !val,
301 						    ACP_REG_POLL_INTERVAL,
302 						    ACP_DMA_COMPLETE_TIMEOUT_US);
303 		if (ret < 0)
304 			dev_err(sdev->dev, "DMA_CHANNEL %d status timeout\n", ch);
305 	}
306 
307 	return ret;
308 }
309 
310 void memcpy_from_scratch(struct snd_sof_dev *sdev, u32 offset, unsigned int *dst, size_t bytes)
311 {
312 	unsigned int reg_offset = offset + ACP_SCRATCH_REG_0;
313 	int i, j;
314 
315 	for (i = 0, j = 0; i < bytes; i = i + 4, j++)
316 		dst[j] = snd_sof_dsp_read(sdev, ACP_DSP_BAR, reg_offset + i);
317 }
318 
319 void memcpy_to_scratch(struct snd_sof_dev *sdev, u32 offset, unsigned int *src, size_t bytes)
320 {
321 	unsigned int reg_offset = offset + ACP_SCRATCH_REG_0;
322 	int i, j;
323 
324 	for (i = 0, j = 0; i < bytes; i = i + 4, j++)
325 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, reg_offset + i, src[j]);
326 }
327 
328 static int acp_memory_init(struct snd_sof_dev *sdev)
329 {
330 	struct acp_dev_data *adata = sdev->pdata->hw_pdata;
331 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
332 
333 	snd_sof_dsp_update_bits(sdev, ACP_DSP_BAR, desc->dsp_intr_base + DSP_SW_INTR_CNTL_OFFSET,
334 				ACP_DSP_INTR_EN_MASK, ACP_DSP_INTR_EN_MASK);
335 	init_dma_descriptor(adata);
336 
337 	return 0;
338 }
339 
340 static irqreturn_t acp_irq_thread(int irq, void *context)
341 {
342 	struct snd_sof_dev *sdev = context;
343 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
344 	unsigned int count = ACP_HW_SEM_RETRY_COUNT;
345 
346 	while (snd_sof_dsp_read(sdev, ACP_DSP_BAR, desc->hw_semaphore_offset)) {
347 		/* Wait until acquired HW Semaphore lock or timeout */
348 		count--;
349 		if (!count) {
350 			dev_err(sdev->dev, "%s: Failed to acquire HW lock\n", __func__);
351 			return IRQ_NONE;
352 		}
353 	}
354 
355 	sof_ops(sdev)->irq_thread(irq, sdev);
356 	/* Unlock or Release HW Semaphore */
357 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->hw_semaphore_offset, 0x0);
358 
359 	return IRQ_HANDLED;
360 };
361 
362 static irqreturn_t acp_irq_handler(int irq, void *dev_id)
363 {
364 	struct snd_sof_dev *sdev = dev_id;
365 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
366 	unsigned int base = desc->dsp_intr_base;
367 	unsigned int val;
368 
369 	val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, base + DSP_SW_INTR_STAT_OFFSET);
370 	if (val & ACP_DSP_TO_HOST_IRQ) {
371 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + DSP_SW_INTR_STAT_OFFSET,
372 				  ACP_DSP_TO_HOST_IRQ);
373 		return IRQ_WAKE_THREAD;
374 	}
375 
376 	return IRQ_NONE;
377 }
378 
379 static int acp_power_on(struct snd_sof_dev *sdev)
380 {
381 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
382 	unsigned int base = desc->pgfsm_base;
383 	unsigned int val;
384 	int ret;
385 
386 	val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, base + PGFSM_STATUS_OFFSET);
387 
388 	if (val == ACP_POWERED_ON)
389 		return 0;
390 
391 	if (val & ACP_PGFSM_STATUS_MASK)
392 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, base + PGFSM_CONTROL_OFFSET,
393 				  ACP_PGFSM_CNTL_POWER_ON_MASK);
394 
395 	ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, base + PGFSM_STATUS_OFFSET, val,
396 					    !val, ACP_REG_POLL_INTERVAL, ACP_REG_POLL_TIMEOUT_US);
397 	if (ret < 0)
398 		dev_err(sdev->dev, "timeout in ACP_PGFSM_STATUS read\n");
399 
400 	return ret;
401 }
402 
403 static int acp_reset(struct snd_sof_dev *sdev)
404 {
405 	const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
406 	unsigned int val;
407 	int ret;
408 
409 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SOFT_RESET, ACP_ASSERT_RESET);
410 
411 	ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SOFT_RESET, val,
412 					    val & ACP_SOFT_RESET_DONE_MASK,
413 					    ACP_REG_POLL_INTERVAL, ACP_REG_POLL_TIMEOUT_US);
414 	if (ret < 0) {
415 		dev_err(sdev->dev, "timeout asserting reset\n");
416 		return ret;
417 	}
418 
419 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SOFT_RESET, ACP_RELEASE_RESET);
420 
421 	ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SOFT_RESET, val, !val,
422 					    ACP_REG_POLL_INTERVAL, ACP_REG_POLL_TIMEOUT_US);
423 	if (ret < 0)
424 		dev_err(sdev->dev, "timeout in releasing reset\n");
425 
426 	if (desc->acp_clkmux_sel)
427 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->acp_clkmux_sel, ACP_CLOCK_ACLK);
428 
429 	if (desc->ext_intr_enb)
430 		snd_sof_dsp_write(sdev, ACP_DSP_BAR, desc->ext_intr_enb, 0x01);
431 
432 	return ret;
433 }
434 
435 static int acp_init(struct snd_sof_dev *sdev)
436 {
437 	int ret;
438 
439 	/* power on */
440 	ret = acp_power_on(sdev);
441 	if (ret) {
442 		dev_err(sdev->dev, "ACP power on failed\n");
443 		return ret;
444 	}
445 
446 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_CONTROL, 0x01);
447 	/* Reset */
448 	return acp_reset(sdev);
449 }
450 
451 int amd_sof_acp_suspend(struct snd_sof_dev *sdev, u32 target_state)
452 {
453 	int ret;
454 
455 	ret = acp_reset(sdev);
456 	if (ret) {
457 		dev_err(sdev->dev, "ACP Reset failed\n");
458 		return ret;
459 	}
460 
461 	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_CONTROL, 0x00);
462 
463 	return 0;
464 }
465 EXPORT_SYMBOL_NS(amd_sof_acp_suspend, SND_SOC_SOF_AMD_COMMON);
466 
467 int amd_sof_acp_resume(struct snd_sof_dev *sdev)
468 {
469 	int ret;
470 
471 	ret = acp_init(sdev);
472 	if (ret) {
473 		dev_err(sdev->dev, "ACP Init failed\n");
474 		return ret;
475 	}
476 	return acp_memory_init(sdev);
477 }
478 EXPORT_SYMBOL_NS(amd_sof_acp_resume, SND_SOC_SOF_AMD_COMMON);
479 
480 int amd_sof_acp_probe(struct snd_sof_dev *sdev)
481 {
482 	struct pci_dev *pci = to_pci_dev(sdev->dev);
483 	struct snd_sof_pdata *plat_data = sdev->pdata;
484 	struct acp_dev_data *adata;
485 	const struct sof_amd_acp_desc *chip;
486 	const struct dmi_system_id *dmi_id;
487 	unsigned int addr;
488 	int ret;
489 
490 	chip = get_chip_info(sdev->pdata);
491 	if (!chip) {
492 		dev_err(sdev->dev, "no such device supported, chip id:%x\n", pci->device);
493 		return -EIO;
494 	}
495 	adata = devm_kzalloc(sdev->dev, sizeof(struct acp_dev_data),
496 			     GFP_KERNEL);
497 	if (!adata)
498 		return -ENOMEM;
499 
500 	adata->dev = sdev;
501 	adata->dmic_dev = platform_device_register_data(sdev->dev, "dmic-codec",
502 							PLATFORM_DEVID_NONE, NULL, 0);
503 	if (IS_ERR(adata->dmic_dev)) {
504 		dev_err(sdev->dev, "failed to register platform for dmic codec\n");
505 		return PTR_ERR(adata->dmic_dev);
506 	}
507 	addr = pci_resource_start(pci, ACP_DSP_BAR);
508 	sdev->bar[ACP_DSP_BAR] = devm_ioremap(sdev->dev, addr, pci_resource_len(pci, ACP_DSP_BAR));
509 	if (!sdev->bar[ACP_DSP_BAR]) {
510 		dev_err(sdev->dev, "ioremap error\n");
511 		ret = -ENXIO;
512 		goto unregister_dev;
513 	}
514 
515 	pci_set_master(pci);
516 
517 	sdev->pdata->hw_pdata = adata;
518 	adata->smn_dev = pci_get_device(PCI_VENDOR_ID_AMD, chip->host_bridge_id, NULL);
519 	if (!adata->smn_dev) {
520 		dev_err(sdev->dev, "Failed to get host bridge device\n");
521 		ret = -ENODEV;
522 		goto unregister_dev;
523 	}
524 
525 	sdev->ipc_irq = pci->irq;
526 	ret = request_threaded_irq(sdev->ipc_irq, acp_irq_handler, acp_irq_thread,
527 				   IRQF_SHARED, "AudioDSP", sdev);
528 	if (ret < 0) {
529 		dev_err(sdev->dev, "failed to register IRQ %d\n",
530 			sdev->ipc_irq);
531 		goto free_smn_dev;
532 	}
533 
534 	ret = acp_init(sdev);
535 	if (ret < 0)
536 		goto free_ipc_irq;
537 
538 	sdev->dsp_box.offset = 0;
539 	sdev->dsp_box.size = BOX_SIZE_512;
540 
541 	sdev->host_box.offset = sdev->dsp_box.offset + sdev->dsp_box.size;
542 	sdev->host_box.size = BOX_SIZE_512;
543 
544 	sdev->debug_box.offset = sdev->host_box.offset + sdev->host_box.size;
545 	sdev->debug_box.size = BOX_SIZE_1024;
546 
547 	adata->signed_fw_image = false;
548 	dmi_id = dmi_first_match(acp_sof_quirk_table);
549 	if (dmi_id && dmi_id->driver_data) {
550 		adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
551 						    "%s/sof-%s-code.bin",
552 						    plat_data->fw_filename_prefix,
553 						    chip->name);
554 		if (!adata->fw_code_bin) {
555 			ret = -ENOMEM;
556 			goto free_ipc_irq;
557 		}
558 
559 		adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
560 						    "%s/sof-%s-data.bin",
561 						    plat_data->fw_filename_prefix,
562 						    chip->name);
563 		if (!adata->fw_data_bin) {
564 			ret = -ENOMEM;
565 			goto free_ipc_irq;
566 		}
567 
568 		adata->signed_fw_image = dmi_id->driver_data;
569 	}
570 
571 	adata->enable_fw_debug = enable_fw_debug;
572 	acp_memory_init(sdev);
573 
574 	acp_dsp_stream_init(sdev);
575 
576 	return 0;
577 
578 free_ipc_irq:
579 	free_irq(sdev->ipc_irq, sdev);
580 free_smn_dev:
581 	pci_dev_put(adata->smn_dev);
582 unregister_dev:
583 	platform_device_unregister(adata->dmic_dev);
584 	return ret;
585 }
586 EXPORT_SYMBOL_NS(amd_sof_acp_probe, SND_SOC_SOF_AMD_COMMON);
587 
588 int amd_sof_acp_remove(struct snd_sof_dev *sdev)
589 {
590 	struct acp_dev_data *adata = sdev->pdata->hw_pdata;
591 
592 	if (adata->smn_dev)
593 		pci_dev_put(adata->smn_dev);
594 
595 	if (sdev->ipc_irq)
596 		free_irq(sdev->ipc_irq, sdev);
597 
598 	if (adata->dmic_dev)
599 		platform_device_unregister(adata->dmic_dev);
600 
601 	return acp_reset(sdev);
602 }
603 EXPORT_SYMBOL_NS(amd_sof_acp_remove, SND_SOC_SOF_AMD_COMMON);
604 
605 MODULE_DESCRIPTION("AMD ACP sof driver");
606 MODULE_LICENSE("Dual BSD/GPL");
607