xref: /openbmc/linux/security/apparmor/file.c (revision 1ad22fcc)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * AppArmor security module
4  *
5  * This file contains AppArmor mediation of files
6  *
7  * Copyright (C) 1998-2008 Novell/SUSE
8  * Copyright 2009-2010 Canonical Ltd.
9  */
10 
11 #include <linux/tty.h>
12 #include <linux/fdtable.h>
13 #include <linux/file.h>
14 #include <linux/fs.h>
15 #include <linux/mount.h>
16 
17 #include "include/apparmor.h"
18 #include "include/audit.h"
19 #include "include/cred.h"
20 #include "include/file.h"
21 #include "include/match.h"
22 #include "include/net.h"
23 #include "include/path.h"
24 #include "include/policy.h"
25 #include "include/label.h"
26 
27 static u32 map_mask_to_chr_mask(u32 mask)
28 {
29 	u32 m = mask & PERMS_CHRS_MASK;
30 
31 	if (mask & AA_MAY_GETATTR)
32 		m |= MAY_READ;
33 	if (mask & (AA_MAY_SETATTR | AA_MAY_CHMOD | AA_MAY_CHOWN))
34 		m |= MAY_WRITE;
35 
36 	return m;
37 }
38 
39 /**
40  * file_audit_cb - call back for file specific audit fields
41  * @ab: audit_buffer  (NOT NULL)
42  * @va: audit struct to audit values of  (NOT NULL)
43  */
44 static void file_audit_cb(struct audit_buffer *ab, void *va)
45 {
46 	struct common_audit_data *sa = va;
47 	kuid_t fsuid = current_fsuid();
48 	char str[10];
49 
50 	if (aad(sa)->request & AA_AUDIT_FILE_MASK) {
51 		aa_perm_mask_to_str(str, sizeof(str), aa_file_perm_chrs,
52 				    map_mask_to_chr_mask(aad(sa)->request));
53 		audit_log_format(ab, " requested_mask=\"%s\"", str);
54 	}
55 	if (aad(sa)->denied & AA_AUDIT_FILE_MASK) {
56 		aa_perm_mask_to_str(str, sizeof(str), aa_file_perm_chrs,
57 				    map_mask_to_chr_mask(aad(sa)->denied));
58 		audit_log_format(ab, " denied_mask=\"%s\"", str);
59 	}
60 	if (aad(sa)->request & AA_AUDIT_FILE_MASK) {
61 		audit_log_format(ab, " fsuid=%d",
62 				 from_kuid(&init_user_ns, fsuid));
63 		audit_log_format(ab, " ouid=%d",
64 				 from_kuid(&init_user_ns, aad(sa)->fs.ouid));
65 	}
66 
67 	if (aad(sa)->peer) {
68 		audit_log_format(ab, " target=");
69 		aa_label_xaudit(ab, labels_ns(aad(sa)->label), aad(sa)->peer,
70 				FLAG_VIEW_SUBNS, GFP_KERNEL);
71 	} else if (aad(sa)->fs.target) {
72 		audit_log_format(ab, " target=");
73 		audit_log_untrustedstring(ab, aad(sa)->fs.target);
74 	}
75 }
76 
77 /**
78  * aa_audit_file - handle the auditing of file operations
79  * @profile: the profile being enforced  (NOT NULL)
80  * @perms: the permissions computed for the request (NOT NULL)
81  * @op: operation being mediated
82  * @request: permissions requested
83  * @name: name of object being mediated (MAYBE NULL)
84  * @target: name of target (MAYBE NULL)
85  * @tlabel: target label (MAY BE NULL)
86  * @ouid: object uid
87  * @info: extra information message (MAYBE NULL)
88  * @error: 0 if operation allowed else failure error code
89  *
90  * Returns: %0 or error on failure
91  */
92 int aa_audit_file(struct aa_profile *profile, struct aa_perms *perms,
93 		  const char *op, u32 request, const char *name,
94 		  const char *target, struct aa_label *tlabel,
95 		  kuid_t ouid, const char *info, int error)
96 {
97 	int type = AUDIT_APPARMOR_AUTO;
98 	DEFINE_AUDIT_DATA(sa, LSM_AUDIT_DATA_TASK, AA_CLASS_FILE, op);
99 
100 	sa.u.tsk = NULL;
101 	aad(&sa)->request = request;
102 	aad(&sa)->name = name;
103 	aad(&sa)->fs.target = target;
104 	aad(&sa)->peer = tlabel;
105 	aad(&sa)->fs.ouid = ouid;
106 	aad(&sa)->info = info;
107 	aad(&sa)->error = error;
108 	sa.u.tsk = NULL;
109 
110 	if (likely(!aad(&sa)->error)) {
111 		u32 mask = perms->audit;
112 
113 		if (unlikely(AUDIT_MODE(profile) == AUDIT_ALL))
114 			mask = 0xffff;
115 
116 		/* mask off perms that are not being force audited */
117 		aad(&sa)->request &= mask;
118 
119 		if (likely(!aad(&sa)->request))
120 			return 0;
121 		type = AUDIT_APPARMOR_AUDIT;
122 	} else {
123 		/* only report permissions that were denied */
124 		aad(&sa)->request = aad(&sa)->request & ~perms->allow;
125 		AA_BUG(!aad(&sa)->request);
126 
127 		if (aad(&sa)->request & perms->kill)
128 			type = AUDIT_APPARMOR_KILL;
129 
130 		/* quiet known rejects, assumes quiet and kill do not overlap */
131 		if ((aad(&sa)->request & perms->quiet) &&
132 		    AUDIT_MODE(profile) != AUDIT_NOQUIET &&
133 		    AUDIT_MODE(profile) != AUDIT_ALL)
134 			aad(&sa)->request &= ~perms->quiet;
135 
136 		if (!aad(&sa)->request)
137 			return aad(&sa)->error;
138 	}
139 
140 	aad(&sa)->denied = aad(&sa)->request & ~perms->allow;
141 	return aa_audit(type, profile, &sa, file_audit_cb);
142 }
143 
144 /**
145  * is_deleted - test if a file has been completely unlinked
146  * @dentry: dentry of file to test for deletion  (NOT NULL)
147  *
148  * Returns: true if deleted else false
149  */
150 static inline bool is_deleted(struct dentry *dentry)
151 {
152 	if (d_unlinked(dentry) && d_backing_inode(dentry)->i_nlink == 0)
153 		return true;
154 	return false;
155 }
156 
157 static int path_name(const char *op, struct aa_label *label,
158 		     const struct path *path, int flags, char *buffer,
159 		     const char **name, struct path_cond *cond, u32 request)
160 {
161 	struct aa_profile *profile;
162 	const char *info = NULL;
163 	int error;
164 
165 	error = aa_path_name(path, flags, buffer, name, &info,
166 			     labels_profile(label)->disconnected);
167 	if (error) {
168 		fn_for_each_confined(label, profile,
169 			aa_audit_file(profile, &nullperms, op, request, *name,
170 				      NULL, NULL, cond->uid, info, error));
171 		return error;
172 	}
173 
174 	return 0;
175 }
176 
177 /**
178  * aa_lookup_fperms - convert dfa compressed perms to internal perms
179  * @dfa: dfa to lookup perms for   (NOT NULL)
180  * @state: state in dfa
181  * @cond:  conditions to consider  (NOT NULL)
182  *
183  * TODO: convert from dfa + state to permission entry
184  *
185  * Returns: a pointer to a file permission set
186  */
187 struct aa_perms default_perms = {};
188 struct aa_perms *aa_lookup_fperms(struct aa_policydb *file_rules,
189 				 aa_state_t state, struct path_cond *cond)
190 {
191 	unsigned int index = ACCEPT_TABLE(file_rules->dfa)[state];
192 
193 	if (!(file_rules->perms))
194 		return &default_perms;
195 
196 	if (uid_eq(current_fsuid(), cond->uid))
197 		return &(file_rules->perms[index]);
198 
199 	return &(file_rules->perms[index + 1]);
200 }
201 
202 /**
203  * aa_str_perms - find permission that match @name
204  * @dfa: to match against  (MAYBE NULL)
205  * @state: state to start matching in
206  * @name: string to match against dfa  (NOT NULL)
207  * @cond: conditions to consider for permission set computation  (NOT NULL)
208  * @perms: Returns - the permissions found when matching @name
209  *
210  * Returns: the final state in @dfa when beginning @start and walking @name
211  */
212 aa_state_t aa_str_perms(struct aa_policydb *file_rules, aa_state_t start,
213 			const char *name, struct path_cond *cond,
214 			struct aa_perms *perms)
215 {
216 	aa_state_t state;
217 	state = aa_dfa_match(file_rules->dfa, start, name);
218 	*perms = *(aa_lookup_fperms(file_rules, state, cond));
219 
220 	return state;
221 }
222 
223 int __aa_path_perm(const char *op, struct aa_profile *profile, const char *name,
224 		   u32 request, struct path_cond *cond, int flags,
225 		   struct aa_perms *perms)
226 {
227 	struct aa_ruleset *rules = list_first_entry(&profile->rules,
228 						    typeof(*rules), list);
229 	int e = 0;
230 
231 	if (profile_unconfined(profile))
232 		return 0;
233 	aa_str_perms(&(rules->file), rules->file.start[AA_CLASS_FILE],
234 		     name, cond, perms);
235 	if (request & ~perms->allow)
236 		e = -EACCES;
237 	return aa_audit_file(profile, perms, op, request, name, NULL, NULL,
238 			     cond->uid, NULL, e);
239 }
240 
241 
242 static int profile_path_perm(const char *op, struct aa_profile *profile,
243 			     const struct path *path, char *buffer, u32 request,
244 			     struct path_cond *cond, int flags,
245 			     struct aa_perms *perms)
246 {
247 	const char *name;
248 	int error;
249 
250 	if (profile_unconfined(profile))
251 		return 0;
252 
253 	error = path_name(op, &profile->label, path,
254 			  flags | profile->path_flags, buffer, &name, cond,
255 			  request);
256 	if (error)
257 		return error;
258 	return __aa_path_perm(op, profile, name, request, cond, flags,
259 			      perms);
260 }
261 
262 /**
263  * aa_path_perm - do permissions check & audit for @path
264  * @op: operation being checked
265  * @label: profile being enforced  (NOT NULL)
266  * @path: path to check permissions of  (NOT NULL)
267  * @flags: any additional path flags beyond what the profile specifies
268  * @request: requested permissions
269  * @cond: conditional info for this request  (NOT NULL)
270  *
271  * Returns: %0 else error if access denied or other error
272  */
273 int aa_path_perm(const char *op, struct aa_label *label,
274 		 const struct path *path, int flags, u32 request,
275 		 struct path_cond *cond)
276 {
277 	struct aa_perms perms = {};
278 	struct aa_profile *profile;
279 	char *buffer = NULL;
280 	int error;
281 
282 	flags |= PATH_DELEGATE_DELETED | (S_ISDIR(cond->mode) ? PATH_IS_DIR :
283 								0);
284 	buffer = aa_get_buffer(false);
285 	if (!buffer)
286 		return -ENOMEM;
287 	error = fn_for_each_confined(label, profile,
288 			profile_path_perm(op, profile, path, buffer, request,
289 					  cond, flags, &perms));
290 
291 	aa_put_buffer(buffer);
292 
293 	return error;
294 }
295 
296 /**
297  * xindex_is_subset - helper for aa_path_link
298  * @link: link permission set
299  * @target: target permission set
300  *
301  * test target x permissions are equal OR a subset of link x permissions
302  * this is done as part of the subset test, where a hardlink must have
303  * a subset of permissions that the target has.
304  *
305  * Returns: true if subset else false
306  */
307 static inline bool xindex_is_subset(u32 link, u32 target)
308 {
309 	if (((link & ~AA_X_UNSAFE) != (target & ~AA_X_UNSAFE)) ||
310 	    ((link & AA_X_UNSAFE) && !(target & AA_X_UNSAFE)))
311 		return false;
312 
313 	return true;
314 }
315 
316 static int profile_path_link(struct aa_profile *profile,
317 			     const struct path *link, char *buffer,
318 			     const struct path *target, char *buffer2,
319 			     struct path_cond *cond)
320 {
321 	struct aa_ruleset *rules = list_first_entry(&profile->rules,
322 						    typeof(*rules), list);
323 	const char *lname, *tname = NULL;
324 	struct aa_perms lperms = {}, perms;
325 	const char *info = NULL;
326 	u32 request = AA_MAY_LINK;
327 	aa_state_t state;
328 	int error;
329 
330 	error = path_name(OP_LINK, &profile->label, link, profile->path_flags,
331 			  buffer, &lname, cond, AA_MAY_LINK);
332 	if (error)
333 		goto audit;
334 
335 	/* buffer2 freed below, tname is pointer in buffer2 */
336 	error = path_name(OP_LINK, &profile->label, target, profile->path_flags,
337 			  buffer2, &tname, cond, AA_MAY_LINK);
338 	if (error)
339 		goto audit;
340 
341 	error = -EACCES;
342 	/* aa_str_perms - handles the case of the dfa being NULL */
343 	state = aa_str_perms(&(rules->file),
344 			     rules->file.start[AA_CLASS_FILE], lname,
345 			     cond, &lperms);
346 
347 	if (!(lperms.allow & AA_MAY_LINK))
348 		goto audit;
349 
350 	/* test to see if target can be paired with link */
351 	state = aa_dfa_null_transition(rules->file.dfa, state);
352 	aa_str_perms(&(rules->file), state, tname, cond, &perms);
353 
354 	/* force audit/quiet masks for link are stored in the second entry
355 	 * in the link pair.
356 	 */
357 	lperms.audit = perms.audit;
358 	lperms.quiet = perms.quiet;
359 	lperms.kill = perms.kill;
360 
361 	if (!(perms.allow & AA_MAY_LINK)) {
362 		info = "target restricted";
363 		lperms = perms;
364 		goto audit;
365 	}
366 
367 	/* done if link subset test is not required */
368 	if (!(perms.allow & AA_LINK_SUBSET))
369 		goto done_tests;
370 
371 	/* Do link perm subset test requiring allowed permission on link are
372 	 * a subset of the allowed permissions on target.
373 	 */
374 	aa_str_perms(&(rules->file), rules->file.start[AA_CLASS_FILE],
375 		     tname, cond, &perms);
376 
377 	/* AA_MAY_LINK is not considered in the subset test */
378 	request = lperms.allow & ~AA_MAY_LINK;
379 	lperms.allow &= perms.allow | AA_MAY_LINK;
380 
381 	request |= AA_AUDIT_FILE_MASK & (lperms.allow & ~perms.allow);
382 	if (request & ~lperms.allow) {
383 		goto audit;
384 	} else if ((lperms.allow & MAY_EXEC) &&
385 		   !xindex_is_subset(lperms.xindex, perms.xindex)) {
386 		lperms.allow &= ~MAY_EXEC;
387 		request |= MAY_EXEC;
388 		info = "link not subset of target";
389 		goto audit;
390 	}
391 
392 done_tests:
393 	error = 0;
394 
395 audit:
396 	return aa_audit_file(profile, &lperms, OP_LINK, request, lname, tname,
397 			     NULL, cond->uid, info, error);
398 }
399 
400 /**
401  * aa_path_link - Handle hard link permission check
402  * @label: the label being enforced  (NOT NULL)
403  * @old_dentry: the target dentry  (NOT NULL)
404  * @new_dir: directory the new link will be created in  (NOT NULL)
405  * @new_dentry: the link being created  (NOT NULL)
406  *
407  * Handle the permission test for a link & target pair.  Permission
408  * is encoded as a pair where the link permission is determined
409  * first, and if allowed, the target is tested.  The target test
410  * is done from the point of the link match (not start of DFA)
411  * making the target permission dependent on the link permission match.
412  *
413  * The subset test if required forces that permissions granted
414  * on link are a subset of the permission granted to target.
415  *
416  * Returns: %0 if allowed else error
417  */
418 int aa_path_link(struct aa_label *label, struct dentry *old_dentry,
419 		 const struct path *new_dir, struct dentry *new_dentry)
420 {
421 	struct path link = { .mnt = new_dir->mnt, .dentry = new_dentry };
422 	struct path target = { .mnt = new_dir->mnt, .dentry = old_dentry };
423 	struct path_cond cond = {
424 		d_backing_inode(old_dentry)->i_uid,
425 		d_backing_inode(old_dentry)->i_mode
426 	};
427 	char *buffer = NULL, *buffer2 = NULL;
428 	struct aa_profile *profile;
429 	int error;
430 
431 	/* buffer freed below, lname is pointer in buffer */
432 	buffer = aa_get_buffer(false);
433 	buffer2 = aa_get_buffer(false);
434 	error = -ENOMEM;
435 	if (!buffer || !buffer2)
436 		goto out;
437 
438 	error = fn_for_each_confined(label, profile,
439 			profile_path_link(profile, &link, buffer, &target,
440 					  buffer2, &cond));
441 out:
442 	aa_put_buffer(buffer);
443 	aa_put_buffer(buffer2);
444 	return error;
445 }
446 
447 static void update_file_ctx(struct aa_file_ctx *fctx, struct aa_label *label,
448 			    u32 request)
449 {
450 	struct aa_label *l, *old;
451 
452 	/* update caching of label on file_ctx */
453 	spin_lock(&fctx->lock);
454 	old = rcu_dereference_protected(fctx->label,
455 					lockdep_is_held(&fctx->lock));
456 	l = aa_label_merge(old, label, GFP_ATOMIC);
457 	if (l) {
458 		if (l != old) {
459 			rcu_assign_pointer(fctx->label, l);
460 			aa_put_label(old);
461 		} else
462 			aa_put_label(l);
463 		fctx->allow |= request;
464 	}
465 	spin_unlock(&fctx->lock);
466 }
467 
468 static int __file_path_perm(const char *op, struct aa_label *label,
469 			    struct aa_label *flabel, struct file *file,
470 			    u32 request, u32 denied, bool in_atomic)
471 {
472 	struct aa_profile *profile;
473 	struct aa_perms perms = {};
474 	struct path_cond cond = {
475 		.uid = i_uid_into_mnt(file_mnt_user_ns(file), file_inode(file)),
476 		.mode = file_inode(file)->i_mode
477 	};
478 	char *buffer;
479 	int flags, error;
480 
481 	/* revalidation due to label out of date. No revocation at this time */
482 	if (!denied && aa_label_is_subset(flabel, label))
483 		/* TODO: check for revocation on stale profiles */
484 		return 0;
485 
486 	flags = PATH_DELEGATE_DELETED | (S_ISDIR(cond.mode) ? PATH_IS_DIR : 0);
487 	buffer = aa_get_buffer(in_atomic);
488 	if (!buffer)
489 		return -ENOMEM;
490 
491 	/* check every profile in task label not in current cache */
492 	error = fn_for_each_not_in_set(flabel, label, profile,
493 			profile_path_perm(op, profile, &file->f_path, buffer,
494 					  request, &cond, flags, &perms));
495 	if (denied && !error) {
496 		/*
497 		 * check every profile in file label that was not tested
498 		 * in the initial check above.
499 		 *
500 		 * TODO: cache full perms so this only happens because of
501 		 * conditionals
502 		 * TODO: don't audit here
503 		 */
504 		if (label == flabel)
505 			error = fn_for_each(label, profile,
506 				profile_path_perm(op, profile, &file->f_path,
507 						  buffer, request, &cond, flags,
508 						  &perms));
509 		else
510 			error = fn_for_each_not_in_set(label, flabel, profile,
511 				profile_path_perm(op, profile, &file->f_path,
512 						  buffer, request, &cond, flags,
513 						  &perms));
514 	}
515 	if (!error)
516 		update_file_ctx(file_ctx(file), label, request);
517 
518 	aa_put_buffer(buffer);
519 
520 	return error;
521 }
522 
523 static int __file_sock_perm(const char *op, struct aa_label *label,
524 			    struct aa_label *flabel, struct file *file,
525 			    u32 request, u32 denied)
526 {
527 	struct socket *sock = (struct socket *) file->private_data;
528 	int error;
529 
530 	AA_BUG(!sock);
531 
532 	/* revalidation due to label out of date. No revocation at this time */
533 	if (!denied && aa_label_is_subset(flabel, label))
534 		return 0;
535 
536 	/* TODO: improve to skip profiles cached in flabel */
537 	error = aa_sock_file_perm(label, op, request, sock);
538 	if (denied) {
539 		/* TODO: improve to skip profiles checked above */
540 		/* check every profile in file label to is cached */
541 		last_error(error, aa_sock_file_perm(flabel, op, request, sock));
542 	}
543 	if (!error)
544 		update_file_ctx(file_ctx(file), label, request);
545 
546 	return error;
547 }
548 
549 /**
550  * aa_file_perm - do permission revalidation check & audit for @file
551  * @op: operation being checked
552  * @label: label being enforced   (NOT NULL)
553  * @file: file to revalidate access permissions on  (NOT NULL)
554  * @request: requested permissions
555  * @in_atomic: whether allocations need to be done in atomic context
556  *
557  * Returns: %0 if access allowed else error
558  */
559 int aa_file_perm(const char *op, struct aa_label *label, struct file *file,
560 		 u32 request, bool in_atomic)
561 {
562 	struct aa_file_ctx *fctx;
563 	struct aa_label *flabel;
564 	u32 denied;
565 	int error = 0;
566 
567 	AA_BUG(!label);
568 	AA_BUG(!file);
569 
570 	fctx = file_ctx(file);
571 
572 	rcu_read_lock();
573 	flabel  = rcu_dereference(fctx->label);
574 	AA_BUG(!flabel);
575 
576 	/* revalidate access, if task is unconfined, or the cached cred
577 	 * doesn't match or if the request is for more permissions than
578 	 * was granted.
579 	 *
580 	 * Note: the test for !unconfined(flabel) is to handle file
581 	 *       delegation from unconfined tasks
582 	 */
583 	denied = request & ~fctx->allow;
584 	if (unconfined(label) || unconfined(flabel) ||
585 	    (!denied && aa_label_is_subset(flabel, label))) {
586 		rcu_read_unlock();
587 		goto done;
588 	}
589 
590 	flabel  = aa_get_newest_label(flabel);
591 	rcu_read_unlock();
592 	/* TODO: label cross check */
593 
594 	if (file->f_path.mnt && path_mediated_fs(file->f_path.dentry))
595 		error = __file_path_perm(op, label, flabel, file, request,
596 					 denied, in_atomic);
597 
598 	else if (S_ISSOCK(file_inode(file)->i_mode))
599 		error = __file_sock_perm(op, label, flabel, file, request,
600 					 denied);
601 	aa_put_label(flabel);
602 
603 done:
604 	return error;
605 }
606 
607 static void revalidate_tty(struct aa_label *label)
608 {
609 	struct tty_struct *tty;
610 	int drop_tty = 0;
611 
612 	tty = get_current_tty();
613 	if (!tty)
614 		return;
615 
616 	spin_lock(&tty->files_lock);
617 	if (!list_empty(&tty->tty_files)) {
618 		struct tty_file_private *file_priv;
619 		struct file *file;
620 		/* TODO: Revalidate access to controlling tty. */
621 		file_priv = list_first_entry(&tty->tty_files,
622 					     struct tty_file_private, list);
623 		file = file_priv->file;
624 
625 		if (aa_file_perm(OP_INHERIT, label, file, MAY_READ | MAY_WRITE,
626 				 IN_ATOMIC))
627 			drop_tty = 1;
628 	}
629 	spin_unlock(&tty->files_lock);
630 	tty_kref_put(tty);
631 
632 	if (drop_tty)
633 		no_tty();
634 }
635 
636 static int match_file(const void *p, struct file *file, unsigned int fd)
637 {
638 	struct aa_label *label = (struct aa_label *)p;
639 
640 	if (aa_file_perm(OP_INHERIT, label, file, aa_map_file_to_perms(file),
641 			 IN_ATOMIC))
642 		return fd + 1;
643 	return 0;
644 }
645 
646 
647 /* based on selinux's flush_unauthorized_files */
648 void aa_inherit_files(const struct cred *cred, struct files_struct *files)
649 {
650 	struct aa_label *label = aa_get_newest_cred_label(cred);
651 	struct file *devnull = NULL;
652 	unsigned int n;
653 
654 	revalidate_tty(label);
655 
656 	/* Revalidate access to inherited open files. */
657 	n = iterate_fd(files, 0, match_file, label);
658 	if (!n) /* none found? */
659 		goto out;
660 
661 	devnull = dentry_open(&aa_null, O_RDWR, cred);
662 	if (IS_ERR(devnull))
663 		devnull = NULL;
664 	/* replace all the matching ones with this */
665 	do {
666 		replace_fd(n - 1, devnull, 0);
667 	} while ((n = iterate_fd(files, n, match_file, label)) != 0);
668 	if (devnull)
669 		fput(devnull);
670 out:
671 	aa_put_label(label);
672 }
673