1 /* Postprocess module symbol versions 2 * 3 * Copyright 2003 Kai Germaschewski 4 * Copyright 2002-2004 Rusty Russell, IBM Corporation 5 * Copyright 2006-2008 Sam Ravnborg 6 * Based in part on module-init-tools/depmod.c,file2alias 7 * 8 * This software may be used and distributed according to the terms 9 * of the GNU General Public License, incorporated herein by reference. 10 * 11 * Usage: modpost vmlinux module1.o module2.o ... 12 */ 13 14 #define _GNU_SOURCE 15 #include <stdio.h> 16 #include <ctype.h> 17 #include "modpost.h" 18 #include "../../include/linux/license.h" 19 20 /* Are we using CONFIG_MODVERSIONS? */ 21 int modversions = 0; 22 /* Warn about undefined symbols? (do so if we have vmlinux) */ 23 int have_vmlinux = 0; 24 /* Is CONFIG_MODULE_SRCVERSION_ALL set? */ 25 static int all_versions = 0; 26 /* If we are modposting external module set to 1 */ 27 static int external_module = 0; 28 /* Warn about section mismatch in vmlinux if set to 1 */ 29 static int vmlinux_section_warnings = 1; 30 /* Only warn about unresolved symbols */ 31 static int warn_unresolved = 0; 32 /* How a symbol is exported */ 33 static int sec_mismatch_count = 0; 34 static int sec_mismatch_verbose = 1; 35 36 enum export { 37 export_plain, export_unused, export_gpl, 38 export_unused_gpl, export_gpl_future, export_unknown 39 }; 40 41 #define PRINTF __attribute__ ((format (printf, 1, 2))) 42 43 PRINTF void fatal(const char *fmt, ...) 44 { 45 va_list arglist; 46 47 fprintf(stderr, "FATAL: "); 48 49 va_start(arglist, fmt); 50 vfprintf(stderr, fmt, arglist); 51 va_end(arglist); 52 53 exit(1); 54 } 55 56 PRINTF void warn(const char *fmt, ...) 57 { 58 va_list arglist; 59 60 fprintf(stderr, "WARNING: "); 61 62 va_start(arglist, fmt); 63 vfprintf(stderr, fmt, arglist); 64 va_end(arglist); 65 } 66 67 PRINTF void merror(const char *fmt, ...) 68 { 69 va_list arglist; 70 71 fprintf(stderr, "ERROR: "); 72 73 va_start(arglist, fmt); 74 vfprintf(stderr, fmt, arglist); 75 va_end(arglist); 76 } 77 78 static int is_vmlinux(const char *modname) 79 { 80 const char *myname; 81 82 myname = strrchr(modname, '/'); 83 if (myname) 84 myname++; 85 else 86 myname = modname; 87 88 return (strcmp(myname, "vmlinux") == 0) || 89 (strcmp(myname, "vmlinux.o") == 0); 90 } 91 92 void *do_nofail(void *ptr, const char *expr) 93 { 94 if (!ptr) 95 fatal("modpost: Memory allocation failure: %s.\n", expr); 96 97 return ptr; 98 } 99 100 /* A list of all modules we processed */ 101 static struct module *modules; 102 103 static struct module *find_module(char *modname) 104 { 105 struct module *mod; 106 107 for (mod = modules; mod; mod = mod->next) 108 if (strcmp(mod->name, modname) == 0) 109 break; 110 return mod; 111 } 112 113 static struct module *new_module(char *modname) 114 { 115 struct module *mod; 116 char *p, *s; 117 118 mod = NOFAIL(malloc(sizeof(*mod))); 119 memset(mod, 0, sizeof(*mod)); 120 p = NOFAIL(strdup(modname)); 121 122 /* strip trailing .o */ 123 s = strrchr(p, '.'); 124 if (s != NULL) 125 if (strcmp(s, ".o") == 0) 126 *s = '\0'; 127 128 /* add to list */ 129 mod->name = p; 130 mod->gpl_compatible = -1; 131 mod->next = modules; 132 modules = mod; 133 134 return mod; 135 } 136 137 /* A hash of all exported symbols, 138 * struct symbol is also used for lists of unresolved symbols */ 139 140 #define SYMBOL_HASH_SIZE 1024 141 142 struct symbol { 143 struct symbol *next; 144 struct module *module; 145 unsigned int crc; 146 int crc_valid; 147 unsigned int weak:1; 148 unsigned int vmlinux:1; /* 1 if symbol is defined in vmlinux */ 149 unsigned int kernel:1; /* 1 if symbol is from kernel 150 * (only for external modules) **/ 151 unsigned int preloaded:1; /* 1 if symbol from Module.symvers */ 152 enum export export; /* Type of export */ 153 char name[0]; 154 }; 155 156 static struct symbol *symbolhash[SYMBOL_HASH_SIZE]; 157 158 /* This is based on the hash agorithm from gdbm, via tdb */ 159 static inline unsigned int tdb_hash(const char *name) 160 { 161 unsigned value; /* Used to compute the hash value. */ 162 unsigned i; /* Used to cycle through random values. */ 163 164 /* Set the initial value from the key size. */ 165 for (value = 0x238F13AF * strlen(name), i = 0; name[i]; i++) 166 value = (value + (((unsigned char *)name)[i] << (i*5 % 24))); 167 168 return (1103515243 * value + 12345); 169 } 170 171 /** 172 * Allocate a new symbols for use in the hash of exported symbols or 173 * the list of unresolved symbols per module 174 **/ 175 static struct symbol *alloc_symbol(const char *name, unsigned int weak, 176 struct symbol *next) 177 { 178 struct symbol *s = NOFAIL(malloc(sizeof(*s) + strlen(name) + 1)); 179 180 memset(s, 0, sizeof(*s)); 181 strcpy(s->name, name); 182 s->weak = weak; 183 s->next = next; 184 return s; 185 } 186 187 /* For the hash of exported symbols */ 188 static struct symbol *new_symbol(const char *name, struct module *module, 189 enum export export) 190 { 191 unsigned int hash; 192 struct symbol *new; 193 194 hash = tdb_hash(name) % SYMBOL_HASH_SIZE; 195 new = symbolhash[hash] = alloc_symbol(name, 0, symbolhash[hash]); 196 new->module = module; 197 new->export = export; 198 return new; 199 } 200 201 static struct symbol *find_symbol(const char *name) 202 { 203 struct symbol *s; 204 205 /* For our purposes, .foo matches foo. PPC64 needs this. */ 206 if (name[0] == '.') 207 name++; 208 209 for (s = symbolhash[tdb_hash(name) % SYMBOL_HASH_SIZE]; s; s = s->next) { 210 if (strcmp(s->name, name) == 0) 211 return s; 212 } 213 return NULL; 214 } 215 216 static struct { 217 const char *str; 218 enum export export; 219 } export_list[] = { 220 { .str = "EXPORT_SYMBOL", .export = export_plain }, 221 { .str = "EXPORT_UNUSED_SYMBOL", .export = export_unused }, 222 { .str = "EXPORT_SYMBOL_GPL", .export = export_gpl }, 223 { .str = "EXPORT_UNUSED_SYMBOL_GPL", .export = export_unused_gpl }, 224 { .str = "EXPORT_SYMBOL_GPL_FUTURE", .export = export_gpl_future }, 225 { .str = "(unknown)", .export = export_unknown }, 226 }; 227 228 229 static const char *export_str(enum export ex) 230 { 231 return export_list[ex].str; 232 } 233 234 static enum export export_no(const char *s) 235 { 236 int i; 237 238 if (!s) 239 return export_unknown; 240 for (i = 0; export_list[i].export != export_unknown; i++) { 241 if (strcmp(export_list[i].str, s) == 0) 242 return export_list[i].export; 243 } 244 return export_unknown; 245 } 246 247 static enum export export_from_sec(struct elf_info *elf, Elf_Section sec) 248 { 249 if (sec == elf->export_sec) 250 return export_plain; 251 else if (sec == elf->export_unused_sec) 252 return export_unused; 253 else if (sec == elf->export_gpl_sec) 254 return export_gpl; 255 else if (sec == elf->export_unused_gpl_sec) 256 return export_unused_gpl; 257 else if (sec == elf->export_gpl_future_sec) 258 return export_gpl_future; 259 else 260 return export_unknown; 261 } 262 263 /** 264 * Add an exported symbol - it may have already been added without a 265 * CRC, in this case just update the CRC 266 **/ 267 static struct symbol *sym_add_exported(const char *name, struct module *mod, 268 enum export export) 269 { 270 struct symbol *s = find_symbol(name); 271 272 if (!s) { 273 s = new_symbol(name, mod, export); 274 } else { 275 if (!s->preloaded) { 276 warn("%s: '%s' exported twice. Previous export " 277 "was in %s%s\n", mod->name, name, 278 s->module->name, 279 is_vmlinux(s->module->name) ?"":".ko"); 280 } else { 281 /* In case Modules.symvers was out of date */ 282 s->module = mod; 283 } 284 } 285 s->preloaded = 0; 286 s->vmlinux = is_vmlinux(mod->name); 287 s->kernel = 0; 288 s->export = export; 289 return s; 290 } 291 292 static void sym_update_crc(const char *name, struct module *mod, 293 unsigned int crc, enum export export) 294 { 295 struct symbol *s = find_symbol(name); 296 297 if (!s) 298 s = new_symbol(name, mod, export); 299 s->crc = crc; 300 s->crc_valid = 1; 301 } 302 303 void *grab_file(const char *filename, unsigned long *size) 304 { 305 struct stat st; 306 void *map; 307 int fd; 308 309 fd = open(filename, O_RDONLY); 310 if (fd < 0 || fstat(fd, &st) != 0) 311 return NULL; 312 313 *size = st.st_size; 314 map = mmap(NULL, *size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0); 315 close(fd); 316 317 if (map == MAP_FAILED) 318 return NULL; 319 return map; 320 } 321 322 /** 323 * Return a copy of the next line in a mmap'ed file. 324 * spaces in the beginning of the line is trimmed away. 325 * Return a pointer to a static buffer. 326 **/ 327 char *get_next_line(unsigned long *pos, void *file, unsigned long size) 328 { 329 static char line[4096]; 330 int skip = 1; 331 size_t len = 0; 332 signed char *p = (signed char *)file + *pos; 333 char *s = line; 334 335 for (; *pos < size ; (*pos)++) { 336 if (skip && isspace(*p)) { 337 p++; 338 continue; 339 } 340 skip = 0; 341 if (*p != '\n' && (*pos < size)) { 342 len++; 343 *s++ = *p++; 344 if (len > 4095) 345 break; /* Too long, stop */ 346 } else { 347 /* End of string */ 348 *s = '\0'; 349 return line; 350 } 351 } 352 /* End of buffer */ 353 return NULL; 354 } 355 356 void release_file(void *file, unsigned long size) 357 { 358 munmap(file, size); 359 } 360 361 static int parse_elf(struct elf_info *info, const char *filename) 362 { 363 unsigned int i; 364 Elf_Ehdr *hdr; 365 Elf_Shdr *sechdrs; 366 Elf_Sym *sym; 367 368 hdr = grab_file(filename, &info->size); 369 if (!hdr) { 370 perror(filename); 371 exit(1); 372 } 373 info->hdr = hdr; 374 if (info->size < sizeof(*hdr)) { 375 /* file too small, assume this is an empty .o file */ 376 return 0; 377 } 378 /* Is this a valid ELF file? */ 379 if ((hdr->e_ident[EI_MAG0] != ELFMAG0) || 380 (hdr->e_ident[EI_MAG1] != ELFMAG1) || 381 (hdr->e_ident[EI_MAG2] != ELFMAG2) || 382 (hdr->e_ident[EI_MAG3] != ELFMAG3)) { 383 /* Not an ELF file - silently ignore it */ 384 return 0; 385 } 386 /* Fix endianness in ELF header */ 387 hdr->e_shoff = TO_NATIVE(hdr->e_shoff); 388 hdr->e_shstrndx = TO_NATIVE(hdr->e_shstrndx); 389 hdr->e_shnum = TO_NATIVE(hdr->e_shnum); 390 hdr->e_machine = TO_NATIVE(hdr->e_machine); 391 hdr->e_type = TO_NATIVE(hdr->e_type); 392 sechdrs = (void *)hdr + hdr->e_shoff; 393 info->sechdrs = sechdrs; 394 395 /* Check if file offset is correct */ 396 if (hdr->e_shoff > info->size) { 397 fatal("section header offset=%lu in file '%s' is bigger than " 398 "filesize=%lu\n", (unsigned long)hdr->e_shoff, 399 filename, info->size); 400 return 0; 401 } 402 403 /* Fix endianness in section headers */ 404 for (i = 0; i < hdr->e_shnum; i++) { 405 sechdrs[i].sh_type = TO_NATIVE(sechdrs[i].sh_type); 406 sechdrs[i].sh_offset = TO_NATIVE(sechdrs[i].sh_offset); 407 sechdrs[i].sh_size = TO_NATIVE(sechdrs[i].sh_size); 408 sechdrs[i].sh_link = TO_NATIVE(sechdrs[i].sh_link); 409 sechdrs[i].sh_name = TO_NATIVE(sechdrs[i].sh_name); 410 sechdrs[i].sh_info = TO_NATIVE(sechdrs[i].sh_info); 411 sechdrs[i].sh_addr = TO_NATIVE(sechdrs[i].sh_addr); 412 } 413 /* Find symbol table. */ 414 for (i = 1; i < hdr->e_shnum; i++) { 415 const char *secstrings 416 = (void *)hdr + sechdrs[hdr->e_shstrndx].sh_offset; 417 const char *secname; 418 419 if (sechdrs[i].sh_offset > info->size) { 420 fatal("%s is truncated. sechdrs[i].sh_offset=%lu > " 421 "sizeof(*hrd)=%zu\n", filename, 422 (unsigned long)sechdrs[i].sh_offset, 423 sizeof(*hdr)); 424 return 0; 425 } 426 secname = secstrings + sechdrs[i].sh_name; 427 if (strcmp(secname, ".modinfo") == 0) { 428 info->modinfo = (void *)hdr + sechdrs[i].sh_offset; 429 info->modinfo_len = sechdrs[i].sh_size; 430 } else if (strcmp(secname, "__ksymtab") == 0) 431 info->export_sec = i; 432 else if (strcmp(secname, "__ksymtab_unused") == 0) 433 info->export_unused_sec = i; 434 else if (strcmp(secname, "__ksymtab_gpl") == 0) 435 info->export_gpl_sec = i; 436 else if (strcmp(secname, "__ksymtab_unused_gpl") == 0) 437 info->export_unused_gpl_sec = i; 438 else if (strcmp(secname, "__ksymtab_gpl_future") == 0) 439 info->export_gpl_future_sec = i; 440 else if (strcmp(secname, "__markers_strings") == 0) 441 info->markers_strings_sec = i; 442 443 if (sechdrs[i].sh_type != SHT_SYMTAB) 444 continue; 445 446 info->symtab_start = (void *)hdr + sechdrs[i].sh_offset; 447 info->symtab_stop = (void *)hdr + sechdrs[i].sh_offset 448 + sechdrs[i].sh_size; 449 info->strtab = (void *)hdr + 450 sechdrs[sechdrs[i].sh_link].sh_offset; 451 } 452 if (!info->symtab_start) 453 fatal("%s has no symtab?\n", filename); 454 455 /* Fix endianness in symbols */ 456 for (sym = info->symtab_start; sym < info->symtab_stop; sym++) { 457 sym->st_shndx = TO_NATIVE(sym->st_shndx); 458 sym->st_name = TO_NATIVE(sym->st_name); 459 sym->st_value = TO_NATIVE(sym->st_value); 460 sym->st_size = TO_NATIVE(sym->st_size); 461 } 462 return 1; 463 } 464 465 static void parse_elf_finish(struct elf_info *info) 466 { 467 release_file(info->hdr, info->size); 468 } 469 470 #define CRC_PFX MODULE_SYMBOL_PREFIX "__crc_" 471 #define KSYMTAB_PFX MODULE_SYMBOL_PREFIX "__ksymtab_" 472 473 static void handle_modversions(struct module *mod, struct elf_info *info, 474 Elf_Sym *sym, const char *symname) 475 { 476 unsigned int crc; 477 enum export export = export_from_sec(info, sym->st_shndx); 478 479 switch (sym->st_shndx) { 480 case SHN_COMMON: 481 warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name); 482 break; 483 case SHN_ABS: 484 /* CRC'd symbol */ 485 if (memcmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) { 486 crc = (unsigned int) sym->st_value; 487 sym_update_crc(symname + strlen(CRC_PFX), mod, crc, 488 export); 489 } 490 break; 491 case SHN_UNDEF: 492 /* undefined symbol */ 493 if (ELF_ST_BIND(sym->st_info) != STB_GLOBAL && 494 ELF_ST_BIND(sym->st_info) != STB_WEAK) 495 break; 496 /* ignore global offset table */ 497 if (strcmp(symname, "_GLOBAL_OFFSET_TABLE_") == 0) 498 break; 499 /* ignore __this_module, it will be resolved shortly */ 500 if (strcmp(symname, MODULE_SYMBOL_PREFIX "__this_module") == 0) 501 break; 502 /* cope with newer glibc (2.3.4 or higher) STT_ definition in elf.h */ 503 #if defined(STT_REGISTER) || defined(STT_SPARC_REGISTER) 504 /* add compatibility with older glibc */ 505 #ifndef STT_SPARC_REGISTER 506 #define STT_SPARC_REGISTER STT_REGISTER 507 #endif 508 if (info->hdr->e_machine == EM_SPARC || 509 info->hdr->e_machine == EM_SPARCV9) { 510 /* Ignore register directives. */ 511 if (ELF_ST_TYPE(sym->st_info) == STT_SPARC_REGISTER) 512 break; 513 if (symname[0] == '.') { 514 char *munged = strdup(symname); 515 munged[0] = '_'; 516 munged[1] = toupper(munged[1]); 517 symname = munged; 518 } 519 } 520 #endif 521 522 if (memcmp(symname, MODULE_SYMBOL_PREFIX, 523 strlen(MODULE_SYMBOL_PREFIX)) == 0) { 524 mod->unres = 525 alloc_symbol(symname + 526 strlen(MODULE_SYMBOL_PREFIX), 527 ELF_ST_BIND(sym->st_info) == STB_WEAK, 528 mod->unres); 529 } 530 break; 531 default: 532 /* All exported symbols */ 533 if (memcmp(symname, KSYMTAB_PFX, strlen(KSYMTAB_PFX)) == 0) { 534 sym_add_exported(symname + strlen(KSYMTAB_PFX), mod, 535 export); 536 } 537 if (strcmp(symname, MODULE_SYMBOL_PREFIX "init_module") == 0) 538 mod->has_init = 1; 539 if (strcmp(symname, MODULE_SYMBOL_PREFIX "cleanup_module") == 0) 540 mod->has_cleanup = 1; 541 break; 542 } 543 } 544 545 /** 546 * Parse tag=value strings from .modinfo section 547 **/ 548 static char *next_string(char *string, unsigned long *secsize) 549 { 550 /* Skip non-zero chars */ 551 while (string[0]) { 552 string++; 553 if ((*secsize)-- <= 1) 554 return NULL; 555 } 556 557 /* Skip any zero padding. */ 558 while (!string[0]) { 559 string++; 560 if ((*secsize)-- <= 1) 561 return NULL; 562 } 563 return string; 564 } 565 566 static char *get_next_modinfo(void *modinfo, unsigned long modinfo_len, 567 const char *tag, char *info) 568 { 569 char *p; 570 unsigned int taglen = strlen(tag); 571 unsigned long size = modinfo_len; 572 573 if (info) { 574 size -= info - (char *)modinfo; 575 modinfo = next_string(info, &size); 576 } 577 578 for (p = modinfo; p; p = next_string(p, &size)) { 579 if (strncmp(p, tag, taglen) == 0 && p[taglen] == '=') 580 return p + taglen + 1; 581 } 582 return NULL; 583 } 584 585 static char *get_modinfo(void *modinfo, unsigned long modinfo_len, 586 const char *tag) 587 588 { 589 return get_next_modinfo(modinfo, modinfo_len, tag, NULL); 590 } 591 592 /** 593 * Test if string s ends in string sub 594 * return 0 if match 595 **/ 596 static int strrcmp(const char *s, const char *sub) 597 { 598 int slen, sublen; 599 600 if (!s || !sub) 601 return 1; 602 603 slen = strlen(s); 604 sublen = strlen(sub); 605 606 if ((slen == 0) || (sublen == 0)) 607 return 1; 608 609 if (sublen > slen) 610 return 1; 611 612 return memcmp(s + slen - sublen, sub, sublen); 613 } 614 615 static const char *sym_name(struct elf_info *elf, Elf_Sym *sym) 616 { 617 if (sym) 618 return elf->strtab + sym->st_name; 619 else 620 return "(unknown)"; 621 } 622 623 static const char *sec_name(struct elf_info *elf, int shndx) 624 { 625 Elf_Shdr *sechdrs = elf->sechdrs; 626 return (void *)elf->hdr + 627 elf->sechdrs[elf->hdr->e_shstrndx].sh_offset + 628 sechdrs[shndx].sh_name; 629 } 630 631 static const char *sech_name(struct elf_info *elf, Elf_Shdr *sechdr) 632 { 633 return (void *)elf->hdr + 634 elf->sechdrs[elf->hdr->e_shstrndx].sh_offset + 635 sechdr->sh_name; 636 } 637 638 /* if sym is empty or point to a string 639 * like ".[0-9]+" then return 1. 640 * This is the optional prefix added by ld to some sections 641 */ 642 static int number_prefix(const char *sym) 643 { 644 if (*sym++ == '\0') 645 return 1; 646 if (*sym != '.') 647 return 0; 648 do { 649 char c = *sym++; 650 if (c < '0' || c > '9') 651 return 0; 652 } while (*sym); 653 return 1; 654 } 655 656 /* The pattern is an array of simple patterns. 657 * "foo" will match an exact string equal to "foo" 658 * "*foo" will match a string that ends with "foo" 659 * "foo*" will match a string that begins with "foo" 660 * "foo$" will match a string equal to "foo" or "foo.1" 661 * where the '1' can be any number including several digits. 662 * The $ syntax is for sections where ld append a dot number 663 * to make section name unique. 664 */ 665 int match(const char *sym, const char * const pat[]) 666 { 667 const char *p; 668 while (*pat) { 669 p = *pat++; 670 const char *endp = p + strlen(p) - 1; 671 672 /* "*foo" */ 673 if (*p == '*') { 674 if (strrcmp(sym, p + 1) == 0) 675 return 1; 676 } 677 /* "foo*" */ 678 else if (*endp == '*') { 679 if (strncmp(sym, p, strlen(p) - 1) == 0) 680 return 1; 681 } 682 /* "foo$" */ 683 else if (*endp == '$') { 684 if (strncmp(sym, p, strlen(p) - 1) == 0) { 685 if (number_prefix(sym + strlen(p) - 1)) 686 return 1; 687 } 688 } 689 /* no wildcards */ 690 else { 691 if (strcmp(p, sym) == 0) 692 return 1; 693 } 694 } 695 /* no match */ 696 return 0; 697 } 698 699 /* sections that we do not want to do full section mismatch check on */ 700 static const char *section_white_list[] = 701 { ".debug*", ".stab*", ".note*", ".got*", ".toc*", NULL }; 702 703 /* 704 * Is this section one we do not want to check? 705 * This is often debug sections. 706 * If we are going to check this section then 707 * test if section name ends with a dot and a number. 708 * This is used to find sections where the linker have 709 * appended a dot-number to make the name unique. 710 * The cause of this is often a section specified in assembler 711 * without "ax" / "aw" and the same section used in .c 712 * code where gcc add these. 713 */ 714 static int check_section(const char *modname, const char *sec) 715 { 716 const char *e = sec + strlen(sec) - 1; 717 if (match(sec, section_white_list)) 718 return 1; 719 720 if (*e && isdigit(*e)) { 721 /* consume all digits */ 722 while (*e && e != sec && isdigit(*e)) 723 e--; 724 if (*e == '.') { 725 warn("%s (%s): unexpected section name.\n" 726 "The (.[number]+) following section name are " 727 "ld generated and not expected.\n" 728 "Did you forget to use \"ax\"/\"aw\" " 729 "in a .S file?\n" 730 "Note that for example <linux/init.h> contains\n" 731 "section definitions for use in .S files.\n\n", 732 modname, sec); 733 } 734 } 735 return 0; 736 } 737 738 739 740 #define ALL_INIT_DATA_SECTIONS \ 741 ".init.data$", ".devinit.data$", ".cpuinit.data$", ".meminit.data$" 742 #define ALL_EXIT_DATA_SECTIONS \ 743 ".exit.data$", ".devexit.data$", ".cpuexit.data$", ".memexit.data$" 744 745 #define ALL_INIT_TEXT_SECTIONS \ 746 ".init.text$", ".devinit.text$", ".cpuinit.text$", ".meminit.text$" 747 #define ALL_EXIT_TEXT_SECTIONS \ 748 ".exit.text$", ".devexit.text$", ".cpuexit.text$", ".memexit.text$" 749 750 #define ALL_INIT_SECTIONS ALL_INIT_DATA_SECTIONS, ALL_INIT_TEXT_SECTIONS 751 #define ALL_EXIT_SECTIONS ALL_EXIT_DATA_SECTIONS, ALL_EXIT_TEXT_SECTIONS 752 753 #define DATA_SECTIONS ".data$", ".data.rel$" 754 #define TEXT_SECTIONS ".text$" 755 756 #define INIT_SECTIONS ".init.data$", ".init.text$" 757 #define DEV_INIT_SECTIONS ".devinit.data$", ".devinit.text$" 758 #define CPU_INIT_SECTIONS ".cpuinit.data$", ".cpuinit.text$" 759 #define MEM_INIT_SECTIONS ".meminit.data$", ".meminit.text$" 760 761 #define EXIT_SECTIONS ".exit.data$", ".exit.text$" 762 #define DEV_EXIT_SECTIONS ".devexit.data$", ".devexit.text$" 763 #define CPU_EXIT_SECTIONS ".cpuexit.data$", ".cpuexit.text$" 764 #define MEM_EXIT_SECTIONS ".memexit.data$", ".memexit.text$" 765 766 /* init data sections */ 767 static const char *init_data_sections[] = { ALL_INIT_DATA_SECTIONS, NULL }; 768 769 /* all init sections */ 770 static const char *init_sections[] = { ALL_INIT_SECTIONS, NULL }; 771 772 /* All init and exit sections (code + data) */ 773 static const char *init_exit_sections[] = 774 {ALL_INIT_SECTIONS, ALL_EXIT_SECTIONS, NULL }; 775 776 /* data section */ 777 static const char *data_sections[] = { DATA_SECTIONS, NULL }; 778 779 /* sections that may refer to an init/exit section with no warning */ 780 static const char *initref_sections[] = 781 { 782 ".text.init.refok*", 783 ".exit.text.refok*", 784 ".data.init.refok*", 785 NULL 786 }; 787 788 789 /* symbols in .data that may refer to init/exit sections */ 790 static const char *symbol_white_list[] = 791 { 792 "*driver", 793 "*_template", /* scsi uses *_template a lot */ 794 "*_timer", /* arm uses ops structures named _timer a lot */ 795 "*_sht", /* scsi also used *_sht to some extent */ 796 "*_ops", 797 "*_probe", 798 "*_probe_one", 799 "*_console", 800 NULL 801 }; 802 803 static const char *head_sections[] = { ".head.text*", NULL }; 804 static const char *linker_symbols[] = 805 { "__init_begin", "_sinittext", "_einittext", NULL }; 806 807 enum mismatch { 808 NO_MISMATCH, 809 TEXT_TO_INIT, 810 DATA_TO_INIT, 811 TEXT_TO_EXIT, 812 DATA_TO_EXIT, 813 XXXINIT_TO_INIT, 814 XXXEXIT_TO_EXIT, 815 INIT_TO_EXIT, 816 EXIT_TO_INIT, 817 EXPORT_TO_INIT_EXIT, 818 }; 819 820 struct sectioncheck { 821 const char *fromsec[20]; 822 const char *tosec[20]; 823 enum mismatch mismatch; 824 }; 825 826 const struct sectioncheck sectioncheck[] = { 827 /* Do not reference init/exit code/data from 828 * normal code and data 829 */ 830 { 831 .fromsec = { TEXT_SECTIONS, NULL }, 832 .tosec = { ALL_INIT_SECTIONS, NULL }, 833 .mismatch = TEXT_TO_INIT, 834 }, 835 { 836 .fromsec = { DATA_SECTIONS, NULL }, 837 .tosec = { ALL_INIT_SECTIONS, NULL }, 838 .mismatch = DATA_TO_INIT, 839 }, 840 { 841 .fromsec = { TEXT_SECTIONS, NULL }, 842 .tosec = { ALL_EXIT_SECTIONS, NULL }, 843 .mismatch = TEXT_TO_EXIT, 844 }, 845 { 846 .fromsec = { DATA_SECTIONS, NULL }, 847 .tosec = { ALL_EXIT_SECTIONS, NULL }, 848 .mismatch = DATA_TO_EXIT, 849 }, 850 /* Do not reference init code/data from devinit/cpuinit/meminit code/data */ 851 { 852 .fromsec = { DEV_INIT_SECTIONS, CPU_INIT_SECTIONS, MEM_INIT_SECTIONS, NULL }, 853 .tosec = { INIT_SECTIONS, NULL }, 854 .mismatch = XXXINIT_TO_INIT, 855 }, 856 /* Do not reference exit code/data from devexit/cpuexit/memexit code/data */ 857 { 858 .fromsec = { DEV_EXIT_SECTIONS, CPU_EXIT_SECTIONS, MEM_EXIT_SECTIONS, NULL }, 859 .tosec = { EXIT_SECTIONS, NULL }, 860 .mismatch = XXXEXIT_TO_EXIT, 861 }, 862 /* Do not use exit code/data from init code */ 863 { 864 .fromsec = { ALL_INIT_SECTIONS, NULL }, 865 .tosec = { ALL_EXIT_SECTIONS, NULL }, 866 .mismatch = INIT_TO_EXIT, 867 }, 868 /* Do not use init code/data from exit code */ 869 { 870 .fromsec = { ALL_EXIT_SECTIONS, NULL }, 871 .tosec = { ALL_INIT_SECTIONS, NULL }, 872 .mismatch = EXIT_TO_INIT, 873 }, 874 /* Do not export init/exit functions or data */ 875 { 876 .fromsec = { "__ksymtab*", NULL }, 877 .tosec = { INIT_SECTIONS, EXIT_SECTIONS, NULL }, 878 .mismatch = EXPORT_TO_INIT_EXIT 879 } 880 }; 881 882 static int section_mismatch(const char *fromsec, const char *tosec) 883 { 884 int i; 885 int elems = sizeof(sectioncheck) / sizeof(struct sectioncheck); 886 const struct sectioncheck *check = §ioncheck[0]; 887 888 for (i = 0; i < elems; i++) { 889 if (match(fromsec, check->fromsec) && 890 match(tosec, check->tosec)) 891 return check->mismatch; 892 check++; 893 } 894 return NO_MISMATCH; 895 } 896 897 /** 898 * Whitelist to allow certain references to pass with no warning. 899 * 900 * Pattern 0: 901 * Do not warn if funtion/data are marked with __init_refok/__initdata_refok. 902 * The pattern is identified by: 903 * fromsec = .text.init.refok* | .data.init.refok* 904 * 905 * Pattern 1: 906 * If a module parameter is declared __initdata and permissions=0 907 * then this is legal despite the warning generated. 908 * We cannot see value of permissions here, so just ignore 909 * this pattern. 910 * The pattern is identified by: 911 * tosec = .init.data 912 * fromsec = .data* 913 * atsym =__param* 914 * 915 * Pattern 2: 916 * Many drivers utilise a *driver container with references to 917 * add, remove, probe functions etc. 918 * These functions may often be marked __init and we do not want to 919 * warn here. 920 * the pattern is identified by: 921 * tosec = init or exit section 922 * fromsec = data section 923 * atsym = *driver, *_template, *_sht, *_ops, *_probe, 924 * *probe_one, *_console, *_timer 925 * 926 * Pattern 3: 927 * Whitelist all refereces from .text.head to .init.data 928 * Whitelist all refereces from .text.head to .init.text 929 * 930 * Pattern 4: 931 * Some symbols belong to init section but still it is ok to reference 932 * these from non-init sections as these symbols don't have any memory 933 * allocated for them and symbol address and value are same. So even 934 * if init section is freed, its ok to reference those symbols. 935 * For ex. symbols marking the init section boundaries. 936 * This pattern is identified by 937 * refsymname = __init_begin, _sinittext, _einittext 938 * 939 **/ 940 static int secref_whitelist(const char *fromsec, const char *fromsym, 941 const char *tosec, const char *tosym) 942 { 943 /* Check for pattern 0 */ 944 if (match(fromsec, initref_sections)) 945 return 0; 946 947 /* Check for pattern 1 */ 948 if (match(tosec, init_data_sections) && 949 match(fromsec, data_sections) && 950 (strncmp(fromsym, "__param", strlen("__param")) == 0)) 951 return 0; 952 953 /* Check for pattern 2 */ 954 if (match(tosec, init_exit_sections) && 955 match(fromsec, data_sections) && 956 match(fromsym, symbol_white_list)) 957 return 0; 958 959 /* Check for pattern 3 */ 960 if (match(fromsec, head_sections) && 961 match(tosec, init_sections)) 962 return 0; 963 964 /* Check for pattern 4 */ 965 if (match(tosym, linker_symbols)) 966 return 0; 967 968 return 1; 969 } 970 971 /** 972 * Find symbol based on relocation record info. 973 * In some cases the symbol supplied is a valid symbol so 974 * return refsym. If st_name != 0 we assume this is a valid symbol. 975 * In other cases the symbol needs to be looked up in the symbol table 976 * based on section and address. 977 * **/ 978 static Elf_Sym *find_elf_symbol(struct elf_info *elf, Elf64_Sword addr, 979 Elf_Sym *relsym) 980 { 981 Elf_Sym *sym; 982 Elf_Sym *near = NULL; 983 Elf64_Sword distance = 20; 984 Elf64_Sword d; 985 986 if (relsym->st_name != 0) 987 return relsym; 988 for (sym = elf->symtab_start; sym < elf->symtab_stop; sym++) { 989 if (sym->st_shndx != relsym->st_shndx) 990 continue; 991 if (ELF_ST_TYPE(sym->st_info) == STT_SECTION) 992 continue; 993 if (sym->st_value == addr) 994 return sym; 995 /* Find a symbol nearby - addr are maybe negative */ 996 d = sym->st_value - addr; 997 if (d < 0) 998 d = addr - sym->st_value; 999 if (d < distance) { 1000 distance = d; 1001 near = sym; 1002 } 1003 } 1004 /* We need a close match */ 1005 if (distance < 20) 1006 return near; 1007 else 1008 return NULL; 1009 } 1010 1011 static inline int is_arm_mapping_symbol(const char *str) 1012 { 1013 return str[0] == '$' && strchr("atd", str[1]) 1014 && (str[2] == '\0' || str[2] == '.'); 1015 } 1016 1017 /* 1018 * If there's no name there, ignore it; likewise, ignore it if it's 1019 * one of the magic symbols emitted used by current ARM tools. 1020 * 1021 * Otherwise if find_symbols_between() returns those symbols, they'll 1022 * fail the whitelist tests and cause lots of false alarms ... fixable 1023 * only by merging __exit and __init sections into __text, bloating 1024 * the kernel (which is especially evil on embedded platforms). 1025 */ 1026 static inline int is_valid_name(struct elf_info *elf, Elf_Sym *sym) 1027 { 1028 const char *name = elf->strtab + sym->st_name; 1029 1030 if (!name || !strlen(name)) 1031 return 0; 1032 return !is_arm_mapping_symbol(name); 1033 } 1034 1035 /* 1036 * Find symbols before or equal addr and after addr - in the section sec. 1037 * If we find two symbols with equal offset prefer one with a valid name. 1038 * The ELF format may have a better way to detect what type of symbol 1039 * it is, but this works for now. 1040 **/ 1041 static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr, 1042 const char *sec) 1043 { 1044 Elf_Sym *sym; 1045 Elf_Sym *near = NULL; 1046 Elf_Addr distance = ~0; 1047 1048 for (sym = elf->symtab_start; sym < elf->symtab_stop; sym++) { 1049 const char *symsec; 1050 1051 if (sym->st_shndx >= SHN_LORESERVE) 1052 continue; 1053 symsec = sec_name(elf, sym->st_shndx); 1054 if (strcmp(symsec, sec) != 0) 1055 continue; 1056 if (!is_valid_name(elf, sym)) 1057 continue; 1058 if (sym->st_value <= addr) { 1059 if ((addr - sym->st_value) < distance) { 1060 distance = addr - sym->st_value; 1061 near = sym; 1062 } else if ((addr - sym->st_value) == distance) { 1063 near = sym; 1064 } 1065 } 1066 } 1067 return near; 1068 } 1069 1070 /* 1071 * Convert a section name to the function/data attribute 1072 * .init.text => __init 1073 * .cpuinit.data => __cpudata 1074 * .memexitconst => __memconst 1075 * etc. 1076 */ 1077 static char *sec2annotation(const char *s) 1078 { 1079 if (match(s, init_exit_sections)) { 1080 char *p = malloc(20); 1081 char *r = p; 1082 1083 *p++ = '_'; 1084 *p++ = '_'; 1085 if (*s == '.') 1086 s++; 1087 while (*s && *s != '.') 1088 *p++ = *s++; 1089 *p = '\0'; 1090 if (*s == '.') 1091 s++; 1092 if (strstr(s, "rodata") != NULL) 1093 strcat(p, "const "); 1094 else if (strstr(s, "data") != NULL) 1095 strcat(p, "data "); 1096 else 1097 strcat(p, " "); 1098 return r; /* we leak her but we do not care */ 1099 } else { 1100 return ""; 1101 } 1102 } 1103 1104 static int is_function(Elf_Sym *sym) 1105 { 1106 if (sym) 1107 return ELF_ST_TYPE(sym->st_info) == STT_FUNC; 1108 else 1109 return -1; 1110 } 1111 1112 /* 1113 * Print a warning about a section mismatch. 1114 * Try to find symbols near it so user can find it. 1115 * Check whitelist before warning - it may be a false positive. 1116 */ 1117 static void report_sec_mismatch(const char *modname, enum mismatch mismatch, 1118 const char *fromsec, 1119 unsigned long long fromaddr, 1120 const char *fromsym, 1121 int from_is_func, 1122 const char *tosec, const char *tosym, 1123 int to_is_func) 1124 { 1125 const char *from, *from_p; 1126 const char *to, *to_p; 1127 1128 switch (from_is_func) { 1129 case 0: from = "variable"; from_p = ""; break; 1130 case 1: from = "function"; from_p = "()"; break; 1131 default: from = "(unknown reference)"; from_p = ""; break; 1132 } 1133 switch (to_is_func) { 1134 case 0: to = "variable"; to_p = ""; break; 1135 case 1: to = "function"; to_p = "()"; break; 1136 default: to = "(unknown reference)"; to_p = ""; break; 1137 } 1138 1139 sec_mismatch_count++; 1140 if (!sec_mismatch_verbose) 1141 return; 1142 1143 warn("%s(%s+0x%llx): Section mismatch in reference from the %s %s%s " 1144 "to the %s %s:%s%s\n", 1145 modname, fromsec, fromaddr, from, fromsym, from_p, to, tosec, 1146 tosym, to_p); 1147 1148 switch (mismatch) { 1149 case TEXT_TO_INIT: 1150 fprintf(stderr, 1151 "The function %s%s() references\n" 1152 "the %s %s%s%s.\n" 1153 "This is often because %s lacks a %s\n" 1154 "annotation or the annotation of %s is wrong.\n", 1155 sec2annotation(fromsec), fromsym, 1156 to, sec2annotation(tosec), tosym, to_p, 1157 fromsym, sec2annotation(tosec), tosym); 1158 break; 1159 case DATA_TO_INIT: { 1160 const char **s = symbol_white_list; 1161 fprintf(stderr, 1162 "The variable %s references\n" 1163 "the %s %s%s%s\n" 1164 "If the reference is valid then annotate the\n" 1165 "variable with __init* (see linux/init.h) " 1166 "or name the variable:\n", 1167 fromsym, to, sec2annotation(tosec), tosym, to_p); 1168 while (*s) 1169 fprintf(stderr, "%s, ", *s++); 1170 fprintf(stderr, "\n"); 1171 break; 1172 } 1173 case TEXT_TO_EXIT: 1174 fprintf(stderr, 1175 "The function %s() references a %s in an exit section.\n" 1176 "Often the %s %s%s has valid usage outside the exit section\n" 1177 "and the fix is to remove the %sannotation of %s.\n", 1178 fromsym, to, to, tosym, to_p, sec2annotation(tosec), tosym); 1179 break; 1180 case DATA_TO_EXIT: { 1181 const char **s = symbol_white_list; 1182 fprintf(stderr, 1183 "The variable %s references\n" 1184 "the %s %s%s%s\n" 1185 "If the reference is valid then annotate the\n" 1186 "variable with __exit* (see linux/init.h) or " 1187 "name the variable:\n", 1188 fromsym, to, sec2annotation(tosec), tosym, to_p); 1189 while (*s) 1190 fprintf(stderr, "%s, ", *s++); 1191 fprintf(stderr, "\n"); 1192 break; 1193 } 1194 case XXXINIT_TO_INIT: 1195 case XXXEXIT_TO_EXIT: 1196 fprintf(stderr, 1197 "The %s %s%s%s references\n" 1198 "a %s %s%s%s.\n" 1199 "If %s is only used by %s then\n" 1200 "annotate %s with a matching annotation.\n", 1201 from, sec2annotation(fromsec), fromsym, from_p, 1202 to, sec2annotation(tosec), tosym, to_p, 1203 tosym, fromsym, tosym); 1204 break; 1205 case INIT_TO_EXIT: 1206 fprintf(stderr, 1207 "The %s %s%s%s references\n" 1208 "a %s %s%s%s.\n" 1209 "This is often seen when error handling " 1210 "in the init function\n" 1211 "uses functionality in the exit path.\n" 1212 "The fix is often to remove the %sannotation of\n" 1213 "%s%s so it may be used outside an exit section.\n", 1214 from, sec2annotation(fromsec), fromsym, from_p, 1215 to, sec2annotation(tosec), tosym, to_p, 1216 sec2annotation(tosec), tosym, to_p); 1217 break; 1218 case EXIT_TO_INIT: 1219 fprintf(stderr, 1220 "The %s %s%s%s references\n" 1221 "a %s %s%s%s.\n" 1222 "This is often seen when error handling " 1223 "in the exit function\n" 1224 "uses functionality in the init path.\n" 1225 "The fix is often to remove the %sannotation of\n" 1226 "%s%s so it may be used outside an init section.\n", 1227 from, sec2annotation(fromsec), fromsym, from_p, 1228 to, sec2annotation(tosec), tosym, to_p, 1229 sec2annotation(tosec), tosym, to_p); 1230 break; 1231 case EXPORT_TO_INIT_EXIT: 1232 fprintf(stderr, 1233 "The symbol %s is exported and annotated %s\n" 1234 "Fix this by removing the %sannotation of %s " 1235 "or drop the export.\n", 1236 tosym, sec2annotation(tosec), sec2annotation(tosec), tosym); 1237 case NO_MISMATCH: 1238 /* To get warnings on missing members */ 1239 break; 1240 } 1241 fprintf(stderr, "\n"); 1242 } 1243 1244 static void check_section_mismatch(const char *modname, struct elf_info *elf, 1245 Elf_Rela *r, Elf_Sym *sym, const char *fromsec) 1246 { 1247 const char *tosec; 1248 enum mismatch mismatch; 1249 1250 tosec = sec_name(elf, sym->st_shndx); 1251 mismatch = section_mismatch(fromsec, tosec); 1252 if (mismatch != NO_MISMATCH) { 1253 Elf_Sym *to; 1254 Elf_Sym *from; 1255 const char *tosym; 1256 const char *fromsym; 1257 1258 from = find_elf_symbol2(elf, r->r_offset, fromsec); 1259 fromsym = sym_name(elf, from); 1260 to = find_elf_symbol(elf, r->r_addend, sym); 1261 tosym = sym_name(elf, to); 1262 1263 /* check whitelist - we may ignore it */ 1264 if (secref_whitelist(fromsec, fromsym, tosec, tosym)) { 1265 report_sec_mismatch(modname, mismatch, 1266 fromsec, r->r_offset, fromsym, 1267 is_function(from), tosec, tosym, 1268 is_function(to)); 1269 } 1270 } 1271 } 1272 1273 static unsigned int *reloc_location(struct elf_info *elf, 1274 Elf_Shdr *sechdr, Elf_Rela *r) 1275 { 1276 Elf_Shdr *sechdrs = elf->sechdrs; 1277 int section = sechdr->sh_info; 1278 1279 return (void *)elf->hdr + sechdrs[section].sh_offset + 1280 (r->r_offset - sechdrs[section].sh_addr); 1281 } 1282 1283 static int addend_386_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) 1284 { 1285 unsigned int r_typ = ELF_R_TYPE(r->r_info); 1286 unsigned int *location = reloc_location(elf, sechdr, r); 1287 1288 switch (r_typ) { 1289 case R_386_32: 1290 r->r_addend = TO_NATIVE(*location); 1291 break; 1292 case R_386_PC32: 1293 r->r_addend = TO_NATIVE(*location) + 4; 1294 /* For CONFIG_RELOCATABLE=y */ 1295 if (elf->hdr->e_type == ET_EXEC) 1296 r->r_addend += r->r_offset; 1297 break; 1298 } 1299 return 0; 1300 } 1301 1302 static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) 1303 { 1304 unsigned int r_typ = ELF_R_TYPE(r->r_info); 1305 1306 switch (r_typ) { 1307 case R_ARM_ABS32: 1308 /* From ARM ABI: (S + A) | T */ 1309 r->r_addend = (int)(long) 1310 (elf->symtab_start + ELF_R_SYM(r->r_info)); 1311 break; 1312 case R_ARM_PC24: 1313 /* From ARM ABI: ((S + A) | T) - P */ 1314 r->r_addend = (int)(long)(elf->hdr + 1315 sechdr->sh_offset + 1316 (r->r_offset - sechdr->sh_addr)); 1317 break; 1318 default: 1319 return 1; 1320 } 1321 return 0; 1322 } 1323 1324 static int addend_mips_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r) 1325 { 1326 unsigned int r_typ = ELF_R_TYPE(r->r_info); 1327 unsigned int *location = reloc_location(elf, sechdr, r); 1328 unsigned int inst; 1329 1330 if (r_typ == R_MIPS_HI16) 1331 return 1; /* skip this */ 1332 inst = TO_NATIVE(*location); 1333 switch (r_typ) { 1334 case R_MIPS_LO16: 1335 r->r_addend = inst & 0xffff; 1336 break; 1337 case R_MIPS_26: 1338 r->r_addend = (inst & 0x03ffffff) << 2; 1339 break; 1340 case R_MIPS_32: 1341 r->r_addend = inst; 1342 break; 1343 } 1344 return 0; 1345 } 1346 1347 static void section_rela(const char *modname, struct elf_info *elf, 1348 Elf_Shdr *sechdr) 1349 { 1350 Elf_Sym *sym; 1351 Elf_Rela *rela; 1352 Elf_Rela r; 1353 unsigned int r_sym; 1354 const char *fromsec; 1355 1356 Elf_Rela *start = (void *)elf->hdr + sechdr->sh_offset; 1357 Elf_Rela *stop = (void *)start + sechdr->sh_size; 1358 1359 fromsec = sech_name(elf, sechdr); 1360 fromsec += strlen(".rela"); 1361 /* if from section (name) is know good then skip it */ 1362 if (check_section(modname, fromsec)) 1363 return; 1364 1365 for (rela = start; rela < stop; rela++) { 1366 r.r_offset = TO_NATIVE(rela->r_offset); 1367 #if KERNEL_ELFCLASS == ELFCLASS64 1368 if (elf->hdr->e_machine == EM_MIPS) { 1369 unsigned int r_typ; 1370 r_sym = ELF64_MIPS_R_SYM(rela->r_info); 1371 r_sym = TO_NATIVE(r_sym); 1372 r_typ = ELF64_MIPS_R_TYPE(rela->r_info); 1373 r.r_info = ELF64_R_INFO(r_sym, r_typ); 1374 } else { 1375 r.r_info = TO_NATIVE(rela->r_info); 1376 r_sym = ELF_R_SYM(r.r_info); 1377 } 1378 #else 1379 r.r_info = TO_NATIVE(rela->r_info); 1380 r_sym = ELF_R_SYM(r.r_info); 1381 #endif 1382 r.r_addend = TO_NATIVE(rela->r_addend); 1383 sym = elf->symtab_start + r_sym; 1384 /* Skip special sections */ 1385 if (sym->st_shndx >= SHN_LORESERVE) 1386 continue; 1387 check_section_mismatch(modname, elf, &r, sym, fromsec); 1388 } 1389 } 1390 1391 static void section_rel(const char *modname, struct elf_info *elf, 1392 Elf_Shdr *sechdr) 1393 { 1394 Elf_Sym *sym; 1395 Elf_Rel *rel; 1396 Elf_Rela r; 1397 unsigned int r_sym; 1398 const char *fromsec; 1399 1400 Elf_Rel *start = (void *)elf->hdr + sechdr->sh_offset; 1401 Elf_Rel *stop = (void *)start + sechdr->sh_size; 1402 1403 fromsec = sech_name(elf, sechdr); 1404 fromsec += strlen(".rel"); 1405 /* if from section (name) is know good then skip it */ 1406 if (check_section(modname, fromsec)) 1407 return; 1408 1409 for (rel = start; rel < stop; rel++) { 1410 r.r_offset = TO_NATIVE(rel->r_offset); 1411 #if KERNEL_ELFCLASS == ELFCLASS64 1412 if (elf->hdr->e_machine == EM_MIPS) { 1413 unsigned int r_typ; 1414 r_sym = ELF64_MIPS_R_SYM(rel->r_info); 1415 r_sym = TO_NATIVE(r_sym); 1416 r_typ = ELF64_MIPS_R_TYPE(rel->r_info); 1417 r.r_info = ELF64_R_INFO(r_sym, r_typ); 1418 } else { 1419 r.r_info = TO_NATIVE(rel->r_info); 1420 r_sym = ELF_R_SYM(r.r_info); 1421 } 1422 #else 1423 r.r_info = TO_NATIVE(rel->r_info); 1424 r_sym = ELF_R_SYM(r.r_info); 1425 #endif 1426 r.r_addend = 0; 1427 switch (elf->hdr->e_machine) { 1428 case EM_386: 1429 if (addend_386_rel(elf, sechdr, &r)) 1430 continue; 1431 break; 1432 case EM_ARM: 1433 if (addend_arm_rel(elf, sechdr, &r)) 1434 continue; 1435 break; 1436 case EM_MIPS: 1437 if (addend_mips_rel(elf, sechdr, &r)) 1438 continue; 1439 break; 1440 } 1441 sym = elf->symtab_start + r_sym; 1442 /* Skip special sections */ 1443 if (sym->st_shndx >= SHN_LORESERVE) 1444 continue; 1445 check_section_mismatch(modname, elf, &r, sym, fromsec); 1446 } 1447 } 1448 1449 /** 1450 * A module includes a number of sections that are discarded 1451 * either when loaded or when used as built-in. 1452 * For loaded modules all functions marked __init and all data 1453 * marked __initdata will be discarded when the module has been intialized. 1454 * Likewise for modules used built-in the sections marked __exit 1455 * are discarded because __exit marked function are supposed to be called 1456 * only when a moduel is unloaded which never happes for built-in modules. 1457 * The check_sec_ref() function traverses all relocation records 1458 * to find all references to a section that reference a section that will 1459 * be discarded and warns about it. 1460 **/ 1461 static void check_sec_ref(struct module *mod, const char *modname, 1462 struct elf_info *elf) 1463 { 1464 int i; 1465 Elf_Shdr *sechdrs = elf->sechdrs; 1466 1467 /* Walk through all sections */ 1468 for (i = 0; i < elf->hdr->e_shnum; i++) { 1469 /* We want to process only relocation sections and not .init */ 1470 if (sechdrs[i].sh_type == SHT_RELA) 1471 section_rela(modname, elf, &elf->sechdrs[i]); 1472 else if (sechdrs[i].sh_type == SHT_REL) 1473 section_rel(modname, elf, &elf->sechdrs[i]); 1474 } 1475 } 1476 1477 static void get_markers(struct elf_info *info, struct module *mod) 1478 { 1479 const Elf_Shdr *sh = &info->sechdrs[info->markers_strings_sec]; 1480 const char *strings = (const char *) info->hdr + sh->sh_offset; 1481 const Elf_Sym *sym, *first_sym, *last_sym; 1482 size_t n; 1483 1484 if (!info->markers_strings_sec) 1485 return; 1486 1487 /* 1488 * First count the strings. We look for all the symbols defined 1489 * in the __markers_strings section named __mstrtab_*. For 1490 * these local names, the compiler puts a random .NNN suffix on, 1491 * so the names don't correspond exactly. 1492 */ 1493 first_sym = last_sym = NULL; 1494 n = 0; 1495 for (sym = info->symtab_start; sym < info->symtab_stop; sym++) 1496 if (ELF_ST_TYPE(sym->st_info) == STT_OBJECT && 1497 sym->st_shndx == info->markers_strings_sec && 1498 !strncmp(info->strtab + sym->st_name, 1499 "__mstrtab_", sizeof "__mstrtab_" - 1)) { 1500 if (first_sym == NULL) 1501 first_sym = sym; 1502 last_sym = sym; 1503 ++n; 1504 } 1505 1506 if (n == 0) 1507 return; 1508 1509 /* 1510 * Now collect each name and format into a line for the output. 1511 * Lines look like: 1512 * marker_name vmlinux marker %s format %d 1513 * The format string after the second \t can use whitespace. 1514 */ 1515 mod->markers = NOFAIL(malloc(sizeof mod->markers[0] * n)); 1516 mod->nmarkers = n; 1517 1518 n = 0; 1519 for (sym = first_sym; sym <= last_sym; sym++) 1520 if (ELF_ST_TYPE(sym->st_info) == STT_OBJECT && 1521 sym->st_shndx == info->markers_strings_sec && 1522 !strncmp(info->strtab + sym->st_name, 1523 "__mstrtab_", sizeof "__mstrtab_" - 1)) { 1524 const char *name = strings + sym->st_value; 1525 const char *fmt = strchr(name, '\0') + 1; 1526 char *line = NULL; 1527 asprintf(&line, "%s\t%s\t%s\n", name, mod->name, fmt); 1528 NOFAIL(line); 1529 mod->markers[n++] = line; 1530 } 1531 } 1532 1533 static void read_symbols(char *modname) 1534 { 1535 const char *symname; 1536 char *version; 1537 char *license; 1538 struct module *mod; 1539 struct elf_info info = { }; 1540 Elf_Sym *sym; 1541 1542 if (!parse_elf(&info, modname)) 1543 return; 1544 1545 mod = new_module(modname); 1546 1547 /* When there's no vmlinux, don't print warnings about 1548 * unresolved symbols (since there'll be too many ;) */ 1549 if (is_vmlinux(modname)) { 1550 have_vmlinux = 1; 1551 mod->skip = 1; 1552 } 1553 1554 license = get_modinfo(info.modinfo, info.modinfo_len, "license"); 1555 while (license) { 1556 if (license_is_gpl_compatible(license)) 1557 mod->gpl_compatible = 1; 1558 else { 1559 mod->gpl_compatible = 0; 1560 break; 1561 } 1562 license = get_next_modinfo(info.modinfo, info.modinfo_len, 1563 "license", license); 1564 } 1565 1566 for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { 1567 symname = info.strtab + sym->st_name; 1568 1569 handle_modversions(mod, &info, sym, symname); 1570 handle_moddevtable(mod, &info, sym, symname); 1571 } 1572 if (!is_vmlinux(modname) || 1573 (is_vmlinux(modname) && vmlinux_section_warnings)) 1574 check_sec_ref(mod, modname, &info); 1575 1576 version = get_modinfo(info.modinfo, info.modinfo_len, "version"); 1577 if (version) 1578 maybe_frob_rcs_version(modname, version, info.modinfo, 1579 version - (char *)info.hdr); 1580 if (version || (all_versions && !is_vmlinux(modname))) 1581 get_src_version(modname, mod->srcversion, 1582 sizeof(mod->srcversion)-1); 1583 1584 get_markers(&info, mod); 1585 1586 parse_elf_finish(&info); 1587 1588 /* Our trick to get versioning for struct_module - it's 1589 * never passed as an argument to an exported function, so 1590 * the automatic versioning doesn't pick it up, but it's really 1591 * important anyhow */ 1592 if (modversions) 1593 mod->unres = alloc_symbol("struct_module", 0, mod->unres); 1594 } 1595 1596 #define SZ 500 1597 1598 /* We first write the generated file into memory using the 1599 * following helper, then compare to the file on disk and 1600 * only update the later if anything changed */ 1601 1602 void __attribute__((format(printf, 2, 3))) buf_printf(struct buffer *buf, 1603 const char *fmt, ...) 1604 { 1605 char tmp[SZ]; 1606 int len; 1607 va_list ap; 1608 1609 va_start(ap, fmt); 1610 len = vsnprintf(tmp, SZ, fmt, ap); 1611 buf_write(buf, tmp, len); 1612 va_end(ap); 1613 } 1614 1615 void buf_write(struct buffer *buf, const char *s, int len) 1616 { 1617 if (buf->size - buf->pos < len) { 1618 buf->size += len + SZ; 1619 buf->p = realloc(buf->p, buf->size); 1620 } 1621 strncpy(buf->p + buf->pos, s, len); 1622 buf->pos += len; 1623 } 1624 1625 static void check_for_gpl_usage(enum export exp, const char *m, const char *s) 1626 { 1627 const char *e = is_vmlinux(m) ?"":".ko"; 1628 1629 switch (exp) { 1630 case export_gpl: 1631 fatal("modpost: GPL-incompatible module %s%s " 1632 "uses GPL-only symbol '%s'\n", m, e, s); 1633 break; 1634 case export_unused_gpl: 1635 fatal("modpost: GPL-incompatible module %s%s " 1636 "uses GPL-only symbol marked UNUSED '%s'\n", m, e, s); 1637 break; 1638 case export_gpl_future: 1639 warn("modpost: GPL-incompatible module %s%s " 1640 "uses future GPL-only symbol '%s'\n", m, e, s); 1641 break; 1642 case export_plain: 1643 case export_unused: 1644 case export_unknown: 1645 /* ignore */ 1646 break; 1647 } 1648 } 1649 1650 static void check_for_unused(enum export exp, const char *m, const char *s) 1651 { 1652 const char *e = is_vmlinux(m) ?"":".ko"; 1653 1654 switch (exp) { 1655 case export_unused: 1656 case export_unused_gpl: 1657 warn("modpost: module %s%s " 1658 "uses symbol '%s' marked UNUSED\n", m, e, s); 1659 break; 1660 default: 1661 /* ignore */ 1662 break; 1663 } 1664 } 1665 1666 static void check_exports(struct module *mod) 1667 { 1668 struct symbol *s, *exp; 1669 1670 for (s = mod->unres; s; s = s->next) { 1671 const char *basename; 1672 exp = find_symbol(s->name); 1673 if (!exp || exp->module == mod) 1674 continue; 1675 basename = strrchr(mod->name, '/'); 1676 if (basename) 1677 basename++; 1678 else 1679 basename = mod->name; 1680 if (!mod->gpl_compatible) 1681 check_for_gpl_usage(exp->export, basename, exp->name); 1682 check_for_unused(exp->export, basename, exp->name); 1683 } 1684 } 1685 1686 /** 1687 * Header for the generated file 1688 **/ 1689 static void add_header(struct buffer *b, struct module *mod) 1690 { 1691 buf_printf(b, "#include <linux/module.h>\n"); 1692 buf_printf(b, "#include <linux/vermagic.h>\n"); 1693 buf_printf(b, "#include <linux/compiler.h>\n"); 1694 buf_printf(b, "\n"); 1695 buf_printf(b, "MODULE_INFO(vermagic, VERMAGIC_STRING);\n"); 1696 buf_printf(b, "\n"); 1697 buf_printf(b, "struct module __this_module\n"); 1698 buf_printf(b, "__attribute__((section(\".gnu.linkonce.this_module\"))) = {\n"); 1699 buf_printf(b, " .name = KBUILD_MODNAME,\n"); 1700 if (mod->has_init) 1701 buf_printf(b, " .init = init_module,\n"); 1702 if (mod->has_cleanup) 1703 buf_printf(b, "#ifdef CONFIG_MODULE_UNLOAD\n" 1704 " .exit = cleanup_module,\n" 1705 "#endif\n"); 1706 buf_printf(b, " .arch = MODULE_ARCH_INIT,\n"); 1707 buf_printf(b, "};\n"); 1708 } 1709 1710 /** 1711 * Record CRCs for unresolved symbols 1712 **/ 1713 static int add_versions(struct buffer *b, struct module *mod) 1714 { 1715 struct symbol *s, *exp; 1716 int err = 0; 1717 1718 for (s = mod->unres; s; s = s->next) { 1719 exp = find_symbol(s->name); 1720 if (!exp || exp->module == mod) { 1721 if (have_vmlinux && !s->weak) { 1722 if (warn_unresolved) { 1723 warn("\"%s\" [%s.ko] undefined!\n", 1724 s->name, mod->name); 1725 } else { 1726 merror("\"%s\" [%s.ko] undefined!\n", 1727 s->name, mod->name); 1728 err = 1; 1729 } 1730 } 1731 continue; 1732 } 1733 s->module = exp->module; 1734 s->crc_valid = exp->crc_valid; 1735 s->crc = exp->crc; 1736 } 1737 1738 if (!modversions) 1739 return err; 1740 1741 buf_printf(b, "\n"); 1742 buf_printf(b, "static const struct modversion_info ____versions[]\n"); 1743 buf_printf(b, "__used\n"); 1744 buf_printf(b, "__attribute__((section(\"__versions\"))) = {\n"); 1745 1746 for (s = mod->unres; s; s = s->next) { 1747 if (!s->module) 1748 continue; 1749 if (!s->crc_valid) { 1750 warn("\"%s\" [%s.ko] has no CRC!\n", 1751 s->name, mod->name); 1752 continue; 1753 } 1754 buf_printf(b, "\t{ %#8x, \"%s\" },\n", s->crc, s->name); 1755 } 1756 1757 buf_printf(b, "};\n"); 1758 1759 return err; 1760 } 1761 1762 static void add_depends(struct buffer *b, struct module *mod, 1763 struct module *modules) 1764 { 1765 struct symbol *s; 1766 struct module *m; 1767 int first = 1; 1768 1769 for (m = modules; m; m = m->next) 1770 m->seen = is_vmlinux(m->name); 1771 1772 buf_printf(b, "\n"); 1773 buf_printf(b, "static const char __module_depends[]\n"); 1774 buf_printf(b, "__used\n"); 1775 buf_printf(b, "__attribute__((section(\".modinfo\"))) =\n"); 1776 buf_printf(b, "\"depends="); 1777 for (s = mod->unres; s; s = s->next) { 1778 const char *p; 1779 if (!s->module) 1780 continue; 1781 1782 if (s->module->seen) 1783 continue; 1784 1785 s->module->seen = 1; 1786 p = strrchr(s->module->name, '/'); 1787 if (p) 1788 p++; 1789 else 1790 p = s->module->name; 1791 buf_printf(b, "%s%s", first ? "" : ",", p); 1792 first = 0; 1793 } 1794 buf_printf(b, "\";\n"); 1795 } 1796 1797 static void add_srcversion(struct buffer *b, struct module *mod) 1798 { 1799 if (mod->srcversion[0]) { 1800 buf_printf(b, "\n"); 1801 buf_printf(b, "MODULE_INFO(srcversion, \"%s\");\n", 1802 mod->srcversion); 1803 } 1804 } 1805 1806 static void write_if_changed(struct buffer *b, const char *fname) 1807 { 1808 char *tmp; 1809 FILE *file; 1810 struct stat st; 1811 1812 file = fopen(fname, "r"); 1813 if (!file) 1814 goto write; 1815 1816 if (fstat(fileno(file), &st) < 0) 1817 goto close_write; 1818 1819 if (st.st_size != b->pos) 1820 goto close_write; 1821 1822 tmp = NOFAIL(malloc(b->pos)); 1823 if (fread(tmp, 1, b->pos, file) != b->pos) 1824 goto free_write; 1825 1826 if (memcmp(tmp, b->p, b->pos) != 0) 1827 goto free_write; 1828 1829 free(tmp); 1830 fclose(file); 1831 return; 1832 1833 free_write: 1834 free(tmp); 1835 close_write: 1836 fclose(file); 1837 write: 1838 file = fopen(fname, "w"); 1839 if (!file) { 1840 perror(fname); 1841 exit(1); 1842 } 1843 if (fwrite(b->p, 1, b->pos, file) != b->pos) { 1844 perror(fname); 1845 exit(1); 1846 } 1847 fclose(file); 1848 } 1849 1850 /* parse Module.symvers file. line format: 1851 * 0x12345678<tab>symbol<tab>module[[<tab>export]<tab>something] 1852 **/ 1853 static void read_dump(const char *fname, unsigned int kernel) 1854 { 1855 unsigned long size, pos = 0; 1856 void *file = grab_file(fname, &size); 1857 char *line; 1858 1859 if (!file) 1860 /* No symbol versions, silently ignore */ 1861 return; 1862 1863 while ((line = get_next_line(&pos, file, size))) { 1864 char *symname, *modname, *d, *export, *end; 1865 unsigned int crc; 1866 struct module *mod; 1867 struct symbol *s; 1868 1869 if (!(symname = strchr(line, '\t'))) 1870 goto fail; 1871 *symname++ = '\0'; 1872 if (!(modname = strchr(symname, '\t'))) 1873 goto fail; 1874 *modname++ = '\0'; 1875 if ((export = strchr(modname, '\t')) != NULL) 1876 *export++ = '\0'; 1877 if (export && ((end = strchr(export, '\t')) != NULL)) 1878 *end = '\0'; 1879 crc = strtoul(line, &d, 16); 1880 if (*symname == '\0' || *modname == '\0' || *d != '\0') 1881 goto fail; 1882 mod = find_module(modname); 1883 if (!mod) { 1884 if (is_vmlinux(modname)) 1885 have_vmlinux = 1; 1886 mod = new_module(NOFAIL(strdup(modname))); 1887 mod->skip = 1; 1888 } 1889 s = sym_add_exported(symname, mod, export_no(export)); 1890 s->kernel = kernel; 1891 s->preloaded = 1; 1892 sym_update_crc(symname, mod, crc, export_no(export)); 1893 } 1894 return; 1895 fail: 1896 fatal("parse error in symbol dump file\n"); 1897 } 1898 1899 /* For normal builds always dump all symbols. 1900 * For external modules only dump symbols 1901 * that are not read from kernel Module.symvers. 1902 **/ 1903 static int dump_sym(struct symbol *sym) 1904 { 1905 if (!external_module) 1906 return 1; 1907 if (sym->vmlinux || sym->kernel) 1908 return 0; 1909 return 1; 1910 } 1911 1912 static void write_dump(const char *fname) 1913 { 1914 struct buffer buf = { }; 1915 struct symbol *symbol; 1916 int n; 1917 1918 for (n = 0; n < SYMBOL_HASH_SIZE ; n++) { 1919 symbol = symbolhash[n]; 1920 while (symbol) { 1921 if (dump_sym(symbol)) 1922 buf_printf(&buf, "0x%08x\t%s\t%s\t%s\n", 1923 symbol->crc, symbol->name, 1924 symbol->module->name, 1925 export_str(symbol->export)); 1926 symbol = symbol->next; 1927 } 1928 } 1929 write_if_changed(&buf, fname); 1930 } 1931 1932 static void add_marker(struct module *mod, const char *name, const char *fmt) 1933 { 1934 char *line = NULL; 1935 asprintf(&line, "%s\t%s\t%s\n", name, mod->name, fmt); 1936 NOFAIL(line); 1937 1938 mod->markers = NOFAIL(realloc(mod->markers, ((mod->nmarkers + 1) * 1939 sizeof mod->markers[0]))); 1940 mod->markers[mod->nmarkers++] = line; 1941 } 1942 1943 static void read_markers(const char *fname) 1944 { 1945 unsigned long size, pos = 0; 1946 void *file = grab_file(fname, &size); 1947 char *line; 1948 1949 if (!file) /* No old markers, silently ignore */ 1950 return; 1951 1952 while ((line = get_next_line(&pos, file, size))) { 1953 char *marker, *modname, *fmt; 1954 struct module *mod; 1955 1956 marker = line; 1957 modname = strchr(marker, '\t'); 1958 if (!modname) 1959 goto fail; 1960 *modname++ = '\0'; 1961 fmt = strchr(modname, '\t'); 1962 if (!fmt) 1963 goto fail; 1964 *fmt++ = '\0'; 1965 if (*marker == '\0' || *modname == '\0') 1966 goto fail; 1967 1968 mod = find_module(modname); 1969 if (!mod) { 1970 if (is_vmlinux(modname)) 1971 have_vmlinux = 1; 1972 mod = new_module(NOFAIL(strdup(modname))); 1973 mod->skip = 1; 1974 } 1975 1976 add_marker(mod, marker, fmt); 1977 } 1978 return; 1979 fail: 1980 fatal("parse error in markers list file\n"); 1981 } 1982 1983 static int compare_strings(const void *a, const void *b) 1984 { 1985 return strcmp(*(const char **) a, *(const char **) b); 1986 } 1987 1988 static void write_markers(const char *fname) 1989 { 1990 struct buffer buf = { }; 1991 struct module *mod; 1992 size_t i; 1993 1994 for (mod = modules; mod; mod = mod->next) 1995 if ((!external_module || !mod->skip) && mod->markers != NULL) { 1996 /* 1997 * Sort the strings so we can skip duplicates when 1998 * we write them out. 1999 */ 2000 qsort(mod->markers, mod->nmarkers, 2001 sizeof mod->markers[0], &compare_strings); 2002 for (i = 0; i < mod->nmarkers; ++i) { 2003 char *line = mod->markers[i]; 2004 buf_write(&buf, line, strlen(line)); 2005 while (i + 1 < mod->nmarkers && 2006 !strcmp(mod->markers[i], 2007 mod->markers[i + 1])) 2008 free(mod->markers[i++]); 2009 free(mod->markers[i]); 2010 } 2011 free(mod->markers); 2012 mod->markers = NULL; 2013 } 2014 2015 write_if_changed(&buf, fname); 2016 } 2017 2018 int main(int argc, char **argv) 2019 { 2020 struct module *mod; 2021 struct buffer buf = { }; 2022 char *kernel_read = NULL, *module_read = NULL; 2023 char *dump_write = NULL; 2024 char *markers_read = NULL; 2025 char *markers_write = NULL; 2026 int opt; 2027 int err; 2028 2029 while ((opt = getopt(argc, argv, "i:I:cmsSo:awM:K:")) != -1) { 2030 switch (opt) { 2031 case 'i': 2032 kernel_read = optarg; 2033 break; 2034 case 'I': 2035 module_read = optarg; 2036 external_module = 1; 2037 break; 2038 case 'c': 2039 cross_build = 1; 2040 break; 2041 case 'm': 2042 modversions = 1; 2043 break; 2044 case 'o': 2045 dump_write = optarg; 2046 break; 2047 case 'a': 2048 all_versions = 1; 2049 break; 2050 case 's': 2051 vmlinux_section_warnings = 0; 2052 break; 2053 case 'S': 2054 sec_mismatch_verbose = 0; 2055 break; 2056 case 'w': 2057 warn_unresolved = 1; 2058 break; 2059 case 'M': 2060 markers_write = optarg; 2061 break; 2062 case 'K': 2063 markers_read = optarg; 2064 break; 2065 default: 2066 exit(1); 2067 } 2068 } 2069 2070 if (kernel_read) 2071 read_dump(kernel_read, 1); 2072 if (module_read) 2073 read_dump(module_read, 0); 2074 2075 while (optind < argc) 2076 read_symbols(argv[optind++]); 2077 2078 for (mod = modules; mod; mod = mod->next) { 2079 if (mod->skip) 2080 continue; 2081 check_exports(mod); 2082 } 2083 2084 err = 0; 2085 2086 for (mod = modules; mod; mod = mod->next) { 2087 char fname[strlen(mod->name) + 10]; 2088 2089 if (mod->skip) 2090 continue; 2091 2092 buf.pos = 0; 2093 2094 add_header(&buf, mod); 2095 err |= add_versions(&buf, mod); 2096 add_depends(&buf, mod, modules); 2097 add_moddevtable(&buf, mod); 2098 add_srcversion(&buf, mod); 2099 2100 sprintf(fname, "%s.mod.c", mod->name); 2101 write_if_changed(&buf, fname); 2102 } 2103 2104 if (dump_write) 2105 write_dump(dump_write); 2106 if (sec_mismatch_count && !sec_mismatch_verbose) 2107 warn("modpost: Found %d section mismatch(es).\n" 2108 "To see full details build your kernel with:\n" 2109 "'make CONFIG_DEBUG_SECTION_MISMATCH=y'\n", 2110 sec_mismatch_count); 2111 2112 if (markers_read) 2113 read_markers(markers_read); 2114 2115 if (markers_write) 2116 write_markers(markers_write); 2117 2118 return err; 2119 } 2120