xref: /openbmc/linux/scripts/coccicheck (revision 2c91ce92c6d99fe8ed0fde2e67c19d40f062e8a3)
19e395550SNicolas Palix#!/usr/bin/env bash
2b2441318SGreg Kroah-Hartman# SPDX-License-Identifier: GPL-2.0
3c100d537SLuis R. Rodriguez# Linux kernel coccicheck
4c100d537SLuis R. Rodriguez#
51e01892eSMarkus Elfring# Read Documentation/dev-tools/coccinelle.rst
6ec97946eSNicolas Palix#
7ec97946eSNicolas Palix# This script requires at least spatch
8ec97946eSNicolas Palix# version 1.0.0-rc11.
9ec97946eSNicolas Palix
10a9e064c0SLuis R. RodriguezDIR="$(dirname $(readlink -f $0))/.."
1174425eeeSNicolas PalixSPATCH="`which ${SPATCH:=spatch}`"
1274425eeeSNicolas Palix
1313d94865SLuis R. Rodriguezif [ ! -x "$SPATCH" ]; then
1413d94865SLuis R. Rodriguez    echo 'spatch is part of the Coccinelle project and is available at http://coccinelle.lip6.fr/'
1513d94865SLuis R. Rodriguez    exit 1
1613d94865SLuis R. Rodriguezfi
1713d94865SLuis R. Rodriguez
18a9e064c0SLuis R. RodriguezSPATCH_VERSION=$($SPATCH --version | head -1 | awk '{print $3}')
19a9e064c0SLuis R. Rodriguez
20c930a1b2SLuis R. RodriguezUSE_JOBS="no"
21c930a1b2SLuis R. Rodriguez$SPATCH --help | grep -e "--jobs" > /dev/null && USE_JOBS="yes"
2290d06a46SKees Cook
2326e56720SBernd Schubert# The verbosity may be set by the environmental parameter V=
2426e56720SBernd Schubert# as for example with 'make V=1 coccicheck'
2526e56720SBernd Schubert
2626e56720SBernd Schubertif [ -n "$V" -a "$V" != "0" ]; then
2790d06a46SKees Cook	VERBOSE="$V"
2826e56720SBernd Schubertelse
2926e56720SBernd Schubert	VERBOSE=0
3026e56720SBernd Schubertfi
3126e56720SBernd Schubert
328e826ad5SLuis R. RodriguezFLAGS="--very-quiet"
339e395550SNicolas Palix
345c384dbaSLuis R. Rodriguez# You can use SPFLAGS to append extra arguments to coccicheck or override any
355c384dbaSLuis R. Rodriguez# heuristics done in this file as Coccinelle accepts the last options when
365c384dbaSLuis R. Rodriguez# options conflict.
375c384dbaSLuis R. Rodriguez#
385c384dbaSLuis R. Rodriguez# A good example for use of SPFLAGS is if you want to debug your cocci script,
395c384dbaSLuis R. Rodriguez# you can for instance use the following:
405c384dbaSLuis R. Rodriguez#
415c384dbaSLuis R. Rodriguez# $ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
425c384dbaSLuis R. Rodriguez# $ make coccicheck MODE=report DEBUG_FILE="all.err" SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
435c384dbaSLuis R. Rodriguez#
445c384dbaSLuis R. Rodriguez# "--show-trying" should show you what rule is being processed as it goes to
455c384dbaSLuis R. Rodriguez# stdout, you do not need a debug file for that. The profile output will be
465c384dbaSLuis R. Rodriguez# be sent to stdout, if you provide a DEBUG_FILE the profiling data can be
475c384dbaSLuis R. Rodriguez# inspected there.
485c384dbaSLuis R. Rodriguez#
495c384dbaSLuis R. Rodriguez# --profile will not output if --very-quiet is used, so avoid it.
50*2d63e6a3SGreg Kroah-Hartmanecho $SPFLAGS | grep -E -e "--profile|--show-trying" 2>&1 > /dev/null
515c384dbaSLuis R. Rodriguezif [ $? -eq 0 ]; then
525c384dbaSLuis R. Rodriguez	FLAGS="--quiet"
535c384dbaSLuis R. Rodriguezfi
545c384dbaSLuis R. Rodriguez
559e395550SNicolas Palix# spatch only allows include directories with the syntax "-I include"
569e395550SNicolas Palix# while gcc also allows "-Iinclude" and "-include include"
579e395550SNicolas PalixCOCCIINCLUDE=${LINUXINCLUDE//-I/-I }
585b169108SAndrzej HajdaCOCCIINCLUDE=${COCCIINCLUDE// -include/ --include}
599e395550SNicolas Palix
601e9dea2aSNicolas Palixif [ "$C" = "1" -o "$C" = "2" ]; then
611e9dea2aSNicolas Palix    ONLINE=1
621e9dea2aSNicolas Palix
63d8f6e5c6SSumera Priyadarsini    if [[ $# -le 0 ]]; then
64d8f6e5c6SSumera Priyadarsini	    echo ''
65d8f6e5c6SSumera Priyadarsini	    echo 'Specifying both the variable "C" and rule "coccicheck" in the make
66d8f6e5c6SSumera Priyadarsinicommand results in a shift count error.'
67d8f6e5c6SSumera Priyadarsini	    echo ''
68d8f6e5c6SSumera Priyadarsini	    echo 'Try specifying "scripts/coccicheck" as a value for the CHECK variable instead.'
69d8f6e5c6SSumera Priyadarsini	    echo ''
70d8f6e5c6SSumera Priyadarsini	    echo 'Example:	make C=2 CHECK=scripts/coccicheck drivers/net/ethernet/ethoc.o'
71d8f6e5c6SSumera Priyadarsini	    echo ''
72d8f6e5c6SSumera Priyadarsini	    exit 1
73d8f6e5c6SSumera Priyadarsini    fi
74d8f6e5c6SSumera Priyadarsini
759e395550SNicolas Palix    # Take only the last argument, which is the C file to test
761e9dea2aSNicolas Palix    shift $(( $# - 1 ))
779e395550SNicolas Palix    OPTIONS="$COCCIINCLUDE $1"
78d7059ca0SMasahiro Yamada
79d7059ca0SMasahiro Yamada    # No need to parallelize Coccinelle since this mode takes one input file.
80d7059ca0SMasahiro Yamada    NPROC=1
811e9dea2aSNicolas Palixelse
821e9dea2aSNicolas Palix    ONLINE=0
83d0bc1fb4SGreg Dietsche    if [ "$KBUILD_EXTMOD" = "" ] ; then
8493f14468SNicolas Palix        OPTIONS="--dir $srctree $COCCIINCLUDE"
85d0bc1fb4SGreg Dietsche    else
8693f14468SNicolas Palix        OPTIONS="--dir $KBUILD_EXTMOD $COCCIINCLUDE"
87d0bc1fb4SGreg Dietsche    fi
88d7059ca0SMasahiro Yamada
89e16a7c47SSumera Priyadarsini    # Use only one thread per core by default if hyperthreading is enabled
90f5b3553bSMauro Carvalho Chehab    THREADS_PER_CORE=$(LANG=C lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")
91d7059ca0SMasahiro Yamada    if [ -z "$J" ]; then
92d7059ca0SMasahiro Yamada        NPROC=$(getconf _NPROCESSORS_ONLN)
93c5864560SSumera Priyadarsini	if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 4 ] ; then
94e16a7c47SSumera Priyadarsini		NPROC=$((NPROC/2))
95e16a7c47SSumera Priyadarsini	fi
96d7059ca0SMasahiro Yamada    else
97d7059ca0SMasahiro Yamada        NPROC="$J"
98d7059ca0SMasahiro Yamada    fi
991e9dea2aSNicolas Palixfi
1001e9dea2aSNicolas Palix
101bad6a409SNicolas Palixif [ "$KBUILD_EXTMOD" != "" ] ; then
10293f14468SNicolas Palix    OPTIONS="--patch $srctree $OPTIONS"
103bad6a409SNicolas Palixfi
104bad6a409SNicolas Palix
105c930a1b2SLuis R. Rodriguez# You can override by using SPFLAGS
106c930a1b2SLuis R. Rodriguezif [ "$USE_JOBS" = "no" ]; then
107c930a1b2SLuis R. Rodriguez	trap kill_running SIGTERM SIGINT
108c930a1b2SLuis R. Rodriguez	declare -a SPATCH_PID
109c930a1b2SLuis R. Rodriguezelif [ "$NPROC" != "1" ]; then
110c930a1b2SLuis R. Rodriguez	# Using 0 should work as well, refer to _SC_NPROCESSORS_ONLN use on
111c930a1b2SLuis R. Rodriguez	# https://github.com/rdicosmo/parmap/blob/master/setcore_stubs.c
112c930a1b2SLuis R. Rodriguez	OPTIONS="$OPTIONS --jobs $NPROC --chunksize 1"
113c930a1b2SLuis R. Rodriguezfi
114c930a1b2SLuis R. Rodriguez
11574425eeeSNicolas Palixif [ "$MODE" = "" ] ; then
1161e9dea2aSNicolas Palix    if [ "$ONLINE" = "0" ] ; then
1171f0a6742SNicolas Palix	echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
1184b2bd20cSSumera Priyadarsini	echo 'Available modes are the following: patch, report, context, org, chain'
11974425eeeSNicolas Palix	echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
1201f0a6742SNicolas Palix	echo 'Note however that some modes are not implemented by some semantic patches.'
1211e9dea2aSNicolas Palix    fi
1221f0a6742SNicolas Palix    MODE="report"
1231f0a6742SNicolas Palixfi
1241f0a6742SNicolas Palix
1251f0a6742SNicolas Palixif [ "$MODE" = "chain" ] ; then
1261f0a6742SNicolas Palix    if [ "$ONLINE" = "0" ] ; then
1271f0a6742SNicolas Palix	echo 'You have selected the "chain" mode.'
1281f0a6742SNicolas Palix	echo 'All available modes will be tried (in that order): patch, report, context, org'
1291f0a6742SNicolas Palix    fi
13003ee0c42SNicolas Palixelif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
1317a2358b3SDeepa Dinamani    FLAGS="--no-show-diff $FLAGS"
13274425eeeSNicolas Palixfi
13374425eeeSNicolas Palix
1341e9dea2aSNicolas Palixif [ "$ONLINE" = "0" ] ; then
13574425eeeSNicolas Palix    echo ''
13674425eeeSNicolas Palix    echo 'Please check for false positives in the output before submitting a patch.'
13774425eeeSNicolas Palix    echo 'When using "patch" mode, carefully review the patch before submitting it.'
13874425eeeSNicolas Palix    echo ''
1391e9dea2aSNicolas Palixfi
14074425eeeSNicolas Palix
141c930a1b2SLuis R. Rodriguezrun_cmd_parmap() {
142c930a1b2SLuis R. Rodriguez	if [ $VERBOSE -ne 0 ] ; then
143c930a1b2SLuis R. Rodriguez		echo "Running ($NPROC in parallel): $@"
144c930a1b2SLuis R. Rodriguez	fi
145a19d1358SSumera Priyadarsini	if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
1469ed07adaSJulia Lawall                echo $@>>$DEBUG_FILE
1479ed07adaSJulia Lawall                $@ 2>>$DEBUG_FILE
148a19d1358SSumera Priyadarsini        else
149a19d1358SSumera Priyadarsini                echo $@
150a19d1358SSumera Priyadarsini                $@ 2>&1
151a19d1358SSumera Priyadarsini	fi
152a19d1358SSumera Priyadarsini
153512ddf7dSDenis Efremov	err=$?
154512ddf7dSDenis Efremov	if [[ $err -ne 0 ]]; then
155c930a1b2SLuis R. Rodriguez		echo "coccicheck failed"
156512ddf7dSDenis Efremov		exit $err
157c930a1b2SLuis R. Rodriguez	fi
158c930a1b2SLuis R. Rodriguez}
159c930a1b2SLuis R. Rodriguez
160c930a1b2SLuis R. Rodriguezrun_cmd_old() {
16190d06a46SKees Cook	local i
1625303265aSBernd Schubert	if [ $VERBOSE -ne 0 ] ; then
16390d06a46SKees Cook		echo "Running ($NPROC in parallel): $@"
1645303265aSBernd Schubert	fi
16590d06a46SKees Cook	for i in $(seq 0 $(( NPROC - 1)) ); do
16693f14468SNicolas Palix		eval "$@ --max $NPROC --index $i &"
16790d06a46SKees Cook		SPATCH_PID[$i]=$!
16890d06a46SKees Cook		if [ $VERBOSE -eq 2 ] ; then
16990d06a46SKees Cook			echo "${SPATCH_PID[$i]} running"
17090d06a46SKees Cook		fi
17190d06a46SKees Cook	done
17290d06a46SKees Cook	wait
1735303265aSBernd Schubert}
1745303265aSBernd Schubert
175c930a1b2SLuis R. Rodriguezrun_cmd() {
176c930a1b2SLuis R. Rodriguez	if [ "$USE_JOBS" = "yes" ]; then
177c930a1b2SLuis R. Rodriguez		run_cmd_parmap $@
178c930a1b2SLuis R. Rodriguez	else
179c930a1b2SLuis R. Rodriguez		run_cmd_old $@
180c930a1b2SLuis R. Rodriguez	fi
181c930a1b2SLuis R. Rodriguez}
182c930a1b2SLuis R. Rodriguez
18390d06a46SKees Cookkill_running() {
1842552a39fSKees Cook	for i in $(seq 0 $(( NPROC - 1 )) ); do
18590d06a46SKees Cook		if [ $VERBOSE -eq 2 ] ; then
18690d06a46SKees Cook			echo "Killing ${SPATCH_PID[$i]}"
18790d06a46SKees Cook		fi
18890d06a46SKees Cook		kill ${SPATCH_PID[$i]} 2>/dev/null
18990d06a46SKees Cook	done
19090d06a46SKees Cook}
1915303265aSBernd Schubert
1928e826ad5SLuis R. Rodriguez# You can override heuristics with SPFLAGS, these must always go last
1938e826ad5SLuis R. RodriguezOPTIONS="$OPTIONS $SPFLAGS"
1948e826ad5SLuis R. Rodriguez
1951e9dea2aSNicolas Palixcoccinelle () {
19674425eeeSNicolas Palix    COCCI="$1"
19774425eeeSNicolas Palix
198e0be348eSMasahiro Yamada    OPT=`grep "Options:" $COCCI | cut -d':' -f2`
199e0be348eSMasahiro Yamada    REQ=`grep "Requires:" $COCCI | cut -d':' -f2 | sed "s| ||"`
20033114c43SMasahiro Yamada    if [ -n "$REQ" ] && ! { echo "$REQ"; echo "$SPATCH_VERSION"; } | sort -CV ; then
2011640eea3SJulia Lawall	    echo "Skipping coccinelle SmPL patch: $COCCI"
202a9e064c0SLuis R. Rodriguez	    echo "You have coccinelle:           $SPATCH_VERSION"
203a9e064c0SLuis R. Rodriguez	    echo "This SmPL patch requires:      $REQ"
204a9e064c0SLuis R. Rodriguez	    return
205a9e064c0SLuis R. Rodriguez    fi
2061e9dea2aSNicolas Palix
20793f14468SNicolas Palix#   The option '--parse-cocci' can be used to syntactically check the SmPL files.
2081e9dea2aSNicolas Palix#
2091e9dea2aSNicolas Palix#    $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
2101e9dea2aSNicolas Palix
21135d88a38SNicolas Palix    if [ $VERBOSE -ne 0 -a $ONLINE -eq 0 ] ; then
2121e9dea2aSNicolas Palix
213cd1af7cfSMasahiro Yamada	FILE=${COCCI#$srctree/}
21474425eeeSNicolas Palix
2153c908417SNicolas Palix	echo "Processing `basename $COCCI`"
2163c908417SNicolas Palix	echo "with option(s) \"$OPT\""
2173c908417SNicolas Palix	echo ''
21874425eeeSNicolas Palix	echo 'Message example to submit a patch:'
21974425eeeSNicolas Palix
2203c908417SNicolas Palix	sed -ne 's|^///||p' $COCCI
22174425eeeSNicolas Palix
222062c1825SNicolas Palix	if [ "$MODE" = "patch" ] ; then
22374425eeeSNicolas Palix	    echo ' The semantic patch that makes this change is available'
224062c1825SNicolas Palix	elif [ "$MODE" = "report" ] ; then
225062c1825SNicolas Palix	    echo ' The semantic patch that makes this report is available'
226062c1825SNicolas Palix	elif [ "$MODE" = "context" ] ; then
227062c1825SNicolas Palix	    echo ' The semantic patch that spots this code is available'
228062c1825SNicolas Palix	elif [ "$MODE" = "org" ] ; then
229062c1825SNicolas Palix	    echo ' The semantic patch that makes this Org report is available'
230062c1825SNicolas Palix	else
231062c1825SNicolas Palix	    echo ' The semantic patch that makes this output is available'
232062c1825SNicolas Palix	fi
23374425eeeSNicolas Palix	echo " in $FILE."
23474425eeeSNicolas Palix	echo ''
23574425eeeSNicolas Palix	echo ' More information about semantic patching is available at'
23674425eeeSNicolas Palix	echo ' http://coccinelle.lip6.fr/'
23774425eeeSNicolas Palix	echo ''
23874425eeeSNicolas Palix
2393c908417SNicolas Palix	if [ "`sed -ne 's|^//#||p' $COCCI`" ] ; then
2403c908417SNicolas Palix	    echo 'Semantic patch information:'
2413c908417SNicolas Palix	    sed -ne 's|^//#||p' $COCCI
2423c908417SNicolas Palix	    echo ''
2433c908417SNicolas Palix	fi
2442c1160c8SNicolas Palix    fi
2453c908417SNicolas Palix
2462c1160c8SNicolas Palix    if [ "$MODE" = "chain" ] ; then
2475303265aSBernd Schubert	run_cmd $SPATCH -D patch   \
24893f14468SNicolas Palix		$FLAGS --cocci-file $COCCI $OPT $OPTIONS               || \
2495303265aSBernd Schubert	run_cmd $SPATCH -D report  \
25093f14468SNicolas Palix		$FLAGS --cocci-file $COCCI $OPT $OPTIONS --no-show-diff || \
2515303265aSBernd Schubert	run_cmd $SPATCH -D context \
25293f14468SNicolas Palix		$FLAGS --cocci-file $COCCI $OPT $OPTIONS               || \
2535303265aSBernd Schubert	run_cmd $SPATCH -D org     \
25493f14468SNicolas Palix		$FLAGS --cocci-file $COCCI $OPT $OPTIONS --no-show-diff || exit 1
255c05cd6ddSNicolas Palix    elif [ "$MODE" = "rep+ctxt" ] ; then
2565303265aSBernd Schubert	run_cmd $SPATCH -D report  \
25793f14468SNicolas Palix		$FLAGS --cocci-file $COCCI $OPT $OPTIONS --no-show-diff && \
2585303265aSBernd Schubert	run_cmd $SPATCH -D context \
25993f14468SNicolas Palix		$FLAGS --cocci-file $COCCI $OPT $OPTIONS || exit 1
2601e9dea2aSNicolas Palix    else
26193f14468SNicolas Palix	run_cmd $SPATCH -D $MODE   $FLAGS --cocci-file $COCCI $OPT $OPTIONS || exit 1
2621e9dea2aSNicolas Palix    fi
26374425eeeSNicolas Palix
26474425eeeSNicolas Palix}
26574425eeeSNicolas Palix
2669ed07adaSJulia Lawallif [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
2679ed07adaSJulia Lawall	if [ -f $DEBUG_FILE ]; then
2689ed07adaSJulia Lawall		echo "Debug file $DEBUG_FILE exists, bailing"
2699ed07adaSJulia Lawall		exit
2709ed07adaSJulia Lawall	fi
2719ed07adaSJulia Lawallelse
2729ed07adaSJulia Lawall	DEBUG_FILE="/dev/null"
2739ed07adaSJulia Lawallfi
2749ed07adaSJulia Lawall
27574425eeeSNicolas Palixif [ "$COCCI" = "" ] ; then
27674425eeeSNicolas Palix    for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
2771e9dea2aSNicolas Palix	coccinelle $f
27874425eeeSNicolas Palix    done
27974425eeeSNicolas Palixelse
2801e9dea2aSNicolas Palix    coccinelle $COCCI
28174425eeeSNicolas Palixfi
282