xref: /openbmc/linux/net/rxrpc/call_object.c (revision 48124178)
18c3e34a4SDavid Howells /* RxRPC individual remote procedure call handling
28c3e34a4SDavid Howells  *
38c3e34a4SDavid Howells  * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved.
48c3e34a4SDavid Howells  * Written by David Howells (dhowells@redhat.com)
58c3e34a4SDavid Howells  *
68c3e34a4SDavid Howells  * This program is free software; you can redistribute it and/or
78c3e34a4SDavid Howells  * modify it under the terms of the GNU General Public License
88c3e34a4SDavid Howells  * as published by the Free Software Foundation; either version
98c3e34a4SDavid Howells  * 2 of the License, or (at your option) any later version.
108c3e34a4SDavid Howells  */
118c3e34a4SDavid Howells 
128c3e34a4SDavid Howells #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
138c3e34a4SDavid Howells 
148c3e34a4SDavid Howells #include <linux/slab.h>
158c3e34a4SDavid Howells #include <linux/module.h>
168c3e34a4SDavid Howells #include <linux/circ_buf.h>
178c3e34a4SDavid Howells #include <linux/spinlock_types.h>
188c3e34a4SDavid Howells #include <net/sock.h>
198c3e34a4SDavid Howells #include <net/af_rxrpc.h>
208c3e34a4SDavid Howells #include "ar-internal.h"
218c3e34a4SDavid Howells 
228c3e34a4SDavid Howells const char *const rxrpc_call_states[NR__RXRPC_CALL_STATES] = {
23999b69f8SDavid Howells 	[RXRPC_CALL_UNINITIALISED]		= "Uninit  ",
24999b69f8SDavid Howells 	[RXRPC_CALL_CLIENT_AWAIT_CONN]		= "ClWtConn",
258c3e34a4SDavid Howells 	[RXRPC_CALL_CLIENT_SEND_REQUEST]	= "ClSndReq",
268c3e34a4SDavid Howells 	[RXRPC_CALL_CLIENT_AWAIT_REPLY]		= "ClAwtRpl",
278c3e34a4SDavid Howells 	[RXRPC_CALL_CLIENT_RECV_REPLY]		= "ClRcvRpl",
2800e90712SDavid Howells 	[RXRPC_CALL_SERVER_PREALLOC]		= "SvPrealc",
298c3e34a4SDavid Howells 	[RXRPC_CALL_SERVER_SECURING]		= "SvSecure",
308c3e34a4SDavid Howells 	[RXRPC_CALL_SERVER_ACCEPTING]		= "SvAccept",
318c3e34a4SDavid Howells 	[RXRPC_CALL_SERVER_RECV_REQUEST]	= "SvRcvReq",
328c3e34a4SDavid Howells 	[RXRPC_CALL_SERVER_ACK_REQUEST]		= "SvAckReq",
338c3e34a4SDavid Howells 	[RXRPC_CALL_SERVER_SEND_REPLY]		= "SvSndRpl",
348c3e34a4SDavid Howells 	[RXRPC_CALL_SERVER_AWAIT_ACK]		= "SvAwtACK",
358c3e34a4SDavid Howells 	[RXRPC_CALL_COMPLETE]			= "Complete",
36f5c17aaeSDavid Howells };
37f5c17aaeSDavid Howells 
38f5c17aaeSDavid Howells const char *const rxrpc_call_completions[NR__RXRPC_CALL_COMPLETIONS] = {
39f5c17aaeSDavid Howells 	[RXRPC_CALL_SUCCEEDED]			= "Complete",
408c3e34a4SDavid Howells 	[RXRPC_CALL_REMOTELY_ABORTED]		= "RmtAbort",
418c3e34a4SDavid Howells 	[RXRPC_CALL_LOCALLY_ABORTED]		= "LocAbort",
42f5c17aaeSDavid Howells 	[RXRPC_CALL_LOCAL_ERROR]		= "LocError",
438c3e34a4SDavid Howells 	[RXRPC_CALL_NETWORK_ERROR]		= "NetError",
448c3e34a4SDavid Howells };
458c3e34a4SDavid Howells 
468c3e34a4SDavid Howells struct kmem_cache *rxrpc_call_jar;
478c3e34a4SDavid Howells 
48248f219cSDavid Howells static void rxrpc_call_timer_expired(unsigned long _call)
49248f219cSDavid Howells {
50248f219cSDavid Howells 	struct rxrpc_call *call = (struct rxrpc_call *)_call;
51248f219cSDavid Howells 
52248f219cSDavid Howells 	_enter("%d", call->debug_id);
53248f219cSDavid Howells 
54405dea1dSDavid Howells 	if (call->state < RXRPC_CALL_COMPLETE)
55405dea1dSDavid Howells 		rxrpc_set_timer(call, rxrpc_timer_expired, ktime_get_real());
56fc7ab6d2SDavid Howells }
578c3e34a4SDavid Howells 
589faaff59SDavid Howells static struct lock_class_key rxrpc_call_user_mutex_lock_class_key;
599faaff59SDavid Howells 
608c3e34a4SDavid Howells /*
618c3e34a4SDavid Howells  * find an extant server call
628c3e34a4SDavid Howells  * - called in process context with IRQs enabled
638c3e34a4SDavid Howells  */
648c3e34a4SDavid Howells struct rxrpc_call *rxrpc_find_call_by_user_ID(struct rxrpc_sock *rx,
658c3e34a4SDavid Howells 					      unsigned long user_call_ID)
668c3e34a4SDavid Howells {
678c3e34a4SDavid Howells 	struct rxrpc_call *call;
688c3e34a4SDavid Howells 	struct rb_node *p;
698c3e34a4SDavid Howells 
708c3e34a4SDavid Howells 	_enter("%p,%lx", rx, user_call_ID);
718c3e34a4SDavid Howells 
728c3e34a4SDavid Howells 	read_lock(&rx->call_lock);
738c3e34a4SDavid Howells 
748c3e34a4SDavid Howells 	p = rx->calls.rb_node;
758c3e34a4SDavid Howells 	while (p) {
768c3e34a4SDavid Howells 		call = rb_entry(p, struct rxrpc_call, sock_node);
778c3e34a4SDavid Howells 
788c3e34a4SDavid Howells 		if (user_call_ID < call->user_call_ID)
798c3e34a4SDavid Howells 			p = p->rb_left;
808c3e34a4SDavid Howells 		else if (user_call_ID > call->user_call_ID)
818c3e34a4SDavid Howells 			p = p->rb_right;
828c3e34a4SDavid Howells 		else
838c3e34a4SDavid Howells 			goto found_extant_call;
848c3e34a4SDavid Howells 	}
858c3e34a4SDavid Howells 
868c3e34a4SDavid Howells 	read_unlock(&rx->call_lock);
878c3e34a4SDavid Howells 	_leave(" = NULL");
888c3e34a4SDavid Howells 	return NULL;
898c3e34a4SDavid Howells 
908c3e34a4SDavid Howells found_extant_call:
91fff72429SDavid Howells 	rxrpc_get_call(call, rxrpc_call_got);
928c3e34a4SDavid Howells 	read_unlock(&rx->call_lock);
938c3e34a4SDavid Howells 	_leave(" = %p [%d]", call, atomic_read(&call->usage));
948c3e34a4SDavid Howells 	return call;
958c3e34a4SDavid Howells }
968c3e34a4SDavid Howells 
978c3e34a4SDavid Howells /*
988c3e34a4SDavid Howells  * allocate a new call
998c3e34a4SDavid Howells  */
1009faaff59SDavid Howells struct rxrpc_call *rxrpc_alloc_call(struct rxrpc_sock *rx, gfp_t gfp)
1018c3e34a4SDavid Howells {
1028c3e34a4SDavid Howells 	struct rxrpc_call *call;
1038c3e34a4SDavid Howells 
1048c3e34a4SDavid Howells 	call = kmem_cache_zalloc(rxrpc_call_jar, gfp);
1058c3e34a4SDavid Howells 	if (!call)
1068c3e34a4SDavid Howells 		return NULL;
1078c3e34a4SDavid Howells 
108248f219cSDavid Howells 	call->rxtx_buffer = kcalloc(RXRPC_RXTX_BUFF_SIZE,
109248f219cSDavid Howells 				    sizeof(struct sk_buff *),
1108c3e34a4SDavid Howells 				    gfp);
111248f219cSDavid Howells 	if (!call->rxtx_buffer)
112248f219cSDavid Howells 		goto nomem;
1138c3e34a4SDavid Howells 
114248f219cSDavid Howells 	call->rxtx_annotations = kcalloc(RXRPC_RXTX_BUFF_SIZE, sizeof(u8), gfp);
115248f219cSDavid Howells 	if (!call->rxtx_annotations)
116248f219cSDavid Howells 		goto nomem_2;
117248f219cSDavid Howells 
118540b1c48SDavid Howells 	mutex_init(&call->user_mutex);
1199faaff59SDavid Howells 
1209faaff59SDavid Howells 	/* Prevent lockdep reporting a deadlock false positive between the afs
1219faaff59SDavid Howells 	 * filesystem and sys_sendmsg() via the mmap sem.
1229faaff59SDavid Howells 	 */
1239faaff59SDavid Howells 	if (rx->sk.sk_kern_sock)
1249faaff59SDavid Howells 		lockdep_set_class(&call->user_mutex,
1259faaff59SDavid Howells 				  &rxrpc_call_user_mutex_lock_class_key);
1269faaff59SDavid Howells 
127248f219cSDavid Howells 	setup_timer(&call->timer, rxrpc_call_timer_expired,
1288c3e34a4SDavid Howells 		    (unsigned long)call);
1298c3e34a4SDavid Howells 	INIT_WORK(&call->processor, &rxrpc_process_call);
130999b69f8SDavid Howells 	INIT_LIST_HEAD(&call->link);
13145025bceSDavid Howells 	INIT_LIST_HEAD(&call->chan_wait_link);
1328c3e34a4SDavid Howells 	INIT_LIST_HEAD(&call->accept_link);
133248f219cSDavid Howells 	INIT_LIST_HEAD(&call->recvmsg_link);
134248f219cSDavid Howells 	INIT_LIST_HEAD(&call->sock_link);
13545025bceSDavid Howells 	init_waitqueue_head(&call->waitq);
1368c3e34a4SDavid Howells 	spin_lock_init(&call->lock);
13720acbd9aSDavid Howells 	spin_lock_init(&call->notify_lock);
1388c3e34a4SDavid Howells 	rwlock_init(&call->state_lock);
1398c3e34a4SDavid Howells 	atomic_set(&call->usage, 1);
1408c3e34a4SDavid Howells 	call->debug_id = atomic_inc_return(&rxrpc_debug_id);
141e754eba6SDavid Howells 	call->tx_total_len = -1;
1428c3e34a4SDavid Howells 
1438c3e34a4SDavid Howells 	memset(&call->sock_node, 0xed, sizeof(call->sock_node));
1448c3e34a4SDavid Howells 
145248f219cSDavid Howells 	/* Leave space in the ring to handle a maxed-out jumbo packet */
14675e42126SDavid Howells 	call->rx_winsize = rxrpc_rx_window_size;
147248f219cSDavid Howells 	call->tx_winsize = 16;
148248f219cSDavid Howells 	call->rx_expect_next = 1;
14957494343SDavid Howells 
15057494343SDavid Howells 	call->cong_cwnd = 2;
15157494343SDavid Howells 	call->cong_ssthresh = RXRPC_RXTX_BUFF_SIZE - 1;
1528c3e34a4SDavid Howells 	return call;
153248f219cSDavid Howells 
154248f219cSDavid Howells nomem_2:
155248f219cSDavid Howells 	kfree(call->rxtx_buffer);
156248f219cSDavid Howells nomem:
157248f219cSDavid Howells 	kmem_cache_free(rxrpc_call_jar, call);
158248f219cSDavid Howells 	return NULL;
1598c3e34a4SDavid Howells }
1608c3e34a4SDavid Howells 
1618c3e34a4SDavid Howells /*
162999b69f8SDavid Howells  * Allocate a new client call.
1638c3e34a4SDavid Howells  */
1649faaff59SDavid Howells static struct rxrpc_call *rxrpc_alloc_client_call(struct rxrpc_sock *rx,
1659faaff59SDavid Howells 						  struct sockaddr_rxrpc *srx,
1668c3e34a4SDavid Howells 						  gfp_t gfp)
1678c3e34a4SDavid Howells {
1688c3e34a4SDavid Howells 	struct rxrpc_call *call;
16957494343SDavid Howells 	ktime_t now;
1708c3e34a4SDavid Howells 
1718c3e34a4SDavid Howells 	_enter("");
1728c3e34a4SDavid Howells 
1739faaff59SDavid Howells 	call = rxrpc_alloc_call(rx, gfp);
1748c3e34a4SDavid Howells 	if (!call)
1758c3e34a4SDavid Howells 		return ERR_PTR(-ENOMEM);
176999b69f8SDavid Howells 	call->state = RXRPC_CALL_CLIENT_AWAIT_CONN;
177999b69f8SDavid Howells 	call->service_id = srx->srx_service;
17871f3ca40SDavid Howells 	call->tx_phase = true;
17957494343SDavid Howells 	now = ktime_get_real();
18057494343SDavid Howells 	call->acks_latest_ts = now;
18157494343SDavid Howells 	call->cong_tstamp = now;
182999b69f8SDavid Howells 
183999b69f8SDavid Howells 	_leave(" = %p", call);
184999b69f8SDavid Howells 	return call;
185999b69f8SDavid Howells }
186999b69f8SDavid Howells 
187999b69f8SDavid Howells /*
188248f219cSDavid Howells  * Initiate the call ack/resend/expiry timer.
189999b69f8SDavid Howells  */
190248f219cSDavid Howells static void rxrpc_start_call_timer(struct rxrpc_call *call)
191999b69f8SDavid Howells {
192df0adc78SDavid Howells 	ktime_t now = ktime_get_real(), expire_at;
193999b69f8SDavid Howells 
194df0adc78SDavid Howells 	expire_at = ktime_add_ms(now, rxrpc_max_call_lifetime);
195248f219cSDavid Howells 	call->expire_at = expire_at;
196248f219cSDavid Howells 	call->ack_at = expire_at;
197a5af7e1fSDavid Howells 	call->ping_at = expire_at;
198248f219cSDavid Howells 	call->resend_at = expire_at;
199df0adc78SDavid Howells 	call->timer.expires = jiffies + LONG_MAX / 2;
200df0adc78SDavid Howells 	rxrpc_set_timer(call, rxrpc_timer_begin, now);
2018c3e34a4SDavid Howells }
2028c3e34a4SDavid Howells 
2038c3e34a4SDavid Howells /*
204540b1c48SDavid Howells  * Set up a call for the given parameters.
205540b1c48SDavid Howells  * - Called with the socket lock held, which it must release.
206540b1c48SDavid Howells  * - If it returns a call, the call's lock will need releasing by the caller.
2078c3e34a4SDavid Howells  */
2088c3e34a4SDavid Howells struct rxrpc_call *rxrpc_new_client_call(struct rxrpc_sock *rx,
20919ffa01cSDavid Howells 					 struct rxrpc_conn_parameters *cp,
210999b69f8SDavid Howells 					 struct sockaddr_rxrpc *srx,
21148124178SDavid Howells 					 struct rxrpc_call_params *p,
2128c3e34a4SDavid Howells 					 gfp_t gfp)
213540b1c48SDavid Howells 	__releases(&rx->sk.sk_lock.slock)
2148c3e34a4SDavid Howells {
2158c3e34a4SDavid Howells 	struct rxrpc_call *call, *xcall;
2162baec2c3SDavid Howells 	struct rxrpc_net *rxnet = rxrpc_net(sock_net(&rx->sk));
2178c3e34a4SDavid Howells 	struct rb_node *parent, **pp;
218e34d4234SDavid Howells 	const void *here = __builtin_return_address(0);
219999b69f8SDavid Howells 	int ret;
2208c3e34a4SDavid Howells 
22148124178SDavid Howells 	_enter("%p,%lx", rx, p->user_call_ID);
2228c3e34a4SDavid Howells 
2239faaff59SDavid Howells 	call = rxrpc_alloc_client_call(rx, srx, gfp);
2248c3e34a4SDavid Howells 	if (IS_ERR(call)) {
225540b1c48SDavid Howells 		release_sock(&rx->sk);
2268c3e34a4SDavid Howells 		_leave(" = %ld", PTR_ERR(call));
2278c3e34a4SDavid Howells 		return call;
2288c3e34a4SDavid Howells 	}
2298c3e34a4SDavid Howells 
23048124178SDavid Howells 	call->tx_total_len = p->tx_total_len;
231a84a46d7SDavid Howells 	trace_rxrpc_call(call, rxrpc_call_new_client, atomic_read(&call->usage),
23248124178SDavid Howells 			 here, (const void *)p->user_call_ID);
233e34d4234SDavid Howells 
234540b1c48SDavid Howells 	/* We need to protect a partially set up call against the user as we
235540b1c48SDavid Howells 	 * will be acting outside the socket lock.
236540b1c48SDavid Howells 	 */
237540b1c48SDavid Howells 	mutex_lock(&call->user_mutex);
238540b1c48SDavid Howells 
239999b69f8SDavid Howells 	/* Publish the call, even though it is incompletely set up as yet */
2408c3e34a4SDavid Howells 	write_lock(&rx->call_lock);
2418c3e34a4SDavid Howells 
2428c3e34a4SDavid Howells 	pp = &rx->calls.rb_node;
2438c3e34a4SDavid Howells 	parent = NULL;
2448c3e34a4SDavid Howells 	while (*pp) {
2458c3e34a4SDavid Howells 		parent = *pp;
2468c3e34a4SDavid Howells 		xcall = rb_entry(parent, struct rxrpc_call, sock_node);
2478c3e34a4SDavid Howells 
24848124178SDavid Howells 		if (p->user_call_ID < xcall->user_call_ID)
2498c3e34a4SDavid Howells 			pp = &(*pp)->rb_left;
25048124178SDavid Howells 		else if (p->user_call_ID > xcall->user_call_ID)
2518c3e34a4SDavid Howells 			pp = &(*pp)->rb_right;
2528c3e34a4SDavid Howells 		else
253357f5ef6SDavid Howells 			goto error_dup_user_ID;
2548c3e34a4SDavid Howells 	}
2558c3e34a4SDavid Howells 
256248f219cSDavid Howells 	rcu_assign_pointer(call->socket, rx);
25748124178SDavid Howells 	call->user_call_ID = p->user_call_ID;
258357f5ef6SDavid Howells 	__set_bit(RXRPC_CALL_HAS_USERID, &call->flags);
259fff72429SDavid Howells 	rxrpc_get_call(call, rxrpc_call_got_userid);
2608c3e34a4SDavid Howells 	rb_link_node(&call->sock_node, parent, pp);
2618c3e34a4SDavid Howells 	rb_insert_color(&call->sock_node, &rx->calls);
262248f219cSDavid Howells 	list_add(&call->sock_link, &rx->sock_calls);
263248f219cSDavid Howells 
2648c3e34a4SDavid Howells 	write_unlock(&rx->call_lock);
2658c3e34a4SDavid Howells 
2662baec2c3SDavid Howells 	write_lock(&rxnet->call_lock);
2672baec2c3SDavid Howells 	list_add_tail(&call->link, &rxnet->calls);
2682baec2c3SDavid Howells 	write_unlock(&rxnet->call_lock);
2698c3e34a4SDavid Howells 
270540b1c48SDavid Howells 	/* From this point on, the call is protected by its own lock. */
271540b1c48SDavid Howells 	release_sock(&rx->sk);
272540b1c48SDavid Howells 
273248f219cSDavid Howells 	/* Set up or get a connection record and set the protocol parameters,
274248f219cSDavid Howells 	 * including channel number and call ID.
275248f219cSDavid Howells 	 */
276248f219cSDavid Howells 	ret = rxrpc_connect_call(call, cp, srx, gfp);
277999b69f8SDavid Howells 	if (ret < 0)
278999b69f8SDavid Howells 		goto error;
279999b69f8SDavid Howells 
280a84a46d7SDavid Howells 	trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage),
28154fde423SDavid Howells 			 here, NULL);
282a84a46d7SDavid Howells 
283248f219cSDavid Howells 	rxrpc_start_call_timer(call);
284248f219cSDavid Howells 
2858c3e34a4SDavid Howells 	_net("CALL new %d on CONN %d", call->debug_id, call->conn->debug_id);
2868c3e34a4SDavid Howells 
2878c3e34a4SDavid Howells 	_leave(" = %p [new]", call);
2888c3e34a4SDavid Howells 	return call;
2898c3e34a4SDavid Howells 
2908c3e34a4SDavid Howells 	/* We unexpectedly found the user ID in the list after taking
2918c3e34a4SDavid Howells 	 * the call_lock.  This shouldn't happen unless the user races
2928c3e34a4SDavid Howells 	 * with itself and tries to add the same user ID twice at the
2938c3e34a4SDavid Howells 	 * same time in different threads.
2948c3e34a4SDavid Howells 	 */
295357f5ef6SDavid Howells error_dup_user_ID:
2968c3e34a4SDavid Howells 	write_unlock(&rx->call_lock);
297540b1c48SDavid Howells 	release_sock(&rx->sk);
2988d94aa38SDavid Howells 	ret = -EEXIST;
299357f5ef6SDavid Howells 
300357f5ef6SDavid Howells error:
301357f5ef6SDavid Howells 	__rxrpc_set_call_completion(call, RXRPC_CALL_LOCAL_ERROR,
302357f5ef6SDavid Howells 				    RX_CALL_DEAD, ret);
303a84a46d7SDavid Howells 	trace_rxrpc_call(call, rxrpc_call_error, atomic_read(&call->usage),
304a84a46d7SDavid Howells 			 here, ERR_PTR(ret));
305357f5ef6SDavid Howells 	rxrpc_release_call(rx, call);
306540b1c48SDavid Howells 	mutex_unlock(&call->user_mutex);
307357f5ef6SDavid Howells 	rxrpc_put_call(call, rxrpc_call_put);
308357f5ef6SDavid Howells 	_leave(" = %d", ret);
309357f5ef6SDavid Howells 	return ERR_PTR(ret);
3108c3e34a4SDavid Howells }
3118c3e34a4SDavid Howells 
3128c3e34a4SDavid Howells /*
313c038a58cSDavid Howells  * Retry a call to a new address.  It is expected that the Tx queue of the call
314c038a58cSDavid Howells  * will contain data previously packaged for an old call.
315c038a58cSDavid Howells  */
316c038a58cSDavid Howells int rxrpc_retry_client_call(struct rxrpc_sock *rx,
317c038a58cSDavid Howells 			    struct rxrpc_call *call,
318c038a58cSDavid Howells 			    struct rxrpc_conn_parameters *cp,
319c038a58cSDavid Howells 			    struct sockaddr_rxrpc *srx,
320c038a58cSDavid Howells 			    gfp_t gfp)
321c038a58cSDavid Howells {
322c038a58cSDavid Howells 	const void *here = __builtin_return_address(0);
323c038a58cSDavid Howells 	int ret;
324c038a58cSDavid Howells 
325c038a58cSDavid Howells 	/* Set up or get a connection record and set the protocol parameters,
326c038a58cSDavid Howells 	 * including channel number and call ID.
327c038a58cSDavid Howells 	 */
328c038a58cSDavid Howells 	ret = rxrpc_connect_call(call, cp, srx, gfp);
329c038a58cSDavid Howells 	if (ret < 0)
330c038a58cSDavid Howells 		goto error;
331c038a58cSDavid Howells 
332c038a58cSDavid Howells 	trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage),
333c038a58cSDavid Howells 			 here, NULL);
334c038a58cSDavid Howells 
335c038a58cSDavid Howells 	rxrpc_start_call_timer(call);
336c038a58cSDavid Howells 
337c038a58cSDavid Howells 	_net("CALL new %d on CONN %d", call->debug_id, call->conn->debug_id);
338c038a58cSDavid Howells 
339c038a58cSDavid Howells 	if (!test_and_set_bit(RXRPC_CALL_EV_RESEND, &call->events))
340c038a58cSDavid Howells 		rxrpc_queue_call(call);
341c038a58cSDavid Howells 
342c038a58cSDavid Howells 	_leave(" = 0");
343c038a58cSDavid Howells 	return 0;
344c038a58cSDavid Howells 
345c038a58cSDavid Howells error:
346c038a58cSDavid Howells 	rxrpc_set_call_completion(call, RXRPC_CALL_LOCAL_ERROR,
347c038a58cSDavid Howells 				  RX_CALL_DEAD, ret);
348c038a58cSDavid Howells 	trace_rxrpc_call(call, rxrpc_call_error, atomic_read(&call->usage),
349c038a58cSDavid Howells 			 here, ERR_PTR(ret));
350c038a58cSDavid Howells 	_leave(" = %d", ret);
351c038a58cSDavid Howells 	return ret;
352c038a58cSDavid Howells }
353c038a58cSDavid Howells 
354c038a58cSDavid Howells /*
355248f219cSDavid Howells  * Set up an incoming call.  call->conn points to the connection.
356248f219cSDavid Howells  * This is called in BH context and isn't allowed to fail.
3578c3e34a4SDavid Howells  */
358248f219cSDavid Howells void rxrpc_incoming_call(struct rxrpc_sock *rx,
359248f219cSDavid Howells 			 struct rxrpc_call *call,
36042886ffeSDavid Howells 			 struct sk_buff *skb)
3618c3e34a4SDavid Howells {
362248f219cSDavid Howells 	struct rxrpc_connection *conn = call->conn;
36342886ffeSDavid Howells 	struct rxrpc_skb_priv *sp = rxrpc_skb(skb);
364248f219cSDavid Howells 	u32 chan;
3658c3e34a4SDavid Howells 
366248f219cSDavid Howells 	_enter(",%d", call->conn->debug_id);
3678c3e34a4SDavid Howells 
368248f219cSDavid Howells 	rcu_assign_pointer(call->socket, rx);
369248f219cSDavid Howells 	call->call_id		= sp->hdr.callNumber;
370248f219cSDavid Howells 	call->service_id	= sp->hdr.serviceId;
371248f219cSDavid Howells 	call->cid		= sp->hdr.cid;
372248f219cSDavid Howells 	call->state		= RXRPC_CALL_SERVER_ACCEPTING;
373248f219cSDavid Howells 	if (sp->hdr.securityIndex > 0)
374248f219cSDavid Howells 		call->state	= RXRPC_CALL_SERVER_SECURING;
37557494343SDavid Howells 	call->cong_tstamp	= skb->tstamp;
3768c3e34a4SDavid Howells 
377248f219cSDavid Howells 	/* Set the channel for this call.  We don't get channel_lock as we're
378248f219cSDavid Howells 	 * only defending against the data_ready handler (which we're called
379248f219cSDavid Howells 	 * from) and the RESPONSE packet parser (which is only really
380248f219cSDavid Howells 	 * interested in call_counter and can cope with a disagreement with the
381248f219cSDavid Howells 	 * call pointer).
3828c3e34a4SDavid Howells 	 */
383248f219cSDavid Howells 	chan = sp->hdr.cid & RXRPC_CHANNELMASK;
384248f219cSDavid Howells 	conn->channels[chan].call_counter = call->call_id;
385248f219cSDavid Howells 	conn->channels[chan].call_id = call->call_id;
386a1399f8bSDavid Howells 	rcu_assign_pointer(conn->channels[chan].call, call);
3878c3e34a4SDavid Howells 
38885f32278SDavid Howells 	spin_lock(&conn->params.peer->lock);
38985f32278SDavid Howells 	hlist_add_head(&call->error_link, &conn->params.peer->error_targets);
39085f32278SDavid Howells 	spin_unlock(&conn->params.peer->lock);
3918c3e34a4SDavid Howells 
3928c3e34a4SDavid Howells 	_net("CALL incoming %d on CONN %d", call->debug_id, call->conn->debug_id);
3938c3e34a4SDavid Howells 
394248f219cSDavid Howells 	rxrpc_start_call_timer(call);
395248f219cSDavid Howells 	_leave("");
3968c3e34a4SDavid Howells }
3978c3e34a4SDavid Howells 
3988c3e34a4SDavid Howells /*
3998d94aa38SDavid Howells  * Queue a call's work processor, getting a ref to pass to the work queue.
4008d94aa38SDavid Howells  */
4018d94aa38SDavid Howells bool rxrpc_queue_call(struct rxrpc_call *call)
4028d94aa38SDavid Howells {
4038d94aa38SDavid Howells 	const void *here = __builtin_return_address(0);
4048d94aa38SDavid Howells 	int n = __atomic_add_unless(&call->usage, 1, 0);
4058d94aa38SDavid Howells 	if (n == 0)
4068d94aa38SDavid Howells 		return false;
4078d94aa38SDavid Howells 	if (rxrpc_queue_work(&call->processor))
4082ab27215SDavid Howells 		trace_rxrpc_call(call, rxrpc_call_queued, n + 1, here, NULL);
4098d94aa38SDavid Howells 	else
4108d94aa38SDavid Howells 		rxrpc_put_call(call, rxrpc_call_put_noqueue);
4118d94aa38SDavid Howells 	return true;
4128d94aa38SDavid Howells }
4138d94aa38SDavid Howells 
4148d94aa38SDavid Howells /*
4158d94aa38SDavid Howells  * Queue a call's work processor, passing the callers ref to the work queue.
4168d94aa38SDavid Howells  */
4178d94aa38SDavid Howells bool __rxrpc_queue_call(struct rxrpc_call *call)
4188d94aa38SDavid Howells {
4198d94aa38SDavid Howells 	const void *here = __builtin_return_address(0);
4208d94aa38SDavid Howells 	int n = atomic_read(&call->usage);
4218d94aa38SDavid Howells 	ASSERTCMP(n, >=, 1);
4228d94aa38SDavid Howells 	if (rxrpc_queue_work(&call->processor))
4232ab27215SDavid Howells 		trace_rxrpc_call(call, rxrpc_call_queued_ref, n, here, NULL);
4248d94aa38SDavid Howells 	else
4258d94aa38SDavid Howells 		rxrpc_put_call(call, rxrpc_call_put_noqueue);
4268d94aa38SDavid Howells 	return true;
4278d94aa38SDavid Howells }
4288d94aa38SDavid Howells 
4298d94aa38SDavid Howells /*
430e34d4234SDavid Howells  * Note the re-emergence of a call.
431e34d4234SDavid Howells  */
432e34d4234SDavid Howells void rxrpc_see_call(struct rxrpc_call *call)
433e34d4234SDavid Howells {
434e34d4234SDavid Howells 	const void *here = __builtin_return_address(0);
435e34d4234SDavid Howells 	if (call) {
436e34d4234SDavid Howells 		int n = atomic_read(&call->usage);
437e34d4234SDavid Howells 
4382ab27215SDavid Howells 		trace_rxrpc_call(call, rxrpc_call_seen, n, here, NULL);
439e34d4234SDavid Howells 	}
440e34d4234SDavid Howells }
441e34d4234SDavid Howells 
442e34d4234SDavid Howells /*
443e34d4234SDavid Howells  * Note the addition of a ref on a call.
444e34d4234SDavid Howells  */
445fff72429SDavid Howells void rxrpc_get_call(struct rxrpc_call *call, enum rxrpc_call_trace op)
446e34d4234SDavid Howells {
447e34d4234SDavid Howells 	const void *here = __builtin_return_address(0);
448e34d4234SDavid Howells 	int n = atomic_inc_return(&call->usage);
449e34d4234SDavid Howells 
4502ab27215SDavid Howells 	trace_rxrpc_call(call, op, n, here, NULL);
451e34d4234SDavid Howells }
452e34d4234SDavid Howells 
453e34d4234SDavid Howells /*
454248f219cSDavid Howells  * Detach a call from its owning socket.
4558c3e34a4SDavid Howells  */
4568d94aa38SDavid Howells void rxrpc_release_call(struct rxrpc_sock *rx, struct rxrpc_call *call)
4578c3e34a4SDavid Howells {
458a84a46d7SDavid Howells 	const void *here = __builtin_return_address(0);
459248f219cSDavid Howells 	struct rxrpc_connection *conn = call->conn;
460248f219cSDavid Howells 	bool put = false;
461248f219cSDavid Howells 	int i;
462248f219cSDavid Howells 
463248f219cSDavid Howells 	_enter("{%d,%d}", call->debug_id, atomic_read(&call->usage));
464248f219cSDavid Howells 
465a84a46d7SDavid Howells 	trace_rxrpc_call(call, rxrpc_call_release, atomic_read(&call->usage),
466a84a46d7SDavid Howells 			 here, (const void *)call->flags);
4678c3e34a4SDavid Howells 
468a84a46d7SDavid Howells 	ASSERTCMP(call->state, ==, RXRPC_CALL_COMPLETE);
469e34d4234SDavid Howells 
4708c3e34a4SDavid Howells 	spin_lock_bh(&call->lock);
4718c3e34a4SDavid Howells 	if (test_and_set_bit(RXRPC_CALL_RELEASED, &call->flags))
4728c3e34a4SDavid Howells 		BUG();
4738c3e34a4SDavid Howells 	spin_unlock_bh(&call->lock);
4748c3e34a4SDavid Howells 
475248f219cSDavid Howells 	del_timer_sync(&call->timer);
4768c3e34a4SDavid Howells 
477248f219cSDavid Howells 	/* Make sure we don't get any more notifications */
478248f219cSDavid Howells 	write_lock_bh(&rx->recvmsg_lock);
479e653cfe4SDavid Howells 
480248f219cSDavid Howells 	if (!list_empty(&call->recvmsg_link)) {
4818c3e34a4SDavid Howells 		_debug("unlinking once-pending call %p { e=%lx f=%lx }",
4828c3e34a4SDavid Howells 		       call, call->events, call->flags);
483248f219cSDavid Howells 		list_del(&call->recvmsg_link);
484248f219cSDavid Howells 		put = true;
485248f219cSDavid Howells 	}
486248f219cSDavid Howells 
487248f219cSDavid Howells 	/* list_empty() must return false in rxrpc_notify_socket() */
488248f219cSDavid Howells 	call->recvmsg_link.next = NULL;
489248f219cSDavid Howells 	call->recvmsg_link.prev = NULL;
490248f219cSDavid Howells 
491248f219cSDavid Howells 	write_unlock_bh(&rx->recvmsg_lock);
492248f219cSDavid Howells 	if (put)
493248f219cSDavid Howells 		rxrpc_put_call(call, rxrpc_call_put);
494248f219cSDavid Howells 
495248f219cSDavid Howells 	write_lock(&rx->call_lock);
496248f219cSDavid Howells 
497248f219cSDavid Howells 	if (test_and_clear_bit(RXRPC_CALL_HAS_USERID, &call->flags)) {
4988c3e34a4SDavid Howells 		rb_erase(&call->sock_node, &rx->calls);
4998c3e34a4SDavid Howells 		memset(&call->sock_node, 0xdd, sizeof(call->sock_node));
5008d94aa38SDavid Howells 		rxrpc_put_call(call, rxrpc_call_put_userid);
5018c3e34a4SDavid Howells 	}
5028c3e34a4SDavid Howells 
503248f219cSDavid Howells 	list_del(&call->sock_link);
504248f219cSDavid Howells 	write_unlock(&rx->call_lock);
5058c3e34a4SDavid Howells 
506248f219cSDavid Howells 	_debug("RELEASE CALL %p (%d CONN %p)", call, call->debug_id, conn);
5078c3e34a4SDavid Howells 
508248f219cSDavid Howells 	if (conn)
509e653cfe4SDavid Howells 		rxrpc_disconnect_call(call);
510e653cfe4SDavid Howells 
511248f219cSDavid Howells 	for (i = 0; i < RXRPC_RXTX_BUFF_SIZE; i++) {
51271f3ca40SDavid Howells 		rxrpc_free_skb(call->rxtx_buffer[i],
51371f3ca40SDavid Howells 			       (call->tx_phase ? rxrpc_skb_tx_cleaned :
51471f3ca40SDavid Howells 				rxrpc_skb_rx_cleaned));
515248f219cSDavid Howells 		call->rxtx_buffer[i] = NULL;
5168c3e34a4SDavid Howells 	}
5178c3e34a4SDavid Howells 
5188c3e34a4SDavid Howells 	_leave("");
5198c3e34a4SDavid Howells }
5208c3e34a4SDavid Howells 
5218c3e34a4SDavid Howells /*
522c038a58cSDavid Howells  * Prepare a kernel service call for retry.
523c038a58cSDavid Howells  */
524c038a58cSDavid Howells int rxrpc_prepare_call_for_retry(struct rxrpc_sock *rx, struct rxrpc_call *call)
525c038a58cSDavid Howells {
526c038a58cSDavid Howells 	const void *here = __builtin_return_address(0);
527c038a58cSDavid Howells 	int i;
528c038a58cSDavid Howells 	u8 last = 0;
529c038a58cSDavid Howells 
530c038a58cSDavid Howells 	_enter("{%d,%d}", call->debug_id, atomic_read(&call->usage));
531c038a58cSDavid Howells 
532c038a58cSDavid Howells 	trace_rxrpc_call(call, rxrpc_call_release, atomic_read(&call->usage),
533c038a58cSDavid Howells 			 here, (const void *)call->flags);
534c038a58cSDavid Howells 
535c038a58cSDavid Howells 	ASSERTCMP(call->state, ==, RXRPC_CALL_COMPLETE);
536c038a58cSDavid Howells 	ASSERTCMP(call->completion, !=, RXRPC_CALL_REMOTELY_ABORTED);
537c038a58cSDavid Howells 	ASSERTCMP(call->completion, !=, RXRPC_CALL_LOCALLY_ABORTED);
538c038a58cSDavid Howells 	ASSERT(list_empty(&call->recvmsg_link));
539c038a58cSDavid Howells 
540c038a58cSDavid Howells 	del_timer_sync(&call->timer);
541c038a58cSDavid Howells 
542c038a58cSDavid Howells 	_debug("RELEASE CALL %p (%d CONN %p)", call, call->debug_id, call->conn);
543c038a58cSDavid Howells 
544c038a58cSDavid Howells 	if (call->conn)
545c038a58cSDavid Howells 		rxrpc_disconnect_call(call);
546c038a58cSDavid Howells 
547c038a58cSDavid Howells 	if (rxrpc_is_service_call(call) ||
548c038a58cSDavid Howells 	    !call->tx_phase ||
549c038a58cSDavid Howells 	    call->tx_hard_ack != 0 ||
550c038a58cSDavid Howells 	    call->rx_hard_ack != 0 ||
551c038a58cSDavid Howells 	    call->rx_top != 0)
552c038a58cSDavid Howells 		return -EINVAL;
553c038a58cSDavid Howells 
554c038a58cSDavid Howells 	call->state = RXRPC_CALL_UNINITIALISED;
555c038a58cSDavid Howells 	call->completion = RXRPC_CALL_SUCCEEDED;
556c038a58cSDavid Howells 	call->call_id = 0;
557c038a58cSDavid Howells 	call->cid = 0;
558c038a58cSDavid Howells 	call->cong_cwnd = 0;
559c038a58cSDavid Howells 	call->cong_extra = 0;
560c038a58cSDavid Howells 	call->cong_ssthresh = 0;
561c038a58cSDavid Howells 	call->cong_mode = 0;
562c038a58cSDavid Howells 	call->cong_dup_acks = 0;
563c038a58cSDavid Howells 	call->cong_cumul_acks = 0;
564c038a58cSDavid Howells 	call->acks_lowest_nak = 0;
565c038a58cSDavid Howells 
566c038a58cSDavid Howells 	for (i = 0; i < RXRPC_RXTX_BUFF_SIZE; i++) {
567c038a58cSDavid Howells 		last |= call->rxtx_annotations[i];
568c038a58cSDavid Howells 		call->rxtx_annotations[i] &= RXRPC_TX_ANNO_LAST;
569c038a58cSDavid Howells 		call->rxtx_annotations[i] |= RXRPC_TX_ANNO_RETRANS;
570c038a58cSDavid Howells 	}
571c038a58cSDavid Howells 
572c038a58cSDavid Howells 	_leave(" = 0");
573c038a58cSDavid Howells 	return 0;
574c038a58cSDavid Howells }
575c038a58cSDavid Howells 
576c038a58cSDavid Howells /*
5778c3e34a4SDavid Howells  * release all the calls associated with a socket
5788c3e34a4SDavid Howells  */
5798c3e34a4SDavid Howells void rxrpc_release_calls_on_socket(struct rxrpc_sock *rx)
5808c3e34a4SDavid Howells {
5818c3e34a4SDavid Howells 	struct rxrpc_call *call;
5828c3e34a4SDavid Howells 
5838c3e34a4SDavid Howells 	_enter("%p", rx);
5848c3e34a4SDavid Howells 
5850360da6dSDavid Howells 	while (!list_empty(&rx->to_be_accepted)) {
5860360da6dSDavid Howells 		call = list_entry(rx->to_be_accepted.next,
5870360da6dSDavid Howells 				  struct rxrpc_call, accept_link);
5880360da6dSDavid Howells 		list_del(&call->accept_link);
5893a92789aSDavid Howells 		rxrpc_abort_call("SKR", call, 0, RX_CALL_DEAD, -ECONNRESET);
5900360da6dSDavid Howells 		rxrpc_put_call(call, rxrpc_call_put);
5910360da6dSDavid Howells 	}
5920360da6dSDavid Howells 
593248f219cSDavid Howells 	while (!list_empty(&rx->sock_calls)) {
594248f219cSDavid Howells 		call = list_entry(rx->sock_calls.next,
595248f219cSDavid Howells 				  struct rxrpc_call, sock_link);
596248f219cSDavid Howells 		rxrpc_get_call(call, rxrpc_call_got);
5973a92789aSDavid Howells 		rxrpc_abort_call("SKT", call, 0, RX_CALL_DEAD, -ECONNRESET);
59826cb02aaSDavid Howells 		rxrpc_send_abort_packet(call);
5998d94aa38SDavid Howells 		rxrpc_release_call(rx, call);
600248f219cSDavid Howells 		rxrpc_put_call(call, rxrpc_call_put);
6018c3e34a4SDavid Howells 	}
6028c3e34a4SDavid Howells 
6038c3e34a4SDavid Howells 	_leave("");
6048c3e34a4SDavid Howells }
6058c3e34a4SDavid Howells 
6068c3e34a4SDavid Howells /*
6078c3e34a4SDavid Howells  * release a call
6088c3e34a4SDavid Howells  */
609fff72429SDavid Howells void rxrpc_put_call(struct rxrpc_call *call, enum rxrpc_call_trace op)
6108c3e34a4SDavid Howells {
6112baec2c3SDavid Howells 	struct rxrpc_net *rxnet;
612e34d4234SDavid Howells 	const void *here = __builtin_return_address(0);
6132ab27215SDavid Howells 	int n;
614e34d4234SDavid Howells 
6158c3e34a4SDavid Howells 	ASSERT(call != NULL);
6168c3e34a4SDavid Howells 
617e34d4234SDavid Howells 	n = atomic_dec_return(&call->usage);
6182ab27215SDavid Howells 	trace_rxrpc_call(call, op, n, here, NULL);
619e34d4234SDavid Howells 	ASSERTCMP(n, >=, 0);
620e34d4234SDavid Howells 	if (n == 0) {
6218c3e34a4SDavid Howells 		_debug("call %d dead", call->debug_id);
622248f219cSDavid Howells 		ASSERTCMP(call->state, ==, RXRPC_CALL_COMPLETE);
623e34d4234SDavid Howells 
6242baec2c3SDavid Howells 		if (!list_empty(&call->link)) {
6252baec2c3SDavid Howells 			rxnet = rxrpc_net(sock_net(&call->socket->sk));
6262baec2c3SDavid Howells 			write_lock(&rxnet->call_lock);
627248f219cSDavid Howells 			list_del_init(&call->link);
6282baec2c3SDavid Howells 			write_unlock(&rxnet->call_lock);
6292baec2c3SDavid Howells 		}
630e34d4234SDavid Howells 
6318d94aa38SDavid Howells 		rxrpc_cleanup_call(call);
632e34d4234SDavid Howells 	}
6338c3e34a4SDavid Howells }
6348c3e34a4SDavid Howells 
6358c3e34a4SDavid Howells /*
636dee46364SDavid Howells  * Final call destruction under RCU.
637dee46364SDavid Howells  */
638dee46364SDavid Howells static void rxrpc_rcu_destroy_call(struct rcu_head *rcu)
639dee46364SDavid Howells {
640dee46364SDavid Howells 	struct rxrpc_call *call = container_of(rcu, struct rxrpc_call, rcu);
641dee46364SDavid Howells 
642df5d8bf7SDavid Howells 	rxrpc_put_peer(call->peer);
643248f219cSDavid Howells 	kfree(call->rxtx_buffer);
644248f219cSDavid Howells 	kfree(call->rxtx_annotations);
645dee46364SDavid Howells 	kmem_cache_free(rxrpc_call_jar, call);
646dee46364SDavid Howells }
647dee46364SDavid Howells 
648dee46364SDavid Howells /*
6498c3e34a4SDavid Howells  * clean up a call
6508c3e34a4SDavid Howells  */
65100e90712SDavid Howells void rxrpc_cleanup_call(struct rxrpc_call *call)
6528c3e34a4SDavid Howells {
653248f219cSDavid Howells 	int i;
6548c3e34a4SDavid Howells 
655248f219cSDavid Howells 	_net("DESTROY CALL %d", call->debug_id);
6568c3e34a4SDavid Howells 
6578c3e34a4SDavid Howells 	memset(&call->sock_node, 0xcd, sizeof(call->sock_node));
6588c3e34a4SDavid Howells 
659248f219cSDavid Howells 	del_timer_sync(&call->timer);
6608c3e34a4SDavid Howells 
6618d94aa38SDavid Howells 	ASSERTCMP(call->state, ==, RXRPC_CALL_COMPLETE);
6628c3e34a4SDavid Howells 	ASSERT(test_bit(RXRPC_CALL_RELEASED, &call->flags));
663e653cfe4SDavid Howells 	ASSERTCMP(call->conn, ==, NULL);
6648c3e34a4SDavid Howells 
665248f219cSDavid Howells 	/* Clean up the Rx/Tx buffer */
666248f219cSDavid Howells 	for (i = 0; i < RXRPC_RXTX_BUFF_SIZE; i++)
66771f3ca40SDavid Howells 		rxrpc_free_skb(call->rxtx_buffer[i],
66871f3ca40SDavid Howells 			       (call->tx_phase ? rxrpc_skb_tx_cleaned :
66971f3ca40SDavid Howells 				rxrpc_skb_rx_cleaned));
6708c3e34a4SDavid Howells 
67171f3ca40SDavid Howells 	rxrpc_free_skb(call->tx_pending, rxrpc_skb_tx_cleaned);
6728c3e34a4SDavid Howells 
673dee46364SDavid Howells 	call_rcu(&call->rcu, rxrpc_rcu_destroy_call);
6748c3e34a4SDavid Howells }
6758c3e34a4SDavid Howells 
6768c3e34a4SDavid Howells /*
6772baec2c3SDavid Howells  * Make sure that all calls are gone from a network namespace.  To reach this
6782baec2c3SDavid Howells  * point, any open UDP sockets in that namespace must have been closed, so any
6792baec2c3SDavid Howells  * outstanding calls cannot be doing I/O.
6808c3e34a4SDavid Howells  */
6812baec2c3SDavid Howells void rxrpc_destroy_all_calls(struct rxrpc_net *rxnet)
6828c3e34a4SDavid Howells {
6838c3e34a4SDavid Howells 	struct rxrpc_call *call;
6848c3e34a4SDavid Howells 
6858c3e34a4SDavid Howells 	_enter("");
6868d94aa38SDavid Howells 
6872baec2c3SDavid Howells 	if (list_empty(&rxnet->calls))
6888d94aa38SDavid Howells 		return;
6898d94aa38SDavid Howells 
6902baec2c3SDavid Howells 	write_lock(&rxnet->call_lock);
6918c3e34a4SDavid Howells 
6922baec2c3SDavid Howells 	while (!list_empty(&rxnet->calls)) {
6932baec2c3SDavid Howells 		call = list_entry(rxnet->calls.next, struct rxrpc_call, link);
6948c3e34a4SDavid Howells 		_debug("Zapping call %p", call);
6958c3e34a4SDavid Howells 
696e34d4234SDavid Howells 		rxrpc_see_call(call);
6978c3e34a4SDavid Howells 		list_del_init(&call->link);
6988c3e34a4SDavid Howells 
699248f219cSDavid Howells 		pr_err("Call %p still in use (%d,%s,%lx,%lx)!\n",
7008c3e34a4SDavid Howells 		       call, atomic_read(&call->usage),
7018c3e34a4SDavid Howells 		       rxrpc_call_states[call->state],
7028c3e34a4SDavid Howells 		       call->flags, call->events);
7038c3e34a4SDavid Howells 
7042baec2c3SDavid Howells 		write_unlock(&rxnet->call_lock);
7058c3e34a4SDavid Howells 		cond_resched();
7062baec2c3SDavid Howells 		write_lock(&rxnet->call_lock);
7078c3e34a4SDavid Howells 	}
7088c3e34a4SDavid Howells 
7092baec2c3SDavid Howells 	write_unlock(&rxnet->call_lock);
7108c3e34a4SDavid Howells }
711