1 // SPDX-License-Identifier: GPL-2.0-only 2 // Copyright (c) 2020, Nikolay Aleksandrov <nikolay@cumulusnetworks.com> 3 #include <linux/kernel.h> 4 #include <linux/netdevice.h> 5 #include <linux/rtnetlink.h> 6 #include <linux/slab.h> 7 #include <net/ip_tunnels.h> 8 9 #include "br_private.h" 10 #include "br_private_tunnel.h" 11 12 static bool __vlan_tun_put(struct sk_buff *skb, const struct net_bridge_vlan *v) 13 { 14 __be32 tid = tunnel_id_to_key32(v->tinfo.tunnel_id); 15 struct nlattr *nest; 16 17 if (!v->tinfo.tunnel_dst) 18 return true; 19 20 nest = nla_nest_start(skb, BRIDGE_VLANDB_ENTRY_TUNNEL_INFO); 21 if (!nest) 22 return false; 23 if (nla_put_u32(skb, BRIDGE_VLANDB_TINFO_ID, be32_to_cpu(tid))) { 24 nla_nest_cancel(skb, nest); 25 return false; 26 } 27 nla_nest_end(skb, nest); 28 29 return true; 30 } 31 32 static bool __vlan_tun_can_enter_range(const struct net_bridge_vlan *v_curr, 33 const struct net_bridge_vlan *range_end) 34 { 35 return (!v_curr->tinfo.tunnel_dst && !range_end->tinfo.tunnel_dst) || 36 vlan_tunid_inrange(v_curr, range_end); 37 } 38 39 /* check if the options' state of v_curr allow it to enter the range */ 40 bool br_vlan_opts_eq_range(const struct net_bridge_vlan *v_curr, 41 const struct net_bridge_vlan *range_end) 42 { 43 return v_curr->state == range_end->state && 44 __vlan_tun_can_enter_range(v_curr, range_end); 45 } 46 47 bool br_vlan_opts_fill(struct sk_buff *skb, const struct net_bridge_vlan *v) 48 { 49 return !nla_put_u8(skb, BRIDGE_VLANDB_ENTRY_STATE, 50 br_vlan_get_state(v)) && 51 __vlan_tun_put(skb, v); 52 } 53 54 size_t br_vlan_opts_nl_size(void) 55 { 56 return nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_ENTRY_STATE */ 57 + nla_total_size(0) /* BRIDGE_VLANDB_ENTRY_TUNNEL_INFO */ 58 + nla_total_size(sizeof(u32)); /* BRIDGE_VLANDB_TINFO_ID */ 59 } 60 61 static int br_vlan_modify_state(struct net_bridge_vlan_group *vg, 62 struct net_bridge_vlan *v, 63 u8 state, 64 bool *changed, 65 struct netlink_ext_ack *extack) 66 { 67 struct net_bridge *br; 68 69 ASSERT_RTNL(); 70 71 if (state > BR_STATE_BLOCKING) { 72 NL_SET_ERR_MSG_MOD(extack, "Invalid vlan state"); 73 return -EINVAL; 74 } 75 76 if (br_vlan_is_brentry(v)) 77 br = v->br; 78 else 79 br = v->port->br; 80 81 if (br->stp_enabled == BR_KERNEL_STP) { 82 NL_SET_ERR_MSG_MOD(extack, "Can't modify vlan state when using kernel STP"); 83 return -EBUSY; 84 } 85 86 if (v->state == state) 87 return 0; 88 89 if (v->vid == br_get_pvid(vg)) 90 br_vlan_set_pvid_state(vg, state); 91 92 br_vlan_set_state(v, state); 93 *changed = true; 94 95 return 0; 96 } 97 98 static const struct nla_policy br_vlandb_tinfo_pol[BRIDGE_VLANDB_TINFO_MAX + 1] = { 99 [BRIDGE_VLANDB_TINFO_ID] = { .type = NLA_U32 }, 100 [BRIDGE_VLANDB_TINFO_CMD] = { .type = NLA_U32 }, 101 }; 102 103 static int br_vlan_modify_tunnel(const struct net_bridge_port *p, 104 struct net_bridge_vlan *v, 105 struct nlattr **tb, 106 bool *changed, 107 struct netlink_ext_ack *extack) 108 { 109 struct nlattr *tun_tb[BRIDGE_VLANDB_TINFO_MAX + 1], *attr; 110 struct bridge_vlan_info *vinfo; 111 u32 tun_id = 0; 112 int cmd, err; 113 114 if (!p) { 115 NL_SET_ERR_MSG_MOD(extack, "Can't modify tunnel mapping of non-port vlans"); 116 return -EINVAL; 117 } 118 if (!(p->flags & BR_VLAN_TUNNEL)) { 119 NL_SET_ERR_MSG_MOD(extack, "Port doesn't have tunnel flag set"); 120 return -EINVAL; 121 } 122 123 attr = tb[BRIDGE_VLANDB_ENTRY_TUNNEL_INFO]; 124 err = nla_parse_nested(tun_tb, BRIDGE_VLANDB_TINFO_MAX, attr, 125 br_vlandb_tinfo_pol, extack); 126 if (err) 127 return err; 128 129 if (!tun_tb[BRIDGE_VLANDB_TINFO_CMD]) { 130 NL_SET_ERR_MSG_MOD(extack, "Missing tunnel command attribute"); 131 return -ENOENT; 132 } 133 cmd = nla_get_u32(tun_tb[BRIDGE_VLANDB_TINFO_CMD]); 134 switch (cmd) { 135 case RTM_SETLINK: 136 if (!tun_tb[BRIDGE_VLANDB_TINFO_ID]) { 137 NL_SET_ERR_MSG_MOD(extack, "Missing tunnel id attribute"); 138 return -ENOENT; 139 } 140 /* when working on vlan ranges this is the starting tunnel id */ 141 tun_id = nla_get_u32(tun_tb[BRIDGE_VLANDB_TINFO_ID]); 142 /* vlan info attr is guaranteed by br_vlan_rtm_process_one */ 143 vinfo = nla_data(tb[BRIDGE_VLANDB_ENTRY_INFO]); 144 /* tunnel ids are mapped to each vlan in increasing order, 145 * the starting vlan is in BRIDGE_VLANDB_ENTRY_INFO and v is the 146 * current vlan, so we compute: tun_id + v - vinfo->vid 147 */ 148 tun_id += v->vid - vinfo->vid; 149 break; 150 case RTM_DELLINK: 151 break; 152 default: 153 NL_SET_ERR_MSG_MOD(extack, "Unsupported tunnel command"); 154 return -EINVAL; 155 } 156 157 return br_vlan_tunnel_info(p, cmd, v->vid, tun_id, changed); 158 } 159 160 static int br_vlan_process_one_opts(const struct net_bridge *br, 161 const struct net_bridge_port *p, 162 struct net_bridge_vlan_group *vg, 163 struct net_bridge_vlan *v, 164 struct nlattr **tb, 165 bool *changed, 166 struct netlink_ext_ack *extack) 167 { 168 int err; 169 170 *changed = false; 171 if (tb[BRIDGE_VLANDB_ENTRY_STATE]) { 172 u8 state = nla_get_u8(tb[BRIDGE_VLANDB_ENTRY_STATE]); 173 174 err = br_vlan_modify_state(vg, v, state, changed, extack); 175 if (err) 176 return err; 177 } 178 if (tb[BRIDGE_VLANDB_ENTRY_TUNNEL_INFO]) { 179 err = br_vlan_modify_tunnel(p, v, tb, changed, extack); 180 if (err) 181 return err; 182 } 183 184 return 0; 185 } 186 187 int br_vlan_process_options(const struct net_bridge *br, 188 const struct net_bridge_port *p, 189 struct net_bridge_vlan *range_start, 190 struct net_bridge_vlan *range_end, 191 struct nlattr **tb, 192 struct netlink_ext_ack *extack) 193 { 194 struct net_bridge_vlan *v, *curr_start = NULL, *curr_end = NULL; 195 struct net_bridge_vlan_group *vg; 196 int vid, err = 0; 197 u16 pvid; 198 199 if (p) 200 vg = nbp_vlan_group(p); 201 else 202 vg = br_vlan_group(br); 203 204 if (!range_start || !br_vlan_should_use(range_start)) { 205 NL_SET_ERR_MSG_MOD(extack, "Vlan range start doesn't exist, can't process options"); 206 return -ENOENT; 207 } 208 if (!range_end || !br_vlan_should_use(range_end)) { 209 NL_SET_ERR_MSG_MOD(extack, "Vlan range end doesn't exist, can't process options"); 210 return -ENOENT; 211 } 212 213 pvid = br_get_pvid(vg); 214 for (vid = range_start->vid; vid <= range_end->vid; vid++) { 215 bool changed = false; 216 217 v = br_vlan_find(vg, vid); 218 if (!v || !br_vlan_should_use(v)) { 219 NL_SET_ERR_MSG_MOD(extack, "Vlan in range doesn't exist, can't process options"); 220 err = -ENOENT; 221 break; 222 } 223 224 err = br_vlan_process_one_opts(br, p, vg, v, tb, &changed, 225 extack); 226 if (err) 227 break; 228 229 if (changed) { 230 /* vlan options changed, check for range */ 231 if (!curr_start) { 232 curr_start = v; 233 curr_end = v; 234 continue; 235 } 236 237 if (v->vid == pvid || 238 !br_vlan_can_enter_range(v, curr_end)) { 239 br_vlan_notify(br, p, curr_start->vid, 240 curr_end->vid, RTM_NEWVLAN); 241 curr_start = v; 242 } 243 curr_end = v; 244 } else { 245 /* nothing changed and nothing to notify yet */ 246 if (!curr_start) 247 continue; 248 249 br_vlan_notify(br, p, curr_start->vid, curr_end->vid, 250 RTM_NEWVLAN); 251 curr_start = NULL; 252 curr_end = NULL; 253 } 254 } 255 if (curr_start) 256 br_vlan_notify(br, p, curr_start->vid, curr_end->vid, 257 RTM_NEWVLAN); 258 259 return err; 260 } 261 262 bool br_vlan_global_opts_can_enter_range(const struct net_bridge_vlan *v_curr, 263 const struct net_bridge_vlan *r_end) 264 { 265 return v_curr->vid - r_end->vid == 1 && 266 ((v_curr->priv_flags ^ r_end->priv_flags) & 267 BR_VLFLAG_GLOBAL_MCAST_ENABLED) == 0 && 268 br_multicast_ctx_options_equal(&v_curr->br_mcast_ctx, 269 &r_end->br_mcast_ctx); 270 } 271 272 bool br_vlan_global_opts_fill(struct sk_buff *skb, u16 vid, u16 vid_range, 273 const struct net_bridge_vlan *v_opts) 274 { 275 u64 clockval __maybe_unused; 276 struct nlattr *nest; 277 278 nest = nla_nest_start(skb, BRIDGE_VLANDB_GLOBAL_OPTIONS); 279 if (!nest) 280 return false; 281 282 if (nla_put_u16(skb, BRIDGE_VLANDB_GOPTS_ID, vid)) 283 goto out_err; 284 285 if (vid_range && vid < vid_range && 286 nla_put_u16(skb, BRIDGE_VLANDB_GOPTS_RANGE, vid_range)) 287 goto out_err; 288 289 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING 290 if (nla_put_u8(skb, BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING, 291 !!(v_opts->priv_flags & BR_VLFLAG_GLOBAL_MCAST_ENABLED)) || 292 nla_put_u8(skb, BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION, 293 v_opts->br_mcast_ctx.multicast_igmp_version) || 294 nla_put_u32(skb, BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT, 295 v_opts->br_mcast_ctx.multicast_last_member_count) || 296 nla_put_u32(skb, BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT, 297 v_opts->br_mcast_ctx.multicast_startup_query_count)) 298 goto out_err; 299 300 clockval = jiffies_to_clock_t(v_opts->br_mcast_ctx.multicast_last_member_interval); 301 if (nla_put_u64_64bit(skb, BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL, 302 clockval, BRIDGE_VLANDB_GOPTS_PAD)) 303 goto out_err; 304 clockval = jiffies_to_clock_t(v_opts->br_mcast_ctx.multicast_membership_interval); 305 if (nla_put_u64_64bit(skb, BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL, 306 clockval, BRIDGE_VLANDB_GOPTS_PAD)) 307 goto out_err; 308 clockval = jiffies_to_clock_t(v_opts->br_mcast_ctx.multicast_querier_interval); 309 if (nla_put_u64_64bit(skb, BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_INTVL, 310 clockval, BRIDGE_VLANDB_GOPTS_PAD)) 311 goto out_err; 312 313 #if IS_ENABLED(CONFIG_IPV6) 314 if (nla_put_u8(skb, BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION, 315 v_opts->br_mcast_ctx.multicast_mld_version)) 316 goto out_err; 317 #endif 318 #endif 319 320 nla_nest_end(skb, nest); 321 322 return true; 323 324 out_err: 325 nla_nest_cancel(skb, nest); 326 return false; 327 } 328 329 static size_t rtnl_vlan_global_opts_nlmsg_size(void) 330 { 331 return NLMSG_ALIGN(sizeof(struct br_vlan_msg)) 332 + nla_total_size(0) /* BRIDGE_VLANDB_GLOBAL_OPTIONS */ 333 + nla_total_size(sizeof(u16)) /* BRIDGE_VLANDB_GOPTS_ID */ 334 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING 335 + nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING */ 336 + nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION */ 337 + nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION */ 338 + nla_total_size(sizeof(u32)) /* BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT */ 339 + nla_total_size(sizeof(u32)) /* BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT */ 340 + nla_total_size(sizeof(u64)) /* BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL */ 341 + nla_total_size(sizeof(u64)) /* BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL */ 342 + nla_total_size(sizeof(u64)) /* BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_INTVL */ 343 #endif 344 + nla_total_size(sizeof(u16)); /* BRIDGE_VLANDB_GOPTS_RANGE */ 345 } 346 347 static void br_vlan_global_opts_notify(const struct net_bridge *br, 348 u16 vid, u16 vid_range) 349 { 350 struct net_bridge_vlan *v; 351 struct br_vlan_msg *bvm; 352 struct nlmsghdr *nlh; 353 struct sk_buff *skb; 354 int err = -ENOBUFS; 355 356 /* right now notifications are done only with rtnl held */ 357 ASSERT_RTNL(); 358 359 skb = nlmsg_new(rtnl_vlan_global_opts_nlmsg_size(), GFP_KERNEL); 360 if (!skb) 361 goto out_err; 362 363 err = -EMSGSIZE; 364 nlh = nlmsg_put(skb, 0, 0, RTM_NEWVLAN, sizeof(*bvm), 0); 365 if (!nlh) 366 goto out_err; 367 bvm = nlmsg_data(nlh); 368 memset(bvm, 0, sizeof(*bvm)); 369 bvm->family = AF_BRIDGE; 370 bvm->ifindex = br->dev->ifindex; 371 372 /* need to find the vlan due to flags/options */ 373 v = br_vlan_find(br_vlan_group(br), vid); 374 if (!v) 375 goto out_kfree; 376 377 if (!br_vlan_global_opts_fill(skb, vid, vid_range, v)) 378 goto out_err; 379 380 nlmsg_end(skb, nlh); 381 rtnl_notify(skb, dev_net(br->dev), 0, RTNLGRP_BRVLAN, NULL, GFP_KERNEL); 382 return; 383 384 out_err: 385 rtnl_set_sk_err(dev_net(br->dev), RTNLGRP_BRVLAN, err); 386 out_kfree: 387 kfree_skb(skb); 388 } 389 390 static int br_vlan_process_global_one_opts(const struct net_bridge *br, 391 struct net_bridge_vlan_group *vg, 392 struct net_bridge_vlan *v, 393 struct nlattr **tb, 394 bool *changed, 395 struct netlink_ext_ack *extack) 396 { 397 int err __maybe_unused; 398 399 *changed = false; 400 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING 401 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING]) { 402 u8 mc_snooping; 403 404 mc_snooping = nla_get_u8(tb[BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING]); 405 if (br_multicast_toggle_global_vlan(v, !!mc_snooping)) 406 *changed = true; 407 } 408 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION]) { 409 u8 ver; 410 411 ver = nla_get_u8(tb[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION]); 412 err = br_multicast_set_igmp_version(&v->br_mcast_ctx, ver); 413 if (err) 414 return err; 415 *changed = true; 416 } 417 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT]) { 418 u32 cnt; 419 420 cnt = nla_get_u32(tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT]); 421 v->br_mcast_ctx.multicast_last_member_count = cnt; 422 *changed = true; 423 } 424 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT]) { 425 u32 cnt; 426 427 cnt = nla_get_u32(tb[BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT]); 428 v->br_mcast_ctx.multicast_startup_query_count = cnt; 429 *changed = true; 430 } 431 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL]) { 432 u64 val; 433 434 val = nla_get_u64(tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL]); 435 v->br_mcast_ctx.multicast_last_member_interval = clock_t_to_jiffies(val); 436 *changed = true; 437 } 438 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL]) { 439 u64 val; 440 441 val = nla_get_u64(tb[BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL]); 442 v->br_mcast_ctx.multicast_membership_interval = clock_t_to_jiffies(val); 443 *changed = true; 444 } 445 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_INTVL]) { 446 u64 val; 447 448 val = nla_get_u64(tb[BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_INTVL]); 449 v->br_mcast_ctx.multicast_querier_interval = clock_t_to_jiffies(val); 450 *changed = true; 451 } 452 #if IS_ENABLED(CONFIG_IPV6) 453 if (tb[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]) { 454 u8 ver; 455 456 ver = nla_get_u8(tb[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]); 457 err = br_multicast_set_mld_version(&v->br_mcast_ctx, ver); 458 if (err) 459 return err; 460 *changed = true; 461 } 462 #endif 463 #endif 464 465 return 0; 466 } 467 468 static const struct nla_policy br_vlan_db_gpol[BRIDGE_VLANDB_GOPTS_MAX + 1] = { 469 [BRIDGE_VLANDB_GOPTS_ID] = { .type = NLA_U16 }, 470 [BRIDGE_VLANDB_GOPTS_RANGE] = { .type = NLA_U16 }, 471 [BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING] = { .type = NLA_U8 }, 472 [BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION] = { .type = NLA_U8 }, 473 [BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION] = { .type = NLA_U8 }, 474 [BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT] = { .type = NLA_U32 }, 475 [BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT] = { .type = NLA_U32 }, 476 [BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL] = { .type = NLA_U64 }, 477 [BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL] = { .type = NLA_U64 }, 478 [BRIDGE_VLANDB_GOPTS_MCAST_QUERIER_INTVL] = { .type = NLA_U64 }, 479 }; 480 481 int br_vlan_rtm_process_global_options(struct net_device *dev, 482 const struct nlattr *attr, 483 int cmd, 484 struct netlink_ext_ack *extack) 485 { 486 struct net_bridge_vlan *v, *curr_start = NULL, *curr_end = NULL; 487 struct nlattr *tb[BRIDGE_VLANDB_GOPTS_MAX + 1]; 488 struct net_bridge_vlan_group *vg; 489 u16 vid, vid_range = 0; 490 struct net_bridge *br; 491 int err = 0; 492 493 if (cmd != RTM_NEWVLAN) { 494 NL_SET_ERR_MSG_MOD(extack, "Global vlan options support only set operation"); 495 return -EINVAL; 496 } 497 if (!netif_is_bridge_master(dev)) { 498 NL_SET_ERR_MSG_MOD(extack, "Global vlan options can only be set on bridge device"); 499 return -EINVAL; 500 } 501 br = netdev_priv(dev); 502 vg = br_vlan_group(br); 503 if (WARN_ON(!vg)) 504 return -ENODEV; 505 506 err = nla_parse_nested(tb, BRIDGE_VLANDB_GOPTS_MAX, attr, 507 br_vlan_db_gpol, extack); 508 if (err) 509 return err; 510 511 if (!tb[BRIDGE_VLANDB_GOPTS_ID]) { 512 NL_SET_ERR_MSG_MOD(extack, "Missing vlan entry id"); 513 return -EINVAL; 514 } 515 vid = nla_get_u16(tb[BRIDGE_VLANDB_GOPTS_ID]); 516 if (!br_vlan_valid_id(vid, extack)) 517 return -EINVAL; 518 519 if (tb[BRIDGE_VLANDB_GOPTS_RANGE]) { 520 vid_range = nla_get_u16(tb[BRIDGE_VLANDB_GOPTS_RANGE]); 521 if (!br_vlan_valid_id(vid_range, extack)) 522 return -EINVAL; 523 if (vid >= vid_range) { 524 NL_SET_ERR_MSG_MOD(extack, "End vlan id is less than or equal to start vlan id"); 525 return -EINVAL; 526 } 527 } else { 528 vid_range = vid; 529 } 530 531 for (; vid <= vid_range; vid++) { 532 bool changed = false; 533 534 v = br_vlan_find(vg, vid); 535 if (!v) { 536 NL_SET_ERR_MSG_MOD(extack, "Vlan in range doesn't exist, can't process global options"); 537 err = -ENOENT; 538 break; 539 } 540 541 err = br_vlan_process_global_one_opts(br, vg, v, tb, &changed, 542 extack); 543 if (err) 544 break; 545 546 if (changed) { 547 /* vlan options changed, check for range */ 548 if (!curr_start) { 549 curr_start = v; 550 curr_end = v; 551 continue; 552 } 553 554 if (!br_vlan_global_opts_can_enter_range(v, curr_end)) { 555 br_vlan_global_opts_notify(br, curr_start->vid, 556 curr_end->vid); 557 curr_start = v; 558 } 559 curr_end = v; 560 } else { 561 /* nothing changed and nothing to notify yet */ 562 if (!curr_start) 563 continue; 564 565 br_vlan_global_opts_notify(br, curr_start->vid, 566 curr_end->vid); 567 curr_start = NULL; 568 curr_end = NULL; 569 } 570 } 571 if (curr_start) 572 br_vlan_global_opts_notify(br, curr_start->vid, curr_end->vid); 573 574 return err; 575 } 576