xref: /openbmc/linux/net/bridge/br_vlan_options.c (revision 2da0aea2)
1 // SPDX-License-Identifier: GPL-2.0-only
2 // Copyright (c) 2020, Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
3 #include <linux/kernel.h>
4 #include <linux/netdevice.h>
5 #include <linux/rtnetlink.h>
6 #include <linux/slab.h>
7 #include <net/ip_tunnels.h>
8 
9 #include "br_private.h"
10 #include "br_private_tunnel.h"
11 
12 static bool __vlan_tun_put(struct sk_buff *skb, const struct net_bridge_vlan *v)
13 {
14 	__be32 tid = tunnel_id_to_key32(v->tinfo.tunnel_id);
15 	struct nlattr *nest;
16 
17 	if (!v->tinfo.tunnel_dst)
18 		return true;
19 
20 	nest = nla_nest_start(skb, BRIDGE_VLANDB_ENTRY_TUNNEL_INFO);
21 	if (!nest)
22 		return false;
23 	if (nla_put_u32(skb, BRIDGE_VLANDB_TINFO_ID, be32_to_cpu(tid))) {
24 		nla_nest_cancel(skb, nest);
25 		return false;
26 	}
27 	nla_nest_end(skb, nest);
28 
29 	return true;
30 }
31 
32 static bool __vlan_tun_can_enter_range(const struct net_bridge_vlan *v_curr,
33 				       const struct net_bridge_vlan *range_end)
34 {
35 	return (!v_curr->tinfo.tunnel_dst && !range_end->tinfo.tunnel_dst) ||
36 	       vlan_tunid_inrange(v_curr, range_end);
37 }
38 
39 /* check if the options' state of v_curr allow it to enter the range */
40 bool br_vlan_opts_eq_range(const struct net_bridge_vlan *v_curr,
41 			   const struct net_bridge_vlan *range_end)
42 {
43 	return v_curr->state == range_end->state &&
44 	       __vlan_tun_can_enter_range(v_curr, range_end);
45 }
46 
47 bool br_vlan_opts_fill(struct sk_buff *skb, const struct net_bridge_vlan *v)
48 {
49 	return !nla_put_u8(skb, BRIDGE_VLANDB_ENTRY_STATE,
50 			   br_vlan_get_state(v)) &&
51 	       __vlan_tun_put(skb, v);
52 }
53 
54 size_t br_vlan_opts_nl_size(void)
55 {
56 	return nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_ENTRY_STATE */
57 	       + nla_total_size(0) /* BRIDGE_VLANDB_ENTRY_TUNNEL_INFO */
58 	       + nla_total_size(sizeof(u32)); /* BRIDGE_VLANDB_TINFO_ID */
59 }
60 
61 static int br_vlan_modify_state(struct net_bridge_vlan_group *vg,
62 				struct net_bridge_vlan *v,
63 				u8 state,
64 				bool *changed,
65 				struct netlink_ext_ack *extack)
66 {
67 	struct net_bridge *br;
68 
69 	ASSERT_RTNL();
70 
71 	if (state > BR_STATE_BLOCKING) {
72 		NL_SET_ERR_MSG_MOD(extack, "Invalid vlan state");
73 		return -EINVAL;
74 	}
75 
76 	if (br_vlan_is_brentry(v))
77 		br = v->br;
78 	else
79 		br = v->port->br;
80 
81 	if (br->stp_enabled == BR_KERNEL_STP) {
82 		NL_SET_ERR_MSG_MOD(extack, "Can't modify vlan state when using kernel STP");
83 		return -EBUSY;
84 	}
85 
86 	if (v->state == state)
87 		return 0;
88 
89 	if (v->vid == br_get_pvid(vg))
90 		br_vlan_set_pvid_state(vg, state);
91 
92 	br_vlan_set_state(v, state);
93 	*changed = true;
94 
95 	return 0;
96 }
97 
98 static const struct nla_policy br_vlandb_tinfo_pol[BRIDGE_VLANDB_TINFO_MAX + 1] = {
99 	[BRIDGE_VLANDB_TINFO_ID]	= { .type = NLA_U32 },
100 	[BRIDGE_VLANDB_TINFO_CMD]	= { .type = NLA_U32 },
101 };
102 
103 static int br_vlan_modify_tunnel(const struct net_bridge_port *p,
104 				 struct net_bridge_vlan *v,
105 				 struct nlattr **tb,
106 				 bool *changed,
107 				 struct netlink_ext_ack *extack)
108 {
109 	struct nlattr *tun_tb[BRIDGE_VLANDB_TINFO_MAX + 1], *attr;
110 	struct bridge_vlan_info *vinfo;
111 	u32 tun_id = 0;
112 	int cmd, err;
113 
114 	if (!p) {
115 		NL_SET_ERR_MSG_MOD(extack, "Can't modify tunnel mapping of non-port vlans");
116 		return -EINVAL;
117 	}
118 	if (!(p->flags & BR_VLAN_TUNNEL)) {
119 		NL_SET_ERR_MSG_MOD(extack, "Port doesn't have tunnel flag set");
120 		return -EINVAL;
121 	}
122 
123 	attr = tb[BRIDGE_VLANDB_ENTRY_TUNNEL_INFO];
124 	err = nla_parse_nested(tun_tb, BRIDGE_VLANDB_TINFO_MAX, attr,
125 			       br_vlandb_tinfo_pol, extack);
126 	if (err)
127 		return err;
128 
129 	if (!tun_tb[BRIDGE_VLANDB_TINFO_CMD]) {
130 		NL_SET_ERR_MSG_MOD(extack, "Missing tunnel command attribute");
131 		return -ENOENT;
132 	}
133 	cmd = nla_get_u32(tun_tb[BRIDGE_VLANDB_TINFO_CMD]);
134 	switch (cmd) {
135 	case RTM_SETLINK:
136 		if (!tun_tb[BRIDGE_VLANDB_TINFO_ID]) {
137 			NL_SET_ERR_MSG_MOD(extack, "Missing tunnel id attribute");
138 			return -ENOENT;
139 		}
140 		/* when working on vlan ranges this is the starting tunnel id */
141 		tun_id = nla_get_u32(tun_tb[BRIDGE_VLANDB_TINFO_ID]);
142 		/* vlan info attr is guaranteed by br_vlan_rtm_process_one */
143 		vinfo = nla_data(tb[BRIDGE_VLANDB_ENTRY_INFO]);
144 		/* tunnel ids are mapped to each vlan in increasing order,
145 		 * the starting vlan is in BRIDGE_VLANDB_ENTRY_INFO and v is the
146 		 * current vlan, so we compute: tun_id + v - vinfo->vid
147 		 */
148 		tun_id += v->vid - vinfo->vid;
149 		break;
150 	case RTM_DELLINK:
151 		break;
152 	default:
153 		NL_SET_ERR_MSG_MOD(extack, "Unsupported tunnel command");
154 		return -EINVAL;
155 	}
156 
157 	return br_vlan_tunnel_info(p, cmd, v->vid, tun_id, changed);
158 }
159 
160 static int br_vlan_process_one_opts(const struct net_bridge *br,
161 				    const struct net_bridge_port *p,
162 				    struct net_bridge_vlan_group *vg,
163 				    struct net_bridge_vlan *v,
164 				    struct nlattr **tb,
165 				    bool *changed,
166 				    struct netlink_ext_ack *extack)
167 {
168 	int err;
169 
170 	*changed = false;
171 	if (tb[BRIDGE_VLANDB_ENTRY_STATE]) {
172 		u8 state = nla_get_u8(tb[BRIDGE_VLANDB_ENTRY_STATE]);
173 
174 		err = br_vlan_modify_state(vg, v, state, changed, extack);
175 		if (err)
176 			return err;
177 	}
178 	if (tb[BRIDGE_VLANDB_ENTRY_TUNNEL_INFO]) {
179 		err = br_vlan_modify_tunnel(p, v, tb, changed, extack);
180 		if (err)
181 			return err;
182 	}
183 
184 	return 0;
185 }
186 
187 int br_vlan_process_options(const struct net_bridge *br,
188 			    const struct net_bridge_port *p,
189 			    struct net_bridge_vlan *range_start,
190 			    struct net_bridge_vlan *range_end,
191 			    struct nlattr **tb,
192 			    struct netlink_ext_ack *extack)
193 {
194 	struct net_bridge_vlan *v, *curr_start = NULL, *curr_end = NULL;
195 	struct net_bridge_vlan_group *vg;
196 	int vid, err = 0;
197 	u16 pvid;
198 
199 	if (p)
200 		vg = nbp_vlan_group(p);
201 	else
202 		vg = br_vlan_group(br);
203 
204 	if (!range_start || !br_vlan_should_use(range_start)) {
205 		NL_SET_ERR_MSG_MOD(extack, "Vlan range start doesn't exist, can't process options");
206 		return -ENOENT;
207 	}
208 	if (!range_end || !br_vlan_should_use(range_end)) {
209 		NL_SET_ERR_MSG_MOD(extack, "Vlan range end doesn't exist, can't process options");
210 		return -ENOENT;
211 	}
212 
213 	pvid = br_get_pvid(vg);
214 	for (vid = range_start->vid; vid <= range_end->vid; vid++) {
215 		bool changed = false;
216 
217 		v = br_vlan_find(vg, vid);
218 		if (!v || !br_vlan_should_use(v)) {
219 			NL_SET_ERR_MSG_MOD(extack, "Vlan in range doesn't exist, can't process options");
220 			err = -ENOENT;
221 			break;
222 		}
223 
224 		err = br_vlan_process_one_opts(br, p, vg, v, tb, &changed,
225 					       extack);
226 		if (err)
227 			break;
228 
229 		if (changed) {
230 			/* vlan options changed, check for range */
231 			if (!curr_start) {
232 				curr_start = v;
233 				curr_end = v;
234 				continue;
235 			}
236 
237 			if (v->vid == pvid ||
238 			    !br_vlan_can_enter_range(v, curr_end)) {
239 				br_vlan_notify(br, p, curr_start->vid,
240 					       curr_end->vid, RTM_NEWVLAN);
241 				curr_start = v;
242 			}
243 			curr_end = v;
244 		} else {
245 			/* nothing changed and nothing to notify yet */
246 			if (!curr_start)
247 				continue;
248 
249 			br_vlan_notify(br, p, curr_start->vid, curr_end->vid,
250 				       RTM_NEWVLAN);
251 			curr_start = NULL;
252 			curr_end = NULL;
253 		}
254 	}
255 	if (curr_start)
256 		br_vlan_notify(br, p, curr_start->vid, curr_end->vid,
257 			       RTM_NEWVLAN);
258 
259 	return err;
260 }
261 
262 bool br_vlan_global_opts_can_enter_range(const struct net_bridge_vlan *v_curr,
263 					 const struct net_bridge_vlan *r_end)
264 {
265 	return v_curr->vid - r_end->vid == 1 &&
266 	       ((v_curr->priv_flags ^ r_end->priv_flags) &
267 		BR_VLFLAG_GLOBAL_MCAST_ENABLED) == 0 &&
268 		br_multicast_ctx_options_equal(&v_curr->br_mcast_ctx,
269 					       &r_end->br_mcast_ctx);
270 }
271 
272 bool br_vlan_global_opts_fill(struct sk_buff *skb, u16 vid, u16 vid_range,
273 			      const struct net_bridge_vlan *v_opts)
274 {
275 	u64 clockval __maybe_unused;
276 	struct nlattr *nest;
277 
278 	nest = nla_nest_start(skb, BRIDGE_VLANDB_GLOBAL_OPTIONS);
279 	if (!nest)
280 		return false;
281 
282 	if (nla_put_u16(skb, BRIDGE_VLANDB_GOPTS_ID, vid))
283 		goto out_err;
284 
285 	if (vid_range && vid < vid_range &&
286 	    nla_put_u16(skb, BRIDGE_VLANDB_GOPTS_RANGE, vid_range))
287 		goto out_err;
288 
289 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING
290 	if (nla_put_u8(skb, BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING,
291 		       !!(v_opts->priv_flags & BR_VLFLAG_GLOBAL_MCAST_ENABLED)) ||
292 	    nla_put_u8(skb, BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION,
293 		       v_opts->br_mcast_ctx.multicast_igmp_version) ||
294 	    nla_put_u32(skb, BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT,
295 			v_opts->br_mcast_ctx.multicast_last_member_count) ||
296 	    nla_put_u32(skb, BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT,
297 			v_opts->br_mcast_ctx.multicast_startup_query_count))
298 		goto out_err;
299 
300 	clockval = jiffies_to_clock_t(v_opts->br_mcast_ctx.multicast_last_member_interval);
301 	if (nla_put_u64_64bit(skb, BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL,
302 			      clockval, BRIDGE_VLANDB_GOPTS_PAD))
303 		goto out_err;
304 	clockval = jiffies_to_clock_t(v_opts->br_mcast_ctx.multicast_membership_interval);
305 	if (nla_put_u64_64bit(skb, BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL,
306 			      clockval, BRIDGE_VLANDB_GOPTS_PAD))
307 		goto out_err;
308 
309 #if IS_ENABLED(CONFIG_IPV6)
310 	if (nla_put_u8(skb, BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION,
311 		       v_opts->br_mcast_ctx.multicast_mld_version))
312 		goto out_err;
313 #endif
314 #endif
315 
316 	nla_nest_end(skb, nest);
317 
318 	return true;
319 
320 out_err:
321 	nla_nest_cancel(skb, nest);
322 	return false;
323 }
324 
325 static size_t rtnl_vlan_global_opts_nlmsg_size(void)
326 {
327 	return NLMSG_ALIGN(sizeof(struct br_vlan_msg))
328 		+ nla_total_size(0) /* BRIDGE_VLANDB_GLOBAL_OPTIONS */
329 		+ nla_total_size(sizeof(u16)) /* BRIDGE_VLANDB_GOPTS_ID */
330 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING
331 		+ nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING */
332 		+ nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION */
333 		+ nla_total_size(sizeof(u8)) /* BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION */
334 		+ nla_total_size(sizeof(u32)) /* BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT */
335 		+ nla_total_size(sizeof(u32)) /* BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT */
336 		+ nla_total_size(sizeof(u64)) /* BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL */
337 		+ nla_total_size(sizeof(u64)) /* BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL */
338 #endif
339 		+ nla_total_size(sizeof(u16)); /* BRIDGE_VLANDB_GOPTS_RANGE */
340 }
341 
342 static void br_vlan_global_opts_notify(const struct net_bridge *br,
343 				       u16 vid, u16 vid_range)
344 {
345 	struct net_bridge_vlan *v;
346 	struct br_vlan_msg *bvm;
347 	struct nlmsghdr *nlh;
348 	struct sk_buff *skb;
349 	int err = -ENOBUFS;
350 
351 	/* right now notifications are done only with rtnl held */
352 	ASSERT_RTNL();
353 
354 	skb = nlmsg_new(rtnl_vlan_global_opts_nlmsg_size(), GFP_KERNEL);
355 	if (!skb)
356 		goto out_err;
357 
358 	err = -EMSGSIZE;
359 	nlh = nlmsg_put(skb, 0, 0, RTM_NEWVLAN, sizeof(*bvm), 0);
360 	if (!nlh)
361 		goto out_err;
362 	bvm = nlmsg_data(nlh);
363 	memset(bvm, 0, sizeof(*bvm));
364 	bvm->family = AF_BRIDGE;
365 	bvm->ifindex = br->dev->ifindex;
366 
367 	/* need to find the vlan due to flags/options */
368 	v = br_vlan_find(br_vlan_group(br), vid);
369 	if (!v)
370 		goto out_kfree;
371 
372 	if (!br_vlan_global_opts_fill(skb, vid, vid_range, v))
373 		goto out_err;
374 
375 	nlmsg_end(skb, nlh);
376 	rtnl_notify(skb, dev_net(br->dev), 0, RTNLGRP_BRVLAN, NULL, GFP_KERNEL);
377 	return;
378 
379 out_err:
380 	rtnl_set_sk_err(dev_net(br->dev), RTNLGRP_BRVLAN, err);
381 out_kfree:
382 	kfree_skb(skb);
383 }
384 
385 static int br_vlan_process_global_one_opts(const struct net_bridge *br,
386 					   struct net_bridge_vlan_group *vg,
387 					   struct net_bridge_vlan *v,
388 					   struct nlattr **tb,
389 					   bool *changed,
390 					   struct netlink_ext_ack *extack)
391 {
392 	int err __maybe_unused;
393 
394 	*changed = false;
395 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING
396 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING]) {
397 		u8 mc_snooping;
398 
399 		mc_snooping = nla_get_u8(tb[BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING]);
400 		if (br_multicast_toggle_global_vlan(v, !!mc_snooping))
401 			*changed = true;
402 	}
403 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION]) {
404 		u8 ver;
405 
406 		ver = nla_get_u8(tb[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION]);
407 		err = br_multicast_set_igmp_version(&v->br_mcast_ctx, ver);
408 		if (err)
409 			return err;
410 		*changed = true;
411 	}
412 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT]) {
413 		u32 cnt;
414 
415 		cnt = nla_get_u32(tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT]);
416 		v->br_mcast_ctx.multicast_last_member_count = cnt;
417 		*changed = true;
418 	}
419 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT]) {
420 		u32 cnt;
421 
422 		cnt = nla_get_u32(tb[BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT]);
423 		v->br_mcast_ctx.multicast_startup_query_count = cnt;
424 		*changed = true;
425 	}
426 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL]) {
427 		u64 val;
428 
429 		val = nla_get_u64(tb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL]);
430 		v->br_mcast_ctx.multicast_last_member_interval = clock_t_to_jiffies(val);
431 		*changed = true;
432 	}
433 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL]) {
434 		u64 val;
435 
436 		val = nla_get_u64(tb[BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL]);
437 		v->br_mcast_ctx.multicast_membership_interval = clock_t_to_jiffies(val);
438 		*changed = true;
439 	}
440 #if IS_ENABLED(CONFIG_IPV6)
441 	if (tb[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]) {
442 		u8 ver;
443 
444 		ver = nla_get_u8(tb[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]);
445 		err = br_multicast_set_mld_version(&v->br_mcast_ctx, ver);
446 		if (err)
447 			return err;
448 		*changed = true;
449 	}
450 #endif
451 #endif
452 
453 	return 0;
454 }
455 
456 static const struct nla_policy br_vlan_db_gpol[BRIDGE_VLANDB_GOPTS_MAX + 1] = {
457 	[BRIDGE_VLANDB_GOPTS_ID]	= { .type = NLA_U16 },
458 	[BRIDGE_VLANDB_GOPTS_RANGE]	= { .type = NLA_U16 },
459 	[BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING]	= { .type = NLA_U8 },
460 	[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]	= { .type = NLA_U8 },
461 	[BRIDGE_VLANDB_GOPTS_MCAST_IGMP_VERSION]	= { .type = NLA_U8 },
462 	[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT]	= { .type = NLA_U32 },
463 	[BRIDGE_VLANDB_GOPTS_MCAST_STARTUP_QUERY_CNT]	= { .type = NLA_U32 },
464 	[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_INTVL]	= { .type = NLA_U64 },
465 	[BRIDGE_VLANDB_GOPTS_MCAST_MEMBERSHIP_INTVL]	= { .type = NLA_U64 },
466 };
467 
468 int br_vlan_rtm_process_global_options(struct net_device *dev,
469 				       const struct nlattr *attr,
470 				       int cmd,
471 				       struct netlink_ext_ack *extack)
472 {
473 	struct net_bridge_vlan *v, *curr_start = NULL, *curr_end = NULL;
474 	struct nlattr *tb[BRIDGE_VLANDB_GOPTS_MAX + 1];
475 	struct net_bridge_vlan_group *vg;
476 	u16 vid, vid_range = 0;
477 	struct net_bridge *br;
478 	int err = 0;
479 
480 	if (cmd != RTM_NEWVLAN) {
481 		NL_SET_ERR_MSG_MOD(extack, "Global vlan options support only set operation");
482 		return -EINVAL;
483 	}
484 	if (!netif_is_bridge_master(dev)) {
485 		NL_SET_ERR_MSG_MOD(extack, "Global vlan options can only be set on bridge device");
486 		return -EINVAL;
487 	}
488 	br = netdev_priv(dev);
489 	vg = br_vlan_group(br);
490 	if (WARN_ON(!vg))
491 		return -ENODEV;
492 
493 	err = nla_parse_nested(tb, BRIDGE_VLANDB_GOPTS_MAX, attr,
494 			       br_vlan_db_gpol, extack);
495 	if (err)
496 		return err;
497 
498 	if (!tb[BRIDGE_VLANDB_GOPTS_ID]) {
499 		NL_SET_ERR_MSG_MOD(extack, "Missing vlan entry id");
500 		return -EINVAL;
501 	}
502 	vid = nla_get_u16(tb[BRIDGE_VLANDB_GOPTS_ID]);
503 	if (!br_vlan_valid_id(vid, extack))
504 		return -EINVAL;
505 
506 	if (tb[BRIDGE_VLANDB_GOPTS_RANGE]) {
507 		vid_range = nla_get_u16(tb[BRIDGE_VLANDB_GOPTS_RANGE]);
508 		if (!br_vlan_valid_id(vid_range, extack))
509 			return -EINVAL;
510 		if (vid >= vid_range) {
511 			NL_SET_ERR_MSG_MOD(extack, "End vlan id is less than or equal to start vlan id");
512 			return -EINVAL;
513 		}
514 	} else {
515 		vid_range = vid;
516 	}
517 
518 	for (; vid <= vid_range; vid++) {
519 		bool changed = false;
520 
521 		v = br_vlan_find(vg, vid);
522 		if (!v) {
523 			NL_SET_ERR_MSG_MOD(extack, "Vlan in range doesn't exist, can't process global options");
524 			err = -ENOENT;
525 			break;
526 		}
527 
528 		err = br_vlan_process_global_one_opts(br, vg, v, tb, &changed,
529 						      extack);
530 		if (err)
531 			break;
532 
533 		if (changed) {
534 			/* vlan options changed, check for range */
535 			if (!curr_start) {
536 				curr_start = v;
537 				curr_end = v;
538 				continue;
539 			}
540 
541 			if (!br_vlan_global_opts_can_enter_range(v, curr_end)) {
542 				br_vlan_global_opts_notify(br, curr_start->vid,
543 							   curr_end->vid);
544 				curr_start = v;
545 			}
546 			curr_end = v;
547 		} else {
548 			/* nothing changed and nothing to notify yet */
549 			if (!curr_start)
550 				continue;
551 
552 			br_vlan_global_opts_notify(br, curr_start->vid,
553 						   curr_end->vid);
554 			curr_start = NULL;
555 			curr_end = NULL;
556 		}
557 	}
558 	if (curr_start)
559 		br_vlan_global_opts_notify(br, curr_start->vid, curr_end->vid);
560 
561 	return err;
562 }
563