1 /* Copyright (C) 2011-2017 B.A.T.M.A.N. contributors: 2 * 3 * Antonio Quartulli 4 * 5 * This program is free software; you can redistribute it and/or 6 * modify it under the terms of version 2 of the GNU General Public 7 * License as published by the Free Software Foundation. 8 * 9 * This program is distributed in the hope that it will be useful, but 10 * WITHOUT ANY WARRANTY; without even the implied warranty of 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * General Public License for more details. 13 * 14 * You should have received a copy of the GNU General Public License 15 * along with this program; if not, see <http://www.gnu.org/licenses/>. 16 */ 17 18 #include "distributed-arp-table.h" 19 #include "main.h" 20 21 #include <linux/atomic.h> 22 #include <linux/bitops.h> 23 #include <linux/byteorder/generic.h> 24 #include <linux/errno.h> 25 #include <linux/etherdevice.h> 26 #include <linux/fs.h> 27 #include <linux/if_arp.h> 28 #include <linux/if_ether.h> 29 #include <linux/if_vlan.h> 30 #include <linux/in.h> 31 #include <linux/jiffies.h> 32 #include <linux/kernel.h> 33 #include <linux/kref.h> 34 #include <linux/list.h> 35 #include <linux/rculist.h> 36 #include <linux/rcupdate.h> 37 #include <linux/seq_file.h> 38 #include <linux/skbuff.h> 39 #include <linux/slab.h> 40 #include <linux/spinlock.h> 41 #include <linux/stddef.h> 42 #include <linux/string.h> 43 #include <linux/workqueue.h> 44 #include <net/arp.h> 45 46 #include "hard-interface.h" 47 #include "hash.h" 48 #include "log.h" 49 #include "originator.h" 50 #include "send.h" 51 #include "translation-table.h" 52 #include "tvlv.h" 53 54 static void batadv_dat_purge(struct work_struct *work); 55 56 /** 57 * batadv_dat_start_timer - initialise the DAT periodic worker 58 * @bat_priv: the bat priv with all the soft interface information 59 */ 60 static void batadv_dat_start_timer(struct batadv_priv *bat_priv) 61 { 62 INIT_DELAYED_WORK(&bat_priv->dat.work, batadv_dat_purge); 63 queue_delayed_work(batadv_event_workqueue, &bat_priv->dat.work, 64 msecs_to_jiffies(10000)); 65 } 66 67 /** 68 * batadv_dat_entry_release - release dat_entry from lists and queue for free 69 * after rcu grace period 70 * @ref: kref pointer of the dat_entry 71 */ 72 static void batadv_dat_entry_release(struct kref *ref) 73 { 74 struct batadv_dat_entry *dat_entry; 75 76 dat_entry = container_of(ref, struct batadv_dat_entry, refcount); 77 78 kfree_rcu(dat_entry, rcu); 79 } 80 81 /** 82 * batadv_dat_entry_put - decrement the dat_entry refcounter and possibly 83 * release it 84 * @dat_entry: dat_entry to be free'd 85 */ 86 static void batadv_dat_entry_put(struct batadv_dat_entry *dat_entry) 87 { 88 kref_put(&dat_entry->refcount, batadv_dat_entry_release); 89 } 90 91 /** 92 * batadv_dat_to_purge - check whether a dat_entry has to be purged or not 93 * @dat_entry: the entry to check 94 * 95 * Return: true if the entry has to be purged now, false otherwise. 96 */ 97 static bool batadv_dat_to_purge(struct batadv_dat_entry *dat_entry) 98 { 99 return batadv_has_timed_out(dat_entry->last_update, 100 BATADV_DAT_ENTRY_TIMEOUT); 101 } 102 103 /** 104 * __batadv_dat_purge - delete entries from the DAT local storage 105 * @bat_priv: the bat priv with all the soft interface information 106 * @to_purge: function in charge to decide whether an entry has to be purged or 107 * not. This function takes the dat_entry as argument and has to 108 * returns a boolean value: true is the entry has to be deleted, 109 * false otherwise 110 * 111 * Loops over each entry in the DAT local storage and deletes it if and only if 112 * the to_purge function passed as argument returns true. 113 */ 114 static void __batadv_dat_purge(struct batadv_priv *bat_priv, 115 bool (*to_purge)(struct batadv_dat_entry *)) 116 { 117 spinlock_t *list_lock; /* protects write access to the hash lists */ 118 struct batadv_dat_entry *dat_entry; 119 struct hlist_node *node_tmp; 120 struct hlist_head *head; 121 u32 i; 122 123 if (!bat_priv->dat.hash) 124 return; 125 126 for (i = 0; i < bat_priv->dat.hash->size; i++) { 127 head = &bat_priv->dat.hash->table[i]; 128 list_lock = &bat_priv->dat.hash->list_locks[i]; 129 130 spin_lock_bh(list_lock); 131 hlist_for_each_entry_safe(dat_entry, node_tmp, head, 132 hash_entry) { 133 /* if a helper function has been passed as parameter, 134 * ask it if the entry has to be purged or not 135 */ 136 if (to_purge && !to_purge(dat_entry)) 137 continue; 138 139 hlist_del_rcu(&dat_entry->hash_entry); 140 batadv_dat_entry_put(dat_entry); 141 } 142 spin_unlock_bh(list_lock); 143 } 144 } 145 146 /** 147 * batadv_dat_purge - periodic task that deletes old entries from the local DAT 148 * hash table 149 * @work: kernel work struct 150 */ 151 static void batadv_dat_purge(struct work_struct *work) 152 { 153 struct delayed_work *delayed_work; 154 struct batadv_priv_dat *priv_dat; 155 struct batadv_priv *bat_priv; 156 157 delayed_work = to_delayed_work(work); 158 priv_dat = container_of(delayed_work, struct batadv_priv_dat, work); 159 bat_priv = container_of(priv_dat, struct batadv_priv, dat); 160 161 __batadv_dat_purge(bat_priv, batadv_dat_to_purge); 162 batadv_dat_start_timer(bat_priv); 163 } 164 165 /** 166 * batadv_compare_dat - comparing function used in the local DAT hash table 167 * @node: node in the local table 168 * @data2: second object to compare the node to 169 * 170 * Return: true if the two entries are the same, false otherwise. 171 */ 172 static bool batadv_compare_dat(const struct hlist_node *node, const void *data2) 173 { 174 const void *data1 = container_of(node, struct batadv_dat_entry, 175 hash_entry); 176 177 return memcmp(data1, data2, sizeof(__be32)) == 0; 178 } 179 180 /** 181 * batadv_arp_hw_src - extract the hw_src field from an ARP packet 182 * @skb: ARP packet 183 * @hdr_size: size of the possible header before the ARP packet 184 * 185 * Return: the value of the hw_src field in the ARP packet. 186 */ 187 static u8 *batadv_arp_hw_src(struct sk_buff *skb, int hdr_size) 188 { 189 u8 *addr; 190 191 addr = (u8 *)(skb->data + hdr_size); 192 addr += ETH_HLEN + sizeof(struct arphdr); 193 194 return addr; 195 } 196 197 /** 198 * batadv_arp_ip_src - extract the ip_src field from an ARP packet 199 * @skb: ARP packet 200 * @hdr_size: size of the possible header before the ARP packet 201 * 202 * Return: the value of the ip_src field in the ARP packet. 203 */ 204 static __be32 batadv_arp_ip_src(struct sk_buff *skb, int hdr_size) 205 { 206 return *(__be32 *)(batadv_arp_hw_src(skb, hdr_size) + ETH_ALEN); 207 } 208 209 /** 210 * batadv_arp_hw_dst - extract the hw_dst field from an ARP packet 211 * @skb: ARP packet 212 * @hdr_size: size of the possible header before the ARP packet 213 * 214 * Return: the value of the hw_dst field in the ARP packet. 215 */ 216 static u8 *batadv_arp_hw_dst(struct sk_buff *skb, int hdr_size) 217 { 218 return batadv_arp_hw_src(skb, hdr_size) + ETH_ALEN + 4; 219 } 220 221 /** 222 * batadv_arp_ip_dst - extract the ip_dst field from an ARP packet 223 * @skb: ARP packet 224 * @hdr_size: size of the possible header before the ARP packet 225 * 226 * Return: the value of the ip_dst field in the ARP packet. 227 */ 228 static __be32 batadv_arp_ip_dst(struct sk_buff *skb, int hdr_size) 229 { 230 return *(__be32 *)(batadv_arp_hw_src(skb, hdr_size) + ETH_ALEN * 2 + 4); 231 } 232 233 /** 234 * batadv_hash_dat - compute the hash value for an IP address 235 * @data: data to hash 236 * @size: size of the hash table 237 * 238 * Return: the selected index in the hash table for the given data. 239 */ 240 static u32 batadv_hash_dat(const void *data, u32 size) 241 { 242 u32 hash = 0; 243 const struct batadv_dat_entry *dat = data; 244 const unsigned char *key; 245 u32 i; 246 247 key = (const unsigned char *)&dat->ip; 248 for (i = 0; i < sizeof(dat->ip); i++) { 249 hash += key[i]; 250 hash += (hash << 10); 251 hash ^= (hash >> 6); 252 } 253 254 key = (const unsigned char *)&dat->vid; 255 for (i = 0; i < sizeof(dat->vid); i++) { 256 hash += key[i]; 257 hash += (hash << 10); 258 hash ^= (hash >> 6); 259 } 260 261 hash += (hash << 3); 262 hash ^= (hash >> 11); 263 hash += (hash << 15); 264 265 return hash % size; 266 } 267 268 /** 269 * batadv_dat_entry_hash_find - look for a given dat_entry in the local hash 270 * table 271 * @bat_priv: the bat priv with all the soft interface information 272 * @ip: search key 273 * @vid: VLAN identifier 274 * 275 * Return: the dat_entry if found, NULL otherwise. 276 */ 277 static struct batadv_dat_entry * 278 batadv_dat_entry_hash_find(struct batadv_priv *bat_priv, __be32 ip, 279 unsigned short vid) 280 { 281 struct hlist_head *head; 282 struct batadv_dat_entry to_find, *dat_entry, *dat_entry_tmp = NULL; 283 struct batadv_hashtable *hash = bat_priv->dat.hash; 284 u32 index; 285 286 if (!hash) 287 return NULL; 288 289 to_find.ip = ip; 290 to_find.vid = vid; 291 292 index = batadv_hash_dat(&to_find, hash->size); 293 head = &hash->table[index]; 294 295 rcu_read_lock(); 296 hlist_for_each_entry_rcu(dat_entry, head, hash_entry) { 297 if (dat_entry->ip != ip) 298 continue; 299 300 if (!kref_get_unless_zero(&dat_entry->refcount)) 301 continue; 302 303 dat_entry_tmp = dat_entry; 304 break; 305 } 306 rcu_read_unlock(); 307 308 return dat_entry_tmp; 309 } 310 311 /** 312 * batadv_dat_entry_add - add a new dat entry or update it if already exists 313 * @bat_priv: the bat priv with all the soft interface information 314 * @ip: ipv4 to add/edit 315 * @mac_addr: mac address to assign to the given ipv4 316 * @vid: VLAN identifier 317 */ 318 static void batadv_dat_entry_add(struct batadv_priv *bat_priv, __be32 ip, 319 u8 *mac_addr, unsigned short vid) 320 { 321 struct batadv_dat_entry *dat_entry; 322 int hash_added; 323 324 dat_entry = batadv_dat_entry_hash_find(bat_priv, ip, vid); 325 /* if this entry is already known, just update it */ 326 if (dat_entry) { 327 if (!batadv_compare_eth(dat_entry->mac_addr, mac_addr)) 328 ether_addr_copy(dat_entry->mac_addr, mac_addr); 329 dat_entry->last_update = jiffies; 330 batadv_dbg(BATADV_DBG_DAT, bat_priv, 331 "Entry updated: %pI4 %pM (vid: %d)\n", 332 &dat_entry->ip, dat_entry->mac_addr, 333 BATADV_PRINT_VID(vid)); 334 goto out; 335 } 336 337 dat_entry = kmalloc(sizeof(*dat_entry), GFP_ATOMIC); 338 if (!dat_entry) 339 goto out; 340 341 dat_entry->ip = ip; 342 dat_entry->vid = vid; 343 ether_addr_copy(dat_entry->mac_addr, mac_addr); 344 dat_entry->last_update = jiffies; 345 kref_init(&dat_entry->refcount); 346 347 kref_get(&dat_entry->refcount); 348 hash_added = batadv_hash_add(bat_priv->dat.hash, batadv_compare_dat, 349 batadv_hash_dat, dat_entry, 350 &dat_entry->hash_entry); 351 352 if (unlikely(hash_added != 0)) { 353 /* remove the reference for the hash */ 354 batadv_dat_entry_put(dat_entry); 355 goto out; 356 } 357 358 batadv_dbg(BATADV_DBG_DAT, bat_priv, "New entry added: %pI4 %pM (vid: %d)\n", 359 &dat_entry->ip, dat_entry->mac_addr, BATADV_PRINT_VID(vid)); 360 361 out: 362 if (dat_entry) 363 batadv_dat_entry_put(dat_entry); 364 } 365 366 #ifdef CONFIG_BATMAN_ADV_DEBUG 367 368 /** 369 * batadv_dbg_arp - print a debug message containing all the ARP packet details 370 * @bat_priv: the bat priv with all the soft interface information 371 * @skb: ARP packet 372 * @hdr_size: size of the possible header before the ARP packet 373 * @msg: message to print together with the debugging information 374 */ 375 static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb, 376 int hdr_size, char *msg) 377 { 378 struct batadv_unicast_4addr_packet *unicast_4addr_packet; 379 struct batadv_bcast_packet *bcast_pkt; 380 u8 *orig_addr; 381 __be32 ip_src, ip_dst; 382 383 if (msg) 384 batadv_dbg(BATADV_DBG_DAT, bat_priv, "%s\n", msg); 385 386 ip_src = batadv_arp_ip_src(skb, hdr_size); 387 ip_dst = batadv_arp_ip_dst(skb, hdr_size); 388 batadv_dbg(BATADV_DBG_DAT, bat_priv, 389 "ARP MSG = [src: %pM-%pI4 dst: %pM-%pI4]\n", 390 batadv_arp_hw_src(skb, hdr_size), &ip_src, 391 batadv_arp_hw_dst(skb, hdr_size), &ip_dst); 392 393 if (hdr_size == 0) 394 return; 395 396 unicast_4addr_packet = (struct batadv_unicast_4addr_packet *)skb->data; 397 398 switch (unicast_4addr_packet->u.packet_type) { 399 case BATADV_UNICAST: 400 batadv_dbg(BATADV_DBG_DAT, bat_priv, 401 "* encapsulated within a UNICAST packet\n"); 402 break; 403 case BATADV_UNICAST_4ADDR: 404 batadv_dbg(BATADV_DBG_DAT, bat_priv, 405 "* encapsulated within a UNICAST_4ADDR packet (src: %pM)\n", 406 unicast_4addr_packet->src); 407 switch (unicast_4addr_packet->subtype) { 408 case BATADV_P_DAT_DHT_PUT: 409 batadv_dbg(BATADV_DBG_DAT, bat_priv, "* type: DAT_DHT_PUT\n"); 410 break; 411 case BATADV_P_DAT_DHT_GET: 412 batadv_dbg(BATADV_DBG_DAT, bat_priv, "* type: DAT_DHT_GET\n"); 413 break; 414 case BATADV_P_DAT_CACHE_REPLY: 415 batadv_dbg(BATADV_DBG_DAT, bat_priv, 416 "* type: DAT_CACHE_REPLY\n"); 417 break; 418 case BATADV_P_DATA: 419 batadv_dbg(BATADV_DBG_DAT, bat_priv, "* type: DATA\n"); 420 break; 421 default: 422 batadv_dbg(BATADV_DBG_DAT, bat_priv, "* type: Unknown (%u)!\n", 423 unicast_4addr_packet->u.packet_type); 424 } 425 break; 426 case BATADV_BCAST: 427 bcast_pkt = (struct batadv_bcast_packet *)unicast_4addr_packet; 428 orig_addr = bcast_pkt->orig; 429 batadv_dbg(BATADV_DBG_DAT, bat_priv, 430 "* encapsulated within a BCAST packet (src: %pM)\n", 431 orig_addr); 432 break; 433 default: 434 batadv_dbg(BATADV_DBG_DAT, bat_priv, 435 "* encapsulated within an unknown packet type (0x%x)\n", 436 unicast_4addr_packet->u.packet_type); 437 } 438 } 439 440 #else 441 442 static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb, 443 int hdr_size, char *msg) 444 { 445 } 446 447 #endif /* CONFIG_BATMAN_ADV_DEBUG */ 448 449 /** 450 * batadv_is_orig_node_eligible - check whether a node can be a DHT candidate 451 * @res: the array with the already selected candidates 452 * @select: number of already selected candidates 453 * @tmp_max: address of the currently evaluated node 454 * @max: current round max address 455 * @last_max: address of the last selected candidate 456 * @candidate: orig_node under evaluation 457 * @max_orig_node: last selected candidate 458 * 459 * Return: true if the node has been elected as next candidate or false 460 * otherwise. 461 */ 462 static bool batadv_is_orig_node_eligible(struct batadv_dat_candidate *res, 463 int select, batadv_dat_addr_t tmp_max, 464 batadv_dat_addr_t max, 465 batadv_dat_addr_t last_max, 466 struct batadv_orig_node *candidate, 467 struct batadv_orig_node *max_orig_node) 468 { 469 bool ret = false; 470 int j; 471 472 /* check if orig node candidate is running DAT */ 473 if (!test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities)) 474 goto out; 475 476 /* Check if this node has already been selected... */ 477 for (j = 0; j < select; j++) 478 if (res[j].orig_node == candidate) 479 break; 480 /* ..and possibly skip it */ 481 if (j < select) 482 goto out; 483 /* sanity check: has it already been selected? This should not happen */ 484 if (tmp_max > last_max) 485 goto out; 486 /* check if during this iteration an originator with a closer dht 487 * address has already been found 488 */ 489 if (tmp_max < max) 490 goto out; 491 /* this is an hash collision with the temporary selected node. Choose 492 * the one with the lowest address 493 */ 494 if ((tmp_max == max) && max_orig_node && 495 (batadv_compare_eth(candidate->orig, max_orig_node->orig) > 0)) 496 goto out; 497 498 ret = true; 499 out: 500 return ret; 501 } 502 503 /** 504 * batadv_choose_next_candidate - select the next DHT candidate 505 * @bat_priv: the bat priv with all the soft interface information 506 * @cands: candidates array 507 * @select: number of candidates already present in the array 508 * @ip_key: key to look up in the DHT 509 * @last_max: pointer where the address of the selected candidate will be saved 510 */ 511 static void batadv_choose_next_candidate(struct batadv_priv *bat_priv, 512 struct batadv_dat_candidate *cands, 513 int select, batadv_dat_addr_t ip_key, 514 batadv_dat_addr_t *last_max) 515 { 516 batadv_dat_addr_t max = 0; 517 batadv_dat_addr_t tmp_max = 0; 518 struct batadv_orig_node *orig_node, *max_orig_node = NULL; 519 struct batadv_hashtable *hash = bat_priv->orig_hash; 520 struct hlist_head *head; 521 int i; 522 523 /* if no node is eligible as candidate, leave the candidate type as 524 * NOT_FOUND 525 */ 526 cands[select].type = BATADV_DAT_CANDIDATE_NOT_FOUND; 527 528 /* iterate over the originator list and find the node with the closest 529 * dat_address which has not been selected yet 530 */ 531 for (i = 0; i < hash->size; i++) { 532 head = &hash->table[i]; 533 534 rcu_read_lock(); 535 hlist_for_each_entry_rcu(orig_node, head, hash_entry) { 536 /* the dht space is a ring using unsigned addresses */ 537 tmp_max = BATADV_DAT_ADDR_MAX - orig_node->dat_addr + 538 ip_key; 539 540 if (!batadv_is_orig_node_eligible(cands, select, 541 tmp_max, max, 542 *last_max, orig_node, 543 max_orig_node)) 544 continue; 545 546 if (!kref_get_unless_zero(&orig_node->refcount)) 547 continue; 548 549 max = tmp_max; 550 if (max_orig_node) 551 batadv_orig_node_put(max_orig_node); 552 max_orig_node = orig_node; 553 } 554 rcu_read_unlock(); 555 } 556 if (max_orig_node) { 557 cands[select].type = BATADV_DAT_CANDIDATE_ORIG; 558 cands[select].orig_node = max_orig_node; 559 batadv_dbg(BATADV_DBG_DAT, bat_priv, 560 "dat_select_candidates() %d: selected %pM addr=%u dist=%u\n", 561 select, max_orig_node->orig, max_orig_node->dat_addr, 562 max); 563 } 564 *last_max = max; 565 } 566 567 /** 568 * batadv_dat_select_candidates - select the nodes which the DHT message has to 569 * be sent to 570 * @bat_priv: the bat priv with all the soft interface information 571 * @ip_dst: ipv4 to look up in the DHT 572 * @vid: VLAN identifier 573 * 574 * An originator O is selected if and only if its DHT_ID value is one of three 575 * closest values (from the LEFT, with wrap around if needed) then the hash 576 * value of the key. ip_dst is the key. 577 * 578 * Return: the candidate array of size BATADV_DAT_CANDIDATE_NUM. 579 */ 580 static struct batadv_dat_candidate * 581 batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst, 582 unsigned short vid) 583 { 584 int select; 585 batadv_dat_addr_t last_max = BATADV_DAT_ADDR_MAX, ip_key; 586 struct batadv_dat_candidate *res; 587 struct batadv_dat_entry dat; 588 589 if (!bat_priv->orig_hash) 590 return NULL; 591 592 res = kmalloc_array(BATADV_DAT_CANDIDATES_NUM, sizeof(*res), 593 GFP_ATOMIC); 594 if (!res) 595 return NULL; 596 597 dat.ip = ip_dst; 598 dat.vid = vid; 599 ip_key = (batadv_dat_addr_t)batadv_hash_dat(&dat, 600 BATADV_DAT_ADDR_MAX); 601 602 batadv_dbg(BATADV_DBG_DAT, bat_priv, 603 "dat_select_candidates(): IP=%pI4 hash(IP)=%u\n", &ip_dst, 604 ip_key); 605 606 for (select = 0; select < BATADV_DAT_CANDIDATES_NUM; select++) 607 batadv_choose_next_candidate(bat_priv, res, select, ip_key, 608 &last_max); 609 610 return res; 611 } 612 613 /** 614 * batadv_dat_send_data - send a payload to the selected candidates 615 * @bat_priv: the bat priv with all the soft interface information 616 * @skb: payload to send 617 * @ip: the DHT key 618 * @vid: VLAN identifier 619 * @packet_subtype: unicast4addr packet subtype to use 620 * 621 * This function copies the skb with pskb_copy() and is sent as unicast packet 622 * to each of the selected candidates. 623 * 624 * Return: true if the packet is sent to at least one candidate, false 625 * otherwise. 626 */ 627 static bool batadv_dat_send_data(struct batadv_priv *bat_priv, 628 struct sk_buff *skb, __be32 ip, 629 unsigned short vid, int packet_subtype) 630 { 631 int i; 632 bool ret = false; 633 int send_status; 634 struct batadv_neigh_node *neigh_node = NULL; 635 struct sk_buff *tmp_skb; 636 struct batadv_dat_candidate *cand; 637 638 cand = batadv_dat_select_candidates(bat_priv, ip, vid); 639 if (!cand) 640 goto out; 641 642 batadv_dbg(BATADV_DBG_DAT, bat_priv, "DHT_SEND for %pI4\n", &ip); 643 644 for (i = 0; i < BATADV_DAT_CANDIDATES_NUM; i++) { 645 if (cand[i].type == BATADV_DAT_CANDIDATE_NOT_FOUND) 646 continue; 647 648 neigh_node = batadv_orig_router_get(cand[i].orig_node, 649 BATADV_IF_DEFAULT); 650 if (!neigh_node) 651 goto free_orig; 652 653 tmp_skb = pskb_copy_for_clone(skb, GFP_ATOMIC); 654 if (!batadv_send_skb_prepare_unicast_4addr(bat_priv, tmp_skb, 655 cand[i].orig_node, 656 packet_subtype)) { 657 kfree_skb(tmp_skb); 658 goto free_neigh; 659 } 660 661 send_status = batadv_send_unicast_skb(tmp_skb, neigh_node); 662 if (send_status == NET_XMIT_SUCCESS) { 663 /* count the sent packet */ 664 switch (packet_subtype) { 665 case BATADV_P_DAT_DHT_GET: 666 batadv_inc_counter(bat_priv, 667 BATADV_CNT_DAT_GET_TX); 668 break; 669 case BATADV_P_DAT_DHT_PUT: 670 batadv_inc_counter(bat_priv, 671 BATADV_CNT_DAT_PUT_TX); 672 break; 673 } 674 675 /* packet sent to a candidate: return true */ 676 ret = true; 677 } 678 free_neigh: 679 batadv_neigh_node_put(neigh_node); 680 free_orig: 681 batadv_orig_node_put(cand[i].orig_node); 682 } 683 684 out: 685 kfree(cand); 686 return ret; 687 } 688 689 /** 690 * batadv_dat_tvlv_container_update - update the dat tvlv container after dat 691 * setting change 692 * @bat_priv: the bat priv with all the soft interface information 693 */ 694 static void batadv_dat_tvlv_container_update(struct batadv_priv *bat_priv) 695 { 696 char dat_mode; 697 698 dat_mode = atomic_read(&bat_priv->distributed_arp_table); 699 700 switch (dat_mode) { 701 case 0: 702 batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_DAT, 1); 703 break; 704 case 1: 705 batadv_tvlv_container_register(bat_priv, BATADV_TVLV_DAT, 1, 706 NULL, 0); 707 break; 708 } 709 } 710 711 /** 712 * batadv_dat_status_update - update the dat tvlv container after dat 713 * setting change 714 * @net_dev: the soft interface net device 715 */ 716 void batadv_dat_status_update(struct net_device *net_dev) 717 { 718 struct batadv_priv *bat_priv = netdev_priv(net_dev); 719 720 batadv_dat_tvlv_container_update(bat_priv); 721 } 722 723 /** 724 * batadv_dat_tvlv_ogm_handler_v1 - process incoming dat tvlv container 725 * @bat_priv: the bat priv with all the soft interface information 726 * @orig: the orig_node of the ogm 727 * @flags: flags indicating the tvlv state (see batadv_tvlv_handler_flags) 728 * @tvlv_value: tvlv buffer containing the gateway data 729 * @tvlv_value_len: tvlv buffer length 730 */ 731 static void batadv_dat_tvlv_ogm_handler_v1(struct batadv_priv *bat_priv, 732 struct batadv_orig_node *orig, 733 u8 flags, 734 void *tvlv_value, u16 tvlv_value_len) 735 { 736 if (flags & BATADV_TVLV_HANDLER_OGM_CIFNOTFND) 737 clear_bit(BATADV_ORIG_CAPA_HAS_DAT, &orig->capabilities); 738 else 739 set_bit(BATADV_ORIG_CAPA_HAS_DAT, &orig->capabilities); 740 } 741 742 /** 743 * batadv_dat_hash_free - free the local DAT hash table 744 * @bat_priv: the bat priv with all the soft interface information 745 */ 746 static void batadv_dat_hash_free(struct batadv_priv *bat_priv) 747 { 748 if (!bat_priv->dat.hash) 749 return; 750 751 __batadv_dat_purge(bat_priv, NULL); 752 753 batadv_hash_destroy(bat_priv->dat.hash); 754 755 bat_priv->dat.hash = NULL; 756 } 757 758 /** 759 * batadv_dat_init - initialise the DAT internals 760 * @bat_priv: the bat priv with all the soft interface information 761 * 762 * Return: 0 in case of success, a negative error code otherwise 763 */ 764 int batadv_dat_init(struct batadv_priv *bat_priv) 765 { 766 if (bat_priv->dat.hash) 767 return 0; 768 769 bat_priv->dat.hash = batadv_hash_new(1024); 770 771 if (!bat_priv->dat.hash) 772 return -ENOMEM; 773 774 batadv_dat_start_timer(bat_priv); 775 776 batadv_tvlv_handler_register(bat_priv, batadv_dat_tvlv_ogm_handler_v1, 777 NULL, BATADV_TVLV_DAT, 1, 778 BATADV_TVLV_HANDLER_OGM_CIFNOTFND); 779 batadv_dat_tvlv_container_update(bat_priv); 780 return 0; 781 } 782 783 /** 784 * batadv_dat_free - free the DAT internals 785 * @bat_priv: the bat priv with all the soft interface information 786 */ 787 void batadv_dat_free(struct batadv_priv *bat_priv) 788 { 789 batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_DAT, 1); 790 batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_DAT, 1); 791 792 cancel_delayed_work_sync(&bat_priv->dat.work); 793 794 batadv_dat_hash_free(bat_priv); 795 } 796 797 #ifdef CONFIG_BATMAN_ADV_DEBUGFS 798 /** 799 * batadv_dat_cache_seq_print_text - print the local DAT hash table 800 * @seq: seq file to print on 801 * @offset: not used 802 * 803 * Return: always 0 804 */ 805 int batadv_dat_cache_seq_print_text(struct seq_file *seq, void *offset) 806 { 807 struct net_device *net_dev = (struct net_device *)seq->private; 808 struct batadv_priv *bat_priv = netdev_priv(net_dev); 809 struct batadv_hashtable *hash = bat_priv->dat.hash; 810 struct batadv_dat_entry *dat_entry; 811 struct batadv_hard_iface *primary_if; 812 struct hlist_head *head; 813 unsigned long last_seen_jiffies; 814 int last_seen_msecs, last_seen_secs, last_seen_mins; 815 u32 i; 816 817 primary_if = batadv_seq_print_text_primary_if_get(seq); 818 if (!primary_if) 819 goto out; 820 821 seq_printf(seq, "Distributed ARP Table (%s):\n", net_dev->name); 822 seq_puts(seq, 823 " IPv4 MAC VID last-seen\n"); 824 825 for (i = 0; i < hash->size; i++) { 826 head = &hash->table[i]; 827 828 rcu_read_lock(); 829 hlist_for_each_entry_rcu(dat_entry, head, hash_entry) { 830 last_seen_jiffies = jiffies - dat_entry->last_update; 831 last_seen_msecs = jiffies_to_msecs(last_seen_jiffies); 832 last_seen_mins = last_seen_msecs / 60000; 833 last_seen_msecs = last_seen_msecs % 60000; 834 last_seen_secs = last_seen_msecs / 1000; 835 836 seq_printf(seq, " * %15pI4 %14pM %4i %6i:%02i\n", 837 &dat_entry->ip, dat_entry->mac_addr, 838 BATADV_PRINT_VID(dat_entry->vid), 839 last_seen_mins, last_seen_secs); 840 } 841 rcu_read_unlock(); 842 } 843 844 out: 845 if (primary_if) 846 batadv_hardif_put(primary_if); 847 return 0; 848 } 849 #endif 850 851 /** 852 * batadv_arp_get_type - parse an ARP packet and gets the type 853 * @bat_priv: the bat priv with all the soft interface information 854 * @skb: packet to analyse 855 * @hdr_size: size of the possible header before the ARP packet in the skb 856 * 857 * Return: the ARP type if the skb contains a valid ARP packet, 0 otherwise. 858 */ 859 static u16 batadv_arp_get_type(struct batadv_priv *bat_priv, 860 struct sk_buff *skb, int hdr_size) 861 { 862 struct arphdr *arphdr; 863 struct ethhdr *ethhdr; 864 __be32 ip_src, ip_dst; 865 u8 *hw_src, *hw_dst; 866 u16 type = 0; 867 868 /* pull the ethernet header */ 869 if (unlikely(!pskb_may_pull(skb, hdr_size + ETH_HLEN))) 870 goto out; 871 872 ethhdr = (struct ethhdr *)(skb->data + hdr_size); 873 874 if (ethhdr->h_proto != htons(ETH_P_ARP)) 875 goto out; 876 877 /* pull the ARP payload */ 878 if (unlikely(!pskb_may_pull(skb, hdr_size + ETH_HLEN + 879 arp_hdr_len(skb->dev)))) 880 goto out; 881 882 arphdr = (struct arphdr *)(skb->data + hdr_size + ETH_HLEN); 883 884 /* check whether the ARP packet carries a valid IP information */ 885 if (arphdr->ar_hrd != htons(ARPHRD_ETHER)) 886 goto out; 887 888 if (arphdr->ar_pro != htons(ETH_P_IP)) 889 goto out; 890 891 if (arphdr->ar_hln != ETH_ALEN) 892 goto out; 893 894 if (arphdr->ar_pln != 4) 895 goto out; 896 897 /* Check for bad reply/request. If the ARP message is not sane, DAT 898 * will simply ignore it 899 */ 900 ip_src = batadv_arp_ip_src(skb, hdr_size); 901 ip_dst = batadv_arp_ip_dst(skb, hdr_size); 902 if (ipv4_is_loopback(ip_src) || ipv4_is_multicast(ip_src) || 903 ipv4_is_loopback(ip_dst) || ipv4_is_multicast(ip_dst) || 904 ipv4_is_zeronet(ip_src) || ipv4_is_lbcast(ip_src) || 905 ipv4_is_zeronet(ip_dst) || ipv4_is_lbcast(ip_dst)) 906 goto out; 907 908 hw_src = batadv_arp_hw_src(skb, hdr_size); 909 if (is_zero_ether_addr(hw_src) || is_multicast_ether_addr(hw_src)) 910 goto out; 911 912 /* don't care about the destination MAC address in ARP requests */ 913 if (arphdr->ar_op != htons(ARPOP_REQUEST)) { 914 hw_dst = batadv_arp_hw_dst(skb, hdr_size); 915 if (is_zero_ether_addr(hw_dst) || 916 is_multicast_ether_addr(hw_dst)) 917 goto out; 918 } 919 920 type = ntohs(arphdr->ar_op); 921 out: 922 return type; 923 } 924 925 /** 926 * batadv_dat_get_vid - extract the VLAN identifier from skb if any 927 * @skb: the buffer containing the packet to extract the VID from 928 * @hdr_size: the size of the batman-adv header encapsulating the packet 929 * 930 * Return: If the packet embedded in the skb is vlan tagged this function 931 * returns the VID with the BATADV_VLAN_HAS_TAG flag. Otherwise BATADV_NO_FLAGS 932 * is returned. 933 */ 934 static unsigned short batadv_dat_get_vid(struct sk_buff *skb, int *hdr_size) 935 { 936 unsigned short vid; 937 938 vid = batadv_get_vid(skb, *hdr_size); 939 940 /* ARP parsing functions jump forward of hdr_size + ETH_HLEN. 941 * If the header contained in the packet is a VLAN one (which is longer) 942 * hdr_size is updated so that the functions will still skip the 943 * correct amount of bytes. 944 */ 945 if (vid & BATADV_VLAN_HAS_TAG) 946 *hdr_size += VLAN_HLEN; 947 948 return vid; 949 } 950 951 /** 952 * batadv_dat_arp_create_reply - create an ARP Reply 953 * @bat_priv: the bat priv with all the soft interface information 954 * @ip_src: ARP sender IP 955 * @ip_dst: ARP target IP 956 * @hw_src: Ethernet source and ARP sender MAC 957 * @hw_dst: Ethernet destination and ARP target MAC 958 * @vid: VLAN identifier (optional, set to zero otherwise) 959 * 960 * Creates an ARP Reply from the given values, optionally encapsulated in a 961 * VLAN header. 962 * 963 * Return: An skb containing an ARP Reply. 964 */ 965 static struct sk_buff * 966 batadv_dat_arp_create_reply(struct batadv_priv *bat_priv, __be32 ip_src, 967 __be32 ip_dst, u8 *hw_src, u8 *hw_dst, 968 unsigned short vid) 969 { 970 struct sk_buff *skb; 971 972 skb = arp_create(ARPOP_REPLY, ETH_P_ARP, ip_dst, bat_priv->soft_iface, 973 ip_src, hw_dst, hw_src, hw_dst); 974 if (!skb) 975 return NULL; 976 977 skb_reset_mac_header(skb); 978 979 if (vid & BATADV_VLAN_HAS_TAG) 980 skb = vlan_insert_tag(skb, htons(ETH_P_8021Q), 981 vid & VLAN_VID_MASK); 982 983 return skb; 984 } 985 986 /** 987 * batadv_dat_snoop_outgoing_arp_request - snoop the ARP request and try to 988 * answer using DAT 989 * @bat_priv: the bat priv with all the soft interface information 990 * @skb: packet to check 991 * 992 * Return: true if the message has been sent to the dht candidates, false 993 * otherwise. In case of a positive return value the message has to be enqueued 994 * to permit the fallback. 995 */ 996 bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, 997 struct sk_buff *skb) 998 { 999 u16 type = 0; 1000 __be32 ip_dst, ip_src; 1001 u8 *hw_src; 1002 bool ret = false; 1003 struct batadv_dat_entry *dat_entry = NULL; 1004 struct sk_buff *skb_new; 1005 int hdr_size = 0; 1006 unsigned short vid; 1007 1008 if (!atomic_read(&bat_priv->distributed_arp_table)) 1009 goto out; 1010 1011 vid = batadv_dat_get_vid(skb, &hdr_size); 1012 1013 type = batadv_arp_get_type(bat_priv, skb, hdr_size); 1014 /* If the node gets an ARP_REQUEST it has to send a DHT_GET unicast 1015 * message to the selected DHT candidates 1016 */ 1017 if (type != ARPOP_REQUEST) 1018 goto out; 1019 1020 batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing outgoing ARP REQUEST"); 1021 1022 ip_src = batadv_arp_ip_src(skb, hdr_size); 1023 hw_src = batadv_arp_hw_src(skb, hdr_size); 1024 ip_dst = batadv_arp_ip_dst(skb, hdr_size); 1025 1026 batadv_dat_entry_add(bat_priv, ip_src, hw_src, vid); 1027 1028 dat_entry = batadv_dat_entry_hash_find(bat_priv, ip_dst, vid); 1029 if (dat_entry) { 1030 /* If the ARP request is destined for a local client the local 1031 * client will answer itself. DAT would only generate a 1032 * duplicate packet. 1033 * 1034 * Moreover, if the soft-interface is enslaved into a bridge, an 1035 * additional DAT answer may trigger kernel warnings about 1036 * a packet coming from the wrong port. 1037 */ 1038 if (batadv_is_my_client(bat_priv, dat_entry->mac_addr, vid)) { 1039 ret = true; 1040 goto out; 1041 } 1042 1043 skb_new = batadv_dat_arp_create_reply(bat_priv, ip_dst, ip_src, 1044 dat_entry->mac_addr, 1045 hw_src, vid); 1046 if (!skb_new) 1047 goto out; 1048 1049 skb_new->protocol = eth_type_trans(skb_new, 1050 bat_priv->soft_iface); 1051 bat_priv->stats.rx_packets++; 1052 bat_priv->stats.rx_bytes += skb->len + ETH_HLEN + hdr_size; 1053 1054 netif_rx(skb_new); 1055 batadv_dbg(BATADV_DBG_DAT, bat_priv, "ARP request replied locally\n"); 1056 ret = true; 1057 } else { 1058 /* Send the request to the DHT */ 1059 ret = batadv_dat_send_data(bat_priv, skb, ip_dst, vid, 1060 BATADV_P_DAT_DHT_GET); 1061 } 1062 out: 1063 if (dat_entry) 1064 batadv_dat_entry_put(dat_entry); 1065 return ret; 1066 } 1067 1068 /** 1069 * batadv_dat_snoop_incoming_arp_request - snoop the ARP request and try to 1070 * answer using the local DAT storage 1071 * @bat_priv: the bat priv with all the soft interface information 1072 * @skb: packet to check 1073 * @hdr_size: size of the encapsulation header 1074 * 1075 * Return: true if the request has been answered, false otherwise. 1076 */ 1077 bool batadv_dat_snoop_incoming_arp_request(struct batadv_priv *bat_priv, 1078 struct sk_buff *skb, int hdr_size) 1079 { 1080 u16 type; 1081 __be32 ip_src, ip_dst; 1082 u8 *hw_src; 1083 struct sk_buff *skb_new; 1084 struct batadv_dat_entry *dat_entry = NULL; 1085 bool ret = false; 1086 unsigned short vid; 1087 int err; 1088 1089 if (!atomic_read(&bat_priv->distributed_arp_table)) 1090 goto out; 1091 1092 vid = batadv_dat_get_vid(skb, &hdr_size); 1093 1094 type = batadv_arp_get_type(bat_priv, skb, hdr_size); 1095 if (type != ARPOP_REQUEST) 1096 goto out; 1097 1098 hw_src = batadv_arp_hw_src(skb, hdr_size); 1099 ip_src = batadv_arp_ip_src(skb, hdr_size); 1100 ip_dst = batadv_arp_ip_dst(skb, hdr_size); 1101 1102 batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing incoming ARP REQUEST"); 1103 1104 batadv_dat_entry_add(bat_priv, ip_src, hw_src, vid); 1105 1106 dat_entry = batadv_dat_entry_hash_find(bat_priv, ip_dst, vid); 1107 if (!dat_entry) 1108 goto out; 1109 1110 skb_new = batadv_dat_arp_create_reply(bat_priv, ip_dst, ip_src, 1111 dat_entry->mac_addr, hw_src, vid); 1112 if (!skb_new) 1113 goto out; 1114 1115 /* To preserve backwards compatibility, the node has choose the outgoing 1116 * format based on the incoming request packet type. The assumption is 1117 * that a node not using the 4addr packet format doesn't support it. 1118 */ 1119 if (hdr_size == sizeof(struct batadv_unicast_4addr_packet)) 1120 err = batadv_send_skb_via_tt_4addr(bat_priv, skb_new, 1121 BATADV_P_DAT_CACHE_REPLY, 1122 NULL, vid); 1123 else 1124 err = batadv_send_skb_via_tt(bat_priv, skb_new, NULL, vid); 1125 1126 if (err != NET_XMIT_DROP) { 1127 batadv_inc_counter(bat_priv, BATADV_CNT_DAT_CACHED_REPLY_TX); 1128 ret = true; 1129 } 1130 out: 1131 if (dat_entry) 1132 batadv_dat_entry_put(dat_entry); 1133 if (ret) 1134 kfree_skb(skb); 1135 return ret; 1136 } 1137 1138 /** 1139 * batadv_dat_snoop_outgoing_arp_reply - snoop the ARP reply and fill the DHT 1140 * @bat_priv: the bat priv with all the soft interface information 1141 * @skb: packet to check 1142 */ 1143 void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv, 1144 struct sk_buff *skb) 1145 { 1146 u16 type; 1147 __be32 ip_src, ip_dst; 1148 u8 *hw_src, *hw_dst; 1149 int hdr_size = 0; 1150 unsigned short vid; 1151 1152 if (!atomic_read(&bat_priv->distributed_arp_table)) 1153 return; 1154 1155 vid = batadv_dat_get_vid(skb, &hdr_size); 1156 1157 type = batadv_arp_get_type(bat_priv, skb, hdr_size); 1158 if (type != ARPOP_REPLY) 1159 return; 1160 1161 batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing outgoing ARP REPLY"); 1162 1163 hw_src = batadv_arp_hw_src(skb, hdr_size); 1164 ip_src = batadv_arp_ip_src(skb, hdr_size); 1165 hw_dst = batadv_arp_hw_dst(skb, hdr_size); 1166 ip_dst = batadv_arp_ip_dst(skb, hdr_size); 1167 1168 batadv_dat_entry_add(bat_priv, ip_src, hw_src, vid); 1169 batadv_dat_entry_add(bat_priv, ip_dst, hw_dst, vid); 1170 1171 /* Send the ARP reply to the candidates for both the IP addresses that 1172 * the node obtained from the ARP reply 1173 */ 1174 batadv_dat_send_data(bat_priv, skb, ip_src, vid, BATADV_P_DAT_DHT_PUT); 1175 batadv_dat_send_data(bat_priv, skb, ip_dst, vid, BATADV_P_DAT_DHT_PUT); 1176 } 1177 1178 /** 1179 * batadv_dat_snoop_incoming_arp_reply - snoop the ARP reply and fill the local 1180 * DAT storage only 1181 * @bat_priv: the bat priv with all the soft interface information 1182 * @skb: packet to check 1183 * @hdr_size: size of the encapsulation header 1184 * 1185 * Return: true if the packet was snooped and consumed by DAT. False if the 1186 * packet has to be delivered to the interface 1187 */ 1188 bool batadv_dat_snoop_incoming_arp_reply(struct batadv_priv *bat_priv, 1189 struct sk_buff *skb, int hdr_size) 1190 { 1191 u16 type; 1192 __be32 ip_src, ip_dst; 1193 u8 *hw_src, *hw_dst; 1194 bool dropped = false; 1195 unsigned short vid; 1196 1197 if (!atomic_read(&bat_priv->distributed_arp_table)) 1198 goto out; 1199 1200 vid = batadv_dat_get_vid(skb, &hdr_size); 1201 1202 type = batadv_arp_get_type(bat_priv, skb, hdr_size); 1203 if (type != ARPOP_REPLY) 1204 goto out; 1205 1206 batadv_dbg_arp(bat_priv, skb, hdr_size, "Parsing incoming ARP REPLY"); 1207 1208 hw_src = batadv_arp_hw_src(skb, hdr_size); 1209 ip_src = batadv_arp_ip_src(skb, hdr_size); 1210 hw_dst = batadv_arp_hw_dst(skb, hdr_size); 1211 ip_dst = batadv_arp_ip_dst(skb, hdr_size); 1212 1213 /* Update our internal cache with both the IP addresses the node got 1214 * within the ARP reply 1215 */ 1216 batadv_dat_entry_add(bat_priv, ip_src, hw_src, vid); 1217 batadv_dat_entry_add(bat_priv, ip_dst, hw_dst, vid); 1218 1219 /* if this REPLY is directed to a client of mine, let's deliver the 1220 * packet to the interface 1221 */ 1222 dropped = !batadv_is_my_client(bat_priv, hw_dst, vid); 1223 1224 /* if this REPLY is sent on behalf of a client of mine, let's drop the 1225 * packet because the client will reply by itself 1226 */ 1227 dropped |= batadv_is_my_client(bat_priv, hw_src, vid); 1228 out: 1229 if (dropped) 1230 kfree_skb(skb); 1231 /* if dropped == false -> deliver to the interface */ 1232 return dropped; 1233 } 1234 1235 /** 1236 * batadv_dat_drop_broadcast_packet - check if an ARP request has to be dropped 1237 * (because the node has already obtained the reply via DAT) or not 1238 * @bat_priv: the bat priv with all the soft interface information 1239 * @forw_packet: the broadcast packet 1240 * 1241 * Return: true if the node can drop the packet, false otherwise. 1242 */ 1243 bool batadv_dat_drop_broadcast_packet(struct batadv_priv *bat_priv, 1244 struct batadv_forw_packet *forw_packet) 1245 { 1246 u16 type; 1247 __be32 ip_dst; 1248 struct batadv_dat_entry *dat_entry = NULL; 1249 bool ret = false; 1250 int hdr_size = sizeof(struct batadv_bcast_packet); 1251 unsigned short vid; 1252 1253 if (!atomic_read(&bat_priv->distributed_arp_table)) 1254 goto out; 1255 1256 /* If this packet is an ARP_REQUEST and the node already has the 1257 * information that it is going to ask, then the packet can be dropped 1258 */ 1259 if (forw_packet->num_packets) 1260 goto out; 1261 1262 vid = batadv_dat_get_vid(forw_packet->skb, &hdr_size); 1263 1264 type = batadv_arp_get_type(bat_priv, forw_packet->skb, hdr_size); 1265 if (type != ARPOP_REQUEST) 1266 goto out; 1267 1268 ip_dst = batadv_arp_ip_dst(forw_packet->skb, hdr_size); 1269 dat_entry = batadv_dat_entry_hash_find(bat_priv, ip_dst, vid); 1270 /* check if the node already got this entry */ 1271 if (!dat_entry) { 1272 batadv_dbg(BATADV_DBG_DAT, bat_priv, 1273 "ARP Request for %pI4: fallback\n", &ip_dst); 1274 goto out; 1275 } 1276 1277 batadv_dbg(BATADV_DBG_DAT, bat_priv, 1278 "ARP Request for %pI4: fallback prevented\n", &ip_dst); 1279 ret = true; 1280 1281 out: 1282 if (dat_entry) 1283 batadv_dat_entry_put(dat_entry); 1284 return ret; 1285 } 1286