xref: /openbmc/linux/fs/xfs/xfs_attr_inactive.c (revision 49813a21)
10b61f8a4SDave Chinner // SPDX-License-Identifier: GPL-2.0
2fde2227cSDave Chinner /*
3fde2227cSDave Chinner  * Copyright (c) 2000-2005 Silicon Graphics, Inc.
4fde2227cSDave Chinner  * Copyright (c) 2013 Red Hat, Inc.
5fde2227cSDave Chinner  * All Rights Reserved.
6fde2227cSDave Chinner  */
7fde2227cSDave Chinner #include "xfs.h"
8fde2227cSDave Chinner #include "xfs_fs.h"
970a9883cSDave Chinner #include "xfs_shared.h"
10239880efSDave Chinner #include "xfs_format.h"
11239880efSDave Chinner #include "xfs_log_format.h"
12239880efSDave Chinner #include "xfs_trans_resv.h"
13fde2227cSDave Chinner #include "xfs_bit.h"
14fde2227cSDave Chinner #include "xfs_mount.h"
1557062787SDave Chinner #include "xfs_da_format.h"
16fde2227cSDave Chinner #include "xfs_da_btree.h"
17fde2227cSDave Chinner #include "xfs_inode.h"
182b74b03cSAllison Henderson #include "xfs_attr.h"
19a4fbe6abSDave Chinner #include "xfs_attr_remote.h"
20239880efSDave Chinner #include "xfs_trans.h"
21fde2227cSDave Chinner #include "xfs_bmap.h"
22fde2227cSDave Chinner #include "xfs_attr_leaf.h"
23fde2227cSDave Chinner #include "xfs_quota.h"
244bceb18fSDave Chinner #include "xfs_dir2.h"
25a5155b87SDarrick J. Wong #include "xfs_error.h"
26fde2227cSDave Chinner 
27fde2227cSDave Chinner /*
28e8db2aafSDarrick J. Wong  * Invalidate any incore buffers associated with this remote attribute value
29e8db2aafSDarrick J. Wong  * extent.   We never log remote attribute value buffers, which means that they
30e8db2aafSDarrick J. Wong  * won't be attached to a transaction and are therefore safe to mark stale.
31e8db2aafSDarrick J. Wong  * The actual bunmapi will be taken care of later.
32fde2227cSDave Chinner  */
33fde2227cSDave Chinner STATIC int
xfs_attr3_rmt_stale(struct xfs_inode * dp,xfs_dablk_t blkno,int blkcnt)34e8db2aafSDarrick J. Wong xfs_attr3_rmt_stale(
35fde2227cSDave Chinner 	struct xfs_inode	*dp,
36fde2227cSDave Chinner 	xfs_dablk_t		blkno,
37fde2227cSDave Chinner 	int			blkcnt)
38fde2227cSDave Chinner {
39fde2227cSDave Chinner 	struct xfs_bmbt_irec	map;
40fde2227cSDave Chinner 	int			nmap;
41fde2227cSDave Chinner 	int			error;
42fde2227cSDave Chinner 
43fde2227cSDave Chinner 	/*
44fde2227cSDave Chinner 	 * Roll through the "value", invalidating the attribute value's
45fde2227cSDave Chinner 	 * blocks.
46fde2227cSDave Chinner 	 */
470bb9d159SDarrick J. Wong 	while (blkcnt > 0) {
48fde2227cSDave Chinner 		/*
49fde2227cSDave Chinner 		 * Try to remember where we decided to put the value.
50fde2227cSDave Chinner 		 */
51fde2227cSDave Chinner 		nmap = 1;
520bb9d159SDarrick J. Wong 		error = xfs_bmapi_read(dp, (xfs_fileoff_t)blkno, blkcnt,
53fde2227cSDave Chinner 				       &map, &nmap, XFS_BMAPI_ATTRFORK);
54fde2227cSDave Chinner 		if (error)
55d99831ffSEric Sandeen 			return error;
56e8db2aafSDarrick J. Wong 		if (XFS_IS_CORRUPT(dp->i_mount, nmap != 1))
57e8db2aafSDarrick J. Wong 			return -EFSCORRUPTED;
58e8db2aafSDarrick J. Wong 
59e8db2aafSDarrick J. Wong 		/*
60e8db2aafSDarrick J. Wong 		 * Mark any incore buffers for the remote value as stale.  We
61e8db2aafSDarrick J. Wong 		 * never log remote attr value buffers, so the buffer should be
62e8db2aafSDarrick J. Wong 		 * easy to kill.
63e8db2aafSDarrick J. Wong 		 */
64e8db2aafSDarrick J. Wong 		error = xfs_attr_rmtval_stale(dp, &map, 0);
65e8db2aafSDarrick J. Wong 		if (error)
66e8db2aafSDarrick J. Wong 			return error;
67fde2227cSDave Chinner 
680bb9d159SDarrick J. Wong 		blkno += map.br_blockcount;
690bb9d159SDarrick J. Wong 		blkcnt -= map.br_blockcount;
70fde2227cSDave Chinner 	}
71fde2227cSDave Chinner 
72d99831ffSEric Sandeen 	return 0;
73fde2227cSDave Chinner }
74fde2227cSDave Chinner 
75fde2227cSDave Chinner /*
76fde2227cSDave Chinner  * Invalidate all of the "remote" value regions pointed to by a particular
77fde2227cSDave Chinner  * leaf block.
78fde2227cSDave Chinner  * Note that we must release the lock on the buffer so that we are not
79fde2227cSDave Chinner  * caught holding something that the logging code wants to flush to disk.
80fde2227cSDave Chinner  */
81fde2227cSDave Chinner STATIC int
xfs_attr3_leaf_inactive(struct xfs_trans ** trans,struct xfs_inode * dp,struct xfs_buf * bp)82fde2227cSDave Chinner xfs_attr3_leaf_inactive(
83fde2227cSDave Chinner 	struct xfs_trans		**trans,
84fde2227cSDave Chinner 	struct xfs_inode		*dp,
85fde2227cSDave Chinner 	struct xfs_buf			*bp)
86fde2227cSDave Chinner {
87fde2227cSDave Chinner 	struct xfs_attr3_icleaf_hdr	ichdr;
880bb9d159SDarrick J. Wong 	struct xfs_mount		*mp = bp->b_mount;
890bb9d159SDarrick J. Wong 	struct xfs_attr_leafblock	*leaf = bp->b_addr;
90fde2227cSDave Chinner 	struct xfs_attr_leaf_entry	*entry;
91fde2227cSDave Chinner 	struct xfs_attr_leaf_name_remote *name_rmt;
9254027a49SDarrick J. Wong 	int				error = 0;
93fde2227cSDave Chinner 	int				i;
94fde2227cSDave Chinner 
952f661241SBrian Foster 	xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &ichdr, leaf);
96fde2227cSDave Chinner 
97fde2227cSDave Chinner 	/*
980bb9d159SDarrick J. Wong 	 * Find the remote value extents for this leaf and invalidate their
990bb9d159SDarrick J. Wong 	 * incore buffers.
100fde2227cSDave Chinner 	 */
101fde2227cSDave Chinner 	entry = xfs_attr3_leaf_entryp(leaf);
102fde2227cSDave Chinner 	for (i = 0; i < ichdr.count; entry++, i++) {
1030bb9d159SDarrick J. Wong 		int		blkcnt;
1040bb9d159SDarrick J. Wong 
1050bb9d159SDarrick J. Wong 		if (!entry->nameidx || (entry->flags & XFS_ATTR_LOCAL))
1060bb9d159SDarrick J. Wong 			continue;
1070bb9d159SDarrick J. Wong 
108fde2227cSDave Chinner 		name_rmt = xfs_attr3_leaf_name_remote(leaf, i);
1090bb9d159SDarrick J. Wong 		if (!name_rmt->valueblk)
1100bb9d159SDarrick J. Wong 			continue;
111fde2227cSDave Chinner 
1120bb9d159SDarrick J. Wong 		blkcnt = xfs_attr3_rmt_blocks(dp->i_mount,
113fde2227cSDave Chinner 				be32_to_cpu(name_rmt->valuelen));
1140bb9d159SDarrick J. Wong 		error = xfs_attr3_rmt_stale(dp,
1150bb9d159SDarrick J. Wong 				be32_to_cpu(name_rmt->valueblk), blkcnt);
1160bb9d159SDarrick J. Wong 		if (error)
1170bb9d159SDarrick J. Wong 			goto err;
118fde2227cSDave Chinner 	}
119fde2227cSDave Chinner 
1200bb9d159SDarrick J. Wong 	xfs_trans_brelse(*trans, bp);
1210bb9d159SDarrick J. Wong err:
122fde2227cSDave Chinner 	return error;
123fde2227cSDave Chinner }
124fde2227cSDave Chinner 
125fde2227cSDave Chinner /*
126fde2227cSDave Chinner  * Recurse (gasp!) through the attribute nodes until we find leaves.
127fde2227cSDave Chinner  * We're doing a depth-first traversal in order to invalidate everything.
128fde2227cSDave Chinner  */
129fde2227cSDave Chinner STATIC int
xfs_attr3_node_inactive(struct xfs_trans ** trans,struct xfs_inode * dp,struct xfs_buf * bp,int level)130fde2227cSDave Chinner xfs_attr3_node_inactive(
131fde2227cSDave Chinner 	struct xfs_trans	**trans,
132fde2227cSDave Chinner 	struct xfs_inode	*dp,
133fde2227cSDave Chinner 	struct xfs_buf		*bp,
134fde2227cSDave Chinner 	int			level)
135fde2227cSDave Chinner {
1362911edb6SChristoph Hellwig 	struct xfs_mount	*mp = dp->i_mount;
13751908ca7SChristoph Hellwig 	struct xfs_da_blkinfo	*info;
138fde2227cSDave Chinner 	xfs_dablk_t		child_fsb;
139fde2227cSDave Chinner 	xfs_daddr_t		parent_blkno, child_blkno;
140fde2227cSDave Chinner 	struct xfs_buf		*child_bp;
141fde2227cSDave Chinner 	struct xfs_da3_icnode_hdr ichdr;
14251908ca7SChristoph Hellwig 	int			error, i;
143fde2227cSDave Chinner 
144fde2227cSDave Chinner 	/*
145fde2227cSDave Chinner 	 * Since this code is recursive (gasp!) we must protect ourselves.
146fde2227cSDave Chinner 	 */
147fde2227cSDave Chinner 	if (level > XFS_DA_NODE_MAXDEPTH) {
1488d57c216SDarrick J. Wong 		xfs_buf_mark_corrupt(bp);
149496b9bcdSDarrick J. Wong 		xfs_trans_brelse(*trans, bp);	/* no locks for later trans */
150c2414ad6SDarrick J. Wong 		return -EFSCORRUPTED;
151fde2227cSDave Chinner 	}
152fde2227cSDave Chinner 
15351908ca7SChristoph Hellwig 	xfs_da3_node_hdr_from_disk(dp->i_mount, &ichdr, bp->b_addr);
1549343ee76SDave Chinner 	parent_blkno = xfs_buf_daddr(bp);
155fde2227cSDave Chinner 	if (!ichdr.count) {
156fde2227cSDave Chinner 		xfs_trans_brelse(*trans, bp);
157fde2227cSDave Chinner 		return 0;
158fde2227cSDave Chinner 	}
15951908ca7SChristoph Hellwig 	child_fsb = be32_to_cpu(ichdr.btree[0].before);
160fde2227cSDave Chinner 	xfs_trans_brelse(*trans, bp);	/* no locks for later trans */
161*95ff0363SDarrick J. Wong 	bp = NULL;
162fde2227cSDave Chinner 
163fde2227cSDave Chinner 	/*
164fde2227cSDave Chinner 	 * If this is the node level just above the leaves, simply loop
165fde2227cSDave Chinner 	 * over the leaves removing all of them.  If this is higher up
166fde2227cSDave Chinner 	 * in the tree, recurse downward.
167fde2227cSDave Chinner 	 */
168fde2227cSDave Chinner 	for (i = 0; i < ichdr.count; i++) {
169fde2227cSDave Chinner 		/*
170fde2227cSDave Chinner 		 * Read the subsidiary block to see what we have to work with.
171fde2227cSDave Chinner 		 * Don't do this in a transaction.  This is a depth-first
172fde2227cSDave Chinner 		 * traversal of the tree so we may deal with many blocks
173fde2227cSDave Chinner 		 * before we come back to this one.
174fde2227cSDave Chinner 		 */
17502c57f0aSChristoph Hellwig 		error = xfs_da3_node_read(*trans, dp, child_fsb, &child_bp,
176fde2227cSDave Chinner 					  XFS_ATTR_FORK);
177fde2227cSDave Chinner 		if (error)
178d99831ffSEric Sandeen 			return error;
179a53efbd5SBrian Foster 
180fde2227cSDave Chinner 		/* save for re-read later */
18104fcad80SDave Chinner 		child_blkno = xfs_buf_daddr(child_bp);
182fde2227cSDave Chinner 
183fde2227cSDave Chinner 		/*
184fde2227cSDave Chinner 		 * Invalidate the subtree, however we have to.
185fde2227cSDave Chinner 		 */
186fde2227cSDave Chinner 		info = child_bp->b_addr;
187fde2227cSDave Chinner 		switch (info->magic) {
188fde2227cSDave Chinner 		case cpu_to_be16(XFS_DA_NODE_MAGIC):
189fde2227cSDave Chinner 		case cpu_to_be16(XFS_DA3_NODE_MAGIC):
190a53efbd5SBrian Foster 			error = xfs_attr3_node_inactive(trans, dp, child_bp,
191a53efbd5SBrian Foster 							level + 1);
192fde2227cSDave Chinner 			break;
193fde2227cSDave Chinner 		case cpu_to_be16(XFS_ATTR_LEAF_MAGIC):
194fde2227cSDave Chinner 		case cpu_to_be16(XFS_ATTR3_LEAF_MAGIC):
195a53efbd5SBrian Foster 			error = xfs_attr3_leaf_inactive(trans, dp, child_bp);
196fde2227cSDave Chinner 			break;
197fde2227cSDave Chinner 		default:
1988d57c216SDarrick J. Wong 			xfs_buf_mark_corrupt(child_bp);
199fde2227cSDave Chinner 			xfs_trans_brelse(*trans, child_bp);
200a5155b87SDarrick J. Wong 			error = -EFSCORRUPTED;
201fde2227cSDave Chinner 			break;
202fde2227cSDave Chinner 		}
203fde2227cSDave Chinner 		if (error)
204fde2227cSDave Chinner 			return error;
205fde2227cSDave Chinner 
206fde2227cSDave Chinner 		/*
207a53efbd5SBrian Foster 		 * Remove the subsidiary block from the cache and from the log.
208fde2227cSDave Chinner 		 */
209ce92464cSDarrick J. Wong 		error = xfs_trans_get_buf(*trans, mp->m_ddev_targp,
2102911edb6SChristoph Hellwig 				child_blkno,
211ce92464cSDarrick J. Wong 				XFS_FSB_TO_BB(mp, mp->m_attr_geo->fsbcount), 0,
212ce92464cSDarrick J. Wong 				&child_bp);
213ce92464cSDarrick J. Wong 		if (error)
214ce92464cSDarrick J. Wong 			return error;
215fde2227cSDave Chinner 		xfs_trans_binval(*trans, child_bp);
216*95ff0363SDarrick J. Wong 		child_bp = NULL;
217fde2227cSDave Chinner 
218fde2227cSDave Chinner 		/*
219fde2227cSDave Chinner 		 * If we're not done, re-read the parent to get the next
220fde2227cSDave Chinner 		 * child block number.
221fde2227cSDave Chinner 		 */
222fde2227cSDave Chinner 		if (i + 1 < ichdr.count) {
22351908ca7SChristoph Hellwig 			struct xfs_da3_icnode_hdr phdr;
22451908ca7SChristoph Hellwig 
22502c57f0aSChristoph Hellwig 			error = xfs_da3_node_read_mapped(*trans, dp,
22602c57f0aSChristoph Hellwig 					parent_blkno, &bp, XFS_ATTR_FORK);
227fde2227cSDave Chinner 			if (error)
228fde2227cSDave Chinner 				return error;
22951908ca7SChristoph Hellwig 			xfs_da3_node_hdr_from_disk(dp->i_mount, &phdr,
23051908ca7SChristoph Hellwig 						  bp->b_addr);
23151908ca7SChristoph Hellwig 			child_fsb = be32_to_cpu(phdr.btree[i + 1].before);
232fde2227cSDave Chinner 			xfs_trans_brelse(*trans, bp);
233*95ff0363SDarrick J. Wong 			bp = NULL;
234fde2227cSDave Chinner 		}
235fde2227cSDave Chinner 		/*
236fde2227cSDave Chinner 		 * Atomically commit the whole invalidate stuff.
237fde2227cSDave Chinner 		 */
238411350dfSChristoph Hellwig 		error = xfs_trans_roll_inode(trans, dp);
239fde2227cSDave Chinner 		if (error)
240fde2227cSDave Chinner 			return  error;
241fde2227cSDave Chinner 	}
242fde2227cSDave Chinner 
243fde2227cSDave Chinner 	return 0;
244fde2227cSDave Chinner }
245fde2227cSDave Chinner 
246fde2227cSDave Chinner /*
247fde2227cSDave Chinner  * Indiscriminately delete the entire attribute fork
248fde2227cSDave Chinner  *
249fde2227cSDave Chinner  * Recurse (gasp!) through the attribute nodes until we find leaves.
250fde2227cSDave Chinner  * We're doing a depth-first traversal in order to invalidate everything.
251fde2227cSDave Chinner  */
2520d5a75e9SEric Sandeen static int
xfs_attr3_root_inactive(struct xfs_trans ** trans,struct xfs_inode * dp)253fde2227cSDave Chinner xfs_attr3_root_inactive(
254fde2227cSDave Chinner 	struct xfs_trans	**trans,
255fde2227cSDave Chinner 	struct xfs_inode	*dp)
256fde2227cSDave Chinner {
2572911edb6SChristoph Hellwig 	struct xfs_mount	*mp = dp->i_mount;
258fde2227cSDave Chinner 	struct xfs_da_blkinfo	*info;
259fde2227cSDave Chinner 	struct xfs_buf		*bp;
260fde2227cSDave Chinner 	xfs_daddr_t		blkno;
261fde2227cSDave Chinner 	int			error;
262fde2227cSDave Chinner 
263fde2227cSDave Chinner 	/*
264fde2227cSDave Chinner 	 * Read block 0 to see what we have to work with.
265fde2227cSDave Chinner 	 * We only get here if we have extents, since we remove
266fde2227cSDave Chinner 	 * the extents in reverse order the extent containing
267fde2227cSDave Chinner 	 * block 0 must still be there.
268fde2227cSDave Chinner 	 */
26902c57f0aSChristoph Hellwig 	error = xfs_da3_node_read(*trans, dp, 0, &bp, XFS_ATTR_FORK);
270fde2227cSDave Chinner 	if (error)
271fde2227cSDave Chinner 		return error;
2729343ee76SDave Chinner 	blkno = xfs_buf_daddr(bp);
273fde2227cSDave Chinner 
274fde2227cSDave Chinner 	/*
275fde2227cSDave Chinner 	 * Invalidate the tree, even if the "tree" is only a single leaf block.
276fde2227cSDave Chinner 	 * This is a depth-first traversal!
277fde2227cSDave Chinner 	 */
278fde2227cSDave Chinner 	info = bp->b_addr;
279fde2227cSDave Chinner 	switch (info->magic) {
280fde2227cSDave Chinner 	case cpu_to_be16(XFS_DA_NODE_MAGIC):
281fde2227cSDave Chinner 	case cpu_to_be16(XFS_DA3_NODE_MAGIC):
282fde2227cSDave Chinner 		error = xfs_attr3_node_inactive(trans, dp, bp, 1);
283fde2227cSDave Chinner 		break;
284fde2227cSDave Chinner 	case cpu_to_be16(XFS_ATTR_LEAF_MAGIC):
285fde2227cSDave Chinner 	case cpu_to_be16(XFS_ATTR3_LEAF_MAGIC):
286fde2227cSDave Chinner 		error = xfs_attr3_leaf_inactive(trans, dp, bp);
287fde2227cSDave Chinner 		break;
288fde2227cSDave Chinner 	default:
289c2414ad6SDarrick J. Wong 		error = -EFSCORRUPTED;
2908d57c216SDarrick J. Wong 		xfs_buf_mark_corrupt(bp);
291fde2227cSDave Chinner 		xfs_trans_brelse(*trans, bp);
292fde2227cSDave Chinner 		break;
293fde2227cSDave Chinner 	}
294fde2227cSDave Chinner 	if (error)
295fde2227cSDave Chinner 		return error;
296fde2227cSDave Chinner 
297fde2227cSDave Chinner 	/*
298fde2227cSDave Chinner 	 * Invalidate the incore copy of the root block.
299fde2227cSDave Chinner 	 */
300ce92464cSDarrick J. Wong 	error = xfs_trans_get_buf(*trans, mp->m_ddev_targp, blkno,
301ce92464cSDarrick J. Wong 			XFS_FSB_TO_BB(mp, mp->m_attr_geo->fsbcount), 0, &bp);
302ce92464cSDarrick J. Wong 	if (error)
303ce92464cSDarrick J. Wong 		return error;
3042911edb6SChristoph Hellwig 	error = bp->b_error;
3052911edb6SChristoph Hellwig 	if (error) {
3062911edb6SChristoph Hellwig 		xfs_trans_brelse(*trans, bp);
307fde2227cSDave Chinner 		return error;
3082911edb6SChristoph Hellwig 	}
309fde2227cSDave Chinner 	xfs_trans_binval(*trans, bp);	/* remove from cache */
310fde2227cSDave Chinner 	/*
311fde2227cSDave Chinner 	 * Commit the invalidate and start the next transaction.
312fde2227cSDave Chinner 	 */
313411350dfSChristoph Hellwig 	error = xfs_trans_roll_inode(trans, dp);
314fde2227cSDave Chinner 
315fde2227cSDave Chinner 	return error;
316fde2227cSDave Chinner }
317fde2227cSDave Chinner 
3186dfe5a04SDave Chinner /*
3196dfe5a04SDave Chinner  * xfs_attr_inactive kills all traces of an attribute fork on an inode. It
3206dfe5a04SDave Chinner  * removes both the on-disk and in-memory inode fork. Note that this also has to
3216dfe5a04SDave Chinner  * handle the condition of inodes without attributes but with an attribute fork
3226dfe5a04SDave Chinner  * configured, so we can't use xfs_inode_hasattr() here.
3236dfe5a04SDave Chinner  *
3246dfe5a04SDave Chinner  * The in-memory attribute fork is removed even on error.
3256dfe5a04SDave Chinner  */
326fde2227cSDave Chinner int
xfs_attr_inactive(struct xfs_inode * dp)3276dfe5a04SDave Chinner xfs_attr_inactive(
3286dfe5a04SDave Chinner 	struct xfs_inode	*dp)
329fde2227cSDave Chinner {
3306dfe5a04SDave Chinner 	struct xfs_trans	*trans;
3316dfe5a04SDave Chinner 	struct xfs_mount	*mp;
3326dfe5a04SDave Chinner 	int			lock_mode = XFS_ILOCK_SHARED;
3336dfe5a04SDave Chinner 	int			error = 0;
334fde2227cSDave Chinner 
335fde2227cSDave Chinner 	mp = dp->i_mount;
336fde2227cSDave Chinner 
3376dfe5a04SDave Chinner 	xfs_ilock(dp, lock_mode);
338932b42c6SDarrick J. Wong 	if (!xfs_inode_has_attr_fork(dp))
3396dfe5a04SDave Chinner 		goto out_destroy_fork;
3406dfe5a04SDave Chinner 	xfs_iunlock(dp, lock_mode);
341fde2227cSDave Chinner 
3426dfe5a04SDave Chinner 	lock_mode = 0;
343253f4911SChristoph Hellwig 
344253f4911SChristoph Hellwig 	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_attrinval, 0, 0, 0, &trans);
3456dfe5a04SDave Chinner 	if (error)
346253f4911SChristoph Hellwig 		goto out_destroy_fork;
3476dfe5a04SDave Chinner 
3486dfe5a04SDave Chinner 	lock_mode = XFS_ILOCK_EXCL;
3496dfe5a04SDave Chinner 	xfs_ilock(dp, lock_mode);
3506dfe5a04SDave Chinner 
351932b42c6SDarrick J. Wong 	if (!xfs_inode_has_attr_fork(dp))
3526dfe5a04SDave Chinner 		goto out_cancel;
353fde2227cSDave Chinner 
354fde2227cSDave Chinner 	/*
355fde2227cSDave Chinner 	 * No need to make quota reservations here. We expect to release some
356fde2227cSDave Chinner 	 * blocks, not allocate, in the common case.
357fde2227cSDave Chinner 	 */
358fde2227cSDave Chinner 	xfs_trans_ijoin(trans, dp, 0);
359fde2227cSDave Chinner 
360f66bf042SBrian Foster 	/*
361f66bf042SBrian Foster 	 * Invalidate and truncate the attribute fork extents. Make sure the
362e45d7cb2SDarrick J. Wong 	 * fork actually has xattr blocks as otherwise the invalidation has no
363f66bf042SBrian Foster 	 * blocks to read and returns an error. In this case, just do the fork
364f66bf042SBrian Foster 	 * removal below.
365f66bf042SBrian Foster 	 */
366e45d7cb2SDarrick J. Wong 	if (dp->i_af.if_nextents > 0) {
367fde2227cSDave Chinner 		error = xfs_attr3_root_inactive(&trans, dp);
368fde2227cSDave Chinner 		if (error)
3696dfe5a04SDave Chinner 			goto out_cancel;
370fde2227cSDave Chinner 
371fde2227cSDave Chinner 		error = xfs_itruncate_extents(&trans, dp, XFS_ATTR_FORK, 0);
372fde2227cSDave Chinner 		if (error)
3736dfe5a04SDave Chinner 			goto out_cancel;
3746dfe5a04SDave Chinner 	}
3756dfe5a04SDave Chinner 
3766dfe5a04SDave Chinner 	/* Reset the attribute fork - this also destroys the in-core fork */
3776dfe5a04SDave Chinner 	xfs_attr_fork_remove(dp, trans);
378fde2227cSDave Chinner 
37970393313SChristoph Hellwig 	error = xfs_trans_commit(trans);
3806dfe5a04SDave Chinner 	xfs_iunlock(dp, lock_mode);
381d99831ffSEric Sandeen 	return error;
382fde2227cSDave Chinner 
3836dfe5a04SDave Chinner out_cancel:
3844906e215SChristoph Hellwig 	xfs_trans_cancel(trans);
3856dfe5a04SDave Chinner out_destroy_fork:
3866dfe5a04SDave Chinner 	/* kill the in-core attr fork before we drop the inode lock */
3872ed5b09bSDarrick J. Wong 	xfs_ifork_zap_attr(dp);
3886dfe5a04SDave Chinner 	if (lock_mode)
3896dfe5a04SDave Chinner 		xfs_iunlock(dp, lock_mode);
390d99831ffSEric Sandeen 	return error;
391fde2227cSDave Chinner }
392