xref: /openbmc/linux/fs/xfs/scrub/attr.c (revision 44af6c7e)
1739a2fe0SDarrick J. Wong // SPDX-License-Identifier: GPL-2.0-or-later
2eec0482eSDarrick J. Wong /*
3ecc73f8aSDarrick J. Wong  * Copyright (C) 2017-2023 Oracle.  All Rights Reserved.
4739a2fe0SDarrick J. Wong  * Author: Darrick J. Wong <djwong@kernel.org>
5eec0482eSDarrick J. Wong  */
6eec0482eSDarrick J. Wong #include "xfs.h"
7eec0482eSDarrick J. Wong #include "xfs_fs.h"
8eec0482eSDarrick J. Wong #include "xfs_shared.h"
9eec0482eSDarrick J. Wong #include "xfs_format.h"
10eec0482eSDarrick J. Wong #include "xfs_trans_resv.h"
11eec0482eSDarrick J. Wong #include "xfs_mount.h"
12eec0482eSDarrick J. Wong #include "xfs_log_format.h"
13eec0482eSDarrick J. Wong #include "xfs_inode.h"
14eec0482eSDarrick J. Wong #include "xfs_da_format.h"
15eec0482eSDarrick J. Wong #include "xfs_da_btree.h"
16eec0482eSDarrick J. Wong #include "xfs_attr.h"
17eec0482eSDarrick J. Wong #include "xfs_attr_leaf.h"
18ae0506ebSDarrick J. Wong #include "xfs_attr_sf.h"
19eec0482eSDarrick J. Wong #include "scrub/scrub.h"
20eec0482eSDarrick J. Wong #include "scrub/common.h"
21eec0482eSDarrick J. Wong #include "scrub/dabtree.h"
223addd248SDarrick J. Wong #include "scrub/attr.h"
23eec0482eSDarrick J. Wong 
2491781ff5SDarrick J. Wong /* Free the buffers linked from the xattr buffer. */
2591781ff5SDarrick J. Wong static void
xchk_xattr_buf_cleanup(void * priv)2691781ff5SDarrick J. Wong xchk_xattr_buf_cleanup(
2791781ff5SDarrick J. Wong 	void			*priv)
2891781ff5SDarrick J. Wong {
2991781ff5SDarrick J. Wong 	struct xchk_xattr_buf	*ab = priv;
3091781ff5SDarrick J. Wong 
3191781ff5SDarrick J. Wong 	kvfree(ab->freemap);
3291781ff5SDarrick J. Wong 	ab->freemap = NULL;
3380069284SDarrick J. Wong 	kvfree(ab->usedmap);
3480069284SDarrick J. Wong 	ab->usedmap = NULL;
35b996c9a8SDarrick J. Wong 	kvfree(ab->value);
36b996c9a8SDarrick J. Wong 	ab->value = NULL;
37b996c9a8SDarrick J. Wong 	ab->value_sz = 0;
3891781ff5SDarrick J. Wong }
3991781ff5SDarrick J. Wong 
406d6cceddSDarrick J. Wong /*
41674f0d0dSDarrick J. Wong  * Allocate the free space bitmap if we're trying harder; there are leaf blocks
42674f0d0dSDarrick J. Wong  * in the attr fork; or we can't tell if there are leaf blocks.
43674f0d0dSDarrick J. Wong  */
44674f0d0dSDarrick J. Wong static inline bool
xchk_xattr_want_freemap(struct xfs_scrub * sc)45674f0d0dSDarrick J. Wong xchk_xattr_want_freemap(
46674f0d0dSDarrick J. Wong 	struct xfs_scrub	*sc)
47674f0d0dSDarrick J. Wong {
48674f0d0dSDarrick J. Wong 	struct xfs_ifork	*ifp;
49674f0d0dSDarrick J. Wong 
50674f0d0dSDarrick J. Wong 	if (sc->flags & XCHK_TRY_HARDER)
51674f0d0dSDarrick J. Wong 		return true;
52674f0d0dSDarrick J. Wong 
53674f0d0dSDarrick J. Wong 	if (!sc->ip)
54674f0d0dSDarrick J. Wong 		return true;
55674f0d0dSDarrick J. Wong 
56674f0d0dSDarrick J. Wong 	ifp = xfs_ifork_ptr(sc->ip, XFS_ATTR_FORK);
57674f0d0dSDarrick J. Wong 	if (!ifp)
58674f0d0dSDarrick J. Wong 		return false;
59674f0d0dSDarrick J. Wong 
60674f0d0dSDarrick J. Wong 	return xfs_ifork_has_extents(ifp);
61674f0d0dSDarrick J. Wong }
62674f0d0dSDarrick J. Wong 
63674f0d0dSDarrick J. Wong /*
646d6cceddSDarrick J. Wong  * Allocate enough memory to hold an attr value and attr block bitmaps,
656d6cceddSDarrick J. Wong  * reallocating the buffer if necessary.  Buffer contents are not preserved
666d6cceddSDarrick J. Wong  * across a reallocation.
676d6cceddSDarrick J. Wong  */
68d634525dSDave Chinner static int
xchk_setup_xattr_buf(struct xfs_scrub * sc,size_t value_size)6900816759SDarrick J. Wong xchk_setup_xattr_buf(
7000816759SDarrick J. Wong 	struct xfs_scrub	*sc,
71f58977edSDarrick J. Wong 	size_t			value_size)
7200816759SDarrick J. Wong {
7391781ff5SDarrick J. Wong 	size_t			bmp_sz;
746d6cceddSDarrick J. Wong 	struct xchk_xattr_buf	*ab = sc->buf;
75b996c9a8SDarrick J. Wong 	void			*new_val;
7691781ff5SDarrick J. Wong 
7791781ff5SDarrick J. Wong 	bmp_sz = sizeof(long) * BITS_TO_LONGS(sc->mp->m_attr_geo->blksize);
7800816759SDarrick J. Wong 
79b996c9a8SDarrick J. Wong 	if (ab)
80b996c9a8SDarrick J. Wong 		goto resize_value;
816d6cceddSDarrick J. Wong 
82f58977edSDarrick J. Wong 	ab = kvzalloc(sizeof(struct xchk_xattr_buf), XCHK_GFP_FLAGS);
836d6cceddSDarrick J. Wong 	if (!ab)
8400816759SDarrick J. Wong 		return -ENOMEM;
856d6cceddSDarrick J. Wong 	sc->buf = ab;
8691781ff5SDarrick J. Wong 	sc->buf_cleanup = xchk_xattr_buf_cleanup;
8791781ff5SDarrick J. Wong 
88f58977edSDarrick J. Wong 	ab->usedmap = kvmalloc(bmp_sz, XCHK_GFP_FLAGS);
8980069284SDarrick J. Wong 	if (!ab->usedmap)
9080069284SDarrick J. Wong 		return -ENOMEM;
9180069284SDarrick J. Wong 
92674f0d0dSDarrick J. Wong 	if (xchk_xattr_want_freemap(sc)) {
93f58977edSDarrick J. Wong 		ab->freemap = kvmalloc(bmp_sz, XCHK_GFP_FLAGS);
9491781ff5SDarrick J. Wong 		if (!ab->freemap)
9591781ff5SDarrick J. Wong 			return -ENOMEM;
96674f0d0dSDarrick J. Wong 	}
97b996c9a8SDarrick J. Wong 
98b996c9a8SDarrick J. Wong resize_value:
99b996c9a8SDarrick J. Wong 	if (ab->value_sz >= value_size)
100b996c9a8SDarrick J. Wong 		return 0;
101b996c9a8SDarrick J. Wong 
102b996c9a8SDarrick J. Wong 	if (ab->value) {
103b996c9a8SDarrick J. Wong 		kvfree(ab->value);
104b996c9a8SDarrick J. Wong 		ab->value = NULL;
105b996c9a8SDarrick J. Wong 		ab->value_sz = 0;
10691781ff5SDarrick J. Wong 	}
10791781ff5SDarrick J. Wong 
108f58977edSDarrick J. Wong 	new_val = kvmalloc(value_size, XCHK_GFP_FLAGS);
109b996c9a8SDarrick J. Wong 	if (!new_val)
110b996c9a8SDarrick J. Wong 		return -ENOMEM;
111b996c9a8SDarrick J. Wong 
112b996c9a8SDarrick J. Wong 	ab->value = new_val;
113b996c9a8SDarrick J. Wong 	ab->value_sz = value_size;
11400816759SDarrick J. Wong 	return 0;
11500816759SDarrick J. Wong }
11600816759SDarrick J. Wong 
117eec0482eSDarrick J. Wong /* Set us up to scrub an inode's extended attributes. */
118eec0482eSDarrick J. Wong int
xchk_setup_xattr(struct xfs_scrub * sc)119c517b3aaSDarrick J. Wong xchk_setup_xattr(
120026f57ebSDarrick J. Wong 	struct xfs_scrub	*sc)
121eec0482eSDarrick J. Wong {
12200816759SDarrick J. Wong 	int			error;
12313791d3bSDarrick J. Wong 
1246d6cceddSDarrick J. Wong 	/*
1256d6cceddSDarrick J. Wong 	 * We failed to get memory while checking attrs, so this time try to
1266d6cceddSDarrick J. Wong 	 * get all the memory we're ever going to need.  Allocate the buffer
1276d6cceddSDarrick J. Wong 	 * without the inode lock held, which means we can sleep.
1286d6cceddSDarrick J. Wong 	 */
1296d6cceddSDarrick J. Wong 	if (sc->flags & XCHK_TRY_HARDER) {
130f58977edSDarrick J. Wong 		error = xchk_setup_xattr_buf(sc, XATTR_SIZE_MAX);
13100816759SDarrick J. Wong 		if (error)
13200816759SDarrick J. Wong 			return error;
1336d6cceddSDarrick J. Wong 	}
134eec0482eSDarrick J. Wong 
135026f57ebSDarrick J. Wong 	return xchk_setup_inode_contents(sc, 0);
136eec0482eSDarrick J. Wong }
137eec0482eSDarrick J. Wong 
138eec0482eSDarrick J. Wong /* Extended Attributes */
139eec0482eSDarrick J. Wong 
140c517b3aaSDarrick J. Wong struct xchk_xattr {
141eec0482eSDarrick J. Wong 	struct xfs_attr_list_context	context;
1421d8a748aSDarrick J. Wong 	struct xfs_scrub		*sc;
143eec0482eSDarrick J. Wong };
144eec0482eSDarrick J. Wong 
145eec0482eSDarrick J. Wong /*
146eec0482eSDarrick J. Wong  * Check that an extended attribute key can be looked up by hash.
147eec0482eSDarrick J. Wong  *
14817e1dd83SChristoph Hellwig  * We use the XFS attribute list iterator (i.e. xfs_attr_list_ilocked)
149eec0482eSDarrick J. Wong  * to call this function for every attribute key in an inode.  Once
150eec0482eSDarrick J. Wong  * we're here, we load the attribute value to see if any errors happen,
151eec0482eSDarrick J. Wong  * or if we get more or less data than we expected.
152eec0482eSDarrick J. Wong  */
153eec0482eSDarrick J. Wong static void
xchk_xattr_listent(struct xfs_attr_list_context * context,int flags,unsigned char * name,int namelen,int valuelen)154c517b3aaSDarrick J. Wong xchk_xattr_listent(
155eec0482eSDarrick J. Wong 	struct xfs_attr_list_context	*context,
156eec0482eSDarrick J. Wong 	int				flags,
157eec0482eSDarrick J. Wong 	unsigned char			*name,
158eec0482eSDarrick J. Wong 	int				namelen,
159eec0482eSDarrick J. Wong 	int				valuelen)
160eec0482eSDarrick J. Wong {
161b996c9a8SDarrick J. Wong 	struct xfs_da_args		args = {
162b996c9a8SDarrick J. Wong 		.op_flags		= XFS_DA_OP_NOTIME,
163b996c9a8SDarrick J. Wong 		.attr_filter		= flags & XFS_ATTR_NSP_ONDISK_MASK,
164b996c9a8SDarrick J. Wong 		.geo			= context->dp->i_mount->m_attr_geo,
165b996c9a8SDarrick J. Wong 		.whichfork		= XFS_ATTR_FORK,
166b996c9a8SDarrick J. Wong 		.dp			= context->dp,
167b996c9a8SDarrick J. Wong 		.name			= name,
168b996c9a8SDarrick J. Wong 		.namelen		= namelen,
169b996c9a8SDarrick J. Wong 		.hashval		= xfs_da_hashname(name, namelen),
170b996c9a8SDarrick J. Wong 		.trans			= context->tp,
171b996c9a8SDarrick J. Wong 		.valuelen		= valuelen,
172b996c9a8SDarrick J. Wong 	};
173b996c9a8SDarrick J. Wong 	struct xchk_xattr_buf		*ab;
174c517b3aaSDarrick J. Wong 	struct xchk_xattr		*sx;
175eec0482eSDarrick J. Wong 	int				error = 0;
176eec0482eSDarrick J. Wong 
177c517b3aaSDarrick J. Wong 	sx = container_of(context, struct xchk_xattr, context);
178b996c9a8SDarrick J. Wong 	ab = sx->sc->buf;
179eec0482eSDarrick J. Wong 
1803258cb20SDarrick J. Wong 	if (xchk_should_terminate(sx->sc, &error)) {
1812c3b83d7SDarrick J. Wong 		context->seen_enough = error;
1823258cb20SDarrick J. Wong 		return;
1833258cb20SDarrick J. Wong 	}
1843258cb20SDarrick J. Wong 
185eec0482eSDarrick J. Wong 	if (flags & XFS_ATTR_INCOMPLETE) {
186eec0482eSDarrick J. Wong 		/* Incomplete attr key, just mark the inode for preening. */
187c517b3aaSDarrick J. Wong 		xchk_ino_set_preen(sx->sc, context->dp->i_ino);
188eec0482eSDarrick J. Wong 		return;
189eec0482eSDarrick J. Wong 	}
190eec0482eSDarrick J. Wong 
191c12ad414SDarrick J. Wong 	/* Only one namespace bit allowed. */
192c12ad414SDarrick J. Wong 	if (hweight32(flags & XFS_ATTR_NSP_ONDISK_MASK) > 1) {
193c12ad414SDarrick J. Wong 		xchk_fblock_set_corrupt(sx->sc, XFS_ATTR_FORK, args.blkno);
194c12ad414SDarrick J. Wong 		goto fail_xref;
195c12ad414SDarrick J. Wong 	}
196c12ad414SDarrick J. Wong 
19765480536SDarrick J. Wong 	/* Does this name make sense? */
19865480536SDarrick J. Wong 	if (!xfs_attr_namecheck(name, namelen)) {
19965480536SDarrick J. Wong 		xchk_fblock_set_corrupt(sx->sc, XFS_ATTR_FORK, args.blkno);
200c12ad414SDarrick J. Wong 		goto fail_xref;
20165480536SDarrick J. Wong 	}
20265480536SDarrick J. Wong 
2036d6cceddSDarrick J. Wong 	/*
204*44af6c7eSDarrick J. Wong 	 * Local xattr values are stored in the attr leaf block, so we don't
205*44af6c7eSDarrick J. Wong 	 * need to retrieve the value from a remote block to detect corruption
206*44af6c7eSDarrick J. Wong 	 * problems.
207*44af6c7eSDarrick J. Wong 	 */
208*44af6c7eSDarrick J. Wong 	if (flags & XFS_ATTR_LOCAL)
209*44af6c7eSDarrick J. Wong 		goto fail_xref;
210*44af6c7eSDarrick J. Wong 
211*44af6c7eSDarrick J. Wong 	/*
2126d6cceddSDarrick J. Wong 	 * Try to allocate enough memory to extrat the attr value.  If that
2136d6cceddSDarrick J. Wong 	 * doesn't work, we overload the seen_enough variable to convey
2146d6cceddSDarrick J. Wong 	 * the error message back to the main scrub function.
2156d6cceddSDarrick J. Wong 	 */
216f58977edSDarrick J. Wong 	error = xchk_setup_xattr_buf(sx->sc, valuelen);
2176d6cceddSDarrick J. Wong 	if (error == -ENOMEM)
2186d6cceddSDarrick J. Wong 		error = -EDEADLOCK;
2196d6cceddSDarrick J. Wong 	if (error) {
2206d6cceddSDarrick J. Wong 		context->seen_enough = error;
2216d6cceddSDarrick J. Wong 		return;
2226d6cceddSDarrick J. Wong 	}
2236d6cceddSDarrick J. Wong 
224b996c9a8SDarrick J. Wong 	args.value = ab->value;
225eec0482eSDarrick J. Wong 
226c36f533fSChristoph Hellwig 	error = xfs_attr_get_ilocked(&args);
227806d3909SDarrick J. Wong 	/* ENODATA means the hash lookup failed and the attr is bad */
228806d3909SDarrick J. Wong 	if (error == -ENODATA)
229806d3909SDarrick J. Wong 		error = -EFSCORRUPTED;
230c517b3aaSDarrick J. Wong 	if (!xchk_fblock_process_error(sx->sc, XFS_ATTR_FORK, args.blkno,
231eec0482eSDarrick J. Wong 			&error))
232eec0482eSDarrick J. Wong 		goto fail_xref;
233eec0482eSDarrick J. Wong 	if (args.valuelen != valuelen)
234c517b3aaSDarrick J. Wong 		xchk_fblock_set_corrupt(sx->sc, XFS_ATTR_FORK,
235eec0482eSDarrick J. Wong 					     args.blkno);
236eec0482eSDarrick J. Wong fail_xref:
2378bc763c2SDarrick J. Wong 	if (sx->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
238e7ee96dfSDarrick J. Wong 		context->seen_enough = 1;
239eec0482eSDarrick J. Wong 	return;
240eec0482eSDarrick J. Wong }
241eec0482eSDarrick J. Wong 
24213791d3bSDarrick J. Wong /*
24313791d3bSDarrick J. Wong  * Mark a range [start, start+len) in this map.  Returns true if the
24413791d3bSDarrick J. Wong  * region was free, and false if there's a conflict or a problem.
24513791d3bSDarrick J. Wong  *
24613791d3bSDarrick J. Wong  * Within a char, the lowest bit of the char represents the byte with
24713791d3bSDarrick J. Wong  * the smallest address
24813791d3bSDarrick J. Wong  */
24913791d3bSDarrick J. Wong STATIC bool
xchk_xattr_set_map(struct xfs_scrub * sc,unsigned long * map,unsigned int start,unsigned int len)250c517b3aaSDarrick J. Wong xchk_xattr_set_map(
2511d8a748aSDarrick J. Wong 	struct xfs_scrub	*sc,
25213791d3bSDarrick J. Wong 	unsigned long		*map,
25313791d3bSDarrick J. Wong 	unsigned int		start,
25413791d3bSDarrick J. Wong 	unsigned int		len)
25513791d3bSDarrick J. Wong {
25613791d3bSDarrick J. Wong 	unsigned int		mapsize = sc->mp->m_attr_geo->blksize;
25713791d3bSDarrick J. Wong 	bool			ret = true;
25813791d3bSDarrick J. Wong 
25913791d3bSDarrick J. Wong 	if (start >= mapsize)
26013791d3bSDarrick J. Wong 		return false;
26113791d3bSDarrick J. Wong 	if (start + len > mapsize) {
26213791d3bSDarrick J. Wong 		len = mapsize - start;
26313791d3bSDarrick J. Wong 		ret = false;
26413791d3bSDarrick J. Wong 	}
26513791d3bSDarrick J. Wong 
26613791d3bSDarrick J. Wong 	if (find_next_bit(map, mapsize, start) < start + len)
26713791d3bSDarrick J. Wong 		ret = false;
26813791d3bSDarrick J. Wong 	bitmap_set(map, start, len);
26913791d3bSDarrick J. Wong 
27013791d3bSDarrick J. Wong 	return ret;
27113791d3bSDarrick J. Wong }
27213791d3bSDarrick J. Wong 
27313791d3bSDarrick J. Wong /*
27413791d3bSDarrick J. Wong  * Check the leaf freemap from the usage bitmap.  Returns false if the
27513791d3bSDarrick J. Wong  * attr freemap has problems or points to used space.
27613791d3bSDarrick J. Wong  */
27713791d3bSDarrick J. Wong STATIC bool
xchk_xattr_check_freemap(struct xfs_scrub * sc,struct xfs_attr3_icleaf_hdr * leafhdr)278c517b3aaSDarrick J. Wong xchk_xattr_check_freemap(
2791d8a748aSDarrick J. Wong 	struct xfs_scrub		*sc,
28013791d3bSDarrick J. Wong 	struct xfs_attr3_icleaf_hdr	*leafhdr)
28113791d3bSDarrick J. Wong {
28291781ff5SDarrick J. Wong 	struct xchk_xattr_buf		*ab = sc->buf;
28313791d3bSDarrick J. Wong 	unsigned int			mapsize = sc->mp->m_attr_geo->blksize;
28413791d3bSDarrick J. Wong 	int				i;
28513791d3bSDarrick J. Wong 
28613791d3bSDarrick J. Wong 	/* Construct bitmap of freemap contents. */
28791781ff5SDarrick J. Wong 	bitmap_zero(ab->freemap, mapsize);
28813791d3bSDarrick J. Wong 	for (i = 0; i < XFS_ATTR_LEAF_MAPSIZE; i++) {
28991781ff5SDarrick J. Wong 		if (!xchk_xattr_set_map(sc, ab->freemap,
29013791d3bSDarrick J. Wong 				leafhdr->freemap[i].base,
29113791d3bSDarrick J. Wong 				leafhdr->freemap[i].size))
29213791d3bSDarrick J. Wong 			return false;
29313791d3bSDarrick J. Wong 	}
29413791d3bSDarrick J. Wong 
29513791d3bSDarrick J. Wong 	/* Look for bits that are set in freemap and are marked in use. */
29680069284SDarrick J. Wong 	return !bitmap_intersects(ab->freemap, ab->usedmap, mapsize);
29713791d3bSDarrick J. Wong }
29813791d3bSDarrick J. Wong 
29913791d3bSDarrick J. Wong /*
30013791d3bSDarrick J. Wong  * Check this leaf entry's relations to everything else.
30113791d3bSDarrick J. Wong  * Returns the number of bytes used for the name/value data.
30213791d3bSDarrick J. Wong  */
30313791d3bSDarrick J. Wong STATIC void
xchk_xattr_entry(struct xchk_da_btree * ds,int level,char * buf_end,struct xfs_attr_leafblock * leaf,struct xfs_attr3_icleaf_hdr * leafhdr,struct xfs_attr_leaf_entry * ent,int idx,unsigned int * usedbytes,__u32 * last_hashval)304c517b3aaSDarrick J. Wong xchk_xattr_entry(
305c517b3aaSDarrick J. Wong 	struct xchk_da_btree		*ds,
30613791d3bSDarrick J. Wong 	int				level,
30713791d3bSDarrick J. Wong 	char				*buf_end,
30813791d3bSDarrick J. Wong 	struct xfs_attr_leafblock	*leaf,
30913791d3bSDarrick J. Wong 	struct xfs_attr3_icleaf_hdr	*leafhdr,
31013791d3bSDarrick J. Wong 	struct xfs_attr_leaf_entry	*ent,
31113791d3bSDarrick J. Wong 	int				idx,
31213791d3bSDarrick J. Wong 	unsigned int			*usedbytes,
31313791d3bSDarrick J. Wong 	__u32				*last_hashval)
31413791d3bSDarrick J. Wong {
31513791d3bSDarrick J. Wong 	struct xfs_mount		*mp = ds->state->mp;
31680069284SDarrick J. Wong 	struct xchk_xattr_buf		*ab = ds->sc->buf;
31713791d3bSDarrick J. Wong 	char				*name_end;
31813791d3bSDarrick J. Wong 	struct xfs_attr_leaf_name_local	*lentry;
31913791d3bSDarrick J. Wong 	struct xfs_attr_leaf_name_remote *rentry;
32013791d3bSDarrick J. Wong 	unsigned int			nameidx;
32113791d3bSDarrick J. Wong 	unsigned int			namesize;
32213791d3bSDarrick J. Wong 
32313791d3bSDarrick J. Wong 	if (ent->pad2 != 0)
324c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
32513791d3bSDarrick J. Wong 
32613791d3bSDarrick J. Wong 	/* Hash values in order? */
32713791d3bSDarrick J. Wong 	if (be32_to_cpu(ent->hashval) < *last_hashval)
328c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
32913791d3bSDarrick J. Wong 	*last_hashval = be32_to_cpu(ent->hashval);
33013791d3bSDarrick J. Wong 
33113791d3bSDarrick J. Wong 	nameidx = be16_to_cpu(ent->nameidx);
33213791d3bSDarrick J. Wong 	if (nameidx < leafhdr->firstused ||
33313791d3bSDarrick J. Wong 	    nameidx >= mp->m_attr_geo->blksize) {
334c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
33513791d3bSDarrick J. Wong 		return;
33613791d3bSDarrick J. Wong 	}
33713791d3bSDarrick J. Wong 
33813791d3bSDarrick J. Wong 	/* Check the name information. */
33913791d3bSDarrick J. Wong 	if (ent->flags & XFS_ATTR_LOCAL) {
34013791d3bSDarrick J. Wong 		lentry = xfs_attr3_leaf_name_local(leaf, idx);
34113791d3bSDarrick J. Wong 		namesize = xfs_attr_leaf_entsize_local(lentry->namelen,
34213791d3bSDarrick J. Wong 				be16_to_cpu(lentry->valuelen));
34313791d3bSDarrick J. Wong 		name_end = (char *)lentry + namesize;
34413791d3bSDarrick J. Wong 		if (lentry->namelen == 0)
345c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
34613791d3bSDarrick J. Wong 	} else {
34713791d3bSDarrick J. Wong 		rentry = xfs_attr3_leaf_name_remote(leaf, idx);
34813791d3bSDarrick J. Wong 		namesize = xfs_attr_leaf_entsize_remote(rentry->namelen);
34913791d3bSDarrick J. Wong 		name_end = (char *)rentry + namesize;
35013791d3bSDarrick J. Wong 		if (rentry->namelen == 0 || rentry->valueblk == 0)
351c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
35213791d3bSDarrick J. Wong 	}
35313791d3bSDarrick J. Wong 	if (name_end > buf_end)
354c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
35513791d3bSDarrick J. Wong 
35680069284SDarrick J. Wong 	if (!xchk_xattr_set_map(ds->sc, ab->usedmap, nameidx, namesize))
357c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
35813791d3bSDarrick J. Wong 	if (!(ds->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT))
35913791d3bSDarrick J. Wong 		*usedbytes += namesize;
36013791d3bSDarrick J. Wong }
36113791d3bSDarrick J. Wong 
36213791d3bSDarrick J. Wong /* Scrub an attribute leaf. */
36313791d3bSDarrick J. Wong STATIC int
xchk_xattr_block(struct xchk_da_btree * ds,int level)364c517b3aaSDarrick J. Wong xchk_xattr_block(
365c517b3aaSDarrick J. Wong 	struct xchk_da_btree		*ds,
36613791d3bSDarrick J. Wong 	int				level)
36713791d3bSDarrick J. Wong {
36813791d3bSDarrick J. Wong 	struct xfs_attr3_icleaf_hdr	leafhdr;
36913791d3bSDarrick J. Wong 	struct xfs_mount		*mp = ds->state->mp;
37013791d3bSDarrick J. Wong 	struct xfs_da_state_blk		*blk = &ds->state->path.blk[level];
37113791d3bSDarrick J. Wong 	struct xfs_buf			*bp = blk->bp;
37213791d3bSDarrick J. Wong 	xfs_dablk_t			*last_checked = ds->private;
37313791d3bSDarrick J. Wong 	struct xfs_attr_leafblock	*leaf = bp->b_addr;
37413791d3bSDarrick J. Wong 	struct xfs_attr_leaf_entry	*ent;
37513791d3bSDarrick J. Wong 	struct xfs_attr_leaf_entry	*entries;
37680069284SDarrick J. Wong 	struct xchk_xattr_buf		*ab = ds->sc->buf;
37713791d3bSDarrick J. Wong 	char				*buf_end;
37813791d3bSDarrick J. Wong 	size_t				off;
37913791d3bSDarrick J. Wong 	__u32				last_hashval = 0;
38013791d3bSDarrick J. Wong 	unsigned int			usedbytes = 0;
38113791d3bSDarrick J. Wong 	unsigned int			hdrsize;
38213791d3bSDarrick J. Wong 	int				i;
38313791d3bSDarrick J. Wong 
38413791d3bSDarrick J. Wong 	if (*last_checked == blk->blkno)
38513791d3bSDarrick J. Wong 		return 0;
3866d6cceddSDarrick J. Wong 
38713791d3bSDarrick J. Wong 	*last_checked = blk->blkno;
38880069284SDarrick J. Wong 	bitmap_zero(ab->usedmap, mp->m_attr_geo->blksize);
38913791d3bSDarrick J. Wong 
39013791d3bSDarrick J. Wong 	/* Check all the padding. */
39138c26bfdSDave Chinner 	if (xfs_has_crc(ds->sc->mp)) {
392ee366fe4SDarrick J. Wong 		struct xfs_attr3_leafblock	*leaf3 = bp->b_addr;
39313791d3bSDarrick J. Wong 
394ee366fe4SDarrick J. Wong 		if (leaf3->hdr.pad1 != 0 || leaf3->hdr.pad2 != 0 ||
395ee366fe4SDarrick J. Wong 		    leaf3->hdr.info.hdr.pad != 0)
396c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
39713791d3bSDarrick J. Wong 	} else {
39813791d3bSDarrick J. Wong 		if (leaf->hdr.pad1 != 0 || leaf->hdr.info.pad != 0)
399c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
40013791d3bSDarrick J. Wong 	}
40113791d3bSDarrick J. Wong 
40213791d3bSDarrick J. Wong 	/* Check the leaf header */
40313791d3bSDarrick J. Wong 	xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &leafhdr, leaf);
40413791d3bSDarrick J. Wong 	hdrsize = xfs_attr3_leaf_hdr_size(leaf);
40513791d3bSDarrick J. Wong 
40613791d3bSDarrick J. Wong 	if (leafhdr.usedbytes > mp->m_attr_geo->blksize)
407c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
40813791d3bSDarrick J. Wong 	if (leafhdr.firstused > mp->m_attr_geo->blksize)
409c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
41013791d3bSDarrick J. Wong 	if (leafhdr.firstused < hdrsize)
411c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
41280069284SDarrick J. Wong 	if (!xchk_xattr_set_map(ds->sc, ab->usedmap, 0, hdrsize))
413c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
41413791d3bSDarrick J. Wong 
41513791d3bSDarrick J. Wong 	if (ds->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
41613791d3bSDarrick J. Wong 		goto out;
41713791d3bSDarrick J. Wong 
41813791d3bSDarrick J. Wong 	entries = xfs_attr3_leaf_entryp(leaf);
41913791d3bSDarrick J. Wong 	if ((char *)&entries[leafhdr.count] > (char *)leaf + leafhdr.firstused)
420c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
42113791d3bSDarrick J. Wong 
42213791d3bSDarrick J. Wong 	buf_end = (char *)bp->b_addr + mp->m_attr_geo->blksize;
42313791d3bSDarrick J. Wong 	for (i = 0, ent = entries; i < leafhdr.count; ent++, i++) {
42413791d3bSDarrick J. Wong 		/* Mark the leaf entry itself. */
42513791d3bSDarrick J. Wong 		off = (char *)ent - (char *)leaf;
42680069284SDarrick J. Wong 		if (!xchk_xattr_set_map(ds->sc, ab->usedmap, off,
42713791d3bSDarrick J. Wong 				sizeof(xfs_attr_leaf_entry_t))) {
428c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
42913791d3bSDarrick J. Wong 			goto out;
43013791d3bSDarrick J. Wong 		}
43113791d3bSDarrick J. Wong 
43213791d3bSDarrick J. Wong 		/* Check the entry and nameval. */
433c517b3aaSDarrick J. Wong 		xchk_xattr_entry(ds, level, buf_end, leaf, &leafhdr,
4343addd248SDarrick J. Wong 				ent, i, &usedbytes, &last_hashval);
43513791d3bSDarrick J. Wong 
43613791d3bSDarrick J. Wong 		if (ds->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
43713791d3bSDarrick J. Wong 			goto out;
43813791d3bSDarrick J. Wong 	}
43913791d3bSDarrick J. Wong 
44080069284SDarrick J. Wong 	if (!xchk_xattr_check_freemap(ds->sc, &leafhdr))
441c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
44213791d3bSDarrick J. Wong 
44313791d3bSDarrick J. Wong 	if (leafhdr.usedbytes != usedbytes)
444c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
44513791d3bSDarrick J. Wong 
44613791d3bSDarrick J. Wong out:
44713791d3bSDarrick J. Wong 	return 0;
44813791d3bSDarrick J. Wong }
44913791d3bSDarrick J. Wong 
450eec0482eSDarrick J. Wong /* Scrub a attribute btree record. */
451eec0482eSDarrick J. Wong STATIC int
xchk_xattr_rec(struct xchk_da_btree * ds,int level)452c517b3aaSDarrick J. Wong xchk_xattr_rec(
453c517b3aaSDarrick J. Wong 	struct xchk_da_btree		*ds,
454649d9d98SChristoph Hellwig 	int				level)
455eec0482eSDarrick J. Wong {
456eec0482eSDarrick J. Wong 	struct xfs_mount		*mp = ds->state->mp;
457649d9d98SChristoph Hellwig 	struct xfs_da_state_blk		*blk = &ds->state->path.blk[level];
458eec0482eSDarrick J. Wong 	struct xfs_attr_leaf_name_local	*lentry;
459eec0482eSDarrick J. Wong 	struct xfs_attr_leaf_name_remote	*rentry;
460eec0482eSDarrick J. Wong 	struct xfs_buf			*bp;
461649d9d98SChristoph Hellwig 	struct xfs_attr_leaf_entry	*ent;
462eec0482eSDarrick J. Wong 	xfs_dahash_t			calc_hash;
463eec0482eSDarrick J. Wong 	xfs_dahash_t			hash;
464eec0482eSDarrick J. Wong 	int				nameidx;
465eec0482eSDarrick J. Wong 	int				hdrsize;
466eec0482eSDarrick J. Wong 	unsigned int			badflags;
467eec0482eSDarrick J. Wong 	int				error;
468eec0482eSDarrick J. Wong 
469649d9d98SChristoph Hellwig 	ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
470649d9d98SChristoph Hellwig 
471649d9d98SChristoph Hellwig 	ent = xfs_attr3_leaf_entryp(blk->bp->b_addr) + blk->index;
472eec0482eSDarrick J. Wong 
47313791d3bSDarrick J. Wong 	/* Check the whole block, if necessary. */
474c517b3aaSDarrick J. Wong 	error = xchk_xattr_block(ds, level);
47513791d3bSDarrick J. Wong 	if (error)
47613791d3bSDarrick J. Wong 		goto out;
47713791d3bSDarrick J. Wong 	if (ds->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
47813791d3bSDarrick J. Wong 		goto out;
47913791d3bSDarrick J. Wong 
480eec0482eSDarrick J. Wong 	/* Check the hash of the entry. */
481c517b3aaSDarrick J. Wong 	error = xchk_da_btree_hash(ds, level, &ent->hashval);
482eec0482eSDarrick J. Wong 	if (error)
483eec0482eSDarrick J. Wong 		goto out;
484eec0482eSDarrick J. Wong 
485eec0482eSDarrick J. Wong 	/* Find the attr entry's location. */
486eec0482eSDarrick J. Wong 	bp = blk->bp;
487eec0482eSDarrick J. Wong 	hdrsize = xfs_attr3_leaf_hdr_size(bp->b_addr);
488eec0482eSDarrick J. Wong 	nameidx = be16_to_cpu(ent->nameidx);
489eec0482eSDarrick J. Wong 	if (nameidx < hdrsize || nameidx >= mp->m_attr_geo->blksize) {
490c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
491eec0482eSDarrick J. Wong 		goto out;
492eec0482eSDarrick J. Wong 	}
493eec0482eSDarrick J. Wong 
494eec0482eSDarrick J. Wong 	/* Retrieve the entry and check it. */
495eec0482eSDarrick J. Wong 	hash = be32_to_cpu(ent->hashval);
496eec0482eSDarrick J. Wong 	badflags = ~(XFS_ATTR_LOCAL | XFS_ATTR_ROOT | XFS_ATTR_SECURE |
497eec0482eSDarrick J. Wong 			XFS_ATTR_INCOMPLETE);
498eec0482eSDarrick J. Wong 	if ((ent->flags & badflags) != 0)
499c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
500eec0482eSDarrick J. Wong 	if (ent->flags & XFS_ATTR_LOCAL) {
501eec0482eSDarrick J. Wong 		lentry = (struct xfs_attr_leaf_name_local *)
502eec0482eSDarrick J. Wong 				(((char *)bp->b_addr) + nameidx);
503eec0482eSDarrick J. Wong 		if (lentry->namelen <= 0) {
504c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
505eec0482eSDarrick J. Wong 			goto out;
506eec0482eSDarrick J. Wong 		}
507eec0482eSDarrick J. Wong 		calc_hash = xfs_da_hashname(lentry->nameval, lentry->namelen);
508eec0482eSDarrick J. Wong 	} else {
509eec0482eSDarrick J. Wong 		rentry = (struct xfs_attr_leaf_name_remote *)
510eec0482eSDarrick J. Wong 				(((char *)bp->b_addr) + nameidx);
511eec0482eSDarrick J. Wong 		if (rentry->namelen <= 0) {
512c517b3aaSDarrick J. Wong 			xchk_da_set_corrupt(ds, level);
513eec0482eSDarrick J. Wong 			goto out;
514eec0482eSDarrick J. Wong 		}
515eec0482eSDarrick J. Wong 		calc_hash = xfs_da_hashname(rentry->name, rentry->namelen);
516eec0482eSDarrick J. Wong 	}
517eec0482eSDarrick J. Wong 	if (calc_hash != hash)
518c517b3aaSDarrick J. Wong 		xchk_da_set_corrupt(ds, level);
519eec0482eSDarrick J. Wong 
520eec0482eSDarrick J. Wong out:
521eec0482eSDarrick J. Wong 	return error;
522eec0482eSDarrick J. Wong }
523eec0482eSDarrick J. Wong 
524ae0506ebSDarrick J. Wong /* Check space usage of shortform attrs. */
525ae0506ebSDarrick J. Wong STATIC int
xchk_xattr_check_sf(struct xfs_scrub * sc)526ae0506ebSDarrick J. Wong xchk_xattr_check_sf(
527ae0506ebSDarrick J. Wong 	struct xfs_scrub		*sc)
528ae0506ebSDarrick J. Wong {
529ae0506ebSDarrick J. Wong 	struct xchk_xattr_buf		*ab = sc->buf;
530ae0506ebSDarrick J. Wong 	struct xfs_attr_shortform	*sf;
531ae0506ebSDarrick J. Wong 	struct xfs_attr_sf_entry	*sfe;
532ae0506ebSDarrick J. Wong 	struct xfs_attr_sf_entry	*next;
533ae0506ebSDarrick J. Wong 	struct xfs_ifork		*ifp;
534ae0506ebSDarrick J. Wong 	unsigned char			*end;
535ae0506ebSDarrick J. Wong 	int				i;
536ae0506ebSDarrick J. Wong 	int				error = 0;
537ae0506ebSDarrick J. Wong 
538ae0506ebSDarrick J. Wong 	ifp = xfs_ifork_ptr(sc->ip, XFS_ATTR_FORK);
539ae0506ebSDarrick J. Wong 
540ae0506ebSDarrick J. Wong 	bitmap_zero(ab->usedmap, ifp->if_bytes);
541ae0506ebSDarrick J. Wong 	sf = (struct xfs_attr_shortform *)sc->ip->i_af.if_u1.if_data;
542ae0506ebSDarrick J. Wong 	end = (unsigned char *)ifp->if_u1.if_data + ifp->if_bytes;
543ae0506ebSDarrick J. Wong 	xchk_xattr_set_map(sc, ab->usedmap, 0, sizeof(sf->hdr));
544ae0506ebSDarrick J. Wong 
545ae0506ebSDarrick J. Wong 	sfe = &sf->list[0];
546ae0506ebSDarrick J. Wong 	if ((unsigned char *)sfe > end) {
547ae0506ebSDarrick J. Wong 		xchk_fblock_set_corrupt(sc, XFS_ATTR_FORK, 0);
548ae0506ebSDarrick J. Wong 		return 0;
549ae0506ebSDarrick J. Wong 	}
550ae0506ebSDarrick J. Wong 
551ae0506ebSDarrick J. Wong 	for (i = 0; i < sf->hdr.count; i++) {
552ae0506ebSDarrick J. Wong 		unsigned char		*name = sfe->nameval;
553ae0506ebSDarrick J. Wong 		unsigned char		*value = &sfe->nameval[sfe->namelen];
554ae0506ebSDarrick J. Wong 
555ae0506ebSDarrick J. Wong 		if (xchk_should_terminate(sc, &error))
556ae0506ebSDarrick J. Wong 			return error;
557ae0506ebSDarrick J. Wong 
558ae0506ebSDarrick J. Wong 		next = xfs_attr_sf_nextentry(sfe);
559ae0506ebSDarrick J. Wong 		if ((unsigned char *)next > end) {
560ae0506ebSDarrick J. Wong 			xchk_fblock_set_corrupt(sc, XFS_ATTR_FORK, 0);
561ae0506ebSDarrick J. Wong 			break;
562ae0506ebSDarrick J. Wong 		}
563ae0506ebSDarrick J. Wong 
564ae0506ebSDarrick J. Wong 		if (!xchk_xattr_set_map(sc, ab->usedmap,
565ae0506ebSDarrick J. Wong 				(char *)sfe - (char *)sf,
566ae0506ebSDarrick J. Wong 				sizeof(struct xfs_attr_sf_entry))) {
567ae0506ebSDarrick J. Wong 			xchk_fblock_set_corrupt(sc, XFS_ATTR_FORK, 0);
568ae0506ebSDarrick J. Wong 			break;
569ae0506ebSDarrick J. Wong 		}
570ae0506ebSDarrick J. Wong 
571ae0506ebSDarrick J. Wong 		if (!xchk_xattr_set_map(sc, ab->usedmap,
572ae0506ebSDarrick J. Wong 				(char *)name - (char *)sf,
573ae0506ebSDarrick J. Wong 				sfe->namelen)) {
574ae0506ebSDarrick J. Wong 			xchk_fblock_set_corrupt(sc, XFS_ATTR_FORK, 0);
575ae0506ebSDarrick J. Wong 			break;
576ae0506ebSDarrick J. Wong 		}
577ae0506ebSDarrick J. Wong 
578ae0506ebSDarrick J. Wong 		if (!xchk_xattr_set_map(sc, ab->usedmap,
579ae0506ebSDarrick J. Wong 				(char *)value - (char *)sf,
580ae0506ebSDarrick J. Wong 				sfe->valuelen)) {
581ae0506ebSDarrick J. Wong 			xchk_fblock_set_corrupt(sc, XFS_ATTR_FORK, 0);
582ae0506ebSDarrick J. Wong 			break;
583ae0506ebSDarrick J. Wong 		}
584ae0506ebSDarrick J. Wong 
585ae0506ebSDarrick J. Wong 		sfe = next;
586ae0506ebSDarrick J. Wong 	}
587ae0506ebSDarrick J. Wong 
588ae0506ebSDarrick J. Wong 	return 0;
589ae0506ebSDarrick J. Wong }
590ae0506ebSDarrick J. Wong 
591eec0482eSDarrick J. Wong /* Scrub the extended attribute metadata. */
592eec0482eSDarrick J. Wong int
xchk_xattr(struct xfs_scrub * sc)593c517b3aaSDarrick J. Wong xchk_xattr(
5941d8a748aSDarrick J. Wong 	struct xfs_scrub		*sc)
595eec0482eSDarrick J. Wong {
5966cee51e6SDarrick J. Wong 	struct xchk_xattr		sx = {
5976cee51e6SDarrick J. Wong 		.sc			= sc,
5986cee51e6SDarrick J. Wong 		.context		= {
5996cee51e6SDarrick J. Wong 			.dp		= sc->ip,
6006cee51e6SDarrick J. Wong 			.tp		= sc->tp,
6016cee51e6SDarrick J. Wong 			.resynch	= 1,
6026cee51e6SDarrick J. Wong 			.put_listent	= xchk_xattr_listent,
6036cee51e6SDarrick J. Wong 			.allow_incomplete = true,
6046cee51e6SDarrick J. Wong 		},
6056cee51e6SDarrick J. Wong 	};
60613791d3bSDarrick J. Wong 	xfs_dablk_t			last_checked = -1U;
607eec0482eSDarrick J. Wong 	int				error = 0;
608eec0482eSDarrick J. Wong 
609eec0482eSDarrick J. Wong 	if (!xfs_inode_hasattr(sc->ip))
610eec0482eSDarrick J. Wong 		return -ENOENT;
611eec0482eSDarrick J. Wong 
6125b02a3e8SDarrick J. Wong 	/* Allocate memory for xattr checking. */
6135b02a3e8SDarrick J. Wong 	error = xchk_setup_xattr_buf(sc, 0);
6145b02a3e8SDarrick J. Wong 	if (error == -ENOMEM)
6155b02a3e8SDarrick J. Wong 		return -EDEADLOCK;
6165b02a3e8SDarrick J. Wong 	if (error)
6175b02a3e8SDarrick J. Wong 		return error;
6185b02a3e8SDarrick J. Wong 
619ae0506ebSDarrick J. Wong 	/* Check the physical structure of the xattr. */
620ae0506ebSDarrick J. Wong 	if (sc->ip->i_af.if_format == XFS_DINODE_FMT_LOCAL)
621ae0506ebSDarrick J. Wong 		error = xchk_xattr_check_sf(sc);
622ae0506ebSDarrick J. Wong 	else
623c517b3aaSDarrick J. Wong 		error = xchk_da_btree(sc, XFS_ATTR_FORK, xchk_xattr_rec,
62413791d3bSDarrick J. Wong 				&last_checked);
625eec0482eSDarrick J. Wong 	if (error)
6266cee51e6SDarrick J. Wong 		return error;
627eec0482eSDarrick J. Wong 
628eec0482eSDarrick J. Wong 	if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
6296cee51e6SDarrick J. Wong 		return 0;
630eec0482eSDarrick J. Wong 
631eec0482eSDarrick J. Wong 	/*
6326cee51e6SDarrick J. Wong 	 * Look up every xattr in this file by name and hash.
633eec0482eSDarrick J. Wong 	 *
634eec0482eSDarrick J. Wong 	 * Use the backend implementation of xfs_attr_list to call
635c517b3aaSDarrick J. Wong 	 * xchk_xattr_listent on every attribute key in this inode.
636eec0482eSDarrick J. Wong 	 * In other words, we use the same iterator/callback mechanism
637eec0482eSDarrick J. Wong 	 * that listattr uses to scrub extended attributes, though in our
638eec0482eSDarrick J. Wong 	 * _listent function, we check the value of the attribute.
639eec0482eSDarrick J. Wong 	 *
640eec0482eSDarrick J. Wong 	 * The VFS only locks i_rwsem when modifying attrs, so keep all
641eec0482eSDarrick J. Wong 	 * three locks held because that's the only way to ensure we're
642eec0482eSDarrick J. Wong 	 * the only thread poking into the da btree.  We traverse the da
643eec0482eSDarrick J. Wong 	 * btree while holding a leaf buffer locked for the xattr name
644eec0482eSDarrick J. Wong 	 * iteration, which doesn't really follow the usual buffer
645eec0482eSDarrick J. Wong 	 * locking order.
646eec0482eSDarrick J. Wong 	 */
64717e1dd83SChristoph Hellwig 	error = xfs_attr_list_ilocked(&sx.context);
648c517b3aaSDarrick J. Wong 	if (!xchk_fblock_process_error(sc, XFS_ATTR_FORK, 0, &error))
6496cee51e6SDarrick J. Wong 		return error;
6502c3b83d7SDarrick J. Wong 
6512c3b83d7SDarrick J. Wong 	/* Did our listent function try to return any errors? */
6522c3b83d7SDarrick J. Wong 	if (sx.context.seen_enough < 0)
6536cee51e6SDarrick J. Wong 		return sx.context.seen_enough;
6546cee51e6SDarrick J. Wong 
6556cee51e6SDarrick J. Wong 	return 0;
656eec0482eSDarrick J. Wong }
657