xref: /openbmc/linux/fs/overlayfs/namei.c (revision d2912cb1)
1d2912cb1SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
2bbb1e54dSMiklos Szeredi /*
3bbb1e54dSMiklos Szeredi  * Copyright (C) 2011 Novell Inc.
4bbb1e54dSMiklos Szeredi  * Copyright (C) 2016 Red Hat, Inc.
5bbb1e54dSMiklos Szeredi  */
6bbb1e54dSMiklos Szeredi 
7bbb1e54dSMiklos Szeredi #include <linux/fs.h>
85b825c3aSIngo Molnar #include <linux/cred.h>
99ee60ce2SAmir Goldstein #include <linux/ctype.h>
10bbb1e54dSMiklos Szeredi #include <linux/namei.h>
11bbb1e54dSMiklos Szeredi #include <linux/xattr.h>
1202b69b28SMiklos Szeredi #include <linux/ratelimit.h>
13a9d01957SAmir Goldstein #include <linux/mount.h>
14a9d01957SAmir Goldstein #include <linux/exportfs.h>
15bbb1e54dSMiklos Szeredi #include "overlayfs.h"
16bbb1e54dSMiklos Szeredi 
17e28edc46SMiklos Szeredi struct ovl_lookup_data {
18146d62e5SAmir Goldstein 	struct super_block *sb;
19e28edc46SMiklos Szeredi 	struct qstr name;
20e28edc46SMiklos Szeredi 	bool is_dir;
21e28edc46SMiklos Szeredi 	bool opaque;
22e28edc46SMiklos Szeredi 	bool stop;
23e28edc46SMiklos Szeredi 	bool last;
2402b69b28SMiklos Szeredi 	char *redirect;
259d3dfea3SVivek Goyal 	bool metacopy;
26e28edc46SMiklos Szeredi };
27bbb1e54dSMiklos Szeredi 
2802b69b28SMiklos Szeredi static int ovl_check_redirect(struct dentry *dentry, struct ovl_lookup_data *d,
2902b69b28SMiklos Szeredi 			      size_t prelen, const char *post)
3002b69b28SMiklos Szeredi {
3102b69b28SMiklos Szeredi 	int res;
320a2d0d3fSVivek Goyal 	char *buf;
3302b69b28SMiklos Szeredi 
340a2d0d3fSVivek Goyal 	buf = ovl_get_redirect_xattr(dentry, prelen + strlen(post));
350a2d0d3fSVivek Goyal 	if (IS_ERR_OR_NULL(buf))
360a2d0d3fSVivek Goyal 		return PTR_ERR(buf);
3702b69b28SMiklos Szeredi 
3802b69b28SMiklos Szeredi 	if (buf[0] == '/') {
393ec9b3faSAmir Goldstein 		/*
403ec9b3faSAmir Goldstein 		 * One of the ancestor path elements in an absolute path
413ec9b3faSAmir Goldstein 		 * lookup in ovl_lookup_layer() could have been opaque and
423ec9b3faSAmir Goldstein 		 * that will stop further lookup in lower layers (d->stop=true)
433ec9b3faSAmir Goldstein 		 * But we have found an absolute redirect in decendant path
443ec9b3faSAmir Goldstein 		 * element and that should force continue lookup in lower
453ec9b3faSAmir Goldstein 		 * layers (reset d->stop).
463ec9b3faSAmir Goldstein 		 */
473ec9b3faSAmir Goldstein 		d->stop = false;
4802b69b28SMiklos Szeredi 	} else {
490a2d0d3fSVivek Goyal 		res = strlen(buf) + 1;
5002b69b28SMiklos Szeredi 		memmove(buf + prelen, buf, res);
5102b69b28SMiklos Szeredi 		memcpy(buf, d->name.name, prelen);
5202b69b28SMiklos Szeredi 	}
5302b69b28SMiklos Szeredi 
5402b69b28SMiklos Szeredi 	strcat(buf, post);
5502b69b28SMiklos Szeredi 	kfree(d->redirect);
5602b69b28SMiklos Szeredi 	d->redirect = buf;
5702b69b28SMiklos Szeredi 	d->name.name = d->redirect;
5802b69b28SMiklos Szeredi 	d->name.len = strlen(d->redirect);
5902b69b28SMiklos Szeredi 
6002b69b28SMiklos Szeredi 	return 0;
6102b69b28SMiklos Szeredi }
6202b69b28SMiklos Szeredi 
63a9d01957SAmir Goldstein static int ovl_acceptable(void *ctx, struct dentry *dentry)
64a9d01957SAmir Goldstein {
65e8f9e5b7SAmir Goldstein 	/*
66e8f9e5b7SAmir Goldstein 	 * A non-dir origin may be disconnected, which is fine, because
67e8f9e5b7SAmir Goldstein 	 * we only need it for its unique inode number.
68e8f9e5b7SAmir Goldstein 	 */
69e8f9e5b7SAmir Goldstein 	if (!d_is_dir(dentry))
70a9d01957SAmir Goldstein 		return 1;
71e8f9e5b7SAmir Goldstein 
72e8f9e5b7SAmir Goldstein 	/* Don't decode a deleted empty directory */
73e8f9e5b7SAmir Goldstein 	if (d_unhashed(dentry))
74e8f9e5b7SAmir Goldstein 		return 0;
75e8f9e5b7SAmir Goldstein 
76e8f9e5b7SAmir Goldstein 	/* Check if directory belongs to the layer we are decoding from */
77e8f9e5b7SAmir Goldstein 	return is_subdir(dentry, ((struct vfsmount *)ctx)->mnt_root);
78a9d01957SAmir Goldstein }
79a9d01957SAmir Goldstein 
802e1a5328SAmir Goldstein /*
812e1a5328SAmir Goldstein  * Check validity of an overlay file handle buffer.
822e1a5328SAmir Goldstein  *
832e1a5328SAmir Goldstein  * Return 0 for a valid file handle.
842e1a5328SAmir Goldstein  * Return -ENODATA for "origin unknown".
852e1a5328SAmir Goldstein  * Return <0 for an invalid file handle.
862e1a5328SAmir Goldstein  */
878556a420SAmir Goldstein int ovl_check_fh_len(struct ovl_fh *fh, int fh_len)
882e1a5328SAmir Goldstein {
892e1a5328SAmir Goldstein 	if (fh_len < sizeof(struct ovl_fh) || fh_len < fh->len)
902e1a5328SAmir Goldstein 		return -EINVAL;
912e1a5328SAmir Goldstein 
922e1a5328SAmir Goldstein 	if (fh->magic != OVL_FH_MAGIC)
932e1a5328SAmir Goldstein 		return -EINVAL;
942e1a5328SAmir Goldstein 
952e1a5328SAmir Goldstein 	/* Treat larger version and unknown flags as "origin unknown" */
962e1a5328SAmir Goldstein 	if (fh->version > OVL_FH_VERSION || fh->flags & ~OVL_FH_FLAG_ALL)
972e1a5328SAmir Goldstein 		return -ENODATA;
982e1a5328SAmir Goldstein 
992e1a5328SAmir Goldstein 	/* Treat endianness mismatch as "origin unknown" */
1002e1a5328SAmir Goldstein 	if (!(fh->flags & OVL_FH_FLAG_ANY_ENDIAN) &&
1012e1a5328SAmir Goldstein 	    (fh->flags & OVL_FH_FLAG_BIG_ENDIAN) != OVL_FH_FLAG_CPU_ENDIAN)
1022e1a5328SAmir Goldstein 		return -ENODATA;
1032e1a5328SAmir Goldstein 
1042e1a5328SAmir Goldstein 	return 0;
1052e1a5328SAmir Goldstein }
1062e1a5328SAmir Goldstein 
10705122443SAmir Goldstein static struct ovl_fh *ovl_get_fh(struct dentry *dentry, const char *name)
108a9d01957SAmir Goldstein {
1092e1a5328SAmir Goldstein 	int res, err;
110a9d01957SAmir Goldstein 	struct ovl_fh *fh = NULL;
111a9d01957SAmir Goldstein 
11205122443SAmir Goldstein 	res = vfs_getxattr(dentry, name, NULL, 0);
113a9d01957SAmir Goldstein 	if (res < 0) {
114a9d01957SAmir Goldstein 		if (res == -ENODATA || res == -EOPNOTSUPP)
115a9d01957SAmir Goldstein 			return NULL;
116a9d01957SAmir Goldstein 		goto fail;
117a9d01957SAmir Goldstein 	}
118a9d01957SAmir Goldstein 	/* Zero size value means "copied up but origin unknown" */
119a9d01957SAmir Goldstein 	if (res == 0)
120a9d01957SAmir Goldstein 		return NULL;
121a9d01957SAmir Goldstein 
1220ee931c4SMichal Hocko 	fh = kzalloc(res, GFP_KERNEL);
123a9d01957SAmir Goldstein 	if (!fh)
124a9d01957SAmir Goldstein 		return ERR_PTR(-ENOMEM);
125a9d01957SAmir Goldstein 
12605122443SAmir Goldstein 	res = vfs_getxattr(dentry, name, fh, res);
127a9d01957SAmir Goldstein 	if (res < 0)
128a9d01957SAmir Goldstein 		goto fail;
129a9d01957SAmir Goldstein 
1302e1a5328SAmir Goldstein 	err = ovl_check_fh_len(fh, res);
1312e1a5328SAmir Goldstein 	if (err < 0) {
1322e1a5328SAmir Goldstein 		if (err == -ENODATA)
133a9d01957SAmir Goldstein 			goto out;
1342e1a5328SAmir Goldstein 		goto invalid;
1352e1a5328SAmir Goldstein 	}
136a9d01957SAmir Goldstein 
1378b88a2e6SAmir Goldstein 	return fh;
1388b88a2e6SAmir Goldstein 
1398b88a2e6SAmir Goldstein out:
1408b88a2e6SAmir Goldstein 	kfree(fh);
1418b88a2e6SAmir Goldstein 	return NULL;
1428b88a2e6SAmir Goldstein 
1438b88a2e6SAmir Goldstein fail:
1448b88a2e6SAmir Goldstein 	pr_warn_ratelimited("overlayfs: failed to get origin (%i)\n", res);
1458b88a2e6SAmir Goldstein 	goto out;
1468b88a2e6SAmir Goldstein invalid:
1478b88a2e6SAmir Goldstein 	pr_warn_ratelimited("overlayfs: invalid origin (%*phN)\n", res, fh);
1488b88a2e6SAmir Goldstein 	goto out;
1498b88a2e6SAmir Goldstein }
1508b88a2e6SAmir Goldstein 
1518a22efa1SAmir Goldstein struct dentry *ovl_decode_real_fh(struct ovl_fh *fh, struct vfsmount *mnt,
1528a22efa1SAmir Goldstein 				  bool connected)
1538b88a2e6SAmir Goldstein {
154e8f9e5b7SAmir Goldstein 	struct dentry *real;
1558b88a2e6SAmir Goldstein 	int bytes;
1568b88a2e6SAmir Goldstein 
157a9d01957SAmir Goldstein 	/*
158a9d01957SAmir Goldstein 	 * Make sure that the stored uuid matches the uuid of the lower
159a9d01957SAmir Goldstein 	 * layer where file handle will be decoded.
160a9d01957SAmir Goldstein 	 */
16185787090SChristoph Hellwig 	if (!uuid_equal(&fh->uuid, &mnt->mnt_sb->s_uuid))
1622e1a5328SAmir Goldstein 		return NULL;
163a9d01957SAmir Goldstein 
1648b88a2e6SAmir Goldstein 	bytes = (fh->len - offsetof(struct ovl_fh, fid));
165e8f9e5b7SAmir Goldstein 	real = exportfs_decode_fh(mnt, (struct fid *)fh->fid,
166a9d01957SAmir Goldstein 				  bytes >> 2, (int)fh->type,
1678a22efa1SAmir Goldstein 				  connected ? ovl_acceptable : NULL, mnt);
168e8f9e5b7SAmir Goldstein 	if (IS_ERR(real)) {
169e8f9e5b7SAmir Goldstein 		/*
170e8f9e5b7SAmir Goldstein 		 * Treat stale file handle to lower file as "origin unknown".
171e8f9e5b7SAmir Goldstein 		 * upper file handle could become stale when upper file is
172e8f9e5b7SAmir Goldstein 		 * unlinked and this information is needed to handle stale
173e8f9e5b7SAmir Goldstein 		 * index entries correctly.
174e8f9e5b7SAmir Goldstein 		 */
175e8f9e5b7SAmir Goldstein 		if (real == ERR_PTR(-ESTALE) &&
176e8f9e5b7SAmir Goldstein 		    !(fh->flags & OVL_FH_FLAG_PATH_UPPER))
177e8f9e5b7SAmir Goldstein 			real = NULL;
178e8f9e5b7SAmir Goldstein 		return real;
179a9d01957SAmir Goldstein 	}
180a9d01957SAmir Goldstein 
181e8f9e5b7SAmir Goldstein 	if (ovl_dentry_weird(real)) {
182e8f9e5b7SAmir Goldstein 		dput(real);
1832e1a5328SAmir Goldstein 		return NULL;
1842e1a5328SAmir Goldstein 	}
1852e1a5328SAmir Goldstein 
186e8f9e5b7SAmir Goldstein 	return real;
187a9d01957SAmir Goldstein }
188a9d01957SAmir Goldstein 
189ee1d6d37SAmir Goldstein static bool ovl_is_opaquedir(struct dentry *dentry)
190ee1d6d37SAmir Goldstein {
191ee1d6d37SAmir Goldstein 	return ovl_check_dir_xattr(dentry, OVL_XATTR_OPAQUE);
192ee1d6d37SAmir Goldstein }
193ee1d6d37SAmir Goldstein 
194e28edc46SMiklos Szeredi static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
195e28edc46SMiklos Szeredi 			     const char *name, unsigned int namelen,
19602b69b28SMiklos Szeredi 			     size_t prelen, const char *post,
197e28edc46SMiklos Szeredi 			     struct dentry **ret)
198e28edc46SMiklos Szeredi {
199e28edc46SMiklos Szeredi 	struct dentry *this;
200e28edc46SMiklos Szeredi 	int err;
201102b0d11SVivek Goyal 	bool last_element = !post[0];
202e28edc46SMiklos Szeredi 
203e28edc46SMiklos Szeredi 	this = lookup_one_len_unlocked(name, base, namelen);
204e28edc46SMiklos Szeredi 	if (IS_ERR(this)) {
205e28edc46SMiklos Szeredi 		err = PTR_ERR(this);
206e28edc46SMiklos Szeredi 		this = NULL;
207e28edc46SMiklos Szeredi 		if (err == -ENOENT || err == -ENAMETOOLONG)
208e28edc46SMiklos Szeredi 			goto out;
209e28edc46SMiklos Szeredi 		goto out_err;
210e28edc46SMiklos Szeredi 	}
211e28edc46SMiklos Szeredi 	if (!this->d_inode)
212e28edc46SMiklos Szeredi 		goto put_and_out;
213e28edc46SMiklos Szeredi 
214e28edc46SMiklos Szeredi 	if (ovl_dentry_weird(this)) {
215e28edc46SMiklos Szeredi 		/* Don't support traversing automounts and other weirdness */
216e28edc46SMiklos Szeredi 		err = -EREMOTE;
217e28edc46SMiklos Szeredi 		goto out_err;
218e28edc46SMiklos Szeredi 	}
219e28edc46SMiklos Szeredi 	if (ovl_is_whiteout(this)) {
220e28edc46SMiklos Szeredi 		d->stop = d->opaque = true;
221e28edc46SMiklos Szeredi 		goto put_and_out;
222e28edc46SMiklos Szeredi 	}
2233a291774SMiklos Szeredi 	/*
2249d3dfea3SVivek Goyal 	 * This dentry should be a regular file if previous layer lookup
2259d3dfea3SVivek Goyal 	 * found a metacopy dentry.
2263a291774SMiklos Szeredi 	 */
2279d3dfea3SVivek Goyal 	if (last_element && d->metacopy && !d_is_reg(this)) {
2289d3dfea3SVivek Goyal 		d->stop = true;
2299d3dfea3SVivek Goyal 		goto put_and_out;
2309d3dfea3SVivek Goyal 	}
2319d3dfea3SVivek Goyal 	if (!d_can_lookup(this)) {
2329d3dfea3SVivek Goyal 		if (d->is_dir || !last_element) {
2339d3dfea3SVivek Goyal 			d->stop = true;
2349d3dfea3SVivek Goyal 			goto put_and_out;
2359d3dfea3SVivek Goyal 		}
2369d3dfea3SVivek Goyal 		err = ovl_check_metacopy_xattr(this);
2379d3dfea3SVivek Goyal 		if (err < 0)
2389d3dfea3SVivek Goyal 			goto out_err;
2399d3dfea3SVivek Goyal 
2409d3dfea3SVivek Goyal 		d->metacopy = err;
2419d3dfea3SVivek Goyal 		d->stop = !d->metacopy;
242b8a8824cSVivek Goyal 		if (!d->metacopy || d->last)
243e28edc46SMiklos Szeredi 			goto out;
2440618a816SVivek Goyal 	} else {
245146d62e5SAmir Goldstein 		if (ovl_lookup_trap_inode(d->sb, this)) {
246146d62e5SAmir Goldstein 			/* Caught in a trap of overlapping layers */
247146d62e5SAmir Goldstein 			err = -ELOOP;
248146d62e5SAmir Goldstein 			goto out_err;
249146d62e5SAmir Goldstein 		}
250146d62e5SAmir Goldstein 
251102b0d11SVivek Goyal 		if (last_element)
252e28edc46SMiklos Szeredi 			d->is_dir = true;
253e9b77f90SVivek Goyal 		if (d->last)
254e9b77f90SVivek Goyal 			goto out;
255e9b77f90SVivek Goyal 
256e9b77f90SVivek Goyal 		if (ovl_is_opaquedir(this)) {
257102b0d11SVivek Goyal 			d->stop = true;
258102b0d11SVivek Goyal 			if (last_element)
259102b0d11SVivek Goyal 				d->opaque = true;
260e28edc46SMiklos Szeredi 			goto out;
261e28edc46SMiklos Szeredi 		}
2620618a816SVivek Goyal 	}
26302b69b28SMiklos Szeredi 	err = ovl_check_redirect(this, d, prelen, post);
26402b69b28SMiklos Szeredi 	if (err)
26502b69b28SMiklos Szeredi 		goto out_err;
266e28edc46SMiklos Szeredi out:
267e28edc46SMiklos Szeredi 	*ret = this;
268e28edc46SMiklos Szeredi 	return 0;
269e28edc46SMiklos Szeredi 
270e28edc46SMiklos Szeredi put_and_out:
271e28edc46SMiklos Szeredi 	dput(this);
272e28edc46SMiklos Szeredi 	this = NULL;
273e28edc46SMiklos Szeredi 	goto out;
274e28edc46SMiklos Szeredi 
275e28edc46SMiklos Szeredi out_err:
276e28edc46SMiklos Szeredi 	dput(this);
277e28edc46SMiklos Szeredi 	return err;
278e28edc46SMiklos Szeredi }
279e28edc46SMiklos Szeredi 
280e28edc46SMiklos Szeredi static int ovl_lookup_layer(struct dentry *base, struct ovl_lookup_data *d,
281e28edc46SMiklos Szeredi 			    struct dentry **ret)
282e28edc46SMiklos Szeredi {
2834c7d0c9cSAmir Goldstein 	/* Counting down from the end, since the prefix can change */
2844c7d0c9cSAmir Goldstein 	size_t rem = d->name.len - 1;
28502b69b28SMiklos Szeredi 	struct dentry *dentry = NULL;
28602b69b28SMiklos Szeredi 	int err;
28702b69b28SMiklos Szeredi 
2884c7d0c9cSAmir Goldstein 	if (d->name.name[0] != '/')
28902b69b28SMiklos Szeredi 		return ovl_lookup_single(base, d, d->name.name, d->name.len,
29002b69b28SMiklos Szeredi 					 0, "", ret);
29102b69b28SMiklos Szeredi 
2924c7d0c9cSAmir Goldstein 	while (!IS_ERR_OR_NULL(base) && d_can_lookup(base)) {
2934c7d0c9cSAmir Goldstein 		const char *s = d->name.name + d->name.len - rem;
29402b69b28SMiklos Szeredi 		const char *next = strchrnul(s, '/');
2954c7d0c9cSAmir Goldstein 		size_t thislen = next - s;
2964c7d0c9cSAmir Goldstein 		bool end = !next[0];
29702b69b28SMiklos Szeredi 
2984c7d0c9cSAmir Goldstein 		/* Verify we did not go off the rails */
2994c7d0c9cSAmir Goldstein 		if (WARN_ON(s[-1] != '/'))
30002b69b28SMiklos Szeredi 			return -EIO;
30102b69b28SMiklos Szeredi 
3024c7d0c9cSAmir Goldstein 		err = ovl_lookup_single(base, d, s, thislen,
3034c7d0c9cSAmir Goldstein 					d->name.len - rem, next, &base);
30402b69b28SMiklos Szeredi 		dput(dentry);
30502b69b28SMiklos Szeredi 		if (err)
30602b69b28SMiklos Szeredi 			return err;
30702b69b28SMiklos Szeredi 		dentry = base;
3084c7d0c9cSAmir Goldstein 		if (end)
3094c7d0c9cSAmir Goldstein 			break;
3104c7d0c9cSAmir Goldstein 
3114c7d0c9cSAmir Goldstein 		rem -= thislen + 1;
3124c7d0c9cSAmir Goldstein 
3134c7d0c9cSAmir Goldstein 		if (WARN_ON(rem >= d->name.len))
3144c7d0c9cSAmir Goldstein 			return -EIO;
31502b69b28SMiklos Szeredi 	}
31602b69b28SMiklos Szeredi 	*ret = dentry;
31702b69b28SMiklos Szeredi 	return 0;
318e28edc46SMiklos Szeredi }
319e28edc46SMiklos Szeredi 
320a9d01957SAmir Goldstein 
3218a22efa1SAmir Goldstein int ovl_check_origin_fh(struct ovl_fs *ofs, struct ovl_fh *fh, bool connected,
322f941866fSAmir Goldstein 			struct dentry *upperdentry, struct ovl_path **stackp)
323a9d01957SAmir Goldstein {
324f7d3dacaSAmir Goldstein 	struct dentry *origin = NULL;
325f7d3dacaSAmir Goldstein 	int i;
326a9d01957SAmir Goldstein 
3271eff1a1dSAmir Goldstein 	for (i = 0; i < ofs->numlower; i++) {
3288a22efa1SAmir Goldstein 		origin = ovl_decode_real_fh(fh, ofs->lower_layers[i].mnt,
3298a22efa1SAmir Goldstein 					    connected);
330f7d3dacaSAmir Goldstein 		if (origin)
331f7d3dacaSAmir Goldstein 			break;
332f7d3dacaSAmir Goldstein 	}
333f7d3dacaSAmir Goldstein 
334f7d3dacaSAmir Goldstein 	if (!origin)
3352e1a5328SAmir Goldstein 		return -ESTALE;
3362e1a5328SAmir Goldstein 	else if (IS_ERR(origin))
3372e1a5328SAmir Goldstein 		return PTR_ERR(origin);
338f7d3dacaSAmir Goldstein 
339f941866fSAmir Goldstein 	if (upperdentry && !ovl_is_whiteout(upperdentry) &&
3402e1a5328SAmir Goldstein 	    ((d_inode(origin)->i_mode ^ d_inode(upperdentry)->i_mode) & S_IFMT))
3412e1a5328SAmir Goldstein 		goto invalid;
3422e1a5328SAmir Goldstein 
343415543d5SAmir Goldstein 	if (!*stackp)
344b9343632SChandan Rajendra 		*stackp = kmalloc(sizeof(struct ovl_path), GFP_KERNEL);
345a9d01957SAmir Goldstein 	if (!*stackp) {
346a9d01957SAmir Goldstein 		dput(origin);
347a9d01957SAmir Goldstein 		return -ENOMEM;
348a9d01957SAmir Goldstein 	}
3491eff1a1dSAmir Goldstein 	**stackp = (struct ovl_path){
3501eff1a1dSAmir Goldstein 		.dentry = origin,
3511eff1a1dSAmir Goldstein 		.layer = &ofs->lower_layers[i]
3521eff1a1dSAmir Goldstein 	};
353a9d01957SAmir Goldstein 
354a9d01957SAmir Goldstein 	return 0;
3552e1a5328SAmir Goldstein 
3562e1a5328SAmir Goldstein invalid:
3572e1a5328SAmir Goldstein 	pr_warn_ratelimited("overlayfs: invalid origin (%pd2, ftype=%x, origin ftype=%x).\n",
3582e1a5328SAmir Goldstein 			    upperdentry, d_inode(upperdentry)->i_mode & S_IFMT,
3592e1a5328SAmir Goldstein 			    d_inode(origin)->i_mode & S_IFMT);
3602e1a5328SAmir Goldstein 	dput(origin);
3612e1a5328SAmir Goldstein 	return -EIO;
3622e1a5328SAmir Goldstein }
3632e1a5328SAmir Goldstein 
3641eff1a1dSAmir Goldstein static int ovl_check_origin(struct ovl_fs *ofs, struct dentry *upperdentry,
3652e1a5328SAmir Goldstein 			    struct ovl_path **stackp, unsigned int *ctrp)
3662e1a5328SAmir Goldstein {
36705122443SAmir Goldstein 	struct ovl_fh *fh = ovl_get_fh(upperdentry, OVL_XATTR_ORIGIN);
3682e1a5328SAmir Goldstein 	int err;
3692e1a5328SAmir Goldstein 
3702e1a5328SAmir Goldstein 	if (IS_ERR_OR_NULL(fh))
3712e1a5328SAmir Goldstein 		return PTR_ERR(fh);
3722e1a5328SAmir Goldstein 
3738a22efa1SAmir Goldstein 	err = ovl_check_origin_fh(ofs, fh, false, upperdentry, stackp);
3742e1a5328SAmir Goldstein 	kfree(fh);
3752e1a5328SAmir Goldstein 
3762e1a5328SAmir Goldstein 	if (err) {
3772e1a5328SAmir Goldstein 		if (err == -ESTALE)
3782e1a5328SAmir Goldstein 			return 0;
3792e1a5328SAmir Goldstein 		return err;
3802e1a5328SAmir Goldstein 	}
3812e1a5328SAmir Goldstein 
3822e1a5328SAmir Goldstein 	if (WARN_ON(*ctrp))
3832e1a5328SAmir Goldstein 		return -EIO;
3842e1a5328SAmir Goldstein 
3852e1a5328SAmir Goldstein 	*ctrp = 1;
3862e1a5328SAmir Goldstein 	return 0;
387a9d01957SAmir Goldstein }
388a9d01957SAmir Goldstein 
389bbb1e54dSMiklos Szeredi /*
39005122443SAmir Goldstein  * Verify that @fh matches the file handle stored in xattr @name.
3918b88a2e6SAmir Goldstein  * Return 0 on match, -ESTALE on mismatch, < 0 on error.
3928b88a2e6SAmir Goldstein  */
39305122443SAmir Goldstein static int ovl_verify_fh(struct dentry *dentry, const char *name,
39405122443SAmir Goldstein 			 const struct ovl_fh *fh)
3958b88a2e6SAmir Goldstein {
39605122443SAmir Goldstein 	struct ovl_fh *ofh = ovl_get_fh(dentry, name);
3978b88a2e6SAmir Goldstein 	int err = 0;
3988b88a2e6SAmir Goldstein 
3998b88a2e6SAmir Goldstein 	if (!ofh)
4008b88a2e6SAmir Goldstein 		return -ENODATA;
4018b88a2e6SAmir Goldstein 
4028b88a2e6SAmir Goldstein 	if (IS_ERR(ofh))
4038b88a2e6SAmir Goldstein 		return PTR_ERR(ofh);
4048b88a2e6SAmir Goldstein 
4058b88a2e6SAmir Goldstein 	if (fh->len != ofh->len || memcmp(fh, ofh, fh->len))
4068b88a2e6SAmir Goldstein 		err = -ESTALE;
4078b88a2e6SAmir Goldstein 
4088b88a2e6SAmir Goldstein 	kfree(ofh);
4098b88a2e6SAmir Goldstein 	return err;
4108b88a2e6SAmir Goldstein }
4118b88a2e6SAmir Goldstein 
4128b88a2e6SAmir Goldstein /*
41305122443SAmir Goldstein  * Verify that @real dentry matches the file handle stored in xattr @name.
4148b88a2e6SAmir Goldstein  *
41505122443SAmir Goldstein  * If @set is true and there is no stored file handle, encode @real and store
41605122443SAmir Goldstein  * file handle in xattr @name.
4178b88a2e6SAmir Goldstein  *
41805122443SAmir Goldstein  * Return 0 on match, -ESTALE on mismatch, -ENODATA on no xattr, < 0 on error.
4198b88a2e6SAmir Goldstein  */
42005122443SAmir Goldstein int ovl_verify_set_fh(struct dentry *dentry, const char *name,
42105122443SAmir Goldstein 		      struct dentry *real, bool is_upper, bool set)
4228b88a2e6SAmir Goldstein {
4238b88a2e6SAmir Goldstein 	struct inode *inode;
4248b88a2e6SAmir Goldstein 	struct ovl_fh *fh;
4258b88a2e6SAmir Goldstein 	int err;
4268b88a2e6SAmir Goldstein 
4275b2cccd3SAmir Goldstein 	fh = ovl_encode_real_fh(real, is_upper);
4288b88a2e6SAmir Goldstein 	err = PTR_ERR(fh);
429babf4770SAmir Goldstein 	if (IS_ERR(fh)) {
430babf4770SAmir Goldstein 		fh = NULL;
4318b88a2e6SAmir Goldstein 		goto fail;
432babf4770SAmir Goldstein 	}
4338b88a2e6SAmir Goldstein 
43405122443SAmir Goldstein 	err = ovl_verify_fh(dentry, name, fh);
4358b88a2e6SAmir Goldstein 	if (set && err == -ENODATA)
43605122443SAmir Goldstein 		err = ovl_do_setxattr(dentry, name, fh, fh->len, 0);
4378b88a2e6SAmir Goldstein 	if (err)
4388b88a2e6SAmir Goldstein 		goto fail;
4398b88a2e6SAmir Goldstein 
4408b88a2e6SAmir Goldstein out:
4418b88a2e6SAmir Goldstein 	kfree(fh);
4428b88a2e6SAmir Goldstein 	return err;
4438b88a2e6SAmir Goldstein 
4448b88a2e6SAmir Goldstein fail:
44505122443SAmir Goldstein 	inode = d_inode(real);
44605122443SAmir Goldstein 	pr_warn_ratelimited("overlayfs: failed to verify %s (%pd2, ino=%lu, err=%i)\n",
44705122443SAmir Goldstein 			    is_upper ? "upper" : "origin", real,
44805122443SAmir Goldstein 			    inode ? inode->i_ino : 0, err);
4498b88a2e6SAmir Goldstein 	goto out;
4508b88a2e6SAmir Goldstein }
4518b88a2e6SAmir Goldstein 
452e8f9e5b7SAmir Goldstein /* Get upper dentry from index */
4533b0bfc6eSAmir Goldstein struct dentry *ovl_index_upper(struct ovl_fs *ofs, struct dentry *index)
454e8f9e5b7SAmir Goldstein {
455e8f9e5b7SAmir Goldstein 	struct ovl_fh *fh;
456e8f9e5b7SAmir Goldstein 	struct dentry *upper;
457e8f9e5b7SAmir Goldstein 
458e8f9e5b7SAmir Goldstein 	if (!d_is_dir(index))
459e8f9e5b7SAmir Goldstein 		return dget(index);
460e8f9e5b7SAmir Goldstein 
461e8f9e5b7SAmir Goldstein 	fh = ovl_get_fh(index, OVL_XATTR_UPPER);
462e8f9e5b7SAmir Goldstein 	if (IS_ERR_OR_NULL(fh))
463e8f9e5b7SAmir Goldstein 		return ERR_CAST(fh);
464e8f9e5b7SAmir Goldstein 
4658a22efa1SAmir Goldstein 	upper = ovl_decode_real_fh(fh, ofs->upper_mnt, true);
466e8f9e5b7SAmir Goldstein 	kfree(fh);
467e8f9e5b7SAmir Goldstein 
468e8f9e5b7SAmir Goldstein 	if (IS_ERR_OR_NULL(upper))
469e8f9e5b7SAmir Goldstein 		return upper ?: ERR_PTR(-ESTALE);
470e8f9e5b7SAmir Goldstein 
471e8f9e5b7SAmir Goldstein 	if (!d_is_dir(upper)) {
472e8f9e5b7SAmir Goldstein 		pr_warn_ratelimited("overlayfs: invalid index upper (%pd2, upper=%pd2).\n",
473e8f9e5b7SAmir Goldstein 				    index, upper);
474e8f9e5b7SAmir Goldstein 		dput(upper);
475e8f9e5b7SAmir Goldstein 		return ERR_PTR(-EIO);
476e8f9e5b7SAmir Goldstein 	}
477e8f9e5b7SAmir Goldstein 
478e8f9e5b7SAmir Goldstein 	return upper;
479e8f9e5b7SAmir Goldstein }
480e8f9e5b7SAmir Goldstein 
4819ee60ce2SAmir Goldstein /* Is this a leftover from create/whiteout of directory index entry? */
4829ee60ce2SAmir Goldstein static bool ovl_is_temp_index(struct dentry *index)
4839ee60ce2SAmir Goldstein {
4849ee60ce2SAmir Goldstein 	return index->d_name.name[0] == '#';
4859ee60ce2SAmir Goldstein }
4869ee60ce2SAmir Goldstein 
4878b88a2e6SAmir Goldstein /*
488415543d5SAmir Goldstein  * Verify that an index entry name matches the origin file handle stored in
489415543d5SAmir Goldstein  * OVL_XATTR_ORIGIN and that origin file handle can be decoded to lower path.
490415543d5SAmir Goldstein  * Return 0 on match, -ESTALE on mismatch or stale origin, < 0 on error.
491415543d5SAmir Goldstein  */
4921eff1a1dSAmir Goldstein int ovl_verify_index(struct ovl_fs *ofs, struct dentry *index)
493415543d5SAmir Goldstein {
494415543d5SAmir Goldstein 	struct ovl_fh *fh = NULL;
495415543d5SAmir Goldstein 	size_t len;
496b9343632SChandan Rajendra 	struct ovl_path origin = { };
497b9343632SChandan Rajendra 	struct ovl_path *stack = &origin;
498e8f9e5b7SAmir Goldstein 	struct dentry *upper = NULL;
499415543d5SAmir Goldstein 	int err;
500415543d5SAmir Goldstein 
501415543d5SAmir Goldstein 	if (!d_inode(index))
502415543d5SAmir Goldstein 		return 0;
503415543d5SAmir Goldstein 
5049ee60ce2SAmir Goldstein 	/* Cleanup leftover from index create/cleanup attempt */
5059ee60ce2SAmir Goldstein 	err = -ESTALE;
5069ee60ce2SAmir Goldstein 	if (ovl_is_temp_index(index))
5079ee60ce2SAmir Goldstein 		goto fail;
5089ee60ce2SAmir Goldstein 
509fa0096e3SAmir Goldstein 	err = -EINVAL;
510415543d5SAmir Goldstein 	if (index->d_name.len < sizeof(struct ovl_fh)*2)
511415543d5SAmir Goldstein 		goto fail;
512415543d5SAmir Goldstein 
513415543d5SAmir Goldstein 	err = -ENOMEM;
514415543d5SAmir Goldstein 	len = index->d_name.len / 2;
5150ee931c4SMichal Hocko 	fh = kzalloc(len, GFP_KERNEL);
516415543d5SAmir Goldstein 	if (!fh)
517415543d5SAmir Goldstein 		goto fail;
518415543d5SAmir Goldstein 
519415543d5SAmir Goldstein 	err = -EINVAL;
5202e1a5328SAmir Goldstein 	if (hex2bin((u8 *)fh, index->d_name.name, len))
5212e1a5328SAmir Goldstein 		goto fail;
5222e1a5328SAmir Goldstein 
5232e1a5328SAmir Goldstein 	err = ovl_check_fh_len(fh, len);
5242e1a5328SAmir Goldstein 	if (err)
525415543d5SAmir Goldstein 		goto fail;
526415543d5SAmir Goldstein 
5277db25d36SAmir Goldstein 	/*
5287db25d36SAmir Goldstein 	 * Whiteout index entries are used as an indication that an exported
5297db25d36SAmir Goldstein 	 * overlay file handle should be treated as stale (i.e. after unlink
5307db25d36SAmir Goldstein 	 * of the overlay inode). These entries contain no origin xattr.
5317db25d36SAmir Goldstein 	 */
5327db25d36SAmir Goldstein 	if (ovl_is_whiteout(index))
5337db25d36SAmir Goldstein 		goto out;
5347db25d36SAmir Goldstein 
535e8f9e5b7SAmir Goldstein 	/*
536e8f9e5b7SAmir Goldstein 	 * Verifying directory index entries are not stale is expensive, so
537e8f9e5b7SAmir Goldstein 	 * only verify stale dir index if NFS export is enabled.
538e8f9e5b7SAmir Goldstein 	 */
539e8f9e5b7SAmir Goldstein 	if (d_is_dir(index) && !ofs->config.nfs_export)
540e8f9e5b7SAmir Goldstein 		goto out;
541e8f9e5b7SAmir Goldstein 
542e8f9e5b7SAmir Goldstein 	/*
543e8f9e5b7SAmir Goldstein 	 * Directory index entries should have 'upper' xattr pointing to the
544e8f9e5b7SAmir Goldstein 	 * real upper dir. Non-dir index entries are hardlinks to the upper
545e8f9e5b7SAmir Goldstein 	 * real inode. For non-dir index, we can read the copy up origin xattr
546e8f9e5b7SAmir Goldstein 	 * directly from the index dentry, but for dir index we first need to
547e8f9e5b7SAmir Goldstein 	 * decode the upper directory.
548e8f9e5b7SAmir Goldstein 	 */
549e8f9e5b7SAmir Goldstein 	upper = ovl_index_upper(ofs, index);
550e8f9e5b7SAmir Goldstein 	if (IS_ERR_OR_NULL(upper)) {
551e8f9e5b7SAmir Goldstein 		err = PTR_ERR(upper);
55224f0b172SAmir Goldstein 		/*
55324f0b172SAmir Goldstein 		 * Directory index entries with no 'upper' xattr need to be
55424f0b172SAmir Goldstein 		 * removed. When dir index entry has a stale 'upper' xattr,
55524f0b172SAmir Goldstein 		 * we assume that upper dir was removed and we treat the dir
55624f0b172SAmir Goldstein 		 * index as orphan entry that needs to be whited out.
55724f0b172SAmir Goldstein 		 */
55824f0b172SAmir Goldstein 		if (err == -ESTALE)
55924f0b172SAmir Goldstein 			goto orphan;
56024f0b172SAmir Goldstein 		else if (!err)
561e8f9e5b7SAmir Goldstein 			err = -ESTALE;
562e8f9e5b7SAmir Goldstein 		goto fail;
563e8f9e5b7SAmir Goldstein 	}
564e8f9e5b7SAmir Goldstein 
565e8f9e5b7SAmir Goldstein 	err = ovl_verify_fh(upper, OVL_XATTR_ORIGIN, fh);
566e8f9e5b7SAmir Goldstein 	dput(upper);
567415543d5SAmir Goldstein 	if (err)
568415543d5SAmir Goldstein 		goto fail;
569415543d5SAmir Goldstein 
570e8f9e5b7SAmir Goldstein 	/* Check if non-dir index is orphan and don't warn before cleaning it */
571e8f9e5b7SAmir Goldstein 	if (!d_is_dir(index) && d_inode(index)->i_nlink == 1) {
5728a22efa1SAmir Goldstein 		err = ovl_check_origin_fh(ofs, fh, false, index, &stack);
573415543d5SAmir Goldstein 		if (err)
574415543d5SAmir Goldstein 			goto fail;
575415543d5SAmir Goldstein 
576e8f9e5b7SAmir Goldstein 		if (ovl_get_nlink(origin.dentry, index, 0) == 0)
57724f0b172SAmir Goldstein 			goto orphan;
578e8f9e5b7SAmir Goldstein 	}
579caf70cb2SAmir Goldstein 
580415543d5SAmir Goldstein out:
581e8f9e5b7SAmir Goldstein 	dput(origin.dentry);
582415543d5SAmir Goldstein 	kfree(fh);
583415543d5SAmir Goldstein 	return err;
584415543d5SAmir Goldstein 
585415543d5SAmir Goldstein fail:
58661b67471SAmir Goldstein 	pr_warn_ratelimited("overlayfs: failed to verify index (%pd2, ftype=%x, err=%i)\n",
58761b67471SAmir Goldstein 			    index, d_inode(index)->i_mode & S_IFMT, err);
588415543d5SAmir Goldstein 	goto out;
58924f0b172SAmir Goldstein 
59024f0b172SAmir Goldstein orphan:
59124f0b172SAmir Goldstein 	pr_warn_ratelimited("overlayfs: orphan index entry (%pd2, ftype=%x, nlink=%u)\n",
59224f0b172SAmir Goldstein 			    index, d_inode(index)->i_mode & S_IFMT,
59324f0b172SAmir Goldstein 			    d_inode(index)->i_nlink);
59424f0b172SAmir Goldstein 	err = -ENOENT;
59524f0b172SAmir Goldstein 	goto out;
596415543d5SAmir Goldstein }
597415543d5SAmir Goldstein 
59891ffe7beSAmir Goldstein static int ovl_get_index_name_fh(struct ovl_fh *fh, struct qstr *name)
59991ffe7beSAmir Goldstein {
60091ffe7beSAmir Goldstein 	char *n, *s;
60191ffe7beSAmir Goldstein 
6026396bb22SKees Cook 	n = kcalloc(fh->len, 2, GFP_KERNEL);
60391ffe7beSAmir Goldstein 	if (!n)
60491ffe7beSAmir Goldstein 		return -ENOMEM;
60591ffe7beSAmir Goldstein 
60691ffe7beSAmir Goldstein 	s  = bin2hex(n, fh, fh->len);
60791ffe7beSAmir Goldstein 	*name = (struct qstr) QSTR_INIT(n, s - n);
60891ffe7beSAmir Goldstein 
60991ffe7beSAmir Goldstein 	return 0;
61091ffe7beSAmir Goldstein 
61191ffe7beSAmir Goldstein }
61291ffe7beSAmir Goldstein 
613415543d5SAmir Goldstein /*
614359f392cSAmir Goldstein  * Lookup in indexdir for the index entry of a lower real inode or a copy up
615359f392cSAmir Goldstein  * origin inode. The index entry name is the hex representation of the lower
616359f392cSAmir Goldstein  * inode file handle.
617359f392cSAmir Goldstein  *
618359f392cSAmir Goldstein  * If the index dentry in negative, then either no lower aliases have been
619359f392cSAmir Goldstein  * copied up yet, or aliases have been copied up in older kernels and are
620359f392cSAmir Goldstein  * not indexed.
621359f392cSAmir Goldstein  *
622359f392cSAmir Goldstein  * If the index dentry for a copy up origin inode is positive, but points
623359f392cSAmir Goldstein  * to an inode different than the upper inode, then either the upper inode
624359f392cSAmir Goldstein  * has been copied up and not indexed or it was indexed, but since then
625359f392cSAmir Goldstein  * index dir was cleared. Either way, that index cannot be used to indentify
626359f392cSAmir Goldstein  * the overlay inode.
627359f392cSAmir Goldstein  */
628359f392cSAmir Goldstein int ovl_get_index_name(struct dentry *origin, struct qstr *name)
629359f392cSAmir Goldstein {
630359f392cSAmir Goldstein 	struct ovl_fh *fh;
63191ffe7beSAmir Goldstein 	int err;
632359f392cSAmir Goldstein 
6335b2cccd3SAmir Goldstein 	fh = ovl_encode_real_fh(origin, false);
634359f392cSAmir Goldstein 	if (IS_ERR(fh))
635359f392cSAmir Goldstein 		return PTR_ERR(fh);
636359f392cSAmir Goldstein 
63791ffe7beSAmir Goldstein 	err = ovl_get_index_name_fh(fh, name);
63891ffe7beSAmir Goldstein 
639359f392cSAmir Goldstein 	kfree(fh);
640359f392cSAmir Goldstein 	return err;
64191ffe7beSAmir Goldstein }
642359f392cSAmir Goldstein 
64391ffe7beSAmir Goldstein /* Lookup index by file handle for NFS export */
64491ffe7beSAmir Goldstein struct dentry *ovl_get_index_fh(struct ovl_fs *ofs, struct ovl_fh *fh)
64591ffe7beSAmir Goldstein {
64691ffe7beSAmir Goldstein 	struct dentry *index;
64791ffe7beSAmir Goldstein 	struct qstr name;
64891ffe7beSAmir Goldstein 	int err;
64991ffe7beSAmir Goldstein 
65091ffe7beSAmir Goldstein 	err = ovl_get_index_name_fh(fh, &name);
65191ffe7beSAmir Goldstein 	if (err)
65291ffe7beSAmir Goldstein 		return ERR_PTR(err);
65391ffe7beSAmir Goldstein 
65491ffe7beSAmir Goldstein 	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
65591ffe7beSAmir Goldstein 	kfree(name.name);
65691ffe7beSAmir Goldstein 	if (IS_ERR(index)) {
65791ffe7beSAmir Goldstein 		if (PTR_ERR(index) == -ENOENT)
65891ffe7beSAmir Goldstein 			index = NULL;
65991ffe7beSAmir Goldstein 		return index;
66091ffe7beSAmir Goldstein 	}
66191ffe7beSAmir Goldstein 
66291ffe7beSAmir Goldstein 	if (d_is_negative(index))
66391ffe7beSAmir Goldstein 		err = 0;
66491ffe7beSAmir Goldstein 	else if (ovl_is_whiteout(index))
66591ffe7beSAmir Goldstein 		err = -ESTALE;
66691ffe7beSAmir Goldstein 	else if (ovl_dentry_weird(index))
66791ffe7beSAmir Goldstein 		err = -EIO;
66891ffe7beSAmir Goldstein 	else
66991ffe7beSAmir Goldstein 		return index;
67091ffe7beSAmir Goldstein 
67191ffe7beSAmir Goldstein 	dput(index);
67291ffe7beSAmir Goldstein 	return ERR_PTR(err);
673359f392cSAmir Goldstein }
674359f392cSAmir Goldstein 
67506170154SAmir Goldstein struct dentry *ovl_lookup_index(struct ovl_fs *ofs, struct dentry *upper,
67606170154SAmir Goldstein 				struct dentry *origin, bool verify)
677359f392cSAmir Goldstein {
678359f392cSAmir Goldstein 	struct dentry *index;
679359f392cSAmir Goldstein 	struct inode *inode;
680359f392cSAmir Goldstein 	struct qstr name;
681ad1d615cSAmir Goldstein 	bool is_dir = d_is_dir(origin);
682359f392cSAmir Goldstein 	int err;
683359f392cSAmir Goldstein 
684359f392cSAmir Goldstein 	err = ovl_get_index_name(origin, &name);
685359f392cSAmir Goldstein 	if (err)
686359f392cSAmir Goldstein 		return ERR_PTR(err);
687359f392cSAmir Goldstein 
688359f392cSAmir Goldstein 	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
689359f392cSAmir Goldstein 	if (IS_ERR(index)) {
690e0082a0fSAmir Goldstein 		err = PTR_ERR(index);
6917937a56fSAmir Goldstein 		if (err == -ENOENT) {
6927937a56fSAmir Goldstein 			index = NULL;
6937937a56fSAmir Goldstein 			goto out;
6947937a56fSAmir Goldstein 		}
695601350ffSAmir Goldstein 		pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%.*s, err=%i);\n"
696359f392cSAmir Goldstein 				    "overlayfs: mount with '-o index=off' to disable inodes index.\n",
697359f392cSAmir Goldstein 				    d_inode(origin)->i_ino, name.len, name.name,
698359f392cSAmir Goldstein 				    err);
699359f392cSAmir Goldstein 		goto out;
700359f392cSAmir Goldstein 	}
701359f392cSAmir Goldstein 
7020e082555SAmir Goldstein 	inode = d_inode(index);
703359f392cSAmir Goldstein 	if (d_is_negative(index)) {
7046eaf0111SAmir Goldstein 		goto out_dput;
70506170154SAmir Goldstein 	} else if (ovl_is_whiteout(index) && !verify) {
70606170154SAmir Goldstein 		/*
70706170154SAmir Goldstein 		 * When index lookup is called with !verify for decoding an
70806170154SAmir Goldstein 		 * overlay file handle, a whiteout index implies that decode
70906170154SAmir Goldstein 		 * should treat file handle as stale and no need to print a
71006170154SAmir Goldstein 		 * warning about it.
71106170154SAmir Goldstein 		 */
71206170154SAmir Goldstein 		dput(index);
71306170154SAmir Goldstein 		index = ERR_PTR(-ESTALE);
71406170154SAmir Goldstein 		goto out;
7150e082555SAmir Goldstein 	} else if (ovl_dentry_weird(index) || ovl_is_whiteout(index) ||
7160e082555SAmir Goldstein 		   ((inode->i_mode ^ d_inode(origin)->i_mode) & S_IFMT)) {
7170e082555SAmir Goldstein 		/*
7180e082555SAmir Goldstein 		 * Index should always be of the same file type as origin
7190e082555SAmir Goldstein 		 * except for the case of a whiteout index. A whiteout
7200e082555SAmir Goldstein 		 * index should only exist if all lower aliases have been
7210e082555SAmir Goldstein 		 * unlinked, which means that finding a lower origin on lookup
7220e082555SAmir Goldstein 		 * whose index is a whiteout should be treated as an error.
7230e082555SAmir Goldstein 		 */
7240e082555SAmir Goldstein 		pr_warn_ratelimited("overlayfs: bad index found (index=%pd2, ftype=%x, origin ftype=%x).\n",
7250e082555SAmir Goldstein 				    index, d_inode(index)->i_mode & S_IFMT,
7260e082555SAmir Goldstein 				    d_inode(origin)->i_mode & S_IFMT);
727359f392cSAmir Goldstein 		goto fail;
72806170154SAmir Goldstein 	} else if (is_dir && verify) {
729ad1d615cSAmir Goldstein 		if (!upper) {
730ad1d615cSAmir Goldstein 			pr_warn_ratelimited("overlayfs: suspected uncovered redirected dir found (origin=%pd2, index=%pd2).\n",
731ad1d615cSAmir Goldstein 					    origin, index);
732ad1d615cSAmir Goldstein 			goto fail;
733359f392cSAmir Goldstein 		}
734359f392cSAmir Goldstein 
735ad1d615cSAmir Goldstein 		/* Verify that dir index 'upper' xattr points to upper dir */
736ad1d615cSAmir Goldstein 		err = ovl_verify_upper(index, upper, false);
737ad1d615cSAmir Goldstein 		if (err) {
738ad1d615cSAmir Goldstein 			if (err == -ESTALE) {
739ad1d615cSAmir Goldstein 				pr_warn_ratelimited("overlayfs: suspected multiply redirected dir found (upper=%pd2, origin=%pd2, index=%pd2).\n",
740ad1d615cSAmir Goldstein 						    upper, origin, index);
741ad1d615cSAmir Goldstein 			}
742ad1d615cSAmir Goldstein 			goto fail;
743ad1d615cSAmir Goldstein 		}
744ad1d615cSAmir Goldstein 	} else if (upper && d_inode(upper) != inode) {
745ad1d615cSAmir Goldstein 		goto out_dput;
746ad1d615cSAmir Goldstein 	}
747359f392cSAmir Goldstein out:
748359f392cSAmir Goldstein 	kfree(name.name);
749359f392cSAmir Goldstein 	return index;
750359f392cSAmir Goldstein 
7516eaf0111SAmir Goldstein out_dput:
7526eaf0111SAmir Goldstein 	dput(index);
7536eaf0111SAmir Goldstein 	index = NULL;
7546eaf0111SAmir Goldstein 	goto out;
7556eaf0111SAmir Goldstein 
756359f392cSAmir Goldstein fail:
757359f392cSAmir Goldstein 	dput(index);
758359f392cSAmir Goldstein 	index = ERR_PTR(-EIO);
759359f392cSAmir Goldstein 	goto out;
760359f392cSAmir Goldstein }
761359f392cSAmir Goldstein 
762359f392cSAmir Goldstein /*
763bbb1e54dSMiklos Szeredi  * Returns next layer in stack starting from top.
764bbb1e54dSMiklos Szeredi  * Returns -1 if this is the last layer.
765bbb1e54dSMiklos Szeredi  */
766bbb1e54dSMiklos Szeredi int ovl_path_next(int idx, struct dentry *dentry, struct path *path)
767bbb1e54dSMiklos Szeredi {
768bbb1e54dSMiklos Szeredi 	struct ovl_entry *oe = dentry->d_fsdata;
769bbb1e54dSMiklos Szeredi 
770bbb1e54dSMiklos Szeredi 	BUG_ON(idx < 0);
771bbb1e54dSMiklos Szeredi 	if (idx == 0) {
772bbb1e54dSMiklos Szeredi 		ovl_path_upper(dentry, path);
773bbb1e54dSMiklos Szeredi 		if (path->dentry)
774bbb1e54dSMiklos Szeredi 			return oe->numlower ? 1 : -1;
775bbb1e54dSMiklos Szeredi 		idx++;
776bbb1e54dSMiklos Szeredi 	}
777bbb1e54dSMiklos Szeredi 	BUG_ON(idx > oe->numlower);
778b9343632SChandan Rajendra 	path->dentry = oe->lowerstack[idx - 1].dentry;
779b9343632SChandan Rajendra 	path->mnt = oe->lowerstack[idx - 1].layer->mnt;
780bbb1e54dSMiklos Szeredi 
781bbb1e54dSMiklos Szeredi 	return (idx < oe->numlower) ? idx + 1 : -1;
782bbb1e54dSMiklos Szeredi }
783bbb1e54dSMiklos Szeredi 
7849678e630SAmir Goldstein /* Fix missing 'origin' xattr */
7859678e630SAmir Goldstein static int ovl_fix_origin(struct dentry *dentry, struct dentry *lower,
7869678e630SAmir Goldstein 			  struct dentry *upper)
7879678e630SAmir Goldstein {
7889678e630SAmir Goldstein 	int err;
7899678e630SAmir Goldstein 
7909678e630SAmir Goldstein 	if (ovl_check_origin_xattr(upper))
7919678e630SAmir Goldstein 		return 0;
7929678e630SAmir Goldstein 
7939678e630SAmir Goldstein 	err = ovl_want_write(dentry);
7949678e630SAmir Goldstein 	if (err)
7959678e630SAmir Goldstein 		return err;
7969678e630SAmir Goldstein 
7979678e630SAmir Goldstein 	err = ovl_set_origin(dentry, lower, upper);
7989678e630SAmir Goldstein 	if (!err)
7999678e630SAmir Goldstein 		err = ovl_set_impure(dentry->d_parent, upper->d_parent);
8009678e630SAmir Goldstein 
8019678e630SAmir Goldstein 	ovl_drop_write(dentry);
8029678e630SAmir Goldstein 	return err;
8039678e630SAmir Goldstein }
8049678e630SAmir Goldstein 
805bbb1e54dSMiklos Szeredi struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
806bbb1e54dSMiklos Szeredi 			  unsigned int flags)
807bbb1e54dSMiklos Szeredi {
808bbb1e54dSMiklos Szeredi 	struct ovl_entry *oe;
809bbb1e54dSMiklos Szeredi 	const struct cred *old_cred;
8106b2d5fe4SMiklos Szeredi 	struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
811bbb1e54dSMiklos Szeredi 	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
812c22205d0SAmir Goldstein 	struct ovl_entry *roe = dentry->d_sb->s_root->d_fsdata;
8139d3dfea3SVivek Goyal 	struct ovl_path *stack = NULL, *origin_path = NULL;
814bbb1e54dSMiklos Szeredi 	struct dentry *upperdir, *upperdentry = NULL;
815ad1d615cSAmir Goldstein 	struct dentry *origin = NULL;
816359f392cSAmir Goldstein 	struct dentry *index = NULL;
817bbb1e54dSMiklos Szeredi 	unsigned int ctr = 0;
818bbb1e54dSMiklos Szeredi 	struct inode *inode = NULL;
819bbb1e54dSMiklos Szeredi 	bool upperopaque = false;
82002b69b28SMiklos Szeredi 	char *upperredirect = NULL;
821bbb1e54dSMiklos Szeredi 	struct dentry *this;
822bbb1e54dSMiklos Szeredi 	unsigned int i;
823bbb1e54dSMiklos Szeredi 	int err;
8249d3dfea3SVivek Goyal 	bool metacopy = false;
825e28edc46SMiklos Szeredi 	struct ovl_lookup_data d = {
826146d62e5SAmir Goldstein 		.sb = dentry->d_sb,
827e28edc46SMiklos Szeredi 		.name = dentry->d_name,
828e28edc46SMiklos Szeredi 		.is_dir = false,
829e28edc46SMiklos Szeredi 		.opaque = false,
830e28edc46SMiklos Szeredi 		.stop = false,
831452061fdSVivek Goyal 		.last = ofs->config.redirect_follow ? false : !poe->numlower,
83202b69b28SMiklos Szeredi 		.redirect = NULL,
8339d3dfea3SVivek Goyal 		.metacopy = false,
834e28edc46SMiklos Szeredi 	};
835bbb1e54dSMiklos Szeredi 
8366b2d5fe4SMiklos Szeredi 	if (dentry->d_name.len > ofs->namelen)
8376b2d5fe4SMiklos Szeredi 		return ERR_PTR(-ENAMETOOLONG);
8386b2d5fe4SMiklos Szeredi 
839bbb1e54dSMiklos Szeredi 	old_cred = ovl_override_creds(dentry->d_sb);
84009d8b586SMiklos Szeredi 	upperdir = ovl_dentry_upper(dentry->d_parent);
841bbb1e54dSMiklos Szeredi 	if (upperdir) {
842e28edc46SMiklos Szeredi 		err = ovl_lookup_layer(upperdir, &d, &upperdentry);
843e28edc46SMiklos Szeredi 		if (err)
844bbb1e54dSMiklos Szeredi 			goto out;
845bbb1e54dSMiklos Szeredi 
846e28edc46SMiklos Szeredi 		if (upperdentry && unlikely(ovl_dentry_remote(upperdentry))) {
847e28edc46SMiklos Szeredi 			dput(upperdentry);
848bbb1e54dSMiklos Szeredi 			err = -EREMOTE;
849bbb1e54dSMiklos Szeredi 			goto out;
850bbb1e54dSMiklos Szeredi 		}
851a9d01957SAmir Goldstein 		if (upperdentry && !d.is_dir) {
8529d3dfea3SVivek Goyal 			unsigned int origin_ctr = 0;
8539d3dfea3SVivek Goyal 
854f7d3dacaSAmir Goldstein 			/*
855f7d3dacaSAmir Goldstein 			 * Lookup copy up origin by decoding origin file handle.
856f7d3dacaSAmir Goldstein 			 * We may get a disconnected dentry, which is fine,
857f7d3dacaSAmir Goldstein 			 * because we only need to hold the origin inode in
858f7d3dacaSAmir Goldstein 			 * cache and use its inode number.  We may even get a
859f7d3dacaSAmir Goldstein 			 * connected dentry, that is not under any of the lower
860f7d3dacaSAmir Goldstein 			 * layers root.  That is also fine for using it's inode
861f7d3dacaSAmir Goldstein 			 * number - it's the same as if we held a reference
862f7d3dacaSAmir Goldstein 			 * to a dentry in lower layer that was moved under us.
863f7d3dacaSAmir Goldstein 			 */
8649d3dfea3SVivek Goyal 			err = ovl_check_origin(ofs, upperdentry, &origin_path,
8659d3dfea3SVivek Goyal 					       &origin_ctr);
866a9d01957SAmir Goldstein 			if (err)
8675455f92bSVivek Goyal 				goto out_put_upper;
8689d3dfea3SVivek Goyal 
8699d3dfea3SVivek Goyal 			if (d.metacopy)
8709d3dfea3SVivek Goyal 				metacopy = true;
871a9d01957SAmir Goldstein 		}
87202b69b28SMiklos Szeredi 
87302b69b28SMiklos Szeredi 		if (d.redirect) {
8740ce5cdc9SDan Carpenter 			err = -ENOMEM;
87502b69b28SMiklos Szeredi 			upperredirect = kstrdup(d.redirect, GFP_KERNEL);
87602b69b28SMiklos Szeredi 			if (!upperredirect)
87702b69b28SMiklos Szeredi 				goto out_put_upper;
87802b69b28SMiklos Szeredi 			if (d.redirect[0] == '/')
879c22205d0SAmir Goldstein 				poe = roe;
88002b69b28SMiklos Szeredi 		}
881e28edc46SMiklos Szeredi 		upperopaque = d.opaque;
882bbb1e54dSMiklos Szeredi 	}
883bbb1e54dSMiklos Szeredi 
884e28edc46SMiklos Szeredi 	if (!d.stop && poe->numlower) {
885bbb1e54dSMiklos Szeredi 		err = -ENOMEM;
886b9343632SChandan Rajendra 		stack = kcalloc(ofs->numlower, sizeof(struct ovl_path),
8870ee931c4SMichal Hocko 				GFP_KERNEL);
888bbb1e54dSMiklos Szeredi 		if (!stack)
889bbb1e54dSMiklos Szeredi 			goto out_put_upper;
890bbb1e54dSMiklos Szeredi 	}
891bbb1e54dSMiklos Szeredi 
892e28edc46SMiklos Szeredi 	for (i = 0; !d.stop && i < poe->numlower; i++) {
893b9343632SChandan Rajendra 		struct ovl_path lower = poe->lowerstack[i];
894bbb1e54dSMiklos Szeredi 
895452061fdSVivek Goyal 		if (!ofs->config.redirect_follow)
896e28edc46SMiklos Szeredi 			d.last = i == poe->numlower - 1;
897452061fdSVivek Goyal 		else
898452061fdSVivek Goyal 			d.last = lower.layer->idx == roe->numlower;
899452061fdSVivek Goyal 
900b9343632SChandan Rajendra 		err = ovl_lookup_layer(lower.dentry, &d, &this);
901e28edc46SMiklos Szeredi 		if (err)
902bbb1e54dSMiklos Szeredi 			goto out_put;
9036b2d5fe4SMiklos Szeredi 
904bbb1e54dSMiklos Szeredi 		if (!this)
905bbb1e54dSMiklos Szeredi 			continue;
906bbb1e54dSMiklos Szeredi 
9079678e630SAmir Goldstein 		/*
9089678e630SAmir Goldstein 		 * If no origin fh is stored in upper of a merge dir, store fh
9099678e630SAmir Goldstein 		 * of lower dir and set upper parent "impure".
9109678e630SAmir Goldstein 		 */
9119d3dfea3SVivek Goyal 		if (upperdentry && !ctr && !ofs->noxattr && d.is_dir) {
9129678e630SAmir Goldstein 			err = ovl_fix_origin(dentry, this, upperdentry);
9139678e630SAmir Goldstein 			if (err) {
9149678e630SAmir Goldstein 				dput(this);
9159678e630SAmir Goldstein 				goto out_put;
9169678e630SAmir Goldstein 			}
9179678e630SAmir Goldstein 		}
9189678e630SAmir Goldstein 
91937b12916SAmir Goldstein 		/*
92037b12916SAmir Goldstein 		 * When "verify_lower" feature is enabled, do not merge with a
921ad1d615cSAmir Goldstein 		 * lower dir that does not match a stored origin xattr. In any
922ad1d615cSAmir Goldstein 		 * case, only verified origin is used for index lookup.
9239d3dfea3SVivek Goyal 		 *
9249d3dfea3SVivek Goyal 		 * For non-dir dentry, if index=on, then ensure origin
9259d3dfea3SVivek Goyal 		 * matches the dentry found using path based lookup,
9269d3dfea3SVivek Goyal 		 * otherwise error out.
92737b12916SAmir Goldstein 		 */
9289d3dfea3SVivek Goyal 		if (upperdentry && !ctr &&
9299d3dfea3SVivek Goyal 		    ((d.is_dir && ovl_verify_lower(dentry->d_sb)) ||
9309d3dfea3SVivek Goyal 		     (!d.is_dir && ofs->config.index && origin_path))) {
93137b12916SAmir Goldstein 			err = ovl_verify_origin(upperdentry, this, false);
93237b12916SAmir Goldstein 			if (err) {
93337b12916SAmir Goldstein 				dput(this);
9349d3dfea3SVivek Goyal 				if (d.is_dir)
93537b12916SAmir Goldstein 					break;
9369d3dfea3SVivek Goyal 				goto out_put;
9379d3dfea3SVivek Goyal 			}
9389d3dfea3SVivek Goyal 			origin = this;
93937b12916SAmir Goldstein 		}
940ad1d615cSAmir Goldstein 
9419d3dfea3SVivek Goyal 		if (d.metacopy)
9429d3dfea3SVivek Goyal 			metacopy = true;
9439d3dfea3SVivek Goyal 		/*
9449d3dfea3SVivek Goyal 		 * Do not store intermediate metacopy dentries in chain,
9459d3dfea3SVivek Goyal 		 * except top most lower metacopy dentry
9469d3dfea3SVivek Goyal 		 */
9479d3dfea3SVivek Goyal 		if (d.metacopy && ctr) {
9489d3dfea3SVivek Goyal 			dput(this);
9499d3dfea3SVivek Goyal 			continue;
95037b12916SAmir Goldstein 		}
95137b12916SAmir Goldstein 
952bbb1e54dSMiklos Szeredi 		stack[ctr].dentry = this;
953b9343632SChandan Rajendra 		stack[ctr].layer = lower.layer;
954bbb1e54dSMiklos Szeredi 		ctr++;
95502b69b28SMiklos Szeredi 
956438c84c2SMiklos Szeredi 		/*
957438c84c2SMiklos Szeredi 		 * Following redirects can have security consequences: it's like
958438c84c2SMiklos Szeredi 		 * a symlink into the lower layer without the permission checks.
959438c84c2SMiklos Szeredi 		 * This is only a problem if the upper layer is untrusted (e.g
960438c84c2SMiklos Szeredi 		 * comes from an USB drive).  This can allow a non-readable file
961438c84c2SMiklos Szeredi 		 * or directory to become readable.
962438c84c2SMiklos Szeredi 		 *
963438c84c2SMiklos Szeredi 		 * Only following redirects when redirects are enabled disables
964438c84c2SMiklos Szeredi 		 * this attack vector when not necessary.
965438c84c2SMiklos Szeredi 		 */
966438c84c2SMiklos Szeredi 		err = -EPERM;
967438c84c2SMiklos Szeredi 		if (d.redirect && !ofs->config.redirect_follow) {
968f8167817SAmir Goldstein 			pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n",
969f8167817SAmir Goldstein 					    dentry);
970438c84c2SMiklos Szeredi 			goto out_put;
971438c84c2SMiklos Szeredi 		}
972438c84c2SMiklos Szeredi 
973d1fe96c0SVivek Goyal 		if (d.stop)
974d1fe96c0SVivek Goyal 			break;
975d1fe96c0SVivek Goyal 
976c22205d0SAmir Goldstein 		if (d.redirect && d.redirect[0] == '/' && poe != roe) {
977c22205d0SAmir Goldstein 			poe = roe;
97802b69b28SMiklos Szeredi 			/* Find the current layer on the root dentry */
979d583ed7dSAmir Goldstein 			i = lower.layer->idx - 1;
98002b69b28SMiklos Szeredi 		}
981bbb1e54dSMiklos Szeredi 	}
982bbb1e54dSMiklos Szeredi 
9839d3dfea3SVivek Goyal 	if (metacopy) {
9849d3dfea3SVivek Goyal 		/*
9859d3dfea3SVivek Goyal 		 * Found a metacopy dentry but did not find corresponding
9869d3dfea3SVivek Goyal 		 * data dentry
9879d3dfea3SVivek Goyal 		 */
9889d3dfea3SVivek Goyal 		if (d.metacopy) {
9899d3dfea3SVivek Goyal 			err = -EIO;
9909d3dfea3SVivek Goyal 			goto out_put;
9919d3dfea3SVivek Goyal 		}
9929d3dfea3SVivek Goyal 
9939d3dfea3SVivek Goyal 		err = -EPERM;
9949d3dfea3SVivek Goyal 		if (!ofs->config.metacopy) {
9959d3dfea3SVivek Goyal 			pr_warn_ratelimited("overlay: refusing to follow metacopy origin for (%pd2)\n",
9969d3dfea3SVivek Goyal 					    dentry);
9979d3dfea3SVivek Goyal 			goto out_put;
9989d3dfea3SVivek Goyal 		}
9999d3dfea3SVivek Goyal 	} else if (!d.is_dir && upperdentry && !ctr && origin_path) {
10009d3dfea3SVivek Goyal 		if (WARN_ON(stack != NULL)) {
10019d3dfea3SVivek Goyal 			err = -EIO;
10029d3dfea3SVivek Goyal 			goto out_put;
10039d3dfea3SVivek Goyal 		}
10049d3dfea3SVivek Goyal 		stack = origin_path;
10059d3dfea3SVivek Goyal 		ctr = 1;
10069d3dfea3SVivek Goyal 		origin_path = NULL;
10079d3dfea3SVivek Goyal 	}
10089d3dfea3SVivek Goyal 
1009ad1d615cSAmir Goldstein 	/*
1010ad1d615cSAmir Goldstein 	 * Lookup index by lower inode and verify it matches upper inode.
1011ad1d615cSAmir Goldstein 	 * We only trust dir index if we verified that lower dir matches
1012ad1d615cSAmir Goldstein 	 * origin, otherwise dir index entries may be inconsistent and we
10139d3dfea3SVivek Goyal 	 * ignore them.
10149d3dfea3SVivek Goyal 	 *
10159d3dfea3SVivek Goyal 	 * For non-dir upper metacopy dentry, we already set "origin" if we
10169d3dfea3SVivek Goyal 	 * verified that lower matched upper origin. If upper origin was
10179d3dfea3SVivek Goyal 	 * not present (because lower layer did not support fh encode/decode),
10189d3dfea3SVivek Goyal 	 * or indexing is not enabled, do not set "origin" and skip looking up
10199d3dfea3SVivek Goyal 	 * index. This case should be handled in same way as a non-dir upper
10209d3dfea3SVivek Goyal 	 * without ORIGIN is handled.
10219d3dfea3SVivek Goyal 	 *
10229d3dfea3SVivek Goyal 	 * Always lookup index of non-dir non-metacopy and non-upper.
1023ad1d615cSAmir Goldstein 	 */
10249d3dfea3SVivek Goyal 	if (ctr && (!upperdentry || (!d.is_dir && !metacopy)))
1025ad1d615cSAmir Goldstein 		origin = stack[0].dentry;
1026359f392cSAmir Goldstein 
1027ad1d615cSAmir Goldstein 	if (origin && ovl_indexdir(dentry->d_sb) &&
1028ad1d615cSAmir Goldstein 	    (!d.is_dir || ovl_index_all(dentry->d_sb))) {
102906170154SAmir Goldstein 		index = ovl_lookup_index(ofs, upperdentry, origin, true);
1030359f392cSAmir Goldstein 		if (IS_ERR(index)) {
1031359f392cSAmir Goldstein 			err = PTR_ERR(index);
1032359f392cSAmir Goldstein 			index = NULL;
1033359f392cSAmir Goldstein 			goto out_put;
1034359f392cSAmir Goldstein 		}
1035359f392cSAmir Goldstein 	}
1036359f392cSAmir Goldstein 
1037bbb1e54dSMiklos Szeredi 	oe = ovl_alloc_entry(ctr);
1038bbb1e54dSMiklos Szeredi 	err = -ENOMEM;
1039bbb1e54dSMiklos Szeredi 	if (!oe)
1040bbb1e54dSMiklos Szeredi 		goto out_put;
1041bbb1e54dSMiklos Szeredi 
1042b9343632SChandan Rajendra 	memcpy(oe->lowerstack, stack, sizeof(struct ovl_path) * ctr);
1043e6d2ebddSMiklos Szeredi 	dentry->d_fsdata = oe;
1044e6d2ebddSMiklos Szeredi 
1045c62520a8SAmir Goldstein 	if (upperopaque)
1046c62520a8SAmir Goldstein 		ovl_dentry_set_opaque(dentry);
1047c62520a8SAmir Goldstein 
104855acc661SMiklos Szeredi 	if (upperdentry)
104955acc661SMiklos Szeredi 		ovl_dentry_set_upper_alias(dentry);
10500a2d0d3fSVivek Goyal 	else if (index) {
1051359f392cSAmir Goldstein 		upperdentry = dget(index);
10520a2d0d3fSVivek Goyal 		upperredirect = ovl_get_redirect_xattr(upperdentry, 0);
10530a2d0d3fSVivek Goyal 		if (IS_ERR(upperredirect)) {
10540a2d0d3fSVivek Goyal 			err = PTR_ERR(upperredirect);
10550a2d0d3fSVivek Goyal 			upperredirect = NULL;
10560a2d0d3fSVivek Goyal 			goto out_free_oe;
10570a2d0d3fSVivek Goyal 		}
10580a2d0d3fSVivek Goyal 	}
1059359f392cSAmir Goldstein 
1060e6d2ebddSMiklos Szeredi 	if (upperdentry || ctr) {
1061ac6a52ebSVivek Goyal 		struct ovl_inode_params oip = {
1062ac6a52ebSVivek Goyal 			.upperdentry = upperdentry,
1063ac6a52ebSVivek Goyal 			.lowerpath = stack,
1064ac6a52ebSVivek Goyal 			.index = index,
1065ac6a52ebSVivek Goyal 			.numlower = ctr,
10669cec54c8SVivek Goyal 			.redirect = upperredirect,
10672664bd08SVivek Goyal 			.lowerdata = (ctr > 1 && !d.is_dir) ?
10682664bd08SVivek Goyal 				      stack[ctr - 1].dentry : NULL,
1069ac6a52ebSVivek Goyal 		};
1070ac6a52ebSVivek Goyal 
1071ac6a52ebSVivek Goyal 		inode = ovl_get_inode(dentry->d_sb, &oip);
1072b9ac5c27SMiklos Szeredi 		err = PTR_ERR(inode);
1073b9ac5c27SMiklos Szeredi 		if (IS_ERR(inode))
1074e6d2ebddSMiklos Szeredi 			goto out_free_oe;
1075e6d2ebddSMiklos Szeredi 	}
1076e6d2ebddSMiklos Szeredi 
1077e6d2ebddSMiklos Szeredi 	revert_creds(old_cred);
10789d3dfea3SVivek Goyal 	if (origin_path) {
10799d3dfea3SVivek Goyal 		dput(origin_path->dentry);
10809d3dfea3SVivek Goyal 		kfree(origin_path);
10819d3dfea3SVivek Goyal 	}
1082359f392cSAmir Goldstein 	dput(index);
1083bbb1e54dSMiklos Szeredi 	kfree(stack);
108402b69b28SMiklos Szeredi 	kfree(d.redirect);
1085829c28beSAmir Goldstein 	return d_splice_alias(inode, dentry);
1086bbb1e54dSMiklos Szeredi 
1087bbb1e54dSMiklos Szeredi out_free_oe:
1088e6d2ebddSMiklos Szeredi 	dentry->d_fsdata = NULL;
1089bbb1e54dSMiklos Szeredi 	kfree(oe);
1090bbb1e54dSMiklos Szeredi out_put:
1091359f392cSAmir Goldstein 	dput(index);
1092bbb1e54dSMiklos Szeredi 	for (i = 0; i < ctr; i++)
1093bbb1e54dSMiklos Szeredi 		dput(stack[i].dentry);
1094bbb1e54dSMiklos Szeredi 	kfree(stack);
1095bbb1e54dSMiklos Szeredi out_put_upper:
10969d3dfea3SVivek Goyal 	if (origin_path) {
10979d3dfea3SVivek Goyal 		dput(origin_path->dentry);
10989d3dfea3SVivek Goyal 		kfree(origin_path);
10999d3dfea3SVivek Goyal 	}
1100bbb1e54dSMiklos Szeredi 	dput(upperdentry);
110102b69b28SMiklos Szeredi 	kfree(upperredirect);
1102bbb1e54dSMiklos Szeredi out:
110302b69b28SMiklos Szeredi 	kfree(d.redirect);
1104bbb1e54dSMiklos Szeredi 	revert_creds(old_cred);
1105bbb1e54dSMiklos Szeredi 	return ERR_PTR(err);
1106bbb1e54dSMiklos Szeredi }
1107bbb1e54dSMiklos Szeredi 
1108bbb1e54dSMiklos Szeredi bool ovl_lower_positive(struct dentry *dentry)
1109bbb1e54dSMiklos Szeredi {
1110bbb1e54dSMiklos Szeredi 	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
1111bbb1e54dSMiklos Szeredi 	const struct qstr *name = &dentry->d_name;
11126d0a8a90SAmir Goldstein 	const struct cred *old_cred;
1113bbb1e54dSMiklos Szeredi 	unsigned int i;
1114bbb1e54dSMiklos Szeredi 	bool positive = false;
1115bbb1e54dSMiklos Szeredi 	bool done = false;
1116bbb1e54dSMiklos Szeredi 
1117bbb1e54dSMiklos Szeredi 	/*
1118bbb1e54dSMiklos Szeredi 	 * If dentry is negative, then lower is positive iff this is a
1119bbb1e54dSMiklos Szeredi 	 * whiteout.
1120bbb1e54dSMiklos Szeredi 	 */
1121bbb1e54dSMiklos Szeredi 	if (!dentry->d_inode)
1122c62520a8SAmir Goldstein 		return ovl_dentry_is_opaque(dentry);
1123bbb1e54dSMiklos Szeredi 
1124bbb1e54dSMiklos Szeredi 	/* Negative upper -> positive lower */
112509d8b586SMiklos Szeredi 	if (!ovl_dentry_upper(dentry))
1126bbb1e54dSMiklos Szeredi 		return true;
1127bbb1e54dSMiklos Szeredi 
11286d0a8a90SAmir Goldstein 	old_cred = ovl_override_creds(dentry->d_sb);
1129bbb1e54dSMiklos Szeredi 	/* Positive upper -> have to look up lower to see whether it exists */
1130bbb1e54dSMiklos Szeredi 	for (i = 0; !done && !positive && i < poe->numlower; i++) {
1131bbb1e54dSMiklos Szeredi 		struct dentry *this;
1132bbb1e54dSMiklos Szeredi 		struct dentry *lowerdir = poe->lowerstack[i].dentry;
1133bbb1e54dSMiklos Szeredi 
1134bbb1e54dSMiklos Szeredi 		this = lookup_one_len_unlocked(name->name, lowerdir,
1135bbb1e54dSMiklos Szeredi 					       name->len);
1136bbb1e54dSMiklos Szeredi 		if (IS_ERR(this)) {
1137bbb1e54dSMiklos Szeredi 			switch (PTR_ERR(this)) {
1138bbb1e54dSMiklos Szeredi 			case -ENOENT:
1139bbb1e54dSMiklos Szeredi 			case -ENAMETOOLONG:
1140bbb1e54dSMiklos Szeredi 				break;
1141bbb1e54dSMiklos Szeredi 
1142bbb1e54dSMiklos Szeredi 			default:
1143bbb1e54dSMiklos Szeredi 				/*
1144bbb1e54dSMiklos Szeredi 				 * Assume something is there, we just couldn't
1145bbb1e54dSMiklos Szeredi 				 * access it.
1146bbb1e54dSMiklos Szeredi 				 */
1147bbb1e54dSMiklos Szeredi 				positive = true;
1148bbb1e54dSMiklos Szeredi 				break;
1149bbb1e54dSMiklos Szeredi 			}
1150bbb1e54dSMiklos Szeredi 		} else {
1151bbb1e54dSMiklos Szeredi 			if (this->d_inode) {
1152bbb1e54dSMiklos Szeredi 				positive = !ovl_is_whiteout(this);
1153bbb1e54dSMiklos Szeredi 				done = true;
1154bbb1e54dSMiklos Szeredi 			}
1155bbb1e54dSMiklos Szeredi 			dput(this);
1156bbb1e54dSMiklos Szeredi 		}
1157bbb1e54dSMiklos Szeredi 	}
11586d0a8a90SAmir Goldstein 	revert_creds(old_cred);
1159bbb1e54dSMiklos Szeredi 
1160bbb1e54dSMiklos Szeredi 	return positive;
1161bbb1e54dSMiklos Szeredi }
1162