xref: /openbmc/linux/fs/ext4/migrate.c (revision aeb64ff3)
1 // SPDX-License-Identifier: LGPL-2.1
2 /*
3  * Copyright IBM Corporation, 2007
4  * Author Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
5  *
6  */
7 
8 #include <linux/slab.h>
9 #include "ext4_jbd2.h"
10 #include "ext4_extents.h"
11 
12 /*
13  * The contiguous blocks details which can be
14  * represented by a single extent
15  */
16 struct migrate_struct {
17 	ext4_lblk_t first_block, last_block, curr_block;
18 	ext4_fsblk_t first_pblock, last_pblock;
19 };
20 
21 static int finish_range(handle_t *handle, struct inode *inode,
22 				struct migrate_struct *lb)
23 
24 {
25 	int retval = 0, needed;
26 	struct ext4_extent newext;
27 	struct ext4_ext_path *path;
28 	if (lb->first_pblock == 0)
29 		return 0;
30 
31 	/* Add the extent to temp inode*/
32 	newext.ee_block = cpu_to_le32(lb->first_block);
33 	newext.ee_len   = cpu_to_le16(lb->last_block - lb->first_block + 1);
34 	ext4_ext_store_pblock(&newext, lb->first_pblock);
35 	/* Locking only for convinience since we are operating on temp inode */
36 	down_write(&EXT4_I(inode)->i_data_sem);
37 	path = ext4_find_extent(inode, lb->first_block, NULL, 0);
38 	if (IS_ERR(path)) {
39 		retval = PTR_ERR(path);
40 		path = NULL;
41 		goto err_out;
42 	}
43 
44 	/*
45 	 * Calculate the credit needed to inserting this extent
46 	 * Since we are doing this in loop we may accumalate extra
47 	 * credit. But below we try to not accumalate too much
48 	 * of them by restarting the journal.
49 	 */
50 	needed = ext4_ext_calc_credits_for_single_extent(inode,
51 		    lb->last_block - lb->first_block + 1, path);
52 
53 	retval = ext4_datasem_ensure_credits(handle, inode, needed, needed, 0);
54 	if (retval < 0)
55 		goto err_out;
56 	retval = ext4_ext_insert_extent(handle, inode, &path, &newext, 0);
57 err_out:
58 	up_write((&EXT4_I(inode)->i_data_sem));
59 	ext4_ext_drop_refs(path);
60 	kfree(path);
61 	lb->first_pblock = 0;
62 	return retval;
63 }
64 
65 static int update_extent_range(handle_t *handle, struct inode *inode,
66 			       ext4_fsblk_t pblock, struct migrate_struct *lb)
67 {
68 	int retval;
69 	/*
70 	 * See if we can add on to the existing range (if it exists)
71 	 */
72 	if (lb->first_pblock &&
73 		(lb->last_pblock+1 == pblock) &&
74 		(lb->last_block+1 == lb->curr_block)) {
75 		lb->last_pblock = pblock;
76 		lb->last_block = lb->curr_block;
77 		lb->curr_block++;
78 		return 0;
79 	}
80 	/*
81 	 * Start a new range.
82 	 */
83 	retval = finish_range(handle, inode, lb);
84 	lb->first_pblock = lb->last_pblock = pblock;
85 	lb->first_block = lb->last_block = lb->curr_block;
86 	lb->curr_block++;
87 	return retval;
88 }
89 
90 static int update_ind_extent_range(handle_t *handle, struct inode *inode,
91 				   ext4_fsblk_t pblock,
92 				   struct migrate_struct *lb)
93 {
94 	struct buffer_head *bh;
95 	__le32 *i_data;
96 	int i, retval = 0;
97 	unsigned long max_entries = inode->i_sb->s_blocksize >> 2;
98 
99 	bh = ext4_sb_bread(inode->i_sb, pblock, 0);
100 	if (IS_ERR(bh))
101 		return PTR_ERR(bh);
102 
103 	i_data = (__le32 *)bh->b_data;
104 	for (i = 0; i < max_entries; i++) {
105 		if (i_data[i]) {
106 			retval = update_extent_range(handle, inode,
107 						le32_to_cpu(i_data[i]), lb);
108 			if (retval)
109 				break;
110 		} else {
111 			lb->curr_block++;
112 		}
113 	}
114 	put_bh(bh);
115 	return retval;
116 
117 }
118 
119 static int update_dind_extent_range(handle_t *handle, struct inode *inode,
120 				    ext4_fsblk_t pblock,
121 				    struct migrate_struct *lb)
122 {
123 	struct buffer_head *bh;
124 	__le32 *i_data;
125 	int i, retval = 0;
126 	unsigned long max_entries = inode->i_sb->s_blocksize >> 2;
127 
128 	bh = ext4_sb_bread(inode->i_sb, pblock, 0);
129 	if (IS_ERR(bh))
130 		return PTR_ERR(bh);
131 
132 	i_data = (__le32 *)bh->b_data;
133 	for (i = 0; i < max_entries; i++) {
134 		if (i_data[i]) {
135 			retval = update_ind_extent_range(handle, inode,
136 						le32_to_cpu(i_data[i]), lb);
137 			if (retval)
138 				break;
139 		} else {
140 			/* Only update the file block number */
141 			lb->curr_block += max_entries;
142 		}
143 	}
144 	put_bh(bh);
145 	return retval;
146 
147 }
148 
149 static int update_tind_extent_range(handle_t *handle, struct inode *inode,
150 				    ext4_fsblk_t pblock,
151 				    struct migrate_struct *lb)
152 {
153 	struct buffer_head *bh;
154 	__le32 *i_data;
155 	int i, retval = 0;
156 	unsigned long max_entries = inode->i_sb->s_blocksize >> 2;
157 
158 	bh = ext4_sb_bread(inode->i_sb, pblock, 0);
159 	if (IS_ERR(bh))
160 		return PTR_ERR(bh);
161 
162 	i_data = (__le32 *)bh->b_data;
163 	for (i = 0; i < max_entries; i++) {
164 		if (i_data[i]) {
165 			retval = update_dind_extent_range(handle, inode,
166 						le32_to_cpu(i_data[i]), lb);
167 			if (retval)
168 				break;
169 		} else {
170 			/* Only update the file block number */
171 			lb->curr_block += max_entries * max_entries;
172 		}
173 	}
174 	put_bh(bh);
175 	return retval;
176 
177 }
178 
179 static int free_dind_blocks(handle_t *handle,
180 				struct inode *inode, __le32 i_data)
181 {
182 	int i;
183 	__le32 *tmp_idata;
184 	struct buffer_head *bh;
185 	struct super_block *sb = inode->i_sb;
186 	unsigned long max_entries = inode->i_sb->s_blocksize >> 2;
187 	int err;
188 
189 	bh = ext4_sb_bread(sb, le32_to_cpu(i_data), 0);
190 	if (IS_ERR(bh))
191 		return PTR_ERR(bh);
192 
193 	tmp_idata = (__le32 *)bh->b_data;
194 	for (i = 0; i < max_entries; i++) {
195 		if (tmp_idata[i]) {
196 			err = ext4_journal_ensure_credits(handle,
197 				EXT4_RESERVE_TRANS_BLOCKS,
198 				ext4_free_metadata_revoke_credits(sb, 1));
199 			if (err < 0) {
200 				put_bh(bh);
201 				return err;
202 			}
203 			ext4_free_blocks(handle, inode, NULL,
204 					 le32_to_cpu(tmp_idata[i]), 1,
205 					 EXT4_FREE_BLOCKS_METADATA |
206 					 EXT4_FREE_BLOCKS_FORGET);
207 		}
208 	}
209 	put_bh(bh);
210 	err = ext4_journal_ensure_credits(handle, EXT4_RESERVE_TRANS_BLOCKS,
211 				ext4_free_metadata_revoke_credits(sb, 1));
212 	if (err < 0)
213 		return err;
214 	ext4_free_blocks(handle, inode, NULL, le32_to_cpu(i_data), 1,
215 			 EXT4_FREE_BLOCKS_METADATA |
216 			 EXT4_FREE_BLOCKS_FORGET);
217 	return 0;
218 }
219 
220 static int free_tind_blocks(handle_t *handle,
221 				struct inode *inode, __le32 i_data)
222 {
223 	int i, retval = 0;
224 	__le32 *tmp_idata;
225 	struct buffer_head *bh;
226 	unsigned long max_entries = inode->i_sb->s_blocksize >> 2;
227 
228 	bh = ext4_sb_bread(inode->i_sb, le32_to_cpu(i_data), 0);
229 	if (IS_ERR(bh))
230 		return PTR_ERR(bh);
231 
232 	tmp_idata = (__le32 *)bh->b_data;
233 	for (i = 0; i < max_entries; i++) {
234 		if (tmp_idata[i]) {
235 			retval = free_dind_blocks(handle,
236 					inode, tmp_idata[i]);
237 			if (retval) {
238 				put_bh(bh);
239 				return retval;
240 			}
241 		}
242 	}
243 	put_bh(bh);
244 	retval = ext4_journal_ensure_credits(handle, EXT4_RESERVE_TRANS_BLOCKS,
245 			ext4_free_metadata_revoke_credits(inode->i_sb, 1));
246 	if (retval < 0)
247 		return retval;
248 	ext4_free_blocks(handle, inode, NULL, le32_to_cpu(i_data), 1,
249 			 EXT4_FREE_BLOCKS_METADATA |
250 			 EXT4_FREE_BLOCKS_FORGET);
251 	return 0;
252 }
253 
254 static int free_ind_block(handle_t *handle, struct inode *inode, __le32 *i_data)
255 {
256 	int retval;
257 
258 	/* ei->i_data[EXT4_IND_BLOCK] */
259 	if (i_data[0]) {
260 		retval = ext4_journal_ensure_credits(handle,
261 			EXT4_RESERVE_TRANS_BLOCKS,
262 			ext4_free_metadata_revoke_credits(inode->i_sb, 1));
263 		if (retval < 0)
264 			return retval;
265 		ext4_free_blocks(handle, inode, NULL,
266 				le32_to_cpu(i_data[0]), 1,
267 				 EXT4_FREE_BLOCKS_METADATA |
268 				 EXT4_FREE_BLOCKS_FORGET);
269 	}
270 
271 	/* ei->i_data[EXT4_DIND_BLOCK] */
272 	if (i_data[1]) {
273 		retval = free_dind_blocks(handle, inode, i_data[1]);
274 		if (retval)
275 			return retval;
276 	}
277 
278 	/* ei->i_data[EXT4_TIND_BLOCK] */
279 	if (i_data[2]) {
280 		retval = free_tind_blocks(handle, inode, i_data[2]);
281 		if (retval)
282 			return retval;
283 	}
284 	return 0;
285 }
286 
287 static int ext4_ext_swap_inode_data(handle_t *handle, struct inode *inode,
288 						struct inode *tmp_inode)
289 {
290 	int retval;
291 	__le32	i_data[3];
292 	struct ext4_inode_info *ei = EXT4_I(inode);
293 	struct ext4_inode_info *tmp_ei = EXT4_I(tmp_inode);
294 
295 	/*
296 	 * One credit accounted for writing the
297 	 * i_data field of the original inode
298 	 */
299 	retval = ext4_journal_ensure_credits(handle, 1, 0);
300 	if (retval < 0)
301 		goto err_out;
302 
303 	i_data[0] = ei->i_data[EXT4_IND_BLOCK];
304 	i_data[1] = ei->i_data[EXT4_DIND_BLOCK];
305 	i_data[2] = ei->i_data[EXT4_TIND_BLOCK];
306 
307 	down_write(&EXT4_I(inode)->i_data_sem);
308 	/*
309 	 * if EXT4_STATE_EXT_MIGRATE is cleared a block allocation
310 	 * happened after we started the migrate. We need to
311 	 * fail the migrate
312 	 */
313 	if (!ext4_test_inode_state(inode, EXT4_STATE_EXT_MIGRATE)) {
314 		retval = -EAGAIN;
315 		up_write(&EXT4_I(inode)->i_data_sem);
316 		goto err_out;
317 	} else
318 		ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE);
319 	/*
320 	 * We have the extent map build with the tmp inode.
321 	 * Now copy the i_data across
322 	 */
323 	ext4_set_inode_flag(inode, EXT4_INODE_EXTENTS);
324 	memcpy(ei->i_data, tmp_ei->i_data, sizeof(ei->i_data));
325 
326 	/*
327 	 * Update i_blocks with the new blocks that got
328 	 * allocated while adding extents for extent index
329 	 * blocks.
330 	 *
331 	 * While converting to extents we need not
332 	 * update the original inode i_blocks for extent blocks
333 	 * via quota APIs. The quota update happened via tmp_inode already.
334 	 */
335 	spin_lock(&inode->i_lock);
336 	inode->i_blocks += tmp_inode->i_blocks;
337 	spin_unlock(&inode->i_lock);
338 	up_write(&EXT4_I(inode)->i_data_sem);
339 
340 	/*
341 	 * We mark the inode dirty after, because we decrement the
342 	 * i_blocks when freeing the indirect meta-data blocks
343 	 */
344 	retval = free_ind_block(handle, inode, i_data);
345 	ext4_mark_inode_dirty(handle, inode);
346 
347 err_out:
348 	return retval;
349 }
350 
351 static int free_ext_idx(handle_t *handle, struct inode *inode,
352 					struct ext4_extent_idx *ix)
353 {
354 	int i, retval = 0;
355 	ext4_fsblk_t block;
356 	struct buffer_head *bh;
357 	struct ext4_extent_header *eh;
358 
359 	block = ext4_idx_pblock(ix);
360 	bh = ext4_sb_bread(inode->i_sb, block, 0);
361 	if (IS_ERR(bh))
362 		return PTR_ERR(bh);
363 
364 	eh = (struct ext4_extent_header *)bh->b_data;
365 	if (eh->eh_depth != 0) {
366 		ix = EXT_FIRST_INDEX(eh);
367 		for (i = 0; i < le16_to_cpu(eh->eh_entries); i++, ix++) {
368 			retval = free_ext_idx(handle, inode, ix);
369 			if (retval) {
370 				put_bh(bh);
371 				return retval;
372 			}
373 		}
374 	}
375 	put_bh(bh);
376 	retval = ext4_journal_ensure_credits(handle, EXT4_RESERVE_TRANS_BLOCKS,
377 			ext4_free_metadata_revoke_credits(inode->i_sb, 1));
378 	if (retval < 0)
379 		return retval;
380 	ext4_free_blocks(handle, inode, NULL, block, 1,
381 			 EXT4_FREE_BLOCKS_METADATA | EXT4_FREE_BLOCKS_FORGET);
382 	return 0;
383 }
384 
385 /*
386  * Free the extent meta data blocks only
387  */
388 static int free_ext_block(handle_t *handle, struct inode *inode)
389 {
390 	int i, retval = 0;
391 	struct ext4_inode_info *ei = EXT4_I(inode);
392 	struct ext4_extent_header *eh = (struct ext4_extent_header *)ei->i_data;
393 	struct ext4_extent_idx *ix;
394 	if (eh->eh_depth == 0)
395 		/*
396 		 * No extra blocks allocated for extent meta data
397 		 */
398 		return 0;
399 	ix = EXT_FIRST_INDEX(eh);
400 	for (i = 0; i < le16_to_cpu(eh->eh_entries); i++, ix++) {
401 		retval = free_ext_idx(handle, inode, ix);
402 		if (retval)
403 			return retval;
404 	}
405 	return retval;
406 }
407 
408 int ext4_ext_migrate(struct inode *inode)
409 {
410 	handle_t *handle;
411 	int retval = 0, i;
412 	__le32 *i_data;
413 	struct ext4_inode_info *ei;
414 	struct inode *tmp_inode = NULL;
415 	struct migrate_struct lb;
416 	unsigned long max_entries;
417 	__u32 goal;
418 	uid_t owner[2];
419 
420 	/*
421 	 * If the filesystem does not support extents, or the inode
422 	 * already is extent-based, error out.
423 	 */
424 	if (!ext4_has_feature_extents(inode->i_sb) ||
425 	    (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
426 		return -EINVAL;
427 
428 	if (S_ISLNK(inode->i_mode) && inode->i_blocks == 0)
429 		/*
430 		 * don't migrate fast symlink
431 		 */
432 		return retval;
433 
434 	/*
435 	 * Worst case we can touch the allocation bitmaps, a bgd
436 	 * block, and a block to link in the orphan list.  We do need
437 	 * need to worry about credits for modifying the quota inode.
438 	 */
439 	handle = ext4_journal_start(inode, EXT4_HT_MIGRATE,
440 		4 + EXT4_MAXQUOTAS_TRANS_BLOCKS(inode->i_sb));
441 
442 	if (IS_ERR(handle)) {
443 		retval = PTR_ERR(handle);
444 		return retval;
445 	}
446 	goal = (((inode->i_ino - 1) / EXT4_INODES_PER_GROUP(inode->i_sb)) *
447 		EXT4_INODES_PER_GROUP(inode->i_sb)) + 1;
448 	owner[0] = i_uid_read(inode);
449 	owner[1] = i_gid_read(inode);
450 	tmp_inode = ext4_new_inode(handle, d_inode(inode->i_sb->s_root),
451 				   S_IFREG, NULL, goal, owner, 0);
452 	if (IS_ERR(tmp_inode)) {
453 		retval = PTR_ERR(tmp_inode);
454 		ext4_journal_stop(handle);
455 		return retval;
456 	}
457 	i_size_write(tmp_inode, i_size_read(inode));
458 	/*
459 	 * Set the i_nlink to zero so it will be deleted later
460 	 * when we drop inode reference.
461 	 */
462 	clear_nlink(tmp_inode);
463 
464 	ext4_ext_tree_init(handle, tmp_inode);
465 	ext4_orphan_add(handle, tmp_inode);
466 	ext4_journal_stop(handle);
467 
468 	/*
469 	 * start with one credit accounted for
470 	 * superblock modification.
471 	 *
472 	 * For the tmp_inode we already have committed the
473 	 * transaction that created the inode. Later as and
474 	 * when we add extents we extent the journal
475 	 */
476 	/*
477 	 * Even though we take i_mutex we can still cause block
478 	 * allocation via mmap write to holes. If we have allocated
479 	 * new blocks we fail migrate.  New block allocation will
480 	 * clear EXT4_STATE_EXT_MIGRATE flag.  The flag is updated
481 	 * with i_data_sem held to prevent racing with block
482 	 * allocation.
483 	 */
484 	down_read(&EXT4_I(inode)->i_data_sem);
485 	ext4_set_inode_state(inode, EXT4_STATE_EXT_MIGRATE);
486 	up_read((&EXT4_I(inode)->i_data_sem));
487 
488 	handle = ext4_journal_start(inode, EXT4_HT_MIGRATE, 1);
489 	if (IS_ERR(handle)) {
490 		/*
491 		 * It is impossible to update on-disk structures without
492 		 * a handle, so just rollback in-core changes and live other
493 		 * work to orphan_list_cleanup()
494 		 */
495 		ext4_orphan_del(NULL, tmp_inode);
496 		retval = PTR_ERR(handle);
497 		goto out;
498 	}
499 
500 	ei = EXT4_I(inode);
501 	i_data = ei->i_data;
502 	memset(&lb, 0, sizeof(lb));
503 
504 	/* 32 bit block address 4 bytes */
505 	max_entries = inode->i_sb->s_blocksize >> 2;
506 	for (i = 0; i < EXT4_NDIR_BLOCKS; i++) {
507 		if (i_data[i]) {
508 			retval = update_extent_range(handle, tmp_inode,
509 						le32_to_cpu(i_data[i]), &lb);
510 			if (retval)
511 				goto err_out;
512 		} else
513 			lb.curr_block++;
514 	}
515 	if (i_data[EXT4_IND_BLOCK]) {
516 		retval = update_ind_extent_range(handle, tmp_inode,
517 				le32_to_cpu(i_data[EXT4_IND_BLOCK]), &lb);
518 		if (retval)
519 			goto err_out;
520 	} else
521 		lb.curr_block += max_entries;
522 	if (i_data[EXT4_DIND_BLOCK]) {
523 		retval = update_dind_extent_range(handle, tmp_inode,
524 				le32_to_cpu(i_data[EXT4_DIND_BLOCK]), &lb);
525 		if (retval)
526 			goto err_out;
527 	} else
528 		lb.curr_block += max_entries * max_entries;
529 	if (i_data[EXT4_TIND_BLOCK]) {
530 		retval = update_tind_extent_range(handle, tmp_inode,
531 				le32_to_cpu(i_data[EXT4_TIND_BLOCK]), &lb);
532 		if (retval)
533 			goto err_out;
534 	}
535 	/*
536 	 * Build the last extent
537 	 */
538 	retval = finish_range(handle, tmp_inode, &lb);
539 err_out:
540 	if (retval)
541 		/*
542 		 * Failure case delete the extent information with the
543 		 * tmp_inode
544 		 */
545 		free_ext_block(handle, tmp_inode);
546 	else {
547 		retval = ext4_ext_swap_inode_data(handle, inode, tmp_inode);
548 		if (retval)
549 			/*
550 			 * if we fail to swap inode data free the extent
551 			 * details of the tmp inode
552 			 */
553 			free_ext_block(handle, tmp_inode);
554 	}
555 
556 	/* We mark the tmp_inode dirty via ext4_ext_tree_init. */
557 	retval = ext4_journal_ensure_credits(handle, 1, 0);
558 	if (retval < 0)
559 		goto out_stop;
560 	/*
561 	 * Mark the tmp_inode as of size zero
562 	 */
563 	i_size_write(tmp_inode, 0);
564 
565 	/*
566 	 * set the  i_blocks count to zero
567 	 * so that the ext4_evict_inode() does the
568 	 * right job
569 	 *
570 	 * We don't need to take the i_lock because
571 	 * the inode is not visible to user space.
572 	 */
573 	tmp_inode->i_blocks = 0;
574 
575 	/* Reset the extent details */
576 	ext4_ext_tree_init(handle, tmp_inode);
577 out_stop:
578 	ext4_journal_stop(handle);
579 out:
580 	unlock_new_inode(tmp_inode);
581 	iput(tmp_inode);
582 
583 	return retval;
584 }
585 
586 /*
587  * Migrate a simple extent-based inode to use the i_blocks[] array
588  */
589 int ext4_ind_migrate(struct inode *inode)
590 {
591 	struct ext4_extent_header	*eh;
592 	struct ext4_super_block		*es = EXT4_SB(inode->i_sb)->s_es;
593 	struct ext4_inode_info		*ei = EXT4_I(inode);
594 	struct ext4_extent		*ex;
595 	unsigned int			i, len;
596 	ext4_lblk_t			start, end;
597 	ext4_fsblk_t			blk;
598 	handle_t			*handle;
599 	int				ret;
600 
601 	if (!ext4_has_feature_extents(inode->i_sb) ||
602 	    (!ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
603 		return -EINVAL;
604 
605 	if (ext4_has_feature_bigalloc(inode->i_sb))
606 		return -EOPNOTSUPP;
607 
608 	/*
609 	 * In order to get correct extent info, force all delayed allocation
610 	 * blocks to be allocated, otherwise delayed allocation blocks may not
611 	 * be reflected and bypass the checks on extent header.
612 	 */
613 	if (test_opt(inode->i_sb, DELALLOC))
614 		ext4_alloc_da_blocks(inode);
615 
616 	handle = ext4_journal_start(inode, EXT4_HT_MIGRATE, 1);
617 	if (IS_ERR(handle))
618 		return PTR_ERR(handle);
619 
620 	down_write(&EXT4_I(inode)->i_data_sem);
621 	ret = ext4_ext_check_inode(inode);
622 	if (ret)
623 		goto errout;
624 
625 	eh = ext_inode_hdr(inode);
626 	ex  = EXT_FIRST_EXTENT(eh);
627 	if (ext4_blocks_count(es) > EXT4_MAX_BLOCK_FILE_PHYS ||
628 	    eh->eh_depth != 0 || le16_to_cpu(eh->eh_entries) > 1) {
629 		ret = -EOPNOTSUPP;
630 		goto errout;
631 	}
632 	if (eh->eh_entries == 0)
633 		blk = len = start = end = 0;
634 	else {
635 		len = le16_to_cpu(ex->ee_len);
636 		blk = ext4_ext_pblock(ex);
637 		start = le32_to_cpu(ex->ee_block);
638 		end = start + len - 1;
639 		if (end >= EXT4_NDIR_BLOCKS) {
640 			ret = -EOPNOTSUPP;
641 			goto errout;
642 		}
643 	}
644 
645 	ext4_clear_inode_flag(inode, EXT4_INODE_EXTENTS);
646 	memset(ei->i_data, 0, sizeof(ei->i_data));
647 	for (i = start; i <= end; i++)
648 		ei->i_data[i] = cpu_to_le32(blk++);
649 	ext4_mark_inode_dirty(handle, inode);
650 errout:
651 	ext4_journal_stop(handle);
652 	up_write(&EXT4_I(inode)->i_data_sem);
653 	return ret;
654 }
655