xref: /openbmc/linux/drivers/tty/serial/8250/8250_dw.c (revision 7bcae826)
1 /*
2  * Synopsys DesignWare 8250 driver.
3  *
4  * Copyright 2011 Picochip, Jamie Iles.
5  * Copyright 2013 Intel Corporation
6  *
7  * This program is free software; you can redistribute it and/or modify
8  * it under the terms of the GNU General Public License as published by
9  * the Free Software Foundation; either version 2 of the License, or
10  * (at your option) any later version.
11  *
12  * The Synopsys DesignWare 8250 has an extra feature whereby it detects if the
13  * LCR is written whilst busy.  If it is, then a busy detect interrupt is
14  * raised, the LCR needs to be rewritten and the uart status register read.
15  */
16 #include <linux/device.h>
17 #include <linux/io.h>
18 #include <linux/module.h>
19 #include <linux/serial_8250.h>
20 #include <linux/serial_reg.h>
21 #include <linux/of.h>
22 #include <linux/of_irq.h>
23 #include <linux/of_platform.h>
24 #include <linux/platform_device.h>
25 #include <linux/slab.h>
26 #include <linux/acpi.h>
27 #include <linux/clk.h>
28 #include <linux/reset.h>
29 #include <linux/pm_runtime.h>
30 
31 #include <asm/byteorder.h>
32 
33 #include "8250.h"
34 
35 /* Offsets for the DesignWare specific registers */
36 #define DW_UART_USR	0x1f /* UART Status Register */
37 #define DW_UART_CPR	0xf4 /* Component Parameter Register */
38 #define DW_UART_UCV	0xf8 /* UART Component Version */
39 
40 /* Component Parameter Register bits */
41 #define DW_UART_CPR_ABP_DATA_WIDTH	(3 << 0)
42 #define DW_UART_CPR_AFCE_MODE		(1 << 4)
43 #define DW_UART_CPR_THRE_MODE		(1 << 5)
44 #define DW_UART_CPR_SIR_MODE		(1 << 6)
45 #define DW_UART_CPR_SIR_LP_MODE		(1 << 7)
46 #define DW_UART_CPR_ADDITIONAL_FEATURES	(1 << 8)
47 #define DW_UART_CPR_FIFO_ACCESS		(1 << 9)
48 #define DW_UART_CPR_FIFO_STAT		(1 << 10)
49 #define DW_UART_CPR_SHADOW		(1 << 11)
50 #define DW_UART_CPR_ENCODED_PARMS	(1 << 12)
51 #define DW_UART_CPR_DMA_EXTRA		(1 << 13)
52 #define DW_UART_CPR_FIFO_MODE		(0xff << 16)
53 /* Helper for fifo size calculation */
54 #define DW_UART_CPR_FIFO_SIZE(a)	(((a >> 16) & 0xff) * 16)
55 
56 /* DesignWare specific register fields */
57 #define DW_UART_MCR_SIRE		BIT(6)
58 
59 struct dw8250_data {
60 	u8			usr_reg;
61 	int			line;
62 	int			msr_mask_on;
63 	int			msr_mask_off;
64 	struct clk		*clk;
65 	struct clk		*pclk;
66 	struct reset_control	*rst;
67 	struct uart_8250_dma	dma;
68 
69 	unsigned int		skip_autocfg:1;
70 	unsigned int		uart_16550_compatible:1;
71 };
72 
73 static inline int dw8250_modify_msr(struct uart_port *p, int offset, int value)
74 {
75 	struct dw8250_data *d = p->private_data;
76 
77 	/* Override any modem control signals if needed */
78 	if (offset == UART_MSR) {
79 		value |= d->msr_mask_on;
80 		value &= ~d->msr_mask_off;
81 	}
82 
83 	return value;
84 }
85 
86 static void dw8250_force_idle(struct uart_port *p)
87 {
88 	struct uart_8250_port *up = up_to_u8250p(p);
89 
90 	serial8250_clear_and_reinit_fifos(up);
91 	(void)p->serial_in(p, UART_RX);
92 }
93 
94 static void dw8250_check_lcr(struct uart_port *p, int value)
95 {
96 	void __iomem *offset = p->membase + (UART_LCR << p->regshift);
97 	int tries = 1000;
98 
99 	/* Make sure LCR write wasn't ignored */
100 	while (tries--) {
101 		unsigned int lcr = p->serial_in(p, UART_LCR);
102 
103 		if ((value & ~UART_LCR_SPAR) == (lcr & ~UART_LCR_SPAR))
104 			return;
105 
106 		dw8250_force_idle(p);
107 
108 #ifdef CONFIG_64BIT
109 		if (p->type == PORT_OCTEON)
110 			__raw_writeq(value & 0xff, offset);
111 		else
112 #endif
113 		if (p->iotype == UPIO_MEM32)
114 			writel(value, offset);
115 		else if (p->iotype == UPIO_MEM32BE)
116 			iowrite32be(value, offset);
117 		else
118 			writeb(value, offset);
119 	}
120 	/*
121 	 * FIXME: this deadlocks if port->lock is already held
122 	 * dev_err(p->dev, "Couldn't set LCR to %d\n", value);
123 	 */
124 }
125 
126 static void dw8250_serial_out(struct uart_port *p, int offset, int value)
127 {
128 	struct dw8250_data *d = p->private_data;
129 
130 	writeb(value, p->membase + (offset << p->regshift));
131 
132 	if (offset == UART_LCR && !d->uart_16550_compatible)
133 		dw8250_check_lcr(p, value);
134 }
135 
136 static unsigned int dw8250_serial_in(struct uart_port *p, int offset)
137 {
138 	unsigned int value = readb(p->membase + (offset << p->regshift));
139 
140 	return dw8250_modify_msr(p, offset, value);
141 }
142 
143 #ifdef CONFIG_64BIT
144 static unsigned int dw8250_serial_inq(struct uart_port *p, int offset)
145 {
146 	unsigned int value;
147 
148 	value = (u8)__raw_readq(p->membase + (offset << p->regshift));
149 
150 	return dw8250_modify_msr(p, offset, value);
151 }
152 
153 static void dw8250_serial_outq(struct uart_port *p, int offset, int value)
154 {
155 	struct dw8250_data *d = p->private_data;
156 
157 	value &= 0xff;
158 	__raw_writeq(value, p->membase + (offset << p->regshift));
159 	/* Read back to ensure register write ordering. */
160 	__raw_readq(p->membase + (UART_LCR << p->regshift));
161 
162 	if (offset == UART_LCR && !d->uart_16550_compatible)
163 		dw8250_check_lcr(p, value);
164 }
165 #endif /* CONFIG_64BIT */
166 
167 static void dw8250_serial_out32(struct uart_port *p, int offset, int value)
168 {
169 	struct dw8250_data *d = p->private_data;
170 
171 	writel(value, p->membase + (offset << p->regshift));
172 
173 	if (offset == UART_LCR && !d->uart_16550_compatible)
174 		dw8250_check_lcr(p, value);
175 }
176 
177 static unsigned int dw8250_serial_in32(struct uart_port *p, int offset)
178 {
179 	unsigned int value = readl(p->membase + (offset << p->regshift));
180 
181 	return dw8250_modify_msr(p, offset, value);
182 }
183 
184 static void dw8250_serial_out32be(struct uart_port *p, int offset, int value)
185 {
186 	struct dw8250_data *d = p->private_data;
187 
188 	iowrite32be(value, p->membase + (offset << p->regshift));
189 
190 	if (offset == UART_LCR && !d->uart_16550_compatible)
191 		dw8250_check_lcr(p, value);
192 }
193 
194 static unsigned int dw8250_serial_in32be(struct uart_port *p, int offset)
195 {
196        unsigned int value = ioread32be(p->membase + (offset << p->regshift));
197 
198        return dw8250_modify_msr(p, offset, value);
199 }
200 
201 
202 static int dw8250_handle_irq(struct uart_port *p)
203 {
204 	struct uart_8250_port *up = up_to_u8250p(p);
205 	struct dw8250_data *d = p->private_data;
206 	unsigned int iir = p->serial_in(p, UART_IIR);
207 	unsigned int status;
208 	unsigned long flags;
209 
210 	/*
211 	 * There are ways to get Designware-based UARTs into a state where
212 	 * they are asserting UART_IIR_RX_TIMEOUT but there is no actual
213 	 * data available.  If we see such a case then we'll do a bogus
214 	 * read.  If we don't do this then the "RX TIMEOUT" interrupt will
215 	 * fire forever.
216 	 *
217 	 * This problem has only been observed so far when not in DMA mode
218 	 * so we limit the workaround only to non-DMA mode.
219 	 */
220 	if (!up->dma && ((iir & 0x3f) == UART_IIR_RX_TIMEOUT)) {
221 		spin_lock_irqsave(&p->lock, flags);
222 		status = p->serial_in(p, UART_LSR);
223 
224 		if (!(status & (UART_LSR_DR | UART_LSR_BI)))
225 			(void) p->serial_in(p, UART_RX);
226 
227 		spin_unlock_irqrestore(&p->lock, flags);
228 	}
229 
230 	if (serial8250_handle_irq(p, iir))
231 		return 1;
232 
233 	if ((iir & UART_IIR_BUSY) == UART_IIR_BUSY) {
234 		/* Clear the USR */
235 		(void)p->serial_in(p, d->usr_reg);
236 
237 		return 1;
238 	}
239 
240 	return 0;
241 }
242 
243 static void
244 dw8250_do_pm(struct uart_port *port, unsigned int state, unsigned int old)
245 {
246 	if (!state)
247 		pm_runtime_get_sync(port->dev);
248 
249 	serial8250_do_pm(port, state, old);
250 
251 	if (state)
252 		pm_runtime_put_sync_suspend(port->dev);
253 }
254 
255 static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
256 			       struct ktermios *old)
257 {
258 	unsigned int baud = tty_termios_baud_rate(termios);
259 	struct dw8250_data *d = p->private_data;
260 	unsigned int rate;
261 	int ret;
262 
263 	if (IS_ERR(d->clk) || !old)
264 		goto out;
265 
266 	clk_disable_unprepare(d->clk);
267 	rate = clk_round_rate(d->clk, baud * 16);
268 	ret = clk_set_rate(d->clk, rate);
269 	clk_prepare_enable(d->clk);
270 
271 	if (!ret)
272 		p->uartclk = rate;
273 
274 out:
275 	p->status &= ~UPSTAT_AUTOCTS;
276 	if (termios->c_cflag & CRTSCTS)
277 		p->status |= UPSTAT_AUTOCTS;
278 
279 	serial8250_do_set_termios(p, termios, old);
280 }
281 
282 static void dw8250_set_ldisc(struct uart_port *p, struct ktermios *termios)
283 {
284 	struct uart_8250_port *up = up_to_u8250p(p);
285 	unsigned int mcr = p->serial_in(p, UART_MCR);
286 
287 	if (up->capabilities & UART_CAP_IRDA) {
288 		if (termios->c_line == N_IRDA)
289 			mcr |= DW_UART_MCR_SIRE;
290 		else
291 			mcr &= ~DW_UART_MCR_SIRE;
292 
293 		p->serial_out(p, UART_MCR, mcr);
294 	}
295 	serial8250_do_set_ldisc(p, termios);
296 }
297 
298 /*
299  * dw8250_fallback_dma_filter will prevent the UART from getting just any free
300  * channel on platforms that have DMA engines, but don't have any channels
301  * assigned to the UART.
302  *
303  * REVISIT: This is a work around for limitation in the DMA Engine API. Once the
304  * core problem is fixed, this function is no longer needed.
305  */
306 static bool dw8250_fallback_dma_filter(struct dma_chan *chan, void *param)
307 {
308 	return false;
309 }
310 
311 static bool dw8250_idma_filter(struct dma_chan *chan, void *param)
312 {
313 	return param == chan->device->dev->parent;
314 }
315 
316 static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
317 {
318 	if (p->dev->of_node) {
319 		struct device_node *np = p->dev->of_node;
320 		int id;
321 
322 		/* get index of serial line, if found in DT aliases */
323 		id = of_alias_get_id(np, "serial");
324 		if (id >= 0)
325 			p->line = id;
326 #ifdef CONFIG_64BIT
327 		if (of_device_is_compatible(np, "cavium,octeon-3860-uart")) {
328 			p->serial_in = dw8250_serial_inq;
329 			p->serial_out = dw8250_serial_outq;
330 			p->flags = UPF_SKIP_TEST | UPF_SHARE_IRQ | UPF_FIXED_TYPE;
331 			p->type = PORT_OCTEON;
332 			data->usr_reg = 0x27;
333 			data->skip_autocfg = true;
334 		}
335 #endif
336 		if (of_device_is_big_endian(p->dev->of_node)) {
337 			p->iotype = UPIO_MEM32BE;
338 			p->serial_in = dw8250_serial_in32be;
339 			p->serial_out = dw8250_serial_out32be;
340 		}
341 	} else if (has_acpi_companion(p->dev)) {
342 		const struct acpi_device_id *id;
343 
344 		id = acpi_match_device(p->dev->driver->acpi_match_table,
345 				       p->dev);
346 		if (id && !strcmp(id->id, "APMC0D08")) {
347 			p->iotype = UPIO_MEM32;
348 			p->regshift = 2;
349 			p->serial_in = dw8250_serial_in32;
350 			data->uart_16550_compatible = true;
351 		}
352 	}
353 
354 	/* Platforms with iDMA */
355 	if (platform_get_resource_byname(to_platform_device(p->dev),
356 					 IORESOURCE_MEM, "lpss_priv")) {
357 		data->dma.rx_param = p->dev->parent;
358 		data->dma.tx_param = p->dev->parent;
359 		data->dma.fn = dw8250_idma_filter;
360 	}
361 }
362 
363 static void dw8250_setup_port(struct uart_port *p)
364 {
365 	struct uart_8250_port *up = up_to_u8250p(p);
366 	u32 reg;
367 
368 	/*
369 	 * If the Component Version Register returns zero, we know that
370 	 * ADDITIONAL_FEATURES are not enabled. No need to go any further.
371 	 */
372 	if (p->iotype == UPIO_MEM32BE)
373 		reg = ioread32be(p->membase + DW_UART_UCV);
374 	else
375 		reg = readl(p->membase + DW_UART_UCV);
376 	if (!reg)
377 		return;
378 
379 	dev_dbg(p->dev, "Designware UART version %c.%c%c\n",
380 		(reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff);
381 
382 	if (p->iotype == UPIO_MEM32BE)
383 		reg = ioread32be(p->membase + DW_UART_CPR);
384 	else
385 		reg = readl(p->membase + DW_UART_CPR);
386 	if (!reg)
387 		return;
388 
389 	/* Select the type based on fifo */
390 	if (reg & DW_UART_CPR_FIFO_MODE) {
391 		p->type = PORT_16550A;
392 		p->flags |= UPF_FIXED_TYPE;
393 		p->fifosize = DW_UART_CPR_FIFO_SIZE(reg);
394 		up->capabilities = UART_CAP_FIFO;
395 	}
396 
397 	if (reg & DW_UART_CPR_AFCE_MODE)
398 		up->capabilities |= UART_CAP_AFE;
399 
400 	if (reg & DW_UART_CPR_SIR_MODE)
401 		up->capabilities |= UART_CAP_IRDA;
402 }
403 
404 static int dw8250_probe(struct platform_device *pdev)
405 {
406 	struct uart_8250_port uart = {};
407 	struct resource *regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
408 	int irq = platform_get_irq(pdev, 0);
409 	struct uart_port *p = &uart.port;
410 	struct device *dev = &pdev->dev;
411 	struct dw8250_data *data;
412 	int err;
413 	u32 val;
414 
415 	if (!regs) {
416 		dev_err(dev, "no registers defined\n");
417 		return -EINVAL;
418 	}
419 
420 	if (irq < 0) {
421 		if (irq != -EPROBE_DEFER)
422 			dev_err(dev, "cannot get irq\n");
423 		return irq;
424 	}
425 
426 	spin_lock_init(&p->lock);
427 	p->mapbase	= regs->start;
428 	p->irq		= irq;
429 	p->handle_irq	= dw8250_handle_irq;
430 	p->pm		= dw8250_do_pm;
431 	p->type		= PORT_8250;
432 	p->flags	= UPF_SHARE_IRQ | UPF_FIXED_PORT;
433 	p->dev		= dev;
434 	p->iotype	= UPIO_MEM;
435 	p->serial_in	= dw8250_serial_in;
436 	p->serial_out	= dw8250_serial_out;
437 	p->set_ldisc	= dw8250_set_ldisc;
438 	p->set_termios	= dw8250_set_termios;
439 
440 	p->membase = devm_ioremap(dev, regs->start, resource_size(regs));
441 	if (!p->membase)
442 		return -ENOMEM;
443 
444 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
445 	if (!data)
446 		return -ENOMEM;
447 
448 	data->dma.fn = dw8250_fallback_dma_filter;
449 	data->usr_reg = DW_UART_USR;
450 	p->private_data = data;
451 
452 	data->uart_16550_compatible = device_property_read_bool(dev,
453 						"snps,uart-16550-compatible");
454 
455 	err = device_property_read_u32(dev, "reg-shift", &val);
456 	if (!err)
457 		p->regshift = val;
458 
459 	err = device_property_read_u32(dev, "reg-io-width", &val);
460 	if (!err && val == 4) {
461 		p->iotype = UPIO_MEM32;
462 		p->serial_in = dw8250_serial_in32;
463 		p->serial_out = dw8250_serial_out32;
464 	}
465 
466 	if (device_property_read_bool(dev, "dcd-override")) {
467 		/* Always report DCD as active */
468 		data->msr_mask_on |= UART_MSR_DCD;
469 		data->msr_mask_off |= UART_MSR_DDCD;
470 	}
471 
472 	if (device_property_read_bool(dev, "dsr-override")) {
473 		/* Always report DSR as active */
474 		data->msr_mask_on |= UART_MSR_DSR;
475 		data->msr_mask_off |= UART_MSR_DDSR;
476 	}
477 
478 	if (device_property_read_bool(dev, "cts-override")) {
479 		/* Always report CTS as active */
480 		data->msr_mask_on |= UART_MSR_CTS;
481 		data->msr_mask_off |= UART_MSR_DCTS;
482 	}
483 
484 	if (device_property_read_bool(dev, "ri-override")) {
485 		/* Always report Ring indicator as inactive */
486 		data->msr_mask_off |= UART_MSR_RI;
487 		data->msr_mask_off |= UART_MSR_TERI;
488 	}
489 
490 	/* Always ask for fixed clock rate from a property. */
491 	device_property_read_u32(dev, "clock-frequency", &p->uartclk);
492 
493 	/* If there is separate baudclk, get the rate from it. */
494 	data->clk = devm_clk_get(dev, "baudclk");
495 	if (IS_ERR(data->clk) && PTR_ERR(data->clk) != -EPROBE_DEFER)
496 		data->clk = devm_clk_get(dev, NULL);
497 	if (IS_ERR(data->clk) && PTR_ERR(data->clk) == -EPROBE_DEFER)
498 		return -EPROBE_DEFER;
499 	if (!IS_ERR_OR_NULL(data->clk)) {
500 		err = clk_prepare_enable(data->clk);
501 		if (err)
502 			dev_warn(dev, "could not enable optional baudclk: %d\n",
503 				 err);
504 		else
505 			p->uartclk = clk_get_rate(data->clk);
506 	}
507 
508 	/* If no clock rate is defined, fail. */
509 	if (!p->uartclk) {
510 		dev_err(dev, "clock rate not defined\n");
511 		return -EINVAL;
512 	}
513 
514 	data->pclk = devm_clk_get(dev, "apb_pclk");
515 	if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) == -EPROBE_DEFER) {
516 		err = -EPROBE_DEFER;
517 		goto err_clk;
518 	}
519 	if (!IS_ERR(data->pclk)) {
520 		err = clk_prepare_enable(data->pclk);
521 		if (err) {
522 			dev_err(dev, "could not enable apb_pclk\n");
523 			goto err_clk;
524 		}
525 	}
526 
527 	data->rst = devm_reset_control_get_optional(dev, NULL);
528 	if (IS_ERR(data->rst) && PTR_ERR(data->rst) == -EPROBE_DEFER) {
529 		err = -EPROBE_DEFER;
530 		goto err_pclk;
531 	}
532 	if (!IS_ERR(data->rst))
533 		reset_control_deassert(data->rst);
534 
535 	dw8250_quirks(p, data);
536 
537 	/* If the Busy Functionality is not implemented, don't handle it */
538 	if (data->uart_16550_compatible)
539 		p->handle_irq = NULL;
540 
541 	if (!data->skip_autocfg)
542 		dw8250_setup_port(p);
543 
544 	/* If we have a valid fifosize, try hooking up DMA */
545 	if (p->fifosize) {
546 		data->dma.rxconf.src_maxburst = p->fifosize / 4;
547 		data->dma.txconf.dst_maxburst = p->fifosize / 4;
548 		uart.dma = &data->dma;
549 	}
550 
551 	data->line = serial8250_register_8250_port(&uart);
552 	if (data->line < 0) {
553 		err = data->line;
554 		goto err_reset;
555 	}
556 
557 	platform_set_drvdata(pdev, data);
558 
559 	pm_runtime_set_active(dev);
560 	pm_runtime_enable(dev);
561 
562 	return 0;
563 
564 err_reset:
565 	if (!IS_ERR(data->rst))
566 		reset_control_assert(data->rst);
567 
568 err_pclk:
569 	if (!IS_ERR(data->pclk))
570 		clk_disable_unprepare(data->pclk);
571 
572 err_clk:
573 	if (!IS_ERR(data->clk))
574 		clk_disable_unprepare(data->clk);
575 
576 	return err;
577 }
578 
579 static int dw8250_remove(struct platform_device *pdev)
580 {
581 	struct dw8250_data *data = platform_get_drvdata(pdev);
582 
583 	pm_runtime_get_sync(&pdev->dev);
584 
585 	serial8250_unregister_port(data->line);
586 
587 	if (!IS_ERR(data->rst))
588 		reset_control_assert(data->rst);
589 
590 	if (!IS_ERR(data->pclk))
591 		clk_disable_unprepare(data->pclk);
592 
593 	if (!IS_ERR(data->clk))
594 		clk_disable_unprepare(data->clk);
595 
596 	pm_runtime_disable(&pdev->dev);
597 	pm_runtime_put_noidle(&pdev->dev);
598 
599 	return 0;
600 }
601 
602 #ifdef CONFIG_PM_SLEEP
603 static int dw8250_suspend(struct device *dev)
604 {
605 	struct dw8250_data *data = dev_get_drvdata(dev);
606 
607 	serial8250_suspend_port(data->line);
608 
609 	return 0;
610 }
611 
612 static int dw8250_resume(struct device *dev)
613 {
614 	struct dw8250_data *data = dev_get_drvdata(dev);
615 
616 	serial8250_resume_port(data->line);
617 
618 	return 0;
619 }
620 #endif /* CONFIG_PM_SLEEP */
621 
622 #ifdef CONFIG_PM
623 static int dw8250_runtime_suspend(struct device *dev)
624 {
625 	struct dw8250_data *data = dev_get_drvdata(dev);
626 
627 	if (!IS_ERR(data->clk))
628 		clk_disable_unprepare(data->clk);
629 
630 	if (!IS_ERR(data->pclk))
631 		clk_disable_unprepare(data->pclk);
632 
633 	return 0;
634 }
635 
636 static int dw8250_runtime_resume(struct device *dev)
637 {
638 	struct dw8250_data *data = dev_get_drvdata(dev);
639 
640 	if (!IS_ERR(data->pclk))
641 		clk_prepare_enable(data->pclk);
642 
643 	if (!IS_ERR(data->clk))
644 		clk_prepare_enable(data->clk);
645 
646 	return 0;
647 }
648 #endif
649 
650 static const struct dev_pm_ops dw8250_pm_ops = {
651 	SET_SYSTEM_SLEEP_PM_OPS(dw8250_suspend, dw8250_resume)
652 	SET_RUNTIME_PM_OPS(dw8250_runtime_suspend, dw8250_runtime_resume, NULL)
653 };
654 
655 static const struct of_device_id dw8250_of_match[] = {
656 	{ .compatible = "snps,dw-apb-uart" },
657 	{ .compatible = "cavium,octeon-3860-uart" },
658 	{ /* Sentinel */ }
659 };
660 MODULE_DEVICE_TABLE(of, dw8250_of_match);
661 
662 static const struct acpi_device_id dw8250_acpi_match[] = {
663 	{ "INT33C4", 0 },
664 	{ "INT33C5", 0 },
665 	{ "INT3434", 0 },
666 	{ "INT3435", 0 },
667 	{ "80860F0A", 0 },
668 	{ "8086228A", 0 },
669 	{ "APMC0D08", 0},
670 	{ "AMD0020", 0 },
671 	{ "AMDI0020", 0 },
672 	{ "HISI0031", 0 },
673 	{ },
674 };
675 MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
676 
677 static struct platform_driver dw8250_platform_driver = {
678 	.driver = {
679 		.name		= "dw-apb-uart",
680 		.pm		= &dw8250_pm_ops,
681 		.of_match_table	= dw8250_of_match,
682 		.acpi_match_table = ACPI_PTR(dw8250_acpi_match),
683 	},
684 	.probe			= dw8250_probe,
685 	.remove			= dw8250_remove,
686 };
687 
688 module_platform_driver(dw8250_platform_driver);
689 
690 MODULE_AUTHOR("Jamie Iles");
691 MODULE_LICENSE("GPL");
692 MODULE_DESCRIPTION("Synopsys DesignWare 8250 serial port driver");
693 MODULE_ALIAS("platform:dw-apb-uart");
694