xref: /openbmc/linux/drivers/regulator/mp886x.c (revision a5f79495)
197be8288SJisheng Zhang // SPDX-License-Identifier: GPL-2.0
297be8288SJisheng Zhang //
3751ca3aaSJisheng Zhang // MP8867/MP8869 regulator driver
497be8288SJisheng Zhang //
597be8288SJisheng Zhang // Copyright (C) 2020 Synaptics Incorporated
697be8288SJisheng Zhang //
797be8288SJisheng Zhang // Author: Jisheng Zhang <jszhang@kernel.org>
897be8288SJisheng Zhang 
997be8288SJisheng Zhang #include <linux/gpio/consumer.h>
1097be8288SJisheng Zhang #include <linux/i2c.h>
1197be8288SJisheng Zhang #include <linux/module.h>
1297be8288SJisheng Zhang #include <linux/of_device.h>
1397be8288SJisheng Zhang #include <linux/regmap.h>
1497be8288SJisheng Zhang #include <linux/regulator/driver.h>
1597be8288SJisheng Zhang #include <linux/regulator/of_regulator.h>
1697be8288SJisheng Zhang 
1797be8288SJisheng Zhang #define MP886X_VSEL		0x00
1897be8288SJisheng Zhang #define  MP886X_V_BOOT		(1 << 7)
1997be8288SJisheng Zhang #define MP886X_SYSCNTLREG1	0x01
2097be8288SJisheng Zhang #define  MP886X_MODE		(1 << 0)
210eddcf02SJisheng Zhang #define  MP886X_SLEW_SHIFT	3
220eddcf02SJisheng Zhang #define  MP886X_SLEW_MASK	(0x7 << MP886X_SLEW_SHIFT)
2397be8288SJisheng Zhang #define  MP886X_GO		(1 << 6)
2497be8288SJisheng Zhang #define  MP886X_EN		(1 << 7)
25ee6ad5a2SJisheng Zhang #define MP8869_SYSCNTLREG2	0x02
2697be8288SJisheng Zhang 
270eddcf02SJisheng Zhang struct mp886x_cfg_info {
280eddcf02SJisheng Zhang 	const struct regulator_ops *rops;
290eddcf02SJisheng Zhang 	const int slew_rates[8];
30ee6ad5a2SJisheng Zhang 	const int switch_freq[4];
31ee6ad5a2SJisheng Zhang 	const u8 fs_reg;
32ee6ad5a2SJisheng Zhang 	const u8 fs_shift;
330eddcf02SJisheng Zhang };
340eddcf02SJisheng Zhang 
3597be8288SJisheng Zhang struct mp886x_device_info {
3697be8288SJisheng Zhang 	struct device *dev;
3797be8288SJisheng Zhang 	struct regulator_desc desc;
3897be8288SJisheng Zhang 	struct regulator_init_data *regulator;
3997be8288SJisheng Zhang 	struct gpio_desc *en_gpio;
400eddcf02SJisheng Zhang 	const struct mp886x_cfg_info *ci;
4197be8288SJisheng Zhang 	u32 r[2];
4297be8288SJisheng Zhang 	unsigned int sel;
4397be8288SJisheng Zhang };
4497be8288SJisheng Zhang 
450eddcf02SJisheng Zhang static int mp886x_set_ramp(struct regulator_dev *rdev, int ramp)
460eddcf02SJisheng Zhang {
470eddcf02SJisheng Zhang 	struct mp886x_device_info *di = rdev_get_drvdata(rdev);
480eddcf02SJisheng Zhang 	const struct mp886x_cfg_info *ci = di->ci;
490eddcf02SJisheng Zhang 	int reg = -1, i;
500eddcf02SJisheng Zhang 
510eddcf02SJisheng Zhang 	for (i = 0; i < ARRAY_SIZE(ci->slew_rates); i++) {
520eddcf02SJisheng Zhang 		if (ramp <= ci->slew_rates[i])
530eddcf02SJisheng Zhang 			reg = i;
540eddcf02SJisheng Zhang 		else
550eddcf02SJisheng Zhang 			break;
560eddcf02SJisheng Zhang 	}
570eddcf02SJisheng Zhang 
580eddcf02SJisheng Zhang 	if (reg < 0) {
590eddcf02SJisheng Zhang 		dev_err(di->dev, "unsupported ramp value %d\n", ramp);
600eddcf02SJisheng Zhang 		return -EINVAL;
610eddcf02SJisheng Zhang 	}
620eddcf02SJisheng Zhang 
630eddcf02SJisheng Zhang 	return regmap_update_bits(rdev->regmap, MP886X_SYSCNTLREG1,
640eddcf02SJisheng Zhang 				  MP886X_SLEW_MASK, reg << MP886X_SLEW_SHIFT);
650eddcf02SJisheng Zhang }
660eddcf02SJisheng Zhang 
67ee6ad5a2SJisheng Zhang static void mp886x_set_switch_freq(struct mp886x_device_info *di,
68ee6ad5a2SJisheng Zhang 				   struct regmap *regmap,
69ee6ad5a2SJisheng Zhang 				   u32 freq)
70ee6ad5a2SJisheng Zhang {
71ee6ad5a2SJisheng Zhang 	const struct mp886x_cfg_info *ci = di->ci;
72ee6ad5a2SJisheng Zhang 	int i;
73ee6ad5a2SJisheng Zhang 
74ee6ad5a2SJisheng Zhang 	for (i = 0; i < ARRAY_SIZE(ci->switch_freq); i++) {
75ee6ad5a2SJisheng Zhang 		if (freq == ci->switch_freq[i]) {
76ee6ad5a2SJisheng Zhang 			regmap_update_bits(regmap, ci->fs_reg,
77ee6ad5a2SJisheng Zhang 				  0x3 << ci->fs_shift, i << ci->fs_shift);
78ee6ad5a2SJisheng Zhang 			return;
79ee6ad5a2SJisheng Zhang 		}
80ee6ad5a2SJisheng Zhang 	}
81ee6ad5a2SJisheng Zhang 
82ee6ad5a2SJisheng Zhang 	dev_err(di->dev, "invalid frequency %d\n", freq);
83ee6ad5a2SJisheng Zhang }
84ee6ad5a2SJisheng Zhang 
8597be8288SJisheng Zhang static int mp886x_set_mode(struct regulator_dev *rdev, unsigned int mode)
8697be8288SJisheng Zhang {
8797be8288SJisheng Zhang 	switch (mode) {
8897be8288SJisheng Zhang 	case REGULATOR_MODE_FAST:
8997be8288SJisheng Zhang 		regmap_update_bits(rdev->regmap, MP886X_SYSCNTLREG1,
9097be8288SJisheng Zhang 				   MP886X_MODE, MP886X_MODE);
9197be8288SJisheng Zhang 		break;
9297be8288SJisheng Zhang 	case REGULATOR_MODE_NORMAL:
9397be8288SJisheng Zhang 		regmap_update_bits(rdev->regmap, MP886X_SYSCNTLREG1,
9497be8288SJisheng Zhang 				   MP886X_MODE, 0);
9597be8288SJisheng Zhang 		break;
9697be8288SJisheng Zhang 	default:
9797be8288SJisheng Zhang 		return -EINVAL;
9897be8288SJisheng Zhang 	}
9997be8288SJisheng Zhang 	return 0;
10097be8288SJisheng Zhang }
10197be8288SJisheng Zhang 
10297be8288SJisheng Zhang static unsigned int mp886x_get_mode(struct regulator_dev *rdev)
10397be8288SJisheng Zhang {
10497be8288SJisheng Zhang 	u32 val;
10597be8288SJisheng Zhang 	int ret;
10697be8288SJisheng Zhang 
10797be8288SJisheng Zhang 	ret = regmap_read(rdev->regmap, MP886X_SYSCNTLREG1, &val);
10897be8288SJisheng Zhang 	if (ret < 0)
10997be8288SJisheng Zhang 		return ret;
11097be8288SJisheng Zhang 	if (val & MP886X_MODE)
11197be8288SJisheng Zhang 		return REGULATOR_MODE_FAST;
11297be8288SJisheng Zhang 	else
11397be8288SJisheng Zhang 		return REGULATOR_MODE_NORMAL;
11497be8288SJisheng Zhang }
11597be8288SJisheng Zhang 
11697be8288SJisheng Zhang static int mp8869_set_voltage_sel(struct regulator_dev *rdev, unsigned int sel)
11797be8288SJisheng Zhang {
11897be8288SJisheng Zhang 	int ret;
11997be8288SJisheng Zhang 
12097be8288SJisheng Zhang 	ret = regmap_update_bits(rdev->regmap, MP886X_SYSCNTLREG1,
12197be8288SJisheng Zhang 				 MP886X_GO, MP886X_GO);
12297be8288SJisheng Zhang 	if (ret < 0)
12397be8288SJisheng Zhang 		return ret;
12497be8288SJisheng Zhang 
12597be8288SJisheng Zhang 	sel <<= ffs(rdev->desc->vsel_mask) - 1;
12697be8288SJisheng Zhang 	return regmap_update_bits(rdev->regmap, rdev->desc->vsel_reg,
12797be8288SJisheng Zhang 				  MP886X_V_BOOT | rdev->desc->vsel_mask, sel);
12897be8288SJisheng Zhang }
12997be8288SJisheng Zhang 
13097be8288SJisheng Zhang static inline unsigned int mp8869_scale(unsigned int uv, u32 r1, u32 r2)
13197be8288SJisheng Zhang {
13297be8288SJisheng Zhang 	u32 tmp = uv * r1 / r2;
13397be8288SJisheng Zhang 
13497be8288SJisheng Zhang 	return uv + tmp;
13597be8288SJisheng Zhang }
13697be8288SJisheng Zhang 
13797be8288SJisheng Zhang static int mp8869_get_voltage_sel(struct regulator_dev *rdev)
13897be8288SJisheng Zhang {
13997be8288SJisheng Zhang 	struct mp886x_device_info *di = rdev_get_drvdata(rdev);
14097be8288SJisheng Zhang 	int ret, uv;
14197be8288SJisheng Zhang 	unsigned int val;
14297be8288SJisheng Zhang 	bool fbloop;
14397be8288SJisheng Zhang 
14497be8288SJisheng Zhang 	ret = regmap_read(rdev->regmap, rdev->desc->vsel_reg, &val);
14597be8288SJisheng Zhang 	if (ret)
14697be8288SJisheng Zhang 		return ret;
14797be8288SJisheng Zhang 
14897be8288SJisheng Zhang 	fbloop = val & MP886X_V_BOOT;
14997be8288SJisheng Zhang 	if (fbloop) {
15097be8288SJisheng Zhang 		uv = rdev->desc->min_uV;
15197be8288SJisheng Zhang 		uv = mp8869_scale(uv, di->r[0], di->r[1]);
15297be8288SJisheng Zhang 		return regulator_map_voltage_linear(rdev, uv, uv);
15397be8288SJisheng Zhang 	}
15497be8288SJisheng Zhang 
15597be8288SJisheng Zhang 	val &= rdev->desc->vsel_mask;
15697be8288SJisheng Zhang 	val >>= ffs(rdev->desc->vsel_mask) - 1;
15797be8288SJisheng Zhang 
15897be8288SJisheng Zhang 	return val;
15997be8288SJisheng Zhang }
16097be8288SJisheng Zhang 
16197be8288SJisheng Zhang static const struct regulator_ops mp8869_regulator_ops = {
16297be8288SJisheng Zhang 	.set_voltage_sel = mp8869_set_voltage_sel,
16397be8288SJisheng Zhang 	.get_voltage_sel = mp8869_get_voltage_sel,
16497be8288SJisheng Zhang 	.set_voltage_time_sel = regulator_set_voltage_time_sel,
16597be8288SJisheng Zhang 	.map_voltage = regulator_map_voltage_linear,
16697be8288SJisheng Zhang 	.list_voltage = regulator_list_voltage_linear,
16797be8288SJisheng Zhang 	.enable = regulator_enable_regmap,
16897be8288SJisheng Zhang 	.disable = regulator_disable_regmap,
16997be8288SJisheng Zhang 	.is_enabled = regulator_is_enabled_regmap,
17097be8288SJisheng Zhang 	.set_mode = mp886x_set_mode,
17197be8288SJisheng Zhang 	.get_mode = mp886x_get_mode,
1720eddcf02SJisheng Zhang 	.set_ramp_delay = mp886x_set_ramp,
1730eddcf02SJisheng Zhang };
1740eddcf02SJisheng Zhang 
1750eddcf02SJisheng Zhang static const struct mp886x_cfg_info mp8869_ci = {
1760eddcf02SJisheng Zhang 	.rops = &mp8869_regulator_ops,
1770eddcf02SJisheng Zhang 	.slew_rates = {
1780eddcf02SJisheng Zhang 		40000,
1790eddcf02SJisheng Zhang 		30000,
1800eddcf02SJisheng Zhang 		20000,
1810eddcf02SJisheng Zhang 		10000,
1820eddcf02SJisheng Zhang 		5000,
1830eddcf02SJisheng Zhang 		2500,
1840eddcf02SJisheng Zhang 		1250,
1850eddcf02SJisheng Zhang 		625,
1860eddcf02SJisheng Zhang 	},
187ee6ad5a2SJisheng Zhang 	.switch_freq = {
188ee6ad5a2SJisheng Zhang 		500000,
189ee6ad5a2SJisheng Zhang 		750000,
190ee6ad5a2SJisheng Zhang 		1000000,
191ee6ad5a2SJisheng Zhang 		1250000,
192ee6ad5a2SJisheng Zhang 	},
193ee6ad5a2SJisheng Zhang 	.fs_reg = MP8869_SYSCNTLREG2,
194ee6ad5a2SJisheng Zhang 	.fs_shift = 4,
19597be8288SJisheng Zhang };
19697be8288SJisheng Zhang 
197751ca3aaSJisheng Zhang static int mp8867_set_voltage_sel(struct regulator_dev *rdev, unsigned int sel)
198751ca3aaSJisheng Zhang {
199751ca3aaSJisheng Zhang 	struct mp886x_device_info *di = rdev_get_drvdata(rdev);
200751ca3aaSJisheng Zhang 	int ret, delta;
201751ca3aaSJisheng Zhang 
202751ca3aaSJisheng Zhang 	ret = mp8869_set_voltage_sel(rdev, sel);
203751ca3aaSJisheng Zhang 	if (ret < 0)
204751ca3aaSJisheng Zhang 		return ret;
205751ca3aaSJisheng Zhang 
206751ca3aaSJisheng Zhang 	delta = di->sel - sel;
207751ca3aaSJisheng Zhang 	if (abs(delta) <= 5)
208751ca3aaSJisheng Zhang 		ret = regmap_update_bits(rdev->regmap, MP886X_SYSCNTLREG1,
209751ca3aaSJisheng Zhang 					 MP886X_GO, 0);
210751ca3aaSJisheng Zhang 	di->sel = sel;
211751ca3aaSJisheng Zhang 
212751ca3aaSJisheng Zhang 	return ret;
213751ca3aaSJisheng Zhang }
214751ca3aaSJisheng Zhang 
215751ca3aaSJisheng Zhang static int mp8867_get_voltage_sel(struct regulator_dev *rdev)
216751ca3aaSJisheng Zhang {
217751ca3aaSJisheng Zhang 	struct mp886x_device_info *di = rdev_get_drvdata(rdev);
218751ca3aaSJisheng Zhang 	int ret, uv;
219751ca3aaSJisheng Zhang 	unsigned int val;
220751ca3aaSJisheng Zhang 	bool fbloop;
221751ca3aaSJisheng Zhang 
222751ca3aaSJisheng Zhang 	ret = regmap_read(rdev->regmap, rdev->desc->vsel_reg, &val);
223751ca3aaSJisheng Zhang 	if (ret)
224751ca3aaSJisheng Zhang 		return ret;
225751ca3aaSJisheng Zhang 
226751ca3aaSJisheng Zhang 	fbloop = val & MP886X_V_BOOT;
227751ca3aaSJisheng Zhang 
228751ca3aaSJisheng Zhang 	val &= rdev->desc->vsel_mask;
229751ca3aaSJisheng Zhang 	val >>= ffs(rdev->desc->vsel_mask) - 1;
230751ca3aaSJisheng Zhang 
231751ca3aaSJisheng Zhang 	if (fbloop) {
232751ca3aaSJisheng Zhang 		uv = regulator_list_voltage_linear(rdev, val);
233751ca3aaSJisheng Zhang 		uv = mp8869_scale(uv, di->r[0], di->r[1]);
234751ca3aaSJisheng Zhang 		return regulator_map_voltage_linear(rdev, uv, uv);
235751ca3aaSJisheng Zhang 	}
236751ca3aaSJisheng Zhang 
237751ca3aaSJisheng Zhang 	return val;
238751ca3aaSJisheng Zhang }
239751ca3aaSJisheng Zhang 
240751ca3aaSJisheng Zhang static const struct regulator_ops mp8867_regulator_ops = {
241751ca3aaSJisheng Zhang 	.set_voltage_sel = mp8867_set_voltage_sel,
242751ca3aaSJisheng Zhang 	.get_voltage_sel = mp8867_get_voltage_sel,
243751ca3aaSJisheng Zhang 	.set_voltage_time_sel = regulator_set_voltage_time_sel,
244751ca3aaSJisheng Zhang 	.map_voltage = regulator_map_voltage_linear,
245751ca3aaSJisheng Zhang 	.list_voltage = regulator_list_voltage_linear,
246751ca3aaSJisheng Zhang 	.enable = regulator_enable_regmap,
247751ca3aaSJisheng Zhang 	.disable = regulator_disable_regmap,
248751ca3aaSJisheng Zhang 	.is_enabled = regulator_is_enabled_regmap,
249751ca3aaSJisheng Zhang 	.set_mode = mp886x_set_mode,
250751ca3aaSJisheng Zhang 	.get_mode = mp886x_get_mode,
2510eddcf02SJisheng Zhang 	.set_ramp_delay = mp886x_set_ramp,
2520eddcf02SJisheng Zhang };
2530eddcf02SJisheng Zhang 
2540eddcf02SJisheng Zhang static const struct mp886x_cfg_info mp8867_ci = {
2550eddcf02SJisheng Zhang 	.rops = &mp8867_regulator_ops,
2560eddcf02SJisheng Zhang 	.slew_rates = {
2570eddcf02SJisheng Zhang 		64000,
2580eddcf02SJisheng Zhang 		32000,
2590eddcf02SJisheng Zhang 		16000,
2600eddcf02SJisheng Zhang 		8000,
2610eddcf02SJisheng Zhang 		4000,
2620eddcf02SJisheng Zhang 		2000,
2630eddcf02SJisheng Zhang 		1000,
2640eddcf02SJisheng Zhang 		500,
2650eddcf02SJisheng Zhang 	},
266ee6ad5a2SJisheng Zhang 	.switch_freq = {
267ee6ad5a2SJisheng Zhang 		500000,
268ee6ad5a2SJisheng Zhang 		750000,
269ee6ad5a2SJisheng Zhang 		1000000,
270ee6ad5a2SJisheng Zhang 		1500000,
271ee6ad5a2SJisheng Zhang 	},
272ee6ad5a2SJisheng Zhang 	.fs_reg = MP886X_SYSCNTLREG1,
273ee6ad5a2SJisheng Zhang 	.fs_shift = 1,
274751ca3aaSJisheng Zhang };
275751ca3aaSJisheng Zhang 
27697be8288SJisheng Zhang static int mp886x_regulator_register(struct mp886x_device_info *di,
27797be8288SJisheng Zhang 				     struct regulator_config *config)
27897be8288SJisheng Zhang {
27997be8288SJisheng Zhang 	struct regulator_desc *rdesc = &di->desc;
28097be8288SJisheng Zhang 	struct regulator_dev *rdev;
28197be8288SJisheng Zhang 
28297be8288SJisheng Zhang 	rdesc->name = "mp886x-reg";
28397be8288SJisheng Zhang 	rdesc->supply_name = "vin";
2840eddcf02SJisheng Zhang 	rdesc->ops = di->ci->rops;
28597be8288SJisheng Zhang 	rdesc->type = REGULATOR_VOLTAGE;
28697be8288SJisheng Zhang 	rdesc->n_voltages = 128;
28797be8288SJisheng Zhang 	rdesc->enable_reg = MP886X_SYSCNTLREG1;
28897be8288SJisheng Zhang 	rdesc->enable_mask = MP886X_EN;
28997be8288SJisheng Zhang 	rdesc->min_uV = 600000;
29097be8288SJisheng Zhang 	rdesc->uV_step = 10000;
29197be8288SJisheng Zhang 	rdesc->vsel_reg = MP886X_VSEL;
29297be8288SJisheng Zhang 	rdesc->vsel_mask = 0x3f;
29397be8288SJisheng Zhang 	rdesc->owner = THIS_MODULE;
29497be8288SJisheng Zhang 
29597be8288SJisheng Zhang 	rdev = devm_regulator_register(di->dev, &di->desc, config);
29697be8288SJisheng Zhang 	if (IS_ERR(rdev))
29797be8288SJisheng Zhang 		return PTR_ERR(rdev);
29897be8288SJisheng Zhang 	di->sel = rdesc->ops->get_voltage_sel(rdev);
29997be8288SJisheng Zhang 	return 0;
30097be8288SJisheng Zhang }
30197be8288SJisheng Zhang 
30297be8288SJisheng Zhang static const struct regmap_config mp886x_regmap_config = {
30397be8288SJisheng Zhang 	.reg_bits = 8,
30497be8288SJisheng Zhang 	.val_bits = 8,
30597be8288SJisheng Zhang };
30697be8288SJisheng Zhang 
307e2c6678bSJisheng Zhang static int mp886x_i2c_probe(struct i2c_client *client)
30897be8288SJisheng Zhang {
30997be8288SJisheng Zhang 	struct device *dev = &client->dev;
31097be8288SJisheng Zhang 	struct device_node *np = dev->of_node;
31197be8288SJisheng Zhang 	struct mp886x_device_info *di;
31297be8288SJisheng Zhang 	struct regulator_config config = { };
31397be8288SJisheng Zhang 	struct regmap *regmap;
314ee6ad5a2SJisheng Zhang 	u32 freq;
31597be8288SJisheng Zhang 	int ret;
31697be8288SJisheng Zhang 
31797be8288SJisheng Zhang 	di = devm_kzalloc(dev, sizeof(struct mp886x_device_info), GFP_KERNEL);
31897be8288SJisheng Zhang 	if (!di)
31997be8288SJisheng Zhang 		return -ENOMEM;
32097be8288SJisheng Zhang 
32197be8288SJisheng Zhang 	di->regulator = of_get_regulator_init_data(dev, np, &di->desc);
32297be8288SJisheng Zhang 	if (!di->regulator) {
32397be8288SJisheng Zhang 		dev_err(dev, "Platform data not found!\n");
32497be8288SJisheng Zhang 		return -EINVAL;
32597be8288SJisheng Zhang 	}
32697be8288SJisheng Zhang 
32797be8288SJisheng Zhang 	ret = of_property_read_u32_array(np, "mps,fb-voltage-divider",
32897be8288SJisheng Zhang 					 di->r, 2);
32997be8288SJisheng Zhang 	if (ret)
33097be8288SJisheng Zhang 		return ret;
33197be8288SJisheng Zhang 
33297be8288SJisheng Zhang 	di->en_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH);
33397be8288SJisheng Zhang 	if (IS_ERR(di->en_gpio))
33497be8288SJisheng Zhang 		return PTR_ERR(di->en_gpio);
33597be8288SJisheng Zhang 
3360eddcf02SJisheng Zhang 	di->ci = of_device_get_match_data(dev);
33797be8288SJisheng Zhang 	di->dev = dev;
33897be8288SJisheng Zhang 
33997be8288SJisheng Zhang 	regmap = devm_regmap_init_i2c(client, &mp886x_regmap_config);
34097be8288SJisheng Zhang 	if (IS_ERR(regmap)) {
34197be8288SJisheng Zhang 		dev_err(dev, "Failed to allocate regmap!\n");
34297be8288SJisheng Zhang 		return PTR_ERR(regmap);
34397be8288SJisheng Zhang 	}
34497be8288SJisheng Zhang 	i2c_set_clientdata(client, di);
34597be8288SJisheng Zhang 
34697be8288SJisheng Zhang 	config.dev = di->dev;
34797be8288SJisheng Zhang 	config.init_data = di->regulator;
34897be8288SJisheng Zhang 	config.regmap = regmap;
34997be8288SJisheng Zhang 	config.driver_data = di;
35097be8288SJisheng Zhang 	config.of_node = np;
35197be8288SJisheng Zhang 
352a5f79495SJisheng Zhang 	if (!of_property_read_u32(np, "mps,switch-frequency-hz", &freq))
353ee6ad5a2SJisheng Zhang 		mp886x_set_switch_freq(di, regmap, freq);
354ee6ad5a2SJisheng Zhang 
35597be8288SJisheng Zhang 	ret = mp886x_regulator_register(di, &config);
35697be8288SJisheng Zhang 	if (ret < 0)
35797be8288SJisheng Zhang 		dev_err(dev, "Failed to register regulator!\n");
35897be8288SJisheng Zhang 	return ret;
35997be8288SJisheng Zhang }
36097be8288SJisheng Zhang 
36197be8288SJisheng Zhang static const struct of_device_id mp886x_dt_ids[] = {
36297be8288SJisheng Zhang 	{
363751ca3aaSJisheng Zhang 		.compatible = "mps,mp8867",
3640eddcf02SJisheng Zhang 		.data = &mp8867_ci
365751ca3aaSJisheng Zhang 	},
366751ca3aaSJisheng Zhang 	{
36797be8288SJisheng Zhang 		.compatible = "mps,mp8869",
3680eddcf02SJisheng Zhang 		.data = &mp8869_ci
36997be8288SJisheng Zhang 	},
37097be8288SJisheng Zhang 	{ }
37197be8288SJisheng Zhang };
37297be8288SJisheng Zhang MODULE_DEVICE_TABLE(of, mp886x_dt_ids);
37397be8288SJisheng Zhang 
37497be8288SJisheng Zhang static const struct i2c_device_id mp886x_id[] = {
37597be8288SJisheng Zhang 	{ "mp886x", },
37697be8288SJisheng Zhang 	{ },
37797be8288SJisheng Zhang };
37897be8288SJisheng Zhang MODULE_DEVICE_TABLE(i2c, mp886x_id);
37997be8288SJisheng Zhang 
38097be8288SJisheng Zhang static struct i2c_driver mp886x_regulator_driver = {
38197be8288SJisheng Zhang 	.driver = {
38297be8288SJisheng Zhang 		.name = "mp886x-regulator",
38397be8288SJisheng Zhang 		.of_match_table = of_match_ptr(mp886x_dt_ids),
38497be8288SJisheng Zhang 	},
385e2c6678bSJisheng Zhang 	.probe_new = mp886x_i2c_probe,
38697be8288SJisheng Zhang 	.id_table = mp886x_id,
38797be8288SJisheng Zhang };
38897be8288SJisheng Zhang module_i2c_driver(mp886x_regulator_driver);
38997be8288SJisheng Zhang 
39097be8288SJisheng Zhang MODULE_AUTHOR("Jisheng Zhang <jszhang@kernel.org>");
39197be8288SJisheng Zhang MODULE_DESCRIPTION("MP886x regulator driver");
39297be8288SJisheng Zhang MODULE_LICENSE("GPL v2");
393