1 /* 2 * This file is part of wl1271 3 * 4 * Copyright (C) 2009 Nokia Corporation 5 * 6 * Contact: Luciano Coelho <luciano.coelho@nokia.com> 7 * 8 * This program is free software; you can redistribute it and/or 9 * modify it under the terms of the GNU General Public License 10 * version 2 as published by the Free Software Foundation. 11 * 12 * This program is distributed in the hope that it will be useful, but 13 * WITHOUT ANY WARRANTY; without even the implied warranty of 14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 * General Public License for more details. 16 * 17 * You should have received a copy of the GNU General Public License 18 * along with this program; if not, write to the Free Software 19 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 20 * 02110-1301 USA 21 * 22 */ 23 24 #include "debugfs.h" 25 26 #include <linux/skbuff.h> 27 #include <linux/slab.h> 28 #include <linux/module.h> 29 30 #include "wlcore.h" 31 #include "debug.h" 32 #include "acx.h" 33 #include "ps.h" 34 #include "io.h" 35 #include "tx.h" 36 #include "hw_ops.h" 37 38 /* ms */ 39 #define WL1271_DEBUGFS_STATS_LIFETIME 1000 40 41 #define WLCORE_MAX_BLOCK_SIZE ((size_t)(4*PAGE_SIZE)) 42 43 /* debugfs macros idea from mac80211 */ 44 int wl1271_format_buffer(char __user *userbuf, size_t count, 45 loff_t *ppos, char *fmt, ...) 46 { 47 va_list args; 48 char buf[DEBUGFS_FORMAT_BUFFER_SIZE]; 49 int res; 50 51 va_start(args, fmt); 52 res = vscnprintf(buf, sizeof(buf), fmt, args); 53 va_end(args); 54 55 return simple_read_from_buffer(userbuf, count, ppos, buf, res); 56 } 57 EXPORT_SYMBOL_GPL(wl1271_format_buffer); 58 59 void wl1271_debugfs_update_stats(struct wl1271 *wl) 60 { 61 int ret; 62 63 mutex_lock(&wl->mutex); 64 65 if (unlikely(wl->state != WLCORE_STATE_ON)) 66 goto out; 67 68 ret = wl1271_ps_elp_wakeup(wl); 69 if (ret < 0) 70 goto out; 71 72 if (!wl->plt && 73 time_after(jiffies, wl->stats.fw_stats_update + 74 msecs_to_jiffies(WL1271_DEBUGFS_STATS_LIFETIME))) { 75 wl1271_acx_statistics(wl, wl->stats.fw_stats); 76 wl->stats.fw_stats_update = jiffies; 77 } 78 79 wl1271_ps_elp_sleep(wl); 80 81 out: 82 mutex_unlock(&wl->mutex); 83 } 84 EXPORT_SYMBOL_GPL(wl1271_debugfs_update_stats); 85 86 DEBUGFS_READONLY_FILE(retry_count, "%u", wl->stats.retry_count); 87 DEBUGFS_READONLY_FILE(excessive_retries, "%u", 88 wl->stats.excessive_retries); 89 90 static ssize_t tx_queue_len_read(struct file *file, char __user *userbuf, 91 size_t count, loff_t *ppos) 92 { 93 struct wl1271 *wl = file->private_data; 94 u32 queue_len; 95 char buf[20]; 96 int res; 97 98 queue_len = wl1271_tx_total_queue_count(wl); 99 100 res = scnprintf(buf, sizeof(buf), "%u\n", queue_len); 101 return simple_read_from_buffer(userbuf, count, ppos, buf, res); 102 } 103 104 static const struct file_operations tx_queue_len_ops = { 105 .read = tx_queue_len_read, 106 .open = simple_open, 107 .llseek = default_llseek, 108 }; 109 110 static void chip_op_handler(struct wl1271 *wl, unsigned long value, 111 void *arg) 112 { 113 int ret; 114 int (*chip_op) (struct wl1271 *wl); 115 116 if (!arg) { 117 wl1271_warning("debugfs chip_op_handler with no callback"); 118 return; 119 } 120 121 ret = wl1271_ps_elp_wakeup(wl); 122 if (ret < 0) 123 return; 124 125 chip_op = arg; 126 chip_op(wl); 127 128 wl1271_ps_elp_sleep(wl); 129 } 130 131 132 static inline void no_write_handler(struct wl1271 *wl, 133 unsigned long value, 134 unsigned long param) 135 { 136 } 137 138 #define WL12XX_CONF_DEBUGFS(param, conf_sub_struct, \ 139 min_val, max_val, write_handler_locked, \ 140 write_handler_arg) \ 141 static ssize_t param##_read(struct file *file, \ 142 char __user *user_buf, \ 143 size_t count, loff_t *ppos) \ 144 { \ 145 struct wl1271 *wl = file->private_data; \ 146 return wl1271_format_buffer(user_buf, count, \ 147 ppos, "%d\n", \ 148 wl->conf.conf_sub_struct.param); \ 149 } \ 150 \ 151 static ssize_t param##_write(struct file *file, \ 152 const char __user *user_buf, \ 153 size_t count, loff_t *ppos) \ 154 { \ 155 struct wl1271 *wl = file->private_data; \ 156 unsigned long value; \ 157 int ret; \ 158 \ 159 ret = kstrtoul_from_user(user_buf, count, 10, &value); \ 160 if (ret < 0) { \ 161 wl1271_warning("illegal value for " #param); \ 162 return -EINVAL; \ 163 } \ 164 \ 165 if (value < min_val || value > max_val) { \ 166 wl1271_warning(#param " is not in valid range"); \ 167 return -ERANGE; \ 168 } \ 169 \ 170 mutex_lock(&wl->mutex); \ 171 wl->conf.conf_sub_struct.param = value; \ 172 \ 173 write_handler_locked(wl, value, write_handler_arg); \ 174 \ 175 mutex_unlock(&wl->mutex); \ 176 return count; \ 177 } \ 178 \ 179 static const struct file_operations param##_ops = { \ 180 .read = param##_read, \ 181 .write = param##_write, \ 182 .open = simple_open, \ 183 .llseek = default_llseek, \ 184 }; 185 186 WL12XX_CONF_DEBUGFS(irq_pkt_threshold, rx, 0, 65535, 187 chip_op_handler, wl1271_acx_init_rx_interrupt) 188 WL12XX_CONF_DEBUGFS(irq_blk_threshold, rx, 0, 65535, 189 chip_op_handler, wl1271_acx_init_rx_interrupt) 190 WL12XX_CONF_DEBUGFS(irq_timeout, rx, 0, 100, 191 chip_op_handler, wl1271_acx_init_rx_interrupt) 192 193 static ssize_t gpio_power_read(struct file *file, char __user *user_buf, 194 size_t count, loff_t *ppos) 195 { 196 struct wl1271 *wl = file->private_data; 197 bool state = test_bit(WL1271_FLAG_GPIO_POWER, &wl->flags); 198 199 int res; 200 char buf[10]; 201 202 res = scnprintf(buf, sizeof(buf), "%d\n", state); 203 204 return simple_read_from_buffer(user_buf, count, ppos, buf, res); 205 } 206 207 static ssize_t gpio_power_write(struct file *file, 208 const char __user *user_buf, 209 size_t count, loff_t *ppos) 210 { 211 struct wl1271 *wl = file->private_data; 212 unsigned long value; 213 int ret; 214 215 ret = kstrtoul_from_user(user_buf, count, 10, &value); 216 if (ret < 0) { 217 wl1271_warning("illegal value in gpio_power"); 218 return -EINVAL; 219 } 220 221 mutex_lock(&wl->mutex); 222 223 if (value) 224 wl1271_power_on(wl); 225 else 226 wl1271_power_off(wl); 227 228 mutex_unlock(&wl->mutex); 229 return count; 230 } 231 232 static const struct file_operations gpio_power_ops = { 233 .read = gpio_power_read, 234 .write = gpio_power_write, 235 .open = simple_open, 236 .llseek = default_llseek, 237 }; 238 239 static ssize_t start_recovery_write(struct file *file, 240 const char __user *user_buf, 241 size_t count, loff_t *ppos) 242 { 243 struct wl1271 *wl = file->private_data; 244 245 mutex_lock(&wl->mutex); 246 wl12xx_queue_recovery_work(wl); 247 mutex_unlock(&wl->mutex); 248 249 return count; 250 } 251 252 static const struct file_operations start_recovery_ops = { 253 .write = start_recovery_write, 254 .open = simple_open, 255 .llseek = default_llseek, 256 }; 257 258 static ssize_t dynamic_ps_timeout_read(struct file *file, char __user *user_buf, 259 size_t count, loff_t *ppos) 260 { 261 struct wl1271 *wl = file->private_data; 262 263 return wl1271_format_buffer(user_buf, count, 264 ppos, "%d\n", 265 wl->conf.conn.dynamic_ps_timeout); 266 } 267 268 static ssize_t dynamic_ps_timeout_write(struct file *file, 269 const char __user *user_buf, 270 size_t count, loff_t *ppos) 271 { 272 struct wl1271 *wl = file->private_data; 273 struct wl12xx_vif *wlvif; 274 unsigned long value; 275 int ret; 276 277 ret = kstrtoul_from_user(user_buf, count, 10, &value); 278 if (ret < 0) { 279 wl1271_warning("illegal value in dynamic_ps"); 280 return -EINVAL; 281 } 282 283 if (value < 1 || value > 65535) { 284 wl1271_warning("dynamic_ps_timeout is not in valid range"); 285 return -ERANGE; 286 } 287 288 mutex_lock(&wl->mutex); 289 290 wl->conf.conn.dynamic_ps_timeout = value; 291 292 if (unlikely(wl->state != WLCORE_STATE_ON)) 293 goto out; 294 295 ret = wl1271_ps_elp_wakeup(wl); 296 if (ret < 0) 297 goto out; 298 299 /* In case we're already in PSM, trigger it again to set new timeout 300 * immediately without waiting for re-association 301 */ 302 303 wl12xx_for_each_wlvif_sta(wl, wlvif) { 304 if (test_bit(WLVIF_FLAG_IN_PS, &wlvif->flags)) 305 wl1271_ps_set_mode(wl, wlvif, STATION_AUTO_PS_MODE); 306 } 307 308 wl1271_ps_elp_sleep(wl); 309 310 out: 311 mutex_unlock(&wl->mutex); 312 return count; 313 } 314 315 static const struct file_operations dynamic_ps_timeout_ops = { 316 .read = dynamic_ps_timeout_read, 317 .write = dynamic_ps_timeout_write, 318 .open = simple_open, 319 .llseek = default_llseek, 320 }; 321 322 static ssize_t forced_ps_read(struct file *file, char __user *user_buf, 323 size_t count, loff_t *ppos) 324 { 325 struct wl1271 *wl = file->private_data; 326 327 return wl1271_format_buffer(user_buf, count, 328 ppos, "%d\n", 329 wl->conf.conn.forced_ps); 330 } 331 332 static ssize_t forced_ps_write(struct file *file, 333 const char __user *user_buf, 334 size_t count, loff_t *ppos) 335 { 336 struct wl1271 *wl = file->private_data; 337 struct wl12xx_vif *wlvif; 338 unsigned long value; 339 int ret, ps_mode; 340 341 ret = kstrtoul_from_user(user_buf, count, 10, &value); 342 if (ret < 0) { 343 wl1271_warning("illegal value in forced_ps"); 344 return -EINVAL; 345 } 346 347 if (value != 1 && value != 0) { 348 wl1271_warning("forced_ps should be either 0 or 1"); 349 return -ERANGE; 350 } 351 352 mutex_lock(&wl->mutex); 353 354 if (wl->conf.conn.forced_ps == value) 355 goto out; 356 357 wl->conf.conn.forced_ps = value; 358 359 if (unlikely(wl->state != WLCORE_STATE_ON)) 360 goto out; 361 362 ret = wl1271_ps_elp_wakeup(wl); 363 if (ret < 0) 364 goto out; 365 366 /* In case we're already in PSM, trigger it again to switch mode 367 * immediately without waiting for re-association 368 */ 369 370 ps_mode = value ? STATION_POWER_SAVE_MODE : STATION_AUTO_PS_MODE; 371 372 wl12xx_for_each_wlvif_sta(wl, wlvif) { 373 if (test_bit(WLVIF_FLAG_IN_PS, &wlvif->flags)) 374 wl1271_ps_set_mode(wl, wlvif, ps_mode); 375 } 376 377 wl1271_ps_elp_sleep(wl); 378 379 out: 380 mutex_unlock(&wl->mutex); 381 return count; 382 } 383 384 static const struct file_operations forced_ps_ops = { 385 .read = forced_ps_read, 386 .write = forced_ps_write, 387 .open = simple_open, 388 .llseek = default_llseek, 389 }; 390 391 static ssize_t split_scan_timeout_read(struct file *file, char __user *user_buf, 392 size_t count, loff_t *ppos) 393 { 394 struct wl1271 *wl = file->private_data; 395 396 return wl1271_format_buffer(user_buf, count, 397 ppos, "%d\n", 398 wl->conf.scan.split_scan_timeout / 1000); 399 } 400 401 static ssize_t split_scan_timeout_write(struct file *file, 402 const char __user *user_buf, 403 size_t count, loff_t *ppos) 404 { 405 struct wl1271 *wl = file->private_data; 406 unsigned long value; 407 int ret; 408 409 ret = kstrtoul_from_user(user_buf, count, 10, &value); 410 if (ret < 0) { 411 wl1271_warning("illegal value in split_scan_timeout"); 412 return -EINVAL; 413 } 414 415 if (value == 0) 416 wl1271_info("split scan will be disabled"); 417 418 mutex_lock(&wl->mutex); 419 420 wl->conf.scan.split_scan_timeout = value * 1000; 421 422 mutex_unlock(&wl->mutex); 423 return count; 424 } 425 426 static const struct file_operations split_scan_timeout_ops = { 427 .read = split_scan_timeout_read, 428 .write = split_scan_timeout_write, 429 .open = simple_open, 430 .llseek = default_llseek, 431 }; 432 433 static ssize_t driver_state_read(struct file *file, char __user *user_buf, 434 size_t count, loff_t *ppos) 435 { 436 struct wl1271 *wl = file->private_data; 437 int res = 0; 438 ssize_t ret; 439 char *buf; 440 struct wl12xx_vif *wlvif; 441 442 #define DRIVER_STATE_BUF_LEN 1024 443 444 buf = kmalloc(DRIVER_STATE_BUF_LEN, GFP_KERNEL); 445 if (!buf) 446 return -ENOMEM; 447 448 mutex_lock(&wl->mutex); 449 450 #define DRIVER_STATE_PRINT(x, fmt) \ 451 (res += scnprintf(buf + res, DRIVER_STATE_BUF_LEN - res,\ 452 #x " = " fmt "\n", wl->x)) 453 454 #define DRIVER_STATE_PRINT_GENERIC(x, fmt, args...) \ 455 (res += scnprintf(buf + res, DRIVER_STATE_BUF_LEN - res,\ 456 #x " = " fmt "\n", args)) 457 458 #define DRIVER_STATE_PRINT_LONG(x) DRIVER_STATE_PRINT(x, "%ld") 459 #define DRIVER_STATE_PRINT_INT(x) DRIVER_STATE_PRINT(x, "%d") 460 #define DRIVER_STATE_PRINT_STR(x) DRIVER_STATE_PRINT(x, "%s") 461 #define DRIVER_STATE_PRINT_LHEX(x) DRIVER_STATE_PRINT(x, "0x%lx") 462 #define DRIVER_STATE_PRINT_HEX(x) DRIVER_STATE_PRINT(x, "0x%x") 463 464 wl12xx_for_each_wlvif_sta(wl, wlvif) { 465 if (!test_bit(WLVIF_FLAG_STA_ASSOCIATED, &wlvif->flags)) 466 continue; 467 468 DRIVER_STATE_PRINT_GENERIC(channel, "%d (%s)", wlvif->channel, 469 wlvif->p2p ? "P2P-CL" : "STA"); 470 } 471 472 wl12xx_for_each_wlvif_ap(wl, wlvif) 473 DRIVER_STATE_PRINT_GENERIC(channel, "%d (%s)", wlvif->channel, 474 wlvif->p2p ? "P2P-GO" : "AP"); 475 476 DRIVER_STATE_PRINT_INT(tx_blocks_available); 477 DRIVER_STATE_PRINT_INT(tx_allocated_blocks); 478 DRIVER_STATE_PRINT_INT(tx_allocated_pkts[0]); 479 DRIVER_STATE_PRINT_INT(tx_allocated_pkts[1]); 480 DRIVER_STATE_PRINT_INT(tx_allocated_pkts[2]); 481 DRIVER_STATE_PRINT_INT(tx_allocated_pkts[3]); 482 DRIVER_STATE_PRINT_INT(tx_frames_cnt); 483 DRIVER_STATE_PRINT_LHEX(tx_frames_map[0]); 484 DRIVER_STATE_PRINT_INT(tx_queue_count[0]); 485 DRIVER_STATE_PRINT_INT(tx_queue_count[1]); 486 DRIVER_STATE_PRINT_INT(tx_queue_count[2]); 487 DRIVER_STATE_PRINT_INT(tx_queue_count[3]); 488 DRIVER_STATE_PRINT_INT(tx_packets_count); 489 DRIVER_STATE_PRINT_INT(tx_results_count); 490 DRIVER_STATE_PRINT_LHEX(flags); 491 DRIVER_STATE_PRINT_INT(tx_blocks_freed); 492 DRIVER_STATE_PRINT_INT(rx_counter); 493 DRIVER_STATE_PRINT_INT(state); 494 DRIVER_STATE_PRINT_INT(band); 495 DRIVER_STATE_PRINT_INT(power_level); 496 DRIVER_STATE_PRINT_INT(sg_enabled); 497 DRIVER_STATE_PRINT_INT(enable_11a); 498 DRIVER_STATE_PRINT_INT(noise); 499 DRIVER_STATE_PRINT_LHEX(ap_fw_ps_map); 500 DRIVER_STATE_PRINT_LHEX(ap_ps_map); 501 DRIVER_STATE_PRINT_HEX(quirks); 502 DRIVER_STATE_PRINT_HEX(irq); 503 /* TODO: ref_clock and tcxo_clock were moved to wl12xx priv */ 504 DRIVER_STATE_PRINT_HEX(hw_pg_ver); 505 DRIVER_STATE_PRINT_HEX(irq_flags); 506 DRIVER_STATE_PRINT_HEX(chip.id); 507 DRIVER_STATE_PRINT_STR(chip.fw_ver_str); 508 DRIVER_STATE_PRINT_STR(chip.phy_fw_ver_str); 509 DRIVER_STATE_PRINT_INT(recovery_count); 510 511 #undef DRIVER_STATE_PRINT_INT 512 #undef DRIVER_STATE_PRINT_LONG 513 #undef DRIVER_STATE_PRINT_HEX 514 #undef DRIVER_STATE_PRINT_LHEX 515 #undef DRIVER_STATE_PRINT_STR 516 #undef DRIVER_STATE_PRINT 517 #undef DRIVER_STATE_BUF_LEN 518 519 mutex_unlock(&wl->mutex); 520 521 ret = simple_read_from_buffer(user_buf, count, ppos, buf, res); 522 kfree(buf); 523 return ret; 524 } 525 526 static const struct file_operations driver_state_ops = { 527 .read = driver_state_read, 528 .open = simple_open, 529 .llseek = default_llseek, 530 }; 531 532 static ssize_t vifs_state_read(struct file *file, char __user *user_buf, 533 size_t count, loff_t *ppos) 534 { 535 struct wl1271 *wl = file->private_data; 536 struct wl12xx_vif *wlvif; 537 int ret, res = 0; 538 const int buf_size = 4096; 539 char *buf; 540 char tmp_buf[64]; 541 542 buf = kzalloc(buf_size, GFP_KERNEL); 543 if (!buf) 544 return -ENOMEM; 545 546 mutex_lock(&wl->mutex); 547 548 #define VIF_STATE_PRINT(x, fmt) \ 549 (res += scnprintf(buf + res, buf_size - res, \ 550 #x " = " fmt "\n", wlvif->x)) 551 552 #define VIF_STATE_PRINT_LONG(x) VIF_STATE_PRINT(x, "%ld") 553 #define VIF_STATE_PRINT_INT(x) VIF_STATE_PRINT(x, "%d") 554 #define VIF_STATE_PRINT_STR(x) VIF_STATE_PRINT(x, "%s") 555 #define VIF_STATE_PRINT_LHEX(x) VIF_STATE_PRINT(x, "0x%lx") 556 #define VIF_STATE_PRINT_LLHEX(x) VIF_STATE_PRINT(x, "0x%llx") 557 #define VIF_STATE_PRINT_HEX(x) VIF_STATE_PRINT(x, "0x%x") 558 559 #define VIF_STATE_PRINT_NSTR(x, len) \ 560 do { \ 561 memset(tmp_buf, 0, sizeof(tmp_buf)); \ 562 memcpy(tmp_buf, wlvif->x, \ 563 min_t(u8, len, sizeof(tmp_buf) - 1)); \ 564 res += scnprintf(buf + res, buf_size - res, \ 565 #x " = %s\n", tmp_buf); \ 566 } while (0) 567 568 wl12xx_for_each_wlvif(wl, wlvif) { 569 VIF_STATE_PRINT_INT(role_id); 570 VIF_STATE_PRINT_INT(bss_type); 571 VIF_STATE_PRINT_LHEX(flags); 572 VIF_STATE_PRINT_INT(p2p); 573 VIF_STATE_PRINT_INT(dev_role_id); 574 VIF_STATE_PRINT_INT(dev_hlid); 575 576 if (wlvif->bss_type == BSS_TYPE_STA_BSS || 577 wlvif->bss_type == BSS_TYPE_IBSS) { 578 VIF_STATE_PRINT_INT(sta.hlid); 579 VIF_STATE_PRINT_INT(sta.basic_rate_idx); 580 VIF_STATE_PRINT_INT(sta.ap_rate_idx); 581 VIF_STATE_PRINT_INT(sta.p2p_rate_idx); 582 VIF_STATE_PRINT_INT(sta.qos); 583 } else { 584 VIF_STATE_PRINT_INT(ap.global_hlid); 585 VIF_STATE_PRINT_INT(ap.bcast_hlid); 586 VIF_STATE_PRINT_LHEX(ap.sta_hlid_map[0]); 587 VIF_STATE_PRINT_INT(ap.mgmt_rate_idx); 588 VIF_STATE_PRINT_INT(ap.bcast_rate_idx); 589 VIF_STATE_PRINT_INT(ap.ucast_rate_idx[0]); 590 VIF_STATE_PRINT_INT(ap.ucast_rate_idx[1]); 591 VIF_STATE_PRINT_INT(ap.ucast_rate_idx[2]); 592 VIF_STATE_PRINT_INT(ap.ucast_rate_idx[3]); 593 } 594 VIF_STATE_PRINT_INT(last_tx_hlid); 595 VIF_STATE_PRINT_INT(tx_queue_count[0]); 596 VIF_STATE_PRINT_INT(tx_queue_count[1]); 597 VIF_STATE_PRINT_INT(tx_queue_count[2]); 598 VIF_STATE_PRINT_INT(tx_queue_count[3]); 599 VIF_STATE_PRINT_LHEX(links_map[0]); 600 VIF_STATE_PRINT_NSTR(ssid, wlvif->ssid_len); 601 VIF_STATE_PRINT_INT(band); 602 VIF_STATE_PRINT_INT(channel); 603 VIF_STATE_PRINT_HEX(bitrate_masks[0]); 604 VIF_STATE_PRINT_HEX(bitrate_masks[1]); 605 VIF_STATE_PRINT_HEX(basic_rate_set); 606 VIF_STATE_PRINT_HEX(basic_rate); 607 VIF_STATE_PRINT_HEX(rate_set); 608 VIF_STATE_PRINT_INT(beacon_int); 609 VIF_STATE_PRINT_INT(default_key); 610 VIF_STATE_PRINT_INT(aid); 611 VIF_STATE_PRINT_INT(psm_entry_retry); 612 VIF_STATE_PRINT_INT(power_level); 613 VIF_STATE_PRINT_INT(rssi_thold); 614 VIF_STATE_PRINT_INT(last_rssi_event); 615 VIF_STATE_PRINT_INT(ba_support); 616 VIF_STATE_PRINT_INT(ba_allowed); 617 VIF_STATE_PRINT_LLHEX(total_freed_pkts); 618 } 619 620 #undef VIF_STATE_PRINT_INT 621 #undef VIF_STATE_PRINT_LONG 622 #undef VIF_STATE_PRINT_HEX 623 #undef VIF_STATE_PRINT_LHEX 624 #undef VIF_STATE_PRINT_LLHEX 625 #undef VIF_STATE_PRINT_STR 626 #undef VIF_STATE_PRINT_NSTR 627 #undef VIF_STATE_PRINT 628 629 mutex_unlock(&wl->mutex); 630 631 ret = simple_read_from_buffer(user_buf, count, ppos, buf, res); 632 kfree(buf); 633 return ret; 634 } 635 636 static const struct file_operations vifs_state_ops = { 637 .read = vifs_state_read, 638 .open = simple_open, 639 .llseek = default_llseek, 640 }; 641 642 static ssize_t dtim_interval_read(struct file *file, char __user *user_buf, 643 size_t count, loff_t *ppos) 644 { 645 struct wl1271 *wl = file->private_data; 646 u8 value; 647 648 if (wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_DTIM || 649 wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_N_DTIM) 650 value = wl->conf.conn.listen_interval; 651 else 652 value = 0; 653 654 return wl1271_format_buffer(user_buf, count, ppos, "%d\n", value); 655 } 656 657 static ssize_t dtim_interval_write(struct file *file, 658 const char __user *user_buf, 659 size_t count, loff_t *ppos) 660 { 661 struct wl1271 *wl = file->private_data; 662 unsigned long value; 663 int ret; 664 665 ret = kstrtoul_from_user(user_buf, count, 10, &value); 666 if (ret < 0) { 667 wl1271_warning("illegal value for dtim_interval"); 668 return -EINVAL; 669 } 670 671 if (value < 1 || value > 10) { 672 wl1271_warning("dtim value is not in valid range"); 673 return -ERANGE; 674 } 675 676 mutex_lock(&wl->mutex); 677 678 wl->conf.conn.listen_interval = value; 679 /* for some reason there are different event types for 1 and >1 */ 680 if (value == 1) 681 wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_DTIM; 682 else 683 wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_N_DTIM; 684 685 /* 686 * we don't reconfigure ACX_WAKE_UP_CONDITIONS now, so it will only 687 * take effect on the next time we enter psm. 688 */ 689 mutex_unlock(&wl->mutex); 690 return count; 691 } 692 693 static const struct file_operations dtim_interval_ops = { 694 .read = dtim_interval_read, 695 .write = dtim_interval_write, 696 .open = simple_open, 697 .llseek = default_llseek, 698 }; 699 700 701 702 static ssize_t suspend_dtim_interval_read(struct file *file, 703 char __user *user_buf, 704 size_t count, loff_t *ppos) 705 { 706 struct wl1271 *wl = file->private_data; 707 u8 value; 708 709 if (wl->conf.conn.suspend_wake_up_event == CONF_WAKE_UP_EVENT_DTIM || 710 wl->conf.conn.suspend_wake_up_event == CONF_WAKE_UP_EVENT_N_DTIM) 711 value = wl->conf.conn.suspend_listen_interval; 712 else 713 value = 0; 714 715 return wl1271_format_buffer(user_buf, count, ppos, "%d\n", value); 716 } 717 718 static ssize_t suspend_dtim_interval_write(struct file *file, 719 const char __user *user_buf, 720 size_t count, loff_t *ppos) 721 { 722 struct wl1271 *wl = file->private_data; 723 unsigned long value; 724 int ret; 725 726 ret = kstrtoul_from_user(user_buf, count, 10, &value); 727 if (ret < 0) { 728 wl1271_warning("illegal value for suspend_dtim_interval"); 729 return -EINVAL; 730 } 731 732 if (value < 1 || value > 10) { 733 wl1271_warning("suspend_dtim value is not in valid range"); 734 return -ERANGE; 735 } 736 737 mutex_lock(&wl->mutex); 738 739 wl->conf.conn.suspend_listen_interval = value; 740 /* for some reason there are different event types for 1 and >1 */ 741 if (value == 1) 742 wl->conf.conn.suspend_wake_up_event = CONF_WAKE_UP_EVENT_DTIM; 743 else 744 wl->conf.conn.suspend_wake_up_event = CONF_WAKE_UP_EVENT_N_DTIM; 745 746 mutex_unlock(&wl->mutex); 747 return count; 748 } 749 750 751 static const struct file_operations suspend_dtim_interval_ops = { 752 .read = suspend_dtim_interval_read, 753 .write = suspend_dtim_interval_write, 754 .open = simple_open, 755 .llseek = default_llseek, 756 }; 757 758 static ssize_t beacon_interval_read(struct file *file, char __user *user_buf, 759 size_t count, loff_t *ppos) 760 { 761 struct wl1271 *wl = file->private_data; 762 u8 value; 763 764 if (wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_BEACON || 765 wl->conf.conn.wake_up_event == CONF_WAKE_UP_EVENT_N_BEACONS) 766 value = wl->conf.conn.listen_interval; 767 else 768 value = 0; 769 770 return wl1271_format_buffer(user_buf, count, ppos, "%d\n", value); 771 } 772 773 static ssize_t beacon_interval_write(struct file *file, 774 const char __user *user_buf, 775 size_t count, loff_t *ppos) 776 { 777 struct wl1271 *wl = file->private_data; 778 unsigned long value; 779 int ret; 780 781 ret = kstrtoul_from_user(user_buf, count, 10, &value); 782 if (ret < 0) { 783 wl1271_warning("illegal value for beacon_interval"); 784 return -EINVAL; 785 } 786 787 if (value < 1 || value > 255) { 788 wl1271_warning("beacon interval value is not in valid range"); 789 return -ERANGE; 790 } 791 792 mutex_lock(&wl->mutex); 793 794 wl->conf.conn.listen_interval = value; 795 /* for some reason there are different event types for 1 and >1 */ 796 if (value == 1) 797 wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_BEACON; 798 else 799 wl->conf.conn.wake_up_event = CONF_WAKE_UP_EVENT_N_BEACONS; 800 801 /* 802 * we don't reconfigure ACX_WAKE_UP_CONDITIONS now, so it will only 803 * take effect on the next time we enter psm. 804 */ 805 mutex_unlock(&wl->mutex); 806 return count; 807 } 808 809 static const struct file_operations beacon_interval_ops = { 810 .read = beacon_interval_read, 811 .write = beacon_interval_write, 812 .open = simple_open, 813 .llseek = default_llseek, 814 }; 815 816 static ssize_t rx_streaming_interval_write(struct file *file, 817 const char __user *user_buf, 818 size_t count, loff_t *ppos) 819 { 820 struct wl1271 *wl = file->private_data; 821 struct wl12xx_vif *wlvif; 822 unsigned long value; 823 int ret; 824 825 ret = kstrtoul_from_user(user_buf, count, 10, &value); 826 if (ret < 0) { 827 wl1271_warning("illegal value in rx_streaming_interval!"); 828 return -EINVAL; 829 } 830 831 /* valid values: 0, 10-100 */ 832 if (value && (value < 10 || value > 100)) { 833 wl1271_warning("value is not in range!"); 834 return -ERANGE; 835 } 836 837 mutex_lock(&wl->mutex); 838 839 wl->conf.rx_streaming.interval = value; 840 841 ret = wl1271_ps_elp_wakeup(wl); 842 if (ret < 0) 843 goto out; 844 845 wl12xx_for_each_wlvif_sta(wl, wlvif) { 846 wl1271_recalc_rx_streaming(wl, wlvif); 847 } 848 849 wl1271_ps_elp_sleep(wl); 850 out: 851 mutex_unlock(&wl->mutex); 852 return count; 853 } 854 855 static ssize_t rx_streaming_interval_read(struct file *file, 856 char __user *userbuf, 857 size_t count, loff_t *ppos) 858 { 859 struct wl1271 *wl = file->private_data; 860 return wl1271_format_buffer(userbuf, count, ppos, 861 "%d\n", wl->conf.rx_streaming.interval); 862 } 863 864 static const struct file_operations rx_streaming_interval_ops = { 865 .read = rx_streaming_interval_read, 866 .write = rx_streaming_interval_write, 867 .open = simple_open, 868 .llseek = default_llseek, 869 }; 870 871 static ssize_t rx_streaming_always_write(struct file *file, 872 const char __user *user_buf, 873 size_t count, loff_t *ppos) 874 { 875 struct wl1271 *wl = file->private_data; 876 struct wl12xx_vif *wlvif; 877 unsigned long value; 878 int ret; 879 880 ret = kstrtoul_from_user(user_buf, count, 10, &value); 881 if (ret < 0) { 882 wl1271_warning("illegal value in rx_streaming_write!"); 883 return -EINVAL; 884 } 885 886 /* valid values: 0, 10-100 */ 887 if (!(value == 0 || value == 1)) { 888 wl1271_warning("value is not in valid!"); 889 return -EINVAL; 890 } 891 892 mutex_lock(&wl->mutex); 893 894 wl->conf.rx_streaming.always = value; 895 896 ret = wl1271_ps_elp_wakeup(wl); 897 if (ret < 0) 898 goto out; 899 900 wl12xx_for_each_wlvif_sta(wl, wlvif) { 901 wl1271_recalc_rx_streaming(wl, wlvif); 902 } 903 904 wl1271_ps_elp_sleep(wl); 905 out: 906 mutex_unlock(&wl->mutex); 907 return count; 908 } 909 910 static ssize_t rx_streaming_always_read(struct file *file, 911 char __user *userbuf, 912 size_t count, loff_t *ppos) 913 { 914 struct wl1271 *wl = file->private_data; 915 return wl1271_format_buffer(userbuf, count, ppos, 916 "%d\n", wl->conf.rx_streaming.always); 917 } 918 919 static const struct file_operations rx_streaming_always_ops = { 920 .read = rx_streaming_always_read, 921 .write = rx_streaming_always_write, 922 .open = simple_open, 923 .llseek = default_llseek, 924 }; 925 926 static ssize_t beacon_filtering_write(struct file *file, 927 const char __user *user_buf, 928 size_t count, loff_t *ppos) 929 { 930 struct wl1271 *wl = file->private_data; 931 struct wl12xx_vif *wlvif; 932 unsigned long value; 933 int ret; 934 935 ret = kstrtoul_from_user(user_buf, count, 0, &value); 936 if (ret < 0) { 937 wl1271_warning("illegal value for beacon_filtering!"); 938 return -EINVAL; 939 } 940 941 mutex_lock(&wl->mutex); 942 943 ret = wl1271_ps_elp_wakeup(wl); 944 if (ret < 0) 945 goto out; 946 947 wl12xx_for_each_wlvif(wl, wlvif) { 948 ret = wl1271_acx_beacon_filter_opt(wl, wlvif, !!value); 949 } 950 951 wl1271_ps_elp_sleep(wl); 952 out: 953 mutex_unlock(&wl->mutex); 954 return count; 955 } 956 957 static const struct file_operations beacon_filtering_ops = { 958 .write = beacon_filtering_write, 959 .open = simple_open, 960 .llseek = default_llseek, 961 }; 962 963 static ssize_t fw_stats_raw_read(struct file *file, 964 char __user *userbuf, 965 size_t count, loff_t *ppos) 966 { 967 struct wl1271 *wl = file->private_data; 968 969 wl1271_debugfs_update_stats(wl); 970 971 return simple_read_from_buffer(userbuf, count, ppos, 972 wl->stats.fw_stats, 973 wl->stats.fw_stats_len); 974 } 975 976 static const struct file_operations fw_stats_raw_ops = { 977 .read = fw_stats_raw_read, 978 .open = simple_open, 979 .llseek = default_llseek, 980 }; 981 982 static ssize_t sleep_auth_read(struct file *file, char __user *user_buf, 983 size_t count, loff_t *ppos) 984 { 985 struct wl1271 *wl = file->private_data; 986 987 return wl1271_format_buffer(user_buf, count, 988 ppos, "%d\n", 989 wl->sleep_auth); 990 } 991 992 static ssize_t sleep_auth_write(struct file *file, 993 const char __user *user_buf, 994 size_t count, loff_t *ppos) 995 { 996 struct wl1271 *wl = file->private_data; 997 unsigned long value; 998 int ret; 999 1000 ret = kstrtoul_from_user(user_buf, count, 0, &value); 1001 if (ret < 0) { 1002 wl1271_warning("illegal value in sleep_auth"); 1003 return -EINVAL; 1004 } 1005 1006 if (value > WL1271_PSM_MAX) { 1007 wl1271_warning("sleep_auth must be between 0 and %d", 1008 WL1271_PSM_MAX); 1009 return -ERANGE; 1010 } 1011 1012 mutex_lock(&wl->mutex); 1013 1014 wl->conf.conn.sta_sleep_auth = value; 1015 1016 if (unlikely(wl->state != WLCORE_STATE_ON)) { 1017 /* this will show up on "read" in case we are off */ 1018 wl->sleep_auth = value; 1019 goto out; 1020 } 1021 1022 ret = wl1271_ps_elp_wakeup(wl); 1023 if (ret < 0) 1024 goto out; 1025 1026 ret = wl1271_acx_sleep_auth(wl, value); 1027 if (ret < 0) 1028 goto out_sleep; 1029 1030 out_sleep: 1031 wl1271_ps_elp_sleep(wl); 1032 out: 1033 mutex_unlock(&wl->mutex); 1034 return count; 1035 } 1036 1037 static const struct file_operations sleep_auth_ops = { 1038 .read = sleep_auth_read, 1039 .write = sleep_auth_write, 1040 .open = simple_open, 1041 .llseek = default_llseek, 1042 }; 1043 1044 static ssize_t dev_mem_read(struct file *file, 1045 char __user *user_buf, size_t count, 1046 loff_t *ppos) 1047 { 1048 struct wl1271 *wl = file->private_data; 1049 struct wlcore_partition_set part, old_part; 1050 size_t bytes = count; 1051 int ret; 1052 char *buf; 1053 1054 /* only requests of dword-aligned size and offset are supported */ 1055 if (bytes % 4) 1056 return -EINVAL; 1057 1058 if (*ppos % 4) 1059 return -EINVAL; 1060 1061 /* function should return in reasonable time */ 1062 bytes = min(bytes, WLCORE_MAX_BLOCK_SIZE); 1063 1064 if (bytes == 0) 1065 return -EINVAL; 1066 1067 memset(&part, 0, sizeof(part)); 1068 part.mem.start = *ppos; 1069 part.mem.size = bytes; 1070 1071 buf = kmalloc(bytes, GFP_KERNEL); 1072 if (!buf) 1073 return -ENOMEM; 1074 1075 mutex_lock(&wl->mutex); 1076 1077 if (unlikely(wl->state == WLCORE_STATE_OFF)) { 1078 ret = -EFAULT; 1079 goto skip_read; 1080 } 1081 1082 /* 1083 * Don't fail if elp_wakeup returns an error, so the device's memory 1084 * could be read even if the FW crashed 1085 */ 1086 wl1271_ps_elp_wakeup(wl); 1087 1088 /* store current partition and switch partition */ 1089 memcpy(&old_part, &wl->curr_part, sizeof(old_part)); 1090 ret = wlcore_set_partition(wl, &part); 1091 if (ret < 0) 1092 goto part_err; 1093 1094 ret = wlcore_raw_read(wl, 0, buf, bytes, false); 1095 if (ret < 0) 1096 goto read_err; 1097 1098 read_err: 1099 /* recover partition */ 1100 ret = wlcore_set_partition(wl, &old_part); 1101 if (ret < 0) 1102 goto part_err; 1103 1104 part_err: 1105 wl1271_ps_elp_sleep(wl); 1106 1107 skip_read: 1108 mutex_unlock(&wl->mutex); 1109 1110 if (ret == 0) { 1111 ret = copy_to_user(user_buf, buf, bytes); 1112 if (ret < bytes) { 1113 bytes -= ret; 1114 *ppos += bytes; 1115 ret = 0; 1116 } else { 1117 ret = -EFAULT; 1118 } 1119 } 1120 1121 kfree(buf); 1122 1123 return ((ret == 0) ? bytes : ret); 1124 } 1125 1126 static ssize_t dev_mem_write(struct file *file, const char __user *user_buf, 1127 size_t count, loff_t *ppos) 1128 { 1129 struct wl1271 *wl = file->private_data; 1130 struct wlcore_partition_set part, old_part; 1131 size_t bytes = count; 1132 int ret; 1133 char *buf; 1134 1135 /* only requests of dword-aligned size and offset are supported */ 1136 if (bytes % 4) 1137 return -EINVAL; 1138 1139 if (*ppos % 4) 1140 return -EINVAL; 1141 1142 /* function should return in reasonable time */ 1143 bytes = min(bytes, WLCORE_MAX_BLOCK_SIZE); 1144 1145 if (bytes == 0) 1146 return -EINVAL; 1147 1148 memset(&part, 0, sizeof(part)); 1149 part.mem.start = *ppos; 1150 part.mem.size = bytes; 1151 1152 buf = memdup_user(user_buf, bytes); 1153 if (IS_ERR(buf)) 1154 return PTR_ERR(buf); 1155 1156 mutex_lock(&wl->mutex); 1157 1158 if (unlikely(wl->state == WLCORE_STATE_OFF)) { 1159 ret = -EFAULT; 1160 goto skip_write; 1161 } 1162 1163 /* 1164 * Don't fail if elp_wakeup returns an error, so the device's memory 1165 * could be read even if the FW crashed 1166 */ 1167 wl1271_ps_elp_wakeup(wl); 1168 1169 /* store current partition and switch partition */ 1170 memcpy(&old_part, &wl->curr_part, sizeof(old_part)); 1171 ret = wlcore_set_partition(wl, &part); 1172 if (ret < 0) 1173 goto part_err; 1174 1175 ret = wlcore_raw_write(wl, 0, buf, bytes, false); 1176 if (ret < 0) 1177 goto write_err; 1178 1179 write_err: 1180 /* recover partition */ 1181 ret = wlcore_set_partition(wl, &old_part); 1182 if (ret < 0) 1183 goto part_err; 1184 1185 part_err: 1186 wl1271_ps_elp_sleep(wl); 1187 1188 skip_write: 1189 mutex_unlock(&wl->mutex); 1190 1191 if (ret == 0) 1192 *ppos += bytes; 1193 1194 kfree(buf); 1195 1196 return ((ret == 0) ? bytes : ret); 1197 } 1198 1199 static loff_t dev_mem_seek(struct file *file, loff_t offset, int orig) 1200 { 1201 /* only requests of dword-aligned size and offset are supported */ 1202 if (offset % 4) 1203 return -EINVAL; 1204 1205 return no_seek_end_llseek(file, offset, orig); 1206 } 1207 1208 static const struct file_operations dev_mem_ops = { 1209 .open = simple_open, 1210 .read = dev_mem_read, 1211 .write = dev_mem_write, 1212 .llseek = dev_mem_seek, 1213 }; 1214 1215 static ssize_t fw_logger_read(struct file *file, char __user *user_buf, 1216 size_t count, loff_t *ppos) 1217 { 1218 struct wl1271 *wl = file->private_data; 1219 1220 return wl1271_format_buffer(user_buf, count, 1221 ppos, "%d\n", 1222 wl->conf.fwlog.output); 1223 } 1224 1225 static ssize_t fw_logger_write(struct file *file, 1226 const char __user *user_buf, 1227 size_t count, loff_t *ppos) 1228 { 1229 struct wl1271 *wl = file->private_data; 1230 unsigned long value; 1231 int ret; 1232 1233 ret = kstrtoul_from_user(user_buf, count, 0, &value); 1234 if (ret < 0) { 1235 wl1271_warning("illegal value in fw_logger"); 1236 return -EINVAL; 1237 } 1238 1239 if ((value > 2) || (value == 0)) { 1240 wl1271_warning("fw_logger value must be 1-UART 2-SDIO"); 1241 return -ERANGE; 1242 } 1243 1244 if (wl->conf.fwlog.output == 0) { 1245 wl1271_warning("invalid operation - fw logger disabled by default, please change mode via wlconf"); 1246 return -EINVAL; 1247 } 1248 1249 mutex_lock(&wl->mutex); 1250 ret = wl1271_ps_elp_wakeup(wl); 1251 if (ret < 0) { 1252 count = ret; 1253 goto out; 1254 } 1255 1256 wl->conf.fwlog.output = value; 1257 1258 ret = wl12xx_cmd_config_fwlog(wl); 1259 1260 wl1271_ps_elp_sleep(wl); 1261 1262 out: 1263 mutex_unlock(&wl->mutex); 1264 return count; 1265 } 1266 1267 static const struct file_operations fw_logger_ops = { 1268 .open = simple_open, 1269 .read = fw_logger_read, 1270 .write = fw_logger_write, 1271 .llseek = default_llseek, 1272 }; 1273 1274 static int wl1271_debugfs_add_files(struct wl1271 *wl, 1275 struct dentry *rootdir) 1276 { 1277 int ret = 0; 1278 struct dentry *entry, *streaming; 1279 1280 DEBUGFS_ADD(tx_queue_len, rootdir); 1281 DEBUGFS_ADD(retry_count, rootdir); 1282 DEBUGFS_ADD(excessive_retries, rootdir); 1283 1284 DEBUGFS_ADD(gpio_power, rootdir); 1285 DEBUGFS_ADD(start_recovery, rootdir); 1286 DEBUGFS_ADD(driver_state, rootdir); 1287 DEBUGFS_ADD(vifs_state, rootdir); 1288 DEBUGFS_ADD(dtim_interval, rootdir); 1289 DEBUGFS_ADD(suspend_dtim_interval, rootdir); 1290 DEBUGFS_ADD(beacon_interval, rootdir); 1291 DEBUGFS_ADD(beacon_filtering, rootdir); 1292 DEBUGFS_ADD(dynamic_ps_timeout, rootdir); 1293 DEBUGFS_ADD(forced_ps, rootdir); 1294 DEBUGFS_ADD(split_scan_timeout, rootdir); 1295 DEBUGFS_ADD(irq_pkt_threshold, rootdir); 1296 DEBUGFS_ADD(irq_blk_threshold, rootdir); 1297 DEBUGFS_ADD(irq_timeout, rootdir); 1298 DEBUGFS_ADD(fw_stats_raw, rootdir); 1299 DEBUGFS_ADD(sleep_auth, rootdir); 1300 DEBUGFS_ADD(fw_logger, rootdir); 1301 1302 streaming = debugfs_create_dir("rx_streaming", rootdir); 1303 if (!streaming || IS_ERR(streaming)) 1304 goto err; 1305 1306 DEBUGFS_ADD_PREFIX(rx_streaming, interval, streaming); 1307 DEBUGFS_ADD_PREFIX(rx_streaming, always, streaming); 1308 1309 DEBUGFS_ADD_PREFIX(dev, mem, rootdir); 1310 1311 return 0; 1312 1313 err: 1314 if (IS_ERR(entry)) 1315 ret = PTR_ERR(entry); 1316 else 1317 ret = -ENOMEM; 1318 1319 return ret; 1320 } 1321 1322 void wl1271_debugfs_reset(struct wl1271 *wl) 1323 { 1324 if (!wl->stats.fw_stats) 1325 return; 1326 1327 memset(wl->stats.fw_stats, 0, wl->stats.fw_stats_len); 1328 wl->stats.retry_count = 0; 1329 wl->stats.excessive_retries = 0; 1330 } 1331 1332 int wl1271_debugfs_init(struct wl1271 *wl) 1333 { 1334 int ret; 1335 struct dentry *rootdir; 1336 1337 rootdir = debugfs_create_dir(KBUILD_MODNAME, 1338 wl->hw->wiphy->debugfsdir); 1339 1340 if (IS_ERR(rootdir)) { 1341 ret = PTR_ERR(rootdir); 1342 goto out; 1343 } 1344 1345 wl->stats.fw_stats = kzalloc(wl->stats.fw_stats_len, GFP_KERNEL); 1346 if (!wl->stats.fw_stats) { 1347 ret = -ENOMEM; 1348 goto out_remove; 1349 } 1350 1351 wl->stats.fw_stats_update = jiffies; 1352 1353 ret = wl1271_debugfs_add_files(wl, rootdir); 1354 if (ret < 0) 1355 goto out_exit; 1356 1357 ret = wlcore_debugfs_init(wl, rootdir); 1358 if (ret < 0) 1359 goto out_exit; 1360 1361 goto out; 1362 1363 out_exit: 1364 wl1271_debugfs_exit(wl); 1365 1366 out_remove: 1367 debugfs_remove_recursive(rootdir); 1368 1369 out: 1370 return ret; 1371 } 1372 1373 void wl1271_debugfs_exit(struct wl1271 *wl) 1374 { 1375 kfree(wl->stats.fw_stats); 1376 wl->stats.fw_stats = NULL; 1377 } 1378