xref: /openbmc/linux/drivers/net/wireless/ti/wlcore/cmd.c (revision 84d517f3)
1 /*
2  * This file is part of wl1271
3  *
4  * Copyright (C) 2009-2010 Nokia Corporation
5  *
6  * Contact: Luciano Coelho <luciano.coelho@nokia.com>
7  *
8  * This program is free software; you can redistribute it and/or
9  * modify it under the terms of the GNU General Public License
10  * version 2 as published by the Free Software Foundation.
11  *
12  * This program is distributed in the hope that it will be useful, but
13  * WITHOUT ANY WARRANTY; without even the implied warranty of
14  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
15  * General Public License for more details.
16  *
17  * You should have received a copy of the GNU General Public License
18  * along with this program; if not, write to the Free Software
19  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
20  * 02110-1301 USA
21  *
22  */
23 
24 #include <linux/module.h>
25 #include <linux/platform_device.h>
26 #include <linux/spi/spi.h>
27 #include <linux/etherdevice.h>
28 #include <linux/ieee80211.h>
29 #include <linux/slab.h>
30 
31 #include "wlcore.h"
32 #include "debug.h"
33 #include "io.h"
34 #include "acx.h"
35 #include "wl12xx_80211.h"
36 #include "cmd.h"
37 #include "event.h"
38 #include "tx.h"
39 #include "hw_ops.h"
40 
41 #define WL1271_CMD_FAST_POLL_COUNT       50
42 #define WL1271_WAIT_EVENT_FAST_POLL_COUNT 20
43 
44 /*
45  * send command to firmware
46  *
47  * @wl: wl struct
48  * @id: command id
49  * @buf: buffer containing the command, must work with dma
50  * @len: length of the buffer
51  * return the cmd status code on success.
52  */
53 static int __wlcore_cmd_send(struct wl1271 *wl, u16 id, void *buf,
54 			     size_t len, size_t res_len)
55 {
56 	struct wl1271_cmd_header *cmd;
57 	unsigned long timeout;
58 	u32 intr;
59 	int ret;
60 	u16 status;
61 	u16 poll_count = 0;
62 
63 	if (unlikely(wl->state == WLCORE_STATE_RESTARTING &&
64 		     id != CMD_STOP_FWLOGGER))
65 		return -EIO;
66 
67 	cmd = buf;
68 	cmd->id = cpu_to_le16(id);
69 	cmd->status = 0;
70 
71 	WARN_ON(len % 4 != 0);
72 	WARN_ON(test_bit(WL1271_FLAG_IN_ELP, &wl->flags));
73 
74 	ret = wlcore_write(wl, wl->cmd_box_addr, buf, len, false);
75 	if (ret < 0)
76 		return ret;
77 
78 	/*
79 	 * TODO: we just need this because one bit is in a different
80 	 * place.  Is there any better way?
81 	 */
82 	ret = wl->ops->trigger_cmd(wl, wl->cmd_box_addr, buf, len);
83 	if (ret < 0)
84 		return ret;
85 
86 	timeout = jiffies + msecs_to_jiffies(WL1271_COMMAND_TIMEOUT);
87 
88 	ret = wlcore_read_reg(wl, REG_INTERRUPT_NO_CLEAR, &intr);
89 	if (ret < 0)
90 		return ret;
91 
92 	while (!(intr & WL1271_ACX_INTR_CMD_COMPLETE)) {
93 		if (time_after(jiffies, timeout)) {
94 			wl1271_error("command complete timeout");
95 			return -ETIMEDOUT;
96 		}
97 
98 		poll_count++;
99 		if (poll_count < WL1271_CMD_FAST_POLL_COUNT)
100 			udelay(10);
101 		else
102 			msleep(1);
103 
104 		ret = wlcore_read_reg(wl, REG_INTERRUPT_NO_CLEAR, &intr);
105 		if (ret < 0)
106 			return ret;
107 	}
108 
109 	/* read back the status code of the command */
110 	if (res_len == 0)
111 		res_len = sizeof(struct wl1271_cmd_header);
112 
113 	ret = wlcore_read(wl, wl->cmd_box_addr, cmd, res_len, false);
114 	if (ret < 0)
115 		return ret;
116 
117 	status = le16_to_cpu(cmd->status);
118 
119 	ret = wlcore_write_reg(wl, REG_INTERRUPT_ACK,
120 			       WL1271_ACX_INTR_CMD_COMPLETE);
121 	if (ret < 0)
122 		return ret;
123 
124 	return status;
125 }
126 
127 /*
128  * send command to fw and return cmd status on success
129  * valid_rets contains a bitmap of allowed error codes
130  */
131 int wlcore_cmd_send_failsafe(struct wl1271 *wl, u16 id, void *buf, size_t len,
132 			     size_t res_len, unsigned long valid_rets)
133 {
134 	int ret = __wlcore_cmd_send(wl, id, buf, len, res_len);
135 
136 	if (ret < 0)
137 		goto fail;
138 
139 	/* success is always a valid status */
140 	valid_rets |= BIT(CMD_STATUS_SUCCESS);
141 
142 	if (ret >= MAX_COMMAND_STATUS ||
143 	    !test_bit(ret, &valid_rets)) {
144 		wl1271_error("command execute failure %d", ret);
145 		ret = -EIO;
146 		goto fail;
147 	}
148 	return ret;
149 fail:
150 	wl12xx_queue_recovery_work(wl);
151 	return ret;
152 }
153 EXPORT_SYMBOL_GPL(wl1271_cmd_send);
154 
155 /*
156  * wrapper for wlcore_cmd_send that accept only CMD_STATUS_SUCCESS
157  * return 0 on success.
158  */
159 int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
160 		    size_t res_len)
161 {
162 	int ret = wlcore_cmd_send_failsafe(wl, id, buf, len, res_len, 0);
163 
164 	if (ret < 0)
165 		return ret;
166 	return 0;
167 }
168 
169 /*
170  * Poll the mailbox event field until any of the bits in the mask is set or a
171  * timeout occurs (WL1271_EVENT_TIMEOUT in msecs)
172  */
173 int wlcore_cmd_wait_for_event_or_timeout(struct wl1271 *wl,
174 					 u32 mask, bool *timeout)
175 {
176 	u32 *events_vector;
177 	u32 event;
178 	unsigned long timeout_time;
179 	u16 poll_count = 0;
180 	int ret = 0;
181 
182 	*timeout = false;
183 
184 	events_vector = kmalloc(sizeof(*events_vector), GFP_KERNEL | GFP_DMA);
185 	if (!events_vector)
186 		return -ENOMEM;
187 
188 	timeout_time = jiffies + msecs_to_jiffies(WL1271_EVENT_TIMEOUT);
189 
190 	do {
191 		if (time_after(jiffies, timeout_time)) {
192 			wl1271_debug(DEBUG_CMD, "timeout waiting for event %d",
193 				     (int)mask);
194 			*timeout = true;
195 			goto out;
196 		}
197 
198 		poll_count++;
199 		if (poll_count < WL1271_WAIT_EVENT_FAST_POLL_COUNT)
200 			usleep_range(50, 51);
201 		else
202 			usleep_range(1000, 5000);
203 
204 		/* read from both event fields */
205 		ret = wlcore_read(wl, wl->mbox_ptr[0], events_vector,
206 				  sizeof(*events_vector), false);
207 		if (ret < 0)
208 			goto out;
209 
210 		event = *events_vector & mask;
211 
212 		ret = wlcore_read(wl, wl->mbox_ptr[1], events_vector,
213 				  sizeof(*events_vector), false);
214 		if (ret < 0)
215 			goto out;
216 
217 		event |= *events_vector & mask;
218 	} while (!event);
219 
220 out:
221 	kfree(events_vector);
222 	return ret;
223 }
224 EXPORT_SYMBOL_GPL(wlcore_cmd_wait_for_event_or_timeout);
225 
226 int wl12xx_cmd_role_enable(struct wl1271 *wl, u8 *addr, u8 role_type,
227 			   u8 *role_id)
228 {
229 	struct wl12xx_cmd_role_enable *cmd;
230 	int ret;
231 
232 	wl1271_debug(DEBUG_CMD, "cmd role enable");
233 
234 	if (WARN_ON(*role_id != WL12XX_INVALID_ROLE_ID))
235 		return -EBUSY;
236 
237 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
238 	if (!cmd) {
239 		ret = -ENOMEM;
240 		goto out;
241 	}
242 
243 	/* get role id */
244 	cmd->role_id = find_first_zero_bit(wl->roles_map, WL12XX_MAX_ROLES);
245 	if (cmd->role_id >= WL12XX_MAX_ROLES) {
246 		ret = -EBUSY;
247 		goto out_free;
248 	}
249 
250 	memcpy(cmd->mac_address, addr, ETH_ALEN);
251 	cmd->role_type = role_type;
252 
253 	ret = wl1271_cmd_send(wl, CMD_ROLE_ENABLE, cmd, sizeof(*cmd), 0);
254 	if (ret < 0) {
255 		wl1271_error("failed to initiate cmd role enable");
256 		goto out_free;
257 	}
258 
259 	__set_bit(cmd->role_id, wl->roles_map);
260 	*role_id = cmd->role_id;
261 
262 out_free:
263 	kfree(cmd);
264 
265 out:
266 	return ret;
267 }
268 
269 int wl12xx_cmd_role_disable(struct wl1271 *wl, u8 *role_id)
270 {
271 	struct wl12xx_cmd_role_disable *cmd;
272 	int ret;
273 
274 	wl1271_debug(DEBUG_CMD, "cmd role disable");
275 
276 	if (WARN_ON(*role_id == WL12XX_INVALID_ROLE_ID))
277 		return -ENOENT;
278 
279 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
280 	if (!cmd) {
281 		ret = -ENOMEM;
282 		goto out;
283 	}
284 	cmd->role_id = *role_id;
285 
286 	ret = wl1271_cmd_send(wl, CMD_ROLE_DISABLE, cmd, sizeof(*cmd), 0);
287 	if (ret < 0) {
288 		wl1271_error("failed to initiate cmd role disable");
289 		goto out_free;
290 	}
291 
292 	__clear_bit(*role_id, wl->roles_map);
293 	*role_id = WL12XX_INVALID_ROLE_ID;
294 
295 out_free:
296 	kfree(cmd);
297 
298 out:
299 	return ret;
300 }
301 
302 static int wlcore_get_new_session_id(struct wl1271 *wl, u8 hlid)
303 {
304 	if (wl->session_ids[hlid] >= SESSION_COUNTER_MAX)
305 		wl->session_ids[hlid] = 0;
306 
307 	wl->session_ids[hlid]++;
308 
309 	return wl->session_ids[hlid];
310 }
311 
312 int wl12xx_allocate_link(struct wl1271 *wl, struct wl12xx_vif *wlvif, u8 *hlid)
313 {
314 	unsigned long flags;
315 	u8 link = find_first_zero_bit(wl->links_map, wl->num_links);
316 	if (link >= wl->num_links)
317 		return -EBUSY;
318 
319 	wl->session_ids[link] = wlcore_get_new_session_id(wl, link);
320 
321 	/* these bits are used by op_tx */
322 	spin_lock_irqsave(&wl->wl_lock, flags);
323 	__set_bit(link, wl->links_map);
324 	__set_bit(link, wlvif->links_map);
325 	spin_unlock_irqrestore(&wl->wl_lock, flags);
326 
327 	/*
328 	 * take the last "freed packets" value from the current FW status.
329 	 * on recovery, we might not have fw_status yet, and
330 	 * tx_lnk_free_pkts will be NULL. check for it.
331 	 */
332 	if (wl->fw_status->counters.tx_lnk_free_pkts)
333 		wl->links[link].prev_freed_pkts =
334 			wl->fw_status->counters.tx_lnk_free_pkts[link];
335 	wl->links[link].wlvif = wlvif;
336 
337 	/*
338 	 * Take saved value for total freed packets from wlvif, in case this is
339 	 * recovery/resume
340 	 */
341 	if (wlvif->bss_type != BSS_TYPE_AP_BSS)
342 		wl->links[link].total_freed_pkts = wlvif->total_freed_pkts;
343 
344 	*hlid = link;
345 
346 	wl->active_link_count++;
347 	return 0;
348 }
349 
350 void wl12xx_free_link(struct wl1271 *wl, struct wl12xx_vif *wlvif, u8 *hlid)
351 {
352 	unsigned long flags;
353 
354 	if (*hlid == WL12XX_INVALID_LINK_ID)
355 		return;
356 
357 	/* these bits are used by op_tx */
358 	spin_lock_irqsave(&wl->wl_lock, flags);
359 	__clear_bit(*hlid, wl->links_map);
360 	__clear_bit(*hlid, wlvif->links_map);
361 	spin_unlock_irqrestore(&wl->wl_lock, flags);
362 
363 	wl->links[*hlid].allocated_pkts = 0;
364 	wl->links[*hlid].prev_freed_pkts = 0;
365 	wl->links[*hlid].ba_bitmap = 0;
366 	memset(wl->links[*hlid].addr, 0, ETH_ALEN);
367 
368 	/*
369 	 * At this point op_tx() will not add more packets to the queues. We
370 	 * can purge them.
371 	 */
372 	wl1271_tx_reset_link_queues(wl, *hlid);
373 	wl->links[*hlid].wlvif = NULL;
374 
375 	if (wlvif->bss_type == BSS_TYPE_STA_BSS ||
376 	    (wlvif->bss_type == BSS_TYPE_AP_BSS &&
377 	     *hlid == wlvif->ap.bcast_hlid)) {
378 		/*
379 		 * save the total freed packets in the wlvif, in case this is
380 		 * recovery or suspend
381 		 */
382 		wlvif->total_freed_pkts = wl->links[*hlid].total_freed_pkts;
383 
384 		/*
385 		 * increment the initial seq number on recovery to account for
386 		 * transmitted packets that we haven't yet got in the FW status
387 		 */
388 		if (test_bit(WL1271_FLAG_RECOVERY_IN_PROGRESS, &wl->flags))
389 			wlvif->total_freed_pkts +=
390 					WL1271_TX_SQN_POST_RECOVERY_PADDING;
391 	}
392 
393 	wl->links[*hlid].total_freed_pkts = 0;
394 
395 	*hlid = WL12XX_INVALID_LINK_ID;
396 	wl->active_link_count--;
397 	WARN_ON_ONCE(wl->active_link_count < 0);
398 }
399 
400 static u8 wlcore_get_native_channel_type(u8 nl_channel_type)
401 {
402 	switch (nl_channel_type) {
403 	case NL80211_CHAN_NO_HT:
404 		return WLCORE_CHAN_NO_HT;
405 	case NL80211_CHAN_HT20:
406 		return WLCORE_CHAN_HT20;
407 	case NL80211_CHAN_HT40MINUS:
408 		return WLCORE_CHAN_HT40MINUS;
409 	case NL80211_CHAN_HT40PLUS:
410 		return WLCORE_CHAN_HT40PLUS;
411 	default:
412 		WARN_ON(1);
413 		return WLCORE_CHAN_NO_HT;
414 	}
415 }
416 
417 static int wl12xx_cmd_role_start_dev(struct wl1271 *wl,
418 				     struct wl12xx_vif *wlvif,
419 				     enum ieee80211_band band,
420 				     int channel)
421 {
422 	struct wl12xx_cmd_role_start *cmd;
423 	int ret;
424 
425 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
426 	if (!cmd) {
427 		ret = -ENOMEM;
428 		goto out;
429 	}
430 
431 	wl1271_debug(DEBUG_CMD, "cmd role start dev %d", wlvif->dev_role_id);
432 
433 	cmd->role_id = wlvif->dev_role_id;
434 	if (band == IEEE80211_BAND_5GHZ)
435 		cmd->band = WLCORE_BAND_5GHZ;
436 	cmd->channel = channel;
437 
438 	if (wlvif->dev_hlid == WL12XX_INVALID_LINK_ID) {
439 		ret = wl12xx_allocate_link(wl, wlvif, &wlvif->dev_hlid);
440 		if (ret)
441 			goto out_free;
442 	}
443 	cmd->device.hlid = wlvif->dev_hlid;
444 	cmd->device.session = wl->session_ids[wlvif->dev_hlid];
445 
446 	wl1271_debug(DEBUG_CMD, "role start: roleid=%d, hlid=%d, session=%d",
447 		     cmd->role_id, cmd->device.hlid, cmd->device.session);
448 
449 	ret = wl1271_cmd_send(wl, CMD_ROLE_START, cmd, sizeof(*cmd), 0);
450 	if (ret < 0) {
451 		wl1271_error("failed to initiate cmd role enable");
452 		goto err_hlid;
453 	}
454 
455 	goto out_free;
456 
457 err_hlid:
458 	/* clear links on error */
459 	wl12xx_free_link(wl, wlvif, &wlvif->dev_hlid);
460 
461 out_free:
462 	kfree(cmd);
463 
464 out:
465 	return ret;
466 }
467 
468 static int wl12xx_cmd_role_stop_dev(struct wl1271 *wl,
469 				    struct wl12xx_vif *wlvif)
470 {
471 	struct wl12xx_cmd_role_stop *cmd;
472 	int ret;
473 
474 	if (WARN_ON(wlvif->dev_hlid == WL12XX_INVALID_LINK_ID))
475 		return -EINVAL;
476 
477 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
478 	if (!cmd) {
479 		ret = -ENOMEM;
480 		goto out;
481 	}
482 
483 	wl1271_debug(DEBUG_CMD, "cmd role stop dev");
484 
485 	cmd->role_id = wlvif->dev_role_id;
486 	cmd->disc_type = DISCONNECT_IMMEDIATE;
487 	cmd->reason = cpu_to_le16(WLAN_REASON_UNSPECIFIED);
488 
489 	ret = wl1271_cmd_send(wl, CMD_ROLE_STOP, cmd, sizeof(*cmd), 0);
490 	if (ret < 0) {
491 		wl1271_error("failed to initiate cmd role stop");
492 		goto out_free;
493 	}
494 
495 	wl12xx_free_link(wl, wlvif, &wlvif->dev_hlid);
496 
497 out_free:
498 	kfree(cmd);
499 
500 out:
501 	return ret;
502 }
503 
504 int wl12xx_cmd_role_start_sta(struct wl1271 *wl, struct wl12xx_vif *wlvif)
505 {
506 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
507 	struct wl12xx_cmd_role_start *cmd;
508 	u32 supported_rates;
509 	int ret;
510 
511 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
512 	if (!cmd) {
513 		ret = -ENOMEM;
514 		goto out;
515 	}
516 
517 	wl1271_debug(DEBUG_CMD, "cmd role start sta %d", wlvif->role_id);
518 
519 	cmd->role_id = wlvif->role_id;
520 	if (wlvif->band == IEEE80211_BAND_5GHZ)
521 		cmd->band = WLCORE_BAND_5GHZ;
522 	cmd->channel = wlvif->channel;
523 	cmd->sta.basic_rate_set = cpu_to_le32(wlvif->basic_rate_set);
524 	cmd->sta.beacon_interval = cpu_to_le16(wlvif->beacon_int);
525 	cmd->sta.ssid_type = WL12XX_SSID_TYPE_ANY;
526 	cmd->sta.ssid_len = wlvif->ssid_len;
527 	memcpy(cmd->sta.ssid, wlvif->ssid, wlvif->ssid_len);
528 	memcpy(cmd->sta.bssid, vif->bss_conf.bssid, ETH_ALEN);
529 
530 	supported_rates = CONF_TX_ENABLED_RATES | CONF_TX_MCS_RATES |
531 			  wlcore_hw_sta_get_ap_rate_mask(wl, wlvif);
532 	if (wlvif->p2p)
533 		supported_rates &= ~CONF_TX_CCK_RATES;
534 
535 	cmd->sta.local_rates = cpu_to_le32(supported_rates);
536 
537 	cmd->channel_type = wlcore_get_native_channel_type(wlvif->channel_type);
538 
539 	if (wlvif->sta.hlid == WL12XX_INVALID_LINK_ID) {
540 		ret = wl12xx_allocate_link(wl, wlvif, &wlvif->sta.hlid);
541 		if (ret)
542 			goto out_free;
543 	}
544 	cmd->sta.hlid = wlvif->sta.hlid;
545 	cmd->sta.session = wl->session_ids[wlvif->sta.hlid];
546 	/*
547 	 * We don't have the correct remote rates in this stage.  The
548 	 * rates will be reconfigured later, after association, if the
549 	 * firmware supports ACX_PEER_CAP.  Otherwise, there's nothing
550 	 * we can do, so use all supported_rates here.
551 	 */
552 	cmd->sta.remote_rates = cpu_to_le32(supported_rates);
553 
554 	wl1271_debug(DEBUG_CMD, "role start: roleid=%d, hlid=%d, session=%d "
555 		     "basic_rate_set: 0x%x, remote_rates: 0x%x",
556 		     wlvif->role_id, cmd->sta.hlid, cmd->sta.session,
557 		     wlvif->basic_rate_set, wlvif->rate_set);
558 
559 	ret = wl1271_cmd_send(wl, CMD_ROLE_START, cmd, sizeof(*cmd), 0);
560 	if (ret < 0) {
561 		wl1271_error("failed to initiate cmd role start sta");
562 		goto err_hlid;
563 	}
564 
565 	wlvif->sta.role_chan_type = wlvif->channel_type;
566 	goto out_free;
567 
568 err_hlid:
569 	/* clear links on error. */
570 	wl12xx_free_link(wl, wlvif, &wlvif->sta.hlid);
571 
572 out_free:
573 	kfree(cmd);
574 
575 out:
576 	return ret;
577 }
578 
579 /* use this function to stop ibss as well */
580 int wl12xx_cmd_role_stop_sta(struct wl1271 *wl, struct wl12xx_vif *wlvif)
581 {
582 	struct wl12xx_cmd_role_stop *cmd;
583 	int ret;
584 
585 	if (WARN_ON(wlvif->sta.hlid == WL12XX_INVALID_LINK_ID))
586 		return -EINVAL;
587 
588 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
589 	if (!cmd) {
590 		ret = -ENOMEM;
591 		goto out;
592 	}
593 
594 	wl1271_debug(DEBUG_CMD, "cmd role stop sta %d", wlvif->role_id);
595 
596 	cmd->role_id = wlvif->role_id;
597 	cmd->disc_type = DISCONNECT_IMMEDIATE;
598 	cmd->reason = cpu_to_le16(WLAN_REASON_UNSPECIFIED);
599 
600 	ret = wl1271_cmd_send(wl, CMD_ROLE_STOP, cmd, sizeof(*cmd), 0);
601 	if (ret < 0) {
602 		wl1271_error("failed to initiate cmd role stop sta");
603 		goto out_free;
604 	}
605 
606 	wl12xx_free_link(wl, wlvif, &wlvif->sta.hlid);
607 
608 out_free:
609 	kfree(cmd);
610 
611 out:
612 	return ret;
613 }
614 
615 int wl12xx_cmd_role_start_ap(struct wl1271 *wl, struct wl12xx_vif *wlvif)
616 {
617 	struct wl12xx_cmd_role_start *cmd;
618 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
619 	struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
620 	u32 supported_rates;
621 	int ret;
622 
623 	wl1271_debug(DEBUG_CMD, "cmd role start ap %d", wlvif->role_id);
624 
625 	/* trying to use hidden SSID with an old hostapd version */
626 	if (wlvif->ssid_len == 0 && !bss_conf->hidden_ssid) {
627 		wl1271_error("got a null SSID from beacon/bss");
628 		ret = -EINVAL;
629 		goto out;
630 	}
631 
632 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
633 	if (!cmd) {
634 		ret = -ENOMEM;
635 		goto out;
636 	}
637 
638 	ret = wl12xx_allocate_link(wl, wlvif, &wlvif->ap.global_hlid);
639 	if (ret < 0)
640 		goto out_free;
641 
642 	ret = wl12xx_allocate_link(wl, wlvif, &wlvif->ap.bcast_hlid);
643 	if (ret < 0)
644 		goto out_free_global;
645 
646 	/* use the previous security seq, if this is a recovery/resume */
647 	wl->links[wlvif->ap.bcast_hlid].total_freed_pkts =
648 						wlvif->total_freed_pkts;
649 
650 	cmd->role_id = wlvif->role_id;
651 	cmd->ap.aging_period = cpu_to_le16(wl->conf.tx.ap_aging_period);
652 	cmd->ap.bss_index = WL1271_AP_BSS_INDEX;
653 	cmd->ap.global_hlid = wlvif->ap.global_hlid;
654 	cmd->ap.broadcast_hlid = wlvif->ap.bcast_hlid;
655 	cmd->ap.global_session_id = wl->session_ids[wlvif->ap.global_hlid];
656 	cmd->ap.bcast_session_id = wl->session_ids[wlvif->ap.bcast_hlid];
657 	cmd->ap.basic_rate_set = cpu_to_le32(wlvif->basic_rate_set);
658 	cmd->ap.beacon_interval = cpu_to_le16(wlvif->beacon_int);
659 	cmd->ap.dtim_interval = bss_conf->dtim_period;
660 	cmd->ap.beacon_expiry = WL1271_AP_DEF_BEACON_EXP;
661 	/* FIXME: Change when adding DFS */
662 	cmd->ap.reset_tsf = 1;  /* By default reset AP TSF */
663 	cmd->ap.wmm = wlvif->wmm_enabled;
664 	cmd->channel = wlvif->channel;
665 	cmd->channel_type = wlcore_get_native_channel_type(wlvif->channel_type);
666 
667 	if (!bss_conf->hidden_ssid) {
668 		/* take the SSID from the beacon for backward compatibility */
669 		cmd->ap.ssid_type = WL12XX_SSID_TYPE_PUBLIC;
670 		cmd->ap.ssid_len = wlvif->ssid_len;
671 		memcpy(cmd->ap.ssid, wlvif->ssid, wlvif->ssid_len);
672 	} else {
673 		cmd->ap.ssid_type = WL12XX_SSID_TYPE_HIDDEN;
674 		cmd->ap.ssid_len = bss_conf->ssid_len;
675 		memcpy(cmd->ap.ssid, bss_conf->ssid, bss_conf->ssid_len);
676 	}
677 
678 	supported_rates = CONF_TX_ENABLED_RATES | CONF_TX_MCS_RATES |
679 		wlcore_hw_ap_get_mimo_wide_rate_mask(wl, wlvif);
680 	if (wlvif->p2p)
681 		supported_rates &= ~CONF_TX_CCK_RATES;
682 
683 	wl1271_debug(DEBUG_CMD, "cmd role start ap with supported_rates 0x%08x",
684 		     supported_rates);
685 
686 	cmd->ap.local_rates = cpu_to_le32(supported_rates);
687 
688 	switch (wlvif->band) {
689 	case IEEE80211_BAND_2GHZ:
690 		cmd->band = WLCORE_BAND_2_4GHZ;
691 		break;
692 	case IEEE80211_BAND_5GHZ:
693 		cmd->band = WLCORE_BAND_5GHZ;
694 		break;
695 	default:
696 		wl1271_warning("ap start - unknown band: %d", (int)wlvif->band);
697 		cmd->band = WLCORE_BAND_2_4GHZ;
698 		break;
699 	}
700 
701 	ret = wl1271_cmd_send(wl, CMD_ROLE_START, cmd, sizeof(*cmd), 0);
702 	if (ret < 0) {
703 		wl1271_error("failed to initiate cmd role start ap");
704 		goto out_free_bcast;
705 	}
706 
707 	goto out_free;
708 
709 out_free_bcast:
710 	wl12xx_free_link(wl, wlvif, &wlvif->ap.bcast_hlid);
711 
712 out_free_global:
713 	wl12xx_free_link(wl, wlvif, &wlvif->ap.global_hlid);
714 
715 out_free:
716 	kfree(cmd);
717 
718 out:
719 	return ret;
720 }
721 
722 int wl12xx_cmd_role_stop_ap(struct wl1271 *wl, struct wl12xx_vif *wlvif)
723 {
724 	struct wl12xx_cmd_role_stop *cmd;
725 	int ret;
726 
727 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
728 	if (!cmd) {
729 		ret = -ENOMEM;
730 		goto out;
731 	}
732 
733 	wl1271_debug(DEBUG_CMD, "cmd role stop ap %d", wlvif->role_id);
734 
735 	cmd->role_id = wlvif->role_id;
736 
737 	ret = wl1271_cmd_send(wl, CMD_ROLE_STOP, cmd, sizeof(*cmd), 0);
738 	if (ret < 0) {
739 		wl1271_error("failed to initiate cmd role stop ap");
740 		goto out_free;
741 	}
742 
743 	wl12xx_free_link(wl, wlvif, &wlvif->ap.bcast_hlid);
744 	wl12xx_free_link(wl, wlvif, &wlvif->ap.global_hlid);
745 
746 out_free:
747 	kfree(cmd);
748 
749 out:
750 	return ret;
751 }
752 
753 int wl12xx_cmd_role_start_ibss(struct wl1271 *wl, struct wl12xx_vif *wlvif)
754 {
755 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
756 	struct wl12xx_cmd_role_start *cmd;
757 	struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
758 	int ret;
759 
760 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
761 	if (!cmd) {
762 		ret = -ENOMEM;
763 		goto out;
764 	}
765 
766 	wl1271_debug(DEBUG_CMD, "cmd role start ibss %d", wlvif->role_id);
767 
768 	cmd->role_id = wlvif->role_id;
769 	if (wlvif->band == IEEE80211_BAND_5GHZ)
770 		cmd->band = WLCORE_BAND_5GHZ;
771 	cmd->channel = wlvif->channel;
772 	cmd->ibss.basic_rate_set = cpu_to_le32(wlvif->basic_rate_set);
773 	cmd->ibss.beacon_interval = cpu_to_le16(wlvif->beacon_int);
774 	cmd->ibss.dtim_interval = bss_conf->dtim_period;
775 	cmd->ibss.ssid_type = WL12XX_SSID_TYPE_ANY;
776 	cmd->ibss.ssid_len = wlvif->ssid_len;
777 	memcpy(cmd->ibss.ssid, wlvif->ssid, wlvif->ssid_len);
778 	memcpy(cmd->ibss.bssid, vif->bss_conf.bssid, ETH_ALEN);
779 	cmd->sta.local_rates = cpu_to_le32(wlvif->rate_set);
780 
781 	if (wlvif->sta.hlid == WL12XX_INVALID_LINK_ID) {
782 		ret = wl12xx_allocate_link(wl, wlvif, &wlvif->sta.hlid);
783 		if (ret)
784 			goto out_free;
785 	}
786 	cmd->ibss.hlid = wlvif->sta.hlid;
787 	cmd->ibss.remote_rates = cpu_to_le32(wlvif->rate_set);
788 
789 	wl1271_debug(DEBUG_CMD, "role start: roleid=%d, hlid=%d, session=%d "
790 		     "basic_rate_set: 0x%x, remote_rates: 0x%x",
791 		     wlvif->role_id, cmd->sta.hlid, cmd->sta.session,
792 		     wlvif->basic_rate_set, wlvif->rate_set);
793 
794 	wl1271_debug(DEBUG_CMD, "vif->bss_conf.bssid = %pM",
795 		     vif->bss_conf.bssid);
796 
797 	ret = wl1271_cmd_send(wl, CMD_ROLE_START, cmd, sizeof(*cmd), 0);
798 	if (ret < 0) {
799 		wl1271_error("failed to initiate cmd role enable");
800 		goto err_hlid;
801 	}
802 
803 	goto out_free;
804 
805 err_hlid:
806 	/* clear links on error. */
807 	wl12xx_free_link(wl, wlvif, &wlvif->sta.hlid);
808 
809 out_free:
810 	kfree(cmd);
811 
812 out:
813 	return ret;
814 }
815 
816 
817 /**
818  * send test command to firmware
819  *
820  * @wl: wl struct
821  * @buf: buffer containing the command, with all headers, must work with dma
822  * @len: length of the buffer
823  * @answer: is answer needed
824  */
825 int wl1271_cmd_test(struct wl1271 *wl, void *buf, size_t buf_len, u8 answer)
826 {
827 	int ret;
828 	size_t res_len = 0;
829 
830 	wl1271_debug(DEBUG_CMD, "cmd test");
831 
832 	if (answer)
833 		res_len = buf_len;
834 
835 	ret = wl1271_cmd_send(wl, CMD_TEST, buf, buf_len, res_len);
836 
837 	if (ret < 0) {
838 		wl1271_warning("TEST command failed");
839 		return ret;
840 	}
841 
842 	return ret;
843 }
844 EXPORT_SYMBOL_GPL(wl1271_cmd_test);
845 
846 /**
847  * read acx from firmware
848  *
849  * @wl: wl struct
850  * @id: acx id
851  * @buf: buffer for the response, including all headers, must work with dma
852  * @len: length of buf
853  */
854 int wl1271_cmd_interrogate(struct wl1271 *wl, u16 id, void *buf,
855 			   size_t cmd_len, size_t res_len)
856 {
857 	struct acx_header *acx = buf;
858 	int ret;
859 
860 	wl1271_debug(DEBUG_CMD, "cmd interrogate");
861 
862 	acx->id = cpu_to_le16(id);
863 
864 	/* response payload length, does not include any headers */
865 	acx->len = cpu_to_le16(res_len - sizeof(*acx));
866 
867 	ret = wl1271_cmd_send(wl, CMD_INTERROGATE, acx, cmd_len, res_len);
868 	if (ret < 0)
869 		wl1271_error("INTERROGATE command failed");
870 
871 	return ret;
872 }
873 
874 /**
875  * write acx value to firmware
876  *
877  * @wl: wl struct
878  * @id: acx id
879  * @buf: buffer containing acx, including all headers, must work with dma
880  * @len: length of buf
881  * @valid_rets: bitmap of valid cmd status codes (i.e. return values).
882  * return the cmd status on success.
883  */
884 int wlcore_cmd_configure_failsafe(struct wl1271 *wl, u16 id, void *buf,
885 				  size_t len, unsigned long valid_rets)
886 {
887 	struct acx_header *acx = buf;
888 	int ret;
889 
890 	wl1271_debug(DEBUG_CMD, "cmd configure (%d)", id);
891 
892 	acx->id = cpu_to_le16(id);
893 
894 	/* payload length, does not include any headers */
895 	acx->len = cpu_to_le16(len - sizeof(*acx));
896 
897 	ret = wlcore_cmd_send_failsafe(wl, CMD_CONFIGURE, acx, len, 0,
898 				       valid_rets);
899 	if (ret < 0) {
900 		wl1271_warning("CONFIGURE command NOK");
901 		return ret;
902 	}
903 
904 	return ret;
905 }
906 
907 /*
908  * wrapper for wlcore_cmd_configure that accepts only success status.
909  * return 0 on success
910  */
911 int wl1271_cmd_configure(struct wl1271 *wl, u16 id, void *buf, size_t len)
912 {
913 	int ret = wlcore_cmd_configure_failsafe(wl, id, buf, len, 0);
914 
915 	if (ret < 0)
916 		return ret;
917 	return 0;
918 }
919 EXPORT_SYMBOL_GPL(wl1271_cmd_configure);
920 
921 int wl1271_cmd_data_path(struct wl1271 *wl, bool enable)
922 {
923 	struct cmd_enabledisable_path *cmd;
924 	int ret;
925 	u16 cmd_rx, cmd_tx;
926 
927 	wl1271_debug(DEBUG_CMD, "cmd data path");
928 
929 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
930 	if (!cmd) {
931 		ret = -ENOMEM;
932 		goto out;
933 	}
934 
935 	/* the channel here is only used for calibration, so hardcoded to 1 */
936 	cmd->channel = 1;
937 
938 	if (enable) {
939 		cmd_rx = CMD_ENABLE_RX;
940 		cmd_tx = CMD_ENABLE_TX;
941 	} else {
942 		cmd_rx = CMD_DISABLE_RX;
943 		cmd_tx = CMD_DISABLE_TX;
944 	}
945 
946 	ret = wl1271_cmd_send(wl, cmd_rx, cmd, sizeof(*cmd), 0);
947 	if (ret < 0) {
948 		wl1271_error("rx %s cmd for channel %d failed",
949 			     enable ? "start" : "stop", cmd->channel);
950 		goto out;
951 	}
952 
953 	wl1271_debug(DEBUG_BOOT, "rx %s cmd channel %d",
954 		     enable ? "start" : "stop", cmd->channel);
955 
956 	ret = wl1271_cmd_send(wl, cmd_tx, cmd, sizeof(*cmd), 0);
957 	if (ret < 0) {
958 		wl1271_error("tx %s cmd for channel %d failed",
959 			     enable ? "start" : "stop", cmd->channel);
960 		goto out;
961 	}
962 
963 	wl1271_debug(DEBUG_BOOT, "tx %s cmd channel %d",
964 		     enable ? "start" : "stop", cmd->channel);
965 
966 out:
967 	kfree(cmd);
968 	return ret;
969 }
970 EXPORT_SYMBOL_GPL(wl1271_cmd_data_path);
971 
972 int wl1271_cmd_ps_mode(struct wl1271 *wl, struct wl12xx_vif *wlvif,
973 		       u8 ps_mode, u16 auto_ps_timeout)
974 {
975 	struct wl1271_cmd_ps_params *ps_params = NULL;
976 	int ret = 0;
977 
978 	wl1271_debug(DEBUG_CMD, "cmd set ps mode");
979 
980 	ps_params = kzalloc(sizeof(*ps_params), GFP_KERNEL);
981 	if (!ps_params) {
982 		ret = -ENOMEM;
983 		goto out;
984 	}
985 
986 	ps_params->role_id = wlvif->role_id;
987 	ps_params->ps_mode = ps_mode;
988 	ps_params->auto_ps_timeout = auto_ps_timeout;
989 
990 	ret = wl1271_cmd_send(wl, CMD_SET_PS_MODE, ps_params,
991 			      sizeof(*ps_params), 0);
992 	if (ret < 0) {
993 		wl1271_error("cmd set_ps_mode failed");
994 		goto out;
995 	}
996 
997 out:
998 	kfree(ps_params);
999 	return ret;
1000 }
1001 
1002 int wl1271_cmd_template_set(struct wl1271 *wl, u8 role_id,
1003 			    u16 template_id, void *buf, size_t buf_len,
1004 			    int index, u32 rates)
1005 {
1006 	struct wl1271_cmd_template_set *cmd;
1007 	int ret = 0;
1008 
1009 	wl1271_debug(DEBUG_CMD, "cmd template_set %d (role %d)",
1010 		     template_id, role_id);
1011 
1012 	WARN_ON(buf_len > WL1271_CMD_TEMPL_MAX_SIZE);
1013 	buf_len = min_t(size_t, buf_len, WL1271_CMD_TEMPL_MAX_SIZE);
1014 
1015 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1016 	if (!cmd) {
1017 		ret = -ENOMEM;
1018 		goto out;
1019 	}
1020 
1021 	/* during initialization wlvif is NULL */
1022 	cmd->role_id = role_id;
1023 	cmd->len = cpu_to_le16(buf_len);
1024 	cmd->template_type = template_id;
1025 	cmd->enabled_rates = cpu_to_le32(rates);
1026 	cmd->short_retry_limit = wl->conf.tx.tmpl_short_retry_limit;
1027 	cmd->long_retry_limit = wl->conf.tx.tmpl_long_retry_limit;
1028 	cmd->index = index;
1029 
1030 	if (buf)
1031 		memcpy(cmd->template_data, buf, buf_len);
1032 
1033 	ret = wl1271_cmd_send(wl, CMD_SET_TEMPLATE, cmd, sizeof(*cmd), 0);
1034 	if (ret < 0) {
1035 		wl1271_warning("cmd set_template failed: %d", ret);
1036 		goto out_free;
1037 	}
1038 
1039 out_free:
1040 	kfree(cmd);
1041 
1042 out:
1043 	return ret;
1044 }
1045 
1046 int wl12xx_cmd_build_null_data(struct wl1271 *wl, struct wl12xx_vif *wlvif)
1047 {
1048 	struct sk_buff *skb = NULL;
1049 	int size;
1050 	void *ptr;
1051 	int ret = -ENOMEM;
1052 
1053 
1054 	if (wlvif->bss_type == BSS_TYPE_IBSS) {
1055 		size = sizeof(struct wl12xx_null_data_template);
1056 		ptr = NULL;
1057 	} else {
1058 		skb = ieee80211_nullfunc_get(wl->hw,
1059 					     wl12xx_wlvif_to_vif(wlvif));
1060 		if (!skb)
1061 			goto out;
1062 		size = skb->len;
1063 		ptr = skb->data;
1064 	}
1065 
1066 	ret = wl1271_cmd_template_set(wl, wlvif->role_id,
1067 				      CMD_TEMPL_NULL_DATA, ptr, size, 0,
1068 				      wlvif->basic_rate);
1069 
1070 out:
1071 	dev_kfree_skb(skb);
1072 	if (ret)
1073 		wl1271_warning("cmd buld null data failed %d", ret);
1074 
1075 	return ret;
1076 
1077 }
1078 
1079 int wl12xx_cmd_build_klv_null_data(struct wl1271 *wl,
1080 				   struct wl12xx_vif *wlvif)
1081 {
1082 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
1083 	struct sk_buff *skb = NULL;
1084 	int ret = -ENOMEM;
1085 
1086 	skb = ieee80211_nullfunc_get(wl->hw, vif);
1087 	if (!skb)
1088 		goto out;
1089 
1090 	ret = wl1271_cmd_template_set(wl, wlvif->role_id, CMD_TEMPL_KLV,
1091 				      skb->data, skb->len,
1092 				      wlvif->sta.klv_template_id,
1093 				      wlvif->basic_rate);
1094 
1095 out:
1096 	dev_kfree_skb(skb);
1097 	if (ret)
1098 		wl1271_warning("cmd build klv null data failed %d", ret);
1099 
1100 	return ret;
1101 
1102 }
1103 
1104 int wl1271_cmd_build_ps_poll(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1105 			     u16 aid)
1106 {
1107 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
1108 	struct sk_buff *skb;
1109 	int ret = 0;
1110 
1111 	skb = ieee80211_pspoll_get(wl->hw, vif);
1112 	if (!skb)
1113 		goto out;
1114 
1115 	ret = wl1271_cmd_template_set(wl, wlvif->role_id,
1116 				      CMD_TEMPL_PS_POLL, skb->data,
1117 				      skb->len, 0, wlvif->basic_rate_set);
1118 
1119 out:
1120 	dev_kfree_skb(skb);
1121 	return ret;
1122 }
1123 
1124 int wl12xx_cmd_build_probe_req(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1125 			       u8 role_id, u8 band,
1126 			       const u8 *ssid, size_t ssid_len,
1127 			       const u8 *ie, size_t ie_len, bool sched_scan)
1128 {
1129 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
1130 	struct sk_buff *skb;
1131 	int ret;
1132 	u32 rate;
1133 	u16 template_id_2_4 = wl->scan_templ_id_2_4;
1134 	u16 template_id_5 = wl->scan_templ_id_5;
1135 
1136 	wl1271_debug(DEBUG_SCAN, "build probe request band %d", band);
1137 
1138 	skb = ieee80211_probereq_get(wl->hw, vif, ssid, ssid_len,
1139 				     ie_len);
1140 	if (!skb) {
1141 		ret = -ENOMEM;
1142 		goto out;
1143 	}
1144 	if (ie_len)
1145 		memcpy(skb_put(skb, ie_len), ie, ie_len);
1146 
1147 	if (sched_scan &&
1148 	    (wl->quirks & WLCORE_QUIRK_DUAL_PROBE_TMPL)) {
1149 		template_id_2_4 = wl->sched_scan_templ_id_2_4;
1150 		template_id_5 = wl->sched_scan_templ_id_5;
1151 	}
1152 
1153 	rate = wl1271_tx_min_rate_get(wl, wlvif->bitrate_masks[band]);
1154 	if (band == IEEE80211_BAND_2GHZ)
1155 		ret = wl1271_cmd_template_set(wl, role_id,
1156 					      template_id_2_4,
1157 					      skb->data, skb->len, 0, rate);
1158 	else
1159 		ret = wl1271_cmd_template_set(wl, role_id,
1160 					      template_id_5,
1161 					      skb->data, skb->len, 0, rate);
1162 
1163 out:
1164 	dev_kfree_skb(skb);
1165 	return ret;
1166 }
1167 EXPORT_SYMBOL_GPL(wl12xx_cmd_build_probe_req);
1168 
1169 struct sk_buff *wl1271_cmd_build_ap_probe_req(struct wl1271 *wl,
1170 					      struct wl12xx_vif *wlvif,
1171 					      struct sk_buff *skb)
1172 {
1173 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
1174 	int ret;
1175 	u32 rate;
1176 
1177 	if (!skb)
1178 		skb = ieee80211_ap_probereq_get(wl->hw, vif);
1179 	if (!skb)
1180 		goto out;
1181 
1182 	wl1271_debug(DEBUG_SCAN, "set ap probe request template");
1183 
1184 	rate = wl1271_tx_min_rate_get(wl, wlvif->bitrate_masks[wlvif->band]);
1185 	if (wlvif->band == IEEE80211_BAND_2GHZ)
1186 		ret = wl1271_cmd_template_set(wl, wlvif->role_id,
1187 					      CMD_TEMPL_CFG_PROBE_REQ_2_4,
1188 					      skb->data, skb->len, 0, rate);
1189 	else
1190 		ret = wl1271_cmd_template_set(wl, wlvif->role_id,
1191 					      CMD_TEMPL_CFG_PROBE_REQ_5,
1192 					      skb->data, skb->len, 0, rate);
1193 
1194 	if (ret < 0)
1195 		wl1271_error("Unable to set ap probe request template.");
1196 
1197 out:
1198 	return skb;
1199 }
1200 
1201 int wl1271_cmd_build_arp_rsp(struct wl1271 *wl, struct wl12xx_vif *wlvif)
1202 {
1203 	int ret, extra = 0;
1204 	u16 fc;
1205 	struct ieee80211_vif *vif = wl12xx_wlvif_to_vif(wlvif);
1206 	struct sk_buff *skb;
1207 	struct wl12xx_arp_rsp_template *tmpl;
1208 	struct ieee80211_hdr_3addr *hdr;
1209 	struct arphdr *arp_hdr;
1210 
1211 	skb = dev_alloc_skb(sizeof(*hdr) + sizeof(__le16) + sizeof(*tmpl) +
1212 			    WL1271_EXTRA_SPACE_MAX);
1213 	if (!skb) {
1214 		wl1271_error("failed to allocate buffer for arp rsp template");
1215 		return -ENOMEM;
1216 	}
1217 
1218 	skb_reserve(skb, sizeof(*hdr) + WL1271_EXTRA_SPACE_MAX);
1219 
1220 	tmpl = (struct wl12xx_arp_rsp_template *)skb_put(skb, sizeof(*tmpl));
1221 	memset(tmpl, 0, sizeof(*tmpl));
1222 
1223 	/* llc layer */
1224 	memcpy(tmpl->llc_hdr, rfc1042_header, sizeof(rfc1042_header));
1225 	tmpl->llc_type = cpu_to_be16(ETH_P_ARP);
1226 
1227 	/* arp header */
1228 	arp_hdr = &tmpl->arp_hdr;
1229 	arp_hdr->ar_hrd = cpu_to_be16(ARPHRD_ETHER);
1230 	arp_hdr->ar_pro = cpu_to_be16(ETH_P_IP);
1231 	arp_hdr->ar_hln = ETH_ALEN;
1232 	arp_hdr->ar_pln = 4;
1233 	arp_hdr->ar_op = cpu_to_be16(ARPOP_REPLY);
1234 
1235 	/* arp payload */
1236 	memcpy(tmpl->sender_hw, vif->addr, ETH_ALEN);
1237 	tmpl->sender_ip = wlvif->ip_addr;
1238 
1239 	/* encryption space */
1240 	switch (wlvif->encryption_type) {
1241 	case KEY_TKIP:
1242 		if (wl->quirks & WLCORE_QUIRK_TKIP_HEADER_SPACE)
1243 			extra = WL1271_EXTRA_SPACE_TKIP;
1244 		break;
1245 	case KEY_AES:
1246 		extra = WL1271_EXTRA_SPACE_AES;
1247 		break;
1248 	case KEY_NONE:
1249 	case KEY_WEP:
1250 	case KEY_GEM:
1251 		extra = 0;
1252 		break;
1253 	default:
1254 		wl1271_warning("Unknown encryption type: %d",
1255 			       wlvif->encryption_type);
1256 		ret = -EINVAL;
1257 		goto out;
1258 	}
1259 
1260 	if (extra) {
1261 		u8 *space = skb_push(skb, extra);
1262 		memset(space, 0, extra);
1263 	}
1264 
1265 	/* QoS header - BE */
1266 	if (wlvif->sta.qos)
1267 		memset(skb_push(skb, sizeof(__le16)), 0, sizeof(__le16));
1268 
1269 	/* mac80211 header */
1270 	hdr = (struct ieee80211_hdr_3addr *)skb_push(skb, sizeof(*hdr));
1271 	memset(hdr, 0, sizeof(*hdr));
1272 	fc = IEEE80211_FTYPE_DATA | IEEE80211_FCTL_TODS;
1273 	if (wlvif->sta.qos)
1274 		fc |= IEEE80211_STYPE_QOS_DATA;
1275 	else
1276 		fc |= IEEE80211_STYPE_DATA;
1277 	if (wlvif->encryption_type != KEY_NONE)
1278 		fc |= IEEE80211_FCTL_PROTECTED;
1279 
1280 	hdr->frame_control = cpu_to_le16(fc);
1281 	memcpy(hdr->addr1, vif->bss_conf.bssid, ETH_ALEN);
1282 	memcpy(hdr->addr2, vif->addr, ETH_ALEN);
1283 	memset(hdr->addr3, 0xff, ETH_ALEN);
1284 
1285 	ret = wl1271_cmd_template_set(wl, wlvif->role_id, CMD_TEMPL_ARP_RSP,
1286 				      skb->data, skb->len, 0,
1287 				      wlvif->basic_rate);
1288 out:
1289 	dev_kfree_skb(skb);
1290 	return ret;
1291 }
1292 
1293 int wl1271_build_qos_null_data(struct wl1271 *wl, struct ieee80211_vif *vif)
1294 {
1295 	struct wl12xx_vif *wlvif = wl12xx_vif_to_data(vif);
1296 	struct ieee80211_qos_hdr template;
1297 
1298 	memset(&template, 0, sizeof(template));
1299 
1300 	memcpy(template.addr1, vif->bss_conf.bssid, ETH_ALEN);
1301 	memcpy(template.addr2, vif->addr, ETH_ALEN);
1302 	memcpy(template.addr3, vif->bss_conf.bssid, ETH_ALEN);
1303 
1304 	template.frame_control = cpu_to_le16(IEEE80211_FTYPE_DATA |
1305 					     IEEE80211_STYPE_QOS_NULLFUNC |
1306 					     IEEE80211_FCTL_TODS);
1307 
1308 	/* FIXME: not sure what priority to use here */
1309 	template.qos_ctrl = cpu_to_le16(0);
1310 
1311 	return wl1271_cmd_template_set(wl, wlvif->role_id,
1312 				       CMD_TEMPL_QOS_NULL_DATA, &template,
1313 				       sizeof(template), 0,
1314 				       wlvif->basic_rate);
1315 }
1316 
1317 int wl12xx_cmd_set_default_wep_key(struct wl1271 *wl, u8 id, u8 hlid)
1318 {
1319 	struct wl1271_cmd_set_keys *cmd;
1320 	int ret = 0;
1321 
1322 	wl1271_debug(DEBUG_CMD, "cmd set_default_wep_key %d", id);
1323 
1324 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1325 	if (!cmd) {
1326 		ret = -ENOMEM;
1327 		goto out;
1328 	}
1329 
1330 	cmd->hlid = hlid;
1331 	cmd->key_id = id;
1332 	cmd->lid_key_type = WEP_DEFAULT_LID_TYPE;
1333 	cmd->key_action = cpu_to_le16(KEY_SET_ID);
1334 	cmd->key_type = KEY_WEP;
1335 
1336 	ret = wl1271_cmd_send(wl, CMD_SET_KEYS, cmd, sizeof(*cmd), 0);
1337 	if (ret < 0) {
1338 		wl1271_warning("cmd set_default_wep_key failed: %d", ret);
1339 		goto out;
1340 	}
1341 
1342 out:
1343 	kfree(cmd);
1344 
1345 	return ret;
1346 }
1347 
1348 int wl1271_cmd_set_sta_key(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1349 		       u16 action, u8 id, u8 key_type,
1350 		       u8 key_size, const u8 *key, const u8 *addr,
1351 		       u32 tx_seq_32, u16 tx_seq_16)
1352 {
1353 	struct wl1271_cmd_set_keys *cmd;
1354 	int ret = 0;
1355 
1356 	/* hlid might have already been deleted */
1357 	if (wlvif->sta.hlid == WL12XX_INVALID_LINK_ID)
1358 		return 0;
1359 
1360 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1361 	if (!cmd) {
1362 		ret = -ENOMEM;
1363 		goto out;
1364 	}
1365 
1366 	cmd->hlid = wlvif->sta.hlid;
1367 
1368 	if (key_type == KEY_WEP)
1369 		cmd->lid_key_type = WEP_DEFAULT_LID_TYPE;
1370 	else if (is_broadcast_ether_addr(addr))
1371 		cmd->lid_key_type = BROADCAST_LID_TYPE;
1372 	else
1373 		cmd->lid_key_type = UNICAST_LID_TYPE;
1374 
1375 	cmd->key_action = cpu_to_le16(action);
1376 	cmd->key_size = key_size;
1377 	cmd->key_type = key_type;
1378 
1379 	cmd->ac_seq_num16[0] = cpu_to_le16(tx_seq_16);
1380 	cmd->ac_seq_num32[0] = cpu_to_le32(tx_seq_32);
1381 
1382 	cmd->key_id = id;
1383 
1384 	if (key_type == KEY_TKIP) {
1385 		/*
1386 		 * We get the key in the following form:
1387 		 * TKIP (16 bytes) - TX MIC (8 bytes) - RX MIC (8 bytes)
1388 		 * but the target is expecting:
1389 		 * TKIP - RX MIC - TX MIC
1390 		 */
1391 		memcpy(cmd->key, key, 16);
1392 		memcpy(cmd->key + 16, key + 24, 8);
1393 		memcpy(cmd->key + 24, key + 16, 8);
1394 
1395 	} else {
1396 		memcpy(cmd->key, key, key_size);
1397 	}
1398 
1399 	wl1271_dump(DEBUG_CRYPT, "TARGET KEY: ", cmd, sizeof(*cmd));
1400 
1401 	ret = wl1271_cmd_send(wl, CMD_SET_KEYS, cmd, sizeof(*cmd), 0);
1402 	if (ret < 0) {
1403 		wl1271_warning("could not set keys");
1404 	goto out;
1405 	}
1406 
1407 out:
1408 	kfree(cmd);
1409 
1410 	return ret;
1411 }
1412 
1413 /*
1414  * TODO: merge with sta/ibss into 1 set_key function.
1415  * note there are slight diffs
1416  */
1417 int wl1271_cmd_set_ap_key(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1418 			  u16 action, u8 id, u8 key_type,
1419 			  u8 key_size, const u8 *key, u8 hlid, u32 tx_seq_32,
1420 			  u16 tx_seq_16)
1421 {
1422 	struct wl1271_cmd_set_keys *cmd;
1423 	int ret = 0;
1424 	u8 lid_type;
1425 
1426 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1427 	if (!cmd)
1428 		return -ENOMEM;
1429 
1430 	if (hlid == wlvif->ap.bcast_hlid) {
1431 		if (key_type == KEY_WEP)
1432 			lid_type = WEP_DEFAULT_LID_TYPE;
1433 		else
1434 			lid_type = BROADCAST_LID_TYPE;
1435 	} else {
1436 		lid_type = UNICAST_LID_TYPE;
1437 	}
1438 
1439 	wl1271_debug(DEBUG_CRYPT, "ap key action: %d id: %d lid: %d type: %d"
1440 		     " hlid: %d", (int)action, (int)id, (int)lid_type,
1441 		     (int)key_type, (int)hlid);
1442 
1443 	cmd->lid_key_type = lid_type;
1444 	cmd->hlid = hlid;
1445 	cmd->key_action = cpu_to_le16(action);
1446 	cmd->key_size = key_size;
1447 	cmd->key_type = key_type;
1448 	cmd->key_id = id;
1449 	cmd->ac_seq_num16[0] = cpu_to_le16(tx_seq_16);
1450 	cmd->ac_seq_num32[0] = cpu_to_le32(tx_seq_32);
1451 
1452 	if (key_type == KEY_TKIP) {
1453 		/*
1454 		 * We get the key in the following form:
1455 		 * TKIP (16 bytes) - TX MIC (8 bytes) - RX MIC (8 bytes)
1456 		 * but the target is expecting:
1457 		 * TKIP - RX MIC - TX MIC
1458 		 */
1459 		memcpy(cmd->key, key, 16);
1460 		memcpy(cmd->key + 16, key + 24, 8);
1461 		memcpy(cmd->key + 24, key + 16, 8);
1462 	} else {
1463 		memcpy(cmd->key, key, key_size);
1464 	}
1465 
1466 	wl1271_dump(DEBUG_CRYPT, "TARGET AP KEY: ", cmd, sizeof(*cmd));
1467 
1468 	ret = wl1271_cmd_send(wl, CMD_SET_KEYS, cmd, sizeof(*cmd), 0);
1469 	if (ret < 0) {
1470 		wl1271_warning("could not set ap keys");
1471 		goto out;
1472 	}
1473 
1474 out:
1475 	kfree(cmd);
1476 	return ret;
1477 }
1478 
1479 int wl12xx_cmd_set_peer_state(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1480 			      u8 hlid)
1481 {
1482 	struct wl12xx_cmd_set_peer_state *cmd;
1483 	int ret = 0;
1484 
1485 	wl1271_debug(DEBUG_CMD, "cmd set peer state (hlid=%d)", hlid);
1486 
1487 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1488 	if (!cmd) {
1489 		ret = -ENOMEM;
1490 		goto out;
1491 	}
1492 
1493 	cmd->hlid = hlid;
1494 	cmd->state = WL1271_CMD_STA_STATE_CONNECTED;
1495 
1496 	/* wmm param is valid only for station role */
1497 	if (wlvif->bss_type == BSS_TYPE_STA_BSS)
1498 		cmd->wmm = wlvif->wmm_enabled;
1499 
1500 	ret = wl1271_cmd_send(wl, CMD_SET_PEER_STATE, cmd, sizeof(*cmd), 0);
1501 	if (ret < 0) {
1502 		wl1271_error("failed to send set peer state command");
1503 		goto out_free;
1504 	}
1505 
1506 out_free:
1507 	kfree(cmd);
1508 
1509 out:
1510 	return ret;
1511 }
1512 
1513 int wl12xx_cmd_add_peer(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1514 			struct ieee80211_sta *sta, u8 hlid)
1515 {
1516 	struct wl12xx_cmd_add_peer *cmd;
1517 	int i, ret;
1518 	u32 sta_rates;
1519 
1520 	wl1271_debug(DEBUG_CMD, "cmd add peer %d", (int)hlid);
1521 
1522 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1523 	if (!cmd) {
1524 		ret = -ENOMEM;
1525 		goto out;
1526 	}
1527 
1528 	memcpy(cmd->addr, sta->addr, ETH_ALEN);
1529 	cmd->bss_index = WL1271_AP_BSS_INDEX;
1530 	cmd->aid = sta->aid;
1531 	cmd->hlid = hlid;
1532 	cmd->sp_len = sta->max_sp;
1533 	cmd->wmm = sta->wme ? 1 : 0;
1534 	cmd->session_id = wl->session_ids[hlid];
1535 	cmd->role_id = wlvif->role_id;
1536 
1537 	for (i = 0; i < NUM_ACCESS_CATEGORIES_COPY; i++)
1538 		if (sta->wme && (sta->uapsd_queues & BIT(i)))
1539 			cmd->psd_type[NUM_ACCESS_CATEGORIES_COPY-1-i] =
1540 					WL1271_PSD_UPSD_TRIGGER;
1541 		else
1542 			cmd->psd_type[NUM_ACCESS_CATEGORIES_COPY-1-i] =
1543 					WL1271_PSD_LEGACY;
1544 
1545 
1546 	sta_rates = sta->supp_rates[wlvif->band];
1547 	if (sta->ht_cap.ht_supported)
1548 		sta_rates |=
1549 			(sta->ht_cap.mcs.rx_mask[0] << HW_HT_RATES_OFFSET) |
1550 			(sta->ht_cap.mcs.rx_mask[1] << HW_MIMO_RATES_OFFSET);
1551 
1552 	cmd->supported_rates =
1553 		cpu_to_le32(wl1271_tx_enabled_rates_get(wl, sta_rates,
1554 							wlvif->band));
1555 
1556 	wl1271_debug(DEBUG_CMD, "new peer rates=0x%x queues=0x%x",
1557 		     cmd->supported_rates, sta->uapsd_queues);
1558 
1559 	ret = wl1271_cmd_send(wl, CMD_ADD_PEER, cmd, sizeof(*cmd), 0);
1560 	if (ret < 0) {
1561 		wl1271_error("failed to initiate cmd add peer");
1562 		goto out_free;
1563 	}
1564 
1565 out_free:
1566 	kfree(cmd);
1567 
1568 out:
1569 	return ret;
1570 }
1571 
1572 int wl12xx_cmd_remove_peer(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1573 			   u8 hlid)
1574 {
1575 	struct wl12xx_cmd_remove_peer *cmd;
1576 	int ret;
1577 	bool timeout = false;
1578 
1579 	wl1271_debug(DEBUG_CMD, "cmd remove peer %d", (int)hlid);
1580 
1581 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1582 	if (!cmd) {
1583 		ret = -ENOMEM;
1584 		goto out;
1585 	}
1586 
1587 	cmd->hlid = hlid;
1588 	/* We never send a deauth, mac80211 is in charge of this */
1589 	cmd->reason_opcode = 0;
1590 	cmd->send_deauth_flag = 0;
1591 	cmd->role_id = wlvif->role_id;
1592 
1593 	ret = wl1271_cmd_send(wl, CMD_REMOVE_PEER, cmd, sizeof(*cmd), 0);
1594 	if (ret < 0) {
1595 		wl1271_error("failed to initiate cmd remove peer");
1596 		goto out_free;
1597 	}
1598 
1599 	ret = wl->ops->wait_for_event(wl,
1600 				      WLCORE_EVENT_PEER_REMOVE_COMPLETE,
1601 				      &timeout);
1602 
1603 	/*
1604 	 * We are ok with a timeout here. The event is sometimes not sent
1605 	 * due to a firmware bug. In case of another error (like SDIO timeout)
1606 	 * queue a recovery.
1607 	 */
1608 	if (ret)
1609 		wl12xx_queue_recovery_work(wl);
1610 
1611 out_free:
1612 	kfree(cmd);
1613 
1614 out:
1615 	return ret;
1616 }
1617 
1618 static int wlcore_get_reg_conf_ch_idx(enum ieee80211_band band, u16 ch)
1619 {
1620 	/*
1621 	 * map the given band/channel to the respective predefined
1622 	 * bit expected by the fw
1623 	 */
1624 	switch (band) {
1625 	case IEEE80211_BAND_2GHZ:
1626 		/* channels 1..14 are mapped to 0..13 */
1627 		if (ch >= 1 && ch <= 14)
1628 			return ch - 1;
1629 		break;
1630 	case IEEE80211_BAND_5GHZ:
1631 		switch (ch) {
1632 		case 8 ... 16:
1633 			/* channels 8,12,16 are mapped to 18,19,20 */
1634 			return 18 + (ch-8)/4;
1635 		case 34 ... 48:
1636 			/* channels 34,36..48 are mapped to 21..28 */
1637 			return 21 + (ch-34)/2;
1638 		case 52 ... 64:
1639 			/* channels 52,56..64 are mapped to 29..32 */
1640 			return 29 + (ch-52)/4;
1641 		case 100 ... 140:
1642 			/* channels 100,104..140 are mapped to 33..43 */
1643 			return 33 + (ch-100)/4;
1644 		case 149 ... 165:
1645 			/* channels 149,153..165 are mapped to 44..48 */
1646 			return 44 + (ch-149)/4;
1647 		default:
1648 			break;
1649 		}
1650 		break;
1651 	default:
1652 		break;
1653 	}
1654 
1655 	wl1271_error("%s: unknown band/channel: %d/%d", __func__, band, ch);
1656 	return -1;
1657 }
1658 
1659 void wlcore_set_pending_regdomain_ch(struct wl1271 *wl, u16 channel,
1660 				     enum ieee80211_band band)
1661 {
1662 	int ch_bit_idx = 0;
1663 
1664 	if (!(wl->quirks & WLCORE_QUIRK_REGDOMAIN_CONF))
1665 		return;
1666 
1667 	ch_bit_idx = wlcore_get_reg_conf_ch_idx(band, channel);
1668 
1669 	if (ch_bit_idx >= 0 && ch_bit_idx <= WL1271_MAX_CHANNELS)
1670 		set_bit(ch_bit_idx, (long *)wl->reg_ch_conf_pending);
1671 }
1672 
1673 int wlcore_cmd_regdomain_config_locked(struct wl1271 *wl)
1674 {
1675 	struct wl12xx_cmd_regdomain_dfs_config *cmd = NULL;
1676 	int ret = 0, i, b, ch_bit_idx;
1677 	struct ieee80211_channel *channel;
1678 	u32 tmp_ch_bitmap[2];
1679 	u16 ch;
1680 	struct wiphy *wiphy = wl->hw->wiphy;
1681 	struct ieee80211_supported_band *band;
1682 	bool timeout = false;
1683 
1684 	if (!(wl->quirks & WLCORE_QUIRK_REGDOMAIN_CONF))
1685 		return 0;
1686 
1687 	wl1271_debug(DEBUG_CMD, "cmd reg domain config");
1688 
1689 	memset(tmp_ch_bitmap, 0, sizeof(tmp_ch_bitmap));
1690 
1691 	for (b = IEEE80211_BAND_2GHZ; b <= IEEE80211_BAND_5GHZ; b++) {
1692 		band = wiphy->bands[b];
1693 		for (i = 0; i < band->n_channels; i++) {
1694 			channel = &band->channels[i];
1695 			ch = channel->hw_value;
1696 
1697 			if (channel->flags & (IEEE80211_CHAN_DISABLED |
1698 					      IEEE80211_CHAN_RADAR |
1699 					      IEEE80211_CHAN_NO_IR))
1700 				continue;
1701 
1702 			ch_bit_idx = wlcore_get_reg_conf_ch_idx(b, ch);
1703 			if (ch_bit_idx < 0)
1704 				continue;
1705 
1706 			set_bit(ch_bit_idx, (long *)tmp_ch_bitmap);
1707 		}
1708 	}
1709 
1710 	tmp_ch_bitmap[0] |= wl->reg_ch_conf_pending[0];
1711 	tmp_ch_bitmap[1] |= wl->reg_ch_conf_pending[1];
1712 
1713 	if (!memcmp(tmp_ch_bitmap, wl->reg_ch_conf_last, sizeof(tmp_ch_bitmap)))
1714 		goto out;
1715 
1716 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1717 	if (!cmd) {
1718 		ret = -ENOMEM;
1719 		goto out;
1720 	}
1721 
1722 	cmd->ch_bit_map1 = cpu_to_le32(tmp_ch_bitmap[0]);
1723 	cmd->ch_bit_map2 = cpu_to_le32(tmp_ch_bitmap[1]);
1724 
1725 	wl1271_debug(DEBUG_CMD,
1726 		     "cmd reg domain bitmap1: 0x%08x, bitmap2: 0x%08x",
1727 		     cmd->ch_bit_map1, cmd->ch_bit_map2);
1728 
1729 	ret = wl1271_cmd_send(wl, CMD_DFS_CHANNEL_CONFIG, cmd, sizeof(*cmd), 0);
1730 	if (ret < 0) {
1731 		wl1271_error("failed to send reg domain dfs config");
1732 		goto out;
1733 	}
1734 
1735 	ret = wl->ops->wait_for_event(wl,
1736 				      WLCORE_EVENT_DFS_CONFIG_COMPLETE,
1737 				      &timeout);
1738 	if (ret < 0 || timeout) {
1739 		wl1271_error("reg domain conf %serror",
1740 			     timeout ? "completion " : "");
1741 		ret = timeout ? -ETIMEDOUT : ret;
1742 		goto out;
1743 	}
1744 
1745 	memcpy(wl->reg_ch_conf_last, tmp_ch_bitmap, sizeof(tmp_ch_bitmap));
1746 	memset(wl->reg_ch_conf_pending, 0, sizeof(wl->reg_ch_conf_pending));
1747 
1748 out:
1749 	kfree(cmd);
1750 	return ret;
1751 }
1752 
1753 int wl12xx_cmd_config_fwlog(struct wl1271 *wl)
1754 {
1755 	struct wl12xx_cmd_config_fwlog *cmd;
1756 	int ret = 0;
1757 
1758 	wl1271_debug(DEBUG_CMD, "cmd config firmware logger");
1759 
1760 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1761 	if (!cmd) {
1762 		ret = -ENOMEM;
1763 		goto out;
1764 	}
1765 
1766 	cmd->logger_mode = wl->conf.fwlog.mode;
1767 	cmd->log_severity = wl->conf.fwlog.severity;
1768 	cmd->timestamp = wl->conf.fwlog.timestamp;
1769 	cmd->output = wl->conf.fwlog.output;
1770 	cmd->threshold = wl->conf.fwlog.threshold;
1771 
1772 	ret = wl1271_cmd_send(wl, CMD_CONFIG_FWLOGGER, cmd, sizeof(*cmd), 0);
1773 	if (ret < 0) {
1774 		wl1271_error("failed to send config firmware logger command");
1775 		goto out_free;
1776 	}
1777 
1778 out_free:
1779 	kfree(cmd);
1780 
1781 out:
1782 	return ret;
1783 }
1784 
1785 int wl12xx_cmd_start_fwlog(struct wl1271 *wl)
1786 {
1787 	struct wl12xx_cmd_start_fwlog *cmd;
1788 	int ret = 0;
1789 
1790 	wl1271_debug(DEBUG_CMD, "cmd start firmware logger");
1791 
1792 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1793 	if (!cmd) {
1794 		ret = -ENOMEM;
1795 		goto out;
1796 	}
1797 
1798 	ret = wl1271_cmd_send(wl, CMD_START_FWLOGGER, cmd, sizeof(*cmd), 0);
1799 	if (ret < 0) {
1800 		wl1271_error("failed to send start firmware logger command");
1801 		goto out_free;
1802 	}
1803 
1804 out_free:
1805 	kfree(cmd);
1806 
1807 out:
1808 	return ret;
1809 }
1810 
1811 int wl12xx_cmd_stop_fwlog(struct wl1271 *wl)
1812 {
1813 	struct wl12xx_cmd_stop_fwlog *cmd;
1814 	int ret = 0;
1815 
1816 	wl1271_debug(DEBUG_CMD, "cmd stop firmware logger");
1817 
1818 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1819 	if (!cmd) {
1820 		ret = -ENOMEM;
1821 		goto out;
1822 	}
1823 
1824 	ret = wl1271_cmd_send(wl, CMD_STOP_FWLOGGER, cmd, sizeof(*cmd), 0);
1825 	if (ret < 0) {
1826 		wl1271_error("failed to send stop firmware logger command");
1827 		goto out_free;
1828 	}
1829 
1830 out_free:
1831 	kfree(cmd);
1832 
1833 out:
1834 	return ret;
1835 }
1836 
1837 static int wl12xx_cmd_roc(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1838 			  u8 role_id, enum ieee80211_band band, u8 channel)
1839 {
1840 	struct wl12xx_cmd_roc *cmd;
1841 	int ret = 0;
1842 
1843 	wl1271_debug(DEBUG_CMD, "cmd roc %d (%d)", channel, role_id);
1844 
1845 	if (WARN_ON(role_id == WL12XX_INVALID_ROLE_ID))
1846 		return -EINVAL;
1847 
1848 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1849 	if (!cmd) {
1850 		ret = -ENOMEM;
1851 		goto out;
1852 	}
1853 
1854 	cmd->role_id = role_id;
1855 	cmd->channel = channel;
1856 	switch (band) {
1857 	case IEEE80211_BAND_2GHZ:
1858 		cmd->band = WLCORE_BAND_2_4GHZ;
1859 		break;
1860 	case IEEE80211_BAND_5GHZ:
1861 		cmd->band = WLCORE_BAND_5GHZ;
1862 		break;
1863 	default:
1864 		wl1271_error("roc - unknown band: %d", (int)wlvif->band);
1865 		ret = -EINVAL;
1866 		goto out_free;
1867 	}
1868 
1869 
1870 	ret = wl1271_cmd_send(wl, CMD_REMAIN_ON_CHANNEL, cmd, sizeof(*cmd), 0);
1871 	if (ret < 0) {
1872 		wl1271_error("failed to send ROC command");
1873 		goto out_free;
1874 	}
1875 
1876 out_free:
1877 	kfree(cmd);
1878 
1879 out:
1880 	return ret;
1881 }
1882 
1883 static int wl12xx_cmd_croc(struct wl1271 *wl, u8 role_id)
1884 {
1885 	struct wl12xx_cmd_croc *cmd;
1886 	int ret = 0;
1887 
1888 	wl1271_debug(DEBUG_CMD, "cmd croc (%d)", role_id);
1889 
1890 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1891 	if (!cmd) {
1892 		ret = -ENOMEM;
1893 		goto out;
1894 	}
1895 	cmd->role_id = role_id;
1896 
1897 	ret = wl1271_cmd_send(wl, CMD_CANCEL_REMAIN_ON_CHANNEL, cmd,
1898 			      sizeof(*cmd), 0);
1899 	if (ret < 0) {
1900 		wl1271_error("failed to send ROC command");
1901 		goto out_free;
1902 	}
1903 
1904 out_free:
1905 	kfree(cmd);
1906 
1907 out:
1908 	return ret;
1909 }
1910 
1911 int wl12xx_roc(struct wl1271 *wl, struct wl12xx_vif *wlvif, u8 role_id,
1912 	       enum ieee80211_band band, u8 channel)
1913 {
1914 	int ret = 0;
1915 
1916 	if (WARN_ON(test_bit(role_id, wl->roc_map)))
1917 		return 0;
1918 
1919 	ret = wl12xx_cmd_roc(wl, wlvif, role_id, band, channel);
1920 	if (ret < 0)
1921 		goto out;
1922 
1923 	__set_bit(role_id, wl->roc_map);
1924 out:
1925 	return ret;
1926 }
1927 
1928 int wl12xx_croc(struct wl1271 *wl, u8 role_id)
1929 {
1930 	int ret = 0;
1931 
1932 	if (WARN_ON(!test_bit(role_id, wl->roc_map)))
1933 		return 0;
1934 
1935 	ret = wl12xx_cmd_croc(wl, role_id);
1936 	if (ret < 0)
1937 		goto out;
1938 
1939 	__clear_bit(role_id, wl->roc_map);
1940 
1941 	/*
1942 	 * Rearm the tx watchdog when removing the last ROC. This prevents
1943 	 * recoveries due to just finished ROCs - when Tx hasn't yet had
1944 	 * a chance to get out.
1945 	 */
1946 	if (find_first_bit(wl->roc_map, WL12XX_MAX_ROLES) >= WL12XX_MAX_ROLES)
1947 		wl12xx_rearm_tx_watchdog_locked(wl);
1948 out:
1949 	return ret;
1950 }
1951 
1952 int wl12xx_cmd_stop_channel_switch(struct wl1271 *wl, struct wl12xx_vif *wlvif)
1953 {
1954 	struct wl12xx_cmd_stop_channel_switch *cmd;
1955 	int ret;
1956 
1957 	wl1271_debug(DEBUG_ACX, "cmd stop channel switch");
1958 
1959 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
1960 	if (!cmd) {
1961 		ret = -ENOMEM;
1962 		goto out;
1963 	}
1964 
1965 	cmd->role_id = wlvif->role_id;
1966 
1967 	ret = wl1271_cmd_send(wl, CMD_STOP_CHANNEL_SWICTH, cmd, sizeof(*cmd), 0);
1968 	if (ret < 0) {
1969 		wl1271_error("failed to stop channel switch command");
1970 		goto out_free;
1971 	}
1972 
1973 out_free:
1974 	kfree(cmd);
1975 
1976 out:
1977 	return ret;
1978 }
1979 
1980 /* start dev role and roc on its channel */
1981 int wl12xx_start_dev(struct wl1271 *wl, struct wl12xx_vif *wlvif,
1982 		     enum ieee80211_band band, int channel)
1983 {
1984 	int ret;
1985 
1986 	if (WARN_ON(!(wlvif->bss_type == BSS_TYPE_STA_BSS ||
1987 		      wlvif->bss_type == BSS_TYPE_IBSS)))
1988 		return -EINVAL;
1989 
1990 	ret = wl12xx_cmd_role_enable(wl,
1991 				     wl12xx_wlvif_to_vif(wlvif)->addr,
1992 				     WL1271_ROLE_DEVICE,
1993 				     &wlvif->dev_role_id);
1994 	if (ret < 0)
1995 		goto out;
1996 
1997 	ret = wl12xx_cmd_role_start_dev(wl, wlvif, band, channel);
1998 	if (ret < 0)
1999 		goto out_disable;
2000 
2001 	ret = wl12xx_roc(wl, wlvif, wlvif->dev_role_id, band, channel);
2002 	if (ret < 0)
2003 		goto out_stop;
2004 
2005 	return 0;
2006 
2007 out_stop:
2008 	wl12xx_cmd_role_stop_dev(wl, wlvif);
2009 out_disable:
2010 	wl12xx_cmd_role_disable(wl, &wlvif->dev_role_id);
2011 out:
2012 	return ret;
2013 }
2014 
2015 /* croc dev hlid, and stop the role */
2016 int wl12xx_stop_dev(struct wl1271 *wl, struct wl12xx_vif *wlvif)
2017 {
2018 	int ret;
2019 
2020 	if (WARN_ON(!(wlvif->bss_type == BSS_TYPE_STA_BSS ||
2021 		      wlvif->bss_type == BSS_TYPE_IBSS)))
2022 		return -EINVAL;
2023 
2024 	/* flush all pending packets */
2025 	ret = wlcore_tx_work_locked(wl);
2026 	if (ret < 0)
2027 		goto out;
2028 
2029 	if (test_bit(wlvif->dev_role_id, wl->roc_map)) {
2030 		ret = wl12xx_croc(wl, wlvif->dev_role_id);
2031 		if (ret < 0)
2032 			goto out;
2033 	}
2034 
2035 	ret = wl12xx_cmd_role_stop_dev(wl, wlvif);
2036 	if (ret < 0)
2037 		goto out;
2038 
2039 	ret = wl12xx_cmd_role_disable(wl, &wlvif->dev_role_id);
2040 	if (ret < 0)
2041 		goto out;
2042 
2043 out:
2044 	return ret;
2045 }
2046