1d2912cb1SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
25a6681e2SEdward Cree /****************************************************************************
35a6681e2SEdward Cree  * Driver for Solarflare network controllers and boards
45a6681e2SEdward Cree  * Copyright 2006-2011 Solarflare Communications Inc.
55a6681e2SEdward Cree  */
65a6681e2SEdward Cree /*
75a6681e2SEdward Cree  * Useful functions for working with MDIO clause 45 PHYs
85a6681e2SEdward Cree  */
95a6681e2SEdward Cree #include <linux/types.h>
105a6681e2SEdward Cree #include <linux/ethtool.h>
115a6681e2SEdward Cree #include <linux/delay.h>
125a6681e2SEdward Cree #include "net_driver.h"
135a6681e2SEdward Cree #include "mdio_10g.h"
145a6681e2SEdward Cree #include "workarounds.h"
155a6681e2SEdward Cree 
ef4_mdio_id_oui(u32 id)165a6681e2SEdward Cree unsigned ef4_mdio_id_oui(u32 id)
175a6681e2SEdward Cree {
185a6681e2SEdward Cree 	unsigned oui = 0;
195a6681e2SEdward Cree 	int i;
205a6681e2SEdward Cree 
215a6681e2SEdward Cree 	/* The bits of the OUI are designated a..x, with a=0 and b variable.
225a6681e2SEdward Cree 	 * In the id register c is the MSB but the OUI is conventionally
235a6681e2SEdward Cree 	 * written as bytes h..a, p..i, x..q.  Reorder the bits accordingly. */
245a6681e2SEdward Cree 	for (i = 0; i < 22; ++i)
255a6681e2SEdward Cree 		if (id & (1 << (i + 10)))
265a6681e2SEdward Cree 			oui |= 1 << (i ^ 7);
275a6681e2SEdward Cree 
285a6681e2SEdward Cree 	return oui;
295a6681e2SEdward Cree }
305a6681e2SEdward Cree 
ef4_mdio_reset_mmd(struct ef4_nic * port,int mmd,int spins,int spintime)315a6681e2SEdward Cree int ef4_mdio_reset_mmd(struct ef4_nic *port, int mmd,
325a6681e2SEdward Cree 			    int spins, int spintime)
335a6681e2SEdward Cree {
345a6681e2SEdward Cree 	u32 ctrl;
355a6681e2SEdward Cree 
365a6681e2SEdward Cree 	/* Catch callers passing values in the wrong units (or just silly) */
375a6681e2SEdward Cree 	EF4_BUG_ON_PARANOID(spins * spintime >= 5000);
385a6681e2SEdward Cree 
395a6681e2SEdward Cree 	ef4_mdio_write(port, mmd, MDIO_CTRL1, MDIO_CTRL1_RESET);
405a6681e2SEdward Cree 	/* Wait for the reset bit to clear. */
415a6681e2SEdward Cree 	do {
425a6681e2SEdward Cree 		msleep(spintime);
435a6681e2SEdward Cree 		ctrl = ef4_mdio_read(port, mmd, MDIO_CTRL1);
445a6681e2SEdward Cree 		spins--;
455a6681e2SEdward Cree 
465a6681e2SEdward Cree 	} while (spins && (ctrl & MDIO_CTRL1_RESET));
475a6681e2SEdward Cree 
485a6681e2SEdward Cree 	return spins ? spins : -ETIMEDOUT;
495a6681e2SEdward Cree }
505a6681e2SEdward Cree 
ef4_mdio_check_mmd(struct ef4_nic * efx,int mmd)515a6681e2SEdward Cree static int ef4_mdio_check_mmd(struct ef4_nic *efx, int mmd)
525a6681e2SEdward Cree {
535a6681e2SEdward Cree 	int status;
545a6681e2SEdward Cree 
555a6681e2SEdward Cree 	if (mmd != MDIO_MMD_AN) {
565a6681e2SEdward Cree 		/* Read MMD STATUS2 to check it is responding. */
575a6681e2SEdward Cree 		status = ef4_mdio_read(efx, mmd, MDIO_STAT2);
585a6681e2SEdward Cree 		if ((status & MDIO_STAT2_DEVPRST) != MDIO_STAT2_DEVPRST_VAL) {
595a6681e2SEdward Cree 			netif_err(efx, hw, efx->net_dev,
605a6681e2SEdward Cree 				  "PHY MMD %d not responding.\n", mmd);
615a6681e2SEdward Cree 			return -EIO;
625a6681e2SEdward Cree 		}
635a6681e2SEdward Cree 	}
645a6681e2SEdward Cree 
655a6681e2SEdward Cree 	return 0;
665a6681e2SEdward Cree }
675a6681e2SEdward Cree 
685a6681e2SEdward Cree /* This ought to be ridiculous overkill. We expect it to fail rarely */
695a6681e2SEdward Cree #define MDIO45_RESET_TIME	1000 /* ms */
705a6681e2SEdward Cree #define MDIO45_RESET_ITERS	100
715a6681e2SEdward Cree 
ef4_mdio_wait_reset_mmds(struct ef4_nic * efx,unsigned int mmd_mask)725a6681e2SEdward Cree int ef4_mdio_wait_reset_mmds(struct ef4_nic *efx, unsigned int mmd_mask)
735a6681e2SEdward Cree {
745a6681e2SEdward Cree 	const int spintime = MDIO45_RESET_TIME / MDIO45_RESET_ITERS;
755a6681e2SEdward Cree 	int tries = MDIO45_RESET_ITERS;
765a6681e2SEdward Cree 	int rc = 0;
775a6681e2SEdward Cree 	int in_reset;
785a6681e2SEdward Cree 
795a6681e2SEdward Cree 	while (tries) {
805a6681e2SEdward Cree 		int mask = mmd_mask;
815a6681e2SEdward Cree 		int mmd = 0;
825a6681e2SEdward Cree 		int stat;
835a6681e2SEdward Cree 		in_reset = 0;
845a6681e2SEdward Cree 		while (mask) {
855a6681e2SEdward Cree 			if (mask & 1) {
865a6681e2SEdward Cree 				stat = ef4_mdio_read(efx, mmd, MDIO_CTRL1);
875a6681e2SEdward Cree 				if (stat < 0) {
885a6681e2SEdward Cree 					netif_err(efx, hw, efx->net_dev,
895a6681e2SEdward Cree 						  "failed to read status of"
905a6681e2SEdward Cree 						  " MMD %d\n", mmd);
915a6681e2SEdward Cree 					return -EIO;
925a6681e2SEdward Cree 				}
935a6681e2SEdward Cree 				if (stat & MDIO_CTRL1_RESET)
945a6681e2SEdward Cree 					in_reset |= (1 << mmd);
955a6681e2SEdward Cree 			}
965a6681e2SEdward Cree 			mask = mask >> 1;
975a6681e2SEdward Cree 			mmd++;
985a6681e2SEdward Cree 		}
995a6681e2SEdward Cree 		if (!in_reset)
1005a6681e2SEdward Cree 			break;
1015a6681e2SEdward Cree 		tries--;
1025a6681e2SEdward Cree 		msleep(spintime);
1035a6681e2SEdward Cree 	}
1045a6681e2SEdward Cree 	if (in_reset != 0) {
1055a6681e2SEdward Cree 		netif_err(efx, hw, efx->net_dev,
1065a6681e2SEdward Cree 			  "not all MMDs came out of reset in time."
1075a6681e2SEdward Cree 			  " MMDs still in reset: %x\n", in_reset);
1085a6681e2SEdward Cree 		rc = -ETIMEDOUT;
1095a6681e2SEdward Cree 	}
1105a6681e2SEdward Cree 	return rc;
1115a6681e2SEdward Cree }
1125a6681e2SEdward Cree 
ef4_mdio_check_mmds(struct ef4_nic * efx,unsigned int mmd_mask)1135a6681e2SEdward Cree int ef4_mdio_check_mmds(struct ef4_nic *efx, unsigned int mmd_mask)
1145a6681e2SEdward Cree {
1155a6681e2SEdward Cree 	int mmd = 0, probe_mmd, devs1, devs2;
1165a6681e2SEdward Cree 	u32 devices;
1175a6681e2SEdward Cree 
1185a6681e2SEdward Cree 	/* Historically we have probed the PHYXS to find out what devices are
1195a6681e2SEdward Cree 	 * present,but that doesn't work so well if the PHYXS isn't expected
1205a6681e2SEdward Cree 	 * to exist, if so just find the first item in the list supplied. */
1215a6681e2SEdward Cree 	probe_mmd = (mmd_mask & MDIO_DEVS_PHYXS) ? MDIO_MMD_PHYXS :
1225a6681e2SEdward Cree 	    __ffs(mmd_mask);
1235a6681e2SEdward Cree 
1245a6681e2SEdward Cree 	/* Check all the expected MMDs are present */
1255a6681e2SEdward Cree 	devs1 = ef4_mdio_read(efx, probe_mmd, MDIO_DEVS1);
1265a6681e2SEdward Cree 	devs2 = ef4_mdio_read(efx, probe_mmd, MDIO_DEVS2);
1275a6681e2SEdward Cree 	if (devs1 < 0 || devs2 < 0) {
1285a6681e2SEdward Cree 		netif_err(efx, hw, efx->net_dev,
1295a6681e2SEdward Cree 			  "failed to read devices present\n");
1305a6681e2SEdward Cree 		return -EIO;
1315a6681e2SEdward Cree 	}
1325a6681e2SEdward Cree 	devices = devs1 | (devs2 << 16);
1335a6681e2SEdward Cree 	if ((devices & mmd_mask) != mmd_mask) {
1345a6681e2SEdward Cree 		netif_err(efx, hw, efx->net_dev,
1355a6681e2SEdward Cree 			  "required MMDs not present: got %x, wanted %x\n",
1365a6681e2SEdward Cree 			  devices, mmd_mask);
1375a6681e2SEdward Cree 		return -ENODEV;
1385a6681e2SEdward Cree 	}
1395a6681e2SEdward Cree 	netif_vdbg(efx, hw, efx->net_dev, "Devices present: %x\n", devices);
1405a6681e2SEdward Cree 
1415a6681e2SEdward Cree 	/* Check all required MMDs are responding and happy. */
1425a6681e2SEdward Cree 	while (mmd_mask) {
1435a6681e2SEdward Cree 		if ((mmd_mask & 1) && ef4_mdio_check_mmd(efx, mmd))
1445a6681e2SEdward Cree 			return -EIO;
1455a6681e2SEdward Cree 		mmd_mask = mmd_mask >> 1;
1465a6681e2SEdward Cree 		mmd++;
1475a6681e2SEdward Cree 	}
1485a6681e2SEdward Cree 
1495a6681e2SEdward Cree 	return 0;
1505a6681e2SEdward Cree }
1515a6681e2SEdward Cree 
ef4_mdio_links_ok(struct ef4_nic * efx,unsigned int mmd_mask)1525a6681e2SEdward Cree bool ef4_mdio_links_ok(struct ef4_nic *efx, unsigned int mmd_mask)
1535a6681e2SEdward Cree {
1545a6681e2SEdward Cree 	/* If the port is in loopback, then we should only consider a subset
1555a6681e2SEdward Cree 	 * of mmd's */
1565a6681e2SEdward Cree 	if (LOOPBACK_INTERNAL(efx))
1575a6681e2SEdward Cree 		return true;
1585a6681e2SEdward Cree 	else if (LOOPBACK_MASK(efx) & LOOPBACKS_WS)
1595a6681e2SEdward Cree 		return false;
1605a6681e2SEdward Cree 	else if (ef4_phy_mode_disabled(efx->phy_mode))
1615a6681e2SEdward Cree 		return false;
1625a6681e2SEdward Cree 	else if (efx->loopback_mode == LOOPBACK_PHYXS)
1635a6681e2SEdward Cree 		mmd_mask &= ~(MDIO_DEVS_PHYXS |
1645a6681e2SEdward Cree 			      MDIO_DEVS_PCS |
1655a6681e2SEdward Cree 			      MDIO_DEVS_PMAPMD |
1665a6681e2SEdward Cree 			      MDIO_DEVS_AN);
1675a6681e2SEdward Cree 	else if (efx->loopback_mode == LOOPBACK_PCS)
1685a6681e2SEdward Cree 		mmd_mask &= ~(MDIO_DEVS_PCS |
1695a6681e2SEdward Cree 			      MDIO_DEVS_PMAPMD |
1705a6681e2SEdward Cree 			      MDIO_DEVS_AN);
1715a6681e2SEdward Cree 	else if (efx->loopback_mode == LOOPBACK_PMAPMD)
1725a6681e2SEdward Cree 		mmd_mask &= ~(MDIO_DEVS_PMAPMD |
1735a6681e2SEdward Cree 			      MDIO_DEVS_AN);
1745a6681e2SEdward Cree 
1755a6681e2SEdward Cree 	return mdio45_links_ok(&efx->mdio, mmd_mask);
1765a6681e2SEdward Cree }
1775a6681e2SEdward Cree 
ef4_mdio_transmit_disable(struct ef4_nic * efx)1785a6681e2SEdward Cree void ef4_mdio_transmit_disable(struct ef4_nic *efx)
1795a6681e2SEdward Cree {
1805a6681e2SEdward Cree 	ef4_mdio_set_flag(efx, MDIO_MMD_PMAPMD,
1815a6681e2SEdward Cree 			  MDIO_PMA_TXDIS, MDIO_PMD_TXDIS_GLOBAL,
1825a6681e2SEdward Cree 			  efx->phy_mode & PHY_MODE_TX_DISABLED);
1835a6681e2SEdward Cree }
1845a6681e2SEdward Cree 
ef4_mdio_phy_reconfigure(struct ef4_nic * efx)1855a6681e2SEdward Cree void ef4_mdio_phy_reconfigure(struct ef4_nic *efx)
1865a6681e2SEdward Cree {
1875a6681e2SEdward Cree 	ef4_mdio_set_flag(efx, MDIO_MMD_PMAPMD,
1885a6681e2SEdward Cree 			  MDIO_CTRL1, MDIO_PMA_CTRL1_LOOPBACK,
1895a6681e2SEdward Cree 			  efx->loopback_mode == LOOPBACK_PMAPMD);
1905a6681e2SEdward Cree 	ef4_mdio_set_flag(efx, MDIO_MMD_PCS,
1915a6681e2SEdward Cree 			  MDIO_CTRL1, MDIO_PCS_CTRL1_LOOPBACK,
1925a6681e2SEdward Cree 			  efx->loopback_mode == LOOPBACK_PCS);
1935a6681e2SEdward Cree 	ef4_mdio_set_flag(efx, MDIO_MMD_PHYXS,
1945a6681e2SEdward Cree 			  MDIO_CTRL1, MDIO_PHYXS_CTRL1_LOOPBACK,
1955a6681e2SEdward Cree 			  efx->loopback_mode == LOOPBACK_PHYXS_WS);
1965a6681e2SEdward Cree }
1975a6681e2SEdward Cree 
ef4_mdio_set_mmd_lpower(struct ef4_nic * efx,int lpower,int mmd)1985a6681e2SEdward Cree static void ef4_mdio_set_mmd_lpower(struct ef4_nic *efx,
1995a6681e2SEdward Cree 				    int lpower, int mmd)
2005a6681e2SEdward Cree {
2015a6681e2SEdward Cree 	int stat = ef4_mdio_read(efx, mmd, MDIO_STAT1);
2025a6681e2SEdward Cree 
2035a6681e2SEdward Cree 	netif_vdbg(efx, drv, efx->net_dev, "Setting low power mode for MMD %d to %d\n",
2045a6681e2SEdward Cree 		  mmd, lpower);
2055a6681e2SEdward Cree 
2065a6681e2SEdward Cree 	if (stat & MDIO_STAT1_LPOWERABLE) {
2075a6681e2SEdward Cree 		ef4_mdio_set_flag(efx, mmd, MDIO_CTRL1,
2085a6681e2SEdward Cree 				  MDIO_CTRL1_LPOWER, lpower);
2095a6681e2SEdward Cree 	}
2105a6681e2SEdward Cree }
2115a6681e2SEdward Cree 
ef4_mdio_set_mmds_lpower(struct ef4_nic * efx,int low_power,unsigned int mmd_mask)2125a6681e2SEdward Cree void ef4_mdio_set_mmds_lpower(struct ef4_nic *efx,
2135a6681e2SEdward Cree 			      int low_power, unsigned int mmd_mask)
2145a6681e2SEdward Cree {
2155a6681e2SEdward Cree 	int mmd = 0;
2165a6681e2SEdward Cree 	mmd_mask &= ~MDIO_DEVS_AN;
2175a6681e2SEdward Cree 	while (mmd_mask) {
2185a6681e2SEdward Cree 		if (mmd_mask & 1)
2195a6681e2SEdward Cree 			ef4_mdio_set_mmd_lpower(efx, low_power, mmd);
2205a6681e2SEdward Cree 		mmd_mask = (mmd_mask >> 1);
2215a6681e2SEdward Cree 		mmd++;
2225a6681e2SEdward Cree 	}
2235a6681e2SEdward Cree }
2245a6681e2SEdward Cree 
2255a6681e2SEdward Cree /**
226e938ed15SPhilippe Reynes  * ef4_mdio_set_link_ksettings - Set (some of) the PHY settings over MDIO.
2275a6681e2SEdward Cree  * @efx:		Efx NIC
228e938ed15SPhilippe Reynes  * @cmd:		New settings
2295a6681e2SEdward Cree  */
ef4_mdio_set_link_ksettings(struct ef4_nic * efx,const struct ethtool_link_ksettings * cmd)230e938ed15SPhilippe Reynes int ef4_mdio_set_link_ksettings(struct ef4_nic *efx,
231e938ed15SPhilippe Reynes 				const struct ethtool_link_ksettings *cmd)
2325a6681e2SEdward Cree {
233e938ed15SPhilippe Reynes 	struct ethtool_link_ksettings prev = {
234e938ed15SPhilippe Reynes 		.base.cmd = ETHTOOL_GLINKSETTINGS
235e938ed15SPhilippe Reynes 	};
236e938ed15SPhilippe Reynes 	u32 prev_advertising, advertising;
237e938ed15SPhilippe Reynes 	u32 prev_supported;
2385a6681e2SEdward Cree 
239e938ed15SPhilippe Reynes 	efx->phy_op->get_link_ksettings(efx, &prev);
2405a6681e2SEdward Cree 
241e938ed15SPhilippe Reynes 	ethtool_convert_link_mode_to_legacy_u32(&advertising,
242e938ed15SPhilippe Reynes 						cmd->link_modes.advertising);
243e938ed15SPhilippe Reynes 	ethtool_convert_link_mode_to_legacy_u32(&prev_advertising,
244e938ed15SPhilippe Reynes 						prev.link_modes.advertising);
245e938ed15SPhilippe Reynes 	ethtool_convert_link_mode_to_legacy_u32(&prev_supported,
246e938ed15SPhilippe Reynes 						prev.link_modes.supported);
247e938ed15SPhilippe Reynes 
248e938ed15SPhilippe Reynes 	if (advertising == prev_advertising &&
249e938ed15SPhilippe Reynes 	    cmd->base.speed == prev.base.speed &&
250e938ed15SPhilippe Reynes 	    cmd->base.duplex == prev.base.duplex &&
251e938ed15SPhilippe Reynes 	    cmd->base.port == prev.base.port &&
252e938ed15SPhilippe Reynes 	    cmd->base.autoneg == prev.base.autoneg)
2535a6681e2SEdward Cree 		return 0;
2545a6681e2SEdward Cree 
2555a6681e2SEdward Cree 	/* We can only change these settings for -T PHYs */
256e938ed15SPhilippe Reynes 	if (prev.base.port != PORT_TP || cmd->base.port != PORT_TP)
2575a6681e2SEdward Cree 		return -EINVAL;
2585a6681e2SEdward Cree 
2595a6681e2SEdward Cree 	/* Check that PHY supports these settings */
260e938ed15SPhilippe Reynes 	if (!cmd->base.autoneg ||
261e938ed15SPhilippe Reynes 	    (advertising | SUPPORTED_Autoneg) & ~prev_supported)
2625a6681e2SEdward Cree 		return -EINVAL;
2635a6681e2SEdward Cree 
264e938ed15SPhilippe Reynes 	ef4_link_set_advertising(efx, advertising | ADVERTISED_Autoneg);
2655a6681e2SEdward Cree 	ef4_mdio_an_reconfigure(efx);
2665a6681e2SEdward Cree 	return 0;
2675a6681e2SEdward Cree }
2685a6681e2SEdward Cree 
2695a6681e2SEdward Cree /**
2705a6681e2SEdward Cree  * ef4_mdio_an_reconfigure - Push advertising flags and restart autonegotiation
2715a6681e2SEdward Cree  * @efx:		Efx NIC
2725a6681e2SEdward Cree  */
ef4_mdio_an_reconfigure(struct ef4_nic * efx)2735a6681e2SEdward Cree void ef4_mdio_an_reconfigure(struct ef4_nic *efx)
2745a6681e2SEdward Cree {
2755a6681e2SEdward Cree 	int reg;
2765a6681e2SEdward Cree 
2775a6681e2SEdward Cree 	WARN_ON(!(efx->mdio.mmds & MDIO_DEVS_AN));
2785a6681e2SEdward Cree 
2795a6681e2SEdward Cree 	/* Set up the base page */
2805a6681e2SEdward Cree 	reg = ADVERTISE_CSMA | ADVERTISE_RESV;
2815a6681e2SEdward Cree 	if (efx->link_advertising & ADVERTISED_Pause)
2825a6681e2SEdward Cree 		reg |= ADVERTISE_PAUSE_CAP;
2835a6681e2SEdward Cree 	if (efx->link_advertising & ADVERTISED_Asym_Pause)
2845a6681e2SEdward Cree 		reg |= ADVERTISE_PAUSE_ASYM;
2855a6681e2SEdward Cree 	ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_AN_ADVERTISE, reg);
2865a6681e2SEdward Cree 
2875a6681e2SEdward Cree 	/* Set up the (extended) next page */
2885a6681e2SEdward Cree 	efx->phy_op->set_npage_adv(efx, efx->link_advertising);
2895a6681e2SEdward Cree 
2905a6681e2SEdward Cree 	/* Enable and restart AN */
2915a6681e2SEdward Cree 	reg = ef4_mdio_read(efx, MDIO_MMD_AN, MDIO_CTRL1);
2925a6681e2SEdward Cree 	reg |= MDIO_AN_CTRL1_ENABLE | MDIO_AN_CTRL1_RESTART | MDIO_AN_CTRL1_XNP;
2935a6681e2SEdward Cree 	ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_CTRL1, reg);
2945a6681e2SEdward Cree }
2955a6681e2SEdward Cree 
ef4_mdio_get_pause(struct ef4_nic * efx)2965a6681e2SEdward Cree u8 ef4_mdio_get_pause(struct ef4_nic *efx)
2975a6681e2SEdward Cree {
2985a6681e2SEdward Cree 	BUILD_BUG_ON(EF4_FC_AUTO & (EF4_FC_RX | EF4_FC_TX));
2995a6681e2SEdward Cree 
3005a6681e2SEdward Cree 	if (!(efx->wanted_fc & EF4_FC_AUTO))
3015a6681e2SEdward Cree 		return efx->wanted_fc;
3025a6681e2SEdward Cree 
3035a6681e2SEdward Cree 	WARN_ON(!(efx->mdio.mmds & MDIO_DEVS_AN));
3045a6681e2SEdward Cree 
3055a6681e2SEdward Cree 	return mii_resolve_flowctrl_fdx(
3065a6681e2SEdward Cree 		mii_advertise_flowctrl(efx->wanted_fc),
3075a6681e2SEdward Cree 		ef4_mdio_read(efx, MDIO_MMD_AN, MDIO_AN_LPA));
3085a6681e2SEdward Cree }
3095a6681e2SEdward Cree 
ef4_mdio_test_alive(struct ef4_nic * efx)3105a6681e2SEdward Cree int ef4_mdio_test_alive(struct ef4_nic *efx)
3115a6681e2SEdward Cree {
3125a6681e2SEdward Cree 	int rc;
3135a6681e2SEdward Cree 	int devad = __ffs(efx->mdio.mmds);
3145a6681e2SEdward Cree 	u16 physid1, physid2;
3155a6681e2SEdward Cree 
3165a6681e2SEdward Cree 	mutex_lock(&efx->mac_lock);
3175a6681e2SEdward Cree 
3185a6681e2SEdward Cree 	physid1 = ef4_mdio_read(efx, devad, MDIO_DEVID1);
3195a6681e2SEdward Cree 	physid2 = ef4_mdio_read(efx, devad, MDIO_DEVID2);
3205a6681e2SEdward Cree 
3215a6681e2SEdward Cree 	if ((physid1 == 0x0000) || (physid1 == 0xffff) ||
3225a6681e2SEdward Cree 	    (physid2 == 0x0000) || (physid2 == 0xffff)) {
3235a6681e2SEdward Cree 		netif_err(efx, hw, efx->net_dev,
3245a6681e2SEdward Cree 			  "no MDIO PHY present with ID %d\n", efx->mdio.prtad);
3255a6681e2SEdward Cree 		rc = -EINVAL;
3265a6681e2SEdward Cree 	} else {
3275a6681e2SEdward Cree 		rc = ef4_mdio_check_mmds(efx, efx->mdio.mmds);
3285a6681e2SEdward Cree 	}
3295a6681e2SEdward Cree 
3305a6681e2SEdward Cree 	mutex_unlock(&efx->mac_lock);
3315a6681e2SEdward Cree 	return rc;
3325a6681e2SEdward Cree }
333