1 // SPDX-License-Identifier: GPL-2.0
2 /* Copyright (C) 2022, Intel Corporation. */
3 
4 #include "ice_vf_lib_private.h"
5 #include "ice.h"
6 #include "ice_lib.h"
7 #include "ice_fltr.h"
8 #include "ice_virtchnl_allowlist.h"
9 
10 /* Public functions which may be accessed by all driver files */
11 
12 /**
13  * ice_get_vf_by_id - Get pointer to VF by ID
14  * @pf: the PF private structure
15  * @vf_id: the VF ID to locate
16  *
17  * Locate and return a pointer to the VF structure associated with a given ID.
18  * Returns NULL if the ID does not have a valid VF structure associated with
19  * it.
20  *
21  * This function takes a reference to the VF, which must be released by
22  * calling ice_put_vf() once the caller is finished accessing the VF structure
23  * returned.
24  */
25 struct ice_vf *ice_get_vf_by_id(struct ice_pf *pf, u16 vf_id)
26 {
27 	struct ice_vf *vf;
28 
29 	rcu_read_lock();
30 	hash_for_each_possible_rcu(pf->vfs.table, vf, entry, vf_id) {
31 		if (vf->vf_id == vf_id) {
32 			struct ice_vf *found;
33 
34 			if (kref_get_unless_zero(&vf->refcnt))
35 				found = vf;
36 			else
37 				found = NULL;
38 
39 			rcu_read_unlock();
40 			return found;
41 		}
42 	}
43 	rcu_read_unlock();
44 
45 	return NULL;
46 }
47 
48 /**
49  * ice_release_vf - Release VF associated with a refcount
50  * @ref: the kref decremented to zero
51  *
52  * Callback function for kref_put to release a VF once its reference count has
53  * hit zero.
54  */
55 static void ice_release_vf(struct kref *ref)
56 {
57 	struct ice_vf *vf = container_of(ref, struct ice_vf, refcnt);
58 
59 	vf->vf_ops->free(vf);
60 }
61 
62 /**
63  * ice_put_vf - Release a reference to a VF
64  * @vf: the VF structure to decrease reference count on
65  *
66  * Decrease the reference count for a VF, and free the entry if it is no
67  * longer in use.
68  *
69  * This must be called after ice_get_vf_by_id() once the reference to the VF
70  * structure is no longer used. Otherwise, the VF structure will never be
71  * freed.
72  */
73 void ice_put_vf(struct ice_vf *vf)
74 {
75 	kref_put(&vf->refcnt, ice_release_vf);
76 }
77 
78 /**
79  * ice_has_vfs - Return true if the PF has any associated VFs
80  * @pf: the PF private structure
81  *
82  * Return whether or not the PF has any allocated VFs.
83  *
84  * Note that this function only guarantees that there are no VFs at the point
85  * of calling it. It does not guarantee that no more VFs will be added.
86  */
87 bool ice_has_vfs(struct ice_pf *pf)
88 {
89 	/* A simple check that the hash table is not empty does not require
90 	 * the mutex or rcu_read_lock.
91 	 */
92 	return !hash_empty(pf->vfs.table);
93 }
94 
95 /**
96  * ice_get_num_vfs - Get number of allocated VFs
97  * @pf: the PF private structure
98  *
99  * Return the total number of allocated VFs. NOTE: VF IDs are not guaranteed
100  * to be contiguous. Do not assume that a VF ID is guaranteed to be less than
101  * the output of this function.
102  */
103 u16 ice_get_num_vfs(struct ice_pf *pf)
104 {
105 	struct ice_vf *vf;
106 	unsigned int bkt;
107 	u16 num_vfs = 0;
108 
109 	rcu_read_lock();
110 	ice_for_each_vf_rcu(pf, bkt, vf)
111 		num_vfs++;
112 	rcu_read_unlock();
113 
114 	return num_vfs;
115 }
116 
117 /**
118  * ice_get_vf_vsi - get VF's VSI based on the stored index
119  * @vf: VF used to get VSI
120  */
121 struct ice_vsi *ice_get_vf_vsi(struct ice_vf *vf)
122 {
123 	if (vf->lan_vsi_idx == ICE_NO_VSI)
124 		return NULL;
125 
126 	return vf->pf->vsi[vf->lan_vsi_idx];
127 }
128 
129 /**
130  * ice_is_vf_disabled
131  * @vf: pointer to the VF info
132  *
133  * If the PF has been disabled, there is no need resetting VF until PF is
134  * active again. Similarly, if the VF has been disabled, this means something
135  * else is resetting the VF, so we shouldn't continue.
136  *
137  * Returns true if the caller should consider the VF as disabled whether
138  * because that single VF is explicitly disabled or because the PF is
139  * currently disabled.
140  */
141 bool ice_is_vf_disabled(struct ice_vf *vf)
142 {
143 	struct ice_pf *pf = vf->pf;
144 
145 	return (test_bit(ICE_VF_DIS, pf->state) ||
146 		test_bit(ICE_VF_STATE_DIS, vf->vf_states));
147 }
148 
149 /**
150  * ice_wait_on_vf_reset - poll to make sure a given VF is ready after reset
151  * @vf: The VF being resseting
152  *
153  * The max poll time is about ~800ms, which is about the maximum time it takes
154  * for a VF to be reset and/or a VF driver to be removed.
155  */
156 static void ice_wait_on_vf_reset(struct ice_vf *vf)
157 {
158 	int i;
159 
160 	for (i = 0; i < ICE_MAX_VF_RESET_TRIES; i++) {
161 		if (test_bit(ICE_VF_STATE_INIT, vf->vf_states))
162 			break;
163 		msleep(ICE_MAX_VF_RESET_SLEEP_MS);
164 	}
165 }
166 
167 /**
168  * ice_check_vf_ready_for_cfg - check if VF is ready to be configured/queried
169  * @vf: VF to check if it's ready to be configured/queried
170  *
171  * The purpose of this function is to make sure the VF is not in reset, not
172  * disabled, and initialized so it can be configured and/or queried by a host
173  * administrator.
174  */
175 int ice_check_vf_ready_for_cfg(struct ice_vf *vf)
176 {
177 	ice_wait_on_vf_reset(vf);
178 
179 	if (ice_is_vf_disabled(vf))
180 		return -EINVAL;
181 
182 	if (ice_check_vf_init(vf))
183 		return -EBUSY;
184 
185 	return 0;
186 }
187 
188 /**
189  * ice_trigger_vf_reset - Reset a VF on HW
190  * @vf: pointer to the VF structure
191  * @is_vflr: true if VFLR was issued, false if not
192  * @is_pfr: true if the reset was triggered due to a previous PFR
193  *
194  * Trigger hardware to start a reset for a particular VF. Expects the caller
195  * to wait the proper amount of time to allow hardware to reset the VF before
196  * it cleans up and restores VF functionality.
197  */
198 static void ice_trigger_vf_reset(struct ice_vf *vf, bool is_vflr, bool is_pfr)
199 {
200 	/* Inform VF that it is no longer active, as a warning */
201 	clear_bit(ICE_VF_STATE_ACTIVE, vf->vf_states);
202 
203 	/* Disable VF's configuration API during reset. The flag is re-enabled
204 	 * when it's safe again to access VF's VSI.
205 	 */
206 	clear_bit(ICE_VF_STATE_INIT, vf->vf_states);
207 
208 	/* VF_MBX_ARQLEN and VF_MBX_ATQLEN are cleared by PFR, so the driver
209 	 * needs to clear them in the case of VFR/VFLR. If this is done for
210 	 * PFR, it can mess up VF resets because the VF driver may already
211 	 * have started cleanup by the time we get here.
212 	 */
213 	if (!is_pfr)
214 		vf->vf_ops->clear_mbx_register(vf);
215 
216 	vf->vf_ops->trigger_reset_register(vf, is_vflr);
217 }
218 
219 static void ice_vf_clear_counters(struct ice_vf *vf)
220 {
221 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
222 
223 	if (vsi)
224 		vsi->num_vlan = 0;
225 
226 	vf->num_mac = 0;
227 	memset(&vf->mdd_tx_events, 0, sizeof(vf->mdd_tx_events));
228 	memset(&vf->mdd_rx_events, 0, sizeof(vf->mdd_rx_events));
229 }
230 
231 /**
232  * ice_vf_pre_vsi_rebuild - tasks to be done prior to VSI rebuild
233  * @vf: VF to perform pre VSI rebuild tasks
234  *
235  * These tasks are items that don't need to be amortized since they are most
236  * likely called in a for loop with all VF(s) in the reset_all_vfs() case.
237  */
238 static void ice_vf_pre_vsi_rebuild(struct ice_vf *vf)
239 {
240 	/* Close any IRQ mapping now */
241 	if (vf->vf_ops->irq_close)
242 		vf->vf_ops->irq_close(vf);
243 
244 	ice_vf_clear_counters(vf);
245 	vf->vf_ops->clear_reset_trigger(vf);
246 }
247 
248 /**
249  * ice_vf_recreate_vsi - Release and re-create the VF's VSI
250  * @vf: VF to recreate the VSI for
251  *
252  * This is only called when a single VF is being reset (i.e. VVF, VFLR, host
253  * VF configuration change, etc)
254  *
255  * It releases and then re-creates a new VSI.
256  */
257 static int ice_vf_recreate_vsi(struct ice_vf *vf)
258 {
259 	struct ice_pf *pf = vf->pf;
260 	int err;
261 
262 	ice_vf_vsi_release(vf);
263 
264 	err = vf->vf_ops->create_vsi(vf);
265 	if (err) {
266 		dev_err(ice_pf_to_dev(pf),
267 			"Failed to recreate the VF%u's VSI, error %d\n",
268 			vf->vf_id, err);
269 		return err;
270 	}
271 
272 	return 0;
273 }
274 
275 /**
276  * ice_vf_rebuild_vsi - rebuild the VF's VSI
277  * @vf: VF to rebuild the VSI for
278  *
279  * This is only called when all VF(s) are being reset (i.e. PCIe Reset on the
280  * host, PFR, CORER, etc.).
281  *
282  * It reprograms the VSI configuration back into hardware.
283  */
284 static int ice_vf_rebuild_vsi(struct ice_vf *vf)
285 {
286 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
287 	struct ice_pf *pf = vf->pf;
288 
289 	if (WARN_ON(!vsi))
290 		return -EINVAL;
291 
292 	if (ice_vsi_rebuild(vsi, ICE_VSI_FLAG_INIT)) {
293 		dev_err(ice_pf_to_dev(pf), "failed to rebuild VF %d VSI\n",
294 			vf->vf_id);
295 		return -EIO;
296 	}
297 	/* vsi->idx will remain the same in this case so don't update
298 	 * vf->lan_vsi_idx
299 	 */
300 	vsi->vsi_num = ice_get_hw_vsi_num(&pf->hw, vsi->idx);
301 	vf->lan_vsi_num = vsi->vsi_num;
302 
303 	return 0;
304 }
305 
306 /**
307  * ice_vf_post_vsi_rebuild - Reset tasks that occur after VSI rebuild
308  * @vf: the VF being reset
309  *
310  * Perform reset tasks which must occur after the VSI has been re-created or
311  * rebuilt during a VF reset.
312  */
313 static void ice_vf_post_vsi_rebuild(struct ice_vf *vf)
314 {
315 	ice_vf_rebuild_host_cfg(vf);
316 	ice_vf_set_initialized(vf);
317 
318 	vf->vf_ops->post_vsi_rebuild(vf);
319 }
320 
321 /**
322  * ice_is_any_vf_in_unicast_promisc - check if any VF(s)
323  * are in unicast promiscuous mode
324  * @pf: PF structure for accessing VF(s)
325  *
326  * Return false if no VF(s) are in unicast promiscuous mode,
327  * else return true
328  */
329 bool ice_is_any_vf_in_unicast_promisc(struct ice_pf *pf)
330 {
331 	bool is_vf_promisc = false;
332 	struct ice_vf *vf;
333 	unsigned int bkt;
334 
335 	rcu_read_lock();
336 	ice_for_each_vf_rcu(pf, bkt, vf) {
337 		/* found a VF that has promiscuous mode configured */
338 		if (test_bit(ICE_VF_STATE_UC_PROMISC, vf->vf_states)) {
339 			is_vf_promisc = true;
340 			break;
341 		}
342 	}
343 	rcu_read_unlock();
344 
345 	return is_vf_promisc;
346 }
347 
348 /**
349  * ice_vf_get_promisc_masks - Calculate masks for promiscuous modes
350  * @vf: the VF pointer
351  * @vsi: the VSI to configure
352  * @ucast_m: promiscuous mask to apply to unicast
353  * @mcast_m: promiscuous mask to apply to multicast
354  *
355  * Decide which mask should be used for unicast and multicast filter,
356  * based on presence of VLANs
357  */
358 void
359 ice_vf_get_promisc_masks(struct ice_vf *vf, struct ice_vsi *vsi,
360 			 u8 *ucast_m, u8 *mcast_m)
361 {
362 	if (ice_vf_is_port_vlan_ena(vf) ||
363 	    ice_vsi_has_non_zero_vlans(vsi)) {
364 		*mcast_m = ICE_MCAST_VLAN_PROMISC_BITS;
365 		*ucast_m = ICE_UCAST_VLAN_PROMISC_BITS;
366 	} else {
367 		*mcast_m = ICE_MCAST_PROMISC_BITS;
368 		*ucast_m = ICE_UCAST_PROMISC_BITS;
369 	}
370 }
371 
372 /**
373  * ice_vf_clear_all_promisc_modes - Clear promisc/allmulticast on VF VSI
374  * @vf: the VF pointer
375  * @vsi: the VSI to configure
376  *
377  * Clear all promiscuous/allmulticast filters for a VF
378  */
379 static int
380 ice_vf_clear_all_promisc_modes(struct ice_vf *vf, struct ice_vsi *vsi)
381 {
382 	struct ice_pf *pf = vf->pf;
383 	u8 ucast_m, mcast_m;
384 	int ret = 0;
385 
386 	ice_vf_get_promisc_masks(vf, vsi, &ucast_m, &mcast_m);
387 	if (test_bit(ICE_VF_STATE_UC_PROMISC, vf->vf_states)) {
388 		if (!test_bit(ICE_FLAG_VF_TRUE_PROMISC_ENA, pf->flags)) {
389 			if (ice_is_dflt_vsi_in_use(vsi->port_info))
390 				ret = ice_clear_dflt_vsi(vsi);
391 		} else {
392 			ret = ice_vf_clear_vsi_promisc(vf, vsi, ucast_m);
393 		}
394 
395 		if (ret) {
396 			dev_err(ice_pf_to_dev(vf->pf), "Disabling promiscuous mode failed\n");
397 		} else {
398 			clear_bit(ICE_VF_STATE_UC_PROMISC, vf->vf_states);
399 			dev_info(ice_pf_to_dev(vf->pf), "Disabling promiscuous mode succeeded\n");
400 		}
401 	}
402 
403 	if (test_bit(ICE_VF_STATE_MC_PROMISC, vf->vf_states)) {
404 		ret = ice_vf_clear_vsi_promisc(vf, vsi, mcast_m);
405 		if (ret) {
406 			dev_err(ice_pf_to_dev(vf->pf), "Disabling allmulticast mode failed\n");
407 		} else {
408 			clear_bit(ICE_VF_STATE_MC_PROMISC, vf->vf_states);
409 			dev_info(ice_pf_to_dev(vf->pf), "Disabling allmulticast mode succeeded\n");
410 		}
411 	}
412 	return ret;
413 }
414 
415 /**
416  * ice_vf_set_vsi_promisc - Enable promiscuous mode for a VF VSI
417  * @vf: the VF to configure
418  * @vsi: the VF's VSI
419  * @promisc_m: the promiscuous mode to enable
420  */
421 int
422 ice_vf_set_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m)
423 {
424 	struct ice_hw *hw = &vsi->back->hw;
425 	int status;
426 
427 	if (ice_vf_is_port_vlan_ena(vf))
428 		status = ice_fltr_set_vsi_promisc(hw, vsi->idx, promisc_m,
429 						  ice_vf_get_port_vlan_id(vf));
430 	else if (ice_vsi_has_non_zero_vlans(vsi))
431 		status = ice_fltr_set_vlan_vsi_promisc(hw, vsi, promisc_m);
432 	else
433 		status = ice_fltr_set_vsi_promisc(hw, vsi->idx, promisc_m, 0);
434 
435 	if (status && status != -EEXIST) {
436 		dev_err(ice_pf_to_dev(vsi->back), "enable Tx/Rx filter promiscuous mode on VF-%u failed, error: %d\n",
437 			vf->vf_id, status);
438 		return status;
439 	}
440 
441 	return 0;
442 }
443 
444 /**
445  * ice_vf_clear_vsi_promisc - Disable promiscuous mode for a VF VSI
446  * @vf: the VF to configure
447  * @vsi: the VF's VSI
448  * @promisc_m: the promiscuous mode to disable
449  */
450 int
451 ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m)
452 {
453 	struct ice_hw *hw = &vsi->back->hw;
454 	int status;
455 
456 	if (ice_vf_is_port_vlan_ena(vf))
457 		status = ice_fltr_clear_vsi_promisc(hw, vsi->idx, promisc_m,
458 						    ice_vf_get_port_vlan_id(vf));
459 	else if (ice_vsi_has_non_zero_vlans(vsi))
460 		status = ice_fltr_clear_vlan_vsi_promisc(hw, vsi, promisc_m);
461 	else
462 		status = ice_fltr_clear_vsi_promisc(hw, vsi->idx, promisc_m, 0);
463 
464 	if (status && status != -ENOENT) {
465 		dev_err(ice_pf_to_dev(vsi->back), "disable Tx/Rx filter promiscuous mode on VF-%u failed, error: %d\n",
466 			vf->vf_id, status);
467 		return status;
468 	}
469 
470 	return 0;
471 }
472 
473 /**
474  * ice_reset_all_vfs - reset all allocated VFs in one go
475  * @pf: pointer to the PF structure
476  *
477  * Reset all VFs at once, in response to a PF or other device reset.
478  *
479  * First, tell the hardware to reset each VF, then do all the waiting in one
480  * chunk, and finally finish restoring each VF after the wait. This is useful
481  * during PF routines which need to reset all VFs, as otherwise it must perform
482  * these resets in a serialized fashion.
483  */
484 void ice_reset_all_vfs(struct ice_pf *pf)
485 {
486 	struct device *dev = ice_pf_to_dev(pf);
487 	struct ice_hw *hw = &pf->hw;
488 	struct ice_vf *vf;
489 	unsigned int bkt;
490 
491 	/* If we don't have any VFs, then there is nothing to reset */
492 	if (!ice_has_vfs(pf))
493 		return;
494 
495 	mutex_lock(&pf->vfs.table_lock);
496 
497 	/* clear all malicious info if the VFs are getting reset */
498 	ice_for_each_vf(pf, bkt, vf)
499 		ice_mbx_clear_malvf(&hw->mbx_snapshot, vf->vf_id,
500 				    &vf->mbx_info);
501 
502 	/* If VFs have been disabled, there is no need to reset */
503 	if (test_and_set_bit(ICE_VF_DIS, pf->state)) {
504 		mutex_unlock(&pf->vfs.table_lock);
505 		return;
506 	}
507 
508 	/* Begin reset on all VFs at once */
509 	ice_for_each_vf(pf, bkt, vf)
510 		ice_trigger_vf_reset(vf, true, true);
511 
512 	/* HW requires some time to make sure it can flush the FIFO for a VF
513 	 * when it resets it. Now that we've triggered all of the VFs, iterate
514 	 * the table again and wait for each VF to complete.
515 	 */
516 	ice_for_each_vf(pf, bkt, vf) {
517 		if (!vf->vf_ops->poll_reset_status(vf)) {
518 			/* Display a warning if at least one VF didn't manage
519 			 * to reset in time, but continue on with the
520 			 * operation.
521 			 */
522 			dev_warn(dev, "VF %u reset check timeout\n", vf->vf_id);
523 			break;
524 		}
525 	}
526 
527 	/* free VF resources to begin resetting the VSI state */
528 	ice_for_each_vf(pf, bkt, vf) {
529 		mutex_lock(&vf->cfg_lock);
530 
531 		vf->driver_caps = 0;
532 		ice_vc_set_default_allowlist(vf);
533 
534 		ice_vf_fdir_exit(vf);
535 		ice_vf_fdir_init(vf);
536 		/* clean VF control VSI when resetting VFs since it should be
537 		 * setup only when VF creates its first FDIR rule.
538 		 */
539 		if (vf->ctrl_vsi_idx != ICE_NO_VSI)
540 			ice_vf_ctrl_invalidate_vsi(vf);
541 
542 		ice_vf_pre_vsi_rebuild(vf);
543 		ice_vf_rebuild_vsi(vf);
544 		ice_vf_post_vsi_rebuild(vf);
545 
546 		mutex_unlock(&vf->cfg_lock);
547 	}
548 
549 	if (ice_is_eswitch_mode_switchdev(pf))
550 		if (ice_eswitch_rebuild(pf))
551 			dev_warn(dev, "eswitch rebuild failed\n");
552 
553 	ice_flush(hw);
554 	clear_bit(ICE_VF_DIS, pf->state);
555 
556 	mutex_unlock(&pf->vfs.table_lock);
557 }
558 
559 /**
560  * ice_notify_vf_reset - Notify VF of a reset event
561  * @vf: pointer to the VF structure
562  */
563 static void ice_notify_vf_reset(struct ice_vf *vf)
564 {
565 	struct ice_hw *hw = &vf->pf->hw;
566 	struct virtchnl_pf_event pfe;
567 
568 	/* Bail out if VF is in disabled state, neither initialized, nor active
569 	 * state - otherwise proceed with notifications
570 	 */
571 	if ((!test_bit(ICE_VF_STATE_INIT, vf->vf_states) &&
572 	     !test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) ||
573 	    test_bit(ICE_VF_STATE_DIS, vf->vf_states))
574 		return;
575 
576 	pfe.event = VIRTCHNL_EVENT_RESET_IMPENDING;
577 	pfe.severity = PF_EVENT_SEVERITY_CERTAIN_DOOM;
578 	ice_aq_send_msg_to_vf(hw, vf->vf_id, VIRTCHNL_OP_EVENT,
579 			      VIRTCHNL_STATUS_SUCCESS, (u8 *)&pfe, sizeof(pfe),
580 			      NULL);
581 }
582 
583 /**
584  * ice_reset_vf - Reset a particular VF
585  * @vf: pointer to the VF structure
586  * @flags: flags controlling behavior of the reset
587  *
588  * Flags:
589  *   ICE_VF_RESET_VFLR - Indicates a reset is due to VFLR event
590  *   ICE_VF_RESET_NOTIFY - Send VF a notification prior to reset
591  *   ICE_VF_RESET_LOCK - Acquire VF cfg_lock before resetting
592  *
593  * Returns 0 if the VF is currently in reset, if resets are disabled, or if
594  * the VF resets successfully. Returns an error code if the VF fails to
595  * rebuild.
596  */
597 int ice_reset_vf(struct ice_vf *vf, u32 flags)
598 {
599 	struct ice_pf *pf = vf->pf;
600 	struct ice_vsi *vsi;
601 	struct device *dev;
602 	struct ice_hw *hw;
603 	int err = 0;
604 	bool rsd;
605 
606 	dev = ice_pf_to_dev(pf);
607 	hw = &pf->hw;
608 
609 	if (flags & ICE_VF_RESET_NOTIFY)
610 		ice_notify_vf_reset(vf);
611 
612 	if (test_bit(ICE_VF_RESETS_DISABLED, pf->state)) {
613 		dev_dbg(dev, "Trying to reset VF %d, but all VF resets are disabled\n",
614 			vf->vf_id);
615 		return 0;
616 	}
617 
618 	if (ice_is_vf_disabled(vf)) {
619 		vsi = ice_get_vf_vsi(vf);
620 		if (!vsi) {
621 			dev_dbg(dev, "VF is already removed\n");
622 			return -EINVAL;
623 		}
624 		ice_vsi_stop_lan_tx_rings(vsi, ICE_NO_RESET, vf->vf_id);
625 
626 		if (ice_vsi_is_rx_queue_active(vsi))
627 			ice_vsi_stop_all_rx_rings(vsi);
628 
629 		dev_dbg(dev, "VF is already disabled, there is no need for resetting it, telling VM, all is fine %d\n",
630 			vf->vf_id);
631 		return 0;
632 	}
633 
634 	if (flags & ICE_VF_RESET_LOCK)
635 		mutex_lock(&vf->cfg_lock);
636 	else
637 		lockdep_assert_held(&vf->cfg_lock);
638 
639 	/* Set VF disable bit state here, before triggering reset */
640 	set_bit(ICE_VF_STATE_DIS, vf->vf_states);
641 	ice_trigger_vf_reset(vf, flags & ICE_VF_RESET_VFLR, false);
642 
643 	vsi = ice_get_vf_vsi(vf);
644 	if (WARN_ON(!vsi)) {
645 		err = -EIO;
646 		goto out_unlock;
647 	}
648 
649 	ice_dis_vf_qs(vf);
650 
651 	/* Call Disable LAN Tx queue AQ whether or not queues are
652 	 * enabled. This is needed for successful completion of VFR.
653 	 */
654 	ice_dis_vsi_txq(vsi->port_info, vsi->idx, 0, 0, NULL, NULL,
655 			NULL, vf->vf_ops->reset_type, vf->vf_id, NULL);
656 
657 	/* poll VPGEN_VFRSTAT reg to make sure
658 	 * that reset is complete
659 	 */
660 	rsd = vf->vf_ops->poll_reset_status(vf);
661 
662 	/* Display a warning if VF didn't manage to reset in time, but need to
663 	 * continue on with the operation.
664 	 */
665 	if (!rsd)
666 		dev_warn(dev, "VF reset check timeout on VF %d\n", vf->vf_id);
667 
668 	vf->driver_caps = 0;
669 	ice_vc_set_default_allowlist(vf);
670 
671 	/* disable promiscuous modes in case they were enabled
672 	 * ignore any error if disabling process failed
673 	 */
674 	ice_vf_clear_all_promisc_modes(vf, vsi);
675 
676 	ice_eswitch_del_vf_mac_rule(vf);
677 
678 	ice_vf_fdir_exit(vf);
679 	ice_vf_fdir_init(vf);
680 	/* clean VF control VSI when resetting VF since it should be setup
681 	 * only when VF creates its first FDIR rule.
682 	 */
683 	if (vf->ctrl_vsi_idx != ICE_NO_VSI)
684 		ice_vf_ctrl_vsi_release(vf);
685 
686 	ice_vf_pre_vsi_rebuild(vf);
687 
688 	if (ice_vf_recreate_vsi(vf)) {
689 		dev_err(dev, "Failed to release and setup the VF%u's VSI\n",
690 			vf->vf_id);
691 		err = -EFAULT;
692 		goto out_unlock;
693 	}
694 
695 	ice_vf_post_vsi_rebuild(vf);
696 	vsi = ice_get_vf_vsi(vf);
697 	if (WARN_ON(!vsi)) {
698 		err = -EINVAL;
699 		goto out_unlock;
700 	}
701 
702 	ice_eswitch_update_repr(vsi);
703 	ice_eswitch_replay_vf_mac_rule(vf);
704 
705 	/* if the VF has been reset allow it to come up again */
706 	ice_mbx_clear_malvf(&hw->mbx_snapshot, vf->vf_id, &vf->mbx_info);
707 
708 out_unlock:
709 	if (flags & ICE_VF_RESET_LOCK)
710 		mutex_unlock(&vf->cfg_lock);
711 
712 	return err;
713 }
714 
715 /**
716  * ice_set_vf_state_qs_dis - Set VF queues state to disabled
717  * @vf: pointer to the VF structure
718  */
719 static void ice_set_vf_state_qs_dis(struct ice_vf *vf)
720 {
721 	/* Clear Rx/Tx enabled queues flag */
722 	bitmap_zero(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF);
723 	bitmap_zero(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF);
724 	clear_bit(ICE_VF_STATE_QS_ENA, vf->vf_states);
725 }
726 
727 /**
728  * ice_set_vf_state_dis - Set VF state to disabled
729  * @vf: pointer to the VF structure
730  */
731 void ice_set_vf_state_dis(struct ice_vf *vf)
732 {
733 	ice_set_vf_state_qs_dis(vf);
734 	vf->vf_ops->clear_reset_state(vf);
735 }
736 
737 /* Private functions only accessed from other virtualization files */
738 
739 /**
740  * ice_initialize_vf_entry - Initialize a VF entry
741  * @vf: pointer to the VF structure
742  */
743 void ice_initialize_vf_entry(struct ice_vf *vf)
744 {
745 	struct ice_pf *pf = vf->pf;
746 	struct ice_vfs *vfs;
747 
748 	vfs = &pf->vfs;
749 
750 	/* assign default capabilities */
751 	vf->spoofchk = true;
752 	vf->num_vf_qs = vfs->num_qps_per;
753 	ice_vc_set_default_allowlist(vf);
754 	ice_virtchnl_set_dflt_ops(vf);
755 
756 	/* ctrl_vsi_idx will be set to a valid value only when iAVF
757 	 * creates its first fdir rule.
758 	 */
759 	ice_vf_ctrl_invalidate_vsi(vf);
760 	ice_vf_fdir_init(vf);
761 
762 	/* Initialize mailbox info for this VF */
763 	ice_mbx_init_vf_info(&pf->hw, &vf->mbx_info);
764 
765 	mutex_init(&vf->cfg_lock);
766 }
767 
768 /**
769  * ice_dis_vf_qs - Disable the VF queues
770  * @vf: pointer to the VF structure
771  */
772 void ice_dis_vf_qs(struct ice_vf *vf)
773 {
774 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
775 
776 	if (WARN_ON(!vsi))
777 		return;
778 
779 	ice_vsi_stop_lan_tx_rings(vsi, ICE_NO_RESET, vf->vf_id);
780 	ice_vsi_stop_all_rx_rings(vsi);
781 	ice_set_vf_state_qs_dis(vf);
782 }
783 
784 /**
785  * ice_err_to_virt_err - translate errors for VF return code
786  * @err: error return code
787  */
788 enum virtchnl_status_code ice_err_to_virt_err(int err)
789 {
790 	switch (err) {
791 	case 0:
792 		return VIRTCHNL_STATUS_SUCCESS;
793 	case -EINVAL:
794 	case -ENODEV:
795 		return VIRTCHNL_STATUS_ERR_PARAM;
796 	case -ENOMEM:
797 		return VIRTCHNL_STATUS_ERR_NO_MEMORY;
798 	case -EALREADY:
799 	case -EBUSY:
800 	case -EIO:
801 	case -ENOSPC:
802 		return VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR;
803 	default:
804 		return VIRTCHNL_STATUS_ERR_NOT_SUPPORTED;
805 	}
806 }
807 
808 /**
809  * ice_check_vf_init - helper to check if VF init complete
810  * @vf: the pointer to the VF to check
811  */
812 int ice_check_vf_init(struct ice_vf *vf)
813 {
814 	struct ice_pf *pf = vf->pf;
815 
816 	if (!test_bit(ICE_VF_STATE_INIT, vf->vf_states)) {
817 		dev_err(ice_pf_to_dev(pf), "VF ID: %u in reset. Try again.\n",
818 			vf->vf_id);
819 		return -EBUSY;
820 	}
821 	return 0;
822 }
823 
824 /**
825  * ice_vf_get_port_info - Get the VF's port info structure
826  * @vf: VF used to get the port info structure for
827  */
828 struct ice_port_info *ice_vf_get_port_info(struct ice_vf *vf)
829 {
830 	return vf->pf->hw.port_info;
831 }
832 
833 /**
834  * ice_cfg_mac_antispoof - Configure MAC antispoof checking behavior
835  * @vsi: the VSI to configure
836  * @enable: whether to enable or disable the spoof checking
837  *
838  * Configure a VSI to enable (or disable) spoof checking behavior.
839  */
840 static int ice_cfg_mac_antispoof(struct ice_vsi *vsi, bool enable)
841 {
842 	struct ice_vsi_ctx *ctx;
843 	int err;
844 
845 	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
846 	if (!ctx)
847 		return -ENOMEM;
848 
849 	ctx->info.sec_flags = vsi->info.sec_flags;
850 	ctx->info.valid_sections = cpu_to_le16(ICE_AQ_VSI_PROP_SECURITY_VALID);
851 
852 	if (enable)
853 		ctx->info.sec_flags |= ICE_AQ_VSI_SEC_FLAG_ENA_MAC_ANTI_SPOOF;
854 	else
855 		ctx->info.sec_flags &= ~ICE_AQ_VSI_SEC_FLAG_ENA_MAC_ANTI_SPOOF;
856 
857 	err = ice_update_vsi(&vsi->back->hw, vsi->idx, ctx, NULL);
858 	if (err)
859 		dev_err(ice_pf_to_dev(vsi->back), "Failed to configure Tx MAC anti-spoof %s for VSI %d, error %d\n",
860 			enable ? "ON" : "OFF", vsi->vsi_num, err);
861 	else
862 		vsi->info.sec_flags = ctx->info.sec_flags;
863 
864 	kfree(ctx);
865 
866 	return err;
867 }
868 
869 /**
870  * ice_vsi_ena_spoofchk - enable Tx spoof checking for this VSI
871  * @vsi: VSI to enable Tx spoof checking for
872  */
873 static int ice_vsi_ena_spoofchk(struct ice_vsi *vsi)
874 {
875 	struct ice_vsi_vlan_ops *vlan_ops;
876 	int err = 0;
877 
878 	vlan_ops = ice_get_compat_vsi_vlan_ops(vsi);
879 
880 	/* Allow VF with VLAN 0 only to send all tagged traffic */
881 	if (vsi->type != ICE_VSI_VF || ice_vsi_has_non_zero_vlans(vsi)) {
882 		err = vlan_ops->ena_tx_filtering(vsi);
883 		if (err)
884 			return err;
885 	}
886 
887 	return ice_cfg_mac_antispoof(vsi, true);
888 }
889 
890 /**
891  * ice_vsi_dis_spoofchk - disable Tx spoof checking for this VSI
892  * @vsi: VSI to disable Tx spoof checking for
893  */
894 static int ice_vsi_dis_spoofchk(struct ice_vsi *vsi)
895 {
896 	struct ice_vsi_vlan_ops *vlan_ops;
897 	int err;
898 
899 	vlan_ops = ice_get_compat_vsi_vlan_ops(vsi);
900 
901 	err = vlan_ops->dis_tx_filtering(vsi);
902 	if (err)
903 		return err;
904 
905 	return ice_cfg_mac_antispoof(vsi, false);
906 }
907 
908 /**
909  * ice_vsi_apply_spoofchk - Apply Tx spoof checking setting to a VSI
910  * @vsi: VSI associated to the VF
911  * @enable: whether to enable or disable the spoof checking
912  */
913 int ice_vsi_apply_spoofchk(struct ice_vsi *vsi, bool enable)
914 {
915 	int err;
916 
917 	if (enable)
918 		err = ice_vsi_ena_spoofchk(vsi);
919 	else
920 		err = ice_vsi_dis_spoofchk(vsi);
921 
922 	return err;
923 }
924 
925 /**
926  * ice_is_vf_trusted
927  * @vf: pointer to the VF info
928  */
929 bool ice_is_vf_trusted(struct ice_vf *vf)
930 {
931 	return test_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);
932 }
933 
934 /**
935  * ice_vf_has_no_qs_ena - check if the VF has any Rx or Tx queues enabled
936  * @vf: the VF to check
937  *
938  * Returns true if the VF has no Rx and no Tx queues enabled and returns false
939  * otherwise
940  */
941 bool ice_vf_has_no_qs_ena(struct ice_vf *vf)
942 {
943 	return (!bitmap_weight(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
944 		!bitmap_weight(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF));
945 }
946 
947 /**
948  * ice_is_vf_link_up - check if the VF's link is up
949  * @vf: VF to check if link is up
950  */
951 bool ice_is_vf_link_up(struct ice_vf *vf)
952 {
953 	struct ice_port_info *pi = ice_vf_get_port_info(vf);
954 
955 	if (ice_check_vf_init(vf))
956 		return false;
957 
958 	if (ice_vf_has_no_qs_ena(vf))
959 		return false;
960 	else if (vf->link_forced)
961 		return vf->link_up;
962 	else
963 		return pi->phy.link_info.link_info &
964 			ICE_AQ_LINK_UP;
965 }
966 
967 /**
968  * ice_vf_set_host_trust_cfg - set trust setting based on pre-reset value
969  * @vf: VF to configure trust setting for
970  */
971 static void ice_vf_set_host_trust_cfg(struct ice_vf *vf)
972 {
973 	if (vf->trusted)
974 		set_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);
975 	else
976 		clear_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps);
977 }
978 
979 /**
980  * ice_vf_rebuild_host_mac_cfg - add broadcast and the VF's perm_addr/LAA
981  * @vf: VF to add MAC filters for
982  *
983  * Called after a VF VSI has been re-added/rebuilt during reset. The PF driver
984  * always re-adds a broadcast filter and the VF's perm_addr/LAA after reset.
985  */
986 static int ice_vf_rebuild_host_mac_cfg(struct ice_vf *vf)
987 {
988 	struct device *dev = ice_pf_to_dev(vf->pf);
989 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
990 	u8 broadcast[ETH_ALEN];
991 	int status;
992 
993 	if (WARN_ON(!vsi))
994 		return -EINVAL;
995 
996 	if (ice_is_eswitch_mode_switchdev(vf->pf))
997 		return 0;
998 
999 	eth_broadcast_addr(broadcast);
1000 	status = ice_fltr_add_mac(vsi, broadcast, ICE_FWD_TO_VSI);
1001 	if (status) {
1002 		dev_err(dev, "failed to add broadcast MAC filter for VF %u, error %d\n",
1003 			vf->vf_id, status);
1004 		return status;
1005 	}
1006 
1007 	vf->num_mac++;
1008 
1009 	if (is_valid_ether_addr(vf->hw_lan_addr)) {
1010 		status = ice_fltr_add_mac(vsi, vf->hw_lan_addr,
1011 					  ICE_FWD_TO_VSI);
1012 		if (status) {
1013 			dev_err(dev, "failed to add default unicast MAC filter %pM for VF %u, error %d\n",
1014 				&vf->hw_lan_addr[0], vf->vf_id,
1015 				status);
1016 			return status;
1017 		}
1018 		vf->num_mac++;
1019 
1020 		ether_addr_copy(vf->dev_lan_addr, vf->hw_lan_addr);
1021 	}
1022 
1023 	return 0;
1024 }
1025 
1026 /**
1027  * ice_vf_rebuild_host_vlan_cfg - add VLAN 0 filter or rebuild the Port VLAN
1028  * @vf: VF to add MAC filters for
1029  * @vsi: Pointer to VSI
1030  *
1031  * Called after a VF VSI has been re-added/rebuilt during reset. The PF driver
1032  * always re-adds either a VLAN 0 or port VLAN based filter after reset.
1033  */
1034 static int ice_vf_rebuild_host_vlan_cfg(struct ice_vf *vf, struct ice_vsi *vsi)
1035 {
1036 	struct ice_vsi_vlan_ops *vlan_ops = ice_get_compat_vsi_vlan_ops(vsi);
1037 	struct device *dev = ice_pf_to_dev(vf->pf);
1038 	int err;
1039 
1040 	if (ice_vf_is_port_vlan_ena(vf)) {
1041 		err = vlan_ops->set_port_vlan(vsi, &vf->port_vlan_info);
1042 		if (err) {
1043 			dev_err(dev, "failed to configure port VLAN via VSI parameters for VF %u, error %d\n",
1044 				vf->vf_id, err);
1045 			return err;
1046 		}
1047 
1048 		err = vlan_ops->add_vlan(vsi, &vf->port_vlan_info);
1049 	} else {
1050 		err = ice_vsi_add_vlan_zero(vsi);
1051 	}
1052 
1053 	if (err) {
1054 		dev_err(dev, "failed to add VLAN %u filter for VF %u during VF rebuild, error %d\n",
1055 			ice_vf_is_port_vlan_ena(vf) ?
1056 			ice_vf_get_port_vlan_id(vf) : 0, vf->vf_id, err);
1057 		return err;
1058 	}
1059 
1060 	err = vlan_ops->ena_rx_filtering(vsi);
1061 	if (err)
1062 		dev_warn(dev, "failed to enable Rx VLAN filtering for VF %d VSI %d during VF rebuild, error %d\n",
1063 			 vf->vf_id, vsi->idx, err);
1064 
1065 	return 0;
1066 }
1067 
1068 /**
1069  * ice_vf_rebuild_host_tx_rate_cfg - re-apply the Tx rate limiting configuration
1070  * @vf: VF to re-apply the configuration for
1071  *
1072  * Called after a VF VSI has been re-added/rebuild during reset. The PF driver
1073  * needs to re-apply the host configured Tx rate limiting configuration.
1074  */
1075 static int ice_vf_rebuild_host_tx_rate_cfg(struct ice_vf *vf)
1076 {
1077 	struct device *dev = ice_pf_to_dev(vf->pf);
1078 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
1079 	int err;
1080 
1081 	if (WARN_ON(!vsi))
1082 		return -EINVAL;
1083 
1084 	if (vf->min_tx_rate) {
1085 		err = ice_set_min_bw_limit(vsi, (u64)vf->min_tx_rate * 1000);
1086 		if (err) {
1087 			dev_err(dev, "failed to set min Tx rate to %d Mbps for VF %u, error %d\n",
1088 				vf->min_tx_rate, vf->vf_id, err);
1089 			return err;
1090 		}
1091 	}
1092 
1093 	if (vf->max_tx_rate) {
1094 		err = ice_set_max_bw_limit(vsi, (u64)vf->max_tx_rate * 1000);
1095 		if (err) {
1096 			dev_err(dev, "failed to set max Tx rate to %d Mbps for VF %u, error %d\n",
1097 				vf->max_tx_rate, vf->vf_id, err);
1098 			return err;
1099 		}
1100 	}
1101 
1102 	return 0;
1103 }
1104 
1105 /**
1106  * ice_vf_rebuild_aggregator_node_cfg - rebuild aggregator node config
1107  * @vsi: Pointer to VSI
1108  *
1109  * This function moves VSI into corresponding scheduler aggregator node
1110  * based on cached value of "aggregator node info" per VSI
1111  */
1112 static void ice_vf_rebuild_aggregator_node_cfg(struct ice_vsi *vsi)
1113 {
1114 	struct ice_pf *pf = vsi->back;
1115 	struct device *dev;
1116 	int status;
1117 
1118 	if (!vsi->agg_node)
1119 		return;
1120 
1121 	dev = ice_pf_to_dev(pf);
1122 	if (vsi->agg_node->num_vsis == ICE_MAX_VSIS_IN_AGG_NODE) {
1123 		dev_dbg(dev,
1124 			"agg_id %u already has reached max_num_vsis %u\n",
1125 			vsi->agg_node->agg_id, vsi->agg_node->num_vsis);
1126 		return;
1127 	}
1128 
1129 	status = ice_move_vsi_to_agg(pf->hw.port_info, vsi->agg_node->agg_id,
1130 				     vsi->idx, vsi->tc_cfg.ena_tc);
1131 	if (status)
1132 		dev_dbg(dev, "unable to move VSI idx %u into aggregator %u node",
1133 			vsi->idx, vsi->agg_node->agg_id);
1134 	else
1135 		vsi->agg_node->num_vsis++;
1136 }
1137 
1138 /**
1139  * ice_vf_rebuild_host_cfg - host admin configuration is persistent across reset
1140  * @vf: VF to rebuild host configuration on
1141  */
1142 void ice_vf_rebuild_host_cfg(struct ice_vf *vf)
1143 {
1144 	struct device *dev = ice_pf_to_dev(vf->pf);
1145 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
1146 
1147 	if (WARN_ON(!vsi))
1148 		return;
1149 
1150 	ice_vf_set_host_trust_cfg(vf);
1151 
1152 	if (ice_vf_rebuild_host_mac_cfg(vf))
1153 		dev_err(dev, "failed to rebuild default MAC configuration for VF %d\n",
1154 			vf->vf_id);
1155 
1156 	if (ice_vf_rebuild_host_vlan_cfg(vf, vsi))
1157 		dev_err(dev, "failed to rebuild VLAN configuration for VF %u\n",
1158 			vf->vf_id);
1159 
1160 	if (ice_vf_rebuild_host_tx_rate_cfg(vf))
1161 		dev_err(dev, "failed to rebuild Tx rate limiting configuration for VF %u\n",
1162 			vf->vf_id);
1163 
1164 	if (ice_vsi_apply_spoofchk(vsi, vf->spoofchk))
1165 		dev_err(dev, "failed to rebuild spoofchk configuration for VF %d\n",
1166 			vf->vf_id);
1167 
1168 	/* rebuild aggregator node config for main VF VSI */
1169 	ice_vf_rebuild_aggregator_node_cfg(vsi);
1170 }
1171 
1172 /**
1173  * ice_vf_ctrl_invalidate_vsi - invalidate ctrl_vsi_idx to remove VSI access
1174  * @vf: VF that control VSI is being invalidated on
1175  */
1176 void ice_vf_ctrl_invalidate_vsi(struct ice_vf *vf)
1177 {
1178 	vf->ctrl_vsi_idx = ICE_NO_VSI;
1179 }
1180 
1181 /**
1182  * ice_vf_ctrl_vsi_release - invalidate the VF's control VSI after freeing it
1183  * @vf: VF that control VSI is being released on
1184  */
1185 void ice_vf_ctrl_vsi_release(struct ice_vf *vf)
1186 {
1187 	ice_vsi_release(vf->pf->vsi[vf->ctrl_vsi_idx]);
1188 	ice_vf_ctrl_invalidate_vsi(vf);
1189 }
1190 
1191 /**
1192  * ice_vf_ctrl_vsi_setup - Set up a VF control VSI
1193  * @vf: VF to setup control VSI for
1194  *
1195  * Returns pointer to the successfully allocated VSI struct on success,
1196  * otherwise returns NULL on failure.
1197  */
1198 struct ice_vsi *ice_vf_ctrl_vsi_setup(struct ice_vf *vf)
1199 {
1200 	struct ice_vsi_cfg_params params = {};
1201 	struct ice_pf *pf = vf->pf;
1202 	struct ice_vsi *vsi;
1203 
1204 	params.type = ICE_VSI_CTRL;
1205 	params.pi = ice_vf_get_port_info(vf);
1206 	params.vf = vf;
1207 	params.flags = ICE_VSI_FLAG_INIT;
1208 
1209 	vsi = ice_vsi_setup(pf, &params);
1210 	if (!vsi) {
1211 		dev_err(ice_pf_to_dev(pf), "Failed to create VF control VSI\n");
1212 		ice_vf_ctrl_invalidate_vsi(vf);
1213 	}
1214 
1215 	return vsi;
1216 }
1217 
1218 /**
1219  * ice_vf_init_host_cfg - Initialize host admin configuration
1220  * @vf: VF to initialize
1221  * @vsi: the VSI created at initialization
1222  *
1223  * Initialize the VF host configuration. Called during VF creation to setup
1224  * VLAN 0, add the VF VSI broadcast filter, and setup spoof checking. It
1225  * should only be called during VF creation.
1226  */
1227 int ice_vf_init_host_cfg(struct ice_vf *vf, struct ice_vsi *vsi)
1228 {
1229 	struct ice_vsi_vlan_ops *vlan_ops;
1230 	struct ice_pf *pf = vf->pf;
1231 	u8 broadcast[ETH_ALEN];
1232 	struct device *dev;
1233 	int err;
1234 
1235 	dev = ice_pf_to_dev(pf);
1236 
1237 	err = ice_vsi_add_vlan_zero(vsi);
1238 	if (err) {
1239 		dev_warn(dev, "Failed to add VLAN 0 filter for VF %d\n",
1240 			 vf->vf_id);
1241 		return err;
1242 	}
1243 
1244 	vlan_ops = ice_get_compat_vsi_vlan_ops(vsi);
1245 	err = vlan_ops->ena_rx_filtering(vsi);
1246 	if (err) {
1247 		dev_warn(dev, "Failed to enable Rx VLAN filtering for VF %d\n",
1248 			 vf->vf_id);
1249 		return err;
1250 	}
1251 
1252 	eth_broadcast_addr(broadcast);
1253 	err = ice_fltr_add_mac(vsi, broadcast, ICE_FWD_TO_VSI);
1254 	if (err) {
1255 		dev_err(dev, "Failed to add broadcast MAC filter for VF %d, status %d\n",
1256 			vf->vf_id, err);
1257 		return err;
1258 	}
1259 
1260 	vf->num_mac = 1;
1261 
1262 	err = ice_vsi_apply_spoofchk(vsi, vf->spoofchk);
1263 	if (err) {
1264 		dev_warn(dev, "Failed to initialize spoofchk setting for VF %d\n",
1265 			 vf->vf_id);
1266 		return err;
1267 	}
1268 
1269 	return 0;
1270 }
1271 
1272 /**
1273  * ice_vf_invalidate_vsi - invalidate vsi_idx/vsi_num to remove VSI access
1274  * @vf: VF to remove access to VSI for
1275  */
1276 void ice_vf_invalidate_vsi(struct ice_vf *vf)
1277 {
1278 	vf->lan_vsi_idx = ICE_NO_VSI;
1279 	vf->lan_vsi_num = ICE_NO_VSI;
1280 }
1281 
1282 /**
1283  * ice_vf_vsi_release - Release the VF VSI and invalidate indexes
1284  * @vf: pointer to the VF structure
1285  *
1286  * Release the VF associated with this VSI and then invalidate the VSI
1287  * indexes.
1288  */
1289 void ice_vf_vsi_release(struct ice_vf *vf)
1290 {
1291 	struct ice_vsi *vsi = ice_get_vf_vsi(vf);
1292 
1293 	if (WARN_ON(!vsi))
1294 		return;
1295 
1296 	ice_vsi_release(vsi);
1297 	ice_vf_invalidate_vsi(vf);
1298 }
1299 
1300 /**
1301  * ice_vf_set_initialized - VF is ready for VIRTCHNL communication
1302  * @vf: VF to set in initialized state
1303  *
1304  * After this function the VF will be ready to receive/handle the
1305  * VIRTCHNL_OP_GET_VF_RESOURCES message
1306  */
1307 void ice_vf_set_initialized(struct ice_vf *vf)
1308 {
1309 	ice_set_vf_state_qs_dis(vf);
1310 	clear_bit(ICE_VF_STATE_MC_PROMISC, vf->vf_states);
1311 	clear_bit(ICE_VF_STATE_UC_PROMISC, vf->vf_states);
1312 	clear_bit(ICE_VF_STATE_DIS, vf->vf_states);
1313 	set_bit(ICE_VF_STATE_INIT, vf->vf_states);
1314 	memset(&vf->vlan_v2_caps, 0, sizeof(vf->vlan_v2_caps));
1315 }
1316