xref: /openbmc/linux/drivers/net/dsa/qca/qca8k-8xxx.c (revision 70ef7d87)
1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * Copyright (C) 2009 Felix Fietkau <nbd@nbd.name>
4  * Copyright (C) 2011-2012 Gabor Juhos <juhosg@openwrt.org>
5  * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved.
6  * Copyright (c) 2016 John Crispin <john@phrozen.org>
7  */
8 
9 #include <linux/module.h>
10 #include <linux/phy.h>
11 #include <linux/netdevice.h>
12 #include <linux/bitfield.h>
13 #include <linux/regmap.h>
14 #include <net/dsa.h>
15 #include <linux/of_net.h>
16 #include <linux/of_mdio.h>
17 #include <linux/of_platform.h>
18 #include <linux/mdio.h>
19 #include <linux/phylink.h>
20 #include <linux/gpio/consumer.h>
21 #include <linux/etherdevice.h>
22 #include <linux/dsa/tag_qca.h>
23 
24 #include "qca8k.h"
25 #include "qca8k_leds.h"
26 
27 static void
28 qca8k_split_addr(u32 regaddr, u16 *r1, u16 *r2, u16 *page)
29 {
30 	regaddr >>= 1;
31 	*r1 = regaddr & 0x1e;
32 
33 	regaddr >>= 5;
34 	*r2 = regaddr & 0x7;
35 
36 	regaddr >>= 3;
37 	*page = regaddr & 0x3ff;
38 }
39 
40 static int
41 qca8k_mii_write_lo(struct mii_bus *bus, int phy_id, u32 regnum, u32 val)
42 {
43 	int ret;
44 	u16 lo;
45 
46 	lo = val & 0xffff;
47 	ret = bus->write(bus, phy_id, regnum, lo);
48 	if (ret < 0)
49 		dev_err_ratelimited(&bus->dev,
50 				    "failed to write qca8k 32bit lo register\n");
51 
52 	return ret;
53 }
54 
55 static int
56 qca8k_mii_write_hi(struct mii_bus *bus, int phy_id, u32 regnum, u32 val)
57 {
58 	int ret;
59 	u16 hi;
60 
61 	hi = (u16)(val >> 16);
62 	ret = bus->write(bus, phy_id, regnum, hi);
63 	if (ret < 0)
64 		dev_err_ratelimited(&bus->dev,
65 				    "failed to write qca8k 32bit hi register\n");
66 
67 	return ret;
68 }
69 
70 static int
71 qca8k_mii_read_lo(struct mii_bus *bus, int phy_id, u32 regnum, u32 *val)
72 {
73 	int ret;
74 
75 	ret = bus->read(bus, phy_id, regnum);
76 	if (ret < 0)
77 		goto err;
78 
79 	*val = ret & 0xffff;
80 	return 0;
81 
82 err:
83 	dev_err_ratelimited(&bus->dev,
84 			    "failed to read qca8k 32bit lo register\n");
85 	*val = 0;
86 
87 	return ret;
88 }
89 
90 static int
91 qca8k_mii_read_hi(struct mii_bus *bus, int phy_id, u32 regnum, u32 *val)
92 {
93 	int ret;
94 
95 	ret = bus->read(bus, phy_id, regnum);
96 	if (ret < 0)
97 		goto err;
98 
99 	*val = ret << 16;
100 	return 0;
101 
102 err:
103 	dev_err_ratelimited(&bus->dev,
104 			    "failed to read qca8k 32bit hi register\n");
105 	*val = 0;
106 
107 	return ret;
108 }
109 
110 static int
111 qca8k_mii_read32(struct mii_bus *bus, int phy_id, u32 regnum, u32 *val)
112 {
113 	u32 hi, lo;
114 	int ret;
115 
116 	*val = 0;
117 
118 	ret = qca8k_mii_read_lo(bus, phy_id, regnum, &lo);
119 	if (ret < 0)
120 		goto err;
121 
122 	ret = qca8k_mii_read_hi(bus, phy_id, regnum + 1, &hi);
123 	if (ret < 0)
124 		goto err;
125 
126 	*val = lo | hi;
127 
128 err:
129 	return ret;
130 }
131 
132 static void
133 qca8k_mii_write32(struct mii_bus *bus, int phy_id, u32 regnum, u32 val)
134 {
135 	if (qca8k_mii_write_lo(bus, phy_id, regnum, val) < 0)
136 		return;
137 
138 	qca8k_mii_write_hi(bus, phy_id, regnum + 1, val);
139 }
140 
141 static int
142 qca8k_set_page(struct qca8k_priv *priv, u16 page)
143 {
144 	u16 *cached_page = &priv->mdio_cache.page;
145 	struct mii_bus *bus = priv->bus;
146 	int ret;
147 
148 	if (page == *cached_page)
149 		return 0;
150 
151 	ret = bus->write(bus, 0x18, 0, page);
152 	if (ret < 0) {
153 		dev_err_ratelimited(&bus->dev,
154 				    "failed to set qca8k page\n");
155 		return ret;
156 	}
157 
158 	*cached_page = page;
159 	usleep_range(1000, 2000);
160 	return 0;
161 }
162 
163 static void qca8k_rw_reg_ack_handler(struct dsa_switch *ds, struct sk_buff *skb)
164 {
165 	struct qca8k_mgmt_eth_data *mgmt_eth_data;
166 	struct qca8k_priv *priv = ds->priv;
167 	struct qca_mgmt_ethhdr *mgmt_ethhdr;
168 	u32 command;
169 	u8 len, cmd;
170 	int i;
171 
172 	mgmt_ethhdr = (struct qca_mgmt_ethhdr *)skb_mac_header(skb);
173 	mgmt_eth_data = &priv->mgmt_eth_data;
174 
175 	command = get_unaligned_le32(&mgmt_ethhdr->command);
176 	cmd = FIELD_GET(QCA_HDR_MGMT_CMD, command);
177 
178 	len = FIELD_GET(QCA_HDR_MGMT_LENGTH, command);
179 	/* Special case for len of 15 as this is the max value for len and needs to
180 	 * be increased before converting it from word to dword.
181 	 */
182 	if (len == 15)
183 		len++;
184 
185 	/* We can ignore odd value, we always round up them in the alloc function. */
186 	len *= sizeof(u16);
187 
188 	/* Make sure the seq match the requested packet */
189 	if (get_unaligned_le32(&mgmt_ethhdr->seq) == mgmt_eth_data->seq)
190 		mgmt_eth_data->ack = true;
191 
192 	if (cmd == MDIO_READ) {
193 		u32 *val = mgmt_eth_data->data;
194 
195 		*val = get_unaligned_le32(&mgmt_ethhdr->mdio_data);
196 
197 		/* Get the rest of the 12 byte of data.
198 		 * The read/write function will extract the requested data.
199 		 */
200 		if (len > QCA_HDR_MGMT_DATA1_LEN) {
201 			__le32 *data2 = (__le32 *)skb->data;
202 			int data_len = min_t(int, QCA_HDR_MGMT_DATA2_LEN,
203 					     len - QCA_HDR_MGMT_DATA1_LEN);
204 
205 			val++;
206 
207 			for (i = sizeof(u32); i <= data_len; i += sizeof(u32)) {
208 				*val = get_unaligned_le32(data2);
209 				val++;
210 				data2++;
211 			}
212 		}
213 	}
214 
215 	complete(&mgmt_eth_data->rw_done);
216 }
217 
218 static struct sk_buff *qca8k_alloc_mdio_header(enum mdio_cmd cmd, u32 reg, u32 *val,
219 					       int priority, unsigned int len)
220 {
221 	struct qca_mgmt_ethhdr *mgmt_ethhdr;
222 	unsigned int real_len;
223 	struct sk_buff *skb;
224 	__le32 *data2;
225 	u32 command;
226 	u16 hdr;
227 	int i;
228 
229 	skb = dev_alloc_skb(QCA_HDR_MGMT_PKT_LEN);
230 	if (!skb)
231 		return NULL;
232 
233 	/* Hdr mgmt length value is in step of word size.
234 	 * As an example to process 4 byte of data the correct length to set is 2.
235 	 * To process 8 byte 4, 12 byte 6, 16 byte 8...
236 	 *
237 	 * Odd values will always return the next size on the ack packet.
238 	 * (length of 3 (6 byte) will always return 8 bytes of data)
239 	 *
240 	 * This means that a value of 15 (0xf) actually means reading/writing 32 bytes
241 	 * of data.
242 	 *
243 	 * To correctly calculate the length we devide the requested len by word and
244 	 * round up.
245 	 * On the ack function we can skip the odd check as we already handle the
246 	 * case here.
247 	 */
248 	real_len = DIV_ROUND_UP(len, sizeof(u16));
249 
250 	/* We check if the result len is odd and we round up another time to
251 	 * the next size. (length of 3 will be increased to 4 as switch will always
252 	 * return 8 bytes)
253 	 */
254 	if (real_len % sizeof(u16) != 0)
255 		real_len++;
256 
257 	/* Max reg value is 0xf(15) but switch will always return the next size (32 byte) */
258 	if (real_len == 16)
259 		real_len--;
260 
261 	skb_reset_mac_header(skb);
262 	skb_set_network_header(skb, skb->len);
263 
264 	mgmt_ethhdr = skb_push(skb, QCA_HDR_MGMT_HEADER_LEN + QCA_HDR_LEN);
265 
266 	hdr = FIELD_PREP(QCA_HDR_XMIT_VERSION, QCA_HDR_VERSION);
267 	hdr |= FIELD_PREP(QCA_HDR_XMIT_PRIORITY, priority);
268 	hdr |= QCA_HDR_XMIT_FROM_CPU;
269 	hdr |= FIELD_PREP(QCA_HDR_XMIT_DP_BIT, BIT(0));
270 	hdr |= FIELD_PREP(QCA_HDR_XMIT_CONTROL, QCA_HDR_XMIT_TYPE_RW_REG);
271 
272 	command = FIELD_PREP(QCA_HDR_MGMT_ADDR, reg);
273 	command |= FIELD_PREP(QCA_HDR_MGMT_LENGTH, real_len);
274 	command |= FIELD_PREP(QCA_HDR_MGMT_CMD, cmd);
275 	command |= FIELD_PREP(QCA_HDR_MGMT_CHECK_CODE,
276 					   QCA_HDR_MGMT_CHECK_CODE_VAL);
277 
278 	put_unaligned_le32(command, &mgmt_ethhdr->command);
279 
280 	if (cmd == MDIO_WRITE)
281 		put_unaligned_le32(*val, &mgmt_ethhdr->mdio_data);
282 
283 	mgmt_ethhdr->hdr = htons(hdr);
284 
285 	data2 = skb_put_zero(skb, QCA_HDR_MGMT_DATA2_LEN + QCA_HDR_MGMT_PADDING_LEN);
286 	if (cmd == MDIO_WRITE && len > QCA_HDR_MGMT_DATA1_LEN) {
287 		int data_len = min_t(int, QCA_HDR_MGMT_DATA2_LEN,
288 				     len - QCA_HDR_MGMT_DATA1_LEN);
289 
290 		val++;
291 
292 		for (i = sizeof(u32); i <= data_len; i += sizeof(u32)) {
293 			put_unaligned_le32(*val, data2);
294 			data2++;
295 			val++;
296 		}
297 	}
298 
299 	return skb;
300 }
301 
302 static void qca8k_mdio_header_fill_seq_num(struct sk_buff *skb, u32 seq_num)
303 {
304 	struct qca_mgmt_ethhdr *mgmt_ethhdr;
305 	u32 seq;
306 
307 	seq = FIELD_PREP(QCA_HDR_MGMT_SEQ_NUM, seq_num);
308 	mgmt_ethhdr = (struct qca_mgmt_ethhdr *)skb->data;
309 	put_unaligned_le32(seq, &mgmt_ethhdr->seq);
310 }
311 
312 static int qca8k_read_eth(struct qca8k_priv *priv, u32 reg, u32 *val, int len)
313 {
314 	struct qca8k_mgmt_eth_data *mgmt_eth_data = &priv->mgmt_eth_data;
315 	struct sk_buff *skb;
316 	bool ack;
317 	int ret;
318 
319 	skb = qca8k_alloc_mdio_header(MDIO_READ, reg, NULL,
320 				      QCA8K_ETHERNET_MDIO_PRIORITY, len);
321 	if (!skb)
322 		return -ENOMEM;
323 
324 	mutex_lock(&mgmt_eth_data->mutex);
325 
326 	/* Check mgmt_master if is operational */
327 	if (!priv->mgmt_master) {
328 		kfree_skb(skb);
329 		mutex_unlock(&mgmt_eth_data->mutex);
330 		return -EINVAL;
331 	}
332 
333 	skb->dev = priv->mgmt_master;
334 
335 	reinit_completion(&mgmt_eth_data->rw_done);
336 
337 	/* Increment seq_num and set it in the mdio pkt */
338 	mgmt_eth_data->seq++;
339 	qca8k_mdio_header_fill_seq_num(skb, mgmt_eth_data->seq);
340 	mgmt_eth_data->ack = false;
341 
342 	dev_queue_xmit(skb);
343 
344 	ret = wait_for_completion_timeout(&mgmt_eth_data->rw_done,
345 					  msecs_to_jiffies(QCA8K_ETHERNET_TIMEOUT));
346 
347 	*val = mgmt_eth_data->data[0];
348 	if (len > QCA_HDR_MGMT_DATA1_LEN)
349 		memcpy(val + 1, mgmt_eth_data->data + 1, len - QCA_HDR_MGMT_DATA1_LEN);
350 
351 	ack = mgmt_eth_data->ack;
352 
353 	mutex_unlock(&mgmt_eth_data->mutex);
354 
355 	if (ret <= 0)
356 		return -ETIMEDOUT;
357 
358 	if (!ack)
359 		return -EINVAL;
360 
361 	return 0;
362 }
363 
364 static int qca8k_write_eth(struct qca8k_priv *priv, u32 reg, u32 *val, int len)
365 {
366 	struct qca8k_mgmt_eth_data *mgmt_eth_data = &priv->mgmt_eth_data;
367 	struct sk_buff *skb;
368 	bool ack;
369 	int ret;
370 
371 	skb = qca8k_alloc_mdio_header(MDIO_WRITE, reg, val,
372 				      QCA8K_ETHERNET_MDIO_PRIORITY, len);
373 	if (!skb)
374 		return -ENOMEM;
375 
376 	mutex_lock(&mgmt_eth_data->mutex);
377 
378 	/* Check mgmt_master if is operational */
379 	if (!priv->mgmt_master) {
380 		kfree_skb(skb);
381 		mutex_unlock(&mgmt_eth_data->mutex);
382 		return -EINVAL;
383 	}
384 
385 	skb->dev = priv->mgmt_master;
386 
387 	reinit_completion(&mgmt_eth_data->rw_done);
388 
389 	/* Increment seq_num and set it in the mdio pkt */
390 	mgmt_eth_data->seq++;
391 	qca8k_mdio_header_fill_seq_num(skb, mgmt_eth_data->seq);
392 	mgmt_eth_data->ack = false;
393 
394 	dev_queue_xmit(skb);
395 
396 	ret = wait_for_completion_timeout(&mgmt_eth_data->rw_done,
397 					  msecs_to_jiffies(QCA8K_ETHERNET_TIMEOUT));
398 
399 	ack = mgmt_eth_data->ack;
400 
401 	mutex_unlock(&mgmt_eth_data->mutex);
402 
403 	if (ret <= 0)
404 		return -ETIMEDOUT;
405 
406 	if (!ack)
407 		return -EINVAL;
408 
409 	return 0;
410 }
411 
412 static int
413 qca8k_regmap_update_bits_eth(struct qca8k_priv *priv, u32 reg, u32 mask, u32 write_val)
414 {
415 	u32 val = 0;
416 	int ret;
417 
418 	ret = qca8k_read_eth(priv, reg, &val, sizeof(val));
419 	if (ret)
420 		return ret;
421 
422 	val &= ~mask;
423 	val |= write_val;
424 
425 	return qca8k_write_eth(priv, reg, &val, sizeof(val));
426 }
427 
428 static int
429 qca8k_read_mii(struct qca8k_priv *priv, uint32_t reg, uint32_t *val)
430 {
431 	struct mii_bus *bus = priv->bus;
432 	u16 r1, r2, page;
433 	int ret;
434 
435 	qca8k_split_addr(reg, &r1, &r2, &page);
436 
437 	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
438 
439 	ret = qca8k_set_page(priv, page);
440 	if (ret < 0)
441 		goto exit;
442 
443 	ret = qca8k_mii_read32(bus, 0x10 | r2, r1, val);
444 
445 exit:
446 	mutex_unlock(&bus->mdio_lock);
447 	return ret;
448 }
449 
450 static int
451 qca8k_write_mii(struct qca8k_priv *priv, uint32_t reg, uint32_t val)
452 {
453 	struct mii_bus *bus = priv->bus;
454 	u16 r1, r2, page;
455 	int ret;
456 
457 	qca8k_split_addr(reg, &r1, &r2, &page);
458 
459 	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
460 
461 	ret = qca8k_set_page(priv, page);
462 	if (ret < 0)
463 		goto exit;
464 
465 	qca8k_mii_write32(bus, 0x10 | r2, r1, val);
466 
467 exit:
468 	mutex_unlock(&bus->mdio_lock);
469 	return ret;
470 }
471 
472 static int
473 qca8k_regmap_update_bits_mii(struct qca8k_priv *priv, uint32_t reg,
474 			     uint32_t mask, uint32_t write_val)
475 {
476 	struct mii_bus *bus = priv->bus;
477 	u16 r1, r2, page;
478 	u32 val;
479 	int ret;
480 
481 	qca8k_split_addr(reg, &r1, &r2, &page);
482 
483 	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
484 
485 	ret = qca8k_set_page(priv, page);
486 	if (ret < 0)
487 		goto exit;
488 
489 	ret = qca8k_mii_read32(bus, 0x10 | r2, r1, &val);
490 	if (ret < 0)
491 		goto exit;
492 
493 	val &= ~mask;
494 	val |= write_val;
495 	qca8k_mii_write32(bus, 0x10 | r2, r1, val);
496 
497 exit:
498 	mutex_unlock(&bus->mdio_lock);
499 
500 	return ret;
501 }
502 
503 static int
504 qca8k_bulk_read(void *ctx, const void *reg_buf, size_t reg_len,
505 		void *val_buf, size_t val_len)
506 {
507 	int i, count = val_len / sizeof(u32), ret;
508 	u32 reg = *(u32 *)reg_buf & U16_MAX;
509 	struct qca8k_priv *priv = ctx;
510 
511 	if (priv->mgmt_master &&
512 	    !qca8k_read_eth(priv, reg, val_buf, val_len))
513 		return 0;
514 
515 	/* loop count times and increment reg of 4 */
516 	for (i = 0; i < count; i++, reg += sizeof(u32)) {
517 		ret = qca8k_read_mii(priv, reg, val_buf + i);
518 		if (ret < 0)
519 			return ret;
520 	}
521 
522 	return 0;
523 }
524 
525 static int
526 qca8k_bulk_gather_write(void *ctx, const void *reg_buf, size_t reg_len,
527 			const void *val_buf, size_t val_len)
528 {
529 	int i, count = val_len / sizeof(u32), ret;
530 	u32 reg = *(u32 *)reg_buf & U16_MAX;
531 	struct qca8k_priv *priv = ctx;
532 	u32 *val = (u32 *)val_buf;
533 
534 	if (priv->mgmt_master &&
535 	    !qca8k_write_eth(priv, reg, val, val_len))
536 		return 0;
537 
538 	/* loop count times, increment reg of 4 and increment val ptr to
539 	 * the next value
540 	 */
541 	for (i = 0; i < count; i++, reg += sizeof(u32), val++) {
542 		ret = qca8k_write_mii(priv, reg, *val);
543 		if (ret < 0)
544 			return ret;
545 	}
546 
547 	return 0;
548 }
549 
550 static int
551 qca8k_bulk_write(void *ctx, const void *data, size_t bytes)
552 {
553 	return qca8k_bulk_gather_write(ctx, data, sizeof(u16), data + sizeof(u16),
554 				       bytes - sizeof(u16));
555 }
556 
557 static int
558 qca8k_regmap_update_bits(void *ctx, uint32_t reg, uint32_t mask, uint32_t write_val)
559 {
560 	struct qca8k_priv *priv = ctx;
561 
562 	if (!qca8k_regmap_update_bits_eth(priv, reg, mask, write_val))
563 		return 0;
564 
565 	return qca8k_regmap_update_bits_mii(priv, reg, mask, write_val);
566 }
567 
568 static struct regmap_config qca8k_regmap_config = {
569 	.reg_bits = 16,
570 	.val_bits = 32,
571 	.reg_stride = 4,
572 	.max_register = 0x16ac, /* end MIB - Port6 range */
573 	.read = qca8k_bulk_read,
574 	.write = qca8k_bulk_write,
575 	.reg_update_bits = qca8k_regmap_update_bits,
576 	.rd_table = &qca8k_readable_table,
577 	.disable_locking = true, /* Locking is handled by qca8k read/write */
578 	.cache_type = REGCACHE_NONE, /* Explicitly disable CACHE */
579 	.max_raw_read = 32, /* mgmt eth can read up to 8 registers at time */
580 	/* ATU regs suffer from a bug where some data are not correctly
581 	 * written. Disable bulk write to correctly write ATU entry.
582 	 */
583 	.use_single_write = true,
584 };
585 
586 static int
587 qca8k_phy_eth_busy_wait(struct qca8k_mgmt_eth_data *mgmt_eth_data,
588 			struct sk_buff *read_skb, u32 *val)
589 {
590 	struct sk_buff *skb = skb_copy(read_skb, GFP_KERNEL);
591 	bool ack;
592 	int ret;
593 
594 	if (!skb)
595 		return -ENOMEM;
596 
597 	reinit_completion(&mgmt_eth_data->rw_done);
598 
599 	/* Increment seq_num and set it in the copy pkt */
600 	mgmt_eth_data->seq++;
601 	qca8k_mdio_header_fill_seq_num(skb, mgmt_eth_data->seq);
602 	mgmt_eth_data->ack = false;
603 
604 	dev_queue_xmit(skb);
605 
606 	ret = wait_for_completion_timeout(&mgmt_eth_data->rw_done,
607 					  QCA8K_ETHERNET_TIMEOUT);
608 
609 	ack = mgmt_eth_data->ack;
610 
611 	if (ret <= 0)
612 		return -ETIMEDOUT;
613 
614 	if (!ack)
615 		return -EINVAL;
616 
617 	*val = mgmt_eth_data->data[0];
618 
619 	return 0;
620 }
621 
622 static int
623 qca8k_phy_eth_command(struct qca8k_priv *priv, bool read, int phy,
624 		      int regnum, u16 data)
625 {
626 	struct sk_buff *write_skb, *clear_skb, *read_skb;
627 	struct qca8k_mgmt_eth_data *mgmt_eth_data;
628 	u32 write_val, clear_val = 0, val;
629 	struct net_device *mgmt_master;
630 	int ret, ret1;
631 	bool ack;
632 
633 	if (regnum >= QCA8K_MDIO_MASTER_MAX_REG)
634 		return -EINVAL;
635 
636 	mgmt_eth_data = &priv->mgmt_eth_data;
637 
638 	write_val = QCA8K_MDIO_MASTER_BUSY | QCA8K_MDIO_MASTER_EN |
639 		    QCA8K_MDIO_MASTER_PHY_ADDR(phy) |
640 		    QCA8K_MDIO_MASTER_REG_ADDR(regnum);
641 
642 	if (read) {
643 		write_val |= QCA8K_MDIO_MASTER_READ;
644 	} else {
645 		write_val |= QCA8K_MDIO_MASTER_WRITE;
646 		write_val |= QCA8K_MDIO_MASTER_DATA(data);
647 	}
648 
649 	/* Prealloc all the needed skb before the lock */
650 	write_skb = qca8k_alloc_mdio_header(MDIO_WRITE, QCA8K_MDIO_MASTER_CTRL, &write_val,
651 					    QCA8K_ETHERNET_PHY_PRIORITY, sizeof(write_val));
652 	if (!write_skb)
653 		return -ENOMEM;
654 
655 	clear_skb = qca8k_alloc_mdio_header(MDIO_WRITE, QCA8K_MDIO_MASTER_CTRL, &clear_val,
656 					    QCA8K_ETHERNET_PHY_PRIORITY, sizeof(clear_val));
657 	if (!clear_skb) {
658 		ret = -ENOMEM;
659 		goto err_clear_skb;
660 	}
661 
662 	read_skb = qca8k_alloc_mdio_header(MDIO_READ, QCA8K_MDIO_MASTER_CTRL, &clear_val,
663 					   QCA8K_ETHERNET_PHY_PRIORITY, sizeof(clear_val));
664 	if (!read_skb) {
665 		ret = -ENOMEM;
666 		goto err_read_skb;
667 	}
668 
669 	/* Actually start the request:
670 	 * 1. Send mdio master packet
671 	 * 2. Busy Wait for mdio master command
672 	 * 3. Get the data if we are reading
673 	 * 4. Reset the mdio master (even with error)
674 	 */
675 	mutex_lock(&mgmt_eth_data->mutex);
676 
677 	/* Check if mgmt_master is operational */
678 	mgmt_master = priv->mgmt_master;
679 	if (!mgmt_master) {
680 		mutex_unlock(&mgmt_eth_data->mutex);
681 		ret = -EINVAL;
682 		goto err_mgmt_master;
683 	}
684 
685 	read_skb->dev = mgmt_master;
686 	clear_skb->dev = mgmt_master;
687 	write_skb->dev = mgmt_master;
688 
689 	reinit_completion(&mgmt_eth_data->rw_done);
690 
691 	/* Increment seq_num and set it in the write pkt */
692 	mgmt_eth_data->seq++;
693 	qca8k_mdio_header_fill_seq_num(write_skb, mgmt_eth_data->seq);
694 	mgmt_eth_data->ack = false;
695 
696 	dev_queue_xmit(write_skb);
697 
698 	ret = wait_for_completion_timeout(&mgmt_eth_data->rw_done,
699 					  QCA8K_ETHERNET_TIMEOUT);
700 
701 	ack = mgmt_eth_data->ack;
702 
703 	if (ret <= 0) {
704 		ret = -ETIMEDOUT;
705 		kfree_skb(read_skb);
706 		goto exit;
707 	}
708 
709 	if (!ack) {
710 		ret = -EINVAL;
711 		kfree_skb(read_skb);
712 		goto exit;
713 	}
714 
715 	ret = read_poll_timeout(qca8k_phy_eth_busy_wait, ret1,
716 				!(val & QCA8K_MDIO_MASTER_BUSY), 0,
717 				QCA8K_BUSY_WAIT_TIMEOUT * USEC_PER_MSEC, false,
718 				mgmt_eth_data, read_skb, &val);
719 
720 	if (ret < 0 && ret1 < 0) {
721 		ret = ret1;
722 		goto exit;
723 	}
724 
725 	if (read) {
726 		reinit_completion(&mgmt_eth_data->rw_done);
727 
728 		/* Increment seq_num and set it in the read pkt */
729 		mgmt_eth_data->seq++;
730 		qca8k_mdio_header_fill_seq_num(read_skb, mgmt_eth_data->seq);
731 		mgmt_eth_data->ack = false;
732 
733 		dev_queue_xmit(read_skb);
734 
735 		ret = wait_for_completion_timeout(&mgmt_eth_data->rw_done,
736 						  QCA8K_ETHERNET_TIMEOUT);
737 
738 		ack = mgmt_eth_data->ack;
739 
740 		if (ret <= 0) {
741 			ret = -ETIMEDOUT;
742 			goto exit;
743 		}
744 
745 		if (!ack) {
746 			ret = -EINVAL;
747 			goto exit;
748 		}
749 
750 		ret = mgmt_eth_data->data[0] & QCA8K_MDIO_MASTER_DATA_MASK;
751 	} else {
752 		kfree_skb(read_skb);
753 	}
754 exit:
755 	reinit_completion(&mgmt_eth_data->rw_done);
756 
757 	/* Increment seq_num and set it in the clear pkt */
758 	mgmt_eth_data->seq++;
759 	qca8k_mdio_header_fill_seq_num(clear_skb, mgmt_eth_data->seq);
760 	mgmt_eth_data->ack = false;
761 
762 	dev_queue_xmit(clear_skb);
763 
764 	wait_for_completion_timeout(&mgmt_eth_data->rw_done,
765 				    QCA8K_ETHERNET_TIMEOUT);
766 
767 	mutex_unlock(&mgmt_eth_data->mutex);
768 
769 	return ret;
770 
771 	/* Error handling before lock */
772 err_mgmt_master:
773 	kfree_skb(read_skb);
774 err_read_skb:
775 	kfree_skb(clear_skb);
776 err_clear_skb:
777 	kfree_skb(write_skb);
778 
779 	return ret;
780 }
781 
782 static int
783 qca8k_mdio_busy_wait(struct mii_bus *bus, u32 reg, u32 mask)
784 {
785 	u16 r1, r2, page;
786 	u32 val;
787 	int ret, ret1;
788 
789 	qca8k_split_addr(reg, &r1, &r2, &page);
790 
791 	ret = read_poll_timeout(qca8k_mii_read_hi, ret1, !(val & mask), 0,
792 				QCA8K_BUSY_WAIT_TIMEOUT * USEC_PER_MSEC, false,
793 				bus, 0x10 | r2, r1 + 1, &val);
794 
795 	/* Check if qca8k_read has failed for a different reason
796 	 * before returnting -ETIMEDOUT
797 	 */
798 	if (ret < 0 && ret1 < 0)
799 		return ret1;
800 
801 	return ret;
802 }
803 
804 static int
805 qca8k_mdio_write(struct qca8k_priv *priv, int phy, int regnum, u16 data)
806 {
807 	struct mii_bus *bus = priv->bus;
808 	u16 r1, r2, page;
809 	u32 val;
810 	int ret;
811 
812 	if (regnum >= QCA8K_MDIO_MASTER_MAX_REG)
813 		return -EINVAL;
814 
815 	val = QCA8K_MDIO_MASTER_BUSY | QCA8K_MDIO_MASTER_EN |
816 	      QCA8K_MDIO_MASTER_WRITE | QCA8K_MDIO_MASTER_PHY_ADDR(phy) |
817 	      QCA8K_MDIO_MASTER_REG_ADDR(regnum) |
818 	      QCA8K_MDIO_MASTER_DATA(data);
819 
820 	qca8k_split_addr(QCA8K_MDIO_MASTER_CTRL, &r1, &r2, &page);
821 
822 	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
823 
824 	ret = qca8k_set_page(priv, page);
825 	if (ret)
826 		goto exit;
827 
828 	qca8k_mii_write32(bus, 0x10 | r2, r1, val);
829 
830 	ret = qca8k_mdio_busy_wait(bus, QCA8K_MDIO_MASTER_CTRL,
831 				   QCA8K_MDIO_MASTER_BUSY);
832 
833 exit:
834 	/* even if the busy_wait timeouts try to clear the MASTER_EN */
835 	qca8k_mii_write_hi(bus, 0x10 | r2, r1 + 1, 0);
836 
837 	mutex_unlock(&bus->mdio_lock);
838 
839 	return ret;
840 }
841 
842 static int
843 qca8k_mdio_read(struct qca8k_priv *priv, int phy, int regnum)
844 {
845 	struct mii_bus *bus = priv->bus;
846 	u16 r1, r2, page;
847 	u32 val;
848 	int ret;
849 
850 	if (regnum >= QCA8K_MDIO_MASTER_MAX_REG)
851 		return -EINVAL;
852 
853 	val = QCA8K_MDIO_MASTER_BUSY | QCA8K_MDIO_MASTER_EN |
854 	      QCA8K_MDIO_MASTER_READ | QCA8K_MDIO_MASTER_PHY_ADDR(phy) |
855 	      QCA8K_MDIO_MASTER_REG_ADDR(regnum);
856 
857 	qca8k_split_addr(QCA8K_MDIO_MASTER_CTRL, &r1, &r2, &page);
858 
859 	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
860 
861 	ret = qca8k_set_page(priv, page);
862 	if (ret)
863 		goto exit;
864 
865 	qca8k_mii_write_hi(bus, 0x10 | r2, r1 + 1, val);
866 
867 	ret = qca8k_mdio_busy_wait(bus, QCA8K_MDIO_MASTER_CTRL,
868 				   QCA8K_MDIO_MASTER_BUSY);
869 	if (ret)
870 		goto exit;
871 
872 	ret = qca8k_mii_read_lo(bus, 0x10 | r2, r1, &val);
873 
874 exit:
875 	/* even if the busy_wait timeouts try to clear the MASTER_EN */
876 	qca8k_mii_write_hi(bus, 0x10 | r2, r1 + 1, 0);
877 
878 	mutex_unlock(&bus->mdio_lock);
879 
880 	if (ret >= 0)
881 		ret = val & QCA8K_MDIO_MASTER_DATA_MASK;
882 
883 	return ret;
884 }
885 
886 static int
887 qca8k_internal_mdio_write(struct mii_bus *slave_bus, int phy, int regnum, u16 data)
888 {
889 	struct qca8k_priv *priv = slave_bus->priv;
890 	int ret;
891 
892 	/* Use mdio Ethernet when available, fallback to legacy one on error */
893 	ret = qca8k_phy_eth_command(priv, false, phy, regnum, data);
894 	if (!ret)
895 		return 0;
896 
897 	return qca8k_mdio_write(priv, phy, regnum, data);
898 }
899 
900 static int
901 qca8k_internal_mdio_read(struct mii_bus *slave_bus, int phy, int regnum)
902 {
903 	struct qca8k_priv *priv = slave_bus->priv;
904 	int ret;
905 
906 	/* Use mdio Ethernet when available, fallback to legacy one on error */
907 	ret = qca8k_phy_eth_command(priv, true, phy, regnum, 0);
908 	if (ret >= 0)
909 		return ret;
910 
911 	ret = qca8k_mdio_read(priv, phy, regnum);
912 
913 	if (ret < 0)
914 		return 0xffff;
915 
916 	return ret;
917 }
918 
919 static int
920 qca8k_legacy_mdio_write(struct mii_bus *slave_bus, int port, int regnum, u16 data)
921 {
922 	port = qca8k_port_to_phy(port) % PHY_MAX_ADDR;
923 
924 	return qca8k_internal_mdio_write(slave_bus, port, regnum, data);
925 }
926 
927 static int
928 qca8k_legacy_mdio_read(struct mii_bus *slave_bus, int port, int regnum)
929 {
930 	port = qca8k_port_to_phy(port) % PHY_MAX_ADDR;
931 
932 	return qca8k_internal_mdio_read(slave_bus, port, regnum);
933 }
934 
935 static int
936 qca8k_mdio_register(struct qca8k_priv *priv)
937 {
938 	struct dsa_switch *ds = priv->ds;
939 	struct device_node *mdio;
940 	struct mii_bus *bus;
941 
942 	bus = devm_mdiobus_alloc(ds->dev);
943 	if (!bus)
944 		return -ENOMEM;
945 
946 	bus->priv = (void *)priv;
947 	snprintf(bus->id, MII_BUS_ID_SIZE, "qca8k-%d.%d",
948 		 ds->dst->index, ds->index);
949 	bus->parent = ds->dev;
950 	bus->phy_mask = ~ds->phys_mii_mask;
951 	ds->slave_mii_bus = bus;
952 
953 	/* Check if the devicetree declare the port:phy mapping */
954 	mdio = of_get_child_by_name(priv->dev->of_node, "mdio");
955 	if (of_device_is_available(mdio)) {
956 		bus->name = "qca8k slave mii";
957 		bus->read = qca8k_internal_mdio_read;
958 		bus->write = qca8k_internal_mdio_write;
959 		return devm_of_mdiobus_register(priv->dev, bus, mdio);
960 	}
961 
962 	/* If a mapping can't be found the legacy mapping is used,
963 	 * using the qca8k_port_to_phy function
964 	 */
965 	bus->name = "qca8k-legacy slave mii";
966 	bus->read = qca8k_legacy_mdio_read;
967 	bus->write = qca8k_legacy_mdio_write;
968 	return devm_mdiobus_register(priv->dev, bus);
969 }
970 
971 static int
972 qca8k_setup_mdio_bus(struct qca8k_priv *priv)
973 {
974 	u32 internal_mdio_mask = 0, external_mdio_mask = 0, reg;
975 	struct device_node *ports, *port;
976 	phy_interface_t mode;
977 	int err;
978 
979 	ports = of_get_child_by_name(priv->dev->of_node, "ports");
980 	if (!ports)
981 		ports = of_get_child_by_name(priv->dev->of_node, "ethernet-ports");
982 
983 	if (!ports)
984 		return -EINVAL;
985 
986 	for_each_available_child_of_node(ports, port) {
987 		err = of_property_read_u32(port, "reg", &reg);
988 		if (err) {
989 			of_node_put(port);
990 			of_node_put(ports);
991 			return err;
992 		}
993 
994 		if (!dsa_is_user_port(priv->ds, reg))
995 			continue;
996 
997 		of_get_phy_mode(port, &mode);
998 
999 		if (of_property_read_bool(port, "phy-handle") &&
1000 		    mode != PHY_INTERFACE_MODE_INTERNAL)
1001 			external_mdio_mask |= BIT(reg);
1002 		else
1003 			internal_mdio_mask |= BIT(reg);
1004 	}
1005 
1006 	of_node_put(ports);
1007 	if (!external_mdio_mask && !internal_mdio_mask) {
1008 		dev_err(priv->dev, "no PHYs are defined.\n");
1009 		return -EINVAL;
1010 	}
1011 
1012 	/* The QCA8K_MDIO_MASTER_EN Bit, which grants access to PHYs through
1013 	 * the MDIO_MASTER register also _disconnects_ the external MDC
1014 	 * passthrough to the internal PHYs. It's not possible to use both
1015 	 * configurations at the same time!
1016 	 *
1017 	 * Because this came up during the review process:
1018 	 * If the external mdio-bus driver is capable magically disabling
1019 	 * the QCA8K_MDIO_MASTER_EN and mutex/spin-locking out the qca8k's
1020 	 * accessors for the time being, it would be possible to pull this
1021 	 * off.
1022 	 */
1023 	if (!!external_mdio_mask && !!internal_mdio_mask) {
1024 		dev_err(priv->dev, "either internal or external mdio bus configuration is supported.\n");
1025 		return -EINVAL;
1026 	}
1027 
1028 	if (external_mdio_mask) {
1029 		/* Make sure to disable the internal mdio bus in cases
1030 		 * a dt-overlay and driver reload changed the configuration
1031 		 */
1032 
1033 		return regmap_clear_bits(priv->regmap, QCA8K_MDIO_MASTER_CTRL,
1034 					 QCA8K_MDIO_MASTER_EN);
1035 	}
1036 
1037 	return qca8k_mdio_register(priv);
1038 }
1039 
1040 static int
1041 qca8k_setup_mac_pwr_sel(struct qca8k_priv *priv)
1042 {
1043 	u32 mask = 0;
1044 	int ret = 0;
1045 
1046 	/* SoC specific settings for ipq8064.
1047 	 * If more device require this consider adding
1048 	 * a dedicated binding.
1049 	 */
1050 	if (of_machine_is_compatible("qcom,ipq8064"))
1051 		mask |= QCA8K_MAC_PWR_RGMII0_1_8V;
1052 
1053 	/* SoC specific settings for ipq8065 */
1054 	if (of_machine_is_compatible("qcom,ipq8065"))
1055 		mask |= QCA8K_MAC_PWR_RGMII1_1_8V;
1056 
1057 	if (mask) {
1058 		ret = qca8k_rmw(priv, QCA8K_REG_MAC_PWR_SEL,
1059 				QCA8K_MAC_PWR_RGMII0_1_8V |
1060 				QCA8K_MAC_PWR_RGMII1_1_8V,
1061 				mask);
1062 	}
1063 
1064 	return ret;
1065 }
1066 
1067 static int qca8k_find_cpu_port(struct dsa_switch *ds)
1068 {
1069 	struct qca8k_priv *priv = ds->priv;
1070 
1071 	/* Find the connected cpu port. Valid port are 0 or 6 */
1072 	if (dsa_is_cpu_port(ds, 0))
1073 		return 0;
1074 
1075 	dev_dbg(priv->dev, "port 0 is not the CPU port. Checking port 6");
1076 
1077 	if (dsa_is_cpu_port(ds, 6))
1078 		return 6;
1079 
1080 	return -EINVAL;
1081 }
1082 
1083 static int
1084 qca8k_setup_of_pws_reg(struct qca8k_priv *priv)
1085 {
1086 	const struct qca8k_match_data *data = priv->info;
1087 	struct device_node *node = priv->dev->of_node;
1088 	u32 val = 0;
1089 	int ret;
1090 
1091 	/* QCA8327 require to set to the correct mode.
1092 	 * His bigger brother QCA8328 have the 172 pin layout.
1093 	 * Should be applied by default but we set this just to make sure.
1094 	 */
1095 	if (priv->switch_id == QCA8K_ID_QCA8327) {
1096 		/* Set the correct package of 148 pin for QCA8327 */
1097 		if (data->reduced_package)
1098 			val |= QCA8327_PWS_PACKAGE148_EN;
1099 
1100 		ret = qca8k_rmw(priv, QCA8K_REG_PWS, QCA8327_PWS_PACKAGE148_EN,
1101 				val);
1102 		if (ret)
1103 			return ret;
1104 	}
1105 
1106 	if (of_property_read_bool(node, "qca,ignore-power-on-sel"))
1107 		val |= QCA8K_PWS_POWER_ON_SEL;
1108 
1109 	if (of_property_read_bool(node, "qca,led-open-drain")) {
1110 		if (!(val & QCA8K_PWS_POWER_ON_SEL)) {
1111 			dev_err(priv->dev, "qca,led-open-drain require qca,ignore-power-on-sel to be set.");
1112 			return -EINVAL;
1113 		}
1114 
1115 		val |= QCA8K_PWS_LED_OPEN_EN_CSR;
1116 	}
1117 
1118 	return qca8k_rmw(priv, QCA8K_REG_PWS,
1119 			QCA8K_PWS_LED_OPEN_EN_CSR | QCA8K_PWS_POWER_ON_SEL,
1120 			val);
1121 }
1122 
1123 static int
1124 qca8k_parse_port_config(struct qca8k_priv *priv)
1125 {
1126 	int port, cpu_port_index = -1, ret;
1127 	struct device_node *port_dn;
1128 	phy_interface_t mode;
1129 	struct dsa_port *dp;
1130 	u32 delay;
1131 
1132 	/* We have 2 CPU port. Check them */
1133 	for (port = 0; port < QCA8K_NUM_PORTS; port++) {
1134 		/* Skip every other port */
1135 		if (port != 0 && port != 6)
1136 			continue;
1137 
1138 		dp = dsa_to_port(priv->ds, port);
1139 		port_dn = dp->dn;
1140 		cpu_port_index++;
1141 
1142 		if (!of_device_is_available(port_dn))
1143 			continue;
1144 
1145 		ret = of_get_phy_mode(port_dn, &mode);
1146 		if (ret)
1147 			continue;
1148 
1149 		switch (mode) {
1150 		case PHY_INTERFACE_MODE_RGMII:
1151 		case PHY_INTERFACE_MODE_RGMII_ID:
1152 		case PHY_INTERFACE_MODE_RGMII_TXID:
1153 		case PHY_INTERFACE_MODE_RGMII_RXID:
1154 		case PHY_INTERFACE_MODE_SGMII:
1155 			delay = 0;
1156 
1157 			if (!of_property_read_u32(port_dn, "tx-internal-delay-ps", &delay))
1158 				/* Switch regs accept value in ns, convert ps to ns */
1159 				delay = delay / 1000;
1160 			else if (mode == PHY_INTERFACE_MODE_RGMII_ID ||
1161 				 mode == PHY_INTERFACE_MODE_RGMII_TXID)
1162 				delay = 1;
1163 
1164 			if (!FIELD_FIT(QCA8K_PORT_PAD_RGMII_TX_DELAY_MASK, delay)) {
1165 				dev_err(priv->dev, "rgmii tx delay is limited to a max value of 3ns, setting to the max value");
1166 				delay = 3;
1167 			}
1168 
1169 			priv->ports_config.rgmii_tx_delay[cpu_port_index] = delay;
1170 
1171 			delay = 0;
1172 
1173 			if (!of_property_read_u32(port_dn, "rx-internal-delay-ps", &delay))
1174 				/* Switch regs accept value in ns, convert ps to ns */
1175 				delay = delay / 1000;
1176 			else if (mode == PHY_INTERFACE_MODE_RGMII_ID ||
1177 				 mode == PHY_INTERFACE_MODE_RGMII_RXID)
1178 				delay = 2;
1179 
1180 			if (!FIELD_FIT(QCA8K_PORT_PAD_RGMII_RX_DELAY_MASK, delay)) {
1181 				dev_err(priv->dev, "rgmii rx delay is limited to a max value of 3ns, setting to the max value");
1182 				delay = 3;
1183 			}
1184 
1185 			priv->ports_config.rgmii_rx_delay[cpu_port_index] = delay;
1186 
1187 			/* Skip sgmii parsing for rgmii* mode */
1188 			if (mode == PHY_INTERFACE_MODE_RGMII ||
1189 			    mode == PHY_INTERFACE_MODE_RGMII_ID ||
1190 			    mode == PHY_INTERFACE_MODE_RGMII_TXID ||
1191 			    mode == PHY_INTERFACE_MODE_RGMII_RXID)
1192 				break;
1193 
1194 			if (of_property_read_bool(port_dn, "qca,sgmii-txclk-falling-edge"))
1195 				priv->ports_config.sgmii_tx_clk_falling_edge = true;
1196 
1197 			if (of_property_read_bool(port_dn, "qca,sgmii-rxclk-falling-edge"))
1198 				priv->ports_config.sgmii_rx_clk_falling_edge = true;
1199 
1200 			if (of_property_read_bool(port_dn, "qca,sgmii-enable-pll")) {
1201 				priv->ports_config.sgmii_enable_pll = true;
1202 
1203 				if (priv->switch_id == QCA8K_ID_QCA8327) {
1204 					dev_err(priv->dev, "SGMII PLL should NOT be enabled for qca8327. Aborting enabling");
1205 					priv->ports_config.sgmii_enable_pll = false;
1206 				}
1207 
1208 				if (priv->switch_revision < 2)
1209 					dev_warn(priv->dev, "SGMII PLL should NOT be enabled for qca8337 with revision 2 or more.");
1210 			}
1211 
1212 			break;
1213 		default:
1214 			continue;
1215 		}
1216 	}
1217 
1218 	return 0;
1219 }
1220 
1221 static void
1222 qca8k_mac_config_setup_internal_delay(struct qca8k_priv *priv, int cpu_port_index,
1223 				      u32 reg)
1224 {
1225 	u32 delay, val = 0;
1226 	int ret;
1227 
1228 	/* Delay can be declared in 3 different way.
1229 	 * Mode to rgmii and internal-delay standard binding defined
1230 	 * rgmii-id or rgmii-tx/rx phy mode set.
1231 	 * The parse logic set a delay different than 0 only when one
1232 	 * of the 3 different way is used. In all other case delay is
1233 	 * not enabled. With ID or TX/RXID delay is enabled and set
1234 	 * to the default and recommended value.
1235 	 */
1236 	if (priv->ports_config.rgmii_tx_delay[cpu_port_index]) {
1237 		delay = priv->ports_config.rgmii_tx_delay[cpu_port_index];
1238 
1239 		val |= QCA8K_PORT_PAD_RGMII_TX_DELAY(delay) |
1240 			QCA8K_PORT_PAD_RGMII_TX_DELAY_EN;
1241 	}
1242 
1243 	if (priv->ports_config.rgmii_rx_delay[cpu_port_index]) {
1244 		delay = priv->ports_config.rgmii_rx_delay[cpu_port_index];
1245 
1246 		val |= QCA8K_PORT_PAD_RGMII_RX_DELAY(delay) |
1247 			QCA8K_PORT_PAD_RGMII_RX_DELAY_EN;
1248 	}
1249 
1250 	/* Set RGMII delay based on the selected values */
1251 	ret = qca8k_rmw(priv, reg,
1252 			QCA8K_PORT_PAD_RGMII_TX_DELAY_MASK |
1253 			QCA8K_PORT_PAD_RGMII_RX_DELAY_MASK |
1254 			QCA8K_PORT_PAD_RGMII_TX_DELAY_EN |
1255 			QCA8K_PORT_PAD_RGMII_RX_DELAY_EN,
1256 			val);
1257 	if (ret)
1258 		dev_err(priv->dev, "Failed to set internal delay for CPU port%d",
1259 			cpu_port_index == QCA8K_CPU_PORT0 ? 0 : 6);
1260 }
1261 
1262 static struct phylink_pcs *
1263 qca8k_phylink_mac_select_pcs(struct dsa_switch *ds, int port,
1264 			     phy_interface_t interface)
1265 {
1266 	struct qca8k_priv *priv = ds->priv;
1267 	struct phylink_pcs *pcs = NULL;
1268 
1269 	switch (interface) {
1270 	case PHY_INTERFACE_MODE_SGMII:
1271 	case PHY_INTERFACE_MODE_1000BASEX:
1272 		switch (port) {
1273 		case 0:
1274 			pcs = &priv->pcs_port_0.pcs;
1275 			break;
1276 
1277 		case 6:
1278 			pcs = &priv->pcs_port_6.pcs;
1279 			break;
1280 		}
1281 		break;
1282 
1283 	default:
1284 		break;
1285 	}
1286 
1287 	return pcs;
1288 }
1289 
1290 static void
1291 qca8k_phylink_mac_config(struct dsa_switch *ds, int port, unsigned int mode,
1292 			 const struct phylink_link_state *state)
1293 {
1294 	struct qca8k_priv *priv = ds->priv;
1295 	int cpu_port_index;
1296 	u32 reg;
1297 
1298 	switch (port) {
1299 	case 0: /* 1st CPU port */
1300 		if (state->interface != PHY_INTERFACE_MODE_RGMII &&
1301 		    state->interface != PHY_INTERFACE_MODE_RGMII_ID &&
1302 		    state->interface != PHY_INTERFACE_MODE_RGMII_TXID &&
1303 		    state->interface != PHY_INTERFACE_MODE_RGMII_RXID &&
1304 		    state->interface != PHY_INTERFACE_MODE_SGMII)
1305 			return;
1306 
1307 		reg = QCA8K_REG_PORT0_PAD_CTRL;
1308 		cpu_port_index = QCA8K_CPU_PORT0;
1309 		break;
1310 	case 1:
1311 	case 2:
1312 	case 3:
1313 	case 4:
1314 	case 5:
1315 		/* Internal PHY, nothing to do */
1316 		return;
1317 	case 6: /* 2nd CPU port / external PHY */
1318 		if (state->interface != PHY_INTERFACE_MODE_RGMII &&
1319 		    state->interface != PHY_INTERFACE_MODE_RGMII_ID &&
1320 		    state->interface != PHY_INTERFACE_MODE_RGMII_TXID &&
1321 		    state->interface != PHY_INTERFACE_MODE_RGMII_RXID &&
1322 		    state->interface != PHY_INTERFACE_MODE_SGMII &&
1323 		    state->interface != PHY_INTERFACE_MODE_1000BASEX)
1324 			return;
1325 
1326 		reg = QCA8K_REG_PORT6_PAD_CTRL;
1327 		cpu_port_index = QCA8K_CPU_PORT6;
1328 		break;
1329 	default:
1330 		dev_err(ds->dev, "%s: unsupported port: %i\n", __func__, port);
1331 		return;
1332 	}
1333 
1334 	if (port != 6 && phylink_autoneg_inband(mode)) {
1335 		dev_err(ds->dev, "%s: in-band negotiation unsupported\n",
1336 			__func__);
1337 		return;
1338 	}
1339 
1340 	switch (state->interface) {
1341 	case PHY_INTERFACE_MODE_RGMII:
1342 	case PHY_INTERFACE_MODE_RGMII_ID:
1343 	case PHY_INTERFACE_MODE_RGMII_TXID:
1344 	case PHY_INTERFACE_MODE_RGMII_RXID:
1345 		qca8k_write(priv, reg, QCA8K_PORT_PAD_RGMII_EN);
1346 
1347 		/* Configure rgmii delay */
1348 		qca8k_mac_config_setup_internal_delay(priv, cpu_port_index, reg);
1349 
1350 		/* QCA8337 requires to set rgmii rx delay for all ports.
1351 		 * This is enabled through PORT5_PAD_CTRL for all ports,
1352 		 * rather than individual port registers.
1353 		 */
1354 		if (priv->switch_id == QCA8K_ID_QCA8337)
1355 			qca8k_write(priv, QCA8K_REG_PORT5_PAD_CTRL,
1356 				    QCA8K_PORT_PAD_RGMII_RX_DELAY_EN);
1357 		break;
1358 	case PHY_INTERFACE_MODE_SGMII:
1359 	case PHY_INTERFACE_MODE_1000BASEX:
1360 		/* Enable SGMII on the port */
1361 		qca8k_write(priv, reg, QCA8K_PORT_PAD_SGMII_EN);
1362 		break;
1363 	default:
1364 		dev_err(ds->dev, "xMII mode %s not supported for port %d\n",
1365 			phy_modes(state->interface), port);
1366 		return;
1367 	}
1368 }
1369 
1370 static void qca8k_phylink_get_caps(struct dsa_switch *ds, int port,
1371 				   struct phylink_config *config)
1372 {
1373 	switch (port) {
1374 	case 0: /* 1st CPU port */
1375 		phy_interface_set_rgmii(config->supported_interfaces);
1376 		__set_bit(PHY_INTERFACE_MODE_SGMII,
1377 			  config->supported_interfaces);
1378 		break;
1379 
1380 	case 1:
1381 	case 2:
1382 	case 3:
1383 	case 4:
1384 	case 5:
1385 		/* Internal PHY */
1386 		__set_bit(PHY_INTERFACE_MODE_GMII,
1387 			  config->supported_interfaces);
1388 		__set_bit(PHY_INTERFACE_MODE_INTERNAL,
1389 			  config->supported_interfaces);
1390 		break;
1391 
1392 	case 6: /* 2nd CPU port / external PHY */
1393 		phy_interface_set_rgmii(config->supported_interfaces);
1394 		__set_bit(PHY_INTERFACE_MODE_SGMII,
1395 			  config->supported_interfaces);
1396 		__set_bit(PHY_INTERFACE_MODE_1000BASEX,
1397 			  config->supported_interfaces);
1398 		break;
1399 	}
1400 
1401 	config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
1402 		MAC_10 | MAC_100 | MAC_1000FD;
1403 }
1404 
1405 static void
1406 qca8k_phylink_mac_link_down(struct dsa_switch *ds, int port, unsigned int mode,
1407 			    phy_interface_t interface)
1408 {
1409 	struct qca8k_priv *priv = ds->priv;
1410 
1411 	qca8k_port_set_status(priv, port, 0);
1412 }
1413 
1414 static void
1415 qca8k_phylink_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode,
1416 			  phy_interface_t interface, struct phy_device *phydev,
1417 			  int speed, int duplex, bool tx_pause, bool rx_pause)
1418 {
1419 	struct qca8k_priv *priv = ds->priv;
1420 	u32 reg;
1421 
1422 	if (phylink_autoneg_inband(mode)) {
1423 		reg = QCA8K_PORT_STATUS_LINK_AUTO;
1424 	} else {
1425 		switch (speed) {
1426 		case SPEED_10:
1427 			reg = QCA8K_PORT_STATUS_SPEED_10;
1428 			break;
1429 		case SPEED_100:
1430 			reg = QCA8K_PORT_STATUS_SPEED_100;
1431 			break;
1432 		case SPEED_1000:
1433 			reg = QCA8K_PORT_STATUS_SPEED_1000;
1434 			break;
1435 		default:
1436 			reg = QCA8K_PORT_STATUS_LINK_AUTO;
1437 			break;
1438 		}
1439 
1440 		if (duplex == DUPLEX_FULL)
1441 			reg |= QCA8K_PORT_STATUS_DUPLEX;
1442 
1443 		if (rx_pause || dsa_is_cpu_port(ds, port))
1444 			reg |= QCA8K_PORT_STATUS_RXFLOW;
1445 
1446 		if (tx_pause || dsa_is_cpu_port(ds, port))
1447 			reg |= QCA8K_PORT_STATUS_TXFLOW;
1448 	}
1449 
1450 	reg |= QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC;
1451 
1452 	qca8k_write(priv, QCA8K_REG_PORT_STATUS(port), reg);
1453 }
1454 
1455 static struct qca8k_pcs *pcs_to_qca8k_pcs(struct phylink_pcs *pcs)
1456 {
1457 	return container_of(pcs, struct qca8k_pcs, pcs);
1458 }
1459 
1460 static void qca8k_pcs_get_state(struct phylink_pcs *pcs,
1461 				struct phylink_link_state *state)
1462 {
1463 	struct qca8k_priv *priv = pcs_to_qca8k_pcs(pcs)->priv;
1464 	int port = pcs_to_qca8k_pcs(pcs)->port;
1465 	u32 reg;
1466 	int ret;
1467 
1468 	ret = qca8k_read(priv, QCA8K_REG_PORT_STATUS(port), &reg);
1469 	if (ret < 0) {
1470 		state->link = false;
1471 		return;
1472 	}
1473 
1474 	state->link = !!(reg & QCA8K_PORT_STATUS_LINK_UP);
1475 	state->an_complete = state->link;
1476 	state->duplex = (reg & QCA8K_PORT_STATUS_DUPLEX) ? DUPLEX_FULL :
1477 							   DUPLEX_HALF;
1478 
1479 	switch (reg & QCA8K_PORT_STATUS_SPEED) {
1480 	case QCA8K_PORT_STATUS_SPEED_10:
1481 		state->speed = SPEED_10;
1482 		break;
1483 	case QCA8K_PORT_STATUS_SPEED_100:
1484 		state->speed = SPEED_100;
1485 		break;
1486 	case QCA8K_PORT_STATUS_SPEED_1000:
1487 		state->speed = SPEED_1000;
1488 		break;
1489 	default:
1490 		state->speed = SPEED_UNKNOWN;
1491 		break;
1492 	}
1493 
1494 	if (reg & QCA8K_PORT_STATUS_RXFLOW)
1495 		state->pause |= MLO_PAUSE_RX;
1496 	if (reg & QCA8K_PORT_STATUS_TXFLOW)
1497 		state->pause |= MLO_PAUSE_TX;
1498 }
1499 
1500 static int qca8k_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode,
1501 			    phy_interface_t interface,
1502 			    const unsigned long *advertising,
1503 			    bool permit_pause_to_mac)
1504 {
1505 	struct qca8k_priv *priv = pcs_to_qca8k_pcs(pcs)->priv;
1506 	int cpu_port_index, ret, port;
1507 	u32 reg, val;
1508 
1509 	port = pcs_to_qca8k_pcs(pcs)->port;
1510 	switch (port) {
1511 	case 0:
1512 		reg = QCA8K_REG_PORT0_PAD_CTRL;
1513 		cpu_port_index = QCA8K_CPU_PORT0;
1514 		break;
1515 
1516 	case 6:
1517 		reg = QCA8K_REG_PORT6_PAD_CTRL;
1518 		cpu_port_index = QCA8K_CPU_PORT6;
1519 		break;
1520 
1521 	default:
1522 		WARN_ON(1);
1523 		return -EINVAL;
1524 	}
1525 
1526 	/* Enable/disable SerDes auto-negotiation as necessary */
1527 	val = neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED ?
1528 		0 : QCA8K_PWS_SERDES_AEN_DIS;
1529 
1530 	ret = qca8k_rmw(priv, QCA8K_REG_PWS, QCA8K_PWS_SERDES_AEN_DIS, val);
1531 	if (ret)
1532 		return ret;
1533 
1534 	/* Configure the SGMII parameters */
1535 	ret = qca8k_read(priv, QCA8K_REG_SGMII_CTRL, &val);
1536 	if (ret)
1537 		return ret;
1538 
1539 	val |= QCA8K_SGMII_EN_SD;
1540 
1541 	if (priv->ports_config.sgmii_enable_pll)
1542 		val |= QCA8K_SGMII_EN_PLL | QCA8K_SGMII_EN_RX |
1543 		       QCA8K_SGMII_EN_TX;
1544 
1545 	if (dsa_is_cpu_port(priv->ds, port)) {
1546 		/* CPU port, we're talking to the CPU MAC, be a PHY */
1547 		val &= ~QCA8K_SGMII_MODE_CTRL_MASK;
1548 		val |= QCA8K_SGMII_MODE_CTRL_PHY;
1549 	} else if (interface == PHY_INTERFACE_MODE_SGMII) {
1550 		val &= ~QCA8K_SGMII_MODE_CTRL_MASK;
1551 		val |= QCA8K_SGMII_MODE_CTRL_MAC;
1552 	} else if (interface == PHY_INTERFACE_MODE_1000BASEX) {
1553 		val &= ~QCA8K_SGMII_MODE_CTRL_MASK;
1554 		val |= QCA8K_SGMII_MODE_CTRL_BASEX;
1555 	}
1556 
1557 	qca8k_write(priv, QCA8K_REG_SGMII_CTRL, val);
1558 
1559 	/* From original code is reported port instability as SGMII also
1560 	 * require delay set. Apply advised values here or take them from DT.
1561 	 */
1562 	if (interface == PHY_INTERFACE_MODE_SGMII)
1563 		qca8k_mac_config_setup_internal_delay(priv, cpu_port_index, reg);
1564 	/* For qca8327/qca8328/qca8334/qca8338 sgmii is unique and
1565 	 * falling edge is set writing in the PORT0 PAD reg
1566 	 */
1567 	if (priv->switch_id == QCA8K_ID_QCA8327 ||
1568 	    priv->switch_id == QCA8K_ID_QCA8337)
1569 		reg = QCA8K_REG_PORT0_PAD_CTRL;
1570 
1571 	val = 0;
1572 
1573 	/* SGMII Clock phase configuration */
1574 	if (priv->ports_config.sgmii_rx_clk_falling_edge)
1575 		val |= QCA8K_PORT0_PAD_SGMII_RXCLK_FALLING_EDGE;
1576 
1577 	if (priv->ports_config.sgmii_tx_clk_falling_edge)
1578 		val |= QCA8K_PORT0_PAD_SGMII_TXCLK_FALLING_EDGE;
1579 
1580 	if (val)
1581 		ret = qca8k_rmw(priv, reg,
1582 				QCA8K_PORT0_PAD_SGMII_RXCLK_FALLING_EDGE |
1583 				QCA8K_PORT0_PAD_SGMII_TXCLK_FALLING_EDGE,
1584 				val);
1585 
1586 	return 0;
1587 }
1588 
1589 static void qca8k_pcs_an_restart(struct phylink_pcs *pcs)
1590 {
1591 }
1592 
1593 static const struct phylink_pcs_ops qca8k_pcs_ops = {
1594 	.pcs_get_state = qca8k_pcs_get_state,
1595 	.pcs_config = qca8k_pcs_config,
1596 	.pcs_an_restart = qca8k_pcs_an_restart,
1597 };
1598 
1599 static void qca8k_setup_pcs(struct qca8k_priv *priv, struct qca8k_pcs *qpcs,
1600 			    int port)
1601 {
1602 	qpcs->pcs.ops = &qca8k_pcs_ops;
1603 	qpcs->pcs.neg_mode = true;
1604 
1605 	/* We don't have interrupts for link changes, so we need to poll */
1606 	qpcs->pcs.poll = true;
1607 	qpcs->priv = priv;
1608 	qpcs->port = port;
1609 }
1610 
1611 static void qca8k_mib_autocast_handler(struct dsa_switch *ds, struct sk_buff *skb)
1612 {
1613 	struct qca8k_mib_eth_data *mib_eth_data;
1614 	struct qca8k_priv *priv = ds->priv;
1615 	const struct qca8k_mib_desc *mib;
1616 	struct mib_ethhdr *mib_ethhdr;
1617 	__le32 *data2;
1618 	u8 port;
1619 	int i;
1620 
1621 	mib_ethhdr = (struct mib_ethhdr *)skb_mac_header(skb);
1622 	mib_eth_data = &priv->mib_eth_data;
1623 
1624 	/* The switch autocast every port. Ignore other packet and
1625 	 * parse only the requested one.
1626 	 */
1627 	port = FIELD_GET(QCA_HDR_RECV_SOURCE_PORT, ntohs(mib_ethhdr->hdr));
1628 	if (port != mib_eth_data->req_port)
1629 		goto exit;
1630 
1631 	data2 = (__le32 *)skb->data;
1632 
1633 	for (i = 0; i < priv->info->mib_count; i++) {
1634 		mib = &ar8327_mib[i];
1635 
1636 		/* First 3 mib are present in the skb head */
1637 		if (i < 3) {
1638 			mib_eth_data->data[i] = get_unaligned_le32(mib_ethhdr->data + i);
1639 			continue;
1640 		}
1641 
1642 		/* Some mib are 64 bit wide */
1643 		if (mib->size == 2)
1644 			mib_eth_data->data[i] = get_unaligned_le64((__le64 *)data2);
1645 		else
1646 			mib_eth_data->data[i] = get_unaligned_le32(data2);
1647 
1648 		data2 += mib->size;
1649 	}
1650 
1651 exit:
1652 	/* Complete on receiving all the mib packet */
1653 	if (refcount_dec_and_test(&mib_eth_data->port_parsed))
1654 		complete(&mib_eth_data->rw_done);
1655 }
1656 
1657 static int
1658 qca8k_get_ethtool_stats_eth(struct dsa_switch *ds, int port, u64 *data)
1659 {
1660 	struct dsa_port *dp = dsa_to_port(ds, port);
1661 	struct qca8k_mib_eth_data *mib_eth_data;
1662 	struct qca8k_priv *priv = ds->priv;
1663 	int ret;
1664 
1665 	mib_eth_data = &priv->mib_eth_data;
1666 
1667 	mutex_lock(&mib_eth_data->mutex);
1668 
1669 	reinit_completion(&mib_eth_data->rw_done);
1670 
1671 	mib_eth_data->req_port = dp->index;
1672 	mib_eth_data->data = data;
1673 	refcount_set(&mib_eth_data->port_parsed, QCA8K_NUM_PORTS);
1674 
1675 	mutex_lock(&priv->reg_mutex);
1676 
1677 	/* Send mib autocast request */
1678 	ret = regmap_update_bits(priv->regmap, QCA8K_REG_MIB,
1679 				 QCA8K_MIB_FUNC | QCA8K_MIB_BUSY,
1680 				 FIELD_PREP(QCA8K_MIB_FUNC, QCA8K_MIB_CAST) |
1681 				 QCA8K_MIB_BUSY);
1682 
1683 	mutex_unlock(&priv->reg_mutex);
1684 
1685 	if (ret)
1686 		goto exit;
1687 
1688 	ret = wait_for_completion_timeout(&mib_eth_data->rw_done, QCA8K_ETHERNET_TIMEOUT);
1689 
1690 exit:
1691 	mutex_unlock(&mib_eth_data->mutex);
1692 
1693 	return ret;
1694 }
1695 
1696 static u32 qca8k_get_phy_flags(struct dsa_switch *ds, int port)
1697 {
1698 	struct qca8k_priv *priv = ds->priv;
1699 
1700 	/* Communicate to the phy internal driver the switch revision.
1701 	 * Based on the switch revision different values needs to be
1702 	 * set to the dbg and mmd reg on the phy.
1703 	 * The first 2 bit are used to communicate the switch revision
1704 	 * to the phy driver.
1705 	 */
1706 	if (port > 0 && port < 6)
1707 		return priv->switch_revision;
1708 
1709 	return 0;
1710 }
1711 
1712 static enum dsa_tag_protocol
1713 qca8k_get_tag_protocol(struct dsa_switch *ds, int port,
1714 		       enum dsa_tag_protocol mp)
1715 {
1716 	return DSA_TAG_PROTO_QCA;
1717 }
1718 
1719 static void
1720 qca8k_master_change(struct dsa_switch *ds, const struct net_device *master,
1721 		    bool operational)
1722 {
1723 	struct dsa_port *dp = master->dsa_ptr;
1724 	struct qca8k_priv *priv = ds->priv;
1725 
1726 	/* Ethernet MIB/MDIO is only supported for CPU port 0 */
1727 	if (dp->index != 0)
1728 		return;
1729 
1730 	mutex_lock(&priv->mgmt_eth_data.mutex);
1731 	mutex_lock(&priv->mib_eth_data.mutex);
1732 
1733 	priv->mgmt_master = operational ? (struct net_device *)master : NULL;
1734 
1735 	mutex_unlock(&priv->mib_eth_data.mutex);
1736 	mutex_unlock(&priv->mgmt_eth_data.mutex);
1737 }
1738 
1739 static int qca8k_connect_tag_protocol(struct dsa_switch *ds,
1740 				      enum dsa_tag_protocol proto)
1741 {
1742 	struct qca_tagger_data *tagger_data;
1743 
1744 	switch (proto) {
1745 	case DSA_TAG_PROTO_QCA:
1746 		tagger_data = ds->tagger_data;
1747 
1748 		tagger_data->rw_reg_ack_handler = qca8k_rw_reg_ack_handler;
1749 		tagger_data->mib_autocast_handler = qca8k_mib_autocast_handler;
1750 
1751 		break;
1752 	default:
1753 		return -EOPNOTSUPP;
1754 	}
1755 
1756 	return 0;
1757 }
1758 
1759 static void qca8k_setup_hol_fixup(struct qca8k_priv *priv, int port)
1760 {
1761 	u32 mask;
1762 
1763 	switch (port) {
1764 	/* The 2 CPU port and port 5 requires some different
1765 	 * priority than any other ports.
1766 	 */
1767 	case 0:
1768 	case 5:
1769 	case 6:
1770 		mask = QCA8K_PORT_HOL_CTRL0_EG_PRI0(0x3) |
1771 			QCA8K_PORT_HOL_CTRL0_EG_PRI1(0x4) |
1772 			QCA8K_PORT_HOL_CTRL0_EG_PRI2(0x4) |
1773 			QCA8K_PORT_HOL_CTRL0_EG_PRI3(0x4) |
1774 			QCA8K_PORT_HOL_CTRL0_EG_PRI4(0x6) |
1775 			QCA8K_PORT_HOL_CTRL0_EG_PRI5(0x8) |
1776 			QCA8K_PORT_HOL_CTRL0_EG_PORT(0x1e);
1777 		break;
1778 	default:
1779 		mask = QCA8K_PORT_HOL_CTRL0_EG_PRI0(0x3) |
1780 			QCA8K_PORT_HOL_CTRL0_EG_PRI1(0x4) |
1781 			QCA8K_PORT_HOL_CTRL0_EG_PRI2(0x6) |
1782 			QCA8K_PORT_HOL_CTRL0_EG_PRI3(0x8) |
1783 			QCA8K_PORT_HOL_CTRL0_EG_PORT(0x19);
1784 	}
1785 	regmap_write(priv->regmap, QCA8K_REG_PORT_HOL_CTRL0(port), mask);
1786 
1787 	mask = QCA8K_PORT_HOL_CTRL1_ING(0x6) |
1788 	       QCA8K_PORT_HOL_CTRL1_EG_PRI_BUF_EN |
1789 	       QCA8K_PORT_HOL_CTRL1_EG_PORT_BUF_EN |
1790 	       QCA8K_PORT_HOL_CTRL1_WRED_EN;
1791 	regmap_update_bits(priv->regmap, QCA8K_REG_PORT_HOL_CTRL1(port),
1792 			   QCA8K_PORT_HOL_CTRL1_ING_BUF_MASK |
1793 			   QCA8K_PORT_HOL_CTRL1_EG_PRI_BUF_EN |
1794 			   QCA8K_PORT_HOL_CTRL1_EG_PORT_BUF_EN |
1795 			   QCA8K_PORT_HOL_CTRL1_WRED_EN,
1796 			   mask);
1797 }
1798 
1799 static int
1800 qca8k_setup(struct dsa_switch *ds)
1801 {
1802 	struct qca8k_priv *priv = ds->priv;
1803 	struct dsa_port *dp;
1804 	int cpu_port, ret;
1805 	u32 mask;
1806 
1807 	cpu_port = qca8k_find_cpu_port(ds);
1808 	if (cpu_port < 0) {
1809 		dev_err(priv->dev, "No cpu port configured in both cpu port0 and port6");
1810 		return cpu_port;
1811 	}
1812 
1813 	/* Parse CPU port config to be later used in phy_link mac_config */
1814 	ret = qca8k_parse_port_config(priv);
1815 	if (ret)
1816 		return ret;
1817 
1818 	ret = qca8k_setup_mdio_bus(priv);
1819 	if (ret)
1820 		return ret;
1821 
1822 	ret = qca8k_setup_of_pws_reg(priv);
1823 	if (ret)
1824 		return ret;
1825 
1826 	ret = qca8k_setup_mac_pwr_sel(priv);
1827 	if (ret)
1828 		return ret;
1829 
1830 	ret = qca8k_setup_led_ctrl(priv);
1831 	if (ret)
1832 		return ret;
1833 
1834 	qca8k_setup_pcs(priv, &priv->pcs_port_0, 0);
1835 	qca8k_setup_pcs(priv, &priv->pcs_port_6, 6);
1836 
1837 	/* Make sure MAC06 is disabled */
1838 	ret = regmap_clear_bits(priv->regmap, QCA8K_REG_PORT0_PAD_CTRL,
1839 				QCA8K_PORT0_PAD_MAC06_EXCHANGE_EN);
1840 	if (ret) {
1841 		dev_err(priv->dev, "failed disabling MAC06 exchange");
1842 		return ret;
1843 	}
1844 
1845 	/* Enable CPU Port */
1846 	ret = regmap_set_bits(priv->regmap, QCA8K_REG_GLOBAL_FW_CTRL0,
1847 			      QCA8K_GLOBAL_FW_CTRL0_CPU_PORT_EN);
1848 	if (ret) {
1849 		dev_err(priv->dev, "failed enabling CPU port");
1850 		return ret;
1851 	}
1852 
1853 	/* Enable MIB counters */
1854 	ret = qca8k_mib_init(priv);
1855 	if (ret)
1856 		dev_warn(priv->dev, "mib init failed");
1857 
1858 	/* Initial setup of all ports */
1859 	dsa_switch_for_each_port(dp, ds) {
1860 		/* Disable forwarding by default on all ports */
1861 		ret = qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(dp->index),
1862 				QCA8K_PORT_LOOKUP_MEMBER, 0);
1863 		if (ret)
1864 			return ret;
1865 	}
1866 
1867 	/* Disable MAC by default on all user ports */
1868 	dsa_switch_for_each_user_port(dp, ds)
1869 		qca8k_port_set_status(priv, dp->index, 0);
1870 
1871 	/* Enable QCA header mode on all cpu ports */
1872 	dsa_switch_for_each_cpu_port(dp, ds) {
1873 		ret = qca8k_write(priv, QCA8K_REG_PORT_HDR_CTRL(dp->index),
1874 				  FIELD_PREP(QCA8K_PORT_HDR_CTRL_TX_MASK, QCA8K_PORT_HDR_CTRL_ALL) |
1875 				  FIELD_PREP(QCA8K_PORT_HDR_CTRL_RX_MASK, QCA8K_PORT_HDR_CTRL_ALL));
1876 		if (ret) {
1877 			dev_err(priv->dev, "failed enabling QCA header mode on port %d", dp->index);
1878 			return ret;
1879 		}
1880 	}
1881 
1882 	/* Forward all unknown frames to CPU port for Linux processing
1883 	 * Notice that in multi-cpu config only one port should be set
1884 	 * for igmp, unknown, multicast and broadcast packet
1885 	 */
1886 	ret = qca8k_write(priv, QCA8K_REG_GLOBAL_FW_CTRL1,
1887 			  FIELD_PREP(QCA8K_GLOBAL_FW_CTRL1_IGMP_DP_MASK, BIT(cpu_port)) |
1888 			  FIELD_PREP(QCA8K_GLOBAL_FW_CTRL1_BC_DP_MASK, BIT(cpu_port)) |
1889 			  FIELD_PREP(QCA8K_GLOBAL_FW_CTRL1_MC_DP_MASK, BIT(cpu_port)) |
1890 			  FIELD_PREP(QCA8K_GLOBAL_FW_CTRL1_UC_DP_MASK, BIT(cpu_port)));
1891 	if (ret)
1892 		return ret;
1893 
1894 	/* CPU port gets connected to all user ports of the switch */
1895 	ret = qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(cpu_port),
1896 			QCA8K_PORT_LOOKUP_MEMBER, dsa_user_ports(ds));
1897 	if (ret)
1898 		return ret;
1899 
1900 	/* Setup connection between CPU port & user ports
1901 	 * Individual user ports get connected to CPU port only
1902 	 */
1903 	dsa_switch_for_each_user_port(dp, ds) {
1904 		u8 port = dp->index;
1905 
1906 		ret = qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(port),
1907 				QCA8K_PORT_LOOKUP_MEMBER,
1908 				BIT(cpu_port));
1909 		if (ret)
1910 			return ret;
1911 
1912 		ret = regmap_clear_bits(priv->regmap, QCA8K_PORT_LOOKUP_CTRL(port),
1913 					QCA8K_PORT_LOOKUP_LEARN);
1914 		if (ret)
1915 			return ret;
1916 
1917 		/* For port based vlans to work we need to set the
1918 		 * default egress vid
1919 		 */
1920 		ret = qca8k_rmw(priv, QCA8K_EGRESS_VLAN(port),
1921 				QCA8K_EGREES_VLAN_PORT_MASK(port),
1922 				QCA8K_EGREES_VLAN_PORT(port, QCA8K_PORT_VID_DEF));
1923 		if (ret)
1924 			return ret;
1925 
1926 		ret = qca8k_write(priv, QCA8K_REG_PORT_VLAN_CTRL0(port),
1927 				  QCA8K_PORT_VLAN_CVID(QCA8K_PORT_VID_DEF) |
1928 				  QCA8K_PORT_VLAN_SVID(QCA8K_PORT_VID_DEF));
1929 		if (ret)
1930 			return ret;
1931 	}
1932 
1933 	/* The port 5 of the qca8337 have some problem in flood condition. The
1934 	 * original legacy driver had some specific buffer and priority settings
1935 	 * for the different port suggested by the QCA switch team. Add this
1936 	 * missing settings to improve switch stability under load condition.
1937 	 * This problem is limited to qca8337 and other qca8k switch are not affected.
1938 	 */
1939 	if (priv->switch_id == QCA8K_ID_QCA8337)
1940 		dsa_switch_for_each_available_port(dp, ds)
1941 			qca8k_setup_hol_fixup(priv, dp->index);
1942 
1943 	/* Special GLOBAL_FC_THRESH value are needed for ar8327 switch */
1944 	if (priv->switch_id == QCA8K_ID_QCA8327) {
1945 		mask = QCA8K_GLOBAL_FC_GOL_XON_THRES(288) |
1946 		       QCA8K_GLOBAL_FC_GOL_XOFF_THRES(496);
1947 		qca8k_rmw(priv, QCA8K_REG_GLOBAL_FC_THRESH,
1948 			  QCA8K_GLOBAL_FC_GOL_XON_THRES_MASK |
1949 			  QCA8K_GLOBAL_FC_GOL_XOFF_THRES_MASK,
1950 			  mask);
1951 	}
1952 
1953 	/* Setup our port MTUs to match power on defaults */
1954 	ret = qca8k_write(priv, QCA8K_MAX_FRAME_SIZE, ETH_FRAME_LEN + ETH_FCS_LEN);
1955 	if (ret)
1956 		dev_warn(priv->dev, "failed setting MTU settings");
1957 
1958 	/* Flush the FDB table */
1959 	qca8k_fdb_flush(priv);
1960 
1961 	/* Set min a max ageing value supported */
1962 	ds->ageing_time_min = 7000;
1963 	ds->ageing_time_max = 458745000;
1964 
1965 	/* Set max number of LAGs supported */
1966 	ds->num_lag_ids = QCA8K_NUM_LAGS;
1967 
1968 	return 0;
1969 }
1970 
1971 static const struct dsa_switch_ops qca8k_switch_ops = {
1972 	.get_tag_protocol	= qca8k_get_tag_protocol,
1973 	.setup			= qca8k_setup,
1974 	.get_strings		= qca8k_get_strings,
1975 	.get_ethtool_stats	= qca8k_get_ethtool_stats,
1976 	.get_sset_count		= qca8k_get_sset_count,
1977 	.set_ageing_time	= qca8k_set_ageing_time,
1978 	.get_mac_eee		= qca8k_get_mac_eee,
1979 	.set_mac_eee		= qca8k_set_mac_eee,
1980 	.port_enable		= qca8k_port_enable,
1981 	.port_disable		= qca8k_port_disable,
1982 	.port_change_mtu	= qca8k_port_change_mtu,
1983 	.port_max_mtu		= qca8k_port_max_mtu,
1984 	.port_stp_state_set	= qca8k_port_stp_state_set,
1985 	.port_pre_bridge_flags	= qca8k_port_pre_bridge_flags,
1986 	.port_bridge_flags	= qca8k_port_bridge_flags,
1987 	.port_bridge_join	= qca8k_port_bridge_join,
1988 	.port_bridge_leave	= qca8k_port_bridge_leave,
1989 	.port_fast_age		= qca8k_port_fast_age,
1990 	.port_fdb_add		= qca8k_port_fdb_add,
1991 	.port_fdb_del		= qca8k_port_fdb_del,
1992 	.port_fdb_dump		= qca8k_port_fdb_dump,
1993 	.port_mdb_add		= qca8k_port_mdb_add,
1994 	.port_mdb_del		= qca8k_port_mdb_del,
1995 	.port_mirror_add	= qca8k_port_mirror_add,
1996 	.port_mirror_del	= qca8k_port_mirror_del,
1997 	.port_vlan_filtering	= qca8k_port_vlan_filtering,
1998 	.port_vlan_add		= qca8k_port_vlan_add,
1999 	.port_vlan_del		= qca8k_port_vlan_del,
2000 	.phylink_get_caps	= qca8k_phylink_get_caps,
2001 	.phylink_mac_select_pcs	= qca8k_phylink_mac_select_pcs,
2002 	.phylink_mac_config	= qca8k_phylink_mac_config,
2003 	.phylink_mac_link_down	= qca8k_phylink_mac_link_down,
2004 	.phylink_mac_link_up	= qca8k_phylink_mac_link_up,
2005 	.get_phy_flags		= qca8k_get_phy_flags,
2006 	.port_lag_join		= qca8k_port_lag_join,
2007 	.port_lag_leave		= qca8k_port_lag_leave,
2008 	.master_state_change	= qca8k_master_change,
2009 	.connect_tag_protocol	= qca8k_connect_tag_protocol,
2010 };
2011 
2012 static int
2013 qca8k_sw_probe(struct mdio_device *mdiodev)
2014 {
2015 	struct qca8k_priv *priv;
2016 	int ret;
2017 
2018 	/* allocate the private data struct so that we can probe the switches
2019 	 * ID register
2020 	 */
2021 	priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv), GFP_KERNEL);
2022 	if (!priv)
2023 		return -ENOMEM;
2024 
2025 	priv->bus = mdiodev->bus;
2026 	priv->dev = &mdiodev->dev;
2027 	priv->info = of_device_get_match_data(priv->dev);
2028 
2029 	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
2030 						   GPIOD_ASIS);
2031 	if (IS_ERR(priv->reset_gpio))
2032 		return PTR_ERR(priv->reset_gpio);
2033 
2034 	if (priv->reset_gpio) {
2035 		gpiod_set_value_cansleep(priv->reset_gpio, 1);
2036 		/* The active low duration must be greater than 10 ms
2037 		 * and checkpatch.pl wants 20 ms.
2038 		 */
2039 		msleep(20);
2040 		gpiod_set_value_cansleep(priv->reset_gpio, 0);
2041 	}
2042 
2043 	/* Start by setting up the register mapping */
2044 	priv->regmap = devm_regmap_init(&mdiodev->dev, NULL, priv,
2045 					&qca8k_regmap_config);
2046 	if (IS_ERR(priv->regmap)) {
2047 		dev_err(priv->dev, "regmap initialization failed");
2048 		return PTR_ERR(priv->regmap);
2049 	}
2050 
2051 	priv->mdio_cache.page = 0xffff;
2052 
2053 	/* Check the detected switch id */
2054 	ret = qca8k_read_switch_id(priv);
2055 	if (ret)
2056 		return ret;
2057 
2058 	priv->ds = devm_kzalloc(&mdiodev->dev, sizeof(*priv->ds), GFP_KERNEL);
2059 	if (!priv->ds)
2060 		return -ENOMEM;
2061 
2062 	mutex_init(&priv->mgmt_eth_data.mutex);
2063 	init_completion(&priv->mgmt_eth_data.rw_done);
2064 
2065 	mutex_init(&priv->mib_eth_data.mutex);
2066 	init_completion(&priv->mib_eth_data.rw_done);
2067 
2068 	priv->ds->dev = &mdiodev->dev;
2069 	priv->ds->num_ports = QCA8K_NUM_PORTS;
2070 	priv->ds->priv = priv;
2071 	priv->ds->ops = &qca8k_switch_ops;
2072 	mutex_init(&priv->reg_mutex);
2073 	dev_set_drvdata(&mdiodev->dev, priv);
2074 
2075 	return dsa_register_switch(priv->ds);
2076 }
2077 
2078 static void
2079 qca8k_sw_remove(struct mdio_device *mdiodev)
2080 {
2081 	struct qca8k_priv *priv = dev_get_drvdata(&mdiodev->dev);
2082 	int i;
2083 
2084 	if (!priv)
2085 		return;
2086 
2087 	for (i = 0; i < QCA8K_NUM_PORTS; i++)
2088 		qca8k_port_set_status(priv, i, 0);
2089 
2090 	dsa_unregister_switch(priv->ds);
2091 }
2092 
2093 static void qca8k_sw_shutdown(struct mdio_device *mdiodev)
2094 {
2095 	struct qca8k_priv *priv = dev_get_drvdata(&mdiodev->dev);
2096 
2097 	if (!priv)
2098 		return;
2099 
2100 	dsa_switch_shutdown(priv->ds);
2101 
2102 	dev_set_drvdata(&mdiodev->dev, NULL);
2103 }
2104 
2105 #ifdef CONFIG_PM_SLEEP
2106 static void
2107 qca8k_set_pm(struct qca8k_priv *priv, int enable)
2108 {
2109 	int port;
2110 
2111 	for (port = 0; port < QCA8K_NUM_PORTS; port++) {
2112 		/* Do not enable on resume if the port was
2113 		 * disabled before.
2114 		 */
2115 		if (!(priv->port_enabled_map & BIT(port)))
2116 			continue;
2117 
2118 		qca8k_port_set_status(priv, port, enable);
2119 	}
2120 }
2121 
2122 static int qca8k_suspend(struct device *dev)
2123 {
2124 	struct qca8k_priv *priv = dev_get_drvdata(dev);
2125 
2126 	qca8k_set_pm(priv, 0);
2127 
2128 	return dsa_switch_suspend(priv->ds);
2129 }
2130 
2131 static int qca8k_resume(struct device *dev)
2132 {
2133 	struct qca8k_priv *priv = dev_get_drvdata(dev);
2134 
2135 	qca8k_set_pm(priv, 1);
2136 
2137 	return dsa_switch_resume(priv->ds);
2138 }
2139 #endif /* CONFIG_PM_SLEEP */
2140 
2141 static SIMPLE_DEV_PM_OPS(qca8k_pm_ops,
2142 			 qca8k_suspend, qca8k_resume);
2143 
2144 static const struct qca8k_info_ops qca8xxx_ops = {
2145 	.autocast_mib = qca8k_get_ethtool_stats_eth,
2146 };
2147 
2148 static const struct qca8k_match_data qca8327 = {
2149 	.id = QCA8K_ID_QCA8327,
2150 	.reduced_package = true,
2151 	.mib_count = QCA8K_QCA832X_MIB_COUNT,
2152 	.ops = &qca8xxx_ops,
2153 };
2154 
2155 static const struct qca8k_match_data qca8328 = {
2156 	.id = QCA8K_ID_QCA8327,
2157 	.mib_count = QCA8K_QCA832X_MIB_COUNT,
2158 	.ops = &qca8xxx_ops,
2159 };
2160 
2161 static const struct qca8k_match_data qca833x = {
2162 	.id = QCA8K_ID_QCA8337,
2163 	.mib_count = QCA8K_QCA833X_MIB_COUNT,
2164 	.ops = &qca8xxx_ops,
2165 };
2166 
2167 static const struct of_device_id qca8k_of_match[] = {
2168 	{ .compatible = "qca,qca8327", .data = &qca8327 },
2169 	{ .compatible = "qca,qca8328", .data = &qca8328 },
2170 	{ .compatible = "qca,qca8334", .data = &qca833x },
2171 	{ .compatible = "qca,qca8337", .data = &qca833x },
2172 	{ /* sentinel */ },
2173 };
2174 
2175 static struct mdio_driver qca8kmdio_driver = {
2176 	.probe  = qca8k_sw_probe,
2177 	.remove = qca8k_sw_remove,
2178 	.shutdown = qca8k_sw_shutdown,
2179 	.mdiodrv.driver = {
2180 		.name = "qca8k",
2181 		.of_match_table = qca8k_of_match,
2182 		.pm = &qca8k_pm_ops,
2183 	},
2184 };
2185 
2186 mdio_module_driver(qca8kmdio_driver);
2187 
2188 MODULE_AUTHOR("Mathieu Olivari, John Crispin <john@phrozen.org>");
2189 MODULE_DESCRIPTION("Driver for QCA8K ethernet switch family");
2190 MODULE_LICENSE("GPL v2");
2191 MODULE_ALIAS("platform:qca8k");
2192